]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
os/bluestore: fix bluefs migrate command 43100/head
authorIgor Fedotov <ifedotov@suse.com>
Tue, 31 Aug 2021 12:54:23 +0000 (15:54 +0300)
committerIgor Fedotov <ifedotov@suse.com>
Wed, 8 Sep 2021 17:04:31 +0000 (20:04 +0300)
After migrating DB volume to a slow one RocksDB still
needs to be provided with slow.db path to properly access relevant files under db.slow subfolder.
Without that specification it tries to access them under 'db' one which
results in "not-found" error.

Fixes: https://tracker.ceph.com/issues/40434
Signed-off-by: Igor Fedotov <ifedotov@suse.com>
(cherry picked from commit 90852d9b6f0da7967121200c9a1c56bed1929d2d)

src/os/bluestore/BlueFS.cc
src/os/bluestore/BlueStore.cc

index 2ddfbbed0f28fbdb4c3973266a2204565773f936..16b64636b891e48abfc9c202d352f0c4b60d0628 100644 (file)
@@ -3837,7 +3837,9 @@ uint8_t OriginalVolumeSelector::select_prefer_bdev(void* hint)
 void OriginalVolumeSelector::get_paths(const std::string& base, paths& res) const
 {
   res.emplace_back(base, db_total);
-  res.emplace_back(base + ".slow", slow_total);
+  res.emplace_back(base + ".slow",
+    slow_total ? slow_total : db_total); // use fake non-zero value if needed to
+                                         // avoid RocksDB complains
 }
 
 #undef dout_prefix
index e74343cdfd015d76d70c7c2c0452e14bae161b43..ba52666a011df68e89055e552921dd045a9ee488 100644 (file)
@@ -6021,9 +6021,7 @@ int BlueStore::_prepare_db_environment(bool create, bool read_only,
     BlueFSVolumeSelector::paths paths;
     bluefs->get_vselector_paths(fn, paths);
 
-    if (bluefs_layout.shared_bdev == BlueFS::BDEV_SLOW) {
-      // we have both block.db and block; tell rocksdb!
-      // note: the second (last) size value doesn't really matter
+    {
       ostringstream db_paths;
       bool first = true;
       for (auto& p : paths) {