]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
librbd/AsyncResize: avoid dup incrementing refresh seq 4325/head
authorZhiqiang Wang <zhiqiang.wang@intel.com>
Fri, 10 Apr 2015 05:44:07 +0000 (13:44 +0800)
committerZhiqiang Wang <zhiqiang.wang@intel.com>
Fri, 10 Apr 2015 05:44:07 +0000 (13:44 +0800)
The refresh_seq is incremented in notify_change when calling
notify_async_complete after the locker owner completes the resize
request.

Signed-off-by: Zhiqiang Wang <zhiqiang.wang@intel.com>
src/librbd/AsyncResizeRequest.cc
src/librbd/AsyncResizeRequest.h

index 621d59d967d328799bc9343c78d0e3bc4038b81c..eda844cd47fce7a520e6058fcc9418a3a31e3c7c 100644 (file)
@@ -98,7 +98,6 @@ bool AsyncResizeRequest::should_complete(int r) {
     ldout(cct, 5) << "UPDATE_HEADER" << dendl;
     if (send_shrink_object_map()) {
       update_size_and_overlap();
-      increment_refresh_seq();
       return true;
     }
     break;
@@ -106,7 +105,6 @@ bool AsyncResizeRequest::should_complete(int r) {
   case STATE_SHRINK_OBJECT_MAP:
     ldout(cct, 5) << "SHRINK_OBJECT_MAP" << dendl;
     update_size_and_overlap();
-    increment_refresh_seq();
     return true;
 
   case STATE_FINISHED:
@@ -301,12 +299,6 @@ void AsyncResizeRequest::compute_parent_overlap() {
   }
 }
 
-void AsyncResizeRequest::increment_refresh_seq() {
-  m_image_ctx.refresh_lock.Lock();
-  ++m_image_ctx.refresh_seq;
-  m_image_ctx.refresh_lock.Unlock();
-}
-
 void AsyncResizeRequest::update_size_and_overlap() {
   RWLock::WLocker snap_locker(m_image_ctx.snap_lock);
   m_image_ctx.size = m_new_size;
index 277b39d2d7680e06b75349bffa7b5aaf0e6e1e44..61f1dd52586f5833beff7f41cc74da90595cfd81 100644 (file)
@@ -97,7 +97,6 @@ private:
   void send_update_header();
 
   void compute_parent_overlap();
-  void increment_refresh_seq();
   void update_size_and_overlap();
 
 };