]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
crimson/osd: comment on `dispatched` in OSD::ms_dispatch() 47279/head
authorRadoslaw Zarzynski <rzarzyns@redhat.com>
Tue, 26 Jul 2022 12:46:01 +0000 (12:46 +0000)
committerRadoslaw Zarzynski <rzarzyns@redhat.com>
Tue, 26 Jul 2022 13:08:12 +0000 (13:08 +0000)
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
src/crimson/osd/osd.cc

index 7a3612a011ac82b33e6a03ea8f76f7e9753bb173..4ad6ca55bebfed45ba1b643d1c57b9f569bac071 100644 (file)
@@ -669,6 +669,9 @@ OSD::ms_dispatch(crimson::net::ConnectionRef conn, MessageRef m)
   if (pg_shard_manager.is_stopping()) {
     return {};
   }
+  // XXX: we're assuming the `switch` part is executed immediately, and thus
+  // we won't smash the stack. Taking into account how `seastar::with_gate`
+  // is currently implemented, this seems to be the case (Summer 2022).
   bool dispatched = true;
   gate.dispatch_in_background(__func__, *this, [this, conn=std::move(conn),
                                                 m=std::move(m), &dispatched] {