]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
crimson/.../replicated_request,logmissing_request: retain reference to req 48350/head
authorSamuel Just <sjust@redhat.com>
Wed, 28 Sep 2022 23:36:46 +0000 (23:36 +0000)
committerSamuel Just <sjust@redhat.com>
Sat, 1 Oct 2022 21:35:55 +0000 (14:35 -0700)
Otherwise, operator<< and dump_detail would need to accessing req after
the call to handle_rep_op.

Fixes: https://tracker.ceph.com/issues/57739
Signed-off-by: Samuel Just <sjust@redhat.com>
src/crimson/osd/osd_operations/logmissing_request.cc
src/crimson/osd/osd_operations/replicated_request.cc

index 84efcfa9f6a599d1ddc5f04259e53bc1b6b7e82f..0b6df5a37c8822c162038951e7c0dd1e09f4ae6d 100644 (file)
@@ -61,7 +61,7 @@ seastar::future<> LogMissingRequest::with_pg(
 
   IRef ref = this;
   return interruptor::with_interruption([this, pg] {
-    return pg->do_update_log_missing(std::move(req));
+    return pg->do_update_log_missing(req);
   }, [ref](std::exception_ptr) { return seastar::now(); }, pg);
 }
 
index d93e4035ed0f5d0ce572c966e746cf2068bbf614..ac197d8ae7ce636a50aa5897b9bdb5586e317048 100644 (file)
@@ -61,7 +61,7 @@ seastar::future<> RepRequest::with_pg(
 
   IRef ref = this;
   return interruptor::with_interruption([this, pg] {
-    return pg->handle_rep_op(std::move(req));
+    return pg->handle_rep_op(req);
   }, [ref](std::exception_ptr) { return seastar::now(); }, pg);
 }