]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
rgw: initialize RGWIndexCompletionManager thread after related members 49093/head
authorCasey Bodley <cbodley@redhat.com>
Mon, 7 Mar 2022 20:10:07 +0000 (15:10 -0500)
committerCory Snyder <csnyder@1111systems.com>
Thu, 7 Dec 2023 09:38:46 +0000 (04:38 -0500)
resolves valgrind issues about RGWIndexCompletionManager::process()
using uninitialized memory

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 112c2608750cf8db2c52c8e89f5897080501f6bd)

src/rgw/rgw_rados.cc

index ab98b5ffa21c6a41aa2a4198a501f963c724cf2d..2885a4af02f946389d8f2fac2442f5032aba3339 100644 (file)
@@ -795,11 +795,10 @@ class RGWIndexCompletionManager {
   std::vector<set<complete_op_data*>> completions;
   std::vector<complete_op_data*> retry_completions;
 
-  std::thread retry_thread;
   std::condition_variable cond;
   std::mutex retry_completions_lock;
-
   bool _stop{false};
+  std::thread retry_thread;
 
   std::atomic<int> cur_shard {0};