]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
cephadm: don't overwrite cluster logrotate file 49927/head
authorAdam King <adking@redhat.com>
Fri, 20 Jan 2023 18:42:00 +0000 (13:42 -0500)
committerAdam King <adking@redhat.com>
Mon, 30 Jan 2023 23:31:08 +0000 (18:31 -0500)
To allow users to customize the file if they need to
akter the settings (e.g. to change the rotation interval
or rotate based on size)

Fixes: https://tracker.ceph.com/issues/58527
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit f33dc8a17e7f5093b062022dacc72a1afc1a4d7a)

src/cephadm/cephadm

index d6965594669fca6a70648bbed9943d9a36f35adb..23e2b1bf873ed59c4517d0cd1b6bfe6aed11d63d 100755 (executable)
@@ -3427,6 +3427,10 @@ def install_base_units(ctx, fsid):
         call_throws(ctx, ['systemctl', 'enable', 'ceph-%s.target' % fsid])
         call_throws(ctx, ['systemctl', 'start', 'ceph-%s.target' % fsid])
 
+    # don't overwrite file in order to allow users to manipulate it
+    if os.path.exists(ctx.logrotate_dir + f'/ceph-{fsid}'):
+        return
+
     # logrotate for the cluster
     with open(ctx.logrotate_dir + '/ceph-%s' % fsid, 'w') as f:
         """