]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
crimson/osd/objclass: Compilation warning 51333/head
authorMatan Breizman <mbreizma@redhat.com>
Wed, 3 May 2023 09:39:14 +0000 (09:39 +0000)
committerMatan Breizman <mbreizma@redhat.com>
Wed, 3 May 2023 13:10:58 +0000 (13:10 +0000)
```
In copy constructor ‘ceph::buffer::v15_2_0::list::list(const ceph::buffer::v15_2_0::list&)’,
    inlined from ‘OSDOp::OSDOp(const OSDOp&)’ at ../src/osd/osd_types.h:4081:8,
    inlined from ‘int cls_cxx_snap_revert(cls_method_context_t, snapid_t)’ at ../src/crimson/osd/objclass.cc:279:37:
../src/include/buffer.h:945:20: warning: ‘op.OSDOp::indata.ceph::buffer::v15_2_0::list::_len’ is used uninitialized [-Wuninitialized]
  945 |         _len(other._len),
      |              ~~~~~~^~~~
../src/crimson/osd/objclass.cc: In function ‘int cls_cxx_snap_revert(cls_method_context_t, snapid_t)’:
../src/crimson/osd/objclass.cc:279:9: note: ‘op’ declared here
  279 |   OSDOp op{op = CEPH_OSD_OP_ROLLBACK};
      |
```

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
src/crimson/osd/objclass.cc

index d6d2e914a7b971cac9dab35f57fd9cf1dae9c904..4cc9d73369d674f676a0aa975de05e9439bc516c 100644 (file)
@@ -276,7 +276,7 @@ int cls_cxx_setxattr(cls_method_context_t hctx,
 
 int cls_cxx_snap_revert(cls_method_context_t hctx, snapid_t snapid)
 {
-  OSDOp op{op = CEPH_OSD_OP_ROLLBACK};
+  OSDOp op{CEPH_OSD_OP_ROLLBACK};
   op.op.snap.snapid = snapid;
   return execute_osd_op(hctx, op);
 }