]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
crimson/osd/osd_operations/client_request: Fix client blocklisting 51381/head
authorMatan Breizman <mbreizma@redhat.com>
Sun, 7 May 2023 13:29:22 +0000 (13:29 +0000)
committerMatan Breizman <mbreizma@redhat.com>
Sun, 7 May 2023 13:29:22 +0000 (13:29 +0000)
See #50835.
In crimson, conn is independently maintained outside Message.
Therefore, when trying to use the message's connection for `get_peer_addr()`
we won't be able to get the peer address.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
src/crimson/osd/osd_operations/client_request.cc

index d23a82ab0524379e340fb3700ecc2ba6539f1e15..9be2108bc9f071f03b1f9a1d0b6625e5d15906af 100644 (file)
@@ -272,8 +272,8 @@ ClientRequest::do_process(
     return reply_op_error(pg, -ENAMETOOLONG);
   } else if (m->get_hobj().oid.name.empty()) {
     return reply_op_error(pg, -EINVAL);
-  } else if (pg->get_osdmap()->is_blocklisted(m->get_source_addr())) {
-    logger().info("{} is blocklisted", m->get_source_addr());
+  } else if (pg->get_osdmap()->is_blocklisted(conn->get_peer_addr())) {
+    logger().info("{} is blocklisted", conn->get_peer_addr());
     return reply_op_error(pg, -EBLOCKLISTED);
   }