]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
crimson/os/seastore/transaction_manager: remove incorrect assertions 57660/head
authorXuehan Xu <xuxuehan@qianxin.com>
Mon, 29 Apr 2024 08:56:09 +0000 (16:56 +0800)
committerMatan Breizman <mbreizma@redhat.com>
Thu, 23 May 2024 14:09:59 +0000 (17:09 +0300)
Indirect mappings always hold the checksums of the corresponding intermediate
mappings, which may have non-zero

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
(cherry picked from commit fca8efca527f44db63df068751f9e6c8bdc939e2)

src/crimson/os/seastore/transaction_manager.h

index 6d99bd77ec2f08d952d2c7e6114432a4a974f307..c7e4121263a9002c9efdc1c2f3cac37daa03837f 100644 (file)
@@ -885,9 +885,7 @@ private:
        crc);
       assert(ref->is_fully_loaded());
       bool inconsistent = false;
-      if (pin->is_indirect()) {
-       inconsistent = (pin->get_checksum() != 0);
-      } else if (full_extent_integrity_check) {
+      if (full_extent_integrity_check) {
        inconsistent = (pin->get_checksum() != crc);
       } else { // !full_extent_integrity_check: remapped extent may be skipped
        inconsistent = !(pin->get_checksum() == 0 ||
@@ -953,9 +951,7 @@ private:
        crc);
       assert(ref->is_fully_loaded());
       bool inconsistent = false;
-      if (pin->is_indirect()) {
-       inconsistent = (pin->get_checksum() != 0);
-      } else if (full_extent_integrity_check) {
+      if (full_extent_integrity_check) {
        inconsistent = (pin->get_checksum() != crc);
       } else { // !full_extent_integrity_check: remapped extent may be skipped
        inconsistent = !(pin->get_checksum() == 0 ||