]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
crimson/osd: remove unnecessary named string for --smp value 68130/head
authorKefu Chai <k.chai@proxmox.com>
Sun, 29 Mar 2026 11:41:48 +0000 (19:41 +0800)
committerKefu Chai <k.chai@proxmox.com>
Tue, 31 Mar 2026 22:47:54 +0000 (06:47 +0800)
The local variable `smp` is used only in the two immediately following
statements. Inline the fmt::format() call into emplace_back() and pass
reactor_num directly to the logger.

Signed-off-by: Kefu Chai <k.chai@proxmox.com>
src/crimson/osd/main_config_bootstrap_helpers.cc

index 614e61773e38d6fc598c548aeb58178f2ece4072..b701247ae7ffc2deed83c683c0baf78ff2179b54 100644 (file)
@@ -224,13 +224,12 @@ _get_early_config(int argc, const char *argv[])
                             " or crimson_cpu_num must be set");
              ceph_abort();
            }
-           std::string smp = fmt::format("{}", reactor_num);
            ret.early_args.emplace_back("--smp");
-           ret.early_args.emplace_back(smp);
+           ret.early_args.emplace_back(fmt::format("{}", reactor_num));
            ret.early_args.emplace_back("--thread-affinity");
            ret.early_args.emplace_back("0");
            logger().info("get_early_config: set --thread-affinity 0 --smp {}",
-                         smp);
+                         reactor_num);
 
          }
        } else {