]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
common: unintended use of the wrong bloom_filter prototype 697/head
authorLoic Dachary <loic@dachary.org>
Mon, 7 Oct 2013 21:05:01 +0000 (23:05 +0200)
committerLoic Dachary <loic@dachary.org>
Mon, 7 Oct 2013 21:11:20 +0000 (23:11 +0200)
For encoding/decoding test purposes. The generate_test_instances should
be improved to cover more encoding/decoding cases.

Signed-off-by: Loic Dachary <loic@dachary.org>
src/common/bloom_filter.cc

index a1c20bf0c12c44dd819c7bbc70678435cf509339..68875e925bf6931975f8678561d2a312cdbb1a96 100644 (file)
@@ -66,11 +66,11 @@ void bloom_filter::dump(Formatter *f) const
 
 void bloom_filter::generate_test_instances(list<bloom_filter*>& ls)
 {
-  ls.push_back(new bloom_filter(10, .5, 1, 5));
-  ls.push_back(new bloom_filter(10, .5, 1, 5));
+  ls.push_back(new bloom_filter(10, .5, 1));
+  ls.push_back(new bloom_filter(10, .5, 1));
   ls.back()->insert("foo");
   ls.back()->insert("bar");
-  ls.push_back(new bloom_filter(50, .5, 1, 5));
+  ls.push_back(new bloom_filter(50, .5, 1));
   ls.back()->insert("foo");
   ls.back()->insert("bar");
   ls.back()->insert("baz");
@@ -123,11 +123,11 @@ void compressible_bloom_filter::dump(Formatter *f) const
 
 void compressible_bloom_filter::generate_test_instances(list<compressible_bloom_filter*>& ls)
 {
-  ls.push_back(new compressible_bloom_filter(10, .5, 1, 4));
-  ls.push_back(new compressible_bloom_filter(10, .5, 1, 4));
+  ls.push_back(new compressible_bloom_filter(10, .5, 1));
+  ls.push_back(new compressible_bloom_filter(10, .5, 1));
   ls.back()->insert("foo");
   ls.back()->insert("bar");
-  ls.push_back(new compressible_bloom_filter(50, .5, 1, 4));
+  ls.push_back(new compressible_bloom_filter(50, .5, 1));
   ls.back()->insert("foo");
   ls.back()->insert("bar");
   ls.back()->insert("baz");