]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
qa/workunits/rbd: use POSIX function definition 8068/head
authorNathan Cutler <ncutler@suse.com>
Sat, 12 Mar 2016 01:03:27 +0000 (02:03 +0100)
committerNathan Cutler <ncutler@suse.com>
Sat, 12 Mar 2016 01:03:27 +0000 (02:03 +0100)
In scripts with /bin/sh shebang, we must use POSIX function definitions to
avoid syntax errors on platforms that link /bin/sh to something other than
/bin/bash.

See https://wiki.ubuntu.com/DashAsBinSh#function for more information.

http://tracker.ceph.com/issues/15104 Fixes: #15104

Signed-off-by: Nathan Cutler <ncutler@suse.com>
qa/workunits/rbd/verify_pool.sh

index 73f1864214a63e46c84be2c80d573d9902f788d6..9033343f46f4b0ee40e2ba4d697a8cc1095ae467 100755 (executable)
@@ -3,11 +3,11 @@
 POOL_NAME=rbd_test_validate_pool
 PG_NUM=100
 
-function tear_down() {
+tear_down () {
   ceph osd pool delete $POOL_NAME $POOL_NAME --yes-i-really-really-mean-it || true
 }
 
-function set_up() {
+set_up () {
   tear_down
   ceph osd pool create $POOL_NAME $PG_NUM
   ceph osd pool mksnap $POOL_NAME snap