]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
3 years agolibrbd/crypto: fix memory leak in ShutDownCryptoRequest
Or Ozeri [Thu, 25 Nov 2021 13:47:54 +0000 (15:47 +0200)]
librbd/crypto: fix memory leak in ShutDownCryptoRequest

If crypto object dispatch does not exist, a context pointer is leaked.
This commit fixes this issue.

Signed-off-by: Or Ozeri <oro@il.ibm.com>
3 years agotest/librbd: fix memory leak in TestMockParentCacheObjectDispatch
Or Ozeri [Thu, 25 Nov 2021 13:45:00 +0000 (15:45 +0200)]
test/librbd: fix memory leak in TestMockParentCacheObjectDispatch

fix memory leak in TestMockParentCacheObjectDispatch.

Signed-off-by: Or Ozeri <oro@il.ibm.com>
3 years agotest/librbd: fix memory leak in TestMockCryptoLuksFormatRequest
Or Ozeri [Thu, 25 Nov 2021 13:44:09 +0000 (15:44 +0200)]
test/librbd: fix memory leak in TestMockCryptoLuksFormatRequest

fix memory leak in TestMockCryptoLuksFormatRequest.

Signed-off-by: Or Ozeri <oro@il.ibm.com>
3 years agotest/librbd: fix memory leak in TestMockCryptoLuksLoadRequest
Or Ozeri [Thu, 25 Nov 2021 13:42:22 +0000 (15:42 +0200)]
test/librbd: fix memory leak in TestMockCryptoLuksLoadRequest

fix memory leak in TestMockCryptoLuksLoadRequest.

Signed-off-by: Or Ozeri <oro@il.ibm.com>
3 years agotest/librbd: fix bad TearDown in TestCryptoOpensslDataCryptor
Or Ozeri [Thu, 25 Nov 2021 13:11:36 +0000 (15:11 +0200)]
test/librbd: fix bad TearDown in TestCryptoOpensslDataCryptor

Fix the TearDown function in TestCryptoOpensslDataCryptor
to call the right class parent function.

Signed-off-by: Or Ozeri <oro@il.ibm.com>
3 years agotest/librbd: fix memory leak in TestCryptoOpensslDataCryptor
Or Ozeri [Thu, 25 Nov 2021 13:10:14 +0000 (15:10 +0200)]
test/librbd: fix memory leak in TestCryptoOpensslDataCryptor

One of the tests leaks an encryption context.
This commit fixes this issue.

Signed-off-by: Or Ozeri <oro@il.ibm.com>
3 years agolibrbd/crypto: fix memory leak in when DataCryptor fails
Or Ozeri [Thu, 25 Nov 2021 13:08:47 +0000 (15:08 +0200)]
librbd/crypto: fix memory leak in when DataCryptor fails

If DataCryptor fails, either in init_context or update_context,
the encryption context is not returned, which causes a memory leak.
This commit fixes this issue.

Signed-off-by: Or Ozeri <oro@il.ibm.com>
3 years agotest/librbd: fix memory leak in TestMockCryptoBlockCrypto
Or Ozeri [Thu, 25 Nov 2021 13:05:55 +0000 (15:05 +0200)]
test/librbd: fix memory leak in TestMockCryptoBlockCrypto

fix memory leak in TestMockCryptoBlockCrypto.

Signed-off-by: Or Ozeri <oro@il.ibm.com>
3 years agoMerge PR #43997 into master
Sage Weil [Fri, 26 Nov 2021 20:15:51 +0000 (15:15 -0500)]
Merge PR #43997 into master

* refs/pull/43997/head:
mgr/cephadm: make logging about agent less verbose

Reviewed-by: Adam King <adking@redhat.com>
3 years agoMerge PR #44079 into master
Sage Weil [Fri, 26 Nov 2021 20:15:42 +0000 (15:15 -0500)]
Merge PR #44079 into master

* refs/pull/44079/head:
mgr/cephadm: skip osd_stats check if osd removal queue is empty

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge PR #44075 into master
Sage Weil [Fri, 26 Nov 2021 20:15:27 +0000 (15:15 -0500)]
Merge PR #44075 into master

* refs/pull/44075/head:
mgr/cephadm: drop osdspec_affinity tracking

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge PR #44073 into master
Sage Weil [Fri, 26 Nov 2021 20:15:12 +0000 (15:15 -0500)]
Merge PR #44073 into master

* refs/pull/44073/head:
pybind/mgr/mgr_module: cache mgr_ip

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
3 years agoMerge PR #43936 into master
Sage Weil [Fri, 26 Nov 2021 15:38:58 +0000 (10:38 -0500)]
Merge PR #43936 into master

* refs/pull/43936/head:
qa/tasks/cephadm: pull image to all hosts in parallel
qa/tasks/cephadm: add hosts via mon remote
qa/tasks/cephadm: use shortname for remote directory
qa/tasks/cephadm: deploy no more than 5 mons in roleless mode
qa/tasks/radosbench: default clients to all clients (not client.0)
qa/tasks/ceph_manager: parallelize flush_pg_stats()
qa/suites/big: remove thrasher
qa/suites/big: update for cephadm

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge PR #44080 into master
Sage Weil [Fri, 26 Nov 2021 15:37:27 +0000 (10:37 -0500)]
Merge PR #44080 into master

* refs/pull/44080/head:
mgr/cephadm: record when finished with scheduled daemon action

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #44106 from sebastian-philipp/mgr-tox-37
Sebastian Wagner [Thu, 25 Nov 2021 16:54:26 +0000 (17:54 +0100)]
Merge pull request #44106 from sebastian-philipp/mgr-tox-37

mgr/tox.ini: Add python 3.7 environment

Reviewed-by: Adam King <adking@redhat.com>
3 years agoMerge pull request #43943 from sebastian-philipp/osd-memeory-hyperconverged
Sebastian Wagner [Thu, 25 Nov 2021 16:27:26 +0000 (17:27 +0100)]
Merge pull request #43943 from sebastian-philipp/osd-memeory-hyperconverged

doc/cephadm: OSD memory autotuning for hyperconverged

Reviewed-by: Adam King <adking@redhat.com>
3 years agoqa/tasks/cephadm: pull image to all hosts in parallel 43936/head
Sage Weil [Mon, 15 Nov 2021 18:00:52 +0000 (12:00 -0600)]
qa/tasks/cephadm: pull image to all hosts in parallel

This doesn't affect bootstrap, but it does mean we avoid any delay
the first time we cephadm.shell on some non-boostrap host.

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoqa/tasks/cephadm: add hosts via mon remote
Sage Weil [Mon, 15 Nov 2021 17:55:52 +0000 (11:55 -0600)]
qa/tasks/cephadm: add hosts via mon remote

If we use a new remote for each shell command, we end up waiting
for the image to pull on every host in sequence.

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoqa/tasks/cephadm: use shortname for remote directory
Sage Weil [Fri, 12 Nov 2021 20:52:46 +0000 (14:52 -0600)]
qa/tasks/cephadm: use shortname for remote directory

This aligns with what the ceph and syslog tasks do.

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoqa/tasks/cephadm: deploy no more than 5 mons in roleless mode
Sage Weil [Wed, 10 Nov 2021 20:48:13 +0000 (14:48 -0600)]
qa/tasks/cephadm: deploy no more than 5 mons in roleless mode

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoqa/tasks/radosbench: default clients to all clients (not client.0)
Sage Weil [Wed, 10 Nov 2021 17:27:53 +0000 (11:27 -0600)]
qa/tasks/radosbench: default clients to all clients (not client.0)

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoqa/tasks/ceph_manager: parallelize flush_pg_stats()
Sage Weil [Wed, 10 Nov 2021 17:23:51 +0000 (11:23 -0600)]
qa/tasks/ceph_manager: parallelize flush_pg_stats()

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoqa/suites/big: remove thrasher
Sage Weil [Wed, 10 Nov 2021 16:35:39 +0000 (10:35 -0600)]
qa/suites/big: remove thrasher

This doesn't work with roleless (yet)

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoqa/suites/big: update for cephadm
Sage Weil [Mon, 8 Nov 2021 15:29:41 +0000 (09:29 -0600)]
qa/suites/big: update for cephadm

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agomgr/cephadm/tests: remove `_deploy_cephadm_binary` 44106/head
Sebastian Wagner [Thu, 25 Nov 2021 12:29:01 +0000 (13:29 +0100)]
mgr/cephadm/tests: remove `_deploy_cephadm_binary`

(not needed)

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
3 years agomgr/tox.ini: Add python 3.7 environment
Sebastian Wagner [Thu, 25 Nov 2021 12:22:06 +0000 (13:22 +0100)]
mgr/tox.ini: Add python 3.7 environment

Plus fixes.

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43774 from aclamk/fix-bluefs-truncate
Neha Ojha [Wed, 24 Nov 2021 17:18:09 +0000 (09:18 -0800)]
Merge pull request #43774 from aclamk/fix-bluefs-truncate

Fix data corruption in bluefs truncate()

Reviewed-by: Igor Fedotov <igor.fedotov@croit.io>
3 years agoMerge pull request #43875 from liewegas/ceph-cli-better-help
Neha Ojha [Wed, 24 Nov 2021 17:17:11 +0000 (09:17 -0800)]
Merge pull request #43875 from liewegas/ceph-cli-better-help

ceph: make -h/--help show match when some args are supplied

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
3 years agopybind/mgr/mgr_module: cache mgr_ip 44073/head
Sage Weil [Tue, 23 Nov 2021 17:32:40 +0000 (12:32 -0500)]
pybind/mgr/mgr_module: cache mgr_ip

This does not change for the lifetime of an active mgr module.  No need to
keep calling back into Mgr to re-fetch it.

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoMerge pull request #44092 from sebastian-philipp/cephadm-docs-deployment-scenarios
Sebastian Wagner [Wed, 24 Nov 2021 15:42:40 +0000 (16:42 +0100)]
Merge pull request #44092 from sebastian-philipp/cephadm-docs-deployment-scenarios

doc/cephadm: Cephadm docs deployment scenarios

Reviewed-by: Adam King <adking@redhat.com>
3 years agodoc/cephadm: deployment scenarios single host and isolated environment 44092/head
Melissa [Tue, 26 Oct 2021 06:46:37 +0000 (02:46 -0400)]
doc/cephadm: deployment scenarios single host and isolated environment

This PR adds a deployment scenarios section to the cephadm docs to document the single-host-defaults flag, and explain how to deploy in an isolated environment.

Signed-off-by: Melissa Li <melissali@redhat.com>
3 years agodoc/cephadm: isolated environment and other deployment scenarios
Melissa [Tue, 26 Oct 2021 06:46:37 +0000 (02:46 -0400)]
doc/cephadm: isolated environment and other deployment scenarios

This PR adds a section to the cephadm docs to describe how to install cephadm in different deployment scenarios (set cluster on single host, and deployment in an isolated environment or private network).

Signed-off-by: Melissa Li <melissali@redhat.com>
3 years agoMerge pull request #43905 from rhcs-dashboard/fix-53242-master
Ernesto Puerta [Wed, 24 Nov 2021 11:47:11 +0000 (12:47 +0100)]
Merge pull request #43905 from rhcs-dashboard/fix-53242-master

mgr/dashboard: dashboard does not show degraded objects if they are less than 0.5% under "Dashboard->Capacity->Objects block

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
3 years agoMerge pull request #44023 from rhcs-dashboard/kcli-expanded-monitoring
Alfonso Martínez [Wed, 24 Nov 2021 10:30:22 +0000 (11:30 +0100)]
Merge pull request #44023 from rhcs-dashboard/kcli-expanded-monitoring

mgr/dashboard: cephadm e2e start script: --expanded: deploy monitoring stack

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
3 years agoMerge pull request #44064 from MrFreezeex/fix-statusupdater-utest
Mykola Golub [Wed, 24 Nov 2021 09:58:36 +0000 (11:58 +0200)]
Merge pull request #44064 from MrFreezeex/fix-statusupdater-utest

rbd-mirror: make RemoveImmediateUpdate test synchronous

Reviewed-by: Mykola Golub <mgolub@suse.com>
3 years agoMerge pull request #44045 from rhcs-dashboard/upgrade-cypress
Alfonso Martínez [Wed, 24 Nov 2021 07:34:10 +0000 (08:34 +0100)]
Merge pull request #44045 from rhcs-dashboard/upgrade-cypress

mgr/dashboard: upgrade Cypress to the latest stable version

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
3 years agoMerge pull request #44019 from liu-chunmei/crimson-background-recovery 43923/head
Liu-Chunmei [Wed, 24 Nov 2021 00:46:16 +0000 (16:46 -0800)]
Merge pull request #44019 from liu-chunmei/crimson-background-recovery

crimson/osd: add delay for background_recovery

reviewed-by:  Radoslaw Zarzynski <rzarzyns@redhat.com>

3 years agoMerge pull request #43989 from cfsnyder/wip-53308
Xie Xingguo [Wed, 24 Nov 2021 00:41:22 +0000 (08:41 +0800)]
Merge pull request #43989 from cfsnyder/wip-53308

osd/OSDMap.cc: clean up pg_temp for nonexistent pgs

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
3 years agoMerge PR #44036 into master
Sage Weil [Wed, 24 Nov 2021 00:40:35 +0000 (19:40 -0500)]
Merge PR #44036 into master

* refs/pull/44036/head:
.github/pull_request_template: drop teuthology reference
.github/pull_request_template: add cleanup option

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
3 years agomgr/cephadm: record when finished with scheduled daemon action 44080/head
Sage Weil [Wed, 24 Nov 2021 00:32:26 +0000 (19:32 -0500)]
mgr/cephadm: record when finished with scheduled daemon action

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agomgr/cephadm: skip osd_stats check if osd removal queue is empty 44079/head
Sage Weil [Tue, 23 Nov 2021 23:59:28 +0000 (18:59 -0500)]
mgr/cephadm: skip osd_stats check if osd removal queue is empty

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoMerge pull request #44061 from Matan-B/wip-matanb-doc-teuthology
Neha Ojha [Tue, 23 Nov 2021 20:07:41 +0000 (12:07 -0800)]
Merge pull request #44061 from Matan-B/wip-matanb-doc-teuthology

doc/dev: adding Teuthology suggested resources

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #43996 from rhcs-dashboard/predefined-labels
Ernesto Puerta [Tue, 23 Nov 2021 19:03:22 +0000 (20:03 +0100)]
Merge pull request #43996 from rhcs-dashboard/predefined-labels

mgr/dashboard: Predefine labels in create host form

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agomgr/cephadm: drop osdspec_affinity tracking 44075/head
Sage Weil [Tue, 23 Nov 2021 18:38:50 +0000 (13:38 -0500)]
mgr/cephadm: drop osdspec_affinity tracking

We identify which drivespec legacy OSDs belong(ed) to by metadata they
report to the mgr.  Modern cephadm does this instead by looking at the
'service' property in the unit.meta file.  Having cephadm query the osd
metadata is expensive for large clusters, so let's avoid this and rely
entirely on unit.meta.

Worst case, some upgraded clusters will show OSDs as service 'osd' instead
of service 'osd.whatever' for whatever drivespec created them.

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agorbd-mirror: make RemoveImmediateUpdate test synchronous 44064/head
Arthur Outhenin-Chalandre [Tue, 23 Nov 2021 14:25:46 +0000 (15:25 +0100)]
rbd-mirror: make RemoveImmediateUpdate test synchronous

Try fixing sporadic failure linked in the tracker in
TestMockMirrorStatusUpdater.RemoveImmediateUpdate by making it
synchronous.

Fixes: https://tracker.ceph.com/issues/53375
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@cern.ch>
3 years agomgr/dashboard: upgrade Cypress to the latest stable version 44045/head
Alfonso Martínez [Tue, 23 Nov 2021 14:17:54 +0000 (15:17 +0100)]
mgr/dashboard: upgrade Cypress to the latest stable version

- Remove unneeded dependency that was causing UI performance issues: zone.js
- Ignore 'ResizeObserver loop limit exceeded' error.
- run-frontend-e2e-tests.sh refactoring: create rgw dashboard user through
  'ceph dashboard set-rgw-credentials' and use it on rgw buckets' tests.

Fixes: https://tracker.ceph.com/issues/53357
Signed-off-by: Alfonso Martínez <almartin@redhat.com>
3 years agoMerge pull request #43244 from ronen-fr/wip-rf-scrub-command
Ronen Friedman [Tue, 23 Nov 2021 13:19:33 +0000 (15:19 +0200)]
Merge pull request #43244 from ronen-fr/wip-rf-scrub-command

osd: make 'pg deep-scrub' command initiate a scrub

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #43722 from lxbsz/caps_doc
Venky Shankar [Tue, 23 Nov 2021 12:47:22 +0000 (18:17 +0530)]
Merge pull request #43722 from lxbsz/caps_doc

doc: update the capabilities doc for cephfs

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agodoc/dev: adding Teuthology suggested resources 44061/head
Matan Breizman [Tue, 23 Nov 2021 11:06:57 +0000 (11:06 +0000)]
doc/dev: adding Teuthology suggested resources

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
3 years agoMerge pull request #43982 from guits/refactor_cv_human_readable_func
Guillaume Abrioux [Tue, 23 Nov 2021 05:12:22 +0000 (06:12 +0100)]
Merge pull request #43982 from guits/refactor_cv_human_readable_func

ceph-volume: human_readable_size() refactor

3 years agoMerge pull request #44007 from tchaikov/wip-cmake-python3.10
Kefu Chai [Tue, 23 Nov 2021 02:59:54 +0000 (10:59 +0800)]
Merge pull request #44007 from tchaikov/wip-cmake-python3.10

cmake: check for python(\d)\.(\d+) when building boost

Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agoMerge pull request #43992 from rhcs-dashboard/flaky-inventory-test-fix
Ernesto Puerta [Mon, 22 Nov 2021 19:39:50 +0000 (20:39 +0100)]
Merge pull request #43992 from rhcs-dashboard/flaky-inventory-test-fix

mgr/dashboard: fix flaky inventory e2e test

Reviewed-by: Waad Alkhoury <walkhour@redhat.com>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agoMerge pull request #43958 from rhcs-dashboard/daemon-event-padding
Ernesto Puerta [Mon, 22 Nov 2021 18:43:11 +0000 (19:43 +0100)]
Merge pull request #43958 from rhcs-dashboard/daemon-event-padding

mgr/dashboard: Daemon Events listing using bootstrap class

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
3 years agoMerge pull request #43866 from rhcs-dashboard/add-hint-provisioned-images
Ernesto Puerta [Mon, 22 Nov 2021 18:41:04 +0000 (19:41 +0100)]
Merge pull request #43866 from rhcs-dashboard/add-hint-provisioned-images

mgr/dashboard: provisioned values is misleading in RBD image table

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
3 years agoMerge pull request #43843 from cbodley/wip-test-cls-rgw-stats
Casey Bodley [Mon, 22 Nov 2021 15:59:39 +0000 (10:59 -0500)]
Merge pull request #43843 from cbodley/wip-test-cls-rgw-stats

test/cls/rgw: add index transaction simulator to model bucket stats

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
3 years agoMerge pull request #43888 from mgfritch/cephadm-expect-hostname
Sebastian Wagner [Mon, 22 Nov 2021 11:00:20 +0000 (12:00 +0100)]
Merge pull request #43888 from mgfritch/cephadm-expect-hostname

cephadm: fixup expect-hostname message

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43873 from guits/add_shared_folder_shell_cmd
Sebastian Wagner [Mon, 22 Nov 2021 10:59:19 +0000 (11:59 +0100)]
Merge pull request #43873 from guits/add_shared_folder_shell_cmd

cephadm: add --shared_ceph_folder to shell cmd

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43876 from sebastian-philipp/all-osd-at-once
Sebastian Wagner [Mon, 22 Nov 2021 10:27:13 +0000 (11:27 +0100)]
Merge pull request #43876 from sebastian-philipp/all-osd-at-once

mgr/cephadm: create osds at all hosts at once

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
3 years agomgr/dashboard: dashboard does not show degraded objects if they are less than 0.5... 43905/head
Aashish Sharma [Fri, 12 Nov 2021 10:05:38 +0000 (15:35 +0530)]
mgr/dashboard: dashboard does not show degraded objects if they are less than 0.5% under "Dashboard->Capacity->Objects block

This PR is intended to fix this issue

Fixes: https://tracker.ceph.com/issues/53242
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
3 years agoMerge pull request #44033 from ljflores/wip-update-email-id
Ernesto Puerta [Mon, 22 Nov 2021 08:14:07 +0000 (09:14 +0100)]
Merge pull request #44033 from ljflores/wip-update-email-id

mailmap: add Laura Flores

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: ljflores <NOT@FOUND>
Reviewed-by: neha-ojha <NOT@FOUND>
3 years agoMerge pull request #43795 from myoungwon/wip-paddr-split
Samuel Just [Mon, 22 Nov 2021 06:17:04 +0000 (22:17 -0800)]
Merge pull request #43795 from myoungwon/wip-paddr-split

seastore: generalize paddr_t

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agomgr/dashboard: Predfine labels in create host form 43996/head
Nizamudeen A [Thu, 18 Nov 2021 11:09:30 +0000 (16:39 +0530)]
mgr/dashboard: Predfine labels in create host form

Also retains the previously created labels by user in the form

Fixes: https://tracker.ceph.com/issues/53315
Signed-off-by: Nizamudeen A <nia@redhat.com>
3 years agomgr/dashboard: fix flaky inventory e2e test 43992/head
Nizamudeen A [Thu, 18 Nov 2021 07:13:39 +0000 (12:43 +0530)]
mgr/dashboard: fix flaky inventory e2e test

When `inventory.getTableCount('total').should('be.eq', totalDiskCount);`
this line is executed the table was not loaded properly and hence the
getTableCount returns 0 on the first try but on second try it passes
since the table is loaded. But in orch e2es the retries are set to 0. I
am not sure if it makes sense to set it to 1. Anyway I am adapting the
test a bit to expect the count to be equal to totalDiskCount so that the
test will wait a bit.

Fixes: https://tracker.ceph.com/issues/53353
Signed-off-by: Nizamudeen A <nia@redhat.com>
3 years agoMerge pull request #43524 from Rethan/feat-expiration-time
Deepika Upadhyay [Mon, 22 Nov 2021 01:22:31 +0000 (06:52 +0530)]
Merge pull request #43524 from Rethan/feat-expiration-time

rbd: when trash mv, show expiration time if it's not now

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
Reviewed-by: Sunny Kumar <sunkumar@redhat.com>
3 years agoMerge pull request #43852 from hualongfeng/show_feature
Deepika Upadhyay [Mon, 22 Nov 2021 01:21:51 +0000 (06:51 +0530)]
Merge pull request #43852 from hualongfeng/show_feature

tools/rbd: make rbd info display dirty-cache feature

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
3 years agoMerge pull request #43907 from cybozu/rbd-correct-encoding-of-snap-protection-record...
Deepika Upadhyay [Sun, 21 Nov 2021 17:03:41 +0000 (22:33 +0530)]
Merge pull request #43907 from cybozu/rbd-correct-encoding-of-snap-protection-record-in-exporting

rbd: correct encoding of snap protection record in exporting image

Reviewed-by: Mykola Golub <mykola.golub@clyso.com>
3 years ago.github/pull_request_template: drop teuthology reference 44036/head
Sage Weil [Sat, 20 Nov 2021 14:55:50 +0000 (08:55 -0600)]
.github/pull_request_template: drop teuthology reference

It is not clear what role this has relative to the needs-qa label.

Signed-off-by: Sage Weil <sage@newdream.net>
3 years ago.github/pull_request_template: add cleanup option
Sage Weil [Sat, 20 Nov 2021 14:55:20 +0000 (08:55 -0600)]
.github/pull_request_template: add cleanup option

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoseastore: generalize paddr_t 43795/head
myoungwon oh [Wed, 3 Nov 2021 07:27:03 +0000 (16:27 +0900)]
seastore: generalize paddr_t

Due to necessity to support both segment and rbm addrs,
paddr_t needs to be generlized.
To do so, this commits introduces seg_paddr_t---
seg_paddr_t inherits paddr_t, and deals with common_addr
according to the semantic of segment.

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
3 years agoMerge pull request #43999 from kamoltat/wip-autoscale-profile-scale-up-default
Neha Ojha [Sat, 20 Nov 2021 00:55:43 +0000 (16:55 -0800)]
Merge pull request #43999 from kamoltat/wip-autoscale-profile-scale-up-default

pybind/mgr/pg_autoscale: revert to default profile scale-up

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge PR #43974 into master
Patrick Donnelly [Fri, 19 Nov 2021 23:43:48 +0000 (18:43 -0500)]
Merge PR #43974 into master

* refs/pull/43974/head:
qa: disable metrics on kernel client during upgrade

Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
3 years agomailmap: add Laura Flores 44033/head
Laura Flores [Fri, 19 Nov 2021 23:22:16 +0000 (23:22 +0000)]
mailmap: add Laura Flores

Signed-off-by: Laura Flores <lflores@redhat.com>
3 years agoMerge pull request #43987 from rhcs-dashboard/53123-dashboard-nfs-cleanup
Ernesto Puerta [Fri, 19 Nov 2021 19:40:41 +0000 (20:40 +0100)]
Merge pull request #43987 from rhcs-dashboard/53123-dashboard-nfs-cleanup

mgr/dashboard: NFS non-existent files cleanup

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: ljflores <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agoMerge pull request #43983 from rhcs-dashboard/rgw-add-realm-column
Ernesto Puerta [Fri, 19 Nov 2021 19:14:19 +0000 (20:14 +0100)]
Merge pull request #43983 from rhcs-dashboard/rgw-add-realm-column

mgr/dashboard: rgw daemon list: add realm column

Reviewed-by: Waad Alkhoury <walkhour@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: sebastian-philipp <NOT@FOUND>
3 years agoMerge pull request #43824 from cbodley/wip-qa-rgw-upgrade-octopus-multisite-cv
J. Eric Ivancich [Fri, 19 Nov 2021 19:11:39 +0000 (14:11 -0500)]
Merge pull request #43824 from cbodley/wip-qa-rgw-upgrade-octopus-multisite-cv

qa/upgrade: rgw multisite upgrade test excludes ceph-volume

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
3 years agoMerge pull request #43764 from gregsfortytwo/wip-rbd-crash-consistency
Deepika Upadhyay [Fri, 19 Nov 2021 18:59:16 +0000 (00:29 +0530)]
Merge pull request #43764 from gregsfortytwo/wip-rbd-crash-consistency

doc: fix up rbd snapshot docs around crash consistency

Reviewed-by: Mykola Golub <mykola.golub@clyso.com>
Reviewed-by: Sunny Kumar <sunkumar@redhat.com>
3 years agopybind/mgr/pg_autoscale: revert to default profile scale-up 43999/head
Kamoltat [Wed, 17 Nov 2021 20:34:48 +0000 (20:34 +0000)]
pybind/mgr/pg_autoscale: revert to default profile scale-up

pg_autoscale module will now start out all the pools
with a scale-up profile by default.

Added tests in workunits/mon/pg_autoscaler.sh
to evaluate if the default pool creation is
a scale-up profile

Updated documentation and release notes to
reflect the change in the default behavior
of the pg_autoscale profile.

Fixes: https://tracker.ceph.com/issues/53309
Signed-off-by: Kamoltat <ksirivad@redhat.com>
3 years agoqa: disable metrics on kernel client during upgrade 43974/head
Patrick Donnelly [Tue, 16 Nov 2021 20:04:59 +0000 (15:04 -0500)]
qa: disable metrics on kernel client during upgrade

v16.2.4 MDS triggers an assert from these messages.

Also: add latest pacific for extra coverage.

Fixes: https://tracker.ceph.com/issues/53293
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
3 years agoqa/rgw: run ceph_test_cls_rgw_stats in rgw/verify suite 43843/head
Casey Bodley [Fri, 19 Nov 2021 17:09:31 +0000 (12:09 -0500)]
qa/rgw: run ceph_test_cls_rgw_stats in rgw/verify suite

Signed-off-by: Casey Bodley <cbodley@redhat.com>
3 years agotest/rgw: model multipart uploads in ceph_test_cls_rgw_stats
Casey Bodley [Mon, 8 Nov 2021 14:05:45 +0000 (09:05 -0500)]
test/rgw: model multipart uploads in ceph_test_cls_rgw_stats

Signed-off-by: Casey Bodley <cbodley@redhat.com>
3 years agotest/rgw: add ceph_test_cls_rgw_stats simulator
Casey Bodley [Sun, 7 Nov 2021 15:13:43 +0000 (10:13 -0500)]
test/rgw: add ceph_test_cls_rgw_stats simulator

a simulator that generates lots of create/delete operations against a
set of object names, and tracks the expected bucket stats for comparison

each operation has a 70% chance to complete successfully, a 10% chance to
cancel, 10% chance to suggest update, and 10% chance to suggest removal

Signed-off-by: Casey Bodley <cbodley@redhat.com>
3 years agocls/rgw: add some missing equality comparisons
Casey Bodley [Sun, 7 Nov 2021 14:50:08 +0000 (09:50 -0500)]
cls/rgw: add some missing equality comparisons

Signed-off-by: Casey Bodley <cbodley@redhat.com>
3 years agocls/rgw: RGWObjCategory to string
Casey Bodley [Sun, 7 Nov 2021 14:46:11 +0000 (09:46 -0500)]
cls/rgw: RGWObjCategory to string

Signed-off-by: Casey Bodley <cbodley@redhat.com>
3 years agocls/rgw: RGWModifyOp <-> string conversions
Casey Bodley [Sun, 7 Nov 2021 14:37:45 +0000 (09:37 -0500)]
cls/rgw: RGWModifyOp <-> string conversions

Signed-off-by: Casey Bodley <cbodley@redhat.com>
3 years agocls/rgw: move stream operator from rgw_common.h
Casey Bodley [Sun, 7 Nov 2021 14:25:46 +0000 (09:25 -0500)]
cls/rgw: move stream operator from rgw_common.h

Signed-off-by: Casey Bodley <cbodley@redhat.com>
3 years agocls/rgw: input parameters are const
Casey Bodley [Sat, 6 Nov 2021 16:08:10 +0000 (12:08 -0400)]
cls/rgw: input parameters are const

Signed-off-by: Casey Bodley <cbodley@redhat.com>
3 years agocls/rgw: add rgw_bucket_dir_stats alias
Casey Bodley [Mon, 8 Nov 2021 14:32:33 +0000 (09:32 -0500)]
cls/rgw: add rgw_bucket_dir_stats alias

Signed-off-by: Casey Bodley <cbodley@redhat.com>
3 years agoMerge pull request #41557 from ifed01/wip-ifed-better-daemonperf
Igor Fedotov [Fri, 19 Nov 2021 15:48:52 +0000 (18:48 +0300)]
Merge pull request #41557 from ifed01/wip-ifed-better-daemonperf

os/bluestore: improve usability for bluestore/bluefs perf counters

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
Reviewed-by: Laura Flores lflores@redhat.com
3 years agomgr/dashboard: cephadm e2e start script: deploy monitoring stack when --expanded 44023/head
Alfonso Martínez [Fri, 19 Nov 2021 07:57:06 +0000 (08:57 +0100)]
mgr/dashboard: cephadm e2e start script: deploy monitoring stack when --expanded

Fixes: https://tracker.ceph.com/issues/53333
Signed-off-by: Alfonso Martínez <almartin@redhat.com>
3 years agoMerge pull request #43886 from nmshelke/doc-fix-53054
Venky Shankar [Fri, 19 Nov 2021 04:40:59 +0000 (10:10 +0530)]
Merge pull request #43886 from nmshelke/doc-fix-53054

doc: prerequisites fix for cephFS mount

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agoMerge pull request #44008 from rzarzynski/wip-crimson-leaky-objectcontextregistry
Samuel Just [Fri, 19 Nov 2021 01:36:30 +0000 (17:36 -0800)]
Merge pull request #44008 from rzarzynski/wip-crimson-leaky-objectcontextregistry

crimson/osd: fix leaks of ObjectContext in the registry.

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
3 years agoMerge pull request #43326 from pdvian/wip-doc-config-correction
Neha Ojha [Fri, 19 Nov 2021 01:03:11 +0000 (17:03 -0800)]
Merge pull request #43326 from pdvian/wip-doc-config-correction

doc/dev/config: Replace invalid config debug-pg

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agocrimson/osd: add delay for background_recovery 44019/head
chunmei-liu [Thu, 18 Nov 2021 22:59:48 +0000 (14:59 -0800)]
crimson/osd: add delay for background_recovery

to avoid interuptor nested.

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
3 years agoMerge pull request #43980 from liu-chunmei/crimson-peerevent-nested
Liu-Chunmei [Thu, 18 Nov 2021 23:04:34 +0000 (15:04 -0800)]
Merge pull request #43980 from liu-chunmei/crimson-peerevent-nested

crimson: add delay for peering_event start when nested

reviewed-by : Samuel Just <sjust@redhat.com>,
                       Kefu Chai <tchaikov@gmail.com>,
                       Xuehan Xu <xxhdx1985126@gmail.com>,
                       Radoslaw Zarzynski <rzarzyns@redhat.com>.

3 years agocrimson/osd: fix leaks of ObjectContext in the registry. 44008/head
Radoslaw Zarzynski [Tue, 16 Nov 2021 01:35:12 +0000 (01:35 +0000)]
crimson/osd: fix leaks of ObjectContext in the registry.

The patch is supposed to fix the following problems (extra
debugs onboard):

```
NFO  2021-11-16 01:18:38,713 [shard 0] osd - ~OSD: OSD dtor called
INFO  2021-11-16 01:18:38,713 [shard 0] osd - Heartbeat::Peer: osd.6 removed
INFO  2021-11-16 01:18:38,714 [shard 0] osd - Heartbeat::Peer: osd.5 removed
INFO  2021-11-16 01:18:38,714 [shard 0] osd - Heartbeat::Peer: osd.2 removed
INFO  2021-11-16 01:18:38,714 [shard 0] osd - ~ShardServices: ShardServices dtor called
INFO  2021-11-16 01:18:38,714 [shard 0] osd - ~ObjectContextRegistry: ShardServices dtor called; unref_size=3, size=3
INFO  2021-11-16 01:18:38,714 [shard 0] osd - ~ObjectContextRegistry: unreferenced p=0x619000115380
INFO  2021-11-16 01:18:38,714 [shard 0] osd - ~ObjectContextRegistry: unreferenced p=0x619000114980
INFO  2021-11-16 01:18:38,714 [shard 0] osd - ~ObjectContextRegistry: unreferenced p=0x619000112680
INFO  2021-11-16 01:18:38,714 [shard 0] osd - ~ObjectContextRegistry: set p=0x619000114980
INFO  2021-11-16 01:18:38,714 [shard 0] osd - ~ObjectContextRegistry: set p=0x619000115380
INFO  2021-11-16 01:18:38,714 [shard 0] osd - ~ObjectContextRegistry: set p=0x619000112680
INFO  2021-11-16 01:18:38,738 [shard 0] osd - crimson shutdown complete

=================================================================
==33351==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 2808 byte(s) in 3 object(s) allocated from:
    #0 0x7fe10c0327b0 in operator new(unsigned long) (/lib64/libasan.so.5+0xf17b0)
    #1 0x55accbe8ffc4 in ceph::common::intrusive_lru<ceph::common::intrusive_lru_config<hobject_t, crimson::osd::ObjectContext, crimson::osd::obc_to_hoid<crimson::osd::ObjectContext> > >::get_or_create(hobject_t const&) (/usr/bin/ceph-osd+0x3b000fc4)

Objects leaked above:
0x619000112680 (936 bytes)
0x619000114980 (936 bytes)
0x619000115380 (936 bytes)
```

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agocmake: check for python(\d)\.(\d+) when building boost 44007/head
Kefu Chai [Thu, 18 Nov 2021 16:18:13 +0000 (00:18 +0800)]
cmake: check for python(\d)\.(\d+) when building boost

now that python3.10 has two digits as its minor version, we should be
able to match it.

this change fixes the build with python3.10. without this change, we'd
have

error: wrong library name 'python310' in the --with-<library> option.

when building with python3.10

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
3 years agomgr/cephadm: use asyncio.gather to parallelize things 43876/head
Sebastian Wagner [Thu, 11 Nov 2021 10:04:19 +0000 (11:04 +0100)]
mgr/cephadm: use asyncio.gather to parallelize things

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
3 years agomgr/cephadm: make OSDService.create_from_spec_one async
Sebastian Wagner [Wed, 10 Nov 2021 17:01:37 +0000 (18:01 +0100)]
mgr/cephadm: make OSDService.create_from_spec_one async

And gather all results. Plus a lot of mechanical adjustments

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
3 years agomgr/cephadm: Add CephadmOrchestrator.wait_async()
Sebastian Wagner [Wed, 10 Nov 2021 16:19:53 +0000 (17:19 +0100)]
mgr/cephadm: Add CephadmOrchestrator.wait_async()

less typing

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43409 from linuxbox2/wip-rgwadmin-logtest
Casey Bodley [Thu, 18 Nov 2021 15:06:56 +0000 (10:06 -0500)]
Merge pull request #43409 from linuxbox2/wip-rgwadmin-logtest

qa/rgw: use local runner with cmdline radosgw_admin.py

Reviewed-by: Casey Bodley <cbodley@redhat.com>