]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Nizamudeen A [Tue, 6 Aug 2024 04:46:19 +0000 (10:16 +0530)]
Merge pull request #58963 from rhcs-dashboard/fix-67009-main
mgr/dashboard: Dashboard not showing Object/Overview correctly.
Reviewed-by: afreen23 <NOT@FOUND>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Nizamudeen A [Tue, 6 Aug 2024 04:45:09 +0000 (10:15 +0530)]
Merge pull request #58746 from rhcs-dashboard/fix-67069-main
mgr/dashboard: make multi-cluster context switcher scrollable if we have many entries in it
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Anthony D'Atri [Tue, 6 Aug 2024 00:23:53 +0000 (20:23 -0400)]
Merge pull request #57905 from mcpreston/docs-dashboard-typo
doc/mgr/dashboard: fix TLS typo
Adam King [Mon, 5 Aug 2024 16:56:39 +0000 (12:56 -0400)]
Merge pull request #58767 from kshtsk/wip-python-invalid-escape-sequence
mgr: fix invalid escape sequence
Reviewed-by: John Mulligan <jmulligan@redhat.com>
kyr [Mon, 5 Aug 2024 15:44:14 +0000 (17:44 +0200)]
Merge pull request #58373 from ceph/wip-tasks-ceph-mkfs-has-no-f
qa: ceph.py mkfs.ext4 has no -f
Zac Dover [Mon, 5 Aug 2024 12:14:56 +0000 (22:14 +1000)]
Merge pull request #58891 from zdover23/wip-doc-2024-07-28-cephfs-file-layouts-layout-fields
doc/cephfs: edit "Layout Fields" text
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Ronen Friedman [Mon, 5 Aug 2024 11:59:38 +0000 (14:59 +0300)]
Merge pull request #58115 from ronen-fr/wip-rf-memmodel
common: MemoryModel: performance improvements and API changes
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Rongqi Sun [Mon, 5 Aug 2024 07:45:17 +0000 (15:45 +0800)]
Merge pull request #57786 from Svelar/asan_cli_test
crush: avoid out-of-bound access and simplify enlarging buckets
Yuri Weinstein [Sun, 4 Aug 2024 15:14:49 +0000 (08:14 -0700)]
Merge pull request #58718 from wanglinke521/wlk-kv-stats
kv/RocksDBStore: add kv_stats function to print all CF info
Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Yuri Weinstein [Sun, 4 Aug 2024 15:14:09 +0000 (08:14 -0700)]
Merge pull request #58470 from mohit84/issue_66867
mon: Remove any pg_upmap_primary mapping during remove a pool
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Josh Salomon <josh.salomon@gmail.com>
Yuri Weinstein [Sun, 4 Aug 2024 15:13:04 +0000 (08:13 -0700)]
Merge pull request #58302 from jianwei1216/feat_add_mclock_perfcounter_main
osd/scheduler: add mclock queue length perfcounter
Reviewed-by: Sridhar Seshasayee <sseshasa@redhat.com>
Anthony D'Atri [Sat, 3 Aug 2024 14:41:03 +0000 (10:41 -0400)]
Merge pull request #59006 from zdover23/wip-doc-2024-08-03-glossary-ceph-ansible
doc/glossary: add "ceph-ansible"
Zac Dover [Fri, 2 Aug 2024 20:51:32 +0000 (06:51 +1000)]
doc/glossary: add "ceph-ansible"
Add a "ceph-ansible" entry to the glossary.
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
Gil Bregman [Fri, 2 Aug 2024 13:27:08 +0000 (16:27 +0300)]
Merge pull request #58969 from gbregman/main
mgr/cephadm: Add SPDK log level to nvmeof configuration file
Adam King [Fri, 2 Aug 2024 13:26:17 +0000 (09:26 -0400)]
Merge pull request #58402 from rkachach/fix_issue_mtls_support
mgr/cephadm: adding mTLS for ceph mgmt-gateway and backend services communication
Reviewed-by: Adam King <adking@redhat.com>
Gil Bregman [Fri, 2 Aug 2024 06:21:01 +0000 (09:21 +0300)]
mgr/cephadm: add SPDK log level to nvmeof configuration
Fixes https://tracker.ceph.com/issues/67258
Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
Gil Bregman [Fri, 2 Aug 2024 06:20:21 +0000 (09:20 +0300)]
python-common/ceph/deployment: add SPDK log level to nvmeof configuration
Fixes https://tracker.ceph.com/issues/67258
Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
Ilya Dryomov [Thu, 1 Aug 2024 20:52:50 +0000 (22:52 +0200)]
Merge pull request #58883 from idryomov/wip-backport-create-resourceattrerror
script/backport-create-issue: handle ResourceAttrError when getting CF_TAGS
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Ilya Dryomov [Thu, 1 Aug 2024 20:51:18 +0000 (22:51 +0200)]
Merge pull request #58882 from idryomov/wip-native-format-dispatch
librbd/migration: don't instantiate NativeFormat, handle it via dispatch
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: N Balachandran <nibalach@redhat.com>
Casey Bodley [Thu, 1 Aug 2024 18:23:26 +0000 (14:23 -0400)]
Merge pull request #58862 from cbodley/wip-rgw-posix-bucket-cache-lock
rgw/posix: name the lock_guard in BucketCacheEntry::reclaim()
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
J. Eric Ivancich [Thu, 1 Aug 2024 14:09:10 +0000 (10:09 -0400)]
Merge pull request #58765 from yuvalif/wip-yuval-64184
rgw/async/notifications: use common async waiter in pubsub push
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Yuri Weinstein [Thu, 1 Aug 2024 13:45:27 +0000 (06:45 -0700)]
Merge pull request #58672 from YiteGu/code-cleanup-osdmon
mon/osdmonitor: cleanup the code for preprocess_mark_me_dead
Reviewed-by: Matan Breizman <Matan.Brz@gmail.com>
Yuri Weinstein [Thu, 1 Aug 2024 13:44:34 +0000 (06:44 -0700)]
Merge pull request #58635 from badone/wip-tracker-50371-rados_api_test-timeout-failures
qa: Restrict rados api tests to large clusters and increase timeout
Reviewed-by: Laura Flores <lflores@redhat.com>
Yuri Weinstein [Thu, 1 Aug 2024 13:43:46 +0000 (06:43 -0700)]
Merge pull request #58631 from cbodley/wip-66336
msg: insert PriorityDispatchers in sorted position
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Yuri Weinstein [Thu, 1 Aug 2024 13:42:09 +0000 (06:42 -0700)]
Merge pull request #57863 from NitzanMordhai/wip-nitzan-thrash-erasure-code-crush-4-nodes-8-6-overrides
suites/ec-rados-plugin=jerasure-k=8-m=6-crush: roles set with overrides
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Matan Breizman <Matan.Brz@gmail.com>
Ali Masarwa [Thu, 1 Aug 2024 12:46:01 +0000 (15:46 +0300)]
Merge pull request #58747 from AliMasarweh/wip-alimasa-bn-test-fix-http
RGW|BN: fix lifecycle test issue
Reviewed-by: yuvalif<ylifshit@redhat.com>
Redouane Kachach [Wed, 31 Jul 2024 11:23:13 +0000 (13:23 +0200)]
mgr/cephadm: fixing Grafana domain handling
it seems that with Grafana 10.4.0 the domain parameter is taken into
account while building the final url (earlier versions didn't seem to
behave the same way). This change sets the domain to the hostname where
Grafana daemon is running instead of '*.lab'. serve_from_sub_path is
removed as it's no needed and when add it causes some undesirable
redirections that could break monitoring HA.
Signed-off-by: Redouane Kachach <rkachach@ibm.com>
Aashish Sharma [Wed, 31 Jul 2024 11:51:02 +0000 (17:21 +0530)]
mgr/dashboard: Dashboard not showing Object/Overview correctly.
Add undefined checks wherever necessary to the updateChartData method in
dashboard-area-chart component
Fixes: https://tracker.ceph.com/issues/67009
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
Venky Shankar [Thu, 1 Aug 2024 06:49:52 +0000 (12:19 +0530)]
Merge PR #51332 into main
* refs/pull/51332/head:
qa: add test for ceph tell with unknown cephtype
pybind/ceph_argparse: fixing error message for ceph tell command
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Aashish Sharma [Tue, 23 Jul 2024 06:29:42 +0000 (11:59 +0530)]
mgr/dashboard: make multi-cluster context switcher scrollable if we have many entries in it
Fixes: https://tracker.ceph.com/issues/67069
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
Zac Dover [Sun, 28 Jul 2024 13:35:21 +0000 (23:35 +1000)]
doc/cephfs: edit "Layout Fields" text
Improve the English in the "Layout Fields" section of
doc/cephfs/file-layouts.rst.
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
Zac Dover [Thu, 1 Aug 2024 03:07:24 +0000 (13:07 +1000)]
Merge pull request #58899 from zdover23/wip-doc-2024-07-29-glossary-prometheus
doc/glossary: add "Prometheus"
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Wed, 31 Jul 2024 22:59:55 +0000 (08:59 +1000)]
Merge pull request #58972 from anthonyeleven/glacier-melting
doc: Improve doc/radosgw/placement.rst
Reviewed-by: Zac Dover <zac.dover@proton.me>
Anthony D'Atri [Wed, 31 Jul 2024 22:41:53 +0000 (18:41 -0400)]
doc: Improve doc/radosgw/placement.rst
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Guillaume Abrioux [Wed, 10 Jul 2024 13:50:59 +0000 (15:50 +0200)]
mgr/cephadm: add SSL support to ceph-exporter
This commit adds SSL support to the ceph-exporter deployment
made by cephadm. When `secure_monitoring_stack` is set to `True`,
the `ceph-exporter` container is restarted with SSL enabled.
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
Signed-off-by: Redouane Kachach <rkachach@ibm.com>
Redouane Kachach [Wed, 3 Jul 2024 13:43:16 +0000 (15:43 +0200)]
mgr/cephadm: adding mTLS support
Signed-off-by: Redouane Kachach <rkachach@ibm.com>
Shilpa Jagannath [Wed, 31 Jul 2024 17:10:26 +0000 (10:10 -0700)]
Merge pull request #56792 from cbodley/wip-qa-rgw-notifications-valgrind
qa/rgw: enable valgrind in rgw/notifications suite
Yuri Weinstein [Wed, 31 Jul 2024 16:05:41 +0000 (09:05 -0700)]
Merge pull request #54671 from baum/ceph-nvmeof-mon
mon: add NVMe-oF gateway monitor and HA
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Ronen Friedman [Wed, 31 Jul 2024 15:07:39 +0000 (18:07 +0300)]
Merge pull request #58931 from ronen-fr/wip-rf-repair-decode
qa/standalone/scrub: fix the searched-for text for snaps decode errors
Reviewed-by: Adam Kupczyk <akupczyk@ibm.com>
Yuri Weinstein [Wed, 31 Jul 2024 14:33:58 +0000 (07:33 -0700)]
Merge pull request #56976 from YiteGu/add-watcher-timeout-discover
osd: add watch ping timeout count in osd
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Yuri Weinstein [Wed, 31 Jul 2024 14:31:40 +0000 (07:31 -0700)]
Merge pull request #55130 from ifed01/wip-ifed-better-shared-blob-repair
test/store_test: get rid off explicit offset specifications in shared
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Yuri Weinstein [Wed, 31 Jul 2024 14:30:53 +0000 (07:30 -0700)]
Merge pull request #52068 from YiteGu/fix-trackedop-perfcounter
common/TrackedOp: rename and raise prio of slow op perfcounter
Reviewed-by: Samuel Just <sjust@redhat.com>
Daniel Gryniewicz [Wed, 31 Jul 2024 13:57:24 +0000 (09:57 -0400)]
Merge pull request #58349 from dang/wip-dang-posix-driver
RGW - Add Multipart and Versioned POSIX
Venky Shankar [Wed, 31 Jul 2024 11:10:03 +0000 (16:40 +0530)]
Merge PR #58878 into main
* refs/pull/58878/head:
client: Fix leading / issue with mds_check_access
qa: Add mds caps test for testing fs read and a path rw
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Alexander Indenbaum [Thu, 25 Jul 2024 09:02:44 +0000 (09:02 +0000)]
nvmeof gw monitor: disable by default
Signed-off-by: Alexander Indenbaum <aindenba@redhat.com>
Vallari Agrawal [Thu, 27 Jun 2024 11:18:47 +0000 (16:48 +0530)]
qa/suites/rbd/nvmeof: add multi-subsystem setup and thrash test
1. qa/tasks/nvmeof.py:
1.1. create multiple rbd images for all subsystems
1.2. add NvmeofThrasher and ThrashTest
2. qa/tasks/mon_thrash.py: add 'switch_thrashers' option
3. nvmeof_setup_subsystem.sh: create multiple subsystems and enable HA
4. Restructure qa/suites/rbd/nvmeof: Create two sub-suites
- "basic" (nvmeof_initiator job)
- "thrash" (new: nvmeof_mon_thrash and nvmeof_thrash jobs)
Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
Alexander Indenbaum [Mon, 10 Jun 2024 13:04:57 +0000 (13:04 +0000)]
mgr/cephadm: ceph nvmeof monitor support
Signed-off-by: Alexander Indenbaum <aindenba@redhat.com>
Alexander Indenbaum [Wed, 31 Jul 2024 08:51:17 +0000 (08:51 +0000)]
mon: add NVMe-oF gateway monitor and HA doc
Signed-off-by: Alexander Indenbaum <aindenba@redhat.com>
Leonid Chernin [Tue, 17 Oct 2023 13:25:07 +0000 (13:25 +0000)]
mon: add NVMe-oF gateway monitor and HA
- gateway submodule
Fixes: https://tracker.ceph.com/issues/64777
This PR adds high availability support for the nvmeof Ceph service. High availability means that even in the case that a certain GW is down, there will be another available path for the initiator to be able to continue the IO through another GW. High availability is achieved by running nvmeof service consisting of at least 2 nvmeof GWs in the Ceph cluster. Every GW will be seen by the host (initiator) as a separate path to the nvme namespaces (volumes).
The implementation consists of the following main modules:
- NVMeofGWMon - a PaxosService. It is a monitor that tracks the status of the nvmeof running services, and take actions in case that services fail, and in case services restored.
- NVMeofGwMonitorClient – It is an agent that is running as a part of each nvmeof GW. It is sending beacons to the monitor to signal that the GW is alive. As a part of the beacon, the client also sends information about the service. This information is used by the monitor to take decisions and perform some operations.
- MNVMeofGwBeacon – It is a structure used by the client and the monitor to send/recv the beacons.
- MNVMeofGwMap – The map is tracking the nvmeof GWs status. It also defines what should be the new role of every GW. So in the events of GWs go down or GWs restored, the map will reflect the new role of each GW resulted by these events. The map is distributed to the NVMeofGwMonitorClient on each GW, and it knows to update the GW with the required changes.
It is also adding 3 new mon commands:
- nvme-gw create
- nvme-gw delete
- nvme-gw show
The commands are used by the ceph adm to update the monitor that a new GW is deployed. The monitor will update the map accordingly and will start tracking this GW until it is deleted.
Signed-off-by: Leonid Chernin <lechernin@gmail.com>
Signed-off-by: Alexander Indenbaum <aindenba@redhat.com>
Ali Masarwa [Thu, 18 Jul 2024 12:24:05 +0000 (15:24 +0300)]
RGW|BN: fix lifecycle test and http server issue
Signed-off-by: Ali Masarwa <amasarwa@redhat.com>
Matan Breizman [Wed, 31 Jul 2024 08:30:44 +0000 (11:30 +0300)]
Merge pull request #58897 from Matan-B/wip-matanb-crimson-string-format
crimson/common/tri_mutex: avoid hobject_t formatting
Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>
Guillaume Abrioux [Wed, 31 Jul 2024 08:11:51 +0000 (10:11 +0200)]
Merge pull request #58424 from guits/tracker_61597
ceph-volume: do not convert LVs's symlink to real path
Redouane Kachach [Wed, 3 Jul 2024 08:15:20 +0000 (10:15 +0200)]
mgr/cephadm: introducing new cmd to generate self-signed certs
this new Cephadm cmd introduces the ability to generate self-signed
certificates for external modules, signed by Cephadm as the root CA.
This feature is essential for implementing mTLS. Previously, if the
user did not provide a certificate and key, the dashboard would
generate its own. With this update, the dashboard now calls Cephadm
to generate self-signed certificates, enabling secure mTLS
communication with other backend applications. Prometheus module
also makes use of this new functionality to generate self-signed
certificates.
Signed-off-by: Redouane Kachach <rkachach@ibm.com>
Redouane Kachach [Tue, 2 Jul 2024 15:28:40 +0000 (17:28 +0200)]
mgr/cephadm: introducing cert_mgr new class to centralize certs mgmt
cert_mgr will be the unique responsible of managing all certificates
generated and maintained by cephadm. Cephadm in addition now provides
a new cmd to generate certificates for external modules.
Signed-off-by: Redouane Kachach <rkachach@ibm.com>
Laura Flores [Wed, 31 Jul 2024 05:30:51 +0000 (00:30 -0500)]
Merge pull request #57843 from rzarzynski/wip-bug-66329
mon: validate also mons and osds on {rm-,}pg-upmap-primary
Zac Dover [Mon, 29 Jul 2024 10:19:02 +0000 (20:19 +1000)]
doc/glossary: add "Prometheus"
Add a glossary entry for "Prometheus".
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
Zac Dover [Wed, 31 Jul 2024 01:34:27 +0000 (11:34 +1000)]
Merge pull request #58946 from anthonyeleven/remove-vanity-name
doc/rados/operations: remove vanity cluster name reference from crush-map.rst
Reviewed-by: Zac Dover <zac.dover@proton.me>
Anthony D'Atri [Wed, 31 Jul 2024 00:45:11 +0000 (20:45 -0400)]
doc/rados/operations: remove vanity cluster name reference from crush-map.rst
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Zac Dover [Tue, 30 Jul 2024 23:37:46 +0000 (09:37 +1000)]
Merge pull request #58908 from zdover23/wip-doc-2024-07-30-glossary-ceph-fuse
doc/glossary: add "ceph-fuse" entry
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Tue, 30 Jul 2024 23:16:57 +0000 (09:16 +1000)]
Merge pull request #58922 from zdover23/wip-doc-2024-07-30-cephadm-services-monitoring-using-custom-images
doc/cephadm: edit "Using Custom Images"
Reviewed-by: Adam King <adking@redhat.com>
Zac Dover [Tue, 30 Jul 2024 21:31:49 +0000 (07:31 +1000)]
Merge pull request #58918 from zdover23/wip-doc-2024-07-30-dev-dev-guide-basic-workflow
doc/dev: improve basic-workflow.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Ilya Dryomov [Fri, 26 Jul 2024 14:54:31 +0000 (16:54 +0200)]
librbd/migration: make FormatInterface::read() void again
Now that NativeFormat is handled via dispatch, FormatInterface::read()
can be void again for consistency with FormatInterface::list_snaps().
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Fri, 26 Jul 2024 10:13:08 +0000 (12:13 +0200)]
librbd/migration: close source image in OpenSourceImageRequest
Currently, on errors in FormatInterface::open(), RawFormat disposes
of src_image_ctx, but QCOWFormat doesn't, which is a leak. Rather than
having each format do it internally, do it in OpenSourceImageRequest.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Thu, 18 Jul 2024 16:11:18 +0000 (18:11 +0200)]
librbd/migration: don't instantiate NativeFormat, handle it via dispatch
Trying to shoehorn NativeFormat under FormatInterface doesn't really
work. It fundamentally doesn't fit in:
- Unlike for RawFormat and QCOWFormat, src_image_ctx for NativeFormat
is not dummy -- it's an ImageCtx for a real RBD image. Pre-creating
it in OpenSourceImageRequest with the expectation that placeholder
values would be overridden later forces NativeFormat to reach into
ImageCtx guts, duplicating the logic in the constructor. This also
necessitates calling snap_set() in a separate step, since snap_id
isn't known at the time ImageCtx is created.
- Unlike for RawFormat and QCOWFormat, get_image_size() and
get_snapshots() implementations for NativeFormat are dummy.
- read() and list_snaps() implementations for NativeFormat are
inconsistent: read() passes through io::ImageDispatch layer, but
list_snaps() doesn't. Both can be passing through, meaning that in
essence these are also dummy.
All of this is with today's code. Additional complications arise with
planned support for migrating from external clusters where src_image_ctx
would require more invasive patching to "move" to an IoCtx belonging to
an external cluster's CephContext and also with other work.
With the above in mind, NativeFormat actually consists of:
1. Code that parses the "type: native" source spec
2. Code that patches ImageCtx, working around the fact that it's
pre-created in OpenSourceImageRequest
3. A bunch of dummy implementations for FormatInterface
With this change, (1) is wrapped into a static method that also creates
ImageCtx after all required parameters are known and (2) and (3) go away
entirely. NativeFormat no longer implements FormatInterface and doesn't
get instantiated at all.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Wed, 17 Jul 2024 19:11:51 +0000 (21:11 +0200)]
librbd/migration/NativeFormat: refactor source spec parsing
In preparation for not instantiating NativeFormat and losing a copy of
the source spec JSON object in m_json_object, refactor the parsing code
to use only const methods (which std::map's operator[] isn't) and local
variables where possible.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Wed, 17 Jul 2024 18:05:08 +0000 (20:05 +0200)]
librbd/migration/NativeFormat: do pool lookup instead of creating io_ctx
A Rados instance is sufficient to map the pool name to the pool ID,
no need to involve an IoCtx instance as well. While at it, report
distinctive errors for a non-existing pool and an invalid JSON value
for pool_name key cases.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Wed, 17 Jul 2024 13:06:33 +0000 (15:06 +0200)]
librbd/migration: make SourceSpecBuilder::parse_source_spec() static
In preparation for divorcing NativeFormat from FormatInterface and
changing when/how src_image_ctx is created, make parse_source_spec()
independent of src_image_ctx. The "invalid source-spec JSON" error is
duplicated by the "failed to parse migration source-spec" error, so
just get rid of the former to spare having to pass CephContext to
parse_source_spec().
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Tue, 30 Jul 2024 20:56:17 +0000 (22:56 +0200)]
librbd/migration/OpenSourceImageRequest: rename io_ctx -> dst_io_ctx
For now, this is just slightly clearer. The distinction would become
important with planned support for migrating from external clusters.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Zac Dover [Tue, 30 Jul 2024 07:33:55 +0000 (17:33 +1000)]
doc/cephadm: edit "Using Custom Images"
Edit the section "Using Custom Images" in
doc/cephadm/services/monitoring.rst.
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
Zac Dover [Tue, 30 Jul 2024 06:07:04 +0000 (16:07 +1000)]
doc/dev: improve basic-workflow.rst
Make various improvements to doc/dev/developer_guide/basic-workflow.rst.
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
Kotresh HR [Fri, 26 Jul 2024 14:48:04 +0000 (20:18 +0530)]
client: Fix leading / issue with mds_check_access
The "Client::mds_check_access" expects the target_path without
leading '/' as it eventually calls the "MDSCapMatch::match_path"
which expects the target_path passed to be with out leading '/'
as well.
The single leading '/' was being removed. But absolute path
constructed did have leading '//', so removing all the leading
'/' was necessary.
This causes the clients not to be able to access a particular
path even though it has a rw permission on the specific path.
The patche fixes the leading '//' issue.
Fixes: https://tracker.ceph.com/issues/67212
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Kotresh HR [Sun, 28 Jul 2024 18:43:27 +0000 (00:13 +0530)]
qa: Add mds caps test for testing fs read and a path rw
Fixes: https://tracker.ceph.com/issues/67212
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Casey Bodley [Tue, 30 Jul 2024 17:20:24 +0000 (18:20 +0100)]
Merge pull request #58213 from benhanokh/ref_count
rgw/rgw_rados: fix server side-copy orphans tail-objects
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Tue, 30 Jul 2024 17:15:17 +0000 (18:15 +0100)]
Merge pull request #58606 from cbodley/wip-66937
rgw/auth: RemoteApplier respects implicit tenants
Reviewed-by: Adam Emerson <aemerson@redhat.com>
Laura Flores [Tue, 30 Jul 2024 15:51:15 +0000 (10:51 -0500)]
Merge pull request #57490 from rzarzynski/wip-osd-configurable-ideal_list_max
osd: make the chunking in e.g. PG deletion controlable
Laura Flores [Tue, 30 Jul 2024 15:46:47 +0000 (10:46 -0500)]
Merge pull request #57545 from NitzanMordhai/wip-nitzan-local-recovery-valgrind-error
PrimaryLogPG: Keep soid before erase entry
Yuri Weinstein [Tue, 30 Jul 2024 15:31:51 +0000 (08:31 -0700)]
Merge pull request #54968 from kamoltat/wip-ksirivad-fix-63860
src/pybind/mgr/pg_autoscaler/module.py: fix 'pg_autoscale_mode' output
Reviewed-by: Matan Breizman <Matan.Brz@gmail.com>
Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>
Ilya Dryomov [Sun, 14 Jul 2024 17:48:33 +0000 (19:48 +0200)]
librbd/migration: massage some error messages
Add missing spaces, don't use the word stream when reporting errors
on POSIX file operations (open() and lseek64()) and fix a cut-and-paste
typo in RawSnapshot.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Sun, 14 Jul 2024 17:21:47 +0000 (19:21 +0200)]
librbd/api: clean up leftovers in Migration::prepare_import()
Dead code after return and an unused variable.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Yuri Weinstein [Tue, 30 Jul 2024 14:50:16 +0000 (07:50 -0700)]
Merge pull request #57193 from NitzanMordhai/wip-nitzan-osd-recovery-standalone-test-wait-for-too-full
Test: osd-recovery-space.sh extends the wait time for "recovery toofull"
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Yuri Weinstein [Tue, 30 Jul 2024 14:49:11 +0000 (07:49 -0700)]
Merge pull request #56224 from ibm-s390-cloud/master-s390x-crc32c
crc32c optimized for s390x arch
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Matan Breizman [Tue, 30 Jul 2024 14:44:52 +0000 (17:44 +0300)]
Merge pull request #57548 from Matan-B/wip-matanb-force-remove-snap
mon/OSDMonitor: Add force-remove-snap mon command
Reviewed-by: Samuel Just <sjust@redhat.com>
Ronen Friedman [Tue, 30 Jul 2024 14:43:00 +0000 (09:43 -0500)]
qa/standalone/scrub: fix the searched-for text for snaps decode errors
to match the updated error log, as modified by commit
ebd8283
Fixes: https://tracker.ceph.com/issues/67228
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Casey Bodley [Tue, 30 Jul 2024 12:26:15 +0000 (13:26 +0100)]
Merge pull request #56864 from clwluvw/s3select-err
rgw: set correct requestId and hostId on s3select error
Reviewed-by: Gal Salomon <gsalomon@redhat.com>
Daniel Gryniewicz [Wed, 30 Aug 2023 18:09:16 +0000 (14:09 -0400)]
RGW - Add Multipart and Versioned to POSIXDriver
This is a rework of the POSIXDriver. It refactors out the actual posix
parts into a set of classes that provide access to underlying
directory/file/symlink, etc. These primatives are used to build up full
support for Bucket, Object, Multipart, and VersionedObjects.
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
Adam Kupczyk [Tue, 30 Jul 2024 12:03:00 +0000 (14:03 +0200)]
Merge pull request #58748 from pereman2/replayer-merge-files
test/allocsim: Replayer merge files
Nizamudeen A [Tue, 30 Jul 2024 11:58:32 +0000 (17:28 +0530)]
Merge pull request #58239 from rhcs-dashboard/carbon-forms
mgr/dashboard: carbonize rbd forms
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Avan [Tue, 30 Jul 2024 11:14:16 +0000 (16:44 +0530)]
Merge pull request #58552 from rhcs-dashboard/nfs-export-rgw
mgr/dashboard: support rgw user level NFS export
Reviewed-by: afreen23 <NOT@FOUND>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Venky Shankar [Tue, 30 Jul 2024 10:54:58 +0000 (16:24 +0530)]
Merge PR #58218 into main
* refs/pull/58218/head:
qa: some test set `refuse_client_session`, so the cluster log is expected
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Nizamudeen A [Sat, 22 Jun 2024 15:32:57 +0000 (21:02 +0530)]
mgr/dashboard: carbonize block forms
Includes rbd forms and mirroring forms (excluded iscsi for now)
carbonized elements/components that were dependent on the forms like
modal, date-time picker etc..
Fixes: https://tracker.ceph.com/issues/67231
Signed-off-by: Nizamudeen A <nia@redhat.com>
Venky Shankar [Mon, 24 Jun 2024 07:11:50 +0000 (07:11 +0000)]
qa: some test set `refuse_client_session`, so the cluster log is expected
Fixes: http://tracker.ceph.com/issues/66639
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Laura Flores [Tue, 30 Jul 2024 03:06:38 +0000 (22:06 -0500)]
Merge pull request #58800 from ljflores/wip-update-crontab
qa/crontab: update frequency and priority for rados nightlies
Mohit Agrawal [Tue, 9 Jul 2024 04:35:38 +0000 (10:05 +0530)]
osdmon: Remove any pg_upmap_primary mapping during remove a pool
The pg_upmap_primary items are not deleted after the pool is deleted
from the cluster.
Fixes: https://tracker.ceph.com/issues/66867
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Laura Flores [Mon, 29 Jul 2024 17:56:34 +0000 (12:56 -0500)]
Merge pull request #58409 from baergj/upstream-fix-async-discard-on-start
blk/KernelDevice: React to bdev_enable_discard changes in handle_conf_change(); Fix several issues with stopping discard threads
Radoslaw Zarzynski [Mon, 29 Jul 2024 17:51:42 +0000 (19:51 +0200)]
Merge pull request #58404 from NitzanMordhai/wip-nitzan-fix-corpus-forward_incompat-cls_rgw_reshard_entry
corpus: update submodule with mark cls_rgw_reshard_entry forward_inco…
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Zac Dover [Mon, 29 Jul 2024 16:01:37 +0000 (02:01 +1000)]
Merge pull request #58904 from zdover23/wip-doc-2024-07-28-cephfs-multimds
doc/cephfs: edit "Dynamic Subtree Partitioning"
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Mon, 29 Jul 2024 15:50:13 +0000 (01:50 +1000)]
doc/glossary: add "ceph-fuse" entry
Add a "ceph-fuse" entry to the glossary.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Nizamudeen A [Sat, 22 Jun 2024 15:31:49 +0000 (21:01 +0530)]
mgr/dashboard: carbonize breadcrums
Fixes: https://tracker.ceph.com/issues/67231
Signed-off-by: Nizamudeen A <nia@redhat.com>
Nizamudeen A [Sat, 22 Jun 2024 15:29:23 +0000 (20:59 +0530)]
mgr/dashboard: carbonize general components and styles
alert-panel and some other general components
Fixes: https://tracker.ceph.com/issues/67231
Signed-off-by: Nizamudeen A <nia@redhat.com>
Zac Dover [Mon, 29 Jul 2024 11:17:44 +0000 (21:17 +1000)]
doc/cephfs: edit "Dynamic Subtree Partitioning"
Edit the section "Dynamic Subtree Partitioning" in
doc/cephfs/multimds.rst.
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>