]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Zac Dover [Mon, 6 Nov 2023 04:31:20 +0000 (14:31 +1000)]
doc/rados: format Q&A list in tshooting-mon.rst
Bold the questions in a Q&A list in the "Most Common Monitor Issues"
section of doc/rados/troubleshooting/troubleshooting-mon.rst.
Signed-off-by: Zac Dover <zac.dover@proton.me>
zdover23 [Sun, 5 Nov 2023 16:05:47 +0000 (02:05 +1000)]
Merge pull request #54344 from zdover23/wip-doc-2023-11-05-rados-troubleshooting-mon-clock-skews-edit
doc/rados: edit t-mon.rst text
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Sun, 5 Nov 2023 12:28:39 +0000 (22:28 +1000)]
doc/rados: edit t-mon.rst text
Clarify the text in the "Clock Skew" section of
doc/rados/troubleshooting/troubleshooting-mon.rst.
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
Anthony D'Atri [Sun, 5 Nov 2023 13:11:22 +0000 (08:11 -0500)]
Merge pull request #54343 from zdover23/wip-doc-2023-11-05-rados-troubleshooting-troubleshooting-mon-clock-skews-formatting
doc/rados: format Q&A list in t-mon.rst
Zac Dover [Sun, 5 Nov 2023 06:24:16 +0000 (16:24 +1000)]
doc/rados: format Q&A list in t-mon.rst
Format a Q&A list in doc/rados/troubleshooting/troubleshooting.rst, in
the "Clock Skews" section.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Adam King [Sat, 4 Nov 2023 16:01:10 +0000 (12:01 -0400)]
Merge pull request #54104 from phlogistonjohn/jjm-cephadm-move-extract
cephadm: move extract_uid_gid function
Reviewed-by: Adam King <adking@redhat.com>
Adam King [Fri, 3 Nov 2023 23:56:34 +0000 (19:56 -0400)]
Merge pull request #54056 from rkachach/fix_issue_ci_for_rook
mgr/rook: adding e2e testing for rook orchestrator
reviewed-by: Nizamudeen A <nia@redhat.com>
Anthony D'Atri [Fri, 3 Nov 2023 23:28:26 +0000 (19:28 -0400)]
Merge pull request #54339 from aclamk/fix-aclamk-bs-reshard-doc-v2
doc/rados/configuration/bluestore-config-ref: Fix lowcase typo
Yuri Weinstein [Fri, 3 Nov 2023 22:57:09 +0000 (15:57 -0700)]
Merge pull request #51784 from muahdib69/rsachere_cache_ratios
osd: make _set_cache_sizes ratio aware of cache_kv_onode_ratio
Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Adam Kupczyk [Fri, 3 Nov 2023 19:32:28 +0000 (20:32 +0100)]
doc/rados/configuration/bluestore-config-ref: Fix lowcase typo
Letter "O" got lowcased to "o".
Reverted that.
Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Adam King [Fri, 3 Nov 2023 17:55:44 +0000 (13:55 -0400)]
Merge pull request #54077 from adk3798/event-update-timestamp
mgr/cephadm: update timestamp on repeat daemon/service events
Reviewed-by: John Mulligan <jmulligan@redhat.com>
Anthony D'Atri [Fri, 3 Nov 2023 16:17:13 +0000 (12:17 -0400)]
Merge pull request #54331 from aclamk/fix-aclamk-bs-reshard-doc
Fixing example of BlueStore resharding.
Adam King [Fri, 3 Nov 2023 15:59:18 +0000 (11:59 -0400)]
Merge pull request #53747 from rkachach/fix_issue_12858
mgr/rook: Adding support to automatically discover storage classes on Rook cluster
Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@ibm.com>
Adam Kupczyk [Fri, 3 Nov 2023 15:50:19 +0000 (16:50 +0100)]
doc/rados/configuration/bluestore-config-ref: Fix lowcase typo
Letters "L P" got lowcased to "l p".
Reverted that.
Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
John Mulligan [Thu, 19 Oct 2023 13:46:58 +0000 (09:46 -0400)]
cephadm: update extract_uid_gid function annotations & format
Update the type annotations of extract_uid_gid to the type annotations
form used in more recent python versions. Reformat the function.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
John Mulligan [Thu, 19 Oct 2023 13:42:34 +0000 (09:42 -0400)]
cephadm: move extract_uid_gid func to container_types module
While extract_uid_gid isn't a perfect fit for container_types it is a
fairly fundamental function for working with containers in cephadm and
doesn't require anything beyond types in containers_types and that
module's existing imports. Moving extract_uid_gid should allow us to
more easily move other functions in the future.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
Adam King [Fri, 3 Nov 2023 15:19:34 +0000 (11:19 -0400)]
Merge pull request #54081 from phlogistonjohn/jjm-cephadm-podman-props
cephadm: move some podman specific logic to Podman methods
Reviewed-by: Adam King <adking@redhat.com>
Adam King [Fri, 3 Nov 2023 15:16:46 +0000 (11:16 -0400)]
Merge pull request #53987 from diabolocom/main
cephadm: add option to install systemd unit only
Reviewed-by: Adam King <adking@redhat.com>
Casey Bodley [Fri, 3 Nov 2023 15:04:50 +0000 (15:04 +0000)]
Merge pull request #54274 from aliakseimakarau/patch-1
doc: Update dynamicresharding.rst
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Jiffin Tony Thottan <jthottan@redhat.com>
Aliaksei Makarau [Tue, 31 Oct 2023 15:20:05 +0000 (16:20 +0100)]
doc: Update dynamicresharding.rst
"3, After resharding completed:" should be
"3. After resharding completed:"
Signed-off-by: Aliaksei Makarau <aliaksei.makarau@ibm.com>
Redouane Kachach [Fri, 3 Nov 2023 14:06:08 +0000 (15:06 +0100)]
mgr/rook: adding behave as testing python dependency
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
Rishabh Dave [Fri, 3 Nov 2023 12:39:52 +0000 (18:09 +0530)]
Merge pull request #53129 from rishabh-d-dave/xfstests-dev-deps
qa/cephfs: update dependencies for xfstests-dev
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Ilya Dryomov [Fri, 3 Nov 2023 11:55:02 +0000 (12:55 +0100)]
Merge pull request #48508 from pkalever/rbd-tests
qa/workunits/rbd: merge journal and snapshot test scripts
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Venky Shankar [Fri, 3 Nov 2023 11:29:36 +0000 (16:59 +0530)]
Merge pull request #50615 from batrick/i59119
mds: respawn standby-replay if read_pos is <= expire_pos
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Rishabh Dave [Fri, 3 Nov 2023 11:02:41 +0000 (16:32 +0530)]
Merge pull request #53611 from Patty8122/adding-useful-print
mds: Include more information in print statement in MDSRank.cc
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Rishabh Dave [Fri, 3 Nov 2023 11:01:13 +0000 (16:31 +0530)]
Merge pull request #53126 from tengjie5/origin/tmp2
cephfs-shell: getxattr fail while the xattr's length > 256
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
Redouane Kachach [Tue, 17 Oct 2023 07:31:59 +0000 (09:31 +0200)]
mgr/rook: adding e2e version based on minikube
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
Yingxin [Fri, 3 Nov 2023 08:17:00 +0000 (16:17 +0800)]
Merge pull request #54036 from xxhdx1985126/wip-seastore-clone-remap-ut
crimson/os/seastore: add unittests for transaction manager's clone/remap/read_pin and fix bugs
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Myoungwon Oh <myoungwon.oh@samsung.com>
Gabriel Benhanokh [Fri, 3 Nov 2023 06:21:22 +0000 (08:21 +0200)]
Merge pull request #53132 from benhanokh/maintain_prefix_itr_2
osd/SnapMapper:maintain the prefix_itr between calls to SnapMapper::get_next_objects_to_trim()
zdover23 [Fri, 3 Nov 2023 06:16:50 +0000 (16:16 +1000)]
Merge pull request #54322 from bluikko/patch-22
doc/cephadm/services: remove excess rendered indentation in osd.rst
Reviewed-by: Zac Dover <zac.dover@proton.me>
Ville Ojamo [Fri, 3 Nov 2023 05:44:00 +0000 (12:44 +0700)]
doc/cephadm/services: remove excess rendered indentation in osd.rst
Start bash command blocks at the left margin, removing
excessive padding/indentation that would render the
block too much towards the right.
At the same time ident the source consistently:
- Two spaces for command blocks and output blocks.
- Four spaces for notes, code blocks.
There seems to be no uniform style for this, sometimes
commands are indented with three spaces but it would
seem two spaces is common. In the end it all renders
the same I guess.
Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
Nizamudeen A [Fri, 3 Nov 2023 05:05:18 +0000 (10:35 +0530)]
Merge pull request #54048 from rhcs-dashboard/rgw-bucket-policy
mgr/dashboard: get object bucket policies for a bucket
Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
zdover23 [Fri, 3 Nov 2023 03:19:19 +0000 (13:19 +1000)]
Merge pull request #54303 from zdover23/wip-doc-2023-11-02-cephadm-troubleshooting-2-of-x
doc/cephadm: edit troubleshooting.rst (2 of x)
Reviewed-by: John Mulligan <jmulligan@redhat.com>
Casey Bodley [Thu, 2 Nov 2023 21:08:07 +0000 (21:08 +0000)]
Merge pull request #54309 from linuxbox2/wip-fix-lockguard
rgwfile: fix lock_guard decl
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Leonid Usov <leonid.usov@ibm.com>
Patrick Donnelly [Thu, 2 Nov 2023 19:41:17 +0000 (15:41 -0400)]
Merge PR #47121 into main
* refs/pull/47121/head:
mds: ensure next replay is queued on req drop
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Patrick Donnelly [Thu, 2 Nov 2023 19:40:09 +0000 (15:40 -0400)]
Merge PR #53883 into main
* refs/pull/53883/head:
mon: fix mds metadata lost in one case.
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Thu, 2 Nov 2023 19:39:12 +0000 (15:39 -0400)]
Merge PR #53636 into main
* refs/pull/53636/head:
mds: do not simplify fragset
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Gabriel BenHanokh [Wed, 14 Dec 2022 12:55:19 +0000 (12:55 +0000)]
osd/SnapMapper: maintain the prefix_itr between calls to SnapMapper::get_next_objects_to_trim()
Maintain the prefix_itr between calls to SnapMapper::get_next_objects_to_trim() to prevent searching depleted prefixes.
We got 8 distinct hash prefixes used for searching objects owned by a given PG.
On each call to SnapMapper::get_next_objects_to_trim() we start from the first prefix even after all objects mapped to it were depleted.
This means that we will be searching for 1 non-existing prefix after the first prefix was depleted, 2 after the first two prefixes were depleted... and so on until we will search 7 non-existing prefixes after the first 7 prefixes were depleted.
This is a performance improvement PR only!
It maintains the existing behavior and does not try to fix/change any of the TRIM logic.
I added an extra step after the last object is trimmed doing a full scan of the DB and only if no object was found it will return ENOENT.
This should make the new code no-worse than existing code which returns ENOENT after a full scan found no object.
It should not impact performance in real life snaps as it should only happen once per-snap.
added snap-mapper tests to rados-test-suite
disabled osd_debug_trim_objects when running (SnapMapperTest, prefix_itr) to prevent asserts(as this code does illegal inserts into DELETED snaps)
Code beautifing
Disabled the assert as there is a corner case when we retrieve the last valid object/s in a snap
The prefix_itr is advanced past the last valid value (as we completed a full scan)
If the OSD will call get_next_objects_to_trim() before the retrieved object/s was processed and removed from the SnapMapper DB it won't be found by the next call (as the prefix_itr is invalid).
The object will be found in the second-pass which will seems as if it was added after the trim was started (which is illegal) and will trigger an ASSERT
Signed-off-by: Gabriel BenHanokh <gbenhano@redhat.com>
Casey Bodley [Thu, 2 Nov 2023 18:01:46 +0000 (18:01 +0000)]
Merge pull request #54299 from ionutbalutoiu/fix-rgw-cloud-sync-multi-tenancy
rgw: fix cloud-sync multi-tenancy scenario
Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
Matt Benjamin [Thu, 2 Nov 2023 17:45:12 +0000 (13:45 -0400)]
rgwfile: fix lock_guard decl
Reported by Leonid Usov <leonid.usov@ibm.com>.
Fixes: https://tracker.ceph.com/issues/63409
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
Casey Bodley [Thu, 2 Nov 2023 14:27:13 +0000 (14:27 +0000)]
Merge pull request #53828 from smanjara/wip-sync-error-trim
rgw/multisite: fix sync_error_trim command
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Zac Dover [Thu, 2 Nov 2023 06:07:39 +0000 (16:07 +1000)]
doc/cephadm: edit troubleshooting.rst (2 of x)
Edit doc/cephadm/troubleshooting.rst. This commit and the PR of which it
is a part was raised in response to https://github.com/ceph/ceph/pull/53976.
Co-authored-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
Prasanna Kumar Kalever [Mon, 17 Oct 2022 08:05:22 +0000 (13:35 +0530)]
qa/workunits/rbd: merge journal and snapshot test scripts
The idea is to avoid the maintenance of duplicate code in both the journal
and snapshot test scripts.
Usage:
RBD_MIRROR_MODE=journal rbd_mirror.sh
Use environment variable RBD_MIRROR_MODE to set the mode
Available modes: snapshot | journal
Fixes: https://tracker.ceph.com/issues/54312
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Igor Fedotov [Thu, 2 Nov 2023 12:21:05 +0000 (15:21 +0300)]
Merge pull request #49486 from ifed01/wip-ifed-fix-rados-pybind
pybind/rados: fix missed changes for PEP484 style type annotations
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Ronen Friedman [Thu, 2 Nov 2023 10:27:46 +0000 (12:27 +0200)]
Merge pull request #53843 from ronen-fr/wip-rf-1b1
osd/scrub: reserve replicas in OSD order, one by one
Reviewed-by: Samuel Just <sjust@redhat.com>
Nizamudeen A [Tue, 17 Oct 2023 04:34:33 +0000 (10:04 +0530)]
mgr/dashboard: get object bucket policies for a bucket
Getting the bucket details will also fetch the bucket policy if its set.
Fixes: https://tracker.ceph.com/issues/63221
Signed-off-by: Nizamudeen A <nia@redhat.com>
Xuehan Xu [Tue, 31 Oct 2023 12:42:56 +0000 (20:42 +0800)]
crimson/os/seastore/lba_manager: rename clone_extent to clone_mapping
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Xuehan Xu [Mon, 16 Oct 2023 03:58:32 +0000 (11:58 +0800)]
crimson/os/seastore/lba_manager: hide lba mapping ref count update away
from users of TransactionManager
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Xuehan Xu [Mon, 16 Oct 2023 08:22:31 +0000 (16:22 +0800)]
test/crimson/seastore: add unittests for clone/remap/read_pin
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Xuehan Xu [Mon, 16 Oct 2023 08:19:52 +0000 (16:19 +0800)]
crimson/os/seastore/transaction_manager: indirect lba mappings should
always have the entire original mappings as their targets
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Samuel Just [Thu, 2 Nov 2023 01:53:28 +0000 (18:53 -0700)]
Merge pull request #52261 from myoungwon/wip-ceph-dedup-tool-snap-add
tool/ceph-dedup-tool: perform dedup on snapshotted object during sample dedup
Reviewed-by: Samuel Just <sjust@redhat.com>
Ionut Balutoiu [Wed, 1 Nov 2023 16:07:58 +0000 (18:07 +0200)]
rgw: fix cloud-sync multi-tenancy scenario
At the moment, we cannot set buckets prefixed with tenant ID in the
`source_bucket` field from cloud-sync profiles (non-trivial config):
https://docs.ceph.com/en/latest/radosgw/cloud-sync-module/#non-trivial-configuration
This is because the `do_find_profile` function only searches in the
profiles configured using `bucket.name`, and it ignores `bucket.tenant`.
This is problematic in the RGW multi-tenancy scenario:
https://docs.ceph.com/en/latest/radosgw/multitenancy/#rgw-multi-tenancy
At the moment, we can only configure bucket name in the profile
`source_bucket` field. In the multi-tenancy scenario, this would sync
all the buckets (from all the tenants).
Without this fix, we cannot configure a cloud-sync profile that syncs
all the buckets from a tenant to a particular S3 target.
For example, we cannot do this:
* `tenantA/test-bucket` -> S3 target A
* `tenantB/test-bucket` -> S3 target B
* `tenantC/test-bucket` -> S3 target C
We can only do this at the moment:
* `test-bucket` -> S3 target A
If `test-bucket` is present in both `tenantA` and `tenantB`, both
buckets will be synced to S3 target A.
The idea would be to be able to do this:
* `tenantA/*` -> S3 target A
* `tenantB/*` -> S3 target B
* `tenantC/*` -> S3 target C
If `test-bucket` is present in all tenants, each tenant bucket is
synced to its own S3 target.
Fixes: https://tracker.ceph.com/issues/63395
Signed-off-by: Ionut Balutoiu <ibalutoiu@cloudbasesolutions.com>
Yuri Weinstein [Wed, 1 Nov 2023 19:09:44 +0000 (12:09 -0700)]
Merge pull request #52545 from Matan-B/wip-matanb-trim-61962
osd/OSD: fix trim_maps() - possible leak on `skip_maps`
Reviewed-by: Samuel Just <sjust@redhat.com>
Yuri Weinstein [Wed, 1 Nov 2023 19:08:42 +0000 (12:08 -0700)]
Merge pull request #50081 from NitzanMordhai/wip-nitzan-subscription-manager-rocksdb-librados
qa/*/test_envlibrados_for_rocksdb.sh: subscribe repo
Reviewed-by: Laura Flores <lflores@redhat.com>
Samuel Just [Wed, 1 Nov 2023 17:45:39 +0000 (10:45 -0700)]
Merge pull request #52171 from myoungwon/wip-ceph-dedup-tool-improve-print
tool/ceph-dedup-tool: improve the progress report
Reviewed-by: Samuel Just <sjust@redhat.com>
Ilya Dryomov [Wed, 1 Nov 2023 17:18:40 +0000 (18:18 +0100)]
Merge pull request #53346 from linuxbox2/wip-build-fio
cmake: BuildFIO.cmake should not introduce -std=gnu++17
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Adam King [Wed, 1 Nov 2023 14:27:31 +0000 (10:27 -0400)]
Merge pull request #54141 from phlogistonjohn/jjm-cephadm-more-assertions
cephadm: add more deployment test assertions
Reviewed-by: Adam King <adking@redhat.com>
Matan Breizman [Wed, 1 Nov 2023 10:41:33 +0000 (12:41 +0200)]
Merge pull request #54040 from Matan-B/wip-wip-matanb-crimson-do_osd_ops_execute-v3
crimson/osd/pg: do_osd_ops_execute refactor
Reviewed-by: Samuel Just <sjust@redhat.com>
Ilya Dryomov [Wed, 1 Nov 2023 09:45:59 +0000 (10:45 +0100)]
Merge pull request #53535 from ajarr/wip-62891
qa/suites/rbd: add test to check rbd_support module recovery
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
Ilya Dryomov [Wed, 1 Nov 2023 09:44:05 +0000 (10:44 +0100)]
Merge pull request #54251 from ajarr/wip-62994
mgr/rbd_support: fix recursive locking on CreateSnapshotRequests lock
Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Igor Fedotov [Wed, 1 Nov 2023 09:38:06 +0000 (12:38 +0300)]
Merge pull request #47730 from ifed01/wip-ifed-alloc-logging
os/bluestore: assert on improper release in AvlAllocator
Reviewed-by: Pere Diaz Bou <pere-altea@hotmail.com>
Xuehan Xu [Mon, 16 Oct 2023 08:16:58 +0000 (16:16 +0800)]
test/crimson/seastore/lba_manager: skip indirect lba mappings
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Xuehan Xu [Mon, 16 Oct 2023 03:59:05 +0000 (11:59 +0800)]
crimson/os/seastore/lba_manager: copy intermediate_length when
dupicating lba mappings
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Xuehan Xu [Mon, 16 Oct 2023 03:57:39 +0000 (11:57 +0800)]
crimson/os/seastore/btree: drop unused lba mapping method
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
zdover23 [Wed, 1 Nov 2023 06:48:58 +0000 (16:48 +1000)]
Merge pull request #54281 from zdover23/wip-doc-2023-11-01-cephadm-troubleshooting-1-of-x
doc/cephadm: edit troubleshooting.rst (1 of x)
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
barakda [Wed, 1 Nov 2023 05:47:25 +0000 (07:47 +0200)]
Merge pull request #54262 from barakda/nvmeof-bump-version-v0.0.5
Update default nvmeof gw version to v0.0.5
Rishabh Dave [Wed, 1 Nov 2023 05:29:59 +0000 (10:59 +0530)]
Merge pull request #54210 from rishabh-d-dave/progress-submodule-update
add --progress flag to git submodule update commands
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Zac Dover [Wed, 1 Nov 2023 01:53:59 +0000 (11:53 +1000)]
doc/cephadm: edit troubleshooting.rst (1 of x)
Edit doc/cephadm/troubleshooting.rst. This commit and the PR of which it
is a part was raised in response to
https://github.com/ceph/ceph/pull/53976. The limits of reStructuredText
are particularly visible here in every instance of a BASH for-loop and
in every instance of a command stretched over multiple lines.
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
Casey Bodley [Tue, 31 Oct 2023 20:28:17 +0000 (20:28 +0000)]
Merge pull request #54226 from adamemerson/wip-build-experiment
build: Fix ARM build and make install-deps.sh more robust
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Tue, 31 Oct 2023 20:20:56 +0000 (20:20 +0000)]
Merge pull request #54216 from adamemerson/wip-fmt-felicity
build: fmt felicity
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Rishabh Dave [Thu, 26 Oct 2023 10:48:31 +0000 (16:18 +0530)]
cmake: add --progress flag to git submodule update commands
Ceph has lots of submodules that needs to be cloned before building
binaries from the repository. Seeing the progress when these submodules
are being cloned is useful, especially when developers/users have a
network issue or a slow network.
Signed-off-by: Rishabh Dave <ridave@redhat.com>
Patrick Donnelly [Tue, 31 Oct 2023 17:22:19 +0000 (13:22 -0400)]
Merge PR #54272 into main
* refs/pull/54272/head:
cmake: do not issue CMAKE_BUILD_TYPE warning if set
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Yuri Weinstein [Tue, 31 Oct 2023 15:07:15 +0000 (08:07 -0700)]
Merge pull request #53720 from ljflores/bz_2241104
osd: fix logic in check_pg_upmaps
Reviewed-by: Samuel Just <sjust@redhat.com>
Patrick Donnelly [Tue, 31 Oct 2023 14:54:37 +0000 (10:54 -0400)]
cmake: do not issue CMAKE_BUILD_TYPE warning if set
Fixes: b8c6ba01b262d33084b9c607d829503ac8ae25c5
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
zdover23 [Tue, 31 Oct 2023 13:34:52 +0000 (23:34 +1000)]
Merge pull request #54238 from zdover23/wip-doc-2023-10-30-rados-config-osd-config-ref-scrubbing
doc/rados: improve "scrubbing" explanation
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
barakda [Tue, 31 Oct 2023 13:15:41 +0000 (15:15 +0200)]
Update default nvmeof gw version to v0.0.5
Signed-off-by: barakda <barak.davidov@gmail.com>
Casey Bodley [Tue, 31 Oct 2023 13:03:46 +0000 (13:03 +0000)]
Merge pull request #50821 from cbodley/wip-cmake-uring
cmake: fix WITH_SYSTEM_LIBURING and make uring available outside of src/blk
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Zac Dover [Mon, 30 Oct 2023 02:19:07 +0000 (12:19 +1000)]
doc/rados: improve "scrubbing" explanation
Improve the English describing the operation of scrubbing PGs in
doc/rados/configuration/osd-config-ref.rst.
Co-authored-by: Ronen Friedman <rfriedma@redhat.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
zdover23 [Tue, 31 Oct 2023 12:02:37 +0000 (22:02 +1000)]
Merge pull request #54239 from zdover23/wip-doc-2023-10-30-glossary-bluestore
doc/glossary: improve "BlueStore" entry
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Mon, 30 Oct 2023 02:37:39 +0000 (12:37 +1000)]
doc/glossary: improve "BlueStore" entry
Initially s/backend/back end/ but then I added a little more information
about BlueStore's use of RocksDB to map object names to block locations
on disk.
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
Aashish Sharma [Tue, 31 Oct 2023 05:04:05 +0000 (10:34 +0530)]
Merge pull request #54247 from rhcs-dashboard/fix-no-multisite-error
mgr/dashboard: fix rgw multisite error when no rgw entity is present
Reviewed-by: Nizamudeen A <nia@redhat.com>
Aashish Sharma [Tue, 31 Oct 2023 05:02:13 +0000 (10:32 +0530)]
Merge pull request #54240 from rhcs-dashboard/fix-63347-main
mgr/dashboard: Block Ui fails in angular with target es2022
Reviewed-by: Nizamudeen A <nia@redhat.com>
Yuri Weinstein [Mon, 30 Oct 2023 20:30:58 +0000 (13:30 -0700)]
Merge pull request #54142 from YiteGu/add-bluestore-fragmentation-to-metrics
os/bluestore: add bluestore fragmentation micros to prometheus
Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Yuri Weinstein [Mon, 30 Oct 2023 20:30:03 +0000 (13:30 -0700)]
Merge pull request #53993 from shminjs/fix-out-and-down-osd-daemon-report
mgr: remove out&down osd from mgr daemons
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Yuri Weinstein [Mon, 30 Oct 2023 20:29:46 +0000 (13:29 -0700)]
Merge pull request #53689 from leonid-s-usov/mds-raise
common/admin_socket: add a command to raise a signal
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Yuri Weinstein [Mon, 30 Oct 2023 20:28:44 +0000 (13:28 -0700)]
Merge pull request #53563 from ifed01/wip-ifed-pg-osd-stats
osd: introduce dump_osd_pg_stats admin socket command.
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Yuri Weinstein [Mon, 30 Oct 2023 20:26:50 +0000 (13:26 -0700)]
Merge pull request #54177 from ronen-fr/wip-rf-map-msg
osd: fix use-after-move in build_incremental_map_msg()
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Matan Breizman <Matan.Brz@gmail.com>
Yuri Weinstein [Mon, 30 Oct 2023 19:59:51 +0000 (12:59 -0700)]
Merge pull request #54198 from ceph/wip-yuriw-release-process-main
docs: revised Distro Codemap, removed `octopus`, added `reef`
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Yuri Weinstein [Mon, 30 Oct 2023 18:00:16 +0000 (11:00 -0700)]
Merge pull request #54252 from rhcs-dashboard/quincy-release-notes
doc: Release notes 17.2.7 with updated dashboard info
Reviewed-by: Yuri Weinstein <yweinste@redhat.com>
Nizamudeen A [Mon, 30 Oct 2023 15:52:24 +0000 (21:22 +0530)]
doc: Release notes 17.2.7 with updated dashboard info
Signed-off-by: Nizamudeen A <nia@redhat.com>
Adam Emerson [Thu, 26 Oct 2023 23:11:12 +0000 (19:11 -0400)]
build: Fix `WITH_FMT_HEADER_ONLY`
Previously it was still linking in the submodule's static libraries
and ldd showed it linking to the system fmt's shared libraries.
Signed-off-by: Adam Emerson <aemerson@redhat.com>
Redouane Kachach [Fri, 29 Sep 2023 14:17:51 +0000 (16:17 +0200)]
mgr/rook: Adding support to automatically discover storage classes
Fixes: https://tracker.ceph.com/issues/63038
Fixes: https://tracker.ceph.com/issues/63338
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
Ramana Raja [Mon, 30 Oct 2023 15:05:27 +0000 (11:05 -0400)]
mgr/rbd_support: remove CreateSnapshotRequests __del__()
There is no need for CreateSnapshotRequests.__del__() that calls
CreateSnapshotRequests.wait_for_pending().
MirrorSnapshotScheduleHandler.shutdown() already calls
CreateSnapshotRequests.wait_for_pending().
Signed-off-by: Ramana Raja <rraja@redhat.com>
Ramana Raja [Thu, 26 Oct 2023 17:18:52 +0000 (13:18 -0400)]
mgr/rbd_support: fix recursive locking on CreateSnapshotRequests lock
The MirrorSnapshotScheduleHandler's run thread issues asynchronous
create snapshot requests using a CreateSnapshotRequests instance. When
the thread invokes a CreateSnapshotRequests instance's get_ioctx(),
the instance's class variable lock is acquired. With the class
variable lock held, the garbage collection of a CreateSnapshotRequests
instance may race in the thread. The thread would then call
CreateSnapshotRequests __del__() that tries to acquire the class
variable lock that the thread already holds. Fix this
recursive deadlock by converting the CreateSnapshotRequests lock from
a class variable to an instance variable. There is no need to share
the lock across CreateSnapshotRequests instances.
Also convert MirrorSnapshotScheduleHandler, PerfHandler and
TrashPurgeScheduleHandler class variables to instance variables
that don't need to be shared across the instances.
Fixes: https://tracker.ceph.com/issues/62994
Signed-off-by: Ramana Raja <rraja@redhat.com>
Co-Authored-By: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Mon, 30 Oct 2023 15:59:51 +0000 (16:59 +0100)]
Merge pull request #54246 from ceph/epuertat-patch-1
create-backport-trackers: pin to Python <3.12
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
barakda [Mon, 30 Oct 2023 15:49:55 +0000 (17:49 +0200)]
Update default nvmeof gw version to v0.0.5
Signed-off-by: barakda <barak.davidov@gmail.com>
Aashish Sharma [Mon, 30 Oct 2023 12:39:09 +0000 (18:09 +0530)]
mgr/dashboard: fix rgw multisite error when no rgw entity is present
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
Aashish Sharma [Mon, 30 Oct 2023 15:00:40 +0000 (20:30 +0530)]
Merge pull request #54241 from rhcs-dashboard/fix-63348-main
mgr/dashboard: update rgw multisite import form helper info
Reviewed-by: Nizamudeen A <nia@redhat.com>
Adam Emerson [Sat, 28 Oct 2023 17:42:59 +0000 (13:42 -0400)]
build: Add `WITH_SYSTEM_FMT` option
The `WITH_SYSTEM_FMT` option builds against system fmt and will fail
if a suitable version is not found. It is defaulted to `OFF`.
Signed-off-by: Adam Emerson <aemerson@redhat.com>
Yuri Weinstein [Mon, 30 Oct 2023 14:48:55 +0000 (07:48 -0700)]
Merge pull request #54153 from ceph/wip-yuriw-release-17.2.7-main
doc: 17.2.7 Release Notes
Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Zac Dover <zac.dover@gmail.com>