]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
3 years agocrimson/os/seastore: change Scanner to ExtentReader
Xuehan Xu [Thu, 23 Sep 2021 06:53:39 +0000 (14:53 +0800)]
crimson/os/seastore: change Scanner to ExtentReader

This commit makes Scanner an extent reader that route read requests to the corresponding
backing devices according to the device ids encapsulated in the segment ids.

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
3 years agocrimson/os/seastore: make segment managers device-id aware
Xuehan Xu [Thu, 23 Sep 2021 06:30:06 +0000 (14:30 +0800)]
crimson/os/seastore: make segment managers device-id aware

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
3 years agocrimson/os/seastore: introduce device id into segment_id_t
Xuehan Xu [Thu, 23 Sep 2021 06:23:13 +0000 (14:23 +0800)]
crimson/os/seastore: introduce device id into segment_id_t

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
3 years agoMerge pull request #43166 from rzarzynski/wip-crimson-no-subproc
Kefu Chai [Sun, 10 Oct 2021 01:42:35 +0000 (09:42 +0800)]
Merge pull request #43166 from rzarzynski/wip-crimson-no-subproc

 crush, crimson: don't support crush_location_hook as crimson lacks SubProcess

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #43346 from hjwsm1989/fix-52765
Kefu Chai [Sun, 10 Oct 2021 01:42:03 +0000 (09:42 +0800)]
Merge pull request #43346 from hjwsm1989/fix-52765

tools/ceph-kvstore-tool: fix segfaults when repair the rocksdb

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #43452 from adk3798/agent-perf1
Kefu Chai [Sun, 10 Oct 2021 01:41:30 +0000 (09:41 +0800)]
Merge pull request #43452 from adk3798/agent-perf1

cephadm: agent: subtract average time of previous iterations off wait time

Reviewed-by: Michael Fritch <mfritch@suse.com>
3 years agoMerge pull request #43401 from romoh/master
Kefu Chai [Sun, 10 Oct 2021 01:38:22 +0000 (09:38 +0800)]
Merge pull request #43401 from romoh/master

src/cephadm: Add support for mariner

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
3 years agoMerge pull request #43443 from tchaikov/wip-elapsed-in-double
Kefu Chai [Sun, 10 Oct 2021 01:36:57 +0000 (09:36 +0800)]
Merge pull request #43443 from tchaikov/wip-elapsed-in-double

msg/async/ProtocolV2: cast usec to double when converting from nsec

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: dongdong tao <dongdong.tao@canonical.com>
3 years agoMerge pull request #43343 from trociny/wip-crushdiff-compat
Yuri Weinstein [Fri, 8 Oct 2021 22:22:49 +0000 (15:22 -0700)]
Merge pull request #43343 from trociny/wip-crushdiff-compat

tools/crushdiff: support old format json dump

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #43324 from neha-ojha/wip-52640
Yuri Weinstein [Fri, 8 Oct 2021 22:21:47 +0000 (15:21 -0700)]
Merge pull request #43324 from neha-ojha/wip-52640

common/options/global.yaml.in: add runtime flag for mon_max_pg_per_osd

Reviewed-by: Vikhyat Umrao <vikhyat@redhat.com>
3 years agoMerge pull request #43232 from Rethan/feat-bluestore-fail-eio
Yuri Weinstein [Fri, 8 Oct 2021 22:21:08 +0000 (15:21 -0700)]
Merge pull request #43232 from Rethan/feat-bluestore-fail-eio

os/bluestore: add option for bluestore fail eio

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
3 years agoMerge PR #43163 into master
Patrick Donnelly [Fri, 8 Oct 2021 18:38:35 +0000 (14:38 -0400)]
Merge PR #43163 into master

* refs/pull/43163/head:
qa: fsync dir for asynchronous creat on stray tests
qa: refactor and generalize create_n_files
qa: only set frag confs for workloads
mds: improve debugging for fragment size check

Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
3 years agoMerge pull request #43462 from Zhiwei-Dai/wip-test-erasure-code-for-aarch64
Kefu Chai [Fri, 8 Oct 2021 15:24:13 +0000 (23:24 +0800)]
Merge pull request #43462 from Zhiwei-Dai/wip-test-erasure-code-for-aarch64

qa: support isal ec test for aarch64

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #43444 from idryomov/wip-read-from-replica-comment
Ilya Dryomov [Fri, 8 Oct 2021 11:43:27 +0000 (13:43 +0200)]
Merge pull request #43444 from idryomov/wip-read-from-replica-comment

librados,librbd: make it clear that replica reads are safe for general use

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #43137 from rhcs-dashboard/fix-52480-master
Ernesto Puerta [Fri, 8 Oct 2021 08:56:30 +0000 (10:56 +0200)]
Merge pull request #43137 from rhcs-dashboard/fix-52480-master

mgr/dashboard: clean-up controllers

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agoMerge pull request #43459 from cyx1231st/wip-seastore-optimize-record-overhead
Samuel Just [Fri, 8 Oct 2021 08:32:55 +0000 (01:32 -0700)]
Merge pull request #43459 from cyx1231st/wip-seastore-optimize-record-overhead

crimson/os/seastore: reduce write amplification from record overhead and implement placement hint

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
3 years agoqa: support isal ec test for aarch64 43462/head
Dai Zhiwei [Fri, 8 Oct 2021 03:54:01 +0000 (11:54 +0800)]
qa: support isal ec test for aarch64

modified:   qa/standalone/erasure-code/test-erasure-code-plugins.sh
new file:   qa/suites/rados/thrash-erasure-code-isa/arch/aarch64.yaml

Signed-off-by: Dai Zhiwei <daizhiwei3@huawei.com>
3 years agocrimson/os/seastore: implement placement_hint HOT/COLD/REWRITE 43459/head
Yingxin Cheng [Fri, 8 Oct 2021 02:47:13 +0000 (10:47 +0800)]
crimson/os/seastore: implement placement_hint HOT/COLD/REWRITE

The current strategy is to inline allocate non-REWRITE extents in order
to reduce the record overhead. The observation shows the transactions
from user is usually very small and doesn't deserve to be written in ool
records, which requires at least a block to store the record metadata.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore/epm: misc cleanup
Yingxin Cheng [Fri, 8 Oct 2021 02:33:28 +0000 (10:33 +0800)]
crimson/os/seastore/epm: misc cleanup

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore: rename ool_placement_hint_t
Yingxin Cheng [Fri, 8 Oct 2021 02:24:26 +0000 (10:24 +0800)]
crimson/os/seastore: rename ool_placement_hint_t

To placement_hint_t as the hint is not limited to ool extents.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agoMerge pull request #43248 from inspur-wyq/wip-doc
Kefu Chai [Thu, 7 Oct 2021 22:22:54 +0000 (06:22 +0800)]
Merge pull request #43248 from inspur-wyq/wip-doc

doc/rbd/vault.rst: fix typos

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #43373 from gregsfortytwo/wip-mon-stretch-new-tiebreaker-52126
Gregory Farnum [Thu, 7 Oct 2021 22:16:23 +0000 (15:16 -0700)]
Merge pull request #43373 from gregsfortytwo/wip-mon-stretch-new-tiebreaker-52126

mon: Allow specifying new tiebreaker monitors

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #43331 from adk3798/agent-drain
Kefu Chai [Thu, 7 Oct 2021 22:07:49 +0000 (06:07 +0800)]
Merge pull request #43331 from adk3798/agent-drain

mgr/cephadm: fix host drain with agent

Reviewed-by: Nizamudeen A <nia@redhat.com>
3 years agoqa: fsync dir for asynchronous creat on stray tests 43163/head
Patrick Donnelly [Tue, 14 Sep 2021 14:58:20 +0000 (10:58 -0400)]
qa: fsync dir for asynchronous creat on stray tests

Use the enhanced create_n_files to dedup code. Also split the large test
into three.

Fixes: https://tracker.ceph.com/issues/52606
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
3 years agoqa: refactor and generalize create_n_files
Patrick Donnelly [Tue, 14 Sep 2021 17:45:33 +0000 (13:45 -0400)]
qa: refactor and generalize create_n_files

Few things:

- Allow calling fsync on directory (to support async create kernel).
- Allow immediately unlinking the created file (for stray testing).
- Close any file descriptors created.
- Write unique content (the i variable) to each file.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
3 years agoqa: only set frag confs for workloads
Patrick Donnelly [Wed, 6 Oct 2021 20:37:34 +0000 (16:37 -0400)]
qa: only set frag confs for workloads

Otherwise these local conf overrides prevent functional testing.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
3 years agomds: improve debugging for fragment size check
Patrick Donnelly [Wed, 6 Oct 2021 15:09:48 +0000 (11:09 -0400)]
mds: improve debugging for fragment size check

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
3 years agoMerge pull request #43442 from linuxbox2/wip-rgwadmin-logfix
Matt Benjamin [Thu, 7 Oct 2021 15:04:16 +0000 (11:04 -0400)]
Merge pull request #43442 from linuxbox2/wip-rgwadmin-logfix

qa/rgw: fix ops log tests to handle non-bucket ops (which are now valid)

3 years agoMerge pull request #43448 from rzarzynski/wip-crimson-monmap-moredbgs
Kefu Chai [Thu, 7 Oct 2021 14:14:03 +0000 (22:14 +0800)]
Merge pull request #43448 from rzarzynski/wip-crimson-monmap-moredbgs

crimson, monmap: inform about errors when interacting with DNS

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agocephadm: agent: subtract average time of previous iterations off wait time 43452/head
Adam King [Thu, 7 Oct 2021 14:09:12 +0000 (10:09 -0400)]
cephadm: agent: subtract average time of previous iterations off wait time

We want the agent to actually report metadata at the rate we set
it for. Before this, that rate was just being used as the wait time
between iterations so the actual time between iterations was the
given interval plus the time to gather metadata. Now the time between
reports should actually be roughly the given interval.

Signed-off-by: Adam King <adking@redhat.com>
3 years agomsg/async/ProtocolV2: cast usec to double when converting from nsec 43443/head
Kefu Chai [Wed, 6 Oct 2021 22:38:13 +0000 (06:38 +0800)]
msg/async/ProtocolV2: cast usec to double when converting from nsec

to be consistent with the same logic in V1, and more importantly, it is
more correct.

the change was suggested by Ilya Dryomov <idryomov@redhat.com>.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge PR #43231 into master
Patrick Donnelly [Thu, 7 Oct 2021 13:16:34 +0000 (09:16 -0400)]
Merge PR #43231 into master

* refs/pull/43231/head:
qa: fix promotion test

Reviewed-by: Ramana Raja <rraja@redhat.com>
3 years agocrimson, monmap: inform about errors in MonMap::init_with_dns_srv(). 43448/head
Radoslaw Zarzynski [Thu, 7 Oct 2021 11:12:48 +0000 (11:12 +0000)]
crimson, monmap: inform about errors in MonMap::init_with_dns_srv().

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agocrimson, monmap: limit the scope of the seastar namespace inclusion.
Radoslaw Zarzynski [Thu, 7 Oct 2021 11:04:12 +0000 (11:04 +0000)]
crimson, monmap: limit the scope of the seastar namespace inclusion.

More consistency that way. This also enables us to define the usual
`logger()` function without having a clash with `seastar::logger`.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agoMerge pull request #43384 from bosc0/master
Venky Shankar [Thu, 7 Oct 2021 08:40:12 +0000 (14:10 +0530)]
Merge pull request #43384 from bosc0/master

mgr: Add check to prevent mgr from crashing

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agoMerge pull request #41445 from guits/cephadm_quick_patch
Kefu Chai [Wed, 6 Oct 2021 22:48:05 +0000 (06:48 +0800)]
Merge pull request #41445 from guits/cephadm_quick_patch

cephadm: add daemon_name in daemon description

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43335 from liewegas/debug-51815
Kefu Chai [Wed, 6 Oct 2021 22:45:45 +0000 (06:45 +0800)]
Merge pull request #43335 from liewegas/debug-51815

mon,auth: fix proposal (and mon db rebuild) of rotating secrets

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #43379 from myoungwon/wip-evict-range
Kefu Chai [Wed, 6 Oct 2021 22:44:33 +0000 (06:44 +0800)]
Merge pull request #43379 from myoungwon/wip-evict-range

osd: trim corresponding chunks on tier_evict

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #43378 from ivancich/wip-build-without-mgr
Kefu Chai [Wed, 6 Oct 2021 22:43:25 +0000 (06:43 +0800)]
Merge pull request #43378 from ivancich/wip-build-without-mgr

rados: build minimally when "WITH_MGR" is off

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #43360 from jianwei1216/fix-shard-threads-cannot-wakeup-bug
Kefu Chai [Wed, 6 Oct 2021 22:41:54 +0000 (06:41 +0800)]
Merge pull request #43360 from jianwei1216/fix-shard-threads-cannot-wakeup-bug

osd: fix shard-threads cannot wakeup bug

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #43307 from taodd/recv_stamp_fix
Kefu Chai [Wed, 6 Oct 2021 22:33:21 +0000 (06:33 +0800)]
Merge pull request #43307 from taodd/recv_stamp_fix

msg/async/ProtocolV2: Set the recv_stamp at the beginning of receiving a message

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Dan Hill <daniel.hill@canonical.com>
3 years agoMerge pull request #43380 from myoungwon/wip-dont-promote-dirty
Kefu Chai [Wed, 6 Oct 2021 22:31:32 +0000 (06:31 +0800)]
Merge pull request #43380 from myoungwon/wip-dont-promote-dirty

osd: do not promote objects if op is is_dirty

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #43435 from rzarzynski/wip-crimson-pickv2only
Kefu Chai [Wed, 6 Oct 2021 22:19:54 +0000 (06:19 +0800)]
Merge pull request #43435 from rzarzynski/wip-crimson-pickv2only

crimson/osd: pick only v2 addresses.

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
3 years agolibrbd: clarify rbd_read_from_replica_policy vs older options 43444/head
Ilya Dryomov [Wed, 6 Oct 2021 21:14:32 +0000 (23:14 +0200)]
librbd: clarify rbd_read_from_replica_policy vs older options

If rbd_read_from_replica_policy is set appropriately, setting
rbd_balance/localize_snap_reads or rbd_balance/localize_parent_reads
is redundant.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
3 years agolibrados: OPERATION_BALANCE/LOCALIZE_READS comment is outdated
Ilya Dryomov [Wed, 6 Oct 2021 21:14:22 +0000 (23:14 +0200)]
librados: OPERATION_BALANCE/LOCALIZE_READS comment is outdated

With the introduction of min_last_complete_ondisk on the OSD side,
it is safe to use these for non-immutable data.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
3 years agoqa/rgw: fix ops log tests to handle non-bucket ops (which are now valid) 43442/head
Matt Benjamin [Tue, 5 Oct 2021 12:17:59 +0000 (08:17 -0400)]
qa/rgw: fix ops log tests to handle non-bucket ops (which are now valid)

After 3863eb89512f1698b8e56f1f1ffc78a6ca8d5826--rgw: permit logging of
list-bucket (and any other no-bucket op-- the radosgw ops-log
contains entries for ops with no associated buckets--e.g., list_buckets.
When examining such a log object in the radosgw_admin task, don't assert
that it has any bucket name.

Fixes: https://tracker.ceph.com/issues/52647
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
3 years agoMerge pull request #43256 from rhcs-dashboard/fix-48845-master
Ernesto Puerta [Wed, 6 Oct 2021 19:49:12 +0000 (21:49 +0200)]
Merge pull request #43256 from rhcs-dashboard/fix-48845-master

qa/mgr/dashboard/test_pool: don't check HEALTH_OK

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
3 years agomgr/dashboard: clean-up controllers 43137/head
Ernesto Puerta [Tue, 7 Sep 2021 15:07:48 +0000 (17:07 +0200)]
mgr/dashboard: clean-up controllers

Fixes: https://tracker.ceph.com/issues/52589
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
3 years agoMerge pull request #42964 from trociny/wip-52448
Neha Ojha [Wed, 6 Oct 2021 16:26:16 +0000 (09:26 -0700)]
Merge pull request #42964 from trociny/wip-52448

osd: re-cache peer_bytes on every peering state activate

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agocrimson/osd: pick only v2 addresses. 43435/head
Radoslaw Zarzynski [Wed, 6 Oct 2021 11:16:31 +0000 (11:16 +0000)]
crimson/osd: pick only v2 addresses.

Otherwise we'll run into an assertion failure when binding:

```
INFO  2021-10-05 15:14:51,075 [shard 0] osd - picked address v2:0.0.0.0:0/0
INFO  2021-10-05 15:14:51,075 [shard 0] osd - picked address v1:0.0.0.0:0/0
ceph-osd: /home/jenkins-build/build/workspace/ceph-dev-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.0.0-8025-geb9c0f59/rpm/el8/BUILD/ceph-17.0.0-8025-geb9c0f59/src/crimson/net/SocketMessenger.cc:89: crimson::errorator<crimson::unthrowable_wrapper<const std::error_code&, ((const std::error_code&)(& crimson::ec<std::errc::address_in_use>))>, crimson::unthrowable_wrapper<const std::error_code&, ((const std::error_code&)(& crimson::ec<std::errc::address_not_available>))> >::future<> crimson::net::SocketMessenger::try_bind(const entity_addrvec_t&, uint32_t, uint32_t): Assertion `addrs.size() == 1' failed.
Aborting on shard 0.
```

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agoMerge PR #43399 into master
Patrick Donnelly [Wed, 6 Oct 2021 00:17:49 +0000 (20:17 -0400)]
Merge PR #43399 into master

* refs/pull/43399/head:
mgr/volumes/fs/operations: fix various flake8 issues

Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
3 years agoMerge PR #43398 into master
Patrick Donnelly [Wed, 6 Oct 2021 00:17:19 +0000 (20:17 -0400)]
Merge PR #43398 into master

* refs/pull/43398/head:
mgr/volumes/fs: fix flake8 issues

Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
3 years agoMerge PR #43397 into master
Patrick Donnelly [Wed, 6 Oct 2021 00:16:50 +0000 (20:16 -0400)]
Merge PR #43397 into master

* refs/pull/43397/head:
mgr/volumes/fs: fix flake8 issues

Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
3 years agoMerge PR #43395 into master
Patrick Donnelly [Wed, 6 Oct 2021 00:16:19 +0000 (20:16 -0400)]
Merge PR #43395 into master

* refs/pull/43395/head:
mgr/volumes/fs/operations/versions: fix various flake8 issues

Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
3 years agoMerge PR #43392 into master
Patrick Donnelly [Wed, 6 Oct 2021 00:15:47 +0000 (20:15 -0400)]
Merge PR #43392 into master

* refs/pull/43392/head:
mgr/volumes/fs/operations: fix various flake8 issues

Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
3 years agoMerge PR #43391 into master
Patrick Donnelly [Wed, 6 Oct 2021 00:15:18 +0000 (20:15 -0400)]
Merge PR #43391 into master

* refs/pull/43391/head:
mgr/volumes/fs/vol_spec.py: fix flake8 issues

Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
3 years agoMerge PR #43390 into master
Patrick Donnelly [Wed, 6 Oct 2021 00:14:49 +0000 (20:14 -0400)]
Merge PR #43390 into master

* refs/pull/43390/head:
mgr/volumes/fs/operations : Fix flake8 issues

Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
3 years agoMerge PR #43387 into master
Patrick Donnelly [Wed, 6 Oct 2021 00:14:06 +0000 (20:14 -0400)]
Merge PR #43387 into master

* refs/pull/43387/head:
mgr/volumes: fix various flake8 issues

Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
3 years agoMerge PR #43375 into master
Patrick Donnelly [Wed, 6 Oct 2021 00:13:34 +0000 (20:13 -0400)]
Merge PR #43375 into master

* refs/pull/43375/head:
mgr/volumes/fs: add extra blank line

Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
3 years agoMerge PR #43357 into master
Patrick Donnelly [Wed, 6 Oct 2021 00:12:44 +0000 (20:12 -0400)]
Merge PR #43357 into master

* refs/pull/43357/head:
mgr/nfs: stick to lazy evaluation of logger messages
mgr/nfs: change _cmd_rgw_export_create_rgw() name
mgr/nfs: don't log fsal keys
mgr/nfs: Add more debug log messages

Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
3 years agoqa: fix promotion test 43231/head
Patrick Donnelly [Tue, 21 Sep 2021 00:07:42 +0000 (20:07 -0400)]
qa: fix promotion test

The test is not needing to check that the new MDS becomes active, only
that a replacement occurs.

Fixes: https://tracker.ceph.com/issues/52677
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
3 years agoMerge pull request #42977 from amathuria/wip-amathuri-scrub-duration
Yuri Weinstein [Tue, 5 Oct 2021 14:49:03 +0000 (07:49 -0700)]
Merge pull request #42977 from amathuria/wip-amathuri-scrub-duration

osd/scrub: Add scrub duration to pg dump stats

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
3 years agoosd: wake up more shard workers when new osdmap is consumed 43360/head
Jianwei Zhang [Thu, 30 Sep 2021 06:47:01 +0000 (14:47 +0800)]
osd: wake up more shard workers when new osdmap is consumed

Reproduce:
(1) ceph cluster not running any client IO
(2) only ceph osd in osd.14 operation

Reason:
(1) one shard-queue has three shard-threads
(2) one or some PeeringOp's epoch > osdmap's epoch held by current osd,
    and these PeeringOp _add_slot_waiter()
(3) shard-queue become empty and three shard-threads cond.wait()
(4) new osdmap consume and it _wake_pg_slot()
    Problem in here
1> OSDShard::consume() exec loop all pg's slot wait
     and requeue more than one PeeringOp to shard-queue
        2> but it only notify one shard-thread to wakeup,
           the other two shard-threads continue cond.wait()
3> OSD::ShardedOpWQ::_enqueue() found the shard-queue not empty
   and not notify all shard-thread to wakeup

     In a period of time, only one shard-thread of 3 shard-threads is running.

Fixes: https://tracker.ceph.com/issues/52781
Signed-off-by: Jianwei Zhang <jianwei1216@qq.com>
Change-Id: I4617db2fd95082007e6d9fa2b60f17f2a6296b5b

3 years agoMerge pull request #43175 from ideepika/wip-supress-jaeger-cmake-logs
Deepika Upadhyay [Tue, 5 Oct 2021 08:30:50 +0000 (14:00 +0530)]
Merge pull request #43175 from ideepika/wip-supress-jaeger-cmake-logs

cmake,rgw: use jaeger-base target, as a dependency for building dbstore

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agodoc: update stretch mode documentation for new commands 43373/head
Greg Farnum [Thu, 30 Sep 2021 19:18:54 +0000 (19:18 +0000)]
doc: update stretch mode documentation for new commands

Signed-off-by: Greg Farnum <gfarnum@redhat.com>
3 years agomon: dump tiebreaker_mon in MonMap
Greg Farnum [Fri, 1 Oct 2021 18:30:25 +0000 (18:30 +0000)]
mon: dump tiebreaker_mon in MonMap

Signed-off-by: Greg Farnum <gfarnum@redhat.com>
3 years agomon: udpate MonMap::last_changed on stretch commands which didn't
Greg Farnum [Thu, 30 Sep 2021 19:05:52 +0000 (19:05 +0000)]
mon: udpate MonMap::last_changed on stretch commands which didn't

Signed-off-by: Greg Farnum <gfarnum@redhat.com>
3 years agomon: remove deleted monitors from the disallowed_leaders set
Greg Farnum [Thu, 30 Sep 2021 19:05:25 +0000 (19:05 +0000)]
mon: remove deleted monitors from the disallowed_leaders set

Signed-off-by: Greg Farnum <gfarnum@redhat.com>
3 years agomon: don't let users remove the tiebreaker monitor from the map
Greg Farnum [Fri, 1 Oct 2021 18:29:28 +0000 (18:29 +0000)]
mon: don't let users remove the tiebreaker monitor from the map

Signed-off-by: Greg Farnum <gfarnum@redhat.com>
3 years agomon: add "mon set_new_tiebreaker" command, so stretch clusters can replace it
Greg Farnum [Thu, 30 Sep 2021 19:03:49 +0000 (19:03 +0000)]
mon: add "mon set_new_tiebreaker" command, so stretch clusters can replace it

Fixes: https://tracker.ceph.com/issues/52126
Signed-off-by: Greg Farnum <gfarnum@redhat.com>
3 years agosrc/cephadm: Add mariner as a supported distro. 43401/head
Roaa Sakr [Fri, 1 Oct 2021 22:40:11 +0000 (15:40 -0700)]
src/cephadm: Add mariner as a supported distro.

Using cephadm install commands on Mariner will result in an error
"Distro not supported" though the packages are supported and can be
installed manually. This patch adds mariner as a supported distro.
Fix validated on mariner.

Signed-off-by: Roaa Sakr <romoh@microsoft.com>
3 years agoMerge pull request #43410 from zdover23/wip-doc-2021-10-04-min-hardware-typo
Josh Durgin [Mon, 4 Oct 2021 18:02:06 +0000 (11:02 -0700)]
Merge pull request #43410 from zdover23/wip-doc-2021-10-04-min-hardware-typo

docs/start: fix min. hardware rec. typo

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
3 years agodocs/start: fix min. hardware rec. typo 43410/head
Zac Dover [Mon, 4 Oct 2021 16:33:49 +0000 (02:33 +1000)]
docs/start: fix min. hardware rec. typo

The minimum hardware recommendations said that we
recommended a minimum of "24GB+ per daemon".

I changed this to read "2-4GB+ per daemon".

Reddit actually caught this one:
https://www.reddit.com/r/ceph/comments/q14ey2/cephs_mon_minimum_requirements/

Signed-off-by: Zac Dover <zac.dover@gmail.com>
3 years agocmake,rgw: use jaeger-base target, as a dependency for building dbstore 43175/head
Deepika Upadhyay [Mon, 4 Oct 2021 08:10:48 +0000 (13:40 +0530)]
cmake,rgw: use jaeger-base target, as a dependency for building dbstore

* dbstore also has tracing dependencies and missing linking for libraries
* use `using` keyword in common/tracer.cc to silence unused method
  warnings
* log building of external project jaegertracing, opentracing into build
  file, (done to reduce external project build verbosity)

Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
3 years agoMerge pull request #43402 from liewegas/doc-general-rep
Sage Weil [Sun, 3 Oct 2021 18:42:45 +0000 (13:42 -0500)]
Merge pull request #43402 from liewegas/doc-general-rep

doc/foundation: Martin is new general member rep

3 years agoMerge PR #43383 into master
Patrick Donnelly [Sat, 2 Oct 2021 16:27:40 +0000 (12:27 -0400)]
Merge PR #43383 into master

* refs/pull/43383/head:
doc: fixed typo in terminology

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
3 years agodoc/foundation: Martin is new general member rep 43402/head
Sage Weil [Sat, 2 Oct 2021 15:49:46 +0000 (10:49 -0500)]
doc/foundation: Martin is new general member rep

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agomgr/volumes/fs/operations: fix various flake8 issues 43399/head
crossbears [Fri, 1 Oct 2021 22:39:21 +0000 (18:39 -0400)]
mgr/volumes/fs/operations: fix various flake8 issues

Fixes: https://tracker.ceph.com/issues/51390
Signed-off-by: Zoey <jingyasu@my.yorku.ca>
3 years agomgr/volumes/fs/vol_spec.py: fix flake8 issues 43391/head
Eunice Lee [Fri, 1 Oct 2021 21:51:49 +0000 (14:51 -0700)]
mgr/volumes/fs/vol_spec.py: fix flake8 issues

Fixes: https://tracker.ceph.com/issues/51384
Signed-off-by: Eunice Lee <eunice337@gmail.com>
3 years agomgr/volumes/fs: fix flake8 issues 43398/head
Hargun Kaur [Fri, 1 Oct 2021 22:39:33 +0000 (22:39 +0000)]
mgr/volumes/fs: fix flake8 issues

Fixes: https://tracker.ceph.com/issues/51407
Signed-off-by: Hargun Kaur <hargunalone@gmail.com>
3 years agomgr/volumes/fs/operations/versions: fix various flake8 issues 43395/head
Gokcen Iskender [Fri, 1 Oct 2021 22:16:07 +0000 (15:16 -0700)]
mgr/volumes/fs/operations/versions: fix various flake8 issues

Fixes: https://tracker.ceph.com/issues/51403
Signed-off-by: Gokcen Iskender <gokceng@gmail.com>
3 years agomgr/volumes/fs: fix flake8 issues 43397/head
Eunice Lee [Fri, 1 Oct 2021 22:11:28 +0000 (15:11 -0700)]
mgr/volumes/fs: fix flake8 issues

Fixes: https://tracker.ceph.com/issues/51381
Signed-off-by: Eunice Lee <eunice337@gmail.com>
3 years agomgr/volumes/fs/operations: fix various flake8 issues 43392/head
Gokcen Iskender [Fri, 1 Oct 2021 21:59:06 +0000 (14:59 -0700)]
mgr/volumes/fs/operations: fix various flake8 issues

Fixes: https://tracker.ceph.com/issues/51398
Signed-off-by: Gokcen Iskender <gokceng@gmail.com>
3 years agomgr/volumes/fs/operations : Fix flake8 issues 43390/head
Anuradha Kulkarni [Fri, 1 Oct 2021 19:25:37 +0000 (15:25 -0400)]
mgr/volumes/fs/operations : Fix flake8 issues
Fixes : https://tracker.ceph.com/issues/51396

Signed-off-by: Anuradha Kulkarni <anuradhak1990@gmail.com>
3 years agomgr/volumes: fix various flake8 issues 43387/head
Almen Ng [Fri, 1 Oct 2021 18:00:20 +0000 (14:00 -0400)]
mgr/volumes: fix various flake8 issues

Fixes: https://tracker.ceph.com/issues/51380
Signed-off-by: Almen Ng <almen000509@gmail.com>
3 years agoceph-monstore-tool: include rotating keys in rebuilt mon 43335/head
Sage Weil [Wed, 29 Sep 2021 20:29:43 +0000 (16:29 -0400)]
ceph-monstore-tool: include rotating keys in rebuilt mon

This avoids an initial period after mon restart in which there are no
rotating keys and authentication can fail.

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agomon,auth: fix proposal of rotating keys
Sage Weil [Wed, 29 Sep 2021 20:28:07 +0000 (16:28 -0400)]
mon,auth: fix proposal of rotating keys

Instead of updating the live CephxKeyServer's rotating_keys and also
including them in a paxos proposal, propose new keys only in the proposal,
and only make them live once they are committed.  This keeps mons fully in
sync and avoids any inconsistency between the live behavior and committed
state (e.g., stale or divergent keys being applied and passed out to
daemons).

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoqa/suites/rados/singleton/rebuild-mon-db: debug auth 30
Sage Weil [Tue, 28 Sep 2021 17:05:22 +0000 (13:05 -0400)]
qa/suites/rados/singleton/rebuild-mon-db: debug auth 30

Hunting https://tracker.ceph.com/issues/51815

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agomon,auth: debug missing service secrets
Sage Weil [Tue, 28 Sep 2021 17:03:13 +0000 (13:03 -0400)]
mon,auth: debug missing service secrets

Hunting https://tracker.ceph.com/issues/51815

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoMerge pull request #41255 from rhcs-dashboard/angular-11-upgrade
Ernesto Puerta [Fri, 1 Oct 2021 16:13:09 +0000 (18:13 +0200)]
Merge pull request #41255 from rhcs-dashboard/angular-11-upgrade

mgr/dashboard: Angular v11 Migration

Reviewed-by: aaryanporwal <NOT@FOUND>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agoMerge pull request #42716 from sshambar/bug-52002
Ernesto Puerta [Fri, 1 Oct 2021 16:12:11 +0000 (18:12 +0200)]
Merge pull request #42716 from sshambar/bug-52002

mgr/dashboard,prometheus: fix handling of server_addr

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: sebastian-philipp <NOT@FOUND>
Reviewed-by: sshambar <NOT@FOUND>
3 years agoMerge pull request #43277 from anthonyeleven/anthonyeleven/fix-47839
zdover23 [Fri, 1 Oct 2021 14:22:22 +0000 (00:22 +1000)]
Merge pull request #43277 from anthonyeleven/anthonyeleven/fix-47839

ceph: add example BlueStore migration via the ceph-objectstore-tool dup op

Reviewed-by: Zac Dover <zac.dover@gmail.com>
3 years agoMetricCollector.h: Add check to prevent mgr from crashing 43384/head
Aswin Toni [Fri, 1 Oct 2021 14:12:22 +0000 (16:12 +0200)]
MetricCollector.h: Add check to prevent mgr from crashing

Fixes: https://tracker.ceph.com/issues/52801
Signed-off-by: Aswin Toni <aswin.toni@cern.ch>
3 years agodoc: fixed typo in terminology 43383/head
Jos Collin [Thu, 9 Sep 2021 12:49:30 +0000 (18:19 +0530)]
doc: fixed typo in terminology

Signed-off-by: Jos Collin <jcollin@redhat.com>
3 years agoosd/scrub: Add scrub duration to pg dump stats 42977/head
Aishwarya Mathuria [Tue, 24 Aug 2021 14:55:02 +0000 (20:25 +0530)]
osd/scrub: Add scrub duration to pg dump stats

Addition of a new column, SCRUB_DURATION, to the pg stats that stores the time taken for a PG scrub.

Fixes: https://tracker.ceph.com/issues/52605
Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
3 years agomgr/dashboard: Remove i18n Warning about duplicate id 41255/head
Nizamudeen A [Thu, 30 Sep 2021 11:48:14 +0000 (17:18 +0530)]
mgr/dashboard: Remove i18n Warning about duplicate id

Fixes: https://tracker.ceph.com/issues/50268
Signed-off-by: Nizamudeen A <nia@redhat.com>
3 years agomgr/dashboard: Taking care of deprecation warnings and other errors
Nizamudeen A [Thu, 30 Sep 2021 07:47:15 +0000 (13:17 +0530)]
mgr/dashboard: Taking care of deprecation warnings and other errors

1. deprecation  group is deprecated: This API is not typesafe and can result in issues with Closure Compiler renaming. Use the `FormBuilder#group` overload with `AbstractControlOptions` instead.

2. cypress/integration/rgw/users.po.ts(113,23): error TS2345: Argument of type 'void' is not assignable to parameter of type 'string'.

3. Cannot find module 'isomorphic-form-data' from 'node_modules/swagger-ui/dist/swagger-ui.js'

Fixes: https://tracker.ceph.com/issues/50268
Signed-off-by: Nizamudeen A <nia@redhat.com>
3 years agomgr/dashboard: Angular v11 Migration
Nizamudeen A [Tue, 29 Jun 2021 09:30:34 +0000 (15:00 +0530)]
mgr/dashboard: Angular v11 Migration

Fixes: https://tracker.ceph.com/issues/50268
Signed-off-by: Nizamudeen A <nia@redhat.com>
3 years agoosd: do not promote objects if op is is_dirty 43380/head
myoungwon oh [Fri, 1 Oct 2021 01:29:32 +0000 (10:29 +0900)]
osd: do not promote objects if op is is_dirty

manifest object contains object_info_t even if the object
is flushed, so OSD can reply the result of is_dirty.

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
3 years agoosd: trim corresponding chunks on tier_evict 43379/head
myoungwon oh [Fri, 1 Oct 2021 01:18:49 +0000 (10:18 +0900)]
osd: trim corresponding chunks on tier_evict

This commit trims chunks on the object even if the size of
the chunks is not equal to the object size.

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>