]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
3 years agoosd: Change description of 'dump_op_pq_state' command to be more generic
Sridhar Seshasayee [Thu, 6 Jan 2022 09:58:21 +0000 (15:28 +0530)]
osd: Change description of 'dump_op_pq_state' command to be more generic

Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
3 years agocommon: Introduce 'mclock' debug subsystem
Sridhar Seshasayee [Thu, 6 Jan 2022 09:56:20 +0000 (15:26 +0530)]
common: Introduce 'mclock' debug subsystem

Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
3 years agoMerge pull request #44410 from tchaikov/wip-cmake-cleanup
Samuel Just [Mon, 10 Jan 2022 21:36:09 +0000 (13:36 -0800)]
Merge pull request #44410 from tchaikov/wip-cmake-cleanup

cmake: detect linux/blk/zoned support

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #44502 from yuvalif/fix-call-to-mrgw
Yuval Lifshitz [Mon, 10 Jan 2022 20:05:22 +0000 (22:05 +0200)]
Merge pull request #44502 from yuvalif/fix-call-to-mrgw

rgw/multisite/test: pass zero (no) ssl port to mrgw.sh

3 years agoMerge pull request #44495 from Matan-B/wip-matanb-crimson-flavor
Matan [Mon, 10 Jan 2022 18:30:18 +0000 (20:30 +0200)]
Merge pull request #44495 from Matan-B/wip-matanb-crimson-flavor

qa/suites: Crimson flavor configuration fix

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: chunmei-liu chunmei.liu@intel.com
3 years agoMerge pull request #44221 from BenoitKnecht/ceph-mon-device-metrics
Yuri Weinstein [Mon, 10 Jan 2022 15:56:29 +0000 (07:56 -0800)]
Merge pull request #44221 from BenoitKnecht/ceph-mon-device-metrics

mon: Abort device health when device not found

Reviewed-by: Yaarit Hatuka <yaarit@redhat.com>
3 years agoMerge pull request #43362 from ybwang0211/pubsub_settingng_spell
Daniel Gryniewicz [Mon, 10 Jan 2022 15:10:51 +0000 (10:10 -0500)]
Merge pull request #43362 from ybwang0211/pubsub_settingng_spell

rgw:word spelling error in rgw/rgw_pubsub.h file

3 years agoMerge pull request #42115 from sandrobonazzola/patch-2
Sebastian Wagner [Mon, 10 Jan 2022 14:41:32 +0000 (15:41 +0100)]
Merge pull request #42115 from sandrobonazzola/patch-2

doc/install: ensure to open ceph-mon firewall ports

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agorgw/multisite/test: passzero (no) ssl port to mrgw.sh 44502/head
Yuval Lifshitz [Sun, 9 Jan 2022 16:27:40 +0000 (18:27 +0200)]
rgw/multisite/test: passzero (no) ssl port to mrgw.sh

in multisite tests script.
this is to fix an issue from: 1f3fbf218faa4859f02917828dbdb48be41a579a

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
3 years agoMerge pull request #44301 from yuvalif/wip-yuval-cloudevents
Yuval Lifshitz [Sun, 9 Jan 2022 07:32:53 +0000 (09:32 +0200)]
Merge pull request #44301 from yuvalif/wip-yuval-cloudevents

rgw/notifications: add cloudevents support to HTTP endpoint

3 years agoMerge pull request #44278 from fengchunsong/dpdk-tso
Kefu Chai [Sat, 8 Jan 2022 11:28:00 +0000 (19:28 +0800)]
Merge pull request #44278 from fengchunsong/dpdk-tso

msg/async/dpdk: Add an option to enable/disable TSO

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #44198 from wjwithagen/fix-bluestore-get-io-size
Kefu Chai [Sat, 8 Jan 2022 04:29:21 +0000 (12:29 +0800)]
Merge pull request #44198 from wjwithagen/fix-bluestore-get-io-size

common/blkdev: add missing stubs for OSes not Linux

Reviewed-by: Igor Fedotov <igor.fedotov@croit.io>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #44402 from inspur-wyq/wip-pybind-mgr
Yuri Weinstein [Fri, 7 Jan 2022 23:36:58 +0000 (15:36 -0800)]
Merge pull request #44402 from inspur-wyq/wip-pybind-mgr

pybind/mgr: fix typos

Reviewed-by: Kefu Chai <kchai@redhat.com>
3 years agoMerge pull request #44055 from ifed01/wip-ifed-cosmetics-for-optimize-rm
Yuri Weinstein [Fri, 7 Jan 2022 23:36:37 +0000 (15:36 -0800)]
Merge pull request #44055 from ifed01/wip-ifed-cosmetics-for-optimize-rm

test/store_test, os/bluestore: bunch of minor improvements/cleanups

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
3 years agoMerge pull request #43993 from SMIL-Infra/cmake-systemd-cleanup
Yuri Weinstein [Fri, 7 Jan 2022 23:35:42 +0000 (15:35 -0800)]
Merge pull request #43993 from SMIL-Infra/cmake-systemd-cleanup

cmake: cleanups about systemd and install

Reviewed-by: Kefu Chai <kchai@redhat.com>
3 years agoMerge pull request #44423 from 5cs/fix-unshare-blob-test
Igor Fedotov [Fri, 7 Jan 2022 23:27:42 +0000 (02:27 +0300)]
Merge pull request #44423 from 5cs/fix-unshare-blob-test

test: fix bluestore unshare blob test case

Reviewed-by: Igor Fedotov <igor.fedotov@croit.io>
3 years agoMerge pull request #44416 from yuvalif/wip-yuval-rgw-params-in-multisite
Casey Bodley [Fri, 7 Jan 2022 20:19:44 +0000 (15:19 -0500)]
Merge pull request #44416 from yuvalif/wip-yuval-rgw-params-in-multisite

rgw/multisite/test: allow passing rgw parameter to multisite script

Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agoMerge pull request #44020 from adk3798/host-ls-scale
Sebastian Wagner [Fri, 7 Jan 2022 10:59:04 +0000 (11:59 +0100)]
Merge pull request #44020 from adk3798/host-ls-scale

mgr/orchestrator: add filtering and count option for orch host ls

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agorgw/notifications: add cloudevents support to HTTP endpoint 44301/head
yuval Lifshitz [Mon, 13 Dec 2021 18:56:20 +0000 (20:56 +0200)]
rgw/notifications: add cloudevents support to HTTP endpoint

following the cloudevents HTTP spec:
https://github.com/cloudevents/spec/blob/v1.0.1/http-protocol-binding.md
and more specifically this aws-s3 spec:
https://github.com/cloudevents/spec/blob/main/cloudevents/adapters/aws-s3.md

Signed-off-by: yuval Lifshitz <ylifshit@redhat.com>
3 years agorgw/common: make "get" methods on RGWHTTPArgs const
yuval Lifshitz [Mon, 13 Dec 2021 16:45:19 +0000 (18:45 +0200)]
rgw/common: make "get" methods on RGWHTTPArgs const

Signed-off-by: yuval Lifshitz <ylifshit@redhat.com>
3 years agoMerge pull request #44412 from cyx1231st/wip-crimson-improve-log
Yingxin [Fri, 7 Jan 2022 07:04:46 +0000 (15:04 +0800)]
Merge pull request #44412 from cyx1231st/wip-crimson-improve-log

crimson: leverage --default-log-level to configure the global log level

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #44473 from johnbent/patch-1
Laura Flores [Thu, 6 Jan 2022 16:05:09 +0000 (10:05 -0600)]
Merge pull request #44473 from johnbent/patch-1

README.md: Update README.md to add link to tracker.ceph.com

3 years agoMerge pull request #43833 from melissa-kun-li/prevent-cephadm-stray-daemon-tcmurunner
Sebastian Wagner [Thu, 6 Jan 2022 16:00:00 +0000 (17:00 +0100)]
Merge pull request #43833 from melissa-kun-li/prevent-cephadm-stray-daemon-tcmurunner

mgr/cephadm: fix tcmu-runner cephadm_stray_daemon

3 years agoqa/suites: Fix crimson flavor configuration 44495/head
Matan Breizman [Thu, 6 Jan 2022 13:32:33 +0000 (13:32 +0000)]
qa/suites: Fix crimson flavor configuration

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
3 years agoMerge PR #44054 into master
Sage Weil [Thu, 6 Jan 2022 13:54:45 +0000 (08:54 -0500)]
Merge PR #44054 into master

* refs/pull/44054/head:
doc/rados/operations: document pg_num_max
mgr: set max of 32 pgs for .mgr pool
mgr/dashboard: expect pg_num_max property for pools
mon/OSDMonitor: add option --pg-num_max arg for create pool
mon/OSDMonitor: disallow setting pg_num < min or > max
mgr/pg_autoscaler: apply pg_num_max
mon: add pg_num_max pool property

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
3 years agoMerge pull request #44157 from CongMinYin/pwl-small-fixes
Ilya Dryomov [Thu, 6 Jan 2022 13:54:31 +0000 (14:54 +0100)]
Merge pull request #44157 from CongMinYin/pwl-small-fixes

librbd/cache/pwl: code cleanup and some minor fixes

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
3 years agolibrbd/cache/pwl: merge multiple output "<<" calls 44157/head
Yin Congmin [Tue, 4 Jan 2022 08:09:27 +0000 (16:09 +0800)]
librbd/cache/pwl: merge multiple output "<<" calls

Follow the principle of fewer "<<" calls and higher performance.
Merge multiple output "<<" calls.

Signed-off-by: Yin Congmin <congmin.yin@intel.com>
3 years agoMerge pull request #44475 from athanatos/sjust/wip-53783
Yingxin [Thu, 6 Jan 2022 01:36:06 +0000 (09:36 +0800)]
Merge pull request #44475 from athanatos/sjust/wip-53783

crimson/os/seastore/cache: fix debug macro usage

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore/cache: fix debug macro usage 44475/head
Samuel Just [Wed, 5 Jan 2022 23:46:33 +0000 (23:46 +0000)]
crimson/os/seastore/cache: fix debug macro usage

Introduced via conflict between 277e57 and 632916.

Fixes: https://tracker.ceph.com/issues/53783
Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agoREADME.md: Update README.md to add link to tracker.ceph.com 44473/head
John Bent [Wed, 5 Jan 2022 16:04:40 +0000 (09:04 -0700)]
README.md: Update README.md to add link to tracker.ceph.com

I searched the existing documentation for a link to the tracker and had a hard time finding it. Other folks like myself might like it so prominently displayed.
Added a link to https://tracker.ceph.com/projects/ceph as https://tracker.ceph.com/ is basically blank and not totally intuitive how to get to issues.

Signed-off-by: John Bent <john.bent@seagate.com>
3 years agoMerge pull request #44429 from cyx1231st/wip-crimson-improve-log-2
Samuel Just [Wed, 5 Jan 2022 20:52:18 +0000 (12:52 -0800)]
Merge pull request #44429 from cyx1231st/wip-crimson-improve-log-2

crimson/os/seastore: differentiate loggers in seastore

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #44420 from aisakaki/lru-cache
Samuel Just [Wed, 5 Jan 2022 20:34:24 +0000 (12:34 -0800)]
Merge pull request #44420 from aisakaki/lru-cache

crimson/os/seastore/cache: add lru

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agoMerge pull request #44474 from ljflores/wip-doc-integration-tests
Neha Ojha [Wed, 5 Jan 2022 18:33:55 +0000 (10:33 -0800)]
Merge pull request #44474 from ljflores/wip-doc-integration-tests

doc/.../testing_integration_tests: fix formatting of teuthology-suite option

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agodoc/.../testing_integration_tests: fix formatting of teuthology-suite option 44474/head
Laura Flores [Wed, 5 Jan 2022 16:48:53 +0000 (16:48 +0000)]
doc/.../testing_integration_tests: fix formatting of teuthology-suite option

The `--subset` teuthology-suite option should be formatted.

Signed-off-by: Laura Flores <lflores@redhat.com>
3 years agoMerge pull request #39192 from linuxbox2/wip-lc-notify
Matt Benjamin [Wed, 5 Jan 2022 14:38:47 +0000 (09:38 -0500)]
Merge pull request #39192 from linuxbox2/wip-lc-notify

rgwlc:  optionally support notifications on object expiration

3 years agoMerge pull request #44341 from sebastian-philipp/cleanup-snmp
Sebastian Wagner [Wed, 5 Jan 2022 13:34:48 +0000 (14:34 +0100)]
Merge pull request #44341 from sebastian-philipp/cleanup-snmp

mgr/cephadm: Cleanup snmp

Reviewed-by: Adam King <adking@redhat.com>
3 years agoMerge pull request #44000 from nmshelke/exception-handling-48473
Venky Shankar [Wed, 5 Jan 2022 12:25:39 +0000 (17:55 +0530)]
Merge pull request #44000 from nmshelke/exception-handling-48473

mgr/stats: exception handling for ceph fs perf stats command

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agoMerge pull request #44291 from vshankar/wip-ignore-invalid-client-op
Venky Shankar [Wed, 5 Jan 2022 12:25:06 +0000 (17:55 +0530)]
Merge pull request #44291 from vshankar/wip-ignore-invalid-client-op

mds: ignore unknown client op when tracking op latency

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agoMerge pull request #44279 from jtlayton/wip-50235
Venky Shankar [Wed, 5 Jan 2022 12:16:01 +0000 (17:46 +0530)]
Merge pull request #44279 from jtlayton/wip-50235

cephfs-shell: add the ability to mount a named filesystem

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agoMerge pull request #44158 from adk3798/agent-failed
Sebastian Wagner [Wed, 5 Jan 2022 11:28:34 +0000 (12:28 +0100)]
Merge pull request #44158 from adk3798/agent-failed

mgr/cephadm: don't include agents in CEPHADM_FAILED_DAEMON

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #44388 from rhcs-dashboard/02-host-inventory-fix
Alfonso Martínez [Wed, 5 Jan 2022 10:32:22 +0000 (11:32 +0100)]
Merge pull request #44388 from rhcs-dashboard/02-host-inventory-fix

mgr/dashboard: fix orchestrator/02-hosts-inventory.e2e failure

Reviewed-by: Waad Alkhoury <walkhour@redhat.com>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
3 years agoMerge pull request #44193 from adk3798/agent-upgrade
Sebastian Wagner [Wed, 5 Jan 2022 09:27:21 +0000 (10:27 +0100)]
Merge pull request #44193 from adk3798/agent-upgrade

mgr/cephadm: speed up upgrade when using agent

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #44266 from adk3798/http-reconfig
Sebastian Wagner [Wed, 5 Jan 2022 09:26:01 +0000 (10:26 +0100)]
Merge pull request #44266 from adk3798/http-reconfig

mgr/cephadm: reconfig agents over http

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agopython-common: move test_valid_snmp_gateway_spec from mgr/cephadm 44341/head
Sebastian Wagner [Mon, 20 Dec 2021 10:48:43 +0000 (11:48 +0100)]
python-common: move test_valid_snmp_gateway_spec from mgr/cephadm

We have to validate to_json() now as well, as we have spcial enums.
Otherwiese we might end up with !!python... representations.

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
3 years agopython-common: move test_invalid_snmp_gateway_spec from mgr/cephadm
Sebastian Wagner [Mon, 20 Dec 2021 10:37:40 +0000 (11:37 +0100)]
python-common: move test_invalid_snmp_gateway_spec from mgr/cephadm

Let's keep the tests in the same package where the class is defined.

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
3 years agomgr/cephadm: SNMP: don't write urls manually
Sebastian Wagner [Thu, 16 Dec 2021 16:57:50 +0000 (17:57 +0100)]
mgr/cephadm: SNMP: don't write urls manually

this just broken for non-trivial urls. Don't be a bad example

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
3 years agomgr/cephadm: SNMP: Don't write default values into the store
Sebastian Wagner [Thu, 16 Dec 2021 16:51:07 +0000 (17:51 +0100)]
mgr/cephadm: SNMP: Don't write default values into the store

Enable us to chage defaults in the future

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
3 years agomgr/cephadm: SNMP: use of python3 enums
Sebastian Wagner [Thu, 16 Dec 2021 16:43:47 +0000 (17:43 +0100)]
mgr/cephadm: SNMP: use of python3 enums

Little reason to duplicate things ourselves

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #44367 from sebastian-philipp/osd-count-fix-again
Sebastian Wagner [Wed, 5 Jan 2022 09:21:03 +0000 (10:21 +0100)]
Merge pull request #44367 from sebastian-philipp/osd-count-fix-again

mgr/cephadm: Fix count for OSDs with OSD specs

Reviewed-by: Adam King <adking@redhat.com>
3 years agoMerge pull request #44374 from fmount/ingress_vip
Sebastian Wagner [Wed, 5 Jan 2022 09:19:43 +0000 (10:19 +0100)]
Merge pull request #44374 from fmount/ingress_vip

mgr/cephadm: spec.virtual_ip  param should be used by the ingress daemon

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #44442 from ceph/dependabot-npm_and_yarn-src-pybind-mgr-dashboard...
Alfonso Martínez [Wed, 5 Jan 2022 09:04:58 +0000 (10:04 +0100)]
Merge pull request #44442 from ceph/dependabot-npm_and_yarn-src-pybind-mgr-dashboard-frontend-simplebar-angular-2.3.6

mgr/dashboard: bump simplebar-angular from 2.3.0 to 2.3.6 in /src/pybind/mgr/dashboard/frontend

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
3 years agoMerge pull request #44361 from xxhdx1985126/wip-53612
Samuel Just [Wed, 5 Jan 2022 05:53:24 +0000 (21:53 -0800)]
Merge pull request #44361 from xxhdx1985126/wip-53612

crimson/os/seastore/cache: add lba nodes' logical begin addresses to extent_info_t

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agoqa: test cases for ceph fs perf stats command 44000/head
Nikhilkumar Shelke [Thu, 2 Dec 2021 11:27:10 +0000 (16:57 +0530)]
qa: test cases for ceph fs perf stats command

Fixes: https://tracker.ceph.com/issues/48473
Signed-off-by: Nikhilkumar Shelke <nshelke@redhat.com>
3 years agomgr/stats: exception handling for ceph fs perf stats command
Nikhilkumar Shelke [Thu, 2 Dec 2021 11:23:50 +0000 (16:53 +0530)]
mgr/stats: exception handling for ceph fs perf stats command

Fixes: https://tracker.ceph.com/issues/48473
Signed-off-by: Nikhilkumar Shelke <nshelke@redhat.com>
3 years agoMerge pull request #44458 from cyx1231st/wip-seastore-cleanup-with-empty-transactions
Samuel Just [Wed, 5 Jan 2022 04:53:50 +0000 (20:53 -0800)]
Merge pull request #44458 from cyx1231st/wip-seastore-cleanup-with-empty-transactions

crimson/os/seastore: cleanup with empty transactions

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #44268 from lxbsz/mds-fix1
Venky Shankar [Wed, 5 Jan 2022 04:23:25 +0000 (09:53 +0530)]
Merge pull request #44268 from lxbsz/mds-fix1

mds: set hb to NULL after the memory released

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agocrimson/os/seastore: cleanup with empty transactions 44458/head
Yingxin Cheng [Fri, 17 Dec 2021 05:43:50 +0000 (13:43 +0800)]
crimson/os/seastore: cleanup with empty transactions

* Add logs to identify OSD operation that submits transaction;
* Mark empty transactions as debug log;
* Misc cleanup;

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agoMerge pull request #44329 from ljflores/wip-telemetry-last-additions
Yuri Weinstein [Tue, 4 Jan 2022 22:43:05 +0000 (14:43 -0800)]
Merge pull request #44329 from ljflores/wip-telemetry-last-additions

mgr/telemetry: add heap stats and pool application to the perf channel

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
3 years agoMerge pull request #43716 from kamoltat/wip-ksirivad-autoscale-global-flag
Yuri Weinstein [Tue, 4 Jan 2022 22:42:41 +0000 (14:42 -0800)]
Merge pull request #43716 from kamoltat/wip-ksirivad-autoscale-global-flag

mgr/autoscaler: Introduce noautoscale flag

Reviewed-by: Vikhyat Umrao <vikhyat@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agorgwlc: format event.eventName with to_event_string(...) 39192/head
Matt Benjamin [Wed, 29 Dec 2021 17:47:42 +0000 (12:47 -0500)]
rgwlc: format event.eventName with to_event_string(...)

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
3 years agorgwlc: add integration tests for lc triggered bucket notifications
yuval Lifshitz [Thu, 30 Dec 2021 16:14:03 +0000 (18:14 +0200)]
rgwlc: add integration tests for lc triggered bucket notifications

Signed-off-by: yuval Lifshitz <ylifshit@redhat.com>
3 years agorgwlc: temporary logic to compensate for rgw::sal::Bucket::get_owner() always nullptr
Matt Benjamin [Thu, 23 Dec 2021 21:51:52 +0000 (16:51 -0500)]
rgwlc: temporary logic to compensate for rgw::sal::Bucket::get_owner() always nullptr

(Acked by Daniel.)  Now with less use-after-free.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
3 years agoMerge pull request #44433 from sebastian-schmid/master
Laura Flores [Tue, 4 Jan 2022 17:21:59 +0000 (11:21 -0600)]
Merge pull request #44433 from sebastian-schmid/master

docs/start: fixes typo in hardware recommendation docs

3 years agoMerge pull request #43580 from rhcs-dashboard/cephadm_box-docs
Alfonso Martínez [Tue, 4 Jan 2022 16:24:44 +0000 (17:24 +0100)]
Merge pull request #43580 from rhcs-dashboard/cephadm_box-docs

cephadm/box: DiD box documentation

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: sebastian-philipp <sewagner@redhat.com>
3 years agoMerge pull request #43763 from rhcs-dashboard/cephadm_box
Alfonso Martínez [Tue, 4 Jan 2022 16:22:56 +0000 (17:22 +0100)]
Merge pull request #43763 from rhcs-dashboard/cephadm_box

cephadm/box: Cephadm Docker in Docker dev box

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
3 years agoMerge pull request #44449 from rhcs-dashboard/api-docs-e2e-test
Alfonso Martínez [Tue, 4 Jan 2022 16:19:48 +0000 (17:19 +0100)]
Merge pull request #44449 from rhcs-dashboard/api-docs-e2e-test

mgr/dashboard: add test coverage for API docs (SwaggerUI)

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agodocs/start: fixes typo and empty headline in hardware recommendation docs 44433/head
Sebastian Schmid [Sat, 1 Jan 2022 16:33:10 +0000 (17:33 +0100)]
docs/start: fixes typo and empty headline in hardware recommendation docs

Signed-off-by: Sebastian Schmid <mail@sebastian-schmid.de>
3 years agoMerge pull request #44428 from rhcs-dashboard/e2e-improvement
Alfonso Martínez [Tue, 4 Jan 2022 16:15:26 +0000 (17:15 +0100)]
Merge pull request #44428 from rhcs-dashboard/e2e-improvement

mgr/dashboard: stabilizing the cephadm dashboard e2e

Reviewed-by: Waad Alkhoury <walkhour@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agoMerge pull request #44453 from sebastian-philipp/mypy-cheroot-import-ssl-fix
Sebastian Wagner [Tue, 4 Jan 2022 15:11:54 +0000 (16:11 +0100)]
Merge pull request #44453 from sebastian-philipp/mypy-cheroot-import-ssl-fix

mgr/dashboard: cheroot now ships type hints

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agonotify: fix a use-after-move crash, unconstify res_id
Yuval Lifshitz [Wed, 29 Dec 2021 17:27:43 +0000 (12:27 -0500)]
notify: fix a use-after-move crash, unconstify res_id

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
3 years agorgwlc: harmonize lifecycle notifications with the others
Matt Benjamin [Wed, 22 Dec 2021 18:33:52 +0000 (13:33 -0500)]
rgwlc:  harmonize lifecycle notifications with the others

After working with notification configurations, it seemed to make
more sense to organize the different lifecycle notification sub-types
along the same lines as the official AWS ones.  So, there are now
ObjectExpirationCurrent and ObjectExpirationNoncurrent types, and
an ObjectExpiration wildcard.  Similarly, ObjectTransition
contains Current and Noncurrent sub-types.

Note that I have defined an ObjectExpirationAbortMPU notification
sub-type, but do not currently generate it--this is to avoid changing
the rgw::sal interface, but most likely we would support this in
future.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
3 years agorgwlc: optionally support notifications on object expiration
Matt Benjamin [Tue, 26 Jan 2021 17:52:47 +0000 (12:52 -0500)]
rgwlc:  optionally support notifications on object expiration

Most of the work is to remove direct knowledge of req_state from
methods in rgw_notify.

I've chosen to create new notification types matching the different
expire actions (but not transition).  The new event types are not
nested under Delete.  Notifications are sent iff rgw_lc_notify is true
(default false).

Adjusted per comments in initial review, in particular, notification from
lifecycle is no longer conditional on a config setting, and constness
is restored.

Fixes: https://tracker.ceph.com/issues/49068
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
3 years agomgr/dashboard: stabilizing the cephadm dashboard e2e 44428/head
Nizamudeen A [Thu, 30 Dec 2021 08:28:58 +0000 (13:58 +0530)]
mgr/dashboard: stabilizing the cephadm dashboard e2e

Reordering the tests and adding some more tests to verify the cluster is
healthy before proceeding to do some complex tasks like maintenance and
drain host

Fixes: https://tracker.ceph.com/issues/53742
Signed-off-by: Nizamudeen A <nia@redhat.com>
3 years agomgr/dashboard: cheroot now ships type hints 44453/head
Sebastian Wagner [Tue, 4 Jan 2022 13:56:12 +0000 (14:56 +0100)]
mgr/dashboard: cheroot now ships type hints

Now we need to prevent mypy frm complainign about a duplicated import.

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
3 years agosystemd: Set PrivateDevices=false in ceph-mon@.service 44221/head
Benoît Knecht [Mon, 6 Dec 2021 08:29:43 +0000 (09:29 +0100)]
systemd: Set PrivateDevices=false in ceph-mon@.service

The `ceph-mon` daemon needs access to block devices to check the health of the
disk that backs its DB store (#24151).

Fixes: https://tracker.ceph.com/issues/52416
Signed-off-by: Benoît Knecht <bknecht@protonmail.ch>
3 years agomon: Abort device health when device not found
Benoît Knecht [Mon, 6 Dec 2021 08:14:56 +0000 (09:14 +0100)]
mon: Abort device health when device not found

If `store->get_devname()` returns an empty device name, it means it couldn't
determine the device that backs the monitor DB store directory.

This can happen if `ceph-mon` runs with `PrivateDevices=yes` in systemd, or
within a container where the host `/dev` isn't exposed.

This commit makes sure we abort trying to get the device health at that point,
and return an appropriate error.

Signed-off-by: Benoît Knecht <bknecht@protonmail.ch>
3 years agoMerge pull request #44067 from MrFreezeex/dirfrags-test
Venky Shankar [Tue, 4 Jan 2022 09:45:41 +0000 (15:15 +0530)]
Merge pull request #44067 from MrFreezeex/dirfrags-test

qa/suites/fs: add prefetch_dirfrags false to thrasher suite

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agoMerge pull request #44255 from lxbsz/syncfs-44916
Venky Shankar [Tue, 4 Jan 2022 09:44:59 +0000 (15:14 +0530)]
Merge pull request #44255 from lxbsz/syncfs-44916

client: fix sync fs to force flush mdlog for all sessions

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agocephadm/box: remove unnecessary bash files 43763/head
Pere Diaz Bou [Tue, 4 Jan 2022 09:10:15 +0000 (10:10 +0100)]
cephadm/box: remove unnecessary bash files

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agoMerge pull request #43618 from kotreshhr/recover-symlink
Venky Shankar [Tue, 4 Jan 2022 09:09:22 +0000 (14:39 +0530)]
Merge pull request #43618 from kotreshhr/recover-symlink

mds: Store symlink target in first data object

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agoMerge pull request #44246 from yongseokoh/fix-prefetch-dirfrags
Venky Shankar [Tue, 4 Jan 2022 09:07:59 +0000 (14:37 +0530)]
Merge pull request #44246 from yongseokoh/fix-prefetch-dirfrags

mds: split _prefetch_dirfrags to avoid heartbeat timeout during up:rejoin

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agoMerge pull request #43236 from mchangir/mgr/snap_schedule-fix-db-connection-concurren...
Venky Shankar [Tue, 4 Jan 2022 09:06:07 +0000 (14:36 +0530)]
Merge pull request #43236 from mchangir/mgr/snap_schedule-fix-db-connection-concurrent-usage

mgr/snap_schedule: fix db connection concurrent usage

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agodoc/rados/operations: document pg_num_max 44054/head
Sage Weil [Wed, 15 Dec 2021 15:09:37 +0000 (10:09 -0500)]
doc/rados/operations: document pg_num_max

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agomgr: set max of 32 pgs for .mgr pool
Sage Weil [Mon, 22 Nov 2021 21:42:57 +0000 (16:42 -0500)]
mgr: set max of 32 pgs for .mgr pool

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agomgr/dashboard: expect pg_num_max property for pools
Sage Weil [Mon, 22 Nov 2021 21:42:46 +0000 (16:42 -0500)]
mgr/dashboard: expect pg_num_max property for pools

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agomon/OSDMonitor: add option --pg-num_max arg for create pool
Sage Weil [Mon, 22 Nov 2021 21:42:25 +0000 (16:42 -0500)]
mon/OSDMonitor: add option --pg-num_max arg for create pool

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agomon/OSDMonitor: disallow setting pg_num < min or > max
Sage Weil [Mon, 22 Nov 2021 23:46:13 +0000 (18:46 -0500)]
mon/OSDMonitor: disallow setting pg_num < min or > max

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agomgr/pg_autoscaler: apply pg_num_max
Sage Weil [Mon, 22 Nov 2021 21:41:10 +0000 (16:41 -0500)]
mgr/pg_autoscaler: apply pg_num_max

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agomon: add pg_num_max pool property
Sage Weil [Mon, 22 Nov 2021 21:09:00 +0000 (16:09 -0500)]
mon: add pg_num_max pool property

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agomgr/dashboard: bump simplebar-angular 44442/head
dependabot[bot] [Mon, 3 Jan 2022 16:50:17 +0000 (16:50 +0000)]
mgr/dashboard: bump simplebar-angular

Bumps simplebar-angular from 2.3.0 to 2.3.6.

---
updated-dependencies:
- dependency-name: simplebar-angular
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
3 years agoMerge pull request #44407 from ceph/dependabot/npm_and_yarn/src/pybind/mgr/dashboard...
Alfonso Martínez [Mon, 3 Jan 2022 16:47:13 +0000 (17:47 +0100)]
Merge pull request #44407 from ceph/dependabot/npm_and_yarn/src/pybind/mgr/dashboard/frontend/swagger-ui-4.1.3

build(deps): bump swagger-ui from 4.1.2 to 4.1.3 in /src/pybind/mgr/dashboard/frontend

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agomgr/dashboard: add test coverage for API docs (SwaggerUI) 44449/head
Alfonso Martínez [Mon, 3 Jan 2022 16:43:07 +0000 (17:43 +0100)]
mgr/dashboard: add test coverage for API docs (SwaggerUI)

Fixes: https://tracker.ceph.com/issues/53756
Signed-off-by: Alfonso Martínez <almartin@redhat.com>
3 years agoMerge pull request #44354 from tchaikov/cmake-cleanup
Kefu Chai [Mon, 3 Jan 2022 15:31:24 +0000 (23:31 +0800)]
Merge pull request #44354 from tchaikov/cmake-cleanup

cmake: use new CMP0127 policy

Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agoMerge pull request #43337 from ljflores/wip-bluestore-zero-detection
Laura Flores [Mon, 3 Jan 2022 15:16:32 +0000 (09:16 -0600)]
Merge pull request #43337 from ljflores/wip-bluestore-zero-detection

os/bluestore: detect unnecessary zeroes in bufferlist when data is written

3 years agoMerge pull request #44187 from rhcs-dashboard/wip-configure_dependabot-master
Alfonso Martínez [Mon, 3 Jan 2022 13:17:27 +0000 (14:17 +0100)]
Merge pull request #44187 from rhcs-dashboard/wip-configure_dependabot-master

mgr/dashboard: configure dependabot

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
3 years agoMerge pull request #44130 from LittleFox94/wip-doc-rbd-default-object-size
Ilya Dryomov [Mon, 3 Jan 2022 09:06:06 +0000 (10:06 +0100)]
Merge pull request #44130 from LittleFox94/wip-doc-rbd-default-object-size

doc: how to change default rbd object size

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
3 years agomds: ignore unknown client op when tracking op latency 44291/head
Venky Shankar [Mon, 13 Dec 2021 06:15:19 +0000 (01:15 -0500)]
mds: ignore unknown client op when tracking op latency

Server::handle_client_request() ignores unknown client operation
by returning -ENOTSUPP, however, Server::perf_gather_op_latency()
aborts on unknown client op, thereby causing -ENOTSUPP to never
reach the client. ceph_abort() seems unnecessary here.

Note, we could have invoked Server::perf_gather_op_latency()
when the return value to client is not -ENOTSUPP, however,
a valid client operation *might* just return -ENOTSUPP in
some cases.

@mchangir ran into this with his getvxattr op changes (PR #42001).

Signed-off-by: Venky Shankar <vshankar@redhat.com>
3 years agolibrbd/cache/pwl/: remove IO waited state
Yin Congmin [Fri, 3 Dec 2021 03:07:52 +0000 (11:07 +0800)]
librbd/cache/pwl/: remove IO waited state

IO waited state variables including waited_lanes, waited_entries,
waited_buffers are only used to print logs and have no practical
effect.no_space = true is enough to indicate state.

Signed-off-by: Yin Congmin <congmin.yin@intel.com>
3 years agodoc/rbd: change persistent write-back cache to persistent write log cache
Yin Congmin [Wed, 1 Dec 2021 06:37:50 +0000 (14:37 +0800)]
doc/rbd: change persistent write-back cache to persistent write log cache

The full name of PWL is persistent write log, and the full name of
RWL is replica write log. Change the title to make it consistent
with the name of the feature and better reflect its design.

Signed-off-by: Yin Congmin <congmin.yin@intel.com>
3 years agolibrbd/cache/pwl: clean code and update comments
Yin Congmin [Mon, 29 Nov 2021 03:47:52 +0000 (11:47 +0800)]
librbd/cache/pwl: clean code and update comments

some comments are outdated, some are no longger needed, update them.
remove redundant ";". remove redundant log. remove redundant "".

Signed-off-by: Yin Congmin <congmin.yin@intel.com>