]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Ilya Dryomov [Thu, 28 Dec 2023 09:52:11 +0000 (10:52 +0100)]
librbd: drop DiffIterate::diff_object_map() declaration
This is a leftover from commit
2b3a46801d39 ("librbd: switch
diff-iterate API to use new object-map diff helper").
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Thu, 28 Dec 2023 09:14:18 +0000 (10:14 +0100)]
librbd: propagate diff-iterate range to parent in fast-diff mode
When getting parent diff, pass the overlap-reduced image extent instead
of the entire 0..overlap range to avoid a similar quadratic slowdown on
cloned images.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Wed, 27 Dec 2023 17:07:05 +0000 (18:07 +0100)]
librbd/object_map: add support for ranged diff-iterate
Currently diff-iterate in fast-diff mode is performed on the entire
image no matter what image extent is passed to the API. Then, unused
diff just gets discarded as DiffIterate ends up querying only objects
that the passed image extent maps to. This hasn't been an issue for
internal consumers ("rbd du", "rbd diff", etc) because they work on the
entire image, but turns out to lead to quadratic slowdown in some QEMU
use cases.
0..UINT64_MAX range is carved out for deep-copy which is unranged by
definition. To get effectively unranged diff-iterate, 0..UINT64_MAX-1
range can be used.
Fixes: https://tracker.ceph.com/issues/63341
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Wed, 27 Dec 2023 15:18:50 +0000 (16:18 +0100)]
include/intarith: introduce round_down_to()
Same as with round_up_to(), d isn't required to be a power of two.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Sat, 23 Dec 2023 14:19:09 +0000 (15:19 +0100)]
test/librbd: expand TestMockObjectMapDiffRequest edge case coverage
For each covered edge case or error, run through the following
scenarios:
- where the edge case concerns snap_id_start
- where the edge case concerns snap_id_end
- where the edge case concerns intermediate snapshot and
snap_id_start == 0 (diff against the beginning of time)
- where the edge case concerns intermediate snapshot and
snap_id_start != 0 (diff from snapshot)
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Sat, 23 Dec 2023 13:47:54 +0000 (14:47 +0100)]
librbd/object_map: allow intermediate snaps to be skipped on diff-iterate
In case of diff-iterate against the beginning of time, the result
depends only on the end version. Loading and processing object maps
or intermediate snapshots is redundant and can be skipped.
This optimization is made possible by commit
be507aaed15f ("librbd:
diff-iterate shouldn't ever report "new hole" against a hole") and, to
a lesser extent, the previous commit.
Getting FastDiffInvalid, LoadObjectMapError and ObjectMapTooSmall to
pass required tweaking not just expectations, but also start/end snap
ids and thus also the meaning of these tests. This is addressed in the
next commit.
Fixes: https://tracker.ceph.com/issues/63341
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Fri, 22 Dec 2023 17:50:20 +0000 (18:50 +0100)]
librbd/object_map: resurrect diff-iterate behavior when image is shrunk
The new "track the largest of all versions in the set, diff state is
only ever grown" semantics introduced in commit
330f2a7bb94f ("librbd:
helper state machine for computing diffs between object-maps") don't
make sense for diff-iterate. It's a waste because DiffIterate won't
query beyond the end version size -- this is baked into the API.
Limit this behavior to deep-copy and resurrect the original behavior
from 2015 for diff-iterate.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Fri, 22 Dec 2023 15:10:12 +0000 (16:10 +0100)]
librbd/object_map: fix diff from snapshot when image is grown
Commit
399a45e11332 ("librbd/object_map: rbd diff between two
snapshots lists entire image content") fixed most of the damage caused
by commit
b81cd2460de7 ("librbd/object_map: diff state machine should
track object existence"), but the case of a "resize diff" when diffing
from snapshot was missed. An area that was freshly allocated in image
resize is the same in principle as a freshly created image and objects
marked OBJECT_EXISTS_CLEAN are no exception. Diff for such objects in
such an area should be set to DIFF_STATE_DATA_UPDATED, however
currently when diffing from snapshot, it's set to DIFF_STATE_DATA.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Wed, 20 Dec 2023 11:22:17 +0000 (12:22 +0100)]
librbd/object_map: drop bogus if in handle_load_object_map()
It became redundant with commit
b81cd2460de7 ("librbd/object_map: diff
state machine should track object existence") -- it != end_it condition
in the loop is sufficient.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Thu, 21 Dec 2023 15:50:31 +0000 (16:50 +0100)]
test/librbd: refactor TestMockObjectMapDiffRequest tests
In preparation for multiple similarly configured MockTestImageCtx
objects being used in a single test, centralize their creation and add
a couple of helpers for setting expectations from a callback.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Thu, 21 Dec 2023 17:08:21 +0000 (18:08 +0100)]
test/librbd: improve TestMockObjectMapDiffRequest.InvalidStartSnap
Use a range where only snap_id_start is invalid.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
zdover23 [Sat, 20 Jan 2024 07:34:44 +0000 (17:34 +1000)]
Merge pull request #55177 from zdover23/wip-doc-2024-01-15-radosgw-admin-get-bucket-rate-limit
doc/radosgw: edit admin.rst "Get Bucket Rate Limit"
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Sun, 14 Jan 2024 23:29:23 +0000 (09:29 +1000)]
doc/radosgw: edit admin.rst "Get Bucket Rate Limit"
Edit "Get Bucket Rate Limit" in doc/radosgw/admin.rst.
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
Venky Shankar [Fri, 19 Jan 2024 07:49:21 +0000 (13:19 +0530)]
Merge PR #54869 into main
* refs/pull/54869/head:
mds: dump sr objects in debug output
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Venky Shankar [Fri, 19 Jan 2024 07:46:19 +0000 (13:16 +0530)]
Merge PR #54915 into main
* refs/pull/54915/head:
doc/cephfs/client-auth.rst: correct `This so because` to `This is because`
doc/cephfs/client-auth.rst: correct ``fs authorize cephfs1 /dir1 client.x rw``
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Venky Shankar [Fri, 19 Jan 2024 07:34:18 +0000 (13:04 +0530)]
Merge PR #54972 into main
* refs/pull/54972/head:
src: kernel mount command returning misleading error message
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
zdover23 [Fri, 19 Jan 2024 05:54:08 +0000 (15:54 +1000)]
Merge pull request #55170 from zdover23/wip-doc-2024-01-14-radosgw-admin-set-bucket-rate-limit
doc/radosgw: edit admin.rst "set bucket rate limit"
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Igor Fedotov [Thu, 18 Jan 2024 18:31:00 +0000 (21:31 +0300)]
Merge pull request #54990 from ifed01/wip-ifed-fix-expand-with-ncb
os/bluestore: fix free space update after bdev-expand in NCB mode.
Reviewed-by: Pere Diaz Bou <pere-altea@hotmail.com>
Samuel Just [Thu, 18 Jan 2024 16:52:15 +0000 (08:52 -0800)]
Merge pull request #55188 from cyx1231st/wip-crimson-increase-obc-lru
common/options/crimson: increase crimson_osd_obc_lru_size to 512
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Casey Bodley [Thu, 18 Jan 2024 16:13:19 +0000 (16:13 +0000)]
Merge pull request #54759 from jzhu116-bloomberg/wip-63178
rgw/lc: do not add datalog/bilog for some lc actions
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Yuri Weinstein [Thu, 18 Jan 2024 15:39:25 +0000 (07:39 -0800)]
Merge pull request #54973 from Matan-B/wip-matanb-should-whiteout-helper
osd/osd/PrimaryLogPG: use should_whiteout helper in _delete_oid()
Reviewed-by: Samuel Just <sjust@redhat.com>
Yuri Weinstein [Thu, 18 Jan 2024 15:38:17 +0000 (07:38 -0800)]
Merge pull request #54780 from jianwei1216/log_to_syslog_main
common: LogClient do not output meaningless logs by default
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Yuri Weinstein [Thu, 18 Jan 2024 15:37:34 +0000 (07:37 -0800)]
Merge pull request #54116 from EdwardVitor/fix-warning-mon
mon: resolve warning about inconsistent variable types
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
zdover23 [Thu, 18 Jan 2024 10:41:38 +0000 (20:41 +1000)]
Merge pull request #55161 from tobydarling/patch-2
doc/rados/operations: Fix off-by-one erors in control.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Matan Breizman [Thu, 18 Jan 2024 10:22:49 +0000 (12:22 +0200)]
Merge pull request #55172 from Matan-B/wip-matanb-crimson-neorados
rados_api_tests: Crimson Skip unsupported
Reviewed-by: Samuel Just <sjust@redhat.com>
Matan Breizman [Thu, 18 Jan 2024 10:06:49 +0000 (12:06 +0200)]
Merge pull request #53281 from xxhdx1985126/wip-crimson-recover-snapset
crimson/osd/pg: set obc's ssc when handling pull responses
Matan Breizman [Thu, 18 Jan 2024 10:05:04 +0000 (12:05 +0200)]
Merge pull request #55202 from zhscn/fix-ssc
crimson/osd: get SnapSetContext from head_obc
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
neeraj pratap singh [Wed, 20 Dec 2023 08:45:35 +0000 (14:15 +0530)]
src: kernel mount command returning misleading error message
Fixes: https://tracker.ceph.com/issues/63866
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
Aashish Sharma [Thu, 18 Jan 2024 08:03:49 +0000 (13:33 +0530)]
Merge pull request #53814 from rhcs-dashboard/fix-61720-main
mgr/dashboard: upgrade from old 'graph' type panels to the new 'timeseries' panel
Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Redouane Kachach [Thu, 18 Jan 2024 05:55:38 +0000 (06:55 +0100)]
Merge pull request #55181 from rkachach/fix_issue_64027
mgr/rook: always recreate kvm default network + fix groups refresh
Venky Shankar [Thu, 18 Jan 2024 05:02:24 +0000 (10:32 +0530)]
Merge PR #53080 into main
* refs/pull/53080/head:
mds/journal: make used_preallocated_ino crash more graceful
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Venky Shankar [Thu, 18 Jan 2024 05:00:00 +0000 (10:30 +0530)]
Merge PR #53238 into main
* refs/pull/53238/head:
mds: just wait the client flushes the snap and dirty buffer
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Venky Shankar [Thu, 18 Jan 2024 04:59:04 +0000 (10:29 +0530)]
Merge PR #54511 into main
* refs/pull/54511/head:
test/libcephfs: move the snapdiff to a dedicated binary
Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Venky Shankar [Thu, 18 Jan 2024 04:57:38 +0000 (10:27 +0530)]
Merge PR #54958 into main
* refs/pull/54958/head:
mds: func name fixup, plus, and additional log message
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Venky Shankar [Thu, 18 Jan 2024 04:55:47 +0000 (10:25 +0530)]
Merge PR #54682 into main
* refs/pull/54682/head:
qa: drop mon_host check from test_cephfs_mirror_peer_bootstrap
pybind/mgr/mirroring: drop mon_host from peer_list
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Redouane Kachach [Mon, 15 Jan 2024 12:41:06 +0000 (13:41 +0100)]
mgr/rook: always recreate kvm default network + fix groups refresh
Fixes: https://tracker.ceph.com/issues/64027
This change also includes:
- adding ~/.local/bin to path so behave binary can be found
- adding requirements.txt file for testing dependencies
- increasing timeout used to wait for tools deployment to 90s
- increasing timeout used to wait for kvm network to 20s
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
Anthony D'Atri [Wed, 17 Jan 2024 20:04:43 +0000 (15:04 -0500)]
Merge pull request #55168 from anthonyeleven/ec-table
doc/rados/operations: add EC overhead table to erasure-code.rst
Anthony D'Atri [Sat, 13 Jan 2024 17:48:58 +0000 (12:48 -0500)]
doc/rados/operations: add EC overhead table to erasure-code.rst
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Venky Shankar [Wed, 17 Jan 2024 14:29:22 +0000 (19:59 +0530)]
Merge PR #54041 into main
* refs/pull/54041/head:
qa: fix error reporting string in assert_cluster_log
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Ronen Friedman [Wed, 17 Jan 2024 12:02:26 +0000 (14:02 +0200)]
Merge pull request #55105 from ronen-fr/wip-rf-nonorecovery
osd/scrub: allow replicas to scrub even if their OSDs have ongoing backfills
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Matan Breizman [Wed, 17 Jan 2024 11:51:50 +0000 (11:51 +0000)]
qa/config/crimson_qa_overrides.yaml: Decrease lru_size for testing
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Tue, 16 Jan 2024 11:00:37 +0000 (11:00 +0000)]
test/neorados/misc: Crimson - Skip NeoRadosMisc.WriteSame
See: https://tracker.ceph.com/issues/64040
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Mon, 15 Jan 2024 14:50:15 +0000 (14:50 +0000)]
test/librados/aio_cxx: Crimson - Skip LibRadosAio.MultiReads
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Mon, 15 Jan 2024 14:47:00 +0000 (14:47 +0000)]
test/neorados/list: Seperate NeoRadosECTest from NeoRadosTest
otherwise SKIP_IF_CRIMSON won't work in this case
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Sun, 14 Jan 2024 14:05:39 +0000 (14:05 +0000)]
test/neorados/aio_cxx: Seperate NeoRadosECTest from NeoRadosTest
SKIP_IF_CRIMSON won't work here since we try to create EC pools
prior to the test being run.
Skip if the entire test instead by seperating EC tests.
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Wed, 17 Jan 2024 11:04:43 +0000 (11:04 +0000)]
test/neorados/io: Crimson - Skip NeoRadosIo.Limits
See: https://tracker.ceph.com/issues/64040
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Mon, 15 Jan 2024 14:53:17 +0000 (14:53 +0000)]
test/neorados/cls: Crimson - Skip NeoRadosCls.RemoteReads
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Zhang Song [Wed, 17 Jan 2024 02:07:46 +0000 (10:07 +0800)]
crimson/osd: fix dangling reference bug
Cherry-picked from:
3fad54e1547c2e5d8b5c54cfcdc48f2a520c3292
Signed-off-by: Zhang Song <zhangsong02@qianxin.com>
Pedro Gonzalez Gomez [Wed, 17 Jan 2024 10:03:03 +0000 (11:03 +0100)]
Merge pull request #54070 from rhcs-dashboard/add-multisite-sync-status-unit-tests
mgr/dashboard: add frontend unit tests for rgw multisite sync status card
Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Matan Breizman [Wed, 17 Jan 2024 09:39:38 +0000 (11:39 +0200)]
Merge pull request #54765 from Matan-B/wip-matanb-crimson-submit-error-cleanup
crimson/osd: submit_error_log cleanup
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Matan Breizman [Wed, 17 Jan 2024 08:51:37 +0000 (10:51 +0200)]
Merge pull request #55171 from Matan-B/wip-matanb-crimson-return-no-supp
crimson/osd/osd_operations/client_request: return OpInfo errors
Reviewed-by: Aishwarya Mathuria <amathuri@redhat.com>
Reviewed-by: chunmei-liu <chunmei.liu@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Ronen Friedman [Wed, 17 Jan 2024 08:48:33 +0000 (10:48 +0200)]
Merge pull request #55175 from ronen-fr/wip-rf-max-test-options
qa/suites/rados/thrash: modify selection of max-scrubs configuration values
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Yingxin [Wed, 17 Jan 2024 08:20:30 +0000 (16:20 +0800)]
Merge pull request #55189 from zhscn/fix-clone-indiect-mapping
crimson/os/seastore: correct the parameter passed to LBAManager::clone_mapping
Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Zhang Song [Wed, 17 Jan 2024 03:39:53 +0000 (11:39 +0800)]
crimson/osd: get SnapSetContext from head_obc
Signed-off-by: Zhang Song <zhangsong02@qianxin.com>
Laura Flores [Tue, 16 Jan 2024 19:07:10 +0000 (13:07 -0600)]
Merge pull request #55115 from ljflores/wip-tracker-63967
qa/tasks: fix syntax for deep-scrub command
Yuval Lifshitz [Tue, 16 Jan 2024 14:12:31 +0000 (16:12 +0200)]
Merge pull request #54966 from yuvalif/wip-yuval-63855
rgw/notifications: dont send notifications if op has failed
reviewed-by: cbodley
zdover23 [Tue, 16 Jan 2024 13:51:29 +0000 (23:51 +1000)]
Merge pull request #55169 from zdover23/wip-doc-2024-01-14-radosgw-admin-enable-disable-user-rate-limit
docs/radosgw: edit admin.rst "enable/disable user rate limit"
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Casey Bodley [Tue, 16 Jan 2024 13:22:30 +0000 (13:22 +0000)]
Merge pull request #55148 from cbodley/wip-63994
rgw: fix use of creds in forward_iam_request()
Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
Pedro Gonzalez Gomez [Tue, 16 Jan 2024 13:15:48 +0000 (14:15 +0100)]
Merge pull request #54803 from rhcs-dashboard/increase-plottable-graphs-dashboard
mgr/dashboard: increase the number of plottable graphs in charts
Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Matan Breizman [Sun, 14 Jan 2024 12:33:52 +0000 (12:33 +0000)]
crimson/osd/osd_operations/client_request: return OpInfo errors
See NeoRadosCls.DNE or LibRadosCls.DNE
Fixes: https://tracker.ceph.com/issues/64000
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Wed, 20 Dec 2023 08:29:45 +0000 (08:29 +0000)]
crimson/osd/pg: move maybe_submit_error_log
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Thu, 30 Nov 2023 14:57:06 +0000 (14:57 +0000)]
crimson/osd/pg: on_removal to assert empty log_entry map
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Thu, 7 Dec 2023 13:48:02 +0000 (13:48 +0000)]
crimson/osd/pg: submit_error_log cleanup
* error log completion logic is moved into maybe_submit_error_log
* renamed it and it2
* maybe_submit_error_log is moved outside of failure_func
* failure_func no longer gets rep_tid and record_error params
* log_entry_version is removed, submit_error_log returns the version instead
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Sun, 3 Dec 2023 10:27:23 +0000 (10:27 +0000)]
crimson/osd/pg: do_osd_ops_execute drop error_func_ptr
std::move to the only user instead
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Rishabh Dave [Tue, 16 Jan 2024 12:18:21 +0000 (17:48 +0530)]
Merge pull request #54484 from batrick/mds-const-mdreqref
mds: use const qualifier for MDRequestRef
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Rishabh Dave [Tue, 16 Jan 2024 12:17:21 +0000 (17:47 +0530)]
Merge pull request #54390 from shminjs/feat-purgequeue-executed-ops
mds/purgequeue: add l_pq_executed_ops counter
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Rishabh Dave [Tue, 16 Jan 2024 12:16:08 +0000 (17:46 +0530)]
Merge pull request #53670 from mchangir/mds-enqueue-all-child-frags-for-scrub-for-a-given-fragset
mds/scrub: enqueue all child frags for a given fragset
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Rishabh Dave [Tue, 16 Jan 2024 12:15:09 +0000 (17:45 +0530)]
Merge pull request #54208 from neesingh-rh/json_asok_fix
qa: fix rank_asok() to handle errors from asok commands
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Rishabh Dave [Tue, 16 Jan 2024 12:14:04 +0000 (17:44 +0530)]
Merge pull request #54381 from lxbsz/wip-cleanup-auth
mds: misc fixes for MDSAuthCaps code
Reviewed-by: Leonid Usov <leonid.usov@ibm.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Rishabh Dave [Tue, 16 Jan 2024 12:12:37 +0000 (17:42 +0530)]
Merge pull request #54406 from vshankar/wip-63482
qa: enable debug mds/client for fs/nfs suite
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Rishabh Dave [Tue, 16 Jan 2024 12:10:59 +0000 (17:40 +0530)]
Merge pull request #54519 from lxbsz/wip-63552
mds: use explicitly sized types for network and disk encoding
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Rishabh Dave [Tue, 16 Jan 2024 12:09:21 +0000 (17:39 +0530)]
Merge pull request #54590 from vshankar/wip-57087
qa: set mds config with `config set` for a particular test
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Nizamudeen A [Tue, 16 Jan 2024 12:05:23 +0000 (17:35 +0530)]
Merge pull request #55185 from rhcs-dashboard/docs-build-fix
admin/doc-requirements: bump Sphinx to 5.0.2
Reviewed-by: Matan-B <NOT@FOUND>
Aashish Sharma [Wed, 18 Oct 2023 08:23:51 +0000 (13:53 +0530)]
mgr/dashboard: add frontend unit tests for rgw multisite sync status
card
Fixes: https://tracker.ceph.com/issues/64039
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
Nizamudeen A [Tue, 16 Jan 2024 05:21:56 +0000 (10:51 +0530)]
admin/doc-requirements: bump Sphinx to 5.0.2
```
Running Sphinx v4.5.0
Sphinx version error:
The sphinxcontrib.applehelp extension used by this project needs at least Sphinx v5.0; it therefore cannot be built with this version.
```
Signed-off-by: Nizamudeen A <nia@redhat.com>
Zhang Song [Tue, 16 Jan 2024 08:13:03 +0000 (16:13 +0800)]
crimson/os/seastore: correct the parameter passed to LBAManager::clone_mapping
Signed-off-by: Zhang Song <zhangsong02@qianxin.com>
Nizamudeen A [Tue, 16 Jan 2024 07:49:20 +0000 (13:19 +0530)]
Merge pull request #55143 from afreen23/main
mgr/dashboard: Fixes multisite topology page breadcrumb
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Nizamudeen A [Tue, 16 Jan 2024 06:34:18 +0000 (12:04 +0530)]
Merge pull request #54645 from rhcs-dashboard/revert-tls-1.2-main
Revert "mgr/dashboard: allow tls 1.2 with a config option"
Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Yingxin Cheng [Tue, 16 Jan 2024 06:32:29 +0000 (14:32 +0800)]
common/options/crimson: increase crimson_osd_obc_lru_size to 512
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Pedro Gonzalez Gomez [Mon, 15 Jan 2024 10:19:32 +0000 (11:19 +0100)]
Merge pull request #55120 from rhcs-dashboard/snapshot-delete
mgr/dashboard: delete cephfs snapshot
Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: afreen23 <NOT@FOUND>
Aashish Sharma [Tue, 5 Dec 2023 05:58:25 +0000 (11:28 +0530)]
mgr/dashboard: increase the number of plottable graphs in charts
Fixes: https://tracker.ceph.com/issues/64024
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
Ronen Friedman [Sun, 14 Jan 2024 18:53:38 +0000 (20:53 +0200)]
test/scrub: modify selection of max-scrubs configuration values
As the osd-max-scrubs default was increased from 1 to (currently) 3, the
original set of optional values under rados/thrash/3-scrub-overrides are
no longer useful. This commits changes the set of optional values to
reflect the current default.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Ilya Dryomov [Sun, 14 Jan 2024 17:54:12 +0000 (18:54 +0100)]
Merge pull request #54974 from fweimer-rh/c99
GCC 14 compatibility fixes
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Zac Dover [Sun, 14 Jan 2024 10:23:25 +0000 (20:23 +1000)]
doc/radosgw: edit admin.rst "set bucket rate limit"
Edit "Set Bucket Rate Limit" in doc/radosgw/admin.rst.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Matan Breizman [Sun, 14 Jan 2024 08:37:08 +0000 (10:37 +0200)]
Merge pull request #55039 from cyx1231st/wip-crimson-alienstore-submit-concurrently
crimson/os/alienstore: submit from the alien world concurrently
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: chunmei-liu <chunmei.liu@intel.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Zac Dover [Sat, 13 Jan 2024 18:06:12 +0000 (04:06 +1000)]
docs/radosgw: edit admin.rst "enable/disable user rate limit"
Edit "Enable/Disable User Rate Limit" in doc/radosgw/admin.rst.
Signed-off-by: Zac Dover <zac.dover@proton.me>
tobydarling [Fri, 12 Jan 2024 14:10:13 +0000 (14:10 +0000)]
doc/rados/operations: Fix off-by-one errors in control.rst
Description of examples was off by one
Signed-off-by: tobydarling <anothercoffee@gmail.com>
Casey Bodley [Fri, 12 Jan 2024 16:19:11 +0000 (11:19 -0500)]
rgw/common: rgw_bl_str(bl) avoids bl.c_str()
where bl contains multiple buffer segments, c_str() has to
rellocate and copy those segments into a single buffer. use c_str()
instead, which just copies each segment into the resulting string
this allows the function to take the bufferlist argument by const ref
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Fri, 12 Jan 2024 16:08:38 +0000 (11:08 -0500)]
rgw: forward_iam_request_to_master() trims trailing null from response
fix a regression from commit
d3ad0efaee6a19c84b2af9b3dfa1b6c902674774
which changed how we parse the response bufferlist:
- std::string r = response.c_str();
+ std::string r = response.to_str();
when the response contains a trailing null character, this now ends up in
`r` and breaks json parsing in `parser.parse(r.c_str(), r.length(), 1)`
replace `response.to_str()` with `rgw_bl_str(response)` which trims
trailing nulls
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Fri, 12 Jan 2024 16:05:48 +0000 (11:05 -0500)]
test/rgw: metadata sync checkpoint waits on global 'sync' status
in testing, i was seeing meta sync checkpoints finish even though sync
hadn't started yet:
```
rgw_multi.tests: DEBUG: current meta sync status={
"sync_status": {
"info": {
"status": "building-full-sync-maps",
```
wait for the global status to reach "sync" before starting to compare
period epochs or sync markers
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Nizamudeen A [Wed, 10 Jan 2024 06:42:23 +0000 (12:12 +0530)]
mgr/dashboard: delete cephfs snapshot
Fixes: https://tracker.ceph.com/issues/63990
Signed-off-by: Nizamudeen A <nia@redhat.com>
Yingxin Cheng [Wed, 27 Dec 2023 05:16:11 +0000 (13:16 +0800)]
crimson/os/alienstore: submit from the alien world concurrently
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Casey Bodley [Thu, 11 Jan 2024 16:08:24 +0000 (16:08 +0000)]
Merge pull request #53678 from cbodley/wip-qa-rgw-upgrade-reef
qa/rgw/upgrade: add reef as a starting release
Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
Casey Bodley [Thu, 11 Jan 2024 15:28:01 +0000 (10:28 -0500)]
rgw: fix use of creds in forward_iam_request()
variable `creds` was moved into the `RGWRESTConn` constructor before being
passed into `forward_iam_request()`. change `forward_iam_request()` so
it uses the member variable from the constructor instead of taking it as
an argument
Fixes: https://tracker.ceph.com/issues/63994
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Mark Nelson [Thu, 11 Jan 2024 15:10:44 +0000 (09:10 -0600)]
Merge pull request #54882 from Svelar/isa_xor_dev
erasure-code/isa/xor_op: add neon-based region_xor implementation
Anthony D'Atri [Thu, 11 Jan 2024 14:30:47 +0000 (09:30 -0500)]
Merge pull request #55142 from zdover23/wip-doc-2024-01-11-radosgw-user-rate-limit-ops
doc/radosgw - edit admin.rst "set user rate limit"
Anthony D'Atri [Thu, 11 Jan 2024 14:21:29 +0000 (09:21 -0500)]
Merge pull request #55146 from zdover23/wip-doc-2024-01-11-radosgw-get-user-rate-limit
doc/radosgw: edit admin.rst "get user rate limit"
Zac Dover [Thu, 11 Jan 2024 13:40:25 +0000 (23:40 +1000)]
doc/radosgw: edit admin.rst "get user rate limit"
Edit "Get User Rate Limit" in doc/radosgw/admin.rst.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Afreen Misbah [Thu, 11 Jan 2024 07:49:39 +0000 (13:19 +0530)]
mgr/dashboard: Fixes multisite topology page breadcrumb
The multi-site topology page just says object in breadcrumb.
The fix adds the missing "multi-site" breadcrumb.
Fixes https://tracker.ceph.com/issues/63635
Signed-off-by: Afreen Misbah <afreen23.git@gmail.com>
Zac Dover [Thu, 11 Jan 2024 08:32:09 +0000 (18:32 +1000)]
doc/radosgw - edit admin.rst "set user rate limit"
Edit "Set User Rate Limit" in doc/radosgw/admin.rst.
Signed-off-by: Zac Dover <zac.dover@proton.me>