]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
9 months agotest/osd: Add interactive mode to ceph_test_rados_io_sequence
JonBailey1993 [Mon, 23 Sep 2024 10:23:18 +0000 (11:23 +0100)]
test/osd: Add interactive mode to ceph_test_rados_io_sequence

Reorganisers the main function to be more modular, moving functionality into a TestRunner object and anonymous namespaces.
Adds a new "interactive" test mode that allows you to direct the order of operations rather than using the preset sequences. This allows complete precise control of the tool when you want to test specific IOs.

Signed-off-by: Jon Bailey <jonathan.bailey1@ibm.com>
9 months agotest/osd: Remove unnecessary whitespace
JonBailey1993 [Thu, 19 Sep 2024 16:14:12 +0000 (17:14 +0100)]
test/osd: Remove unnecessary whitespace

Removes unnecessary whitespace in the ceph_test_rados_io_sequence class

Signed-off-by: Jon Bailey <jonathan.bailey1@ibm.com>
9 months agoMerge pull request #59706 from Matan-B/wip-matanb-cleanup-snapmap
SrinivasaBharathKanta [Tue, 15 Oct 2024 14:19:02 +0000 (19:49 +0530)]
Merge pull request #59706 from Matan-B/wip-matanb-cleanup-snapmap

osd/PG: make use of SnapMapper::update_snap_map

9 months agoMerge pull request #59844 from spuiuk/mgr_smb_add_public_addrs_cli
Adam King [Tue, 15 Oct 2024 13:43:28 +0000 (09:43 -0400)]
Merge pull request #59844 from spuiuk/mgr_smb_add_public_addrs_cli

mgr/smb: accept public_addrs on cli when creating cluster

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
9 months agoMerge pull request #60238 from anoopcs9/cephadm-add-net-raw-ctdbd
Adam King [Tue, 15 Oct 2024 13:41:49 +0000 (09:41 -0400)]
Merge pull request #60238 from anoopcs9/cephadm-add-net-raw-ctdbd

cephadm/smb: Add NET_RAW capability to deploy ctdbd

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
9 months agoMerge pull request #60221 from rhcs-dashboard/fix-68461-main
Adam King [Tue, 15 Oct 2024 13:02:34 +0000 (09:02 -0400)]
Merge pull request #60221 from rhcs-dashboard/fix-68461-main

mgr/cephadm: Update multi-site configs before deploying  daemons on rgw service create

Reviewed-by: Adam King <adking@redhat.com>
9 months agoMerge PR #60302 into main
Patrick Donnelly [Tue, 15 Oct 2024 13:01:29 +0000 (09:01 -0400)]
Merge PR #60302 into main

* refs/pull/60302/head:
doc/governance: update my CSC email
mailmap: add my ibm email

Reviewed-by: Anthony D Atri <anthony.datri@gmail.com>
9 months agoMerge pull request #60212 from VallariAg/nvmeof-labeler
Vallari Agrawal [Tue, 15 Oct 2024 07:59:41 +0000 (13:29 +0530)]
Merge pull request #60212 from VallariAg/nvmeof-labeler

labeler: add nvmeof labelers

9 months agoMerge PR #60301 into main
Patrick Donnelly [Tue, 15 Oct 2024 00:21:22 +0000 (20:21 -0400)]
Merge PR #60301 into main

* refs/pull/60301/head:
doc/governance: add new CSC members

Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Anthony D Atri <anthony.datri@gmail.com>
9 months agodoc/governance: update my CSC email 60302/head
Patrick Donnelly [Mon, 14 Oct 2024 18:57:31 +0000 (14:57 -0400)]
doc/governance: update my CSC email

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
9 months agomailmap: add my ibm email
Patrick Donnelly [Mon, 14 Oct 2024 18:50:41 +0000 (14:50 -0400)]
mailmap: add my ibm email

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
9 months agodoc/governance: add new CSC members 60301/head
Patrick Donnelly [Mon, 14 Oct 2024 16:14:53 +0000 (12:14 -0400)]
doc/governance: add new CSC members

Congratulations!

Election: https://vote.heliosvoting.org/helios/elections/f276a15a-84c5-11ef-a0e4-b69e035002b0/view
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
9 months agoMerge pull request #60158 from aclamk/wip-aclamk-bluefs-truncate-allocations
Laura Flores [Mon, 14 Oct 2024 17:19:53 +0000 (12:19 -0500)]
Merge pull request #60158 from aclamk/wip-aclamk-bluefs-truncate-allocations

os/bluestore: Make truncate() drop unused allocations

9 months agoMerge pull request #59914 from xxhdx1985126/wip-68174
Matan Breizman [Mon, 14 Oct 2024 15:51:51 +0000 (18:51 +0300)]
Merge pull request #59914 from xxhdx1985126/wip-68174

crimson/osd/pg: remove snapmapper objects when eventually removing collections at the last moment of pg deleting, just as pg meta objects

Reviewed-by: Samuel Just <sjust@redhat.com>
9 months agoMerge pull request #60169 from lee-j-sanders/wip-ljs-rmcosbench
Lee Sanders [Mon, 14 Oct 2024 15:14:49 +0000 (16:14 +0100)]
Merge pull request #60169 from lee-j-sanders/wip-ljs-rmcosbench

qa/suites/tasks/cbt.py: Deprecating cosbench from Teuthology in preparation for deletion of cosbench from CBT

9 months agoMerge pull request #59888 from phlogistonjohn/jjm-mypy-more
Adam King [Mon, 14 Oct 2024 15:11:36 +0000 (11:11 -0400)]
Merge pull request #59888 from phlogistonjohn/jjm-mypy-more

prepare mypy checking for newer python (3.12)

Reviewed-by: Adam King <adking@redhat.com>
9 months agoMerge pull request #59942 from ronen-fr/wip-rf-store2-steps
Ronen Friedman [Mon, 14 Oct 2024 12:44:55 +0000 (15:44 +0300)]
Merge pull request #59942 from ronen-fr/wip-rf-store2-steps

osd/scrub: separate shallow vs deep errors storage

Reviewed-by: Samuel Just <sjust@redhat.com>
9 months agoMerge pull request #60242 from zdover23/wip-doc-2024-10-10-SubmittingPatches-backports
Zac Dover [Mon, 14 Oct 2024 11:24:22 +0000 (21:24 +1000)]
Merge pull request #60242 from zdover23/wip-doc-2024-10-10-SubmittingPatches-backports

doc: SubmittingPatches-backports - remove backports team

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
9 months agoMerge PR #60219 into main
Venky Shankar [Mon, 14 Oct 2024 09:51:15 +0000 (15:21 +0530)]
Merge PR #60219 into main

* refs/pull/60219/head:
qa/cephfs: update earmark values to valid ones in test_volumes.py

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
9 months agoMerge pull request #60247 from leonidc/101024-fix-no-listeners
leonidc [Mon, 14 Oct 2024 08:45:27 +0000 (11:45 +0300)]
Merge pull request #60247 from leonidc/101024-fix-no-listeners

mon/nvmeofgw*: fix HA usecase when gateway has no listeners: behaves …

9 months agoMerge pull request #59905 from rhcs-dashboard/osd-perf-impr
afreen23 [Mon, 14 Oct 2024 08:22:55 +0000 (13:52 +0530)]
Merge pull request #59905 from rhcs-dashboard/osd-perf-impr

mgr/dashboard: introduce server side pagination for osds

Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>
9 months agoMerge pull request #60259 from afreen23/wip-listener-del
afreen23 [Mon, 14 Oct 2024 08:21:49 +0000 (13:51 +0530)]
Merge pull request #60259 from afreen23/wip-listener-del

mgr/dashboard: Fix listener deletion

Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>
9 months agoMerge pull request #59572 from xxhdx1985126/wip-67874
Matan Breizman [Mon, 14 Oct 2024 07:03:30 +0000 (10:03 +0300)]
Merge pull request #59572 from xxhdx1985126/wip-67874

crimson/osd/backfill_state: add the object to be pushed in the peer missing set of PeeringState

Reviewed-by: Samuel Just <sjust@redhat.com>
9 months agoMerge pull request #59878 from xxhdx1985126/wip-68147
Matan Breizman [Mon, 14 Oct 2024 07:02:21 +0000 (10:02 +0300)]
Merge pull request #59878 from xxhdx1985126/wip-68147

crimson/osd/backfill_state: push peer pg infos' last_backfills only when all objects before them are backfilled

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
9 months agoMerge pull request #60198 from ronen-fr/wip-rf-rm-recovery-2
Ronen Friedman [Sun, 13 Oct 2024 15:52:33 +0000 (18:52 +0300)]
Merge pull request #60198 from ronen-fr/wip-rf-rm-recovery-2

qa/standalone/scrub: remove TEST_recovery_scrub_2

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
9 months agoMerge pull request #59916 from xxhdx1985126/wip-68175
Matan Breizman [Sun, 13 Oct 2024 13:04:27 +0000 (16:04 +0300)]
Merge pull request #59916 from xxhdx1985126/wip-68175

crimson/osd/backfill_state: do at least one time of replica scanning if necessary in the Enqueuing state

Reviewed-by: Samuel Just <sjust@redhat.com>
9 months agoMerge pull request #59776 from xxhdx1985126/wip-68061
Matan Breizman [Sun, 13 Oct 2024 13:00:13 +0000 (16:00 +0300)]
Merge pull request #59776 from xxhdx1985126/wip-68061

crimson/osd/backfill_state: always go to Enqueuing when object is pushed during Waiting

Reviewed-by: Samuel Just <sjust@redhat.com>
9 months agoMerge pull request #59853 from xxhdx1985126/wip-crimson-pg-purge-strays
Matan Breizman [Sun, 13 Oct 2024 12:54:56 +0000 (15:54 +0300)]
Merge pull request #59853 from xxhdx1985126/wip-crimson-pg-purge-strays

crimson/osd: purge strays when PGs go clean

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
9 months agoMerge pull request #60255 from dmick/wip-fix-container-arch
Dan Mick [Fri, 11 Oct 2024 19:59:17 +0000 (12:59 -0700)]
Merge pull request #60255 from dmick/wip-fix-container-arch

container/build.sh: fix arm architecture tagging

9 months agoMerge pull request #60028 from rkachach/fix_issue_add_internal_mtls_check
Adam King [Fri, 11 Oct 2024 12:56:57 +0000 (08:56 -0400)]
Merge pull request #60028 from rkachach/fix_issue_add_internal_mtls_check

mgr/cephadm: adding config to enforce clients cert check for internal nginx (mTLS)

Reviewed-by: Adam King <adking@redhat.com>
9 months agomgr/dashboard: Fix listener deletion 60259/head
Afreen Misbah [Fri, 11 Oct 2024 08:57:24 +0000 (14:27 +0530)]
mgr/dashboard: Fix listener deletion

Listener deletion is broken due to passing wrong gateway address.
Including `traddr` in DELETE API of listener to choose correct gateway address for deletion.

The same fix we did for POST API here: https://github.com/afreen23/ceph/commit/287ff3b3603291763b3cd08f9b1543fe60d5f3b9

Fixes: https://tracker.ceph.com/issues/68506
Signed-off-by: Afreen Misbah <afreen23.git@gmail.com>
9 months agomgr/dashboard: introduce server side pagination for osds 59905/head
Nizamudeen A [Fri, 20 Sep 2024 15:05:38 +0000 (20:35 +0530)]
mgr/dashboard: introduce server side pagination for osds

Fixes: https://tracker.ceph.com/issues/56511
Signed-off-by: Nizamudeen A <nia@redhat.com>
9 months agomgr/cephadm: RGW service deployment defaults to 'default' realm/zonegroup/zone despit... 60221/head
Aashish Sharma [Wed, 9 Oct 2024 14:02:49 +0000 (19:32 +0530)]
mgr/cephadm: RGW service deployment defaults to 'default' realm/zonegroup/zone despite non-default spec in service

When we create an RGW service using the ceph orch apply command, the service is always deployed in the default realm, zonegroup, and zone, even if we specify a different realm, zonegroup, or zone in the service spec. This happens because certain configuration values, like rgw_realm, rgw_zonegroup, and rgw_zone, need to be set for the RGW instances before the daemons are deployed. Currently, these configurations are being applied after the RGW daemons are deployed, which requires a service restart to reflect the correct realm, zonegroup, and zone. Ideally, these configurations should be applied before the RGW daemons are deployed, so they are correctly placed in the desired realm, zonegroup, and zone from the start.

Fixes: https://tracker.ceph.com/issues/68461
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
9 months agoMerge pull request #59720 from myoungwon/wip-fix-overlapped-write
Yingxin [Fri, 11 Oct 2024 03:38:05 +0000 (11:38 +0800)]
Merge pull request #59720 from myoungwon/wip-fix-overlapped-write

crimson/os/seastore: fix data inconsistency during ool writes

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
9 months agocontainer/build.sh: fix arm architecture tagging 60255/head
Dan Mick [Thu, 10 Oct 2024 23:38:58 +0000 (16:38 -0700)]
container/build.sh: fix arm architecture tagging

The wrong string was used for comparison, and for tagging,
so the arm64 branch and sha1 images overwrote and destroyed
the amd64 images.

Signed-off-by: Dan Mick <dmick@redhat.com>
9 months agoMerge pull request #60147 from rhcs-dashboard/sync-policy-pipe-edit-fixes
afreen23 [Thu, 10 Oct 2024 20:30:24 +0000 (02:00 +0530)]
Merge pull request #60147 from rhcs-dashboard/sync-policy-pipe-edit-fixes

mgr/dashboard: unable to edit pipe config for bucket level policy of bucket

Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>
9 months agoMerge pull request #59045 from pereman2/ignore-pg-degrade-upgrade
Laura Flores [Thu, 10 Oct 2024 19:08:23 +0000 (14:08 -0500)]
Merge pull request #59045 from pereman2/ignore-pg-degrade-upgrade

qa/rados/upgrade: ignore PG_DEGRADED

9 months agoMerge pull request #60206 from VallariAg/wip-nvmeof-fix-test
Vallari Agrawal [Thu, 10 Oct 2024 18:14:31 +0000 (23:44 +0530)]
Merge pull request #60206 from VallariAg/wip-nvmeof-fix-test

qa/suites/nvmeof: Fix broken suite by using --no-group-append tag

9 months agoqa/standalone/scrub: remove TEST_recovery_scrub_2 60198/head
Ronen Friedman [Tue, 8 Oct 2024 13:25:56 +0000 (08:25 -0500)]
qa/standalone/scrub: remove TEST_recovery_scrub_2

That test does no longer match the actual requirements and
implementation of scrubbing.
It was already deactivated in
https://github.com/ceph/ceph/pull/59590. Here - it is
fully removed, mainly for the sake of backporting.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
9 months agoMerge pull request #60243 from zdover23/wip-doc-2024-10-10-dev-dev-guide-essentials...
Anthony D'Atri [Thu, 10 Oct 2024 16:30:12 +0000 (12:30 -0400)]
Merge pull request #60243 from zdover23/wip-doc-2024-10-10-dev-dev-guide-essentials-backporting

doc/dev: remove "Stable Releases and Backports"

9 months agoosd/scrub: modify ScrubStore contents retrieval 59942/head
Ronen Friedman [Sat, 5 Oct 2024 12:33:49 +0000 (07:33 -0500)]
osd/scrub: modify ScrubStore contents retrieval

A separate commit added a simple test to verify the new
store implementation (creating both shallow & deep errors),
scrubbing (step 1), deep scrubbing (step 2), then shallow
scrubbing again (step 3). The test verifies that
the results after step 2 include all shallow errors data (*),
and that the results after step 3 include all deep errors
data.

The test highlighted the need to correctly partition and
retrieve the "shards inconsistencies" and the "selected
shard" data, which was not fully implemented in the
previous commit. Thus, this commit adds the following:

- add_object_error() no longer filters out data saved during
  deep scrubbing; it also filters less of the shallow scrubs
  "shards inconsistencies" data;

- merge_encoded_error_wrappers() now merges the "shards
  inconsistencies" data correctly, handling the multiple
  scenarios possible.

(*) note the special case of not being able to read the
   object's version during deep scrubbing (due to a read
   error). In this case - the data collected during the
   shallow scrub will not be reported.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
9 months agoqa/standalone/scrub: test new ScrubStore implementation
Ronen Friedman [Mon, 7 Oct 2024 06:49:18 +0000 (01:49 -0500)]
qa/standalone/scrub: test new ScrubStore implementation

The ScrubStore is now comprised of two separate data
structures, one for shallow errors and one for deep.

A new test is added to verify the main objective of that
design change: shallow scrubs should not overwrite deep
scrub data.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
9 months agoosd/scrub: separate shallow vs deep errors storage
Ronen Friedman [Tue, 24 Sep 2024 04:09:51 +0000 (23:09 -0500)]
osd/scrub: separate shallow vs deep errors storage

The ScrubStore now holds two ScrubStore::at_level_t objects,
one for the shallow errors and one for the deep errors.

The shallow errors DB is recreated at the start of every scrub,
while the deep errors DB is only recreated at the start of a
deep scrub.

When queried by the operator for known scrub errors, the
ScrubStore will return the union of the errors from both
DBs.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
9 months agocommon/scrub,osd/scrub: minor cleanups to ScrubStore
Ronen Friedman [Mon, 23 Sep 2024 13:51:22 +0000 (08:51 -0500)]
common/scrub,osd/scrub: minor cleanups to ScrubStore

Including:
- introducing 'no out param' encode() for the inconsistent wrappers;
- renaming the ambiguous 'empty()' to 'is_empty()';
- removing unused code;
- a few other minor cleanups.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
9 months agocommon: extend MapCacher API
Ronen Friedman [Mon, 23 Sep 2024 10:25:05 +0000 (05:25 -0500)]
common: extend MapCacher API

to include 'no out' version of get_next()

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
9 months agoosd/scrub: add dout() capability to the ScrubStore
Ronen Friedman [Mon, 23 Sep 2024 10:15:57 +0000 (05:15 -0500)]
osd/scrub: add dout() capability to the ScrubStore

now that the ScrubSTore object is directly created by the
scrubber, (and has a lifetime that does not extend beyond
the scrubber object), we can add the same dout()
mechanism used by the other scrubber sub-objects.

Note: that mechanism will be changed shortly, so that the
sub-objects would use one prefix() creator supplied by
the Scrubber object.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
9 months agoosd/scrub: directly create or reinit the ScrubStore
Ronen Friedman [Mon, 23 Sep 2024 08:58:59 +0000 (03:58 -0500)]
osd/scrub: directly create or reinit the ScrubStore

The ScrubStore is now directly created or reinitialized by the
Scrubber. Note that the store object is not identical to the
errors DB: the errors DB is an entity in the OSD store (a
collection of OMap entries in a uniquely-named object(s)),
while the ScrubSTore object is a cacher and accessor for
that entity. That one can be recreated or disposed of at
will.

We now do not recreate the ScrubStore object for every scrub.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
9 months agoosd/scrub: introduce ScrubStore::at_level_t
Ronen Friedman [Mon, 23 Sep 2024 06:59:30 +0000 (01:59 -0500)]
osd/scrub: introduce ScrubStore::at_level_t

to hold the caching and backend details related to the representation
of scrub-detected errors as OMap entries of a uniquely-named object.

In a followup commit - the ScrubStore is modified to hold two of
these objects, one for the shallow errors and one for the deep errors.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
9 months agomon/nvmeofgw*: fix HA usecase when gateway has no listeners: behaves like no-subsystems 60247/head
Leonid Chernin [Wed, 9 Oct 2024 06:59:09 +0000 (06:59 +0000)]
mon/nvmeofgw*: fix HA usecase when gateway has no listeners: behaves like no-subsystems

Signed-off-by: Leonid Chernin <leonidc@il.ibm.com>
9 months agoMerge PR #60011 into main
Patrick Donnelly [Thu, 10 Oct 2024 12:32:09 +0000 (08:32 -0400)]
Merge PR #60011 into main

* refs/pull/60011/head:
qa: do not fail cephfs QA tests for slow bluestore ops

Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
9 months agomgr/dashboard: unable to edit pipe config for bucket level policy of a bucket 60147/head
Naman Munet [Mon, 7 Oct 2024 05:11:29 +0000 (10:41 +0530)]
mgr/dashboard: unable to edit pipe config for bucket level policy of a bucket

Fixes: https://tracker.ceph.com/issues/68387
Fixes Includes:
1) Passing additional parameter for 'user' and 'mode' as the user can be either system/dashboard or other values while creating pipe.
2) Previously while removing the src/dest bucket field, we were getting same old values on editing pipe, but now it will become '*' if empty value passed from frontend.

Signed-off-by: Naman Munet <namanmunet@li-ff83bccc-26af-11b2-a85c-a4b04bfb1003.ibm.com>
9 months agodoc/dev: remove "Stable Releases and Backports" 60243/head
Zac Dover [Thu, 10 Oct 2024 12:17:12 +0000 (22:17 +1000)]
doc/dev: remove "Stable Releases and Backports"

Remove mention of "Stable Releases and Backports" from
doc/dev/developer_guide/essentials.rst.

Co-authored-by: Laura Flores <lflores@ibm.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
9 months agoMerge pull request #59987 from kotreshhr/licephfs-aio-nfsganesha
Venky Shankar [Thu, 10 Oct 2024 12:11:49 +0000 (17:41 +0530)]
Merge pull request #59987 from kotreshhr/licephfs-aio-nfsganesha

client: Fix libcephfs aio metadata corruption.

Reviewed-by: Venky Shankar <vshankar@redhat.com>
9 months agodoc: SubmittingPatches-backports - remove backports team 60242/head
Zac Dover [Thu, 10 Oct 2024 12:11:22 +0000 (22:11 +1000)]
doc: SubmittingPatches-backports - remove backports team

Remove all references to the "Stable Releases and Backports Team", which
as of October 2024 does not exist.

Fixes: https://tracker.ceph.com/issues/68471
Co-authored-by: Laura Flores <lflores@ibm.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
9 months agoMerge pull request #60161 from NitzanMordhai/wip-nitzan-crimson-perf-suites-adding...
Matan Breizman [Thu, 10 Oct 2024 10:46:05 +0000 (13:46 +0300)]
Merge pull request #60161 from NitzanMordhai/wip-nitzan-crimson-perf-suites-adding-ssh-auth

qa/suites/crimson-rados/perf: add ssh keys

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
9 months agoAdd cosbench deprecation warning to qa/README 60169/head
Lee Sanders [Thu, 10 Oct 2024 10:21:46 +0000 (11:21 +0100)]
Add cosbench deprecation warning to qa/README

Signed-off-by: Lee Sanders <ljsanders@uk.ibm.com>
9 months agoqa/suites/tasks/cbt.py: Deprecating cosbench from Teuthology in preparation for delet...
Lee Sanders [Fri, 4 Oct 2024 14:13:57 +0000 (15:13 +0100)]
qa/suites/tasks/cbt.py: Deprecating cosbench from Teuthology in preparation for deletion of cosbench support
from CBT. The code being deleting is infrastructure code, no qa test suite uses this function. Therefore it can
be safely deleted.

Signed-off-by: Lee Sanders <ljsanders@uk.ibm.com>
9 months agoqa/workunits/nvmeof/setup_subsystem.sh: use --no-group-append 60206/head
Vallari Agrawal [Wed, 9 Oct 2024 07:27:32 +0000 (12:57 +0530)]
qa/workunits/nvmeof/setup_subsystem.sh: use --no-group-append

In newer version of nvmeof cli, "subsystem add" needs
this tag to ensure subsystem name is value of --subsystem.
Otherwise, in newer cli version, the gateway group is appended
at the end of the subsystem name.

This fixes the teuthology nvmeof suite (currently all jobs fails
because of this).

Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
9 months agoqa/suites/nvmeof: use "latest" image of gateway and cli
Vallari Agrawal [Tue, 1 Oct 2024 11:06:21 +0000 (16:36 +0530)]
qa/suites/nvmeof: use "latest" image of gateway and cli

Change nvmeof gateway and cli image from 1.2 to "latest".

Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
9 months agocephadm/smb: Add NET_RAW capability to deploy ctdbd 60238/head
Anoop C S [Thu, 10 Oct 2024 05:30:03 +0000 (11:00 +0530)]
cephadm/smb: Add NET_RAW capability to deploy ctdbd

CTDB heavily depends on raw sockets to send gratuitous ARPs[1](see the
second point from the list of reasons to use gratuitous ARPs). As per
the current design it is also inevitable while sending tickle ACKs[2]
in the event of an IP failover. man capabilities(7)[3] further mandates
CAP_NET_RAW to use raw sockets. Therefore append NET_RAW to the list of
capabilties while deploying ctdbd containers.

[1] https://wiki.wireshark.org/Gratuitous_ARP
[2] https://ctdb.samba.org/manpages/ctdb.1.html
[3] https://www.man7.org/linux/man-pages/man7/capabilities.7.html

Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
9 months agoMerge pull request #59692 from cyx1231st/wip-seastore-improve-log
Matan Breizman [Thu, 10 Oct 2024 08:34:22 +0000 (11:34 +0300)]
Merge pull request #59692 from cyx1231st/wip-seastore-improve-log

crimson/os/seastore: refine seastore and transaction_manager logs, cleanups

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
9 months agoMerge pull request #60079 from yuvalif/wip-yuval-gcc-14-test-posix
Yuval Lifshitz [Thu, 10 Oct 2024 07:48:24 +0000 (10:48 +0300)]
Merge pull request #60079 from yuvalif/wip-yuval-gcc-14-test-posix

test/rgw/posix: missing std include with GCC 14

9 months agoMerge pull request #60168 from yuvalif/wip-yuval-68336
Yuval Lifshitz [Thu, 10 Oct 2024 07:47:10 +0000 (10:47 +0300)]
Merge pull request #60168 from yuvalif/wip-yuval-68336

test/rgw/lua: use stats polling instead of sleep

9 months agoMerge pull request #60101 from rhcs-dashboard/fix-68376-main
afreen23 [Thu, 10 Oct 2024 06:32:32 +0000 (12:02 +0530)]
Merge pull request #60101 from rhcs-dashboard/fix-68376-main

mgr/dashboard: fix gateways section error:”404 - Not Found RGW Daemon not found: None”

Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>
9 months agoMerge pull request #60050 from rhcs-dashboard/non-default-realm-sync-status
afreen23 [Thu, 10 Oct 2024 06:31:14 +0000 (12:01 +0530)]
Merge pull request #60050 from rhcs-dashboard/non-default-realm-sync-status

mgr/dashboard: show non default realm sync status in rgw overview page

Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>
9 months agolabeler: add nvmeof labelers 60212/head
Vallari Agrawal [Wed, 9 Oct 2024 10:47:04 +0000 (16:17 +0530)]
labeler: add nvmeof labelers

Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
9 months agoMerge pull request #60211 from JonBailey1993/JonBailey1993/ceph_test_rados_io_sequenc...
Casey Bodley [Wed, 9 Oct 2024 19:49:57 +0000 (15:49 -0400)]
Merge pull request #60211 from JonBailey1993/JonBailey1993/ceph_test_rados_io_sequence_lock_fix

common/io_exerciser: Modify is_locked_by_me call in ceph_test_rados_io_sequence

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
9 months agoMerge PR #60210 into main
Patrick Donnelly [Wed, 9 Oct 2024 14:06:27 +0000 (10:06 -0400)]
Merge PR #60210 into main

* refs/pull/60210/head:
doc: update 'header get' output in cephfs-journal-tool.rst

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
9 months agoMerge PR #60204 into main
Patrick Donnelly [Wed, 9 Oct 2024 13:25:35 +0000 (09:25 -0400)]
Merge PR #60204 into main

* refs/pull/60204/head:
doc: fix email

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Zac Dover <zac.dover@gmail.com>
Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>
9 months agoqa/cephfs: update earmark values to valid ones in test_volumes.py 60219/head
Avan Thakkar [Wed, 9 Oct 2024 13:01:11 +0000 (18:31 +0530)]
qa/cephfs: update earmark values to valid ones in test_volumes.py

smb.test is an invalid earmark now it should be either smb or
smb.cluster.<cluster_id>. Update the test_volumes.py to set
valid earmarks wherever used.

Fixes: https://tracker.ceph.com/issues/68448
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
9 months agoMerge PR #60012 into main
Patrick Donnelly [Wed, 9 Oct 2024 12:33:13 +0000 (08:33 -0400)]
Merge PR #60012 into main

* refs/pull/60012/head:
qa: ignore pg availability/degraded warnings

Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
9 months agocommon/io_exerciser: Modify is_locked_by_me call in ceph_test_rados_io_sequence 60211/head
JonBailey1993 [Wed, 9 Oct 2024 10:28:42 +0000 (11:28 +0100)]
common/io_exerciser: Modify is_locked_by_me call in ceph_test_rados_io_sequence

is_locked_by_me() is a function of ceph::mutex which is only used in debug builds. By using the ceph_mutex_is_locked_by_me macro, we can neatly make sure we only run this function in debug mode, allowing compilation to no longer be affected when running in release mode.

Signed-off-by: Jon Bailey <jonathan.bailey1@ibm.com>
9 months agodoc: update 'header get' output in cephfs-journal-tool.rst 60210/head
Jos Collin [Wed, 9 Oct 2024 10:16:00 +0000 (15:46 +0530)]
doc: update 'header get' output in cephfs-journal-tool.rst

Signed-off-by: Jos Collin <jcollin@redhat.com>
9 months agoMerge pull request #60186 from JonBailey1993/JonBailey1993/ceph_test_rados_io_sequenc...
Jon Bailey [Wed, 9 Oct 2024 08:09:02 +0000 (09:09 +0100)]
Merge pull request #60186 from JonBailey1993/JonBailey1993/ceph_test_rados_io_sequence_add_version

common/io_exerciser: Add version argument to callbacks in ceph_radios_io_sequence

Signed-off-by: Jon Bailey <jonathan.bailey1@ibm.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
9 months agoMerge pull request #60150 from rhcs-dashboard/add-gwgroups-to-missing-endpoints
afreen23 [Wed, 9 Oct 2024 07:53:36 +0000 (13:23 +0530)]
Merge pull request #60150 from rhcs-dashboard/add-gwgroups-to-missing-endpoints

mgr/dashboard: add gw_groups to all nvmeof endpoints

Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>
9 months agodoc: fix email 60204/head
Ernesto Puerta [Wed, 9 Oct 2024 06:12:42 +0000 (08:12 +0200)]
doc: fix email

Signed-off-by: Ernesto Puerta <37327689+epuertat@users.noreply.github.com>
9 months agoMerge PR #60032 into main
Patrick Donnelly [Wed, 9 Oct 2024 00:56:28 +0000 (20:56 -0400)]
Merge PR #60032 into main

* refs/pull/60032/head:
mds: do not dump empty bufptr

Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
9 months agoMerge PR #60037 into main
Patrick Donnelly [Wed, 9 Oct 2024 00:55:38 +0000 (20:55 -0400)]
Merge PR #60037 into main

* refs/pull/60037/head:
test/common: add death test for double !recursive lock
common/test: do not test exception raised from recursive lock
test/common: fix invalid vim mode
common,osdc: remove obsolete ceph::mutex_debugging
common: assert debug mutex lock is not held if !recursive

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
9 months agoos/bluestore: Make truncate() drop unused allocations 60158/head
Adam Kupczyk [Mon, 7 Oct 2024 11:45:41 +0000 (11:45 +0000)]
os/bluestore: Make truncate() drop unused allocations

Now when truncate() drops unused allocations.
Modified Close() in BlueRocksEnv to unconditionally call truncate.

Fixes: https://tracker.ceph.com/issues/68385
Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
9 months agoqa: do not fail cephfs QA tests for slow bluestore ops 60011/head
Patrick Donnelly [Fri, 27 Sep 2024 00:39:40 +0000 (20:39 -0400)]
qa: do not fail cephfs QA tests for slow bluestore ops

Fixes: https://tracker.ceph.com/issues/68283
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
9 months agoMerge pull request #60163 from zdover23/wip-doc-2024-10-07-man-mount-ceph
Zac Dover [Tue, 8 Oct 2024 17:45:50 +0000 (03:45 +1000)]
Merge pull request #60163 from zdover23/wip-doc-2024-10-07-man-mount-ceph

doc/man: supplant "wsync" with "nowsync" as the default

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Patrick Donnelly <pdonnelly@redhat.com>
9 months agocommon/io_exerciser: Add version argument to callbacks in ceph_radios_io_sequence 60186/head
JonBailey1993 [Tue, 8 Oct 2024 08:43:10 +0000 (09:43 +0100)]
common/io_exerciser: Add version argument to callbacks in ceph_radios_io_sequence

Add new version that was missing from ceph_test_rados_io_sequence callbacks due to interface changes

Signed-off-by: Jon Bailey <jonathan.bailey1@ibm.com>
9 months agocrimson/osd/backfill_state: add the object to be pushed in the peer 59572/head
Xuehan Xu [Tue, 3 Sep 2024 08:25:25 +0000 (16:25 +0800)]
crimson/osd/backfill_state: add the object to be pushed in the peer
missing set of PeeringState

Fixes: https://tracker.ceph.com/issues/67874
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
9 months agocrimson/os/seastore/transaction_manager: refine logs 59692/head
Yingxin Cheng [Tue, 10 Sep 2024 03:55:05 +0000 (11:55 +0800)]
crimson/os/seastore/transaction_manager: refine logs

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
9 months agocrimson/os/seastore/transaction_manager: misc cleanups
Yingxin Cheng [Tue, 10 Sep 2024 03:52:56 +0000 (11:52 +0800)]
crimson/os/seastore/transaction_manager: misc cleanups

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
9 months agocrimson/os/seastore: workaround log linkage issue under clang14
Yingxin Cheng [Sun, 29 Sep 2024 05:47:17 +0000 (13:47 +0800)]
crimson/os/seastore: workaround log linkage issue under clang14

The logs printing lambda-captured variables cannot be linked correctly
with SeaStore::Shard::repeat_with_onode() under clang14.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
9 months agocrimson/os/seastore: refine logs of seastore.h/cc
Yingxin Cheng [Sun, 29 Sep 2024 03:47:46 +0000 (11:47 +0800)]
crimson/os/seastore: refine logs of seastore.h/cc

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
9 months agocrimson/os/seastore: adjust op names
Yingxin Cheng [Sun, 29 Sep 2024 03:14:14 +0000 (11:14 +0800)]
crimson/os/seastore: adjust op names

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
9 months agocrimson/os/seastore: convert length logs to the hex format
Yingxin Cheng [Tue, 10 Sep 2024 03:41:15 +0000 (11:41 +0800)]
crimson/os/seastore: convert length logs to the hex format

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
9 months agocrimson/os/seastore: misc cleanups
Yingxin Cheng [Fri, 6 Sep 2024 08:54:22 +0000 (16:54 +0800)]
crimson/os/seastore: misc cleanups

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
9 months agoMerge pull request #60162 from zdover23/wip-doc-2024-10-07-governance-reset
Zac Dover [Mon, 7 Oct 2024 23:55:13 +0000 (09:55 +1000)]
Merge pull request #60162 from zdover23/wip-doc-2024-10-07-governance-reset

doc/governance: revert d7c144c0d7e490bfda9715a0c8462bb67cffc764

Reviewed-by: Patrick Donnelly <pdonnelly@redhat.com>
9 months agoMerge pull request #60109 from idryomov/wip-63184
Ilya Dryomov [Mon, 7 Oct 2024 18:15:54 +0000 (20:15 +0200)]
Merge pull request #60109 from idryomov/wip-63184

librbd/crypto/LoadRequest: clone format for migration source image

Reviewed-by: Sunil Angadi <Sunil.Angadi@ibm.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
9 months agoMerge pull request #57582 from sajibreadd/wip-66059
Md Mahamudur Rahaman Sajib [Mon, 7 Oct 2024 18:07:40 +0000 (20:07 +0200)]
Merge pull request #57582 from sajibreadd/wip-66059

OSD: PG stat is not synchronized between osds after deep-scrub

9 months agotest/rgw/lua: use stats polling instead of sleep 60168/head
Yuval Lifshitz [Mon, 7 Oct 2024 15:34:15 +0000 (15:34 +0000)]
test/rgw/lua: use stats polling instead of sleep

this makes the test more consistent as well as faster

fixes: https://tracker.ceph.com/issues/68335

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
9 months agoMerge pull request #59857 from JonBailey1993/JonBailey1993/ceph_test_rados_io_sequence
Jon Bailey [Mon, 7 Oct 2024 14:48:06 +0000 (15:48 +0100)]
Merge pull request #59857 from JonBailey1993/JonBailey1993/ceph_test_rados_io_sequence

src/test/osd: create ceph_test_rados_io_sequence testing tool

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
9 months agoMerge pull request #60146 from spuiuk/smb_version
Zac Dover [Mon, 7 Oct 2024 14:34:01 +0000 (00:34 +1000)]
Merge pull request #60146 from spuiuk/smb_version

doc: remove note for smb3 support

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
9 months agodoc/man: supplant "wsync" with "nowsync" as the default 60163/head
Zac Dover [Mon, 7 Oct 2024 13:21:02 +0000 (23:21 +1000)]
doc/man: supplant "wsync" with "nowsync" as the default

Change the default from "wsync" to "nowsync". "nowsync" has been the
default since kernel version 5.16.

This information was reported on
https://pad.ceph.com/p/Report_Documentation_Bugs by Benjamin Mare on 07
Oct 2024.

The commit relevant to this change can be seen here, in Linus's main
branch:
https://github.com/torvalds/linux/commit/f7a67b463fb83a4b9b11ceaa8ec4950b8fb7f902

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
9 months agoMerge pull request #60001 from cbodley/wip-65654-debug
Casey Bodley [Mon, 7 Oct 2024 13:12:05 +0000 (09:12 -0400)]
Merge pull request #60001 from cbodley/wip-65654-debug

qa/rgw: add debug log to help diagnose 'bucket check unlinked' failure

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
9 months agoMerge pull request #60020 from soumyakoduri/wip-skoduri-lc-process
Casey Bodley [Mon, 7 Oct 2024 13:11:36 +0000 (09:11 -0400)]
Merge pull request #60020 from soumyakoduri/wip-skoduri-lc-process

rgw/lc: Fix a bug in LCOpAction_Transition::check()

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
9 months agoMerge pull request #59884 from cbodley/wip-51786
Casey Bodley [Mon, 7 Oct 2024 13:10:41 +0000 (09:10 -0400)]
Merge pull request #59884 from cbodley/wip-51786

cls/user: reset stats only returns marker when truncated

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>