]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Ilya Dryomov [Wed, 31 Aug 2022 07:22:05 +0000 (09:22 +0200)]
test/cli-integration/rbd: iSCSI REST API responses aren't pretty-printed anymore
See https://github.com/ceph/ceph-iscsi/pull/263 and
https://github.com/pallets/flask/pull/2193. Flask stopped
pretty-printing by default in 1.0:
Change the default for JSONIFY_PRETTYPRINT_REGULAR to False.
json.jsonify returns a compact format by default, and an indented
format in debug mode.
Fixes: https://tracker.ceph.com/issues/57343
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Kefu Chai [Tue, 30 Aug 2022 15:02:46 +0000 (23:02 +0800)]
Merge pull request #47761 from tchaikov/wip-intarith-bit
include, os: s/ctz/std::countr_zero/
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Kefu Chai [Tue, 30 Aug 2022 14:19:27 +0000 (22:19 +0800)]
Merge pull request #47830 from tchaikov/wip-fmtlib-v9
common, include, osd: compile with fmt v9
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Kefu Chai [Tue, 30 Aug 2022 13:19:01 +0000 (21:19 +0800)]
Merge pull request #44993 from kamoltat/wip-ksirivad-fix-bug-50089
mon/Elector: Added sanity check when pinging a peer monitor
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
zdover23 [Tue, 30 Aug 2022 11:14:17 +0000 (21:14 +1000)]
Merge pull request #47843 from zdover23/wip-doc-2022-08-29-mgr-dashboard-includes-prompt-update
doc/mgr: update prompts in dboard.rst includes
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Pere Diaz Bou [Tue, 30 Aug 2022 10:59:01 +0000 (12:59 +0200)]
Merge pull request #46962 from rhcs-dashboard/auto-coloring-badges-from-color-pool
mgr/dashboard: auto-coloring-badges-component
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: nSedrickm <NOT@FOUND>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Arthur Outhenin-Chalandre [Tue, 30 Aug 2022 10:49:23 +0000 (12:49 +0200)]
Merge pull request #47707 from bosc0/fix_alert
Ceph-mixin: Fix CephNodeNetworkPacket alerts
Arthur Outhenin-Chalandre [Tue, 30 Aug 2022 06:35:04 +0000 (08:35 +0200)]
Merge pull request #47669 from MrFreezeex/jb-path
ceph-mixin: fix PATH issues with jsonnet-bundler
Adam King [Mon, 29 Aug 2022 19:52:17 +0000 (15:52 -0400)]
Merge pull request #47808 from phlogistonjohn/jjm-remove-tox-env-lint
pybind/mgr: tox.ini remove redundant `tox` env
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
Pedro Gonzalez Gomez [Tue, 5 Jul 2022 09:40:01 +0000 (11:40 +0200)]
mgr/dashboard: auto-coloring-badges-component
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Kefu Chai [Mon, 29 Aug 2022 16:00:37 +0000 (00:00 +0800)]
Merge pull request #47834 from tchaikov/wip-56850
mon/MgrMonitor: do not propose again for "mgr fail"
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Casey Bodley [Mon, 29 Aug 2022 13:51:21 +0000 (09:51 -0400)]
Merge pull request #47441 from mkogan1/wip-WITH_BOOST_VALGRIND
cmake: set WITH_BOOST_VALGRIND before building boost
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
Arthur Outhenin-Chalandre [Mon, 29 Aug 2022 12:55:43 +0000 (14:55 +0200)]
Merge pull request #47675 from bosc0/fix_multicluster
ceph-mixin: fix config inheritance
Zac Dover [Mon, 29 Aug 2022 00:39:51 +0000 (10:39 +1000)]
doc/mgr: update prompts in dboard.rst includes
This PR adds unselectable prompts to three files that are
transcluded in the doc/mgr/dashboard.rst file. These three
files are:
1. debug.inc.rst
2. feature_toggles.inc.rst
3. motd.inc.rst
The addition of unselectable prompts to these three files
completes the work begun in PR#47810 (
d8064b4 ), which sought
to bring dashboard.rst into line with the unselectable prompt
standard introduced by Kefu Chai in 2020.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Ronen Friedman [Sun, 28 Aug 2022 11:10:10 +0000 (14:10 +0300)]
Merge pull request #47681 from ronen-fr/wip-rf-delog1
osd/scrub: improving scrub logs
Reviewed-by: Aishwarya Mathuria <amathuri@redhat.com>
Yuval Lifshitz [Sun, 28 Aug 2022 07:44:07 +0000 (10:44 +0300)]
Merge pull request #47728 from yuvalif/wip-yuval-cont-lease
rgw/multisite: check for late lease renewals
reviewed-by: cbodley
Ronen Friedman [Tue, 16 Aug 2022 12:48:04 +0000 (15:48 +0300)]
osd/scrub: reduce the amount of log lines
Following call chains, and removing repeated data.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Ronen Friedman [Thu, 18 Aug 2022 15:27:47 +0000 (18:27 +0300)]
common: improving fmtlib handling of ceph::utime_t
1. fixing the output to show local-time instead of UTC format, matching
operator<<() handling (and all the rest of our logs)
2. adding a 'short' mode (as {:s}) for when, e.g. in most scrub logs,
we only need 3 digits for the sub-second, and do not need the
trailing TZ designation.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
zdover23 [Sat, 27 Aug 2022 21:13:39 +0000 (07:13 +1000)]
Merge pull request #47736 from ceph/release-docs
doc: Update release process doc to accurately reflect current process
Reviewed-by: Zac Dover <zac.dover@gmail.com>
David Galloway [Mon, 22 Aug 2022 20:12:36 +0000 (16:12 -0400)]
doc: Update release process doc to accurately reflect current process
Signed-off-by: David Galloway <dgallowa@redhat.com>
Kefu Chai [Sat, 27 Aug 2022 03:31:07 +0000 (11:31 +0800)]
include/object_fmt: mark fmt::formatter<>::format() const
so these formatters can be used in methods with `const` specifier.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Sat, 27 Aug 2022 03:00:20 +0000 (11:00 +0800)]
common/LogEntry: specialize fmt::formatter<LogEntry>
so we can use the formatter defined for `LogEntry` in fmtlib v9.
in this new version of fmtlib, it is required to define a specialization
for the formatted type even when it comes to the types with an override of
operator<<(). since we already have an override for `LogEntry`, let's define
the specialization for `fmt::formatter<LogEntry>`.
this change should address the FTBFS when building with fmtlib v9.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Sat, 27 Aug 2022 02:27:01 +0000 (10:27 +0800)]
common/Journald: include msg/msg_fmt.h
so we can use the formatter defined for `entity_name_t`. in fmtlib v9,
it is required to define a specialization for the formatted type even
the type has an override of operator<<(). now that we already have a
formatter for `entity_name_t`, let's just use it.
this change should address the FTBFS when building with fmtlib v9.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Sat, 27 Aug 2022 15:46:00 +0000 (23:46 +0800)]
mon/MgrMonitor: do not propse again for "mgr fail"
in
23c3f76018b446fb77bbd71fdd33bddfbae9e06d , the change to fail the mgr
is proposed immediately. but `MgrMonitor::prepare_command()` method still
returns `true` in this case. its indirect caller of
`PaxosService::dispatch()` considers this as a sign that it needs to
propose the change with `propose_pending()`. but the pending change has
already been proposed by `MgrMonitor::prepare_command()`, and
`have_pending` is also cleared by this call. as we don't allow
consecutive paxos proposals, the second `propose_pending()` call is
delayed with a configured latency. but when the timer is fired, this
poseponed call would find itself trying to propose nothing. the change
to fail the mgr has been proposed. that's why we have
`ceph_assert(have_pending)` assertion failures.
in this change, the second proposal is not proposed anymore if the
proposal is proposed immediately. this should avoid the assertion
failure.
this change should address the regression introduced by
23c3f76018b446fb77bbd71fdd33bddfbae9e06d .
Fixes: https://tracker.ceph.com/issues/56850
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
zdover23 [Fri, 26 Aug 2022 19:45:28 +0000 (05:45 +1000)]
Merge pull request #47810 from zdover23/wip-doc-2022-08-25-mgr-dashboard-prompt-correct
doc/mgr: add prompt directives to dashboard.rst
Reviewed-by: Nizamudeen A <nia@redhat.com>
Laura Flores [Fri, 26 Aug 2022 19:07:44 +0000 (14:07 -0500)]
Merge pull request #47046 from rzarzynski/wip-dup-trimming-test2
osd, tools, kv: non-aggressive, on-line trimming of accumulated dups
Rishabh Dave [Fri, 26 Aug 2022 13:13:52 +0000 (18:43 +0530)]
Merge pull request #46994 from rishabh-d-dave/qa-caps-helper-upgrade
qa/cephfs: upgrade caps_helper.py
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Pere Diaz Bou [Fri, 26 Aug 2022 13:09:37 +0000 (15:09 +0200)]
Merge pull request #47510 from nSedrickm/pagination-component-accesibility-update
mgr/dashboard: Improve level A accessibility for pagination component
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Rishabh Dave [Fri, 26 Aug 2022 13:03:13 +0000 (18:33 +0530)]
Merge pull request #46902 from lxbsz/wip-56414
client: specify the quota type when finding the root quota realm
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Yingxin [Fri, 26 Aug 2022 06:55:41 +0000 (14:55 +0800)]
Merge pull request #47698 from cyx1231st/wip-seastore-RBM-trim-2
crimson/os/seastore: generalize journal tail calculations with CircularBoundedJournal
Reviewed-by: Myoungwon Oh <myoungwon.oh@samsung.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Adam King [Thu, 25 Aug 2022 23:05:44 +0000 (19:05 -0400)]
Merge pull request #47811 from adk3798/fix-tox-mgr
mgr/orchestrator/tests: don't match exact whitespace in table output
Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Casey Bodley [Thu, 25 Aug 2022 18:17:25 +0000 (14:17 -0400)]
Merge pull request #47686 from cbodley/wip-rgw-rm-zonegroupmap
rgw: remove RGWRegionMap and RGWZoneGroupMap
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Casey Bodley [Thu, 25 Aug 2022 18:17:00 +0000 (14:17 -0400)]
Merge pull request #47735 from cbodley/wip-57232
cls/rgw: restore backward-compatible encoding of cls_rgw_bucket_instance_entry
Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
Ernesto Puerta [Thu, 25 Aug 2022 17:31:09 +0000 (19:31 +0200)]
Merge pull request #46958 from nSedrickm/datatables-accessibility-update
mgr/dashboard: Improve accessibility for datatable component
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Yuval Lifshitz [Thu, 25 Aug 2022 16:38:27 +0000 (19:38 +0300)]
Merge pull request #43436 from yuvalif/wip-yuval-fix-50611
rgw/notification: allow sending bucket notifications secrets in cleartext
reviewed-by: cbodley, mattbenjamin
Adam King [Thu, 25 Aug 2022 16:09:49 +0000 (12:09 -0400)]
mgr/orchestrator/tests: don't match exact whitespace in table output
It seems that the exact spacing may differ a bit between
python versions. Currently seeing py3 (which cooresponds to py 3.6
on my system) passing these tests and py37 (which is python 3.7
obviously) failing. I think verifying against the exact whitespace
is unnecessary anyhow. As long as it isn't egregious, we don't
really need to worry about exactly what the spacing is.
Signed-off-by: Adam King <adking@redhat.com>
Zac Dover [Thu, 25 Aug 2022 15:56:41 +0000 (01:56 +1000)]
doc/mgr: add prompt directives to dashboard.rst
This commit adds prompt directives (.. prompt:: bash $) to
the commands in dashboard.rst.
There are several ".. include::" directives in the dashboard.rst
file, which means that part of this page is sourced from elsewhere
than the dashboard.rst file. Because I have not yet added prompt
directives to those files, there is an inconsistency in the rendering
of this file. Most of the commands on this page have unselectable
prompts (unselectable prompts are the prompts that don't get added to
the buffer when you copy them to one of the clipboards). But the
commands on this page that come from those ".. include::" directives
do not yet have unselectable prompts.
This file is over 1600 lines long. It was perhaps not optimally wise
of me to have edited all of it in one fell swoop. It took many hours,
and carefully checking it will probably take at least one hour. I
suggest that whoever reviews this should not spend much time on it,
but should instead make a quick pass over the page and make sure that
it looks passable.
The English syntax on this page (and throughout the Dashboard doc-
umentation) will be tightened to remove ambiguity and to improve
readability in the near future, so hold all English-language-related
comments for a future pull request.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Adam King [Thu, 25 Aug 2022 15:21:35 +0000 (11:21 -0400)]
Merge pull request #47674 from adk3798/distro-workunits
qa/cephadm: specify using container host distros for workunits
Reviewed-by: Laura Flores <lflores@redhat.com>
Yuval Lifshitz [Mon, 22 Aug 2022 13:29:56 +0000 (13:29 +0000)]
rgw/multisite: check for late lease renewals
also make lease renewal logs more uniform
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
John Mulligan [Thu, 25 Aug 2022 13:58:55 +0000 (09:58 -0400)]
pybind/mgr: tox.ini remove redundant `tox` env
Fixes: https://tracker.ceph.com/issues/57153
The envlist contained an environment named `lint`. There was no specific
customization of the lint testenv so it is essentially the same as
running the `py3` testenv.
This was probably a typo and was meant to be `pylint`. Unfortunately,
the pylint test env does not appear to work, probably because it was
never run as part of any automation. At the risk of leaving old stuff
behind I'm not removing the pylint testenv at the moment, only the
`lint` item in order to not run redundant tests.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
Adam King [Thu, 25 Aug 2022 13:11:30 +0000 (09:11 -0400)]
Merge pull request #47792 from adk3798/rgw-bad-example
doc/cephadm/services: fix example for specifying networks for rgw
Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
Yingxin [Thu, 25 Aug 2022 02:36:09 +0000 (10:36 +0800)]
Merge pull request #47599 from xxhdx1985126/wip-backref-minor-bug
crimson/os/seastore/cache: set extent's state to INVALID when invalidating it
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
nsedrickm [Wed, 3 Aug 2022 11:14:27 +0000 (12:14 +0100)]
mgr/dashboard: Improve level A accessibility for pagination component
Add custom pagination component based on patternfly design
Fixes: https://tracker.ceph.com/issues/55876
Signed-off-by: nsedrickm <nsedrick101@gmail.com>
Adam King [Wed, 24 Aug 2022 14:36:53 +0000 (10:36 -0400)]
doc/cephadm: fix example for specifying networks for rgw
count_per_host must be used with underscores rather
than dashes to work, you need to pass service_id not
service_name and the option for the port is called
rgw_frontend_port not just "port"
Signed-off-by: Adam King <adking@redhat.com>
zdover23 [Wed, 24 Aug 2022 14:20:59 +0000 (00:20 +1000)]
Merge pull request #47785 from rhcs-dashboard/doc-fix-monitoring
docs: fix doc link pointing to master in dashboard.rst
Reviewed-by: Zac Dover <zac.dover@gmail.com>
Nizamudeen A [Wed, 24 Aug 2022 10:41:00 +0000 (16:11 +0530)]
docs: fix doc link pointing to master in dashboard.rst
Signed-off-by: Nizamudeen A <nia@redhat.com>
Kefu Chai [Tue, 23 Aug 2022 15:38:39 +0000 (23:38 +0800)]
include/intarith: s/8/CHAR_BIT/
less magic numbers
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Sun, 21 Aug 2022 16:52:13 +0000 (00:52 +0800)]
include/intarith: drop ctz()
it is not used anymore
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Sun, 21 Aug 2022 16:50:43 +0000 (00:50 +0800)]
denc, os: s/ctz/std::countr_zero/
prefer the facilities provided by standard library over the homebrew
ones for better readability and maintainability.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
NitzanMordhai [Wed, 24 Aug 2022 05:46:15 +0000 (05:46 +0000)]
standalone/osd: Test adjust with new trimming function
Change the number of dups trimmied according to the new loop.
Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
Yingxin [Wed, 24 Aug 2022 08:10:20 +0000 (16:10 +0800)]
Merge pull request #47705 from xxhdx1985126/wip-skip-invalid-inline-extents
crimson/os/seastore/cache: skip invalid inline extents when completing commits
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin [Wed, 24 Aug 2022 08:08:29 +0000 (16:08 +0800)]
Merge pull request #47745 from liu-chunmei/seastore-empty-delta
crimson/seastore: fix omap empty delta buffer
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Venky Shankar [Wed, 24 Aug 2022 08:07:46 +0000 (13:37 +0530)]
Merge pull request #46072 from neesingh-rh/fix_54978
cephfs-top: adding filesystem menu option
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
Yingxin [Wed, 24 Aug 2022 08:07:07 +0000 (16:07 +0800)]
Merge pull request #47782 from tchaikov/wip-crimson-os-cleanups
crimson/os: use IsFullKey when appropriate
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Venky Shankar [Wed, 24 Aug 2022 08:01:28 +0000 (13:31 +0530)]
Merge pull request #46685 from Rethan/perf-limit-dump-loads-depth
mds/MDBalancer: add an arg to limit depth when dump loads for dirfrags
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Kefu Chai [Wed, 24 Aug 2022 05:27:05 +0000 (13:27 +0800)]
crimson/os: replace full_key_t<KeyT::VIEW> with key_view_t
and replace full_key_t<KeyT::HOBJ> with key_hobj_t.
there is not need to have this indirection
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Wed, 24 Aug 2022 05:13:40 +0000 (13:13 +0800)]
crimson/os: use IsFullKey in staged::insert_size{,at}()
to fade out KeyT, so we can have more straightforward definitions.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Wed, 24 Aug 2022 04:25:41 +0000 (12:25 +0800)]
crimson/os: use IsFullKey in staged::insert()
to fade out KeyT, so we can have more straightforward definitions.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Venky Shankar [Wed, 24 Aug 2022 05:43:07 +0000 (11:13 +0530)]
Merge pull request #46068 from neesingh-rh/change_perf_stats_o/p_structure
mgr/stats: change in structure of perf_stats o/p
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
Yingxin [Wed, 24 Aug 2022 05:27:30 +0000 (13:27 +0800)]
Merge pull request #47778 from xxhdx1985126/wip-fix-output-error-cleaner
crimson/os/seastore/async_cleaner: fix several log related errors
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
zdover23 [Wed, 24 Aug 2022 04:36:48 +0000 (14:36 +1000)]
Merge pull request #47751 from zdover23/wip-doc-2022-08-23-mgr-orchestrator-editorial-pass
doc/mgr: edit orchestrator.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Venky Shankar [Wed, 24 Aug 2022 04:19:47 +0000 (09:49 +0530)]
Merge pull request #47079 from neesingh-rh/fix_56483
mgr/stats: missing clients in perf stats command output.
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
Kefu Chai [Wed, 24 Aug 2022 04:09:41 +0000 (12:09 +0800)]
Merge pull request #47729 from tchaikov/wip-crimson-os-cleanup
crimson/os: use IsFullKey in *::insert_prefix{,_at}()
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Zac Dover [Tue, 23 Aug 2022 06:59:04 +0000 (16:59 +1000)]
doc/mgr: edit orchestrator.rst
This PR improves the English language in the "Orchestrator CLI"
section of the MGR documentation. It adds a couple of section
headers in order to signpost the information in the document
a bit more than had already been done, but it makes no major
structural changes to the presentation of the information here.
This PR was motivated by feedback from the 2022 Ceph User Survey
in which one of the respondents wrote "better ceph orch documen-
tation".
The final section on this page, "Current Implementation Status",
must be verified by someone who is familiar with the current state
of "ceph orch" and a date stamp should be applied to the top of
the section so that the word "current" has a meaningful referent.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Yingxin Cheng [Wed, 24 Aug 2022 02:51:56 +0000 (10:51 +0800)]
crimson/os/seastore/cache: workaround to drop delta with mismatched crc
The workaround is unreliable to identify whether the delta is out-dated,
need to drop it once the paddr->journal_seq_t mapping is introduced.
Note: this issue only happens with journal_type_t::CIRCULAR.
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Xuehan Xu [Wed, 24 Aug 2022 03:03:53 +0000 (11:03 +0800)]
crimson/os/seastore/async_cleaner: fix several log related errors
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
myoungwon oh [Fri, 17 Jun 2022 06:14:41 +0000 (15:14 +0900)]
crimson/os/seastore: enable CBJournal trim during transaction_manager unit test
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Fri, 19 Aug 2022 07:09:41 +0000 (15:09 +0800)]
crimson/os/seastore: generalize journal tail calculations
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
Xuehan Xu [Mon, 22 Aug 2022 06:51:12 +0000 (14:51 +0800)]
crimson/os/seastore/async_cleaner: fill the semantic gap between backref get_mappings and space reclaim
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
Xuehan Xu [Sat, 20 Aug 2022 04:30:26 +0000 (12:30 +0800)]
crimson/common: parallel_for_each shouldn't accept rvalue reference of containers
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
Xuehan Xu [Fri, 19 Aug 2022 10:16:39 +0000 (18:16 +0800)]
crimson/os/seastore/cache: skip invalid inline extents when completing commits
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
Yingxin Cheng [Fri, 19 Aug 2022 07:05:26 +0000 (15:05 +0800)]
crimson/os/seastore: move journal_type_t to seastore_types.h with shorter names
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin [Tue, 23 Aug 2022 23:54:15 +0000 (07:54 +0800)]
Merge pull request #47646 from cyx1231st/wip-seastore-move-cleaner-to-epm
crimson/os/seastore: move AsyncCleaner to EPM
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
Reviewed-by: Zhang Song <zhangsong325@gmail.com>
chunmei-liu [Mon, 22 Aug 2022 21:54:24 +0000 (14:54 -0700)]
crimson/seastore: fix omap empty delta buffer
when rm_key get end iterator, don't do muatate
otherwise delta buffer will be empty and cause assert(delta.bl.lenght())
Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
Daniel Gryniewicz [Tue, 23 Aug 2022 17:51:06 +0000 (13:51 -0400)]
Merge pull request #47561 from dang/wip-dang-zipper-cast
RGW - Zipper - Remove a bunch of casts
Reviewed-by: Soumya Koduri <skoduri@redhat.com>
Venky Shankar [Tue, 23 Aug 2022 16:03:09 +0000 (21:33 +0530)]
Merge pull request #45949 from neesingh-rh/feature-51434
mgr/volumes: Add volume info command
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Nikhilkumar Shelke <nshelke@redhat.com>
Venky Shankar [Tue, 23 Aug 2022 16:00:18 +0000 (21:30 +0530)]
Merge pull request #44501 from SMIL-Infra/fix-mds-evicted
mon/MDSMonitor: fix standby-replay mds being removed from MDSMap unexpectedly
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Daniel Gryniewicz [Tue, 23 Aug 2022 15:40:50 +0000 (11:40 -0400)]
Merge pull request #47678 from dang/wip-dang-admin-user
RGW - Admin - Pass user to created bucket
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Laura Flores [Tue, 23 Aug 2022 15:32:31 +0000 (10:32 -0500)]
Merge pull request #47642 from ljflores/wip-librados-fix
qa/workunits/rados: pull librados files from "main" instead of "master"
Kefu Chai [Tue, 23 Aug 2022 15:29:06 +0000 (23:29 +0800)]
Merge pull request #47624 from Mer1997/wip-57138
mgr/snap-schedule: use the right way to check the result returned by…
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Tue, 23 Aug 2022 15:27:54 +0000 (23:27 +0800)]
Merge pull request #47301 from rzarzynski/wip-bug-55851
msg: reset ProtocolV2's frame assembler in appropriate thread
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Kefu Chai [Tue, 23 Aug 2022 15:26:07 +0000 (23:26 +0800)]
Merge pull request #46943 from kalaspuffar/python39
mgr/diskprediction_local: Support Python 3.9 for disk prediction module.
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Tue, 23 Aug 2022 15:24:15 +0000 (23:24 +0800)]
Merge pull request #47672 from Matan-B/wip-matanb-buffer-next
include/buffer: clear_and_dispose() fix implicitly-declared operator= usage
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Tue, 23 Aug 2022 15:21:35 +0000 (23:21 +0800)]
Merge pull request #47710 from tchaikov/denc-concept
include/denc: define is_const_iterator as a concept
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Kefu Chai [Tue, 23 Aug 2022 15:19:41 +0000 (23:19 +0800)]
Merge pull request #47718 from tchaikov/wip-no-isp2
*: replace functions in intarith.h with the ones provided by standard library
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Matan [Tue, 23 Aug 2022 14:45:18 +0000 (17:45 +0300)]
Merge pull request #46419 from Matan-B/wip-matanb-c-snaps
crimson/osd: Snaps IO path
Reviewed-by: Samuel Just <sjust@redhat.com>
Yingxin Cheng [Thu, 18 Aug 2022 04:10:46 +0000 (12:10 +0800)]
test/crimson/seastore: fix teardown with cleanups
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Wed, 17 Aug 2022 07:06:19 +0000 (15:06 +0800)]
crimson/os/seastore: move AsyncCleaner to EPM
There are two purposes related to generic device tiering:
* Make AsyncCleaner (need to introduce a generic interface class later)
to hide differences between segment-based tier and RB-based tier
cleaner implementations.
* Make EPM to coordinate cleaning transactions across tiers with general
AsyncCleaners.
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Thu, 18 Aug 2022 04:15:14 +0000 (12:15 +0800)]
test/crimson/seastore: drop unnecessary run_until_halt()
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Venky Shankar [Tue, 23 Aug 2022 14:09:40 +0000 (19:39 +0530)]
Merge pull request #47182 from lxbsz/wip-56638
libcephfs: define AT_NO_ATTR_SYNC back for backward compatibility
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Nikhilkumar Shelke <nshelke@redhat.com>
Yingxin Cheng [Wed, 17 Aug 2022 06:51:06 +0000 (14:51 +0800)]
crimson/os/seastore/async_cleaner: cleanup and sort interfaces
To prepare for a general interface class for device tiering.
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Tue, 16 Aug 2022 08:55:04 +0000 (16:55 +0800)]
crimson/os/seastore/async_cleaner: cleanup, replace init_complete by explicit states
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Aswin Toni [Tue, 23 Aug 2022 08:30:12 +0000 (10:30 +0200)]
ceph-mixin: fix CephNodeNetworkPacket alerts
Signed-off-by: Aswin Toni <aswin.toni@cern.ch>
Ilya Dryomov [Tue, 23 Aug 2022 12:24:36 +0000 (14:24 +0200)]
Merge pull request #47737 from ceph/release-docs2
admin: Fix check if PR or release branch docs build
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Venky Shankar [Tue, 23 Aug 2022 10:52:29 +0000 (16:22 +0530)]
Merge pull request #47542 from batrick/i56140
tools/cephfs: add basic detection/cleanup tool for dentry first damage
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Nizamudeen A [Tue, 23 Aug 2022 10:03:30 +0000 (15:33 +0530)]
Merge pull request #43771 from rhcs-dashboard/wip-52701-master
mgr/dashboard: add backend-driven UI tables
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: sherrif10 <NOT@FOUND>
Reviewed-by: Zac Dover <zac.dover@gmail.com>
Venky Shankar [Tue, 23 Aug 2022 07:55:02 +0000 (13:25 +0530)]
Merge pull request #46599 from kotreshhr/rename_config_on_flush
mgr/volumes: Better handle config file on osd full scenario
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Venky Shankar [Tue, 23 Aug 2022 07:52:09 +0000 (13:22 +0530)]
Merge pull request #47063 from lxbsz/wip-56529
mds/client: fail the request if the peer MDS doesn't support getvxattr op
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Venky Shankar [Tue, 23 Aug 2022 07:19:57 +0000 (12:49 +0530)]
Merge pull request #47132 from lxbsz/_rmsnap_finish_clean
mds: remove useless code in _rmsnap_finish()
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Venky Shankar [Tue, 23 Aug 2022 07:13:36 +0000 (12:43 +0530)]
Merge pull request #47384 from lxbsz/wip-56633
mds: add more debug logs before crashing the MDS
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Nikhilkumar Shelke <nshelke@redhat.com>