Merge pull request #56471 from rhcs-dashboard/wip-65137-reef

reef: mgr/dashboard: add system users to rgw user form

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: afreen23 <NOT@FOUND>

Merge pull request #56466 from zdover23/wip-doc-2024-03-26-backport-56436-to-reef

reef: doc/start: improve MDS explanation

Merge pull request #56259 from guits/wip-64943-reef

reef: ceph-volume: add missing import

mgr/dashboard: add system users to rgw user form

Fixes: https://tracker.ceph.com/issues/65074
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
(cherry picked from commit b658bb9c32ad31608921e77603003c004ab0f15b)

Merge pull request #55987 from joscollin/wip-64743-reef

reef: mds: add a command to dump directory information

Reviewed-by: Venky Shankar <vshankar@redhat.com>

doc/start: improve MDS explanation

Improve the explanation of MDS as requested by Anthony D'Atri here:

https://github.com/ceph/ceph/pull/56367#discussion_r1536667249

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit e7eff3cf8738ddd378c2fd70075ac61dbac3cf55)

Merge pull request #56452 from rhcs-dashboard/wip-65111-reef

reef: mgr/dashboard: sanitize dashboard user creation

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: afreen23 <NOT@FOUND>

Merge pull request #56151 from sseshasa/wip-64881-reef

reef: qa: Add benign cluster warning from ec-inconsistent-hinfo test to ignorelist

Reviewed-by: Laura Flores <lflores@redhat.com>

Merge pull request #54981 from sseshasa/wip-63874-reef

reef: osd: Apply randomly selected scheduler type across all OSD shards

Reviewed-by: Laura Flores <lflores@redhat.com>

Merge pull request #56325 from adk3798/wip-64994-reef

reef: mgr/cephadm: refresh public_network for config checks before checking

Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #56307 from adk3798/reef-timemaster

reef: cephadm: add timemaster to timesync services list

Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #56302 from adk3798/reef-only-bind-to-network

reef: mgr/cephadm: allow grafana and prometheus to only bind to specific network

Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #56292 from adk3798/reef-cephadm-pull-usage

reef: cephadm: improve cephadm pull usage message

Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #56286 from adk3798/reef-haproxy-healthcheck-interval

reef: cephadm: adjust the ingress ha proxy health check interval

Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #56221 from adk3798/reef-regex-host-pattern

reef: mgr/cephadm: support for regex based host patterns

Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #56443 from rhcs-dashboard/wip-65103-reef

reef: mgr/dashboard: rm warning/error threshold for cpu usage

Reviewed-by: afreen23 <NOT@FOUND>

mgr/dashboard: sanitize dashboard user creation

Fixes: https://tracker.ceph.com/issues/65030
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
(cherry picked from commit 9951a3a7f314c7cd1eb147fb1b398ac6c5212806)

Merge pull request #56439 from rhcs-dashboard/wip-65108-reef

reef: mgr/dashboard: fix empty tags

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: afreen23 <NOT@FOUND>

mgr/dashboard: rm warning/error threshold for cpu usage

for multi-core cpu's the value can be more than 100% so it doesn't make
sense to show warning/error when the usage is at or more than 100%.
hence removing it

Fixes: https://tracker.ceph.com/issues/58838
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 131a70754a6bfbbb2d1481ba74436953c6ecc226)

mgr/dashboard: fix empty tags

Fixes: https://tracker.ceph.com/issues/64911
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
(cherry picked from commit a60f82566551e731987b4a02d1bb2bf4cfb9a9ce)

Merge pull request #56419 from rhcs-dashboard/wip-65078-reef

reef: Snapshot schedule show subvolume path

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #56426 from zdover23/wip-doc-2024-08-24-backport-56367-to-reef

reef: doc/start: improve MDS explanation

Merge pull request #56410 from zdover23/wip-doc-2024-03-23-backport-56377-to-reef

reef: doc/start: link to mon map command

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/start: improve MDS explanation

Remove a prolix "on behalf of" and streamline some sentences explaining
the benefits of MDS.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 2da1812a1de7e32395cb95c2e0ebeea689c1b810)

mgr/dashboard: show full subvol path snap schedule

Show full subvolume path when adding snap schedule

Fixes: https://tracker.ceph.com/issues/65000
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
(cherry picked from commit b6dbf0f24d189d5b75148f07f1dc7f332d23b64a)

Merge pull request #56387 from rhcs-dashboard/wip-64959-reef

reef: mgr/dashboard: fixed nfs attach command

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>

Merge pull request #56385 from rhcs-dashboard/wip-65068-reef

reef: mgr/dashboard: fix subvolume group edit size

Reviewed-by: Nizamudeen A <nia@redhat.com>

doc/start: link to mon map command

Link to the "ceph mon stat" command when "Intro to Ceph" document first
mentions Monitor Maps.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 5d300db825316db25706111bbe577d41d41ab4b3)

Merge pull request #56215 from rhcs-dashboard/applitools-disable-reef

reef: mgr/dashboard: disable applitools e2e

Reviewed-by: ivoalmeida <NOT@FOUND>

mgr/dashboard: fixed nfs attach command

Fixes: https://tracker.ceph.com/issues/64933
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
(cherry picked from commit db724a8fef183f6f5200bc0e93428a19c69d1342)

mgr/dashboard: fix subvolume group edit size

Removed the 'infinite' string which was set when no value was provided

Fixes: https://tracker.ceph.com/issues/65049
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
(cherry picked from commit a19f2b6e3c4b51b605be1b5683c0ddad2b9d959f)

Merge pull request #56370 from rhcs-dashboard/wip-65046-reef

reef: mgr/dashboard: fix retention add for subvolume

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #56363 from rhcs-dashboard/wip-65036-reef

reef: mgr/dashboard: fix M retention frequency display

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #55575 from rhcs-dashboard/rwg-reef-backports

reef: mgr/dashboard: rgw bucket features

Reviewed-by: afreen23 <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>

mgr/dashboard: fix retention add for subvolume

- Added parameters for subvolume and subvolume group when adding a new
snap schedule.
- Added call to remove retention policies when removing a snap schedule
  in case it is the last one with same path

Fixes: https://tracker.ceph.com/issues/64524
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
(cherry picked from commit 80e1207f4b536fe6edbc81e61cbf951e135eba54)

mgr/dashboard: fix M retention frequency display

Fix snap schedule list monthly retention frequency display

Fixes: https://tracker.ceph.com/issues/64982
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
(cherry picked from commit 0bd8d3b6bc8ecbe99e22545549a63de3444e5f75)

Merge pull request #56340 from zdover23/wip-doc-2024-03-20-backport-56333-to-reef

reef: doc/cephfs: fix architecture link to correct relative path

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #56268 from zdover23/wip-doc-2024-08-19-backport-56240-to-reef

reef: doc/rados: update common.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #56062 from mchangir/wip-64811-reef

reef: mds: add debug logs during setxattr ceph.dir.subvolume

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #55502 from cbodley/wip-64361-reef

reef: cmake/modules/BuildRocksDB.cmake: inherit parent's CMAKE_CXX_FLAGS

Reviewed-by: Mark Nelson <mnelson@redhat.com>

Merge pull request #54711 from mchangir/wip-63590-reef

reef: qa: run kernel_untar_build with newer tarball

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #56213 from idryomov/wip-63770-reef

reef: librbd: account for discards that truncate in ObjectListSnapsRequest

Reviewed-by: Ramana Raja <rraja@redhat.com>

Merge pull request #56004 from prazumovsky/wip-63684-reef-backport

reef: RGW - Swift retarget needs bucket set on object

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #55692 from neesingh-rh/wip-64518-reef

reef: mgr/volumes: support to reject CephFS clones if cloner threads are not available

Reviewed-by: Venky Shankar <vshankar@redhat.com>

doc/cephfs: fix architecture link to correct relative path

Signed-off-by: molpako <35787116+molpako@users.noreply.github.com>
(cherry picked from commit ceeb1ca4b38dc307e493b04a59d5d07fed23971f)

Merge pull request #55541 from rhcs-dashboard/wip-63728-reef

reef: mgr/dashboard: add support for editing and deleting rgw roles

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: ivoalmeida <NOT@FOUND>

Merge pull request #56254 from rhcs-dashboard/wip-64930-reef

reef: mgr/dashboard: ceph authenticate user from fs

Reviewed-by: afreen23 <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #56290 from zdover23/wip-doc-2024-03-20-backport-56109-to-reef

reef: doc/cephadm/services: Improve monitoring.rst

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>

Merge pull request #56230 from adk3798/reef-docs-typo-replace-osd

reef: doc: cephadm/services/osd: fix typo

Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Reviewed-by: Zac Dover <zac.dover@proton.me>

mgr/cephadm: refresh public_network for config checks before checking

The place it was being run before meant it would only grab the
public_network setting once at startup of the module. This meant
if a user changed the setting, which they are likely to do if they
get the warning, cephadm would ignore the change and continue
reporting that the hosts don't match up with the old setting
for the public_network. This moves the call to refresh the
setting to right before we actually run the checks. It does
mean we'll do the `ceph config dump --format json` call
each serve loop iteration, but I've found that only tends
to take a few milliseconds, which is nothing compared to
the time to refresh other things we check during the serve
loop.

I additionally modified the use of this option to use
the attribute on the mgr, rather than calling
`get_module_option`. This was just to get it more in
line with how we tend to handle other config options

Fixes: https://tracker.ceph.com/issues/64902
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 129c10b4da518b8843ac0bc5397276eb695d4033)

cephadm.py: add timemaster to timesync services list

On debian/ubuntu, if you need PTP, it's possible to use the linuxptp package for time-synchonization.
In that case the systemd service is called timemaster and is a wrapper for chrony/ntpd/phc2sys/ptp4l.

Signed-off-by: Florent Carli <florent.carli@rte-france.com>
(cherry picked from commit 4ee1c761e50e3c3feed89ccc5c450ac96681b778)

mgr/cephadm: allow having prometheus bind on specific network

To avoid port conflicts in certain setups where
something else is using the same port on a different
network on the host.

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit e6943dd61374ee8ce337751e9ef9ba55f10a83ed)

Conflicts:
src/cephadm/cephadmlib/daemons/monitoring.py
src/cephadm/tests/test_deploy.py

mgr/cephadm: add option for grafana to bind on specific network

For example, with a spec like

```
[root@vm-00 ~]# cat grafana.yaml
service_type: grafana
service_name: grafana
placement:
  count: 1
networks:
  - 10.2.1.0/24
spec:
  anonymous_access: true
  protocol: https
  only_bind_port_on_networks: true
```

where the networks is set and the
"only_bind_port_on_networks" option is
set to true, the grafana daemon will bind
to its port (3000 in this case since it's
the default and I didn't set a port) only
on an IP from that network. I tested this
by holding port 3000 on an IP from a different
network on the host and then deploying
grafana. Without this patch it would have
failed with a port conflict error.

```
[root@vm-00 ~]# netstat -tulpn | grep 3000
tcp        0      0 10.2.1.61:3000          0.0.0.0:*               LISTEN      34178/grafana
tcp        0      0 192.168.122.251:3000    0.0.0.0:*               LISTEN      33274/nc
```

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 6ee5fff0c8dc71c4789496a587e2599ff2e0bc13)

mgr/dashboard: support rgw roles updating

Right now only the modification of max_session_duration is supported via
the roles update command. To update, we need to use `policy modify`
command which is not added in this PR. That should be done separately

Refer: https://docs.ceph.com/en/latest/radosgw/role/#update-a-role

Fixes: https://tracker.ceph.com/issues/63230
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 5c28d78a45d87d2be6b9ea2961be42689673e252)

mgr/dashboard: support rgw roles removal

Fixes: https://tracker.ceph.com/issues/63230
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 2e06ab0b8c730f063e1376b2f330c3b78089af67)

cephadm: improve cephadm pull usage message

Generally, it's uncommon for users to run this
directly, but in case they need to for debugging
purposes, we should include how to pass the
image to be pulled in the usage message.

Additionally, include that this is only to be used
for pulling ceph images in the help message, as
that isn't necessarily clear. Pulling anything
else will result in a traceback as it tries
to run `ceph --version` inside the container.

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 90b8ba9fc09ace4e4114152b194239061c7acb31)

doc/cephadm/services: Improve monitoring.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit ead944be18781ddccd52af5aa5cff414d15bb39d)

Merge pull request #55928 from ajarr/wip-64668-reef

reef: qa: add diff-continuous and compare-mirror-image tests to rbd and krbd suites respectively

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

cephadm: adjust the ingress ha proxy health check interval

Currently health checker uses default value of 2s, it is send list
bucket request for every 2s. This seems to be frequent and need to
adjust properly. Hence introducing new setting health_check_interval in
the ingress spec for haproxy.

Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
Apply suggestions from code review

Co-authored-by: Adam King <47704447+adk3798@users.noreply.github.com>
Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
(cherry picked from commit 75327c5b56591c6a29ad47745df24d16320f5a99)

Merge pull request #56196 from vshankar/wip-64926-reef

reef: mds: disable `defer_client_eviction_on_laggy_osds' by default

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>

qa/suites: add diff-continuous and compare-mirror-image tests

... to rbd and krbd suites respectively.

This allows the compare-mirror-image tests introduced in ea3a567
to be run against various kernel branches, e.g., testing branch.
And allows diff_continuous test in rbd_suite to run against distro
kernel.

Fixes: https://tracker.ceph.com/issues/64574
Signed-off-by: Ramana Raja <rraja@redhat.com>
(cherry picked from commit 92b254138dd43755490392ffcf5ebca04872e116)

qa/suites/rbd: rename nbd folder to device folder

Signed-off-by: Ramana Raja <rraja@redhat.com>
(cherry picked from commit af43f6162464a20625319a2783a104f7032ba21e)

Merge pull request #55762 from ajarr/wip-64554-reef

reef: qa: Add tests to validate synced images on rbd-mirror

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

doc/rados: update common.rst

Clarify some overwritten paragraphs in
doc/rados/configuration/common.rst. Cf.
https://github.com/ceph/ceph/pull/50795/files#r1153897231.

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 233b670704d15c3a69b8d91885b60f3fb101ec58)

Merge pull request #56262 from zdover23/wip-doc-2024-03-19-backport-56247-to-reef

reef: docs/rbd: fix typo in arg name

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>

docs/rbd: fix typo in arg name

Replace "{image-}" with "{image-id}" in the "rbd trash rm"
command description.

Signed-off-by: N Balachandran <nibalach@redhat.com>
(cherry picked from commit f3eb489520fd4fae057e61275d16c6c8fd596f3f)

docs/rbd: replace introspect with inspect

Replace "introspect" with "inspect" in the rbd basic commands
description.

Signed-off-by: N Balachandran <nibalach@redhat.com>
(cherry picked from commit ebf2f60f784728c04d8ec59015d666bafcef8218)

docs/rbd: typo in "retrieving image information"

Replace "for the image" with "of the image".

Signed-off-by: N Balachandran <nibalach@redhat.com>
(cherry picked from commit 4fd5c134536d652ae1f9e05ecf52cb81adb3b850)

Merge pull request #56256 from zdover23/wip-doc-2024-03-18-backport-56248-to-reef

reef: doc/rbd: minor changes to the rbd man page

ceph-volume: add missing import

This adds the missing import `List` (from typing).

Probably missed by 36c83bf54243.

Fixes: https://tracker.ceph.com/issues/64898
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 1abd3e659ff59d7b0c5c2360a665c395a748e3ff)

doc/rbd: minor changes to the rbd man page

Fixes typos and grammar for some commands. Adds
additional details for some commandds.

Signed-off-by: N Balachandran <nibalach@redhat.com>
(cherry picked from commit 5dcff6a4b8d835fc55e454af977dc5ebad99d37f)

Merge pull request #56252 from guits/wip-64932-reef

reef: node-proxy: fix RedFishClient.logout() method

mgr/dashboard: ceph authenticate user from fs

Fixes: https://tracker.ceph.com/issues/64660
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
(cherry picked from commit 19a9f79b5f218d8cb757579bf8c0f5d610dde3a8)

node-proxy: support more Location value formats

After some tests, it turns out that depending on the hardware,
the header 'Location' which is returned by the server after logged can be different.
I could notice the following:

either:

Location: scheme://address:port/redfish/v1/SessionService/Session

or

Location: /redfish/v1/SessionService/Session

a previous tracker [1] was opened because I thought only the first one existed, which is wrong.

Fixes: https://tracker.ceph.com/issues/64951
[1] https://tracker.ceph.com/issues/64894

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit d7ccf26983c41344a12f33b2a30fc79b65cc548f)

node-proxy: fix RedFishClient.logout() method

the endpoint passed down to util.query() is wrong:
is passes the full url (scheme://addr:port/path) where it should only
pass the path. The cause is that RedFishClient.login() basically stores
the value of the Location header in `self.location`.

The consequence of this is that it makes the client unable to properly logout.

Fixes: https://tracker.ceph.com/issues/64894
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit b1d828d1d2f31c02f225bb375d915353582d158a)

Merge pull request #56235 from zdover23/wip-doc-2024-03-16-backport-56182-to-reef

reef: doc/glossary: add "librados" entry

doc/glossary: add "librados" entry

Add a "librados" entry to the glossary.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 2a93a8e837a42559f8a81c6fd9274b24f4fdf7f6)

Merge pull request #56104 from adk3798/wip-64632-reef

reef: doc: adding documentation for secure monitoring stack configuration

Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>

Merge pull request #56103 from adk3798/wip-64629-reef

reef: mgr/cephadm: catch CancelledError in asyncio timeout handler

Reviewed-by: Guillaume Abrioux <gabrioux@ibm.com>

Merge pull request #56094 from adk3798/wip-63533-reef

reef: mgr/cephadm: fix reweighting of OSD when OSD removal is stopped

Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #56029 from asm0deuz/wip-64698-reef

reef: mgr/cephadm: Allow idmap overrides in nfs-ganesha configuration

Reviewed-by: Adam King <adking@redhat.com>

doc: cephadm/services/osd: fix typo

Signed-off-by: Lorenz Bausch <info@lorenzbausch.de>
(cherry picked from commit d513f1ca69d38f0d7eb40a2d68275caed322cc68)

doc/cephadm: document regex based host pattern

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 62bd0b9368d4a53b15d9ecb665444dd943dbcfcf)

mgr/cephadm: support for regex based host patterns

For example, with hosts vm-00, vm-01, and vm-02
I was able to provide the placement

service_type: node-exporter
service_name: node-exporter
placement:
  host_pattern:
    pattern: vm-00|vm-02
    pattern_type: regex

and it placed the node-exporter daemons on vm-00
and vm-02 but not vm-01. Obviously there are more
advanced scenarios that justify this than listing
two hosts, but using "|" as an OR like that is an
example of something you can't do with the fnmatch
version of the host pattern

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit f27790b057db667c48b1840472046db3d6d9c5f1)

Conflicts:
src/pybind/mgr/rook/rook_cluster.py

Merge pull request #55915 from mchangir/wip-64223-reef

reef: qa: bump up scrub status command timeout

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #55829 from kotreshhr/wip-64582-reef

reef: qa: Fix fs/full suite

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #55746 from lxbsz/wip-64222

reef: qa/tasks/cephfs/test_misc: switch duration to timeout

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #55743 from lxbsz/wip-64075

reef: mds: just wait the client flushes the snap and dirty buffer

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #55742 from lxbsz/wip-64045

reef: mds: use explicitly sized types for network and disk encoding

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #54520 from joscollin/wip-63553-reef

reef: cephfs-top: include the missing fields in --dump output

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #53893 from rishabh-d-dave/wip-63147-reef

reef: client: append to buffer list to save all result from wildcard command

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #52581 from rishabh-d-dave/wip-62026-reef

reef: mds: allow all types of mds caps

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #55716 from cbodley/wip-64540-reef

reef: rgw: RGWSI_SysObj_Cache::remove() invalidates after successful delete

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>

Merge pull request #56208 from zdover23/wip-doc-2024-03-15-backport-56188-to-reef

reef: doc/rbd: add clone mapping command

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>

mgr/dashboard: disable applitools e2e

Temporarily disabling this so the CI could turn green. Meanwhile I'll
research for a proper way to handle the applitools e2es which I'll track
on https://tracker.ceph.com/issues/64783

Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 09c50063a3763fc5d29f604a9daeb844252a31da)

test/librbd: add DiffIterateTruncate and DiffIterateWriteAndTruncate

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit d84485ec534ccf42327242a9141906f4881c030e)

librbd: don't clip expanded diff on truncate in ObjectListSnapsRequest

If the diff was expanded due to LIST_SNAPS_FLAG_WHOLE_OBJECT, clipping
it when handling a truncate is wrong -- when subtracting that interval,
we either split the expanded extent into two or chop off a piece of it.
However the point of LIST_SNAPS_FLAG_WHOLE_OBJECT is to report a single
extent covering the entire object.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 0ebca5fe22d976f1a17f8078f20a47c49a057edb)

librados/snap_set_diff: ignore truncates above size at start

Because currently calc_snap_set_diff() only ever appends to the running
diff, an excessive (either too large or completely bogus) zero extent
is reported in cases where an object is first expanded (with a snapshot
taken at that point) and then truncated but still above the size of the
object as of the starting snapshot.

Fixes: https://tracker.ceph.com/issues/63770
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 5b11fb314abefea390c5663c33e9e1ace6179974)

mgr/vol: don't import IndexException since it's unused

Introduced-by: 079f722c37ef6cc8bd3cc26c49ae119dd83431f9
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit b4c1d552aa4066efdda3493192927cb780693469)

qa: disable snapshot_clone_no_wait for some tests

Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit e5099d67a2478e199bba6a435300964756005525)

doc: add the reject the clone when threads are not available feature in the document

Fixes: https://tracker.ceph.com/issues/59714
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
(cherry picked from commit 6a44322d59e5542731dd450b383046a13bc28a66)

Conflicts:
doc/cephfs/fs-volumes.rst: order of lines were improper
due to amendments in `max_concurrent_clones` config option
explanation.

qa: add test cases for the support to reject clones feature

Fixes: https://tracker.ceph.com/issues/59714
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
(cherry picked from commit dbdc161f7473b6445a46f2cd69efb09f99e8193d)