]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
14 years agokernel console debug output setup scripts
Sage Weil [Mon, 7 Feb 2011 16:56:03 +0000 (08:56 -0800)]
kernel console debug output setup scripts

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
14 years agoscript: add script to build uml images
Sage Weil [Mon, 7 Feb 2011 05:17:08 +0000 (21:17 -0800)]
script: add script to build uml images

Set up a tap interface in your bridge, and then

./linux ubda=image mem=512M eth0=tuntap,tap0 ip=<ip> netmask=<netmask> gw=<gw>

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
14 years agoremove old script
Sage Weil [Mon, 7 Feb 2011 05:13:32 +0000 (21:13 -0800)]
remove old script

14 years agoremove ancient web content
Sage Weil [Mon, 7 Feb 2011 05:11:05 +0000 (21:11 -0800)]
remove ancient web content

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
14 years agomsgr: make remove_pid_file fail silently if nothing to remove
Sage Weil [Sun, 6 Feb 2011 21:37:58 +0000 (13:37 -0800)]
msgr: make remove_pid_file fail silently if nothing to remove

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
14 years agoremove ancient mds_local_osd option
Sage Weil [Sun, 6 Feb 2011 04:43:58 +0000 (20:43 -0800)]
remove ancient mds_local_osd option

This used to add a few osds to the end of the osdmap, not included in the
crush map, with the assumption that they would be colocated with the MDSs
and used as the primary MDS journal copy.  Not a useful hack anymore; you
can do this all explicitly by setting up your own crush map.

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
14 years agofakemessenger: remove fakemessenger and related dead code
Sage Weil [Sat, 5 Feb 2011 21:55:49 +0000 (13:55 -0800)]
fakemessenger: remove fakemessenger and related dead code

FakeMessenger has hopelessly drifted from the current abstract interface;
all of this code is years old.

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
14 years agoclock: remove tare function
Sage Weil [Sat, 5 Feb 2011 21:50:02 +0000 (13:50 -0800)]
clock: remove tare function

This was used way back when to set a clock's relative "zero" time to
simplify stat collection when running performance benchmarks.  It has no
use in a real system.  If we need relative time for something, we can
subtract off the zero time in the output.

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
14 years agoconfig: remove (most) unused options
Sage Weil [Sat, 5 Feb 2011 21:25:03 +0000 (13:25 -0800)]
config: remove (most) unused options

Left in a few that may be used later:

client_unmount_timeout
osd_shed_reads*
osd_min_raid_width
osd_recovery_forget_lost_objects

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
14 years agoclient: set lru midpoint
Sage Weil [Sat, 5 Feb 2011 21:21:59 +0000 (13:21 -0800)]
client: set lru midpoint

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
14 years agologger: don't calculate variance by default
Sage Weil [Sat, 5 Feb 2011 21:09:47 +0000 (13:09 -0800)]
logger: don't calculate variance by default

Less memory, less CPU.

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
14 years agomsgr: check return values
Sage Weil [Sat, 5 Feb 2011 17:19:06 +0000 (09:19 -0800)]
msgr: check return values

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
14 years agomsgr: check return values for write_pid_file
Sage Weil [Sat, 5 Feb 2011 17:18:57 +0000 (09:18 -0800)]
msgr: check return values for write_pid_file

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
14 years agomsgr: SimpleMessenger::start: fix unchecked return
Colin Patrick McCabe [Fri, 4 Feb 2011 19:00:24 +0000 (11:00 -0800)]
msgr: SimpleMessenger::start: fix unchecked return

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agomsgr: remove deadcode, warnings
Colin Patrick McCabe [Fri, 4 Feb 2011 18:57:56 +0000 (10:57 -0800)]
msgr: remove deadcode, warnings

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agomsgr: remove_pid_file: fix unchecked returns
Colin Patrick McCabe [Fri, 4 Feb 2011 18:53:36 +0000 (10:53 -0800)]
msgr: remove_pid_file: fix unchecked returns

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agoos: FileJournal::do_write: fix error handling
Colin Patrick McCabe [Fri, 4 Feb 2011 18:02:22 +0000 (10:02 -0800)]
os: FileJournal::do_write: fix error handling

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agoMerge branch 'wannoying2'
Colin Patrick McCabe [Fri, 4 Feb 2011 17:47:29 +0000 (09:47 -0800)]
Merge branch 'wannoying2'

Conflicts:
src/os/FileJournal.cc

14 years agofilestore: handle read_op_seq errors
Sage Weil [Fri, 4 Feb 2011 22:27:10 +0000 (14:27 -0800)]
filestore: handle read_op_seq errors

Fixes: #775
Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
14 years agoosd: Return error code when a write is too large.
Greg Farnum [Fri, 4 Feb 2011 21:42:09 +0000 (13:42 -0800)]
osd: Return error code when a write is too large.

This should prevent us from crashing the OSD by trying
to pass in a write that is larger than its journal can handle.

Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com>
14 years agoconfig: add new osd_max_write_size option.
Greg Farnum [Thu, 3 Feb 2011 00:12:04 +0000 (16:12 -0800)]
config: add new osd_max_write_size option.

Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com>
14 years agoassert.h: Add ceph_abort
Colin Patrick McCabe [Fri, 4 Feb 2011 17:28:30 +0000 (09:28 -0800)]
assert.h: Add ceph_abort

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agoos: _check_disk_write_cache: fix error handling
Colin Patrick McCabe [Fri, 4 Feb 2011 17:17:57 +0000 (09:17 -0800)]
os: _check_disk_write_cache: fix error handling

Fix error handling; use popen instead of a temporary file.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agocmds: check return code of chdir
Colin Patrick McCabe [Fri, 4 Feb 2011 16:50:43 +0000 (08:50 -0800)]
cmds: check return code of chdir

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agounittest_encoding: build without -fstrict-aliasing
Colin Patrick McCabe [Fri, 4 Feb 2011 16:45:37 +0000 (08:45 -0800)]
unittest_encoding: build without -fstrict-aliasing

unittest_encoding gets "this breaks strict-aliasing" warnings when
compiled under Ubuntu. So don't crank up optimization on the unit test.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agoFileStore::mount: fix error handling
Colin Patrick McCabe [Fri, 4 Feb 2011 15:42:14 +0000 (07:42 -0800)]
FileStore::mount: fix error handling

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agoos: fix zeroing first chunk of FileJournal
Colin Patrick McCabe [Fri, 4 Feb 2011 15:42:14 +0000 (07:42 -0800)]
os: fix zeroing first chunk of FileJournal

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agoos: FileStore::mkjournal: fix error handling
Colin Patrick McCabe [Fri, 4 Feb 2011 14:22:08 +0000 (06:22 -0800)]
os: FileStore::mkjournal: fix error handling

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agoos: FileJournal::create: fix error handling
Colin Patrick McCabe [Fri, 4 Feb 2011 14:16:07 +0000 (06:16 -0800)]
os: FileJournal::create: fix error handling

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agocmon: check return code of chdir
Colin Patrick McCabe [Fri, 4 Feb 2011 14:08:41 +0000 (06:08 -0800)]
cmon: check return code of chdir

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agotools/common: EINTR/unchecked return fix
Colin Patrick McCabe [Fri, 4 Feb 2011 12:42:01 +0000 (04:42 -0800)]
tools/common: EINTR/unchecked return fix

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agorados: fix pedantic gcc warning on writing stdout
Colin Patrick McCabe [Fri, 4 Feb 2011 12:37:53 +0000 (04:37 -0800)]
rados: fix pedantic gcc warning on writing stdout

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agofilejournal: fix unchecked returns, modularize
Colin Patrick McCabe [Fri, 4 Feb 2011 12:24:27 +0000 (04:24 -0800)]
filejournal: fix unchecked returns, modularize

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agocosd: check chdir return code
Colin Patrick McCabe [Thu, 3 Feb 2011 18:15:34 +0000 (10:15 -0800)]
cosd: check chdir return code

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agoosd: Ager: remove Ebofs leftovers
Colin Patrick McCabe [Thu, 3 Feb 2011 17:42:39 +0000 (09:42 -0800)]
osd: Ager: remove Ebofs leftovers

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agoAdd do_autogen.sh
Colin Patrick McCabe [Thu, 3 Feb 2011 14:50:32 +0000 (06:50 -0800)]
Add do_autogen.sh

It's handy when making builds with various different warning levels.
Also saves you from having to remember --prefix, etc. all the time.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agomkcephfs: clean up temp files, honor $TEMPDIR
Colin Patrick McCabe [Thu, 3 Feb 2011 15:53:51 +0000 (07:53 -0800)]
mkcephfs: clean up temp files, honor $TEMPDIR

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agofiler: fix probe
Sage Weil [Thu, 3 Feb 2011 23:53:53 +0000 (15:53 -0800)]
filer: fix probe

ENOENT is allowed and expected at the end of a journal.  It is treated the
same as a zero size object.

Fixes 800507e891170b99cae10a9bf7c5166fd3512927.

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
14 years agoclient/fuse_ll.c: const cleanup
Colin Patrick McCabe [Thu, 3 Feb 2011 15:51:57 +0000 (07:51 -0800)]
client/fuse_ll.c: const cleanup

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agoRevert "client/fuse_ll: fully initialize callback struct"
Colin Patrick McCabe [Thu, 3 Feb 2011 15:50:54 +0000 (07:50 -0800)]
Revert "client/fuse_ll: fully initialize callback struct"

Older build environments may not have all the fuse function ptrs that
are present in newer ones. It's best to just let them all silently be
set to 0.

This reverts commit 516ac99bb8c16614757f3b61f4bf266e4531861e.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agoRevert "client/fuse.cc: explicity zero fuse function ptrs"
Colin Patrick McCabe [Thu, 3 Feb 2011 15:47:59 +0000 (07:47 -0800)]
Revert "client/fuse.cc: explicity zero fuse function ptrs"

Older build environments may not have all the fuse function ptrs that
are present in newer ones. It's best to just let them all silently be
set to 0.

This reverts commit 38b50013e27e79dd43c5f514c8c24bd8b1e69e5f.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agoMerge branch 'master' of ssh://ceph.newdream.net/git/ceph
Colin Patrick McCabe [Thu, 3 Feb 2011 15:42:44 +0000 (07:42 -0800)]
Merge branch 'master' of ssh://ceph.newdream.net/git/ceph

14 years agofilestore: fix wipe_subvol the rest of the way
Sage Weil [Thu, 3 Feb 2011 23:24:06 +0000 (15:24 -0800)]
filestore: fix wipe_subvol the rest of the way

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
14 years agofilestore: fix (part of) wipe_subvol
Sage Weil [Thu, 3 Feb 2011 23:09:36 +0000 (15:09 -0800)]
filestore: fix (part of) wipe_subvol

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
14 years agomsgr: add nonce parsing to entity_addr_t::parse()
Sage Weil [Thu, 3 Feb 2011 22:41:48 +0000 (14:41 -0800)]
msgr: add nonce parsing to entity_addr_t::parse()

Reported-by: John Leach <john@brightbox.co.uk>
Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
14 years agoos: FileStore::wipe_subvol: fix removing old dir
Colin Patrick McCabe [Thu, 3 Feb 2011 12:30:32 +0000 (04:30 -0800)]
os: FileStore::wipe_subvol: fix removing old dir

Older versions of btrfs which don't have BTRFS_IOC_SNAP_DESTROY need to
manually remove snapshots.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agocosd.cc: better error message if osd->init fails
Colin Patrick McCabe [Thu, 3 Feb 2011 14:07:26 +0000 (06:07 -0800)]
cosd.cc: better error message if osd->init fails

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agoauth/ExportControl: fix allow_def leak
Samuel Just [Thu, 3 Feb 2011 20:20:22 +0000 (12:20 -0800)]
auth/ExportControl: fix allow_def leak

allow_def would be leaked if the first branch is not taken.

Signed-off-by: Samuel Just <samuel.just@dreamhost.com>
14 years agoMerge branch 'stable'
Sage Weil [Thu, 3 Feb 2011 19:58:59 +0000 (11:58 -0800)]
Merge branch 'stable'

Conflicts:
src/common/signal.cc
src/os/FileStore.cc

14 years agosignal: fix redefine warnings
Sage Weil [Thu, 3 Feb 2011 18:10:51 +0000 (10:10 -0800)]
signal: fix redefine warnings

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
14 years agoReplicatedPG: snap_trimmer fix leaked lock
Samuel Just [Thu, 3 Feb 2011 19:58:56 +0000 (11:58 -0800)]
ReplicatedPG: snap_trimmer fix leaked lock

Previous patch 7a02070b741d3482ff6b28827c1eb274a2134486 leaks the pg
lock.

Signed-off-by: Samuel Just <samuel.just@dreamhost.com>
14 years agomds: make SETDIRLAYOUT start with ancestor policy
Sage Weil [Thu, 3 Feb 2011 19:54:01 +0000 (11:54 -0800)]
mds: make SETDIRLAYOUT start with ancestor policy

When we set a new policy on a directory, make the starting point the
current policy, as specified by an ancestor.  Remove any reference to
g_default_file_layout.

This aligns the code with the inode creation paths (the other time we
look at the layout policy).

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
14 years agoReplicatedPG:snap_trimmer should return if !clean or !active or !primary
Samuel Just [Thu, 3 Feb 2011 18:31:47 +0000 (10:31 -0800)]
ReplicatedPG:snap_trimmer should return if !clean or !active or !primary

The PG may become !clean or !active while in the osd snap_trim_wq.

Signed-off-by: Samuel Just <samuel.just@dreamhost.com>
14 years agoMerge branch 'wannoying'
Colin Patrick McCabe [Thu, 3 Feb 2011 12:36:56 +0000 (04:36 -0800)]
Merge branch 'wannoying'

14 years agoMonMap: add,remove,contains can take const references
Samuel Just [Thu, 3 Feb 2011 19:35:47 +0000 (11:35 -0800)]
MonMap: add,remove,contains can take const references

Signed-off-by: Samuel Just <samuel.just@dreamhost.com>
14 years agoSimpleMessenger: learned_addr can take a const ref
Samuel Just [Thu, 3 Feb 2011 19:34:17 +0000 (11:34 -0800)]
SimpleMessenger: learned_addr can take a const ref

peer_addr_for_me can be passed as a const ref.

Signed-off-by: Samuel Just <samuel.just@dreamhost.com>
14 years agomds: handle_client_setdirlayout: init fl_pg_pool
Greg Farnum [Thu, 3 Feb 2011 12:12:37 +0000 (04:12 -0800)]
mds: handle_client_setdirlayout: init fl_pg_pool

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agolibrados: print out errs in do_import, check EINTR
Colin Patrick McCabe [Thu, 3 Feb 2011 12:10:58 +0000 (04:10 -0800)]
librados: print out errs in do_import, check EINTR

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agoinclude/utime.h: avoid comparing float with 0
Colin Patrick McCabe [Thu, 3 Feb 2011 11:20:40 +0000 (03:20 -0800)]
include/utime.h: avoid comparing float with 0

Avoid doing an exact comparison of a float with 0.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agocrush: eliminate signed/unsigned comparisons
Colin Patrick McCabe [Wed, 2 Feb 2011 18:24:17 +0000 (10:24 -0800)]
crush: eliminate signed/unsigned comparisons

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agoclient/fuse.cc: explicity zero fuse function ptrs
Colin Patrick McCabe [Wed, 2 Feb 2011 17:57:32 +0000 (09:57 -0800)]
client/fuse.cc: explicity zero fuse function ptrs

Set unused function pointers to 0 explicitly to please gcc. (They were
already implicitly zeroed because the containing struct was a global.)

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agomount.ceph: put static at the beginning of decl
Colin Patrick McCabe [Wed, 2 Feb 2011 17:44:13 +0000 (09:44 -0800)]
mount.ceph: put static at the beginning of decl

To squash a gcc warning.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agotools/gui.cc: remove empty else statement
Colin Patrick McCabe [Wed, 2 Feb 2011 17:42:51 +0000 (09:42 -0800)]
tools/gui.cc: remove empty else statement

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agomon/OSDMonitor: don't check if unsigned < 0
Colin Patrick McCabe [Wed, 2 Feb 2011 17:37:27 +0000 (09:37 -0800)]
mon/OSDMonitor: don't check if unsigned < 0

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agoosd/OSD: remove always-true assert
Colin Patrick McCabe [Wed, 2 Feb 2011 17:36:46 +0000 (09:36 -0800)]
osd/OSD: remove always-true assert

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agoconst-ify some unchanging static structs
Colin Patrick McCabe [Thu, 3 Feb 2011 12:10:22 +0000 (04:10 -0800)]
const-ify some unchanging static structs

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agorgw/rgw_rest.cc: fix uninitialized static struct
Colin Patrick McCabe [Wed, 2 Feb 2011 17:27:59 +0000 (09:27 -0800)]
rgw/rgw_rest.cc: fix uninitialized static struct

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agoosdc/Filer: assert(0) on stat error
Colin Patrick McCabe [Wed, 2 Feb 2011 17:01:50 +0000 (09:01 -0800)]
osdc/Filer: assert(0) on stat error

Remove broken error handling code and replace with an assert(0) and a
TODO.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agoclient/fuse_ll: fully initialize callback struct
Colin Patrick McCabe [Wed, 2 Feb 2011 16:30:30 +0000 (08:30 -0800)]
client/fuse_ll: fully initialize callback struct

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agomds/locks: fully initialize lock states
Colin Patrick McCabe [Wed, 2 Feb 2011 16:28:42 +0000 (08:28 -0800)]
mds/locks: fully initialize lock states

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agoosdc/ObjectCacher.h: don't assert unsigned >= 0
Colin Patrick McCabe [Wed, 2 Feb 2011 16:26:16 +0000 (08:26 -0800)]
osdc/ObjectCacher.h: don't assert unsigned >= 0

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agoClient::readdir_r_cb: fix "always returns true"cmp
Colin Patrick McCabe [Wed, 2 Feb 2011 16:25:33 +0000 (08:25 -0800)]
Client::readdir_r_cb: fix "always returns true"cmp

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agodirect_io_test: fix signed/unsigned, printf flags
Colin Patrick McCabe [Wed, 2 Feb 2011 14:54:04 +0000 (06:54 -0800)]
direct_io_test: fix signed/unsigned, printf flags

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agosrc/config.cc: fully initialize g_default_file_layout
Colin Patrick McCabe [Wed, 2 Feb 2011 14:53:37 +0000 (06:53 -0800)]
src/config.cc: fully initialize g_default_file_layout

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agocrush/builder.c: fix signed/unsigned confusion
Colin Patrick McCabe [Wed, 2 Feb 2011 13:41:07 +0000 (05:41 -0800)]
crush/builder.c: fix signed/unsigned confusion

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agoinclude/buffer.h:unsigned variables are always >=0
Colin Patrick McCabe [Wed, 2 Feb 2011 12:41:10 +0000 (04:41 -0800)]
include/buffer.h:unsigned variables are always >=0

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agoMerge branch 'master' of ssh://ceph.newdream.net/git/ceph
Colin Patrick McCabe [Thu, 3 Feb 2011 11:53:29 +0000 (03:53 -0800)]
Merge branch 'master' of ssh://ceph.newdream.net/git/ceph

14 years agoRGW: RGW::GetObj - signed/unsigned bug
Samuel Just [Wed, 2 Feb 2011 22:25:09 +0000 (14:25 -0800)]
RGW: RGW::GetObj - signed/unsigned bug

get_obj returns an int, len is unsigned

Signed-off-by: Samuel Just <samuel.just@dreamhost.com>
14 years agoRGW: fix ret in RGWCopyObj::init_common
Samuel Just [Wed, 2 Feb 2011 20:03:52 +0000 (12:03 -0800)]
RGW: fix ret in RGWCopyObj::init_common

int ret shadows RGWCopyObj::ret.

Signed-off-by: Samuel Just <samuel.just@dreamhost.com>
14 years agoRGW: fix shadowed variable error
Samuel Just [Wed, 2 Feb 2011 20:01:22 +0000 (12:01 -0800)]
RGW: fix shadowed variable error

int ret and bool ret shadow this->ret, setting ret before the goto
therefore had no effect in these cases.

Signed-off-by: Samuel Just <samuel.just@dreamhost.com>
14 years agoRGW: get_service_secret returns a bool, not an int
Samuel Just [Wed, 2 Feb 2011 20:00:00 +0000 (12:00 -0800)]
RGW: get_service_secret returns a bool, not an int

Signed-off-by: Samuel Just <samuel.just@dreamhost.com>
14 years agoRBD.cc: pread returns a signed value
Samuel Just [Wed, 2 Feb 2011 22:19:42 +0000 (14:19 -0800)]
RBD.cc: pread returns a signed value

The check for len < 0 here always returned true since len is uint64_t.

Signed-off-by: Samuel Just <samuel.just@dreamhost.com>
14 years agomount.ceph: option parsing fix
Samuel Just [Wed, 2 Feb 2011 21:35:21 +0000 (13:35 -0800)]
mount.ceph: option parsing fix

Passing -o secretfile would cause a segfault since searching for = would
result in a null pointer.  New version checks for that case.  Also, *end
cannot be a ,.

Signed-off-by: Samuel Just <samuel.just@dreamhost.com>
14 years agoMerge branch 'objecter_balance_reads'
Colin Patrick McCabe [Wed, 2 Feb 2011 12:25:34 +0000 (04:25 -0800)]
Merge branch 'objecter_balance_reads'

14 years agoFix base64-decoding when input ends in newline.
Tommi Virtanen [Wed, 2 Feb 2011 19:02:14 +0000 (11:02 -0800)]
Fix base64-decoding when input ends in newline.

It used to return -EINVAL because it thought the end was not aligned
to 4 bytes.

Clean up superfluous src < end test in if, the while itself guarantees
that.

14 years agoFix inner loop index variable. i and j are too close together ;)
Tommi Virtanen [Wed, 2 Feb 2011 17:59:49 +0000 (09:59 -0800)]
Fix inner loop index variable. i and j are too close together ;)

Before this fix, j would keep increasing well beyond in_len,
and lead to segfaults.

14 years agoosd: Fix compile-time warning.
Greg Farnum [Wed, 2 Feb 2011 17:57:14 +0000 (09:57 -0800)]
osd: Fix compile-time warning.

store is properly initialized inside a try block, but the
compiler doesn't notice that and so thinks it may be used
uninitialized. So initialize it to be NULL.

Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com>
14 years agomds: Remove unused variable.
Greg Farnum [Wed, 2 Feb 2011 17:54:45 +0000 (09:54 -0800)]
mds: Remove unused variable.

Fixes compile complaint. Was made useless in commit
6d29fc66326ff40443ac465c84d6f7bddf3cee4f.

Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com>
14 years agorados: Make rados tool "put" objects in chunks.
Greg Farnum [Wed, 2 Feb 2011 17:51:33 +0000 (09:51 -0800)]
rados: Make rados tool "put" objects in chunks.

Defaults to 4MB, but can be configured.

Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com>
14 years agomds: Remove redundant cap suppression code.
Greg Farnum [Tue, 1 Feb 2011 20:42:59 +0000 (12:42 -0800)]
mds: Remove redundant cap suppression code.

Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com>
14 years agoSpeling fixes
Chris Dunlop [Wed, 2 Feb 2011 05:38:54 +0000 (05:38 +0000)]
Speling fixes

Trivial spelling fixes...

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
14 years agoImprove mount.ceph.8
Chris Dunlop [Wed, 2 Feb 2011 06:02:10 +0000 (06:02 +0000)]
Improve mount.ceph.8

Seeing as I was wondering what "rbytes" might be, I guess others might
too...

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
14 years agomonitorstore: check return values
Sage Weil [Wed, 2 Feb 2011 05:08:34 +0000 (21:08 -0800)]
monitorstore: check return values

And use open(2) instead of fopen.

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
14 years agomds: check return values in dumper
Sage Weil [Wed, 2 Feb 2011 05:07:55 +0000 (21:07 -0800)]
mds: check return values in dumper

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
14 years agoconfutils: check return values
Sage Weil [Wed, 2 Feb 2011 05:07:45 +0000 (21:07 -0800)]
confutils: check return values

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
14 years agoos: use scoped variables for fds
Colin Patrick McCabe [Tue, 1 Feb 2011 19:08:56 +0000 (11:08 -0800)]
os: use scoped variables for fds

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agotest: add test_csyn
Colin Patrick McCabe [Tue, 1 Feb 2011 18:49:28 +0000 (10:49 -0800)]
test: add test_csyn

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agocsyn: implement localize_reads cmdline option
Colin Patrick McCabe [Tue, 1 Feb 2011 18:14:05 +0000 (10:14 -0800)]
csyn: implement localize_reads cmdline option

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agoosd: change unfound handling when using localize
Colin Patrick McCabe [Tue, 1 Feb 2011 14:22:02 +0000 (06:22 -0800)]
osd: change unfound handling when using localize

Change how cosd handles unfound objects when doing operations with
localize_reads. Specifically, don't wait for unfound objects unless we
are the primary for the relevant PG.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
14 years agoHadoop: set localize_reads
Colin Patrick McCabe [Mon, 31 Jan 2011 18:45:58 +0000 (10:45 -0800)]
Hadoop: set localize_reads

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>