librbd: fix possible use-after-free

(of the pointer)

CID 966634 (#1 of 1): Use after free (USE_AFTER_FREE)
2. use_after_free: Using freed pointer "ictx".

Signed-off-by: Sage Weil <sage@inktank.com>

ceph-filestore-dump: fix uninit fields in ctor

Signed-off-by: Sage Weil <sage@inktank.com>

rgw: fix various uninit class fields

Signed-off-by: Sage Weil <sage@inktank.com>

radosgw-admin: fix fd leak in read_input()

Signed-off-by: Sage Weil <sage@inktank.com>

rados: fix fd leak

Signed-off-by: Sage Weil <sage@inktank.com>

rados: fix buffer leak

Signed-off-by: Sage Weil <sage@inktank.com>

os/Filestore: fix fd leak in error path

Signed-off-by: Sage Weil <sage@inktank.com>

mon: fix Formatter leak

Signed-off-by: Sage Weil <sage@inktank.com>

mds: fix fd leak

Signed-off-by: Sage Weil <sage@inktank.com>

doc/release-notes: v0.61.1 release notes

Signed-off-by: Sage Weil <sage@inktank.com>

Merge remote-tracking branch 'gh/next'

Conflicts:
src/mon/MonitorDBStore.h

mon: dump MonitorDBStore transactions to file

Signed-off-by: Samuel Just <sam.just@inktank.com>
(cherry picked from commit 797089ef082b99910eebfd9454c03d1f027c93bb)

osd: optionally enable leveldb logging

Signed-off-by: Sage Weil <sage@inktank.com>
(cherry picked from commit 0b4c5c1a3349670d11cc3c4fb3c4b3c1a80b2502)

mon: allow leveldb logging

'mon leveldb log = filename'

Signed-off-by: Sage Weil <sage@inktank.com>
(cherry picked from commit c1d5f815546b731e10bfcb81cbcd48b7d432e9c4)

common/Preforker: fix warnings

Signed-off-by: Sage Weil <sage@inktank.com>

debian/control:  squeeze requres cryptsetup package

Squeeze requires the cryptsetup package which has been renamed
cryptsetup-bin in later versions.  Allow either package to
satisfy the dependency.

Signed-off-by: Gary Lowell <gary.lowell@inktank.com>
(cherry picked from commit 83bbae415de16f708ca1cb24861ddbb0bd514a7f)

debian/control:  squeeze requres cryptsetup package

Squeeze requires the cryptsetup package which has been renamed
cryptsetup-bin in later versions.  Allow either package to
satisfy the dependency.

Signed-off-by: Gary Lowell <gary.lowell@inktank.com>

ceph-create-keys: gracefully handle no data from admin socket

Old ceph-mon (prior to 393c9372f82ef37fc6497dd46fc453507a463d42) would
return an empty string and success if the command was not registered yet.
Gracefully handle that case by retrying.

If we still fail to parse, exit entirely with EINVAL.

Fixes: #4952
Signed-off-by: Sage Weil <sage@inktank.com>
Reviewed-by: Dan Mick <dan.mick@intank.com>

init-ceph: fix osd_data location when checking df utilization

Do not assume default osd data location.

Fixes: #4951
Backport: cuttlefish, bobtail
Signed-off-by: Sage Weil <sage@inktank.com>
Reviewed-by: Gary Lowelll <gary.lowell@inktank.com>

Merge pull request #266 from ceph/wip-4949

osd: don't assert if get_omap_iterator() returns NULL

Reviewed-by: Sam Just <sam.just@inktank.com>

osd: don't assert if get_omap_iterator() returns NULL

Fixes: #4949
This can happen if the object does not exist and it's
a write operation. Just return -ENOENT.

Signed-off-by: Yehuda Sadeh <yehuda@inktank.com>

Merge pull request #165 from dachary/wip-4321

unit tests for FileStore::_detect_fs when running on ext4

rgw: user operation mask

Fixes: #4716
add user operation mask for controlling user permissions.
Also add admin controls for it.

Signed-off-by: Yehuda Sadeh <yehuda@inktank.com>
Reviewed-by: Greg Farnum <greg@inktank.com>

Merge pull request #180 from ceph/wip-rados-clone

Reviewed-by: Josh Durgin <josh.durgin@inktank.com>

Merge branch 'wip_split_upgrade' into next

Fixes: #4927

OSD: handle stray snap collections from upgrade bug

Previously, we failed to clear snap_collections, which causes split to
spawn a bunch of snap collections.  In load_pgs, we now clear any such
snap collections and then snap_collections field on the PG itself.

Related: #4927
Signed-off-by: Samuel Just <sam.just@inktank.com>
Reviewed-by: Sage Weil <sage@inktank.com>

PG: clear snap_collections on upgrade

Signed-off-by: Samuel Just <sam.just@inktank.com>
Reviewed-by: Sage Weil <sage@inktank.com>

OSD: snap collections can be ignored on split

Signed-off-by: Samuel Just <sam.just@inktank.com>
Reviewed-by: Sage Weil <sage@inktank.com>

Merge pull request #265 from ceph/wip-mon-trace

mon: set MonitorDBStore options on open

So both ctors set the options.

Signed-off-by: Sage Weil <sage@inktank.com>

Merge pull request #254 from ceph/wip-crush-rules

Reviewed-by: Joao Luis <joao.luis@inktank.com>

ceph: return error code when failing to get result from admin socket

Make sure we return a non-zero result code when we fail to read something
from the admin socket.

Backport: cuttlefish, bobtail
Signed-off-by: Sage Weil <sage@inktank.com>

ceph-monstore-tool: added replay

ceph-monstore-tool: add MonitorDBStore trace dumper

Signed-off-by: Samuel Just <sam.just@inktank.com>

mon: dump MonitorDBStore transactions to file

Signed-off-by: Samuel Just <sam.just@inktank.com>

Merge pull request #261 from ceph/wip-leveldb

Reviewed-by: Samuel Just <sam.just@inktank.com>

doc/install/os-recs: reverse order of releases

Signed-off-by: Sage Weil <sage@inktank.com>

Merge pull request #263 from wido/config-get

Add "config get <var>" to the admin

Reviewed-by: Sage Weil <sage@inktank.com>

doc: Fixed typos.

fixes: #4932

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Fixed typo.

fixes: #4422

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Removed "and" as suggested.

fixes: #3686

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Fixed hyperlink.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Fixed path typo.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Updated OS support for Cuttlefish.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Minor tweak to the definition list style.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Added glossary to TOC.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Added glossary.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Fixed usage typo.

fixes: #4923

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

Merge pull request #262 from gollub/typos

fixed common typo in error messages

Fix whitespace indentation

Signed-off-by: Wido den Hollander <wido@42on.com>

Implement 'config get <var>' for the admin socket

Signed-off-by: Wido den Hollander <wido@42on.com>

fixed common typo in error messages

Signed-off-by: Daniel Gollub <d.gollub@telekom.de>

doc/install/{debian,rpm}: update for cuttlefish

Signed-off-by: Sage Weil <sage@inktank.com>

doc/start/get-involved: fix links

ERROR: /srv/autobuild-ceph/gitbuilder.git/build/doc/start/get-involved.rst:33: Unknown target name: "tracker".
ERROR: /srv/autobuild-ceph/gitbuilder.git/build/doc/start/get-involved.rst:43: Unknown target name: "support".

Signed-off-by: Sage Weil <sage@inktank.com>

doc/release-notes: I missed rgw rest api in the release notes

Mostly from here dd19d693e6528c70167958ebc57e075200a08803

Signed-off-by: Sage Weil <sage@inktank.com>

Merge branch 'next'

os/ObjectStore: add missing break in dump()

CID 751331 (#1 of 1): Missing break in switch (MISSING_BREAK)
unterminated_case: This case (value 35) is not terminated by a 'break' statement.

Signed-off-by: Sage Weil <sage@inktank.com>

rados: add whole-object 'clonedata' command

Clone the data stream from one object to another.

Signed-off-by: Sage Weil <sage@inktank.com>

doc: Deleted redundant "so that" phrase.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Corrected typo.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Corrected typo.

Removed comment out of header, and added "coming soon."

doc: Updated usage for push | pull.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

osd: make class load errors louder

Fixes: #4639
Signed-off-by: Sage Weil <sage@inktank.com>

osd: optionally enable leveldb logging

Signed-off-by: Sage Weil <sage@inktank.com>

mon: allow leveldb logging

'mon leveldb log = filename'

Signed-off-by: Sage Weil <sage@inktank.com>

v0.61

os/: default to dio for non-block journals

Workaround: #4910
Signed-off-by: Samuel Just <sam.just@inktank.com>
Reviewed-by: Sage Weil <sage@inktank.com>

ceph-disk: use separate lock files for prepare, activate

Use a separate lock file for prepare and activate to avoid deadlock.  This
didn't seem to trigger on all machines, but in many cases, the prepare
process would take the file lock and later trigger a udev event and the
activate would then block on the same lock, either when we explicitly call
'udevadm settle --timeout=10' or when partprobe does it on our behalf
(without a timeout!).   Avoid this by using separate locks for prepare
and activate.  We only care if multiple activates race; it is
okay for a prepare to be in progress and for an activate to be kicked
off.

Signed-off-by: Sage Weil <sage@inktank.com>

ceph-test.install: add ceph-monstore-tool and ceph-osdomap-tool

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

ceph.spec.in: remove twice listed ceph-coverage

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

ceph.spec: add some files to ceph

Add installed, but not packaged files to ceph-test (ceph-monstore-tool,
ceph-osdomap-tool) rpm file section.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

doc: Update the usage to reflect optional directory name.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Rearranged to show zapping multiple disks and creating multiple OSDs.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Moved install to the second step, from the first step.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

Merge pull request #256 from dalgaaf/wip-da-spec-update

Fix ceph.spec.in

Merge pull request #257 from dalgaaf/wip-da-fix-debian

ceph-test.install: add ceph-monstore-tool and ceph-osdomap-tool

doc: Autonumbering syntax correction.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Added troubleshooting PGs to the index.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Commented out osd list for now.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Commented out remove a mds for now.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Forwarding link. FAQ migrated to new Ceph wiki.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

ceph-test.install: add ceph-monstore-tool and ceph-osdomap-tool

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

ceph.spec.in: remove twice listed ceph-coverage

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

ceph.spec: add some files to ceph

Add installed, but not packaged files to ceph-test (ceph-monstore-tool,
ceph-osdomap-tool) rpm file section.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

mon: fix init sequence when not daemonizing

We made the common_init_finish and chdir conditional on daemonize in commit
2e0dd5ae6c8751e33d456b2b06c1204b63db959a, breaking init (asok at least)
when -f is specified (as with upstart).

Signed-off-by: Sage Weil <sage@inktank.com>
Reviewed-by: Greg Farnum <greg@inktank.com>

ceph: add 'osd crush rule ...' to usage

Signed-off-by: Sage Weil <sage@inktank.com>

mon: avoid null deref in Monitor::_mon_status()

mikedawson reports:

*** Caught signal (Segmentation fault) **
 in thread 7f40ce270700

 ceph version 0.60-801-g7ec0151 (7ec01513970b5a977bdbdf60052b6f6e257d267e)
 1: /usr/bin/ceph-mon() [0x59d550]
 2: (()+0xfbd0) [0x7f40d3e38bd0]
 3: (operator<<(std::ostream&, entity_name_t const&)+0x16) [0x4d7c46]
 4: (operator<<(std::ostream&, entity_inst_t const&)+0x1b) [0x4d837b]
 5: (Monitor::_mon_status(std::ostream&)+0x2ce) [0x4d284e]
 6: (Monitor::do_admin_command(std::string, std::string, std::ostream&)+0x4f) [0x4d652f]
 7: (AdminHook::call(std::string, std::string, ceph::buffer::list&)+0x68) [0x4efa38]
 8: (AdminSocket::do_accept()+0x451) [0x64ab81]
 9: (AdminSocket::entry()+0x398) [0x64c528]
 10: (()+0x7f8e) [0x7f40d3e30f8e]
 11: (clone()+0x6d) [0x7f40d237ae1d]

Signed-off-by: Sage Weil <sage@inktank.com>
Reviewed-by: Greg Farnum <greg@inktank.com>

mon: generate useful error msgs for 'osd crush rule create-simple ...'

Signed-off-by: Sage Weil <sage@inktank.com>

crush: return -1 on error from get_type_id

So we can distinguish between a bad type name and type 0.

Fix both callers, too.

Signed-off-by: Sage Weil <sage@inktank.com>

ceph.spec: require xfsprogs

This is needed when creating new OSDs (via ceph-disk).  At least for most
people.  Eventually we'll want to include btrfs here.

Signed-off-by: Sage Weil <sage@inktank.com>

Merge branch 'next'

doc/release-notes: warn about sysvinit crush map update

See c189d855e67baadf977d8ca14509dcacd579af7a.

Signed-off-by: Sage Weil <sage@inktank.com>

init-ceph: update osd crush map position on start

This is what the upstart ceph-osd.conf does; we need to do the same so that
new OSDs (e.g., that ceph-deploy creates) get added to the crush map.

Signed-off-by: Sage Weil <sage@inktank.com>

mon: fork early to avoid leveldb static env state

leveldb has static state that prevents it from recreating its worker thread
after our fork(), even when we close and reopen the database (tsk tsk!).
Avoid this by forking early, before we touch leveldb.

Hide the details in a Preforker class.  This is modeled after what
ceph-fuse already does; we should convert it later.

Signed-off-by: Sage Weil <sage@inktank.com>
Reviewed-by: Samuel Just <sam.just@inktank.com>
Reviewed-by: Greg Farnum <greg@inktank.com>

doc/release-notes: add/link complete changelogs

Signed-off-by: Sage Weil <sage@inktank.com>

doc/release-notes: v0.56.5

Signed-off-by: Sage Weil <sage@inktank.com>

doc: Fixed typos.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

Merge branch 'next'

Revert "mon: fix Monitor::pick_random_mon()"

This reverts commit 741f46852380c8e75669f6d7bf1202adad0358fb.

This is fixed in next; revert this to avoid a conflict.

Signed-off-by: Sage Weil <sage@inktank.com>