]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Yuval Lifshitz [Mon, 23 Aug 2021 14:01:54 +0000 (17:01 +0300)]
Merge pull request #42434 from zenomri/wip-omri-rgw-tracing
[WIP] - RGW tracing implementation
Stephan Müller [Mon, 23 Aug 2021 13:52:57 +0000 (15:52 +0200)]
Merge pull request #41380 from Devp00l/wip-rgw-multisite-doc
doc: Improve RGW multisite documentation
Reviewed-by: Volker Theile <vtheile@suse.com>
Reviewed-by: Alex Settle <asettle@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Alfonso Martínez [Mon, 23 Aug 2021 12:59:00 +0000 (14:59 +0200)]
Merge pull request #42864 from aaryanporwal/vrt-doc
doc/dev: mgr/dashboard: Visual regression tests for ceph dashboard
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Yuval Lifshitz [Mon, 23 Aug 2021 12:46:54 +0000 (15:46 +0300)]
Merge pull request #42739 from Matan-B/lua-install-packages-fix
rgw: fix install packages function
Alfonso Martínez [Mon, 23 Aug 2021 12:43:56 +0000 (14:43 +0200)]
Merge pull request #42865 from rhcs-dashboard/fix-rgw-bucket-list-api
mgr/dashboard: stats=false not working when listing buckets
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Sebastian Wagner [Mon, 23 Aug 2021 12:29:01 +0000 (14:29 +0200)]
Merge pull request #42051 from melissa-kun-li/asyncssh
mgr/cephadm: replace execnet and remoto with asyncssh
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Dimitri Savineau <dsavinea@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Ilya Dryomov [Mon, 23 Aug 2021 11:46:31 +0000 (13:46 +0200)]
Merge pull request #42804 from zdover23/wip-doc-2021-08-17-rbd-nomad-1-of-x
doc: improve RBD "Block Devices and Nomad"
Reviewed-by: Etienne Menguy <etienne.menguy@croit.io>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Kefu Chai [Mon, 23 Aug 2021 11:10:37 +0000 (19:10 +0800)]
Merge pull request #42879 from tchaikov/wip-seastar
seastar: pick up change silencing gcc warning
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Avan Thakkar [Fri, 20 Aug 2021 09:07:17 +0000 (14:37 +0530)]
mgr/dashboard: stats=false not working when listing buckets
Fixes: https://tracker.ceph.com/issues/51154
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
Aaryan Porwal [Sat, 21 Aug 2021 15:26:14 +0000 (20:56 +0530)]
doc/dev: mgr/dashboard: Visual regression tests for ceph dashboard
Fixes: https://tracker.ceph.com/issues/52370
Signed-off-by: Aaryan Porwal <aaryanporwal2233@gmail.com>
Mykola Golub [Mon, 23 Aug 2021 08:33:41 +0000 (11:33 +0300)]
Merge pull request #41405 from ideepika/wip-rbd-update-feature-test
test/librbd: add unit tests for rbd update features
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
J. Eric Ivancich [Sun, 22 Aug 2021 22:34:16 +0000 (18:34 -0400)]
Merge pull request #42532 from ivancich/wip-multisite-conflict-detection
rgw-multisite: metadata conflict not computed correctly
Reviewed-by: Casey Bodley <cbodley@redhat.com>
J. Eric Ivancich [Wed, 28 Jul 2021 18:07:09 +0000 (14:07 -0400)]
rgw-multisite: metadata conflict not computed correctly
The former logic with a conditional based on `++i == 0` would never
execute. So this uses a boolean to differentiate the first from other
iterations and tries to clarify the code through commenting and an
explicit declaration. Additionally a warning is eliminated by
initializing a variable.
Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
Ilya Dryomov [Sun, 22 Aug 2021 19:01:15 +0000 (21:01 +0200)]
Merge pull request #42792 from tchaikov/wip-librbd-cleanups
librbd: trade a map<> for a plain array
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Kefu Chai [Sun, 22 Aug 2021 14:15:56 +0000 (22:15 +0800)]
seastar: pick up change silencing gcc warning
silences compiler warning from src/net/tls.cc
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Sebastian Wagner [Sat, 21 Aug 2021 08:55:45 +0000 (10:55 +0200)]
Merge pull request #42855 from josephsawaya/rook-label
.github/labeler: add rook label to PRs related to Rook
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
Melissa [Wed, 21 Jul 2021 03:46:41 +0000 (23:46 -0400)]
mgr/cephadm: replace instances of remoto/execnet with asyncssh
Fixes: https://tracker.ceph.com/issues/44676
Signed-off-by: Melissa Li <li.melissa.kun@gmail.com>
Melissa [Wed, 21 Jul 2021 03:36:20 +0000 (23:36 -0400)]
mgr/cephadm: rewrite test_etc_ceph to apply to asyncssh
Fixes: https://tracker.ceph.com/issues/44676
Signed-off-by: Melissa Li <li.melissa.kun@gmail.com>
Melissa [Wed, 21 Jul 2021 03:33:37 +0000 (23:33 -0400)]
mgr/cephadm: remove test_stale_connections
remove test_stale_connections because it applies to remoto
Fixes: https://tracker.ceph.com/issues/44676
Signed-off-by: Melissa Li <li.melissa.kun@gmail.com>
Melissa [Wed, 21 Jul 2021 03:28:04 +0000 (23:28 -0400)]
mgr/cephadm: add test_offline, edit with_cephadm_module
add `event_loop` and `tkey` object to with_cephadm_module, and create MockEventLoopThread in fixtures.py to test async functions of ssh.py.
rewrite test_offline to be compatible with asyncssh
Fixes: https://tracker.ceph.com/issues/44676
Signed-off-by: Melissa Li <li.melissa.kun@gmail.com>
Melissa [Wed, 21 Jul 2021 03:19:33 +0000 (23:19 -0400)]
mgr/cephadm: simplify _deploy_cephadm_binary, remove _deploy_cephadm_binary_conn
_deploy_cephadm_binary can be simplified to call write_remote_file in ssh.py, and _deploy_cephadm_binary_conn is no longer needed
Fixes: https://tracker.ceph.com/issues/44676
Signed-off-by: Melissa Li <li.melissa.kun@gmail.com>
Melissa [Wed, 21 Jul 2021 03:12:21 +0000 (23:12 -0400)]
mgr/cephadm: use _remote_connection (ssh.py), _execute_command, _check_execute_command in _run_cephadm
remove _get_connection from module.py and _remote_connection in serve.py, replacing with _remote_connection in ssh.py.
also, replace remoto.process.check with _execute_command and _check_execute_command in ssh.py
Fixes: https://tracker.ceph.com/issues/44676
Signed-off-by: Melissa Li <li.melissa.kun@gmail.com>
Melissa [Wed, 21 Jul 2021 02:43:38 +0000 (22:43 -0400)]
mgr/cephadm: remove remotes.py, replace old _write_remote_file in serve.py with write_remote_file in ssh.py
remove remotes.py because it is specific to execnet/remoto.
_write_remote_file in ssh.py now fulfills the function of write_file in remotes.py and the old _write_remote_file in serve.py
Fixes: https://tracker.ceph.com/issues/44676
Signed-off-by: Melissa Li <li.melissa.kun@gmail.com>
Melissa [Wed, 21 Jul 2021 01:50:33 +0000 (21:50 -0400)]
mgr/cephadm: remove _executable_path from module.py
Fixes: https://tracker.ceph.com/issues/44676
Signed-off-by: Melissa Li <li.melissa.kun@gmail.com>
Melissa [Tue, 20 Jul 2021 23:11:29 +0000 (19:11 -0400)]
mgr/cephadm: make synchronous wrapper functions of the async functions in ssh.py
Fixes: https://tracker.ceph.com/issues/44676
Signed-off-by: Melissa Li <li.melissa.kun@gmail.com>
Melissa [Tue, 20 Jul 2021 23:02:57 +0000 (19:02 -0400)]
mgr/cephadm: create thread to start event loop for ssh.py, and return results of the async functions with get_result
The EventLoopThread class starts a thread and an event loop which runs forever. Coroutines are scheduled on the event loop by the `get_result` method which uses `run_coroutine_threadsafe` to return a concurrent.futures.Future, and ultimately the result with .result()
Fixes: https://tracker.ceph.com/issues/44676
Signed-off-by: Melissa Li <li.melissa.kun@gmail.com>
Melissa [Tue, 20 Jul 2021 22:24:26 +0000 (18:24 -0400)]
mgr/cephadm: move _reconfig_ssh, _reset_con, and _reset_cons to ssh.py
Fixes: https://tracker.ceph.com/issues/44676
Signed-off-by: Melissa Li <li.melissa.kun@gmail.com>
Melissa [Tue, 20 Jul 2021 21:22:00 +0000 (17:22 -0400)]
mgr/cephadm: create async function _write_remote_file to write files on remote host
_write_remote_file uses _check_execute_command in ssh.py which calls _execute_command which uses shlex quote. Thus, any commands with an int will need to be transformed into a str because shlex quote does not take int objects
Fixes: https://tracker.ceph.com/issues/44676
Signed-off-by: Melissa Li <li.melissa.kun@gmail.com>
Melissa [Tue, 20 Jul 2021 21:02:40 +0000 (17:02 -0400)]
mgr/cephadm: execute commands run over ssh via asyncssh
_execute_command will run commands over ssh using the asyncssh `run` method: https://asyncssh.readthedocs.io/en/latest/api.html#asyncssh.SSHClientConnection.run
_check_execute_command will check the output of _execute_command and raise OrchestratorError if command fails on the remote host.
All commands run over ssh are prepended with sudo in `_execute_command` and shell-escaped with shlex quote.
If the cached ssh connection is closed or broken, the connection object will be removed from the cache, added to the `offline_hosts`, and an OrchestratorError will be raised. On the next call, the connection object will attempt to be recreated.
Exceptions involving asyncssh methods should be handled otherwise errors like TypeError: __init__() missing 1 required positional argument: 'reason' could occur due to the asyncssh error interacting with `raise_if_exception`
Fixes: https://tracker.ceph.com/issues/44676
Signed-off-by: Melissa Li <li.melissa.kun@gmail.com>
Melissa [Tue, 20 Jul 2021 19:56:32 +0000 (15:56 -0400)]
mgr/cephadm: create and cache asyncssh connection objects, and handle asyncssh connection errors
Create asyncssh connection object in async `_remote_connection` function and cache in `self.cons`
Create a handler for asyncssh log redirection and output ssh log if a connection error occurs
Disable asyncssh logger from propagating because the asyncssh info messages are verbose
Fixes: https://tracker.ceph.com/issues/44676
Signed-off-by: Melissa Li <li.melissa.kun@gmail.com>
Kefu Chai [Fri, 20 Aug 2021 14:38:03 +0000 (22:38 +0800)]
Merge pull request #42813 from wjwithagen/wjw-fix-hexdump-output
blk: start 1st line of hexdump() on a new line
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Daniel Gryniewicz [Fri, 20 Aug 2021 14:31:57 +0000 (10:31 -0400)]
Merge pull request #42856 from dang/wip-dang-zipper-manifest
RGW - Zipper - Remove RGWManifest from API
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Fri, 20 Aug 2021 14:21:37 +0000 (10:21 -0400)]
Merge pull request #41522 from Dreamyu20xx/wip-50967
rgw: Get the correct initial value(pos) in raw_obj_to_obj function when zoneid contains ‘_ ’character.
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
Casey Bodley [Fri, 20 Aug 2021 14:11:23 +0000 (10:11 -0400)]
Merge pull request #42723 from liewegas/fix-rgw-warning-2
rgw: default auth_client_required=cephx
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Fri, 20 Aug 2021 14:10:00 +0000 (10:10 -0400)]
Merge pull request #42803 from joke-lee/sts-memory-leak
rgw: fix sts memory leak
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Fri, 20 Aug 2021 14:08:45 +0000 (10:08 -0400)]
Merge pull request #42683 from cbodley/wip-52027
rgw: change order of xml elements in ListRoles response
Reviewed-by: Pritha Srivastava <prsrivas@redhat.com>
Casey Bodley [Fri, 20 Aug 2021 14:08:18 +0000 (10:08 -0400)]
Merge pull request #42740 from cbodley/wip-52128
cls/cmpomap: empty values are 0 in U64 comparisons
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
Joseph Sawaya [Thu, 19 Aug 2021 15:01:29 +0000 (11:01 -0400)]
.github/labeler: add rook label to PRs related to Rook
To make it easier to look for PRs directly related to the Rook orchestrator.
Signed-off-by: Joseph Sawaya <jsawaya@redhat.com>
Sebastian Wagner [Fri, 20 Aug 2021 10:12:45 +0000 (12:12 +0200)]
Merge pull request #42863 from sebastian-philipp/centos_8.2_container_tools_3.0.yaml
qa/distro: Add centos_8.2_container_tools_3.0.yaml
Reviewed-by: Patrick Seidensal <pseidensal@suse.com>
Sebastian Wagner [Fri, 20 Aug 2021 08:53:11 +0000 (10:53 +0200)]
qa/distro: Add centos_8.2_container_tools_3.0.yaml
Let's avoid latest kubic stable
Fixes: https://tracker.ceph.com/issues/52279
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
Deepika Upadhyay [Fri, 20 Aug 2021 06:30:49 +0000 (12:00 +0530)]
Merge pull request #42842 from ideepika/wip-werror-testing
run-make-check.sh: fix run-make-check.sh skipping cmake options
Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
Willem Jan Withagen [Tue, 17 Aug 2021 08:56:38 +0000 (10:56 +0200)]
blk: start 1st line of hexdump() on a new line
Otherwise the fist line looks rather strange
```
2021-08-19T23:42:33.604+0200
4f60700 40 bdev:kd:965(0x4fab180 /usr/local/src/wip.bluestore-test/build/dev/osd0/block.db) data:
00000000 56 f9 b8 f8 1c 00 01 01 1a 6c 65 76 65 6c 64 62 |V........leveldb|
00000010 2e 42 79 74 65 77 69 73 65 43 6f 6d 70 61 72 61 |.BytewiseCompara|
00000020 74 6f 72 98 af 58 a6 02 00 01 02 00 d2 c7 3c 95 |tor..X........<.|
00000030 06 00 01 09 00 03 04 04 00 6b 93 6d c5 2b 00 01 |.........k.m.+..|
00000040 01 1a 6c 65 76 65 6c 64 62 2e 42 79 74 65 77 69 |..leveldb.Bytewi|
.....
```
versus new:
```
2021-08-19T23:42:33.604+0200
4f60700 40 bdev:kd:965(0x4fab180 /usr/local/src/wip.bluestore-test/build/dev/osd0/block.db) data:
00000000 56 f9 b8 f8 1c 00 01 01 1a 6c 65 76 65 6c 64 62 |V........leveldb|
00000010 2e 42 79 74 65 77 69 73 65 43 6f 6d 70 61 72 61 |.BytewiseCompara|
00000020 74 6f 72 98 af 58 a6 02 00 01 02 00 d2 c7 3c 95 |tor..X........<.|
00000030 06 00 01 09 00 03 04 04 00 6b 93 6d c5 2b 00 01 |.........k.m.+..|
00000040 01 1a 6c 65 76 65 6c 64 62 2e 42 79 74 65 77 69 |..leveldb.Bytewi|
.....
```
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
Yuri Weinstein [Thu, 19 Aug 2021 19:45:01 +0000 (12:45 -0700)]
Merge pull request #42852 from sebastian-philipp/centos_8.3_container_tools_3.0.yaml
qa/cephadm: centos_8.3_container_tools_3.0.yaml
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Ali Maredia [Thu, 19 Aug 2021 19:07:16 +0000 (15:07 -0400)]
Merge pull request #41950 from zenomri/rgw-crypt-dpp
src/rgw : ldout and lderr calls were replaced by ldpp_dout calls
Reviewed-by: Ali Maredia <amaredia@redhat.com>
Daniel Gryniewicz [Tue, 17 Aug 2021 16:09:30 +0000 (12:09 -0400)]
RGW - Zipper - Remove StatOp
As part of removing RGWObjManifest from the Zipper API, we need to
remove StatOp. It's only used by orphan list, which is part of the
RadosStore.
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
Daniel Gryniewicz [Mon, 16 Aug 2021 18:39:25 +0000 (14:39 -0400)]
RGW - Zipper - Remove WriteOp
As part of removing RGWObjManifest from the Zipper API, we need to remove
WriteOp. Fortunately, with the multipart upload changes, it's no longer
needed outside the RadosStore.
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
Casey Bodley [Thu, 19 Aug 2021 16:31:03 +0000 (12:31 -0400)]
Merge pull request #42851 from dang/wip-dang-zipper-raw_obj
RGW - Zipper remove unused files
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Joseph Sawaya [Thu, 19 Aug 2021 15:14:33 +0000 (11:14 -0400)]
Merge pull request #42834 from josephsawaya/rook-orch-qa
qa/tasks/rook: add `ceph orch device ls` command to the rook qa task
Joseph Sawaya [Thu, 19 Aug 2021 15:14:07 +0000 (11:14 -0400)]
Merge pull request #42757 from josephsawaya/wip-mgr-rook-osd-creation
mgr/rook: Rook orchestrator OSD creation using `ceph orch apply osd`
Sebastian Wagner [Thu, 19 Aug 2021 14:30:32 +0000 (16:30 +0200)]
qa/cephadm: centos_8.3_container_tools_3.0.yaml
Let's avoid latest stable
Fixes: https://tracker.ceph.com/issues/52279
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
Daniel Gryniewicz [Thu, 19 Aug 2021 14:27:50 +0000 (10:27 -0400)]
RGW - Zipper remove unused files
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
Daniel Gryniewicz [Thu, 19 Aug 2021 14:19:27 +0000 (10:19 -0400)]
Merge pull request #42796 from dang/wip-dang-zipper-raw_obj
RGW - Remove last rgw_raw_obj from zipper
Reviewed-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Deepika Upadhyay [Thu, 19 Aug 2021 09:00:33 +0000 (14:30 +0530)]
run-make-check: fix do_cmake not consuming run-make-check opts
run-make-check.sh uses run-make.sh to `prepare`(install dependencies)
and `configure` cmake options, without quotes these options containing
special characters(hypens mostly) are skipped, hence we see not all
options supplied at cmake configure step.
Resolves(focused to solve issues in jenkins build env):
- missing cmake options:
cmake_opts+=" -DCMAKE_CXX_COMPILER=$cxx_compiler -DCMAKE_C_COMPILER=$c_compiler"
cmake_opts+=" -DCMAKE_CXX_FLAGS_DEBUG=\-Werror"
- Ninja not being used as cmake generator
Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
Alfonso Martínez [Thu, 19 Aug 2021 11:12:17 +0000 (13:12 +0200)]
Merge pull request #42793 from sebastian-philipp/dashboard-fix-standby-redirect
pybind/mgr: Fix IPv6 url generation
Kefu Chai [Thu, 19 Aug 2021 07:42:04 +0000 (15:42 +0800)]
Merge pull request #42302 from myoungwon/wip-51000
osd: fix to allow inc manifest leaked
Reviewed-by: Samuel Just <sjust@redhat.com>
Kefu Chai [Thu, 19 Aug 2021 07:40:54 +0000 (15:40 +0800)]
Merge pull request #42820 from ronen-fr/wip-ronenf-mgr-argvvec
common: create a faster & cleaner alternative to argv_to_vec()
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Thu, 19 Aug 2021 06:49:55 +0000 (14:49 +0800)]
Merge pull request #42823 from mgfritch/ceph-volume-py3-exec
cmake: s/Python_EXECUTABLE/Python3_EXECUTABLE/
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Thu, 19 Aug 2021 06:42:38 +0000 (14:42 +0800)]
Merge pull request #42799 from varshar16/wip-update-email-id
.githubmap: update mail address
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Kefu Chai [Thu, 19 Aug 2021 05:49:37 +0000 (13:49 +0800)]
Merge pull request #42835 from ceph/wip-ctest-fail
run-make-check.sh: Increase failure output log size
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Thu, 19 Aug 2021 02:15:43 +0000 (10:15 +0800)]
Merge pull request #42828 from tchaikov/wip-doc-dev-config
doc/dev/config: update to in sync with latest .yaml.in changes
Reviewed-by: Neha Ojha <nojha@redhat.com>
David Galloway [Wed, 18 Aug 2021 17:30:22 +0000 (13:30 -0400)]
run-make-check.sh: Increase failure output log size
Fixes: https://tracker.ceph.com/issues/43566
Signed-off-by: David Galloway <dgallowa@redhat.com>
Joseph Sawaya [Wed, 18 Aug 2021 13:41:40 +0000 (09:41 -0400)]
qa/tasks/rook: add device ls command to rook task
This commit adds the device ls command to the rook qa task
since that command should be working from now on.
Signed-off-by: Joseph Sawaya <jsawaya@redhat.com>
Daniel Gryniewicz [Tue, 10 Aug 2021 13:40:54 +0000 (09:40 -0400)]
RGW - Zipper - remove last rgw_raw_obj from API
Remove the remaining rgw_raw_obj from the API. This consists of:
- move get/delete raw_obj from Store to RadosStore; it's only needed by
RadosStore code
- Add a layout formatter to the API
- remove head_obj and get_manifest() from ReadOp
- Remove GCChain (no longer needed)
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
Daniel Gryniewicz [Tue, 10 Aug 2021 16:22:58 +0000 (12:22 -0400)]
Fix uninitialized warnings
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
Ronen Friedman [Wed, 18 Aug 2021 11:40:30 +0000 (14:40 +0300)]
Merge pull request #42827 from ronen-fr/wip-ronenf-std-fix2
key_value_store: fix missing std
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Wed, 18 Aug 2021 11:39:26 +0000 (19:39 +0800)]
Merge pull request #42825 from hualongfeng/fix_blk_pmem
blk/pmem: Add namespace std for map,string
Reviewed-by: Kefu Chai <kchai@redhat.com>
Sebastian Wagner [Tue, 17 Aug 2021 10:41:31 +0000 (12:41 +0200)]
mgr/cephadm: fix generation of wrong IPv6 urls
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
Sebastian Wagner [Tue, 17 Aug 2021 10:30:36 +0000 (12:30 +0200)]
mgr/restful: Fix url generation for IPv6 hosts
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
Sebastian Wagner [Tue, 17 Aug 2021 10:29:58 +0000 (12:29 +0200)]
mgr/prometheus: Fix url generation for IPv6 hosts
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
Sebastian Wagner [Mon, 16 Aug 2021 12:15:23 +0000 (14:15 +0200)]
mgr/dashboard: Fix redirect to active MGR
Fixes: https://tracker.ceph.com/issues/52117
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
Sebastian Wagner [Tue, 17 Aug 2021 10:06:12 +0000 (12:06 +0200)]
pybind/mgr: move build_url from dashboard to mgr_util
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
Sebastian Wagner [Wed, 18 Aug 2021 10:00:33 +0000 (12:00 +0200)]
Merge pull request #42690 from adk3798/offline2
mgr/cephadm: make scheduler able to accomodate offline/maintenance hosts
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
Reviewed-by: Cory Snyder <csnyder@iland.com>
Kefu Chai [Wed, 18 Aug 2021 09:33:26 +0000 (17:33 +0800)]
doc/dev/config: update to in sync with latest .yaml.in changes
we migrated to a build process which translate the options from .yaml.in
files. so update the document to reflect this change.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Sebastian Wagner [Wed, 18 Aug 2021 09:52:09 +0000 (11:52 +0200)]
Merge pull request #42592 from vfreex/cephadm-better-port-stripping
cephadm: better port stripping
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
Sebastian Wagner [Wed, 18 Aug 2021 09:51:17 +0000 (11:51 +0200)]
Merge pull request #42590 from vfreex/cephadm-propagate-env-vars
cephadm: propagate environment variables to subprocesses
Sebastian Wagner [Wed, 18 Aug 2021 09:48:18 +0000 (11:48 +0200)]
Merge pull request #42589 from vfreex/fix-cephadm-ipv6
cephadm: Fix bootstrap error with IPv6 mon-ip
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
Sebastian Wagner [Wed, 18 Aug 2021 09:41:22 +0000 (11:41 +0200)]
Merge pull request #42816 from sebastian-philipp/cephadm-upgrade-status-message
mgr/cephadm/upgrade: Upgrade status: We also upgrade non-ceph daemons
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Dimitri Savineau <dsavinea@redhat.com>
Ronen Friedman [Wed, 18 Aug 2021 08:25:49 +0000 (08:25 +0000)]
key_value_store: fix missing std
following the removal of 'using std' in PR #42742, and missed
in PR #42790.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Ilya Dryomov [Wed, 18 Aug 2021 08:08:50 +0000 (10:08 +0200)]
Merge pull request #41968 from CongMinYin/fix-ssd-bug
librbd/cache/pwl/ssd: fix m_bytes_allocated exceeding m_bytes_allocated_cap
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Alfonso Martínez [Wed, 18 Aug 2021 06:32:49 +0000 (08:32 +0200)]
Merge pull request #42768 from s0nea/wip-dashboard-suppressed-alerts
mgr/dashboard: don't notify for suppressed alerts
Feng Hualong [Wed, 18 Aug 2021 05:52:50 +0000 (13:52 +0800)]
blk/pmem: Add namespace std for map,string
Due to not use namespace std for map,string, it leads to
`map,string` not be declared.
Signed-off-by: Feng Hualong <hualong.feng@intel.com>
Kefu Chai [Wed, 18 Aug 2021 05:44:50 +0000 (13:44 +0800)]
Merge pull request #42758 from liewegas/gh-template
.github/pull_request_template: fix dashboard e2e test command
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Wed, 18 Aug 2021 03:46:45 +0000 (11:46 +0800)]
Merge pull request #42801 from ivancich/wip-update-rados-rm-help
doc: clarify use of `rados rm` command
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Kefu Chai [Wed, 18 Aug 2021 03:36:02 +0000 (11:36 +0800)]
Merge pull request #42822 from tchaikov/wip-drop-gdbm
ceph.spec.in: drop gdbm from build deps
Reviewed-by: Ken Dreyer <kdreyer@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Michael Fritch [Tue, 17 Aug 2021 21:37:13 +0000 (15:37 -0600)]
tools/setup-virtualenv: verify the `--python` param
when given an invalid or empty (PYTHON_BINARY)
fixup for
494fea50ced7
Fixes: https://tracker.ceph.com/issues/52304
Signed-off-by: Michael Fritch <mfritch@suse.com>
Michael Fritch [Tue, 17 Aug 2021 21:36:50 +0000 (15:36 -0600)]
cmake: s/Python_EXECUTABLE/Python3_EXECUTABLE/
pass the python3 exec when creating the ceph-volume build venv
fixup for
5fc657b40dc7
Fixes: https://tracker.ceph.com/issues/52304
Signed-off-by: Michael Fritch <mfritch@suse.com>
Joseph Sawaya [Tue, 17 Aug 2021 19:37:58 +0000 (15:37 -0400)]
mgr/rook: make use of SizeMatcher in Creator classes
This commit uses the SizeMatcher Class in the Creator functions
to parse and filter devices according to the size specified in a
drive_group.
Signed-off-by: Joseph Sawaya <jsawaya@redhat.com>
Ronen Friedman [Tue, 17 Aug 2021 05:11:15 +0000 (05:11 +0000)]
common: create a faster & cleaner alternative to argv_to_vec()
New function signature follows current C++ guidance regarding
returning values from functions. It is also faster
- 1.3X for a sample test of 10 arguments.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Co-authored-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Tue, 17 Aug 2021 17:04:39 +0000 (01:04 +0800)]
ceph.spec.in: drop gdbm from build deps
neither gdbm nor libgdbm is used when building ceph, so let's drop it.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Joseph Sawaya [Wed, 11 Aug 2021 15:01:25 +0000 (11:01 -0400)]
mgr/rook: fix convert_size method in DefaultFetcher
This commit fixes the convert_size method by getting it
to use the re python module to split the digits and letters
to support all units a PV could be expressed in.
Signed-off-by: Joseph Sawaya <jsawaya@redhat.com>
Joseph Sawaya [Thu, 22 Jul 2021 19:42:13 +0000 (15:42 -0400)]
mgr/rook: create get_storage_class method on RookCluster
this commit creates the get_storage_class method on the RookCluster
class used to get the storage class matching the name provided
in the ceph config.
Signed-off-by: Joseph Sawaya <jsawaya@redhat.com>
Joseph Sawaya [Mon, 19 Jul 2021 17:08:57 +0000 (13:08 -0400)]
mgr/rook: apply_drivegroups fix and coding style fixes
This commit fixes the apply_drivegroups method in RookOrchestrator
to process the entire list of drive groups passed.
This commit also fixes some coding style errors in RookCluster.
Signed-off-by: Joseph Sawaya <jsawaya@redhat.com>
Joseph Sawaya [Mon, 19 Jul 2021 13:50:39 +0000 (09:50 -0400)]
mgr/rook: keep drive groups updated and clean up cluster CR
This commit creates a new threaded methods on the RookCluster class
that keeps the cluster updated by re-applying drive groups in a
loop.
Signed-off-by: Joseph Sawaya <jsawaya@redhat.com>
Joseph Sawaya [Mon, 19 Jul 2021 13:37:58 +0000 (09:37 -0400)]
mgr/rook: OSD creation using Creator classes
This commit implements the apply_drivegroups method in the
RookOrchestrator class and creates the DefaultCreator and
LSOCreator classes that handle creating OSDs. The add_osds
method in RookCluster will use each creator based on what
storage class the user provided in the ceph config.
Signed-off-by: Joseph Sawaya <jsawaya@redhat.com>
Joseph Sawaya [Mon, 19 Jul 2021 13:26:03 +0000 (09:26 -0400)]
mgr/rook: add supplemental information to device object in LSOFetcher
This commit adds the PV name, node name, vendor and model to the Device object
created in the LSOFetcher device method, this information is useful for adding
OSDs.
Signed-off-by: Joseph Sawaya <jsawaya@redhat.com>
Sebastian Wagner [Tue, 17 Aug 2021 14:37:15 +0000 (16:37 +0200)]
Merge pull request #42738 from sebastian-philipp/mypy-3.7
pybind/mgr: tox: also test mypy with python 3.7
Reviewed-by: Kefu Chai <kchai@redhat.com>
myoungwon oh [Tue, 17 Aug 2021 12:51:29 +0000 (21:51 +0900)]
test: allowing >= the real refcount to avoid false alarm
Current dedup allow to contain multiple same sources using
multiset, which results in inconsistent situation as follow
(during set_chunk, but not confined in set_chunk).
1. User issues set_chunk
2. OSD receives the set_chunk, and sends increment message
to an object in the low tier (INPROGRESS).
3. OSD map is changed (841 → 843)
3.5. on_change() is called
4. the set_chunk op is reenqueued by requeue_op()
5. OSD handles the duplicated set_chunk, but it is not able to
know the set_chunk is duplicated because it does not log on the disk yet.
6. OSD issues increment message again to the object
in the low tier. (increment operation is executed twice)
To fix this, this commit allows >= the real refcount in test cases
fixes: https://tracker.ceph.com/issues/51000
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
Kefu Chai [Tue, 17 Aug 2021 12:40:47 +0000 (20:40 +0800)]
Merge pull request #42811 from tchaikov/wip-dashboard-test
mgr/dashboard/api: set a UTF-8 locale when running pip
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Alfonso Martínez [Tue, 17 Aug 2021 12:35:24 +0000 (14:35 +0200)]
Merge pull request #42732 from rhcs-dashboard/bug-
1950644
mgr/dashboard: disable create snapshot with subvolumes
Alfonso Martínez [Tue, 17 Aug 2021 12:32:49 +0000 (14:32 +0200)]
Merge pull request #42717 from rhcs-dashboard/iscsi-target-refresh-btn
mgr/dashboard: Refresh button on the iscsi targets page