]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Casey Bodley [Tue, 25 Apr 2023 14:06:46 +0000 (10:06 -0400)]
Merge pull request #51028 from cbodley/wip-59220
reef: qa/rgw: unpin centos for verify suite
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Guillaume Abrioux [Tue, 25 Apr 2023 08:05:09 +0000 (10:05 +0200)]
Merge pull request #50880 from guits/wip-59310-reef
reef: ceph-volume: fix issue with fast device allocs when there are multiple PVs per VG
Anthony D'Atri [Sun, 23 Apr 2023 21:19:18 +0000 (23:19 +0200)]
Merge pull request #51181 from zdover23/wip-doc-2023-04-23-backport-51177-to-reef
reef: doc/start: edit first 150 lines of documenting-ceph
Anthony D'Atri [Sun, 23 Apr 2023 21:15:41 +0000 (23:15 +0200)]
Merge pull request #51184 from zdover23/wip-doc-2023-04-23-backport-51178-to-reef
reef: doc/glossary: add "Placement Groups" definition
Zac Dover [Sat, 22 Apr 2023 08:55:38 +0000 (10:55 +0200)]
doc/glossary: add "Placement Groups" definition
Add a definition of "Placement Groups" to the Glossary.
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
9f37ea651f9ee2c51e0705b9b58ed356f1bc56e6 )
Zac Dover [Sat, 22 Apr 2023 07:03:12 +0000 (09:03 +0200)]
doc/start: edit first 50 lines of documenting-ceph
Edit the first 150 lines of doc/start/documenting-ceph.rst. This is part
of an initiative to harvest the fruits of Cephalocon 2023, at which
documentation proved to be in demand to a surprising degree.
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
dd37f94aa4f1de947b1eaf5d82cc529925f5823e )
Nizamudeen A [Thu, 20 Apr 2023 17:39:25 +0000 (23:09 +0530)]
Merge pull request #51151 from rhcs-dashboard/wip-59468-reef
reef: mgr/dashboard: skip Create OSDs step in Cluster expansion
Reviewed-by: Pegonzal <NOT@FOUND>
Nizamudeen A [Fri, 14 Apr 2023 19:33:11 +0000 (01:03 +0530)]
mgr/dashboard: skip Create OSDs step in Cluster expansion
Its to ensure OSDs are not deployed on all hosts because that would make
the host draining impossible
Fixes: https://tracker.ceph.com/issues/59457
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit
0f6d23a7aa024495a79cdedc80f7a00902115b6b )
zdover23 [Tue, 18 Apr 2023 14:07:39 +0000 (16:07 +0200)]
Merge pull request #51125 from zdover23/wip-doc-2023-04-17-backport-50639-to-reef
reef: doc: account for PG autoscaling being the default
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Nizamudeen A [Tue, 18 Apr 2023 13:32:03 +0000 (19:02 +0530)]
Merge pull request #51121 from rhcs-dashboard/wip-59465-reef
reef: mgr/dashboard: remove unncessary hyperlink in landing page
Reviewed-by: Pegonzal <NOT@FOUND>
zdover23 [Tue, 18 Apr 2023 09:48:34 +0000 (11:48 +0200)]
Merge pull request #51123 from zdover23/wip-doc-2023-04-17-backport-49762-to-reef
reef: vstart: fix text format
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Conrad Hoffmann [Wed, 22 Mar 2023 22:03:57 +0000 (23:03 +0100)]
doc: account for PG autoscaling being the default
The current documentation tries really hard to convince people to set
both `osd_pool_default_pg_num` and `osd_pool_default_pgp_num` in their
configs, but at least the latter has undesirable side effects on any
Ceph version that has PG autoscaling enabled by default (at least quincy
and beyond).
Assume a cluster with defaults of `64` for `pg_num` and `pgp_num`.
Starting `radosgw` will fail as it tries to create various pools without
providing values for `pg_num` or `pgp_num`. This triggers the following
in `OSDMonitor::prepare_new_pool()`:
- `pg_num` is set to `1`, because autoscaling is enabled
- `pgp_num` is set to `osd pool default pgp_num`, which we set to `64`
- This is an invalid setup, so the pool creation fails
Likewise, `ceph osd pool create mypool` (without providing values for
`pg_num` or `pgp_num`) does not work.
Following this rationale:
- Not providing a default value for `pgp_num` will always do the right
thing, unless you use advanced features, in which case you can be
expected to set both values on pool creation
- Setting `osd_pool_default_pgp_num` in your config breaks pool creation
for various cases
This commit:
- Removes `osd_pool_default_pgp_num` from all example configs
- Adds mentions of the autoscaling and how it interacts with the default
values in various places
For each file that was touched, the following maintenance was also
performed:
- Change interternal spaces to underscores for config values
- Remove mentions of filestore or any of its settings
- Fix minor inconsistencies, like indentation etc.
There is also a ticket which I think is very relevant and fixed by this,
though it only captures part of the broader issue addressed here:
Fixes: https://tracker.ceph.com/issues/47176
Signed-off-by: Conrad Hoffmann <ch@bitfehler.net>
(cherry picked from commit
402d2eacbc67f7a6d47d8f90d9ed757fc20931a6 )
Rongqi Sun [Tue, 17 Jan 2023 05:55:01 +0000 (13:55 +0800)]
vstart: fix text format
Signed-off-by: Rongqi Sun <sunrongqi@huawei.com>
(cherry picked from commit
57dc8ce51602543d42a2f82cb829eda1c231b434 )
Nizamudeen A [Mon, 17 Apr 2023 09:38:06 +0000 (15:08 +0530)]
mgr/dashboard: remove unncessary hyperlink in landing page
Fixes: https://tracker.ceph.com/issues/59462
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit
7e7da955445ecf37bc43fc296298bd91d0d8a140 )
Nizamudeen A [Mon, 17 Apr 2023 13:38:33 +0000 (19:08 +0530)]
Merge pull request #51080 from rhcs-dashboard/wip-59452-reef
reef: mgr/dashboard: fix cephadm e2e expression changed error
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
colemitchell [Mon, 17 Apr 2023 10:43:33 +0000 (12:43 +0200)]
Merge pull request #51116 from zdover23/wip-doc-2023-04-17-backport-51114-to-reef
reef: doc/radosgw: format part of s3select
Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
Cole Mitchell [Mon, 17 Apr 2023 09:34:49 +0000 (05:34 -0400)]
doc/radosgw: format part of s3select
Partially format the 'Basic Workflow' section's introduction and 'Basic Functionalities' subsection in s3select. Nothing else is being fixed.
Signed-off-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
(cherry picked from commit
13cf134c0610509da52aa68e11e26f0740002bde )
Anthony D'Atri [Sun, 16 Apr 2023 20:25:39 +0000 (22:25 +0200)]
Merge pull request #51110 from zdover23/wip-doc-2023-04-16-backport-50941-to-reef
reef: doc/foundation: Update Foundation members for April 2023
zdover23 [Sun, 16 Apr 2023 16:24:30 +0000 (18:24 +0200)]
Merge pull request #51107 from zdover23/wip-doc-2023-04-16-backport-51099-to-reef
reef: doc/dev: format command in cephfs-mirroring
Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
zdover23 [Sun, 16 Apr 2023 16:22:40 +0000 (18:22 +0200)]
Merge pull request #51096 from zdover23/wip-doc-2023-04-16-backport-51062-to-reef
reef: doc/glossary: add "Hybrid Storage"
Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
zdover23 [Sun, 16 Apr 2023 16:18:43 +0000 (18:18 +0200)]
Merge pull request #51092 from zdover23/wip-doc-2023-04-16-backport-51091-to-reef
reef: doc/mgr/prometheus: fix confval reference
Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
Mike Perez [Fri, 7 Apr 2023 21:00:36 +0000 (14:00 -0700)]
doc/foundation: Update Foundation members for April 2023
Signed-off-by: Mike Perez <thingee@gmail.com>
(cherry picked from commit
759f26a99f7a1b52954e12e080304b867af81418 )
Zac Dover [Sun, 16 Apr 2023 09:11:27 +0000 (11:11 +0200)]
doc/dev: format command in cephfs-mirroring
Correctly format a command in doc/dev/cephfs-mirroring/#creating-users.
Reported by casanlin@init7.net at
https://pad.ceph.com/p/Report_Documentation_Bugs
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
408219bfca6b1e698229967e76d22d10028b7c20 )
colemitchell [Sun, 16 Apr 2023 14:43:15 +0000 (10:43 -0400)]
Merge pull request #51104 from zdover23/wip-doc-2023-04-16-backport-51103-to-reef
reef: doc/radosgw: format part of s3select
Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
Cole Mitchell [Sun, 16 Apr 2023 13:13:56 +0000 (09:13 -0400)]
doc/radosgw: format part of s3select
Format the first section of s3select. Nothing else is being fixed.
Signed-off-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
(cherry picked from commit
a6a84471a7af154e7ccc93f51df2fc9744dc606c )
Zac Dover [Thu, 13 Apr 2023 12:01:44 +0000 (14:01 +0200)]
doc/glossary: add "Hybrid Storage"
Add "Hybrid Storage" to the glossary.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
dc8148d0727b307fb3baa30baf9dfee9bf8a247e )
Piotr Parczewski [Sat, 15 Apr 2023 21:16:35 +0000 (23:16 +0200)]
doc/mgr/prometheus: fix confval reference
Signed-off-by: Piotr Parczewski <piotr@stackhpc.com>
(cherry picked from commit
b9b75dafe248e07b21f2958023697397094cc537 )
Anthony D'Atri [Sat, 15 Apr 2023 09:46:55 +0000 (11:46 +0200)]
Merge pull request #51087 from zdover23/wip-doc-2023-04-15-backport-51086-to-reef
reef: doc/rados/ops: remove ceph-medic from monitoring
Zac Dover [Sat, 15 Apr 2023 07:42:31 +0000 (09:42 +0200)]
doc/rados/ops: remove ceph-medic from monitoring
Remove mention of ceph-medic from doc/rados/operations/monitoring.rst,
because it is no longer supported.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
42cd28a2a639e68a44838ae4e7f875cb6bd5d97b )
Nizamudeen A [Fri, 14 Apr 2023 06:03:16 +0000 (11:33 +0530)]
mgr/dashboard: fix cephadm e2e expression changed error
tried to fix this issue from the daemon component sometime ago several
times but it didn't work. So force ignoring the error
Fixes: https://tracker.ceph.com/issues/59444
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit
f7e29e5ab85fabcf2524656bb456a2955fa8608d )
Nizamudeen A [Fri, 14 Apr 2023 08:24:57 +0000 (13:54 +0530)]
Merge pull request #51010 from rhcs-dashboard/wip-59420-reef
reef: mgr/dashboard: fix eviction of all FS clients
Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Anthony D'Atri [Thu, 13 Apr 2023 12:32:26 +0000 (08:32 -0400)]
Merge pull request #51063 from zdover23/wip-doc-2023-04-13-backport-50713-to-reef
reef: doc/glossary: improve "CephX" entry
Zac Dover [Tue, 28 Mar 2023 08:42:11 +0000 (18:42 +1000)]
doc/glossary: improve "CephX" entry
Improve the glossary entry for "CephX".
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
02e3a5cb763987eeaee2dd1a7543d2762aaad7fe )
Ilya Dryomov [Thu, 13 Apr 2023 12:03:55 +0000 (14:03 +0200)]
Merge pull request #50919 from idryomov/wip-rbd-reef-backports-1
reef: RBD backports (batch 1)
Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Christopher Hoffman <choffman@redhat.com>
Nizamudeen A [Thu, 13 Apr 2023 10:10:20 +0000 (15:40 +0530)]
Merge pull request #51058 from rhcs-dashboard/wip-59436-reef
reef: mgr/dashboard: rbd-mirror force promotion
Reviewed-by: Nizamudeen A <nia@redhat.com>
Ilya Dryomov [Tue, 11 Apr 2023 20:43:58 +0000 (22:43 +0200)]
qa/suites/rbd: install qemu-utils in addition to qemu-block-extra on Ubuntu
qemu-utils is usually pre-installed but, due to what appears to be
a Ubuntu packaging bug, it's not upgraded when qemu-block-extra is
installed:
The following NEW packages will be installed:
qemu-block-extra
The following packages will be upgraded:
qemu-system-common qemu-system-data qemu-system-gui qemu-system-x86
However, the version of the block driver must match exactly the version
of the qemu-img tool, so the above leads to:
$ qemu-img convert -f qcow2 -O raw /home/ubuntu/cephtest/qemu/base.client.0.0.qcow2 rbd:rbd/client.0.0
Failed to initialize module: /usr/lib/x86_64-linux-gnu/qemu/block-rbd.so
Note: only modules from the same build can be loaded.
qemu: module block-block-rbd not found, do you want to install qemu-block-extra package?
qemu-img: Unknown protocol 'rbd'
Fixes: https://tracker.ceph.com/issues/59431
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit
c529fdd63a5aae2c598078df05fe9bbef40042dc )
Pedro Gonzalez Gomez [Wed, 5 Apr 2023 15:42:52 +0000 (17:42 +0200)]
mgr/dashboard: rbd-mirror force promotion
resolves: https://tracker.ceph.com/issues/59327
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
(cherry picked from commit
9696b6a04830297c23c4cccd6e7c225f183ba0b2 )
zdover23 [Wed, 12 Apr 2023 09:41:54 +0000 (19:41 +1000)]
Merge pull request #51035 from zdover23/wip-doc-2023-04-12-backport-50993-to-reef
reef: doc/rados/operations: edit monitoring.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Guillaume Abrioux [Wed, 12 Apr 2023 07:58:53 +0000 (09:58 +0200)]
Merge pull request #50994 from guits/cv-bkp-50473-reef
ceph-volume: update the OS before deploying Ceph (reef)
Zac Dover [Tue, 11 Apr 2023 04:15:47 +0000 (14:15 +1000)]
doc/rados/operations: edit monitoring.rst
Line-edit the final third of doc/rados/operations/monitoring.rst.
Follows https://github.com/ceph/ceph/pull/50834.
https://tracker.ceph.com/issues/58485
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
b9ccad80608953fc0af779e8cad93971d47649b6 )
Nizamudeen A [Tue, 11 Apr 2023 16:11:42 +0000 (21:41 +0530)]
Merge pull request #51006 from rhcs-dashboard/wip-59402-reef
reef: mgr/dashboard: fix create osd default selected as recommended not working
Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Casey Bodley [Wed, 22 Mar 2023 17:57:57 +0000 (13:57 -0400)]
qa/rgw: unpin centos for verify suite
use a random supported distro instead of centos
Fixes: https://tracker.ceph.com/issues/54102
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit
4bc1f376b901f809748b751d45899e512738c934 )
Pere Diaz Bou [Wed, 5 Apr 2023 16:54:45 +0000 (18:54 +0200)]
mgr/dashboard: fix eviction of all FS clients
Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com>
(cherry picked from commit
780f49325aefd0b2c537462c6bb498232621ee8a )
Guillaume Abrioux [Tue, 11 Apr 2023 11:29:15 +0000 (13:29 +0200)]
ceph-volume/tests: fix an issue with rpm
Typical error seen in the CI:
```
error: /var/cache/dnf/baseos-
00fe51d07def85f0 /packages/kernel-core-4.18.0-483.el8.x86_64.rpm: signature hdr data: BAD, no. of bytes(459772) out of range
```
Upgrading `rpm` fixes this issue.
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit
05aa334b96ed8a8c8497047bc26da64ee3a3d1fa )
Nizamudeen A [Thu, 6 Apr 2023 06:37:20 +0000 (12:07 +0530)]
mgr/dashboard: fix create osds step failing on the default option
the backend was reporting with a keyError which doesn't find the
`encrypted` key.
Fixes: https://tracker.ceph.com/issues/59319
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit
ca8b107cf2198ecf189b513ff75b9d5a9d9782b9 )
Nizamudeen A [Wed, 5 Apr 2023 06:37:11 +0000 (12:07 +0530)]
mgr/dashboard: add option to skip the create OSDs step
Fixes: https://tracker.ceph.com/issues/59319
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit
caa0c456b1d0c33f6abb847b3c9259501d587004 )
Guillaume Abrioux [Fri, 10 Mar 2023 15:44:16 +0000 (16:44 +0100)]
ceph-volume: add bluefs_buffered_io: false in functional tests
This is a workaround to make dmcrypt scenarios pass the CI.
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit
491e88ede56b51bc425ba5e38adf6eb74ad5196e )
Guillaume Abrioux [Fri, 10 Mar 2023 15:01:19 +0000 (16:01 +0100)]
ceph-volume: update the OS before deploying Ceph
ceph-volume tests are failing, OSDs never get up and running.
For some reason, updating the OS early in the testing workflow
addresses that issue in the CI.
-- to be continued ... --
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit
663c914c59873f433a5512aca0ebc4b4a7ef1fd3 )
colemitchell [Tue, 11 Apr 2023 01:04:56 +0000 (21:04 -0400)]
Merge pull request #50955 from zdover23/wip-doc-2023-04-09-backport-50827-to-reef
reef: doc/rados/ops: edit health-checks.rst (4 of x)
Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
Anthony D'Atri [Mon, 10 Apr 2023 11:48:40 +0000 (07:48 -0400)]
Merge pull request #50966 from zdover23/wip-doc-2023-04-10-backport-50828-to-reef
reef: doc/rados/ops: edit health checks.rst (5 of x)
Anthony D'Atri [Mon, 10 Apr 2023 11:46:50 +0000 (07:46 -0400)]
Merge pull request #50969 from zdover23/wip-doc-2023-04-10-backport-50829-to-reef
reef: doc/rados/ops: edit health-checks.rst (6 of x)
Zac Dover [Sat, 1 Apr 2023 20:39:32 +0000 (06:39 +1000)]
doc/rados/ops: edit health-checks.rst (6 of x)
Edit docs/rados/operations/health-checks.rst (6 of x).
Follows https://github.com/ceph/ceph/pull/50828.
https://tracker.ceph.com/issues/58485
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
c59bc152ea746a8bfc5795dbeb68b2ef6e511b1f )
Zac Dover [Sat, 1 Apr 2023 20:33:45 +0000 (06:33 +1000)]
doc/rados/ops: edit health checks.rst (5 of x)
Edit docs/rados/operations/health-checks.rst (5 of x).
Follows https://github.com/ceph/ceph/pull/50827
https://tracker.ceph.com/issues/58485
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
cb8ec5b5ab8f5fb25c8f2c6404447dabe4ebd1ad )
Anthony D'Atri [Sun, 9 Apr 2023 19:08:46 +0000 (15:08 -0400)]
Merge pull request #50959 from zdover23/wip-doc-2023-04-09-backport-50958-to-reef
reef: doc/rados/ops: add hyphen to mon-osd-pg.rst
Zac Dover [Sun, 9 Apr 2023 02:42:11 +0000 (12:42 +1000)]
doc/rados/ops: add hyphen to mon-osd-pg.rst
Remove confusing parentheses and add a clearer (as compared to the
parentheses) hyphen (actually an em-dash, or at least it is intended
to be an em-dash) to doc/rados/operations/monitoring-osd-pg.rst
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
0c965c18d0e6ab1461b5fad42d481f25e4207940 )
zdover23 [Sun, 9 Apr 2023 05:03:40 +0000 (15:03 +1000)]
Merge pull request #50952 from zdover23/wip-doc-2023-04-09-backport-50826-to-reef
reef: doc/rados/ops: edit health-checks.rst (3 of x)
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
zdover23 [Sun, 9 Apr 2023 05:03:09 +0000 (15:03 +1000)]
Merge pull request #50949 from zdover23/wip-doc-2023-04-09-backport-50907-to-reef
reef: doc/rados/config: edit auth-config-ref
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Sat, 1 Apr 2023 20:25:42 +0000 (06:25 +1000)]
doc/rados/ops: edit health-checks.rst (4 of x)
Edit docs/rados/operations/health-checks.rst (4 of x).
Follows https://github.com/ceph/ceph/pull/50826.
https://tracker.ceph.com/issues/58485
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
31df75356f2e49e0da6e0f4a6ec498e3609bd39e )
Zac Dover [Sat, 1 Apr 2023 20:17:06 +0000 (06:17 +1000)]
doc/rados/ops: edit health-checks.rst (3 of x)
Edit docs/rados/operations/health-checks.rst (3 of x).
Follows https://github.com/ceph/ceph/pull/50825
https://tracker.ceph.com/issues/58485
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
e02ddb24e583b5bedd4056ba0871a9427b581bfe )
Zac Dover [Thu, 6 Apr 2023 00:21:01 +0000 (10:21 +1000)]
doc/rados/config: edit auth-config-ref
Line edit doc/rados/config/auth-config-ref.rst.
https://tracker.ceph.com/issues/58485
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
3d0acf9372a35ef48be47efe68192ec389c17ccb )
zdover23 [Sat, 8 Apr 2023 04:53:55 +0000 (14:53 +1000)]
Merge pull request #50945 from zdover23/wip-doc-2023-04-08-backport-50863-to-reef
reef: doc/rados/ops: edit monitoring-osd-pg.rst (2 of x)
Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
zdover23 [Sat, 8 Apr 2023 04:13:30 +0000 (14:13 +1000)]
Merge pull request #50942 from zdover23/wip-doc-2023-04-08-backport-50795-to-reef
reef: doc/rados: line-edit common.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Wed, 5 Apr 2023 03:32:43 +0000 (13:32 +1000)]
doc/rados/ops: edit monitoring-osd-pg.rst (2 of x)
Line-edit monitoring-osd-pg.rst (2 of x).
https://tracker.ceph.com/issues/58485
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
270e2fd730dad19d970d73ea19c6872defa9fce4 )
Zac Dover [Thu, 30 Mar 2023 22:54:05 +0000 (08:54 +1000)]
doc/rados: line-edit common.rst
Edit syntax and semantics in doc/configuration/common.rst.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
6c9f226742e951de6c40627271ba6d6cabba4535 )
Anthony D'Atri [Fri, 7 Apr 2023 11:25:37 +0000 (07:25 -0400)]
Merge pull request #50933 from zdover23/wip-doc-2023-04-07-backport-50928-to-reef
reef: doc/rados/ops: line-edit operating.rst
Zac Dover [Fri, 7 Apr 2023 00:46:50 +0000 (10:46 +1000)]
doc/rados/ops: line-edit operating.rst
Line-edit doc/rados/operations/operating.rst.
https://tracker.ceph.com/issues/58485
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
bb8fc0068369369fd213062590738e38c9f4dc63 )
zdover23 [Fri, 7 Apr 2023 02:10:11 +0000 (12:10 +1000)]
Merge pull request #50848 from zdover23/wip-doc-2023-04-04-backport-50834-to-reef
reef: doc/rados: edit ops/monitoring.rst (2 of 3)
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Sun, 2 Apr 2023 22:03:29 +0000 (08:03 +1000)]
doc/rados: edit ops/monitoring.rst (2 of 3)
Line-edit the second third of doc/rados/operations/monitoring.rst.
Follows https://github.com/ceph/ceph/pull/50670.
https://tracker.ceph.com/issues/58485
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
41684ebd33b5c9fe707f5a33b27c55ed29cd5ede )
Anthony D'Atri [Thu, 6 Apr 2023 16:05:17 +0000 (12:05 -0400)]
Merge pull request #50911 from zdover23/wip-doc-2023-04-06-backport-50825-to-reef
reef: doc/rados/ops: edit health-checks.rst (2 of x)
Ilya Dryomov [Tue, 28 Mar 2023 18:03:05 +0000 (20:03 +0200)]
librbd: avoid generating ESHUTDOWN in ManagedLock
EBLOCKLISTED has a very special meaning but happens to be an alias for
ESHUTDOWN. If the client gets blocklisted, we always want to propagate
EBLOCKLISTED error code since it's generated by the OSD.
For ManagedLock use case of indicating that an operation on the lock
raced with lock shut down, meaning that a higher level request can just
be restarted, ERESTART should do.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit
76856d90e0e0d73276c06a724091197301f982e9 )
Ilya Dryomov [Tue, 28 Mar 2023 17:52:42 +0000 (19:52 +0200)]
librbd: fix recursive locking on owner_lock in ImageDispatch
needs_exclusive_lock() calls acquire_lock() with owner_lock held.
If lock acquisiton races with lock shut down, ManagedLock completes
ImageDispatch context directly and dispatch is retried immediately on
the same thread (due to DISPATCH_RESULT_RESTART). This results in
recursion into needs_exclusive_lock() and, barring locking issues, can
lead to unbounded stack growth if lock shut down takes its time.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit
1d943f8c47b3510e47d40701e9acd213706754e5 )
Ilya Dryomov [Tue, 4 Apr 2023 15:21:16 +0000 (17:21 +0200)]
test/librados_test_stub: drop watches only after actually blocklisting
Eliminate a race where a client is able to submit an operation after
WatchCtx2::handle_error() is invoked on its watch due to blocklisting.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit
a14498eff645e9e154e4d1a3cc436453b8401d89 )
Ilya Dryomov [Thu, 30 Mar 2023 16:22:24 +0000 (18:22 +0200)]
test/librados_test_stub: raise a watch error on blocklisting
Simulate getting MWatchNotify CEPH_WATCH_EVENT_DISCONNECT message after
the client is blocklisted.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit
0dfe87d3b6ed52cee6f6660b42af42a8dd7708bb )
Christopher Hoffman [Tue, 21 Mar 2023 16:15:04 +0000 (16:15 +0000)]
librbd: Propagate EBLOCKLIST in send_acquire_lock
During send_acquire_lock, there's a case where
there's no watcher handle present and lock request is delayed.
If the client is blocklisted, the delayed request will not
continue and the call that requested lock will never complete.
The lock process will now propagate -EBLOCKLIST, to callback
instead of indefinitely delaying.
Fixes: https://tracker.ceph.com/issues/59115
Signed-off-by: Christopher Hoffman <choffman@redhat.com>
(cherry picked from commit
6a0aeadc31ab1942c42c6e466183148f1d3752be )
Ilya Dryomov [Thu, 6 Apr 2023 10:32:11 +0000 (12:32 +0200)]
PendingReleaseNotes: add a note for rbd-mirror daemon perf counters
This was missed in commit
1a1477b9fd7f ("rbd-mirror: add and rename
perf counters for journal and snapshot mirroring").
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit
e89f5815134fbeea4fa4894082c71a4ebd249794 )
Ilya Dryomov [Thu, 30 Mar 2023 11:58:20 +0000 (13:58 +0200)]
librbd: clear Image::list_watchers() list before populating it
The "append to the passed list" behavior is confusing and not what the
corresponding C API (rbd_watchers_list) or other similar C++ APIs (e.g.
list_lockers) do.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit
e11097bc4cf82b997ad1e8e21a8cd9400767f40d )
Dongsheng Yang [Wed, 15 Mar 2023 06:54:39 +0000 (06:54 +0000)]
librbd: fix wrong attribute for rbd_quiesce_complete api
When we use rbd_quiesce_complete api, we got an error:
/usr/bin/ld: undefined reference to `rbd_quiesce_complete'
Then we found the problem is the symbol of rbd_quiesce_complete
in librbd.so is LOCAL. After some investigation, we found
the attribute of rbd_quiesce_complete api is CEPH_RADOS_API
rather than expected CEPH_RBD_API.
Fixes: https://tracker.ceph.com/issues/59208
Signed-off-by: Dongsheng Yang <dongsheng.yang.linux@gmail.com>
(cherry picked from commit
51a2b707a3074e000b310fc20901d5038b15ea0c )
Prasanna Kumar Kalever [Thu, 2 Mar 2023 10:29:19 +0000 (15:59 +0530)]
rbd: improve log msgs when failing to enable mirroring on image
Attempting to enable mirroring on an an image within a namespace bails
out without any useful msg.
$ rbd mirror image enable mi_pool/ns_0/big snapshot
2021-11-17T08:33:21.321+0000
7f4b36f9c2c0 -1 librbd::api::Mirror:
image_enable: cannot enable mirroring in the current pool mirroring mode
Fixes: https://tracker.ceph.com/issues/58895
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
(cherry picked from commit
828a0dea2d40ba0c1aa0a9d4b211f0fabc854350 )
Zac Dover [Sat, 1 Apr 2023 20:05:41 +0000 (06:05 +1000)]
doc/rados/ops: edit health-checks.rst (2 of x)
Edit docs/rados/operations/health-checks.rst (2 of x). PR#50674, the PR
that immediately precedes this PR in the series of PRs that line-edit
health-checks.rst, wrongly identified this series as having five
sections. This has been rectified by using the "2 of x" formulation.
Follows https://github.com/ceph/ceph/pull/50674
https://tracker.ceph.com/issues/58485
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
0565f59698e9d00adf5a4667ac6e84e97d31b554 )
Nizamudeen A [Wed, 5 Apr 2023 17:41:26 +0000 (23:11 +0530)]
Merge pull request #50869 from rhcs-dashboard/wip-59323-reef
reef: mgr/dashboard: fix displaying mirror image progress
Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Cory Snyder [Mon, 27 Feb 2023 09:48:08 +0000 (04:48 -0500)]
ceph-volume: fix issue with fast device allocs when there are multiple PVs per VG
Fixes a regression with fast device allocations when there are multiple PVs
per VG. This is the case for clusters that were deployed prior to v15.2.8.
Fixes: https://tracker.ceph.com/issues/58857
Signed-off-by: Cory Snyder <csnyder@1111systems.com>
(cherry picked from commit
efcf71be18eb25be10a574d54b70229753538664 )
Cory Snyder [Mon, 27 Feb 2023 09:45:47 +0000 (04:45 -0500)]
ceph-volume: add test case to reproduce bug in get_physical_fast_allocs
Adds a test case to reproduce a bug with get_physical_fast_allocs for
clusters that have multiple fast device PVs in a single VG (deployed
prior to v15.2.8). Also fixes other test cases for this function
to more accurately represent reality.
Signed-off-by: Cory Snyder <csnyder@1111systems.com>
(cherry picked from commit
02592cb0a5970f861d25a521579c30639d10b007 )
Anthony D'Atri [Wed, 5 Apr 2023 13:25:12 +0000 (09:25 -0400)]
Merge pull request #50864 from zdover23/wip-doc-2023-04-05-backport-50855-to-reef
reef: doc/rados/ops: edit monitoring-osd-pg.rst (1 of x)
Pere Diaz Bou [Mon, 3 Apr 2023 15:22:35 +0000 (17:22 +0200)]
mgr/dashboard: fix displaying mirror image progress
Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com>
(cherry picked from commit
80960387fbb6d49c3681f4c9e249c441a891462a )
Zac Dover [Tue, 4 Apr 2023 03:29:15 +0000 (13:29 +1000)]
doc/rados/ops: edit monitoring-osd-pg.rst (1 of x)
Line-edit doc/rados/operations/monitoring-osd-pg.rst (1 of x).
https://tracker.ceph.com/issues/58485
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
bd213c244e8a387c98358ac41f4802e102e89c63 )
Anthony D'Atri [Mon, 3 Apr 2023 22:22:03 +0000 (18:22 -0400)]
Merge pull request #50852 from zdover23/wip-doc-2023-04-04-backport-50851-to-reef
reef: doc/rados/ops: add ceph-medic documentation
Zac Dover [Mon, 3 Apr 2023 20:57:27 +0000 (06:57 +1000)]
doc/rados/ops: add ceph-medic documentation
Add a link to the ceph-medic documentation to
doc/rados/operations/monitoring.rst.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
b2a409da26b508e5a51e3becbce16b7ecaffcc1d )
Yuri Weinstein [Mon, 3 Apr 2023 18:30:33 +0000 (11:30 -0700)]
Merge pull request #50758 from ceph/wip-yuriw-fix-upgrades-reef
qa/upgrade: consistently use the tip of the branch as the start version
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Yuri Weinstein [Wed, 29 Mar 2023 21:18:00 +0000 (14:18 -0700)]
qa/upgrade: consistently use the tip of the branch as the start version
Also corrected line to use `image: quay.ceph.io/ceph-ci/ceph:*`
In order to make sure that latest versions of ceph is used as initial install
Fixes: https://tracker.ceph.com/issues/58914
Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
Anthony D'Atri [Sun, 2 Apr 2023 12:59:19 +0000 (08:59 -0400)]
Merge pull request #50830 from zdover23/wip-doc-2023-04-02-backport-50818-to-reef
reef: doc/cephfs: Improve fs-volumes.rst
Anthony D'Atri [Fri, 31 Mar 2023 13:37:52 +0000 (09:37 -0400)]
doc/cephfs: Improve fs-volumes.rst
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit
c8e1f3ac3db513004fbfbb0049757ddc2bca291a )
Yuri Weinstein [Fri, 31 Mar 2023 22:43:02 +0000 (15:43 -0700)]
Merge pull request #50481 from ljflores/wip-tracker-58050-reef
reef: mgr/telemetry: make sure histograms are formatted in `all` commands
Reviewed-by: Yaarit Hatuka <yaarithatuka@gmail.com>
Yuri Weinstein [Fri, 31 Mar 2023 22:41:46 +0000 (15:41 -0700)]
Merge pull request #50475 from rzarzynski/wip-aclamk-harmonize-bluefs-log-reef
reef: os/bluestore: BlueFS: harmonize log read and writes modes
Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
Anthony D'Atri [Fri, 31 Mar 2023 20:04:37 +0000 (16:04 -0400)]
Merge pull request #50822 from zdover23/wip-doc-2023-04-01-backport-50670-to-reef
reef: doc/rados: edit ops/monitoring.rst (1 of 3)
Zac Dover [Sat, 25 Mar 2023 18:51:50 +0000 (04:51 +1000)]
doc/rados: edit ops/monitoring.rst (1 of 3)
Line-edit the first third of doc/rados/operations/monitoring.rst.
https://tracker.ceph.com/issues/58485
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
bc5f404a7876f887d0c7a2dedee5391f66ab0505 )
Anthony D'Atri [Fri, 31 Mar 2023 13:57:47 +0000 (09:57 -0400)]
Merge pull request #50799 from zdover23/wip-doc-2023-03-31-backport-45354-to-reef
reef: doc/msgr2: update dual stack status
Anthony D'Atri [Fri, 31 Mar 2023 13:53:49 +0000 (09:53 -0400)]
Merge pull request #50802 from zdover23/wip-doc-2023-03-31-backport-50554-to-reef
reef: doc/rados: line-edit pg-repair.rst
Zac Dover [Thu, 16 Mar 2023 02:27:44 +0000 (12:27 +1000)]
doc/rados: line-edit pg-repair.rst
Line edit pg-repair.rst.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
b7c19dac2dfdcbc50515e83d952fb25070496c1c )
Dan van der Ster [Fri, 11 Mar 2022 14:15:20 +0000 (15:15 +0100)]
doc/msgr2: update dual stack status
Signed-off-by: Dan van der Ster <daniel.vanderster@cern.ch>
(cherry picked from commit
c7eaeb4dff1fca967046bcd9b53548eabd18012e )
Anthony D'Atri [Thu, 30 Mar 2023 23:56:30 +0000 (19:56 -0400)]
Merge pull request #50796 from zdover23/wip-doc-2023-03-31-backport-50674-to-reef
reef: doc/rados/ops: edit health-checks.rst (1 of x)