]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Yuri Weinstein [Fri, 17 Jun 2022 20:47:33 +0000 (13:47 -0700)]
Merge pull request #46630 from rzarzynski/wip-pglog-trim-dups
tools: ceph-objectstore-tool is able to trim solely pg log dups' entries
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Ernesto Puerta [Fri, 17 Jun 2022 15:33:49 +0000 (17:33 +0200)]
Merge pull request #46433 from rhcs-dashboard/rbd-mirroring-replay
mgr/dashboard: move replaying images to Syncing tab
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: nSedrickm <NOT@FOUND>
Josh Durgin [Fri, 17 Jun 2022 14:53:40 +0000 (07:53 -0700)]
Merge pull request #39980 from badone/wip-ceph_test_lazy_omap_stats-improve-scrubbing-calls-2
test/lazy-omap-stats: Various enhancements
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Guillaume Abrioux [Fri, 17 Jun 2022 12:03:48 +0000 (14:03 +0200)]
Merge pull request #46698 from guits/cv-hide-luks-key-in-log
ceph-volume: do not log sensitive details
Josh Durgin [Thu, 16 Jun 2022 22:17:53 +0000 (15:17 -0700)]
Merge pull request #45284 from tobias-urdin/doc-memory-profiling-valgrind-massif
doc: Add alternative memory profiling to doc
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
zdover23 [Thu, 16 Jun 2022 22:09:54 +0000 (08:09 +1000)]
Merge pull request #46712 from zdover23/wip-doc-2022-06-15--master-to-main-dev-guide-basic-workflow-title
doc/dev: s/master/main/ in title
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Yuri Weinstein [Thu, 16 Jun 2022 21:24:49 +0000 (14:24 -0700)]
Merge pull request #45690 from sleepinging/fix-fio-windows-crash
test/fio/fio_ceph_messenger: fix str_to_ptr() crash at windows
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Guillaume Abrioux [Thu, 16 Jun 2022 07:22:18 +0000 (09:22 +0200)]
ceph-volume: do not print the secret of osd keyring
during osd preparation, ceph-volume logs the secret of the osd keyring to file
```
[2022-06-15 12:31:17,466][ceph_volume.process][INFO ] Running command: /usr/bin/ceph-authtool /var/lib/ceph/osd/ceph-0/keyring --create-keyring --name osd.0 --add-key AQAM0aliR5JvDRAAQBu0stWl9ZhZrcjijg2BIQ==
[2022-06-15 12:31:17,481][ceph_volume.process][INFO ] stdout creating /var/lib/ceph/osd/ceph-0/keyring
added entity osd.0 auth(key=AQAM0aliR5JvDRAAQBu0stWl9ZhZrcjijg2BIQ==)
```
This shouldn't be logged nor printed on terminal.
Fixes: https://tracker.ceph.com/issues/56071
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
Guillaume Abrioux [Wed, 15 Jun 2022 13:46:32 +0000 (15:46 +0200)]
ceph-volume: do not print luks key encryption
During osd activation, ceph-volume logs the luks key to its log file.
```
[2022-06-15 12:50:35,180][ceph_volume.process][INFO ] Running command: /usr/bin/ceph --cluster ceph --name client.osd-lockbox.
51d0770d -403d-4f81-93e6-
e99f627f246c --keyring /var/lib/ceph/osd/ceph-0/lockbox.keyring config-key get dm-crypt/osd/
51d0770d -403d-4f81-93e6-
e99f627f246c /luks
[2022-06-15 12:50:35,522][ceph_volume.process][INFO ] stdout ut9NjMK6YtMh1BLMJZ/mE2A7zTNyrp9pW1kHV8F2ipfz1BIX9MkEWhdYB2Azm1JPZ1d7ahIjBMUbrC/Iqqr2jQhP3MIsDzUYj1enw+sw7LeVvGPf0qNUdKmEGu5tUmvtQ+5pbk4T/9PF36kT6vCHKfNML/3fL6nnY8FDySrI4LY=
[2022-06-15 12:50:35,522][ceph_volume.process][INFO ] Running command: /usr/sbin/cryptsetup --key-size 512 --key-file - --allow-discards luksOpen /dev/ceph-
83c307d3 -710b-4197-8ecd-
0484e17395e3 /osd-block-
51d0770d -403d-4f81-93e6-
e99f627f246c a9HhDO-MiYD-DtYm-SKJf-nO1d-5O3u-FmcCrd
```
Fixes: https://tracker.ceph.com/issues/56066
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
Ernesto Puerta [Thu, 16 Jun 2022 11:19:08 +0000 (13:19 +0200)]
Merge pull request #45926 from ceph/dependabot-npm_and_yarn-src-pybind-mgr-dashboard-frontend-moment-2.29.3
mgr/dashboard: bump moment from 2.29.1 to 2.29.3 in /src/pybind/mgr/dashboard/frontend
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Zac Dover [Thu, 16 Jun 2022 05:57:16 +0000 (15:57 +1000)]
doc/dev: s/master/main/ in title
This changes "master" to "main" in a title. If we lived in an
ideal world, this would have been a part of PR#46678.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
zdover23 [Thu, 16 Jun 2022 01:50:31 +0000 (11:50 +1000)]
Merge pull request #46705 from zdover23/wip-doc-2022-06-15--master-to-main-dev-guide-merging
doc/dev_guide: s/master/main in merging.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
zdover23 [Thu, 16 Jun 2022 01:13:05 +0000 (11:13 +1000)]
Merge pull request #46678 from zdover23/wip-doc-2022-06-14-dev-guide-basic-workflow-master-to-main
doc/dev: s/master/main/ in basic workflow
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Anthony D'Atri [Wed, 15 Jun 2022 22:58:13 +0000 (15:58 -0700)]
Merge pull request #46632 from anthonyeleven/anthonyeleven/osd-activate-typos
src/ceph-volume/ceph_volume/activate: Improve usage message text
Zac Dover [Wed, 15 Jun 2022 21:54:31 +0000 (07:54 +1000)]
doc/dev_guide: s/master/main in merging.rst
This changes the branch name "master" to the branch name
"main" in merging.rst.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Laura Flores [Wed, 15 Jun 2022 21:14:30 +0000 (16:14 -0500)]
Merge pull request #44861 from Matan-B/wip-matanb-doc-gdb
doc/dev: Debuggging with gdb
Zack Cerza [Wed, 15 Jun 2022 21:05:55 +0000 (15:05 -0600)]
Merge pull request #46582 from ceph/rhel86
qa: Default to RHEL8.6 instead of 8.5
Yuri Weinstein [Wed, 15 Jun 2022 20:27:13 +0000 (13:27 -0700)]
Merge pull request #46029 from kamoltat/wip-ksirivad-fix-notify-rank-removed
mon/Elector: notify_rank_removed erase rank from both live_pinging and dead_pinging sets for highest ranked MON
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Yuri Weinstein [Wed, 15 Jun 2022 20:26:45 +0000 (13:26 -0700)]
Merge pull request #45858 from ganeshmaharaj/ganeshma/gcc-12-libcephsqlite
libcephsqlite: ceph-mgr crashes when compiled with gcc12
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Yuri Weinstein [Wed, 15 Jun 2022 20:25:56 +0000 (13:25 -0700)]
Merge pull request #45750 from m-ildefons/boost-b2-jobs
cmake: configure boost build with concurrent jobs
Reviewed-by: Kefu Chai <kchai@redhat.com>
David Galloway [Wed, 8 Jun 2022 19:07:09 +0000 (15:07 -0400)]
qa: Default to RHEL8.6 instead of 8.5
Signed-off-by: David Galloway <dgallowa@redhat.com>
Adam King [Wed, 15 Jun 2022 17:47:28 +0000 (13:47 -0400)]
Merge pull request #46364 from rkachach/fix_issue_54581
mgr/nfs: validate virtual_ip parameter
Reviewed-by: John Mulligan <jmulligan@redhat.com>
Matan Breizman [Wed, 2 Feb 2022 10:11:53 +0000 (10:11 +0000)]
doc/dev: Debuggging with gdb
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Zack Cerza [Wed, 15 Jun 2022 16:55:14 +0000 (10:55 -0600)]
Merge pull request #46648 from zmc/cephadm-sysctl-noop
Kefu Chai [Wed, 15 Jun 2022 14:25:16 +0000 (22:25 +0800)]
Merge pull request #46664 from tchaikov/wip-doc-gantt
doc: render release with mermaid gantt
Reviewed-by: Laura Flores <lflores@redhat.com>
Kefu Chai [Wed, 15 Jun 2022 14:24:36 +0000 (22:24 +0800)]
Merge pull request #46669 from tchaikov/wip-crimson-deferred
crimson/osd: use seastar::deferred_stop()
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Venky Shankar [Wed, 15 Jun 2022 07:03:06 +0000 (12:33 +0530)]
Merge pull request #45614 from lxbsz/wip-54653
ceph-fuse: add dedicated snap stag map for each directory
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
Kefu Chai [Wed, 15 Jun 2022 04:30:34 +0000 (00:30 -0400)]
doc: render release with mermaid gantt
for better readability
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Wed, 15 Jun 2022 04:31:26 +0000 (00:31 -0400)]
admin/doc-requirements: bump sphinx to 4.5.0
also pin sphinx-autodoc-typehints to 1.18.3
to address following error:
ERROR: sphinx-autodoc-typehints 1.18.3 has requirement Sphinx>=4.5, but you'll have sphinx 4.4.0 which is incompatible.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Xiubo Li [Wed, 6 Apr 2022 00:12:26 +0000 (08:12 +0800)]
ceph-fuse: add dedicated snap stag map for each directory
This will fix the fino colliding bug, which is caused when the
snapid is later than 0xffff.
From mds 'mds_max_snaps_per_dir' option, we can see that the max
snapshots for each directory is 4_K, and in ceph-fuse we have
around 64_K, which is from 0xffff - 2, stags could be used to make
the fake fuse inode numbers for each directory.
Fixes: https://tracker.ceph.com/issues/54653
Signed-off-by: Xiubo Li <xiubli@redhat.com>
Xiubo Li [Thu, 24 Mar 2022 02:01:57 +0000 (10:01 +0800)]
ceph-fuse: return EINVAL if get invalid fino instead of assert
All the snap ids of the finos returned to libfuse from libcephfs
will be recorded in the map of 'stag_snap_map', and will never be
erased before unmounting. So if libfuse passes invalid fino the
ceph-fuse should return EINVAL errno instead of crash itself.
Fixes: https://tracker.ceph.com/issues/54653
Signed-off-by: Xiubo Li <xiubli@redhat.com>
Xiubo Li [Wed, 23 Mar 2022 06:30:07 +0000 (14:30 +0800)]
ceph-fuse: reserve stag number 1 for snapdirs
There have two stags will be reserved, 0 for CEPH_NOSNAP and 1 for
CPEH_SNAPDIR.
This will always make sure that for the nonsnap and snapdir inode
numbers to be consistent for all the ceph-fuse mounts.
Signed-off-by: Xiubo Li <xiubli@redhat.com>
Xiubo Li [Wed, 23 Mar 2022 02:05:32 +0000 (10:05 +0800)]
mds-client: make the fake inos option unchangeable in runtime
If the flags is empty then in option.h in can_update_at_runtime()
it will return true. That means this opetion could be changed in
runtime, which is buggy. Because if this is false, ceph-fuse will
use its own fake inos instead of libcephfs'. If this is changed
during runtime, we will hit inos dosn't exist assert bugs.
Fixes: https://tracker.ceph.com/issues/54653
Signed-off-by: Xiubo Li <xiubli@redhat.com>
Anthony D'Atri [Wed, 15 Jun 2022 01:03:05 +0000 (18:03 -0700)]
Merge pull request #46629 from anthonyeleven/anthonyeleven/46195_formatting
doc/man/8: Tweak formatting and wording in ceph.rst
Zac Dover [Tue, 14 Jun 2022 22:15:33 +0000 (08:15 +1000)]
doc/dev: s/master/main/ in basic workflow
This PR changes "master" to "main" in the
basic_workflow.rst file. I have even changed
"master" to "main" in some terminal output from
several years ago. This isn't historically ac-
curate, of course, but my hope is that this change
will prevent someone in the future from being con-
fused about why an antiquated branch name is ref-
erred to.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Yuri Weinstein [Tue, 14 Jun 2022 20:43:42 +0000 (13:43 -0700)]
Merge pull request #46362 from pdvian/wip-logm-mgrstat
mon/LogMonitor, MgrStat: Report logm and mgrstat committed version
Reviewed-by: Laura Flores <lflores@redhat.com>
Yuri Weinstein [Tue, 14 Jun 2022 20:43:10 +0000 (13:43 -0700)]
Merge pull request #46279 from jianwei1216/osd-peering-complete-log-patch
osd: add log for pg peering and activiting complete
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Kefu Chai [Tue, 14 Jun 2022 16:31:09 +0000 (00:31 +0800)]
crimson/osd: use seastar::deferred_stop()
trade `seastar::defer()` for `seastar::deferred_stop()` to
simplify the code a little bit.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Zack Cerza [Mon, 13 Jun 2022 17:12:23 +0000 (11:12 -0600)]
cephadm: Make sysctl conf writing idempotent
By checking the system's actual settings against our desired settings
before writing out the config file.
Fixes: https://tracker.ceph.com/issues/56026
Signed-off-by: Zack Cerza <zack@redhat.com>
Yuri Weinstein [Tue, 14 Jun 2022 15:27:57 +0000 (08:27 -0700)]
Merge pull request #46509 from aclamk/wip-pglog-test-leak
test/pglog: Fix memory leak
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Yuri Weinstein [Tue, 14 Jun 2022 15:27:05 +0000 (08:27 -0700)]
Merge pull request #46438 from pdvian/wip-scrub-starts
osd/scrub: Reintroduce scrub starts message
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Yuri Weinstein [Tue, 14 Jun 2022 15:26:23 +0000 (08:26 -0700)]
Merge pull request #46428 from sseshasa/wip-fix-55773-have-pending
mon/OSDMonitor: Ensure kvmon() is writeable before handling "osd new" cmd
Reviewed-by: Neha Ojha <nojha@redhat.com>
Yuri Weinstein [Tue, 14 Jun 2022 15:25:25 +0000 (08:25 -0700)]
Merge pull request #45984 from trociny/wip-51835
mgr: relax "pending_service_map.epoch > service_map.epoch" assert
Reviewed-by: Neha Ojha <nojha@redhat.com>
Adam King [Tue, 14 Jun 2022 14:01:08 +0000 (10:01 -0400)]
Merge pull request #46285 from s0nea/config-fqdn-active
mgr/cephadm: try to get FQDN for active instance
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Paul Cuzner <pcuzner@redhat.com>
Adam King [Tue, 14 Jun 2022 13:56:49 +0000 (09:56 -0400)]
Merge pull request #46506 from asm0deuz/mod_iscsi_systemd
Modify how Iscsi tcmu-runner container is started within systemd
Reviewed-by: Adam King <adking@redhat.com>
Adam King [Tue, 14 Jun 2022 13:52:53 +0000 (09:52 -0400)]
Merge pull request #44894 from guits/add_dockerfile_keepalived
cephadm: change default keepalived/haproxy container images
Reviewed-by: Ken Dreyer <kdreyer@redhat.com>
Adam King [Tue, 14 Jun 2022 13:48:53 +0000 (09:48 -0400)]
Merge pull request #46588 from guits/cluster-fsid-common
ceph-volume: make is_valid() optional
Reviewed-by: Teoman ONAY <tonay@redhat.com>
Deepika Upadhyay [Tue, 14 Jun 2022 12:46:27 +0000 (18:16 +0530)]
Merge pull request #46586 from SUSE/wip-suse-default-jaeger-off
ceph.spec.in: turn jaeger off by default for SUSE distros
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
Ernesto Puerta [Tue, 14 Jun 2022 11:23:59 +0000 (13:23 +0200)]
Merge pull request #46370 from rhcs-dashboard/stop-poll-page-inactive
mgr/dashboard: stop polling when page is not visible
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Ernesto Puerta [Tue, 14 Jun 2022 11:21:26 +0000 (13:21 +0200)]
Merge pull request #46475 from rhcs-dashboard/01-hosts-failure
mgr/dashboard: fix drain e2e failure
Reviewed-by: Sarthak Gupta <sarthak.dev.0702@gmail.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Venky Shankar [Tue, 14 Jun 2022 09:46:27 +0000 (15:16 +0530)]
Merge pull request #44567 from lxbsz/client_reply
client: do nothing when get a stale reply
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Yuval Lifshitz [Tue, 14 Jun 2022 09:22:21 +0000 (12:22 +0300)]
Merge pull request #46313 from zenomri/wip-omri-tracing-lua
rgw: add SetAttribute and AddEvent functions for TraceMetaTable in Lua
Reviewed-by: yuvalif
Ernesto Puerta [Tue, 14 Jun 2022 09:00:21 +0000 (11:00 +0200)]
Merge pull request #46407 from melissa-kun-li/disable-create-image
mgr/dashboard: add rbd status endpoint and error page
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: sunilangadi2 <NOT@FOUND>
zdover23 [Tue, 14 Jun 2022 06:27:14 +0000 (16:27 +1000)]
Merge pull request #46651 from zdover23/wip-doc-2022-06-13-dev-guide-essentials-master-to-main
doc/dev: s/master/main/ essentials.rst dev guide
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Anthony D'Atri [Mon, 13 Jun 2022 23:58:08 +0000 (16:58 -0700)]
Merge pull request #46659 from anthonyeleven/anthonyeleven-46637-followup
doc/start: Polish network section of hardware-recommendations.rst
Anthony D'Atri [Mon, 13 Jun 2022 23:06:12 +0000 (16:06 -0700)]
doc/start: Polish network section of hardware-recommendations.rst
Harmonize network throughput notation, minor tweaks to wording.
Followup to #46637
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Zac Dover [Mon, 13 Jun 2022 21:48:46 +0000 (07:48 +1000)]
doc/dev: s/master/main/ essentials.rst dev guide
This PR changes all reference to the "master" branch
to references to the "main" branch (because we renamed
"master" to main", and the docs now need to reflect that).
Signed-off-by: Zac Dover <zac.dover@gmail.com>
zdover23 [Mon, 13 Jun 2022 21:11:12 +0000 (07:11 +1000)]
Merge pull request #46637 from zdover23/wip-doc-2022-06-12-start-intro-networks-rewrite
doc/start: rewrite hardware-recs networks section
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Casey Bodley [Mon, 13 Jun 2022 16:04:12 +0000 (12:04 -0400)]
Merge pull request #43597 from pritha-srivastava/wip-rgw-sts-role-multisite
rgw multisite: replicate metadata for iam roles
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Yuval Lifshitz [Mon, 13 Jun 2022 15:18:56 +0000 (18:18 +0300)]
Merge pull request #46568 from yuvalif/wip-yuval-lua-counters
rgw/lua: add counters to background table
Reviewed-by: mattbenjamin
Reviewed-by: Matan-b
Nizamudeen A [Wed, 1 Jun 2022 07:40:14 +0000 (13:10 +0530)]
mgr/dashboard: fix drain e2e failure
Cypress sometimes fail to register the click and that causes the
deselect/select to not happen properly. Deselecting the row immediately
after performing the action makes it pass from cypress.
Fixes: https://tracker.ceph.com/issues/55741
Signed-off-by: Nizamudeen A <nia@redhat.com>
Xiubo Li [Thu, 13 Jan 2022 04:03:39 +0000 (12:03 +0800)]
client: do nothing when get a stale reply
In theory when we get a stale reply from incorrect session, that
means it's buggy in MDS. Anyway we should discard it without doing
anything.
Signed-off-by: Xiubo Li <xiubli@redhat.com>
Venky Shankar [Mon, 13 Jun 2022 08:10:04 +0000 (13:40 +0530)]
Merge pull request #44655 from lxbsz/wip-53741
mds: clear MDCache::rejoin_*_q queues before recovering file inodes
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Nikhilkumar Shelke <nshelke@redhat.com>
Venky Shankar [Mon, 13 Jun 2022 06:59:43 +0000 (12:29 +0530)]
Merge pull request #45556 from mchangir/qa-add-subvolume-option-flavors
qa: add subvolume option flavors
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Venky Shankar [Mon, 13 Jun 2022 06:56:59 +0000 (12:26 +0530)]
Merge pull request #44347 from kotreshhr/subvolumegroup-quotas
mgr/volumes: subvolumegroup quotas
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Venky Shankar [Mon, 13 Jun 2022 06:55:44 +0000 (12:25 +0530)]
Merge pull request #46332 from lxbsz/qa-snap
qa: enlarge the tag number and test more for the snapshot
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Omri Zeneva [Tue, 24 May 2022 09:08:17 +0000 (05:08 -0400)]
doc: add explanation about the new two functions and example
Signed-off-by: Omri Zeneva <ozeneva@redhat.com>
Omri Zeneva [Mon, 23 May 2022 15:50:05 +0000 (11:50 -0400)]
test: add unit tests
- added trace initialization
- opentelemetry linking when needed
- conditional ASSERT on SetBadAttribute, when we don't have opentelemetry (tracing sdk), we expect different result from the execute function.
Signed-off-by: Omri Zeneva <ozeneva@redhat.com>
Omri Zeneva [Wed, 11 May 2022 13:39:49 +0000 (09:39 -0400)]
rgw: add functionality of SetAttribute and AddEvent method in postRequest context
opentelemetry supports mainly string, int64, double and boolean for values of trace's Attributes,
so we should validate those types and static cast to the proper type, which is different than Lua types
SetAttribute Closure will be returned to lua only if the request's trace is real and not noop span or even null like what happens in preRequest Context
AddEvent method comes to give us the ability to record an event. the event can be a single string that represents the event, or event name and key-value pairs.
Signed-off-by: Omri Zeneva <ozeneva@redhat.com>
Zac Dover [Mon, 13 Jun 2022 04:34:36 +0000 (14:34 +1000)]
doc/start: rewrite hardware-recs networks section
This rewrites the first two-thirds of the "Networks"
section of the Hardware Recommendations page in the
Intro to Ceph document. I have tried to divide the
techincal content in this section into subsections
that foreground the various subjects covered.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Anthony D'Atri [Mon, 13 Jun 2022 03:47:48 +0000 (20:47 -0700)]
Merge pull request #46634 from Huber-ming/pr_target_main
SubmittingPatches.rst: PRs should target "main"
Anthony D'Atri [Mon, 13 Jun 2022 03:32:05 +0000 (20:32 -0700)]
Merge pull request #46583 from zdover23/wip-doc-2022-06-08-intro-hardware-recs-osd-acro-fix
doc/start: make OSD and MDS structures parallel
Anthony D'Atri [Mon, 13 Jun 2022 03:26:02 +0000 (20:26 -0700)]
Merge pull request #46633 from zdover23/wip-doc-2022-06-12-start-intro-crush-para-fix
doc/start: rewrite CRUSH para
Huber-ming [Mon, 13 Jun 2022 01:36:39 +0000 (09:36 +0800)]
SubmittingPatches.rst: PRs should target "main"
Signed-off-by: Huber-ming <zhangsm01@inspur.com>
Zac Dover [Wed, 8 Jun 2022 19:19:16 +0000 (05:19 +1000)]
doc/start: make OSD and MDS structures parallel
This PR makes the "Ceph OSDs" and "MDSs" bullet points
parallel by naming "object storage daemon" before referring
to the (admittedly more common and colloquial, but surely
unknown to people who genuinely require a document called
'Intro') acronym "OSD".
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Zac Dover [Sun, 12 Jun 2022 23:41:28 +0000 (09:41 +1000)]
doc/start: rewrite CRUSH para
This PR supersedes https://github.com/ceph/ceph/pull/46584
and makes changes suggested by Anthony D'Atri that improve
the coherence and consistency of the paragraph that explains
the basics of the CRUSH algorithm.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Anthony D'Atri [Sun, 12 Jun 2022 01:23:28 +0000 (18:23 -0700)]
src/ceph-volume/ceph_volume/activate: Improve usage message text
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Radosław Zarzyński [Sat, 11 Jun 2022 19:29:29 +0000 (21:29 +0200)]
tools: ceph-objectstore-tool is able to trim pg log dups' entries.
The main assumption is trimming just dups doesn't need any update
to the corresponding pg_info_t.
Testing:
1. cluster without the autoscaler
```
rzarz@ubulap:~/dev/ceph/build$ MON=1 MGR=1 OSD=3 MGR=1 MDS=0 ../src/vstart.sh -l -b -n -o "osd_pg_log_dups_tracked=
3000000 " -o "osd_pool_default_pg_autoscale_mode=off"
```
2. 8 PGs in the testing pool.
```
rzarz@ubulap:~/dev/ceph/build$ bin/ceph osd pool create test-pool 8 8
```
3. Provisioning dups with rados bench
```
bin/rados bench -p test-pool 300 write -b 4096 --no-cleanup
...
Total time run: 300.034
Total writes made: 103413
Write size: 4096
Object size: 4096
Bandwidth (MB/sec): 1.34637
Stddev Bandwidth: 0.589071
Max bandwidth (MB/sec): 2.4375
Min bandwidth (MB/sec): 0.902344
Average IOPS: 344
Stddev IOPS: 150.802
Max IOPS: 624
Min IOPS: 231
Average Latency(s): 0.
0464151
Stddev Latency(s): 0.
0183627
Max latency(s): 0.
0928424
Min latency(s): 0.
0131932
```
4. Killing osd.0
```
rzarz@ubulap:~/dev/ceph/build$ kill
2572129 # pid of osd.0
```
5. Listing PGs on osd.0 and calculating number of pg log's entries and
dups:
```
rzarz@ubulap:~/dev/ceph/build$ bin/ceph-objectstore-tool --data-path dev/osd0 --op list-pgs --pgid 2.c > osd0_pgs.txt
rzarz@ubulap:~/dev/ceph/build$ for pgid in `cat osd0_pgs.txt`; do echo $pgid; bin/ceph-objectstore-tool --data-path dev/osd0 --op log --pgid $pgid | jq '(.pg_log_t.log|length),(.pg_log_t.dups|length)'; done
2.7
10020
3100
2.6
10100
3000
2.3
10012
2800
2.1
10049
2900
2.2
10057
2700
2.0
10027
2900
2.5
10077
2700
2.4
10072
2900
1.0
97
0
```
6. Trimming dups
```
rzarz@ubulap:~/dev/ceph/build$ CEPH_ARGS="--osd_pg_log_dups_tracked 2500 --osd_pg_log_trim_max=100" bin/ceph-objectstore-tool --data-path dev/osd0 --op trim-pg-log-dups --pgid 2.7
max_dup_entries=2500 max_chunk_size=100
Removing keys dup_0000000020.
00000000000000000001 - dup_0000000020.
00000000000000000100
Removing keys dup_0000000020.
00000000000000000101 - dup_0000000020.
00000000000000000200
Removing keys dup_0000000020.
00000000000000000201 - dup_0000000020.
00000000000000000300
Removing keys dup_0000000020.
00000000000000000301 - dup_0000000020.
00000000000000000400
Removing keys dup_0000000020.
00000000000000000401 - dup_0000000020.
00000000000000000500
Removing keys dup_0000000020.
00000000000000000501 - dup_0000000020.
00000000000000000600
Finished trimming, now compacting...
Finished trimming pg log dups
```
7. Checking number of pg log's entries and dups
```
rzarz@ubulap:~/dev/ceph/build$ for pgid in `cat osd0_pgs.txt`; do echo $pgid; bin/ceph-objectstore-tool --data-path dev/osd0 --op log --pgid $pgid | jq '(.pg_log_t.log|length),(.pg_log_t.dups|length)'; done
2.7
10020
2500
2.6
10100
3000
2.3
10012
2800
2.1
10049
2900
2.2
10057
2700
2.0
10027
2900
2.5
10077
2700
2.4
10072
2900
1.0
97
0
```
Fixes: https://tracker.ceph.com/issues/53729
Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
Radosław Zarzyński [Sat, 11 Jun 2022 06:33:55 +0000 (08:33 +0200)]
Revert "tools/ceph_objectstore_took: Add duplicate entry trimming"
This reverts commit
9fb7ec61ba10896ce01d5970375f1ce1dd993874 .
Although the chunking in off-line `dups` trimming (via COT) seems
fine, the `ceph-objectstore-tool` is a client of `trim()` of
`PGLog::IndexedLog` which means than a partial revert is not
possible without extensive changes. Moreover, trimming pg log
is not enough without modifying pg_info_t accordingly which
the reverted patch lacks.
Fixes: https://tracker.ceph.com/issues/53729
Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
Radosław Zarzyński [Sat, 11 Jun 2022 06:32:46 +0000 (08:32 +0200)]
Revert "osd/PGLog.cc: Trim duplicates by number of entries"
This reverts commit
0d253bcc09a5540fa6c724f6128fb7436ded5ec1 .
which is the in-OSD part of the fix for accumulation of `dup`
entries in a PG Log. Brainstorming it has brought questions
on the OSD's behaviour during an upgrade if there are tons of
dups in the log. What must be double-checked before bringing
it back is ensuring we chunk the deletions properly to not
impose OOMs / stalls in, to exemplify, RocksDB.
Fixes: https://tracker.ceph.com/issues/53729
Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
Anthony D'Atri [Sat, 11 Jun 2022 21:21:50 +0000 (14:21 -0700)]
doc/man/8: Tweak formatting and wording in ceph.rst
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Anthony D'Atri [Sat, 11 Jun 2022 21:02:32 +0000 (14:02 -0700)]
Merge pull request #46200 from elacunza/doc-man-ceph-add-enable_stretch_mode
doc/man/8: Add enable_stretch_mode docs
Anthony D'Atri [Sat, 11 Jun 2022 20:43:48 +0000 (13:43 -0700)]
Merge pull request #46462 from Thingee/update-foundation-mems-202205
doc: Updating Ceph Foundation members for May
Anthony D'Atri [Sat, 11 Jun 2022 20:32:15 +0000 (13:32 -0700)]
Merge pull request #46195 from snosratiershad/fix-docs-double-dash-convertion-to-em-dash
doc: Disable double dashes "--" smartquotes conversion to en-dashes
Salar Nosrati-Ershad [Sun, 8 May 2022 06:49:06 +0000 (11:19 +0430)]
doc: Disable double dashes "--" smartquotes conversion to en-dashes
Laura Flores [Fri, 10 Jun 2022 16:56:19 +0000 (11:56 -0500)]
Merge pull request #46604 from ljflores/wip-librados-test-fix
test/librados: modify LibRadosMiscConnectFailure.ConnectFailure to comply with new seconds unit
Yuri Weinstein [Fri, 10 Jun 2022 16:39:24 +0000 (09:39 -0700)]
Merge pull request #46606 from rzarzynski/wip-55982
osd: log the number of 'dups' entries in a PG Log
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Ilya Dryomov [Fri, 10 Jun 2022 16:28:18 +0000 (18:28 +0200)]
Merge pull request #46600 from idryomov/wip-pmdk-wno-error
cmake: pass -Wno-error when building PMDK
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Casey Bodley [Fri, 10 Jun 2022 13:36:38 +0000 (09:36 -0400)]
Merge pull request #46617 from yuvalif/wip-yuval-fix-55978
rgw/lua: pass correct value to "toplevel" param
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Fri, 10 Jun 2022 13:36:00 +0000 (09:36 -0400)]
Merge pull request #44648 from Huber-ming/index_cancel
rgw: delete redundant brackets
Reviewed-by: Matt Benjamin <mbenjami@redhat.com>
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Patrick Donnelly [Fri, 10 Jun 2022 00:12:49 +0000 (20:12 -0400)]
Merge PR #46421 into main
* refs/pull/46421/head:
doc/dev: move option -R to a different section of doc
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Anthony D Atri <anthony.datri@gmail.com>
Radoslaw Zarzynski [Thu, 9 Jun 2022 18:44:10 +0000 (18:44 +0000)]
osd: log the number of 'dups' entries in a PG Log
We really want to have the ability to know how many
entries `PGLog::IndexedLog::dups` has inside.
The current ways are either invasive (stopping an OSD)
or indirect (examination of `dump_mempools`).
The code comes from Nitzan Mordechai (part of
ede37edd79a9d5560dfb417ec176327edfc0e4a3 ).
Fixes: https://tracker.ceph.com/issues/55982
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
yuval Lifshitz [Thu, 9 Jun 2022 19:51:50 +0000 (22:51 +0300)]
rgw/lua: pass correct value to "toplevel" param
Fixes: https://tracker.ceph.com/issues/55978
Signed-off-by: yuval Lifshitz <ylifshit@redhat.com>
Laura Flores [Thu, 9 Jun 2022 18:55:48 +0000 (18:55 +0000)]
test/librados: modify LibRadosMiscConnectFailure.ConnectFailure to comply with new seconds unit
The unit type for `client_mount_timeout` was changed from "float" to "secs" in
983b10506dc8466a0e47ff0d320d480dd09999ec . To make this test comply with the new
seconds unit change, we need to change the value to an integer, as seconds
does not accept float values.
Fixes: https://tracker.ceph.com/issues/55971
Signed-off-by: Laura Flores <lflores@redhat.com>
yuval Lifshitz [Thu, 9 Jun 2022 15:57:07 +0000 (18:57 +0300)]
rgw/lua: replace int64_t with "long long int" for the background table
lua integer is "long long int" which works with GCC 11.2.1 (fedora 36)
but fails to compile on centos8 and ubuntu focal
Signed-off-by: yuval Lifshitz <ylifshit@redhat.com>
yuval Lifshitz [Thu, 9 Jun 2022 13:29:48 +0000 (16:29 +0300)]
rgw/lua: use constants for upvalue indexes
Signed-off-by: yuval Lifshitz <ylifshit@redhat.com>
Yuval Lifshitz [Mon, 23 May 2022 11:38:34 +0000 (14:38 +0300)]
rgw/lua: add atomic increment/decrement to RGW table
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
Yuval Lifshitz [Wed, 18 May 2022 14:18:14 +0000 (17:18 +0300)]
rgw/lua: support multiple types in lua background table
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
Casey Bodley [Thu, 9 Jun 2022 14:50:24 +0000 (10:50 -0400)]
Merge pull request #45806 from hualongfeng/qat_error_fix1
common/compressor: fix the issue that read more data
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Ilya Dryomov [Thu, 9 Jun 2022 11:42:01 +0000 (13:42 +0200)]
cmake: pass -Wno-error when building PMDK
It's hitting pacific with a nuisance -Werror=array-parameter= const
char * vs const char[37] mismatch. Follow commit
91a616b26e83 ("cmake:
pass RTE_DEVEL_BUILD=n when building dpdk") and just disable -Werror.
Fixes: https://tracker.ceph.com/issues/55977
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>