cmon: check return code of chdir

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

tools/common: EINTR/unchecked return fix

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

rados: fix pedantic gcc warning on writing stdout

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

filejournal: fix unchecked returns, modularize

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

cosd: check chdir return code

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

osd: Ager: remove Ebofs leftovers

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

Add do_autogen.sh

It's handy when making builds with various different warning levels.
Also saves you from having to remember --prefix, etc. all the time.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

mkcephfs: clean up temp files, honor $TEMPDIR

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

filer: fix probe

ENOENT is allowed and expected at the end of a journal.  It is treated the
same as a zero size object.

Fixes 800507e891170b99cae10a9bf7c5166fd3512927.

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

client/fuse_ll.c: const cleanup

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

Revert "client/fuse_ll: fully initialize callback struct"

Older build environments may not have all the fuse function ptrs that
are present in newer ones. It's best to just let them all silently be
set to 0.

This reverts commit 516ac99bb8c16614757f3b61f4bf266e4531861e.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

Revert "client/fuse.cc: explicity zero fuse function ptrs"

Older build environments may not have all the fuse function ptrs that
are present in newer ones. It's best to just let them all silently be
set to 0.

This reverts commit 38b50013e27e79dd43c5f514c8c24bd8b1e69e5f.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

Merge branch 'master' of ssh://ceph.newdream.net/git/ceph

filestore: fix wipe_subvol the rest of the way

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

filestore: fix (part of) wipe_subvol

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

msgr: add nonce parsing to entity_addr_t::parse()

Reported-by: John Leach <john@brightbox.co.uk>
Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

os: FileStore::wipe_subvol: fix removing old dir

Older versions of btrfs which don't have BTRFS_IOC_SNAP_DESTROY need to
manually remove snapshots.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

cosd.cc: better error message if osd->init fails

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

auth/ExportControl: fix allow_def leak

allow_def would be leaked if the first branch is not taken.

Signed-off-by: Samuel Just <samuel.just@dreamhost.com>

Merge branch 'stable'

Conflicts:
src/common/signal.cc
src/os/FileStore.cc

signal: fix redefine warnings

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

ReplicatedPG: snap_trimmer fix leaked lock

Previous patch 7a02070b741d3482ff6b28827c1eb274a2134486 leaks the pg
lock.

Signed-off-by: Samuel Just <samuel.just@dreamhost.com>

mds: make SETDIRLAYOUT start with ancestor policy

When we set a new policy on a directory, make the starting point the
current policy, as specified by an ancestor.  Remove any reference to
g_default_file_layout.

This aligns the code with the inode creation paths (the other time we
look at the layout policy).

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

ReplicatedPG:snap_trimmer should return if !clean or !active or !primary

The PG may become !clean or !active while in the osd snap_trim_wq.

Signed-off-by: Samuel Just <samuel.just@dreamhost.com>

Merge branch 'wannoying'

MonMap: add,remove,contains can take const references

Signed-off-by: Samuel Just <samuel.just@dreamhost.com>

SimpleMessenger: learned_addr can take a const ref

peer_addr_for_me can be passed as a const ref.

Signed-off-by: Samuel Just <samuel.just@dreamhost.com>

mds: handle_client_setdirlayout: init fl_pg_pool

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

librados: print out errs in do_import, check EINTR

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

include/utime.h: avoid comparing float with 0

Avoid doing an exact comparison of a float with 0.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

crush: eliminate signed/unsigned comparisons

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

client/fuse.cc: explicity zero fuse function ptrs

Set unused function pointers to 0 explicitly to please gcc. (They were
already implicitly zeroed because the containing struct was a global.)

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

mount.ceph: put static at the beginning of decl

To squash a gcc warning.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

tools/gui.cc: remove empty else statement

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

mon/OSDMonitor: don't check if unsigned < 0

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

osd/OSD: remove always-true assert

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

const-ify some unchanging static structs

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

rgw/rgw_rest.cc: fix uninitialized static struct

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

osdc/Filer: assert(0) on stat error

Remove broken error handling code and replace with an assert(0) and a
TODO.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

client/fuse_ll: fully initialize callback struct

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

mds/locks: fully initialize lock states

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

osdc/ObjectCacher.h: don't assert unsigned >= 0

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

Client::readdir_r_cb: fix "always returns true"cmp

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

direct_io_test: fix signed/unsigned, printf flags

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

src/config.cc: fully initialize g_default_file_layout

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

crush/builder.c: fix signed/unsigned confusion

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

include/buffer.h:unsigned variables are always >=0

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

Merge branch 'master' of ssh://ceph.newdream.net/git/ceph

RGW: RGW::GetObj - signed/unsigned bug

get_obj returns an int, len is unsigned

Signed-off-by: Samuel Just <samuel.just@dreamhost.com>

RGW: fix ret in RGWCopyObj::init_common

int ret shadows RGWCopyObj::ret.

Signed-off-by: Samuel Just <samuel.just@dreamhost.com>

RGW: fix shadowed variable error

int ret and bool ret shadow this->ret, setting ret before the goto
therefore had no effect in these cases.

Signed-off-by: Samuel Just <samuel.just@dreamhost.com>

RGW: get_service_secret returns a bool, not an int

Signed-off-by: Samuel Just <samuel.just@dreamhost.com>

RBD.cc: pread returns a signed value

The check for len < 0 here always returned true since len is uint64_t.

Signed-off-by: Samuel Just <samuel.just@dreamhost.com>

mount.ceph: option parsing fix

Passing -o secretfile would cause a segfault since searching for = would
result in a null pointer.  New version checks for that case.  Also, *end
cannot be a ,.

Signed-off-by: Samuel Just <samuel.just@dreamhost.com>

Merge branch 'objecter_balance_reads'

Fix base64-decoding when input ends in newline.

It used to return -EINVAL because it thought the end was not aligned
to 4 bytes.

Clean up superfluous src < end test in if, the while itself guarantees
that.

Fix inner loop index variable. i and j are too close together ;)

Before this fix, j would keep increasing well beyond in_len,
and lead to segfaults.

osd: Fix compile-time warning.

store is properly initialized inside a try block, but the
compiler doesn't notice that and so thinks it may be used
uninitialized. So initialize it to be NULL.

Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com>

mds: Remove unused variable.

Fixes compile complaint. Was made useless in commit
6d29fc66326ff40443ac465c84d6f7bddf3cee4f.

Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com>

rados: Make rados tool "put" objects in chunks.

Defaults to 4MB, but can be configured.

Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com>

mds: Remove redundant cap suppression code.

Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com>

Speling fixes

Trivial spelling fixes...

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

Improve mount.ceph.8

Seeing as I was wondering what "rbytes" might be, I guess others might
too...

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

monitorstore: check return values

And use open(2) instead of fopen.

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

mds: check return values in dumper

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

confutils: check return values

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

os: use scoped variables for fds

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

test: add test_csyn

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

csyn: implement localize_reads cmdline option

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

osd: change unfound handling when using localize

Change how cosd handles unfound objects when doing operations with
localize_reads. Specifically, don't wait for unfound objects unless we
are the primary for the relevant PG.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

Hadoop: set localize_reads

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

cfuse: add --localize-reads argument

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

libceph: iface for CEPH_OSD_FLAG_LOCALIZE_READS

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

objecter: implement FLAG_LOCALIZE_READS

Read from a local replica, if any.

Signed-off-by: Sage Weil <sage@newdream.net>

objecter: send read to random replica if BALANCE_READS flag is set

The flag is just an existing one; we may want to rename.

This assumes the OSD will discard any request sent prior to any change in
the PG acting set.  We need to make sure the OSD behavior matches.

Signed-off-by: Sage Weil <sage@newdream.net>

FileStore: fix double close

curr_fd is already closed if cp == cur_seq.  This second close
occasionally ended up closing another thread's fd.  The next open would
tend to grab that fd in op_fd or current_fd which would then get closed
by the other thread leaving op_fd or current_fd pointing to some random
file (or a closed descriptor).

Signed-off-by: Samuel Just <samuel.just@dreamhost.com>

FileStore: fix double close

curr_fd is already closed if cp == cur_seq.  This second close
occasionally ended up closing another thread's fd.  The next open would
tend to grab that fd in op_fd or current_fd which would then get closed
by the other thread leaving op_fd or current_fd pointing to some random
file (or a closed descriptor).

Signed-off-by: Samuel Just <samuel.just@dreamhost.com>

common: config.cc: use "admin" as the default id

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

common: move init_g_conf into md_config_t ctor

Make sure that g_conf is initialized with default values before anything
else happens.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

common: config.cc: whitespace cleanup

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

common: config.cc: de-globalize g_fake_kill_after

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

common: config.cc: de-globalize show_config

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

common: clean up g_conf.id initialization a bit

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

common: remove ceph_set_default_id

ceph_set_default_id was only ever used to set the default ID to "admin",
which it already was.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

FileStore: fix error handling for mkfs, umount

In FileStore::umount: check if FDs are valid before closing them. Make
them invalid after closing them. Shut down FileStore::timer.

In FileStore::mkfs: always properly shutdown and free the filestore if
an error is encountered during mkfs. Check all functions that can fail.
Print out error messages on failures.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

mds: make --dump-journal preserve offset

Suggest user use tar -S to preserve sparseness.

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

gitignore: ignore eclipse metadata

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

remove ancient active/ stuff

osd: don't leak fd on error

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

crypto: don't clobber errno

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

Merge remote branch 'origin/ostimeo'

Merge branch 'mds_reset'

Fixes: #602

Merge remote branch 'origin/stable'

Conflicts:
src/osd/OSD.cc

OSD: update_osd_stat take heartbeat_lock

Previously update_osd_stat had a race with code modifying heartbeat_from
causing the iterator increment to occasionally segfault.

Signed-off-by: Samuel Just <samuel.just@dreamhost.com>

mds: skip a few more inodes during journal reset

To be safe...

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

mds: implement journal reset

This basically works.  Remaining issues:
 - mydir and root inodes are recreated from scratch but need to be
   reconciled with what's committed (outside the old journal)
 - ?

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

mds: open mydir (along w/ root) inode from boot_start()

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

Locker: Drop loner correctly!

Our previous check for if we want to drop the loner was incorrect.
Now, it's fixed. Resolves a serious bug with inode write access.

Reported-by: Jim Schutt <jaschut@sandia.gov>
Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com>

Locker: Drop loner correctly!

Our previous check for if we want to drop the loner was incorrect.
Now, it's fixed. Resolves a serious bug with inode write access.

Reported-by: Jim Schutt <jaschut@sandia.gov>
Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com>

librados: fix C interface const, too.

See 561224e95d6c66661d1bd6dce0e3d9da6f4a7e13

Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com>