doc/rbd: refine "Removing a Block Device Image"

Refine and add unselectable prompts to "Removing a Block Device Image"
in doc/rbd/rados-rbd-cmds.

https://tracker.ceph.com/issues/57001

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #49338 from zdover23/wip-doc-2022-12-09-rbd-rados-rbd-cmds-creating-a-block-device-image-semantics

doc/rbd: refine "Creating a Block Device Image"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #49340 from zdover23/wip-doc-2022-12-09-rbd-rados-rbd-cmds-retrieving-image-information-semantics

doc/rbd: refine "Retrieving Image Information"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #49339 from zdover23/wip-doc-2022-12-09-rbd-rados-rbd-cmds-listing-block-device-images-semantics

doc/rbd: refine "Listing Block Device Images"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/rbd: refine "Retrieving Image Information"

Refine the text and prompts in "Retrieving Image Information" in
doc/rbd/rados-rbd-cmds.rst.

https://tracker.ceph.com/issues/57001

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #49321 from tchaikov/wip-qa-install-with-utf-8

qa: set locale to C.UTF-8 in tox.ini

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Adam King <adking@redhat.com>

doc/rbd: refine "Listing Block Device Images"

Refine the text and prompts in "Listing Block Device Images" in
doc/rbd/rados-rbd-cmds.rst.

https://tracker.ceph.com/issues/57001

Signed-off-by: Zac Dover <zac.dover@gmail.com>

doc/rbd: refine "Creating a Block Device Image"

Refine the English and prompts in "Creating a Block Device Image" in
doc/rbd/rados-rbd-cmds.rst.

https://tracker.ceph.com/issues/57001

Signed-off-by: Zac Dover <zac.dover@gmail.com>

pybind/mgr: do not test with py37

as we always test with ubuntu jammy, which does not provide python3.7:

py37: skipped because could not find python interpreter with spec(s): py37

so there is no point testing with python3.7.

also, in tox v4, it is not able to handle "key = value" anymore, where
value has newlines in it. so we need to find a better way passing
command line options to the test command.

this change partially reverts 2dd86c9e3eca6e14a04a821edf3a654f31da7a21

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

cmake: temporarily disable py3 test

py3 tries to import all python modules to ensure that they are
python3 compatible. but the installation fails on jenkins test node:

  Resolved https://github.com/ceph/teuthology.git to commit 4da97cf64e542f347ec47b7bdbe5eca99759f9b7
  Installing build dependencies: started
  error: subprocess-exited-with-error

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #48375 from lbausch/mgr/balancer-fix_end_weekday_being_exclusive

mgr/balancer: Fix `end_weekday` being exclusive

Reviewed-by: Laura Flores <lflores@redhat.com>

Merge pull request #48318 from gregsfortytwo/wip-17170

osd: mds: suggest clock skew when failing to obtain rotating service keys

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>

qa: add pytest to deps of py3 env

otherwise it is mising when running test, and we'd have following
failure:

py3: exit 2 (0.00 seconds) /home/jenkins-build/build/workspace/ceph-pull-requests/qa> pytest --assert=plain test_import.py

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

qa: set locale to C.UTF-8 in tox.ini

as ansible is using UTF-8 encoded characters in the file names, so,
to avoid failures like:

  File "/home/jenkins-build/build/workspace/ceph-pull-requests/qa/.tox/py3/lib/python3.10/site-packages/pip/_internal/utils/unpacking.py", line 217, in untar_file
    with open(path, "wb") as destfp:
UnicodeEncodeError: 'latin-1' codec can't encode characters in position 137-140: ordinal not in range(256)

we have to set a locale which is able to handle UTF-8.

see also https://github.com/ceph/teuthology/pull/1671

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #49236 from yuvalif/wip-yuval-missing-init

rgw/notification: initialize member in reservation ctor

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #49290 from inspur-wyq/wip-rgw-svc-doc

src/rgw/services/svc_finisher.cc: fix typos

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #49322 from tchaikov/wip-allowlist_externals

*: s/whitelist_externals/allowlist_externals/

Reviewed-by: Adam King <adking@redhat.com>

pybind/mgr: drop cython from requires

cython is not required for running tox commands.

this should address the test failure like:

ROOT: will run in automatically provisioned tox, host /home/jenkins-build/build/workspace/ceph-pull-requests/build/mgr-virtualenv/bin/python3.10 is missing [requires (has)]: cython

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

cephadm: drop cython from requires

cython is not required for launching the tox environment.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

*: s/whitelist_externals/allowlist_externals/

as allowlist_externals was introduced in
tox v4.0. see
https://github.com/tox-dev/tox/commit/5e33fda1a40ffb4973de3d607a572891eb3cb2d2 , but
this option was backported to 3.18 as an alias of whitelist_externals, so we don't need
to specify the minversion to 4.0 in this change.

as we started using tox 4.0 and up (v4.0.2 in specific). tox complains
and fails like:

alerts-lint: failed with promtool is not allowed, use allowlist_externals to allow it
  alerts-lint: FAIL code 1 (9.25 seconds)

see https://tox.wiki/en/latest/faq.html#tox-4-removed-tox-ini-keys
and https://tox.wiki/en/latest/config.html#allowlist_externals

it'd be nice to use a more inclusive language also. so, in this change,
s/whitelist_externals/allowlist_externals/ in all tox.ini in this
project.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #49306 from zdover23/wip-doc-2022-12-08-rbd-rados-rbd-cmds-create-a-block-device-user-semantics

doc/rbd: refine "Create a Block Device User"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #49288 from BryceCao/wip-update-doc-ubuntu-deps-install

doc/start: update "apt install" command in documenting-ceph.rst

doc/start: update "apt install" command in documenting-ceph.rst

Signed-off-by: caolei <cao.leilc@inspur.com>

doc/rbd: refine "Create a Block Device User"

Refine "Create a Block Device User", after suggestions made by Ilya
Dryomov in https://github.com/ceph/ceph/pull/49301#pullrequestreview-1208285685

https://tracker.ceph.com/issues/57001

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #48943 from yaarith/fix-telemetry-ident

qa/workunits: identify ceph test clusters

Merge pull request #49121 from tchaikov/wip-cmake-cares

cmake: add c-ares::cares as a global visible library

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #48679 from cfsnyder/wip-rgw-multi-obj-del-perf

rgw: concurrency for multi object deletes

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #48265 from pdvian/wip-fix-mmgrupdate

mon: Fix condition to check for ceph version mismatch

Reviewed-by: Laura Flores <lflores@redhat.com>

Merge pull request #48138 from sseshasa/wip-fix-osd-bench

osd: Randomize osd bench buffer data before submitting to objectstore

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>

Merge pull request #48136 from shreyanshjain7174/fix_versions

 mon: remove empty list entries from ceph versions

Reviewed-by: Prashant D <pdhange@redhat.com>

Merge pull request #49282 from zdover23/wip-doc-2022-12-06-rbd-rados-rbd-cmds-create-a-block-device-pool-semantics

doc/rbd: refine "Create a Block Device Pool"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>

Merge pull request #49293 from BryceCao/wip-fix-rgw.yaml.in-spelling-mistake

src/common/options/rgw.yaml.in: fix spelling mistake

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #47708 from rkachach/fix_issue_57160

mgr/rgw: adding support for rgw multisite

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Ali Maredia <amaredia@redhat.com>

Merge pull request #48074 from adk3798/client-removal-fixing

mgr/cephadm: write client files after applying services

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #48213 from adk3798/migration-too-high

mgr/cephadm: don't say migration in progress if migration current > migration last

Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #48304 from rhcs-dashboard/iscsi-default-user-pwd

mgr/cephadm: iscsi username and password defaults to admin

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #49127 from Matan-B/wip-matanb-c-seq_mode_t

crimson/osd/osd_operations/client_request: Remove seq_mode_t

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #48306 from alimaredia/wip-ceph-adm-force-asok-removal

cephadm: force .asok file removal after daemon stoppage

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>

Merge pull request #48389 from adk3798/staggered-start-update

qa/cephadm: update staggered upgrade test to use --image when redeploying mgr

Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #48391 from adk3798/iscsi-ports

mgr/cephadm: specify ports for iscsi

Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #48489 from rkachach/fix_issue_57816

mgr/cephadm: making grafana protocol configurable

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #48507 from rkachach/fix_issue_57876

mgr/prometheus: fix module crash when trying to collect OSDs metrics

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #48517 from adk3798/active-mgr-redeploy

mgr/cephadm: save host cache data after scheduling daemon action

Reviewed-by: Michael Fritch <mfritch@suse.com>

doc/rbd: refine "Create a Block Device Pool"

Refine the "Create a Block Device Pool" section of
doc/rbd/rados-rbd-cmds.rst.

https://tracker.ceph.com/issues/57001

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #49283 from zdover23/wip-doc-2022-12-06-rbd-rados-rbd-cmds-create-a-block-device-user-semantics

doc/rbd: refine "Create a Block Device User"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

src/common/options/rgw.yaml.in: fix spelling mistake

Signed-off-by: caolei <cao.leilc@inspur.com>

Merge pull request #49155 from joscollin/wip-cephfs-top-doc-update-filters

doc: updated doc for Filters

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>

Merge pull request #49257 from ktdreyer/doc-createfs-syntax

doc/cephfs: monospace "ceph fs set-default" command

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/rbd: refine "Create a Block Device User"

Refine "Create a Block Device User" in doc/rbd/rados-rbd-cmds.rst.

https://tracker.ceph.com/issues/57001

Signed-off-by: Zac Dover <zac.dover@gmail.com>

src/rgw/services/svc_finisher.cc: fix typos

Signed-off-by: wangyunqing <wangyunqing@inspur.com>

doc/cephfs: monospace "ceph fs set-default" command

Fix the rst syntax here to make this command match everything else.

Signed-off-by: Ken Dreyer <kdreyer@redhat.com>

Merge pull request #48296 from Matan-B/wip-matanb-no-history-cleanup

osd/OSD.cc: handle_fast_pg_create cleanup

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #49260 from ceph/core-label

.github: add core label to files under src/test/librados

Merge pull request #49270 from zdover23/wip-doc-2022-12-05-rados-placment-groups-3-of-3-prompts

doc/rados: add prompts to placement-groups.rst (3)

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

Merge pull request #49269 from zdover23/wip-doc-2022-12-05-rados-placment-groups-2-of-3-prompts

doc/rados: add prompts to placement-groups.rst

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

Merge pull request #49268 from zdover23/wip-doc-2022-12-05-rados-placment-groups-1-of-3-prompts

doc/rados: add prompts to placement-groups.rst

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

doc/rados: add prompts to placement-groups.rst (3)

Add unselectable prompts to doc/rados/operations/placement-groups.rst (3
of 3).

https://tracker.ceph.com/issues/57108

Signed-off-by: Zac Dover <zac.dover@gmail.com>

doc/rados: add prompts to placement-groups.rst

Add unselectable prompts to doc/rados/operations/placement-groups.rst.
(2 of 3)

https://tracker.ceph.com/issues/57108

Signed-off-by: Zac Dover <zac.dover@gmail.com>

doc/rados: add prompts to placement-groups.rst

Add unselectable prompts to doc/rados/operations/placement-groups.rst.

https://tracker.ceph.com/issues/57108

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #49264 from zdover23/wip-doc-2022-12-06-glossary-rbd

doc/glossary: add matter to "RBD"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #48628 from lxbsz/kclient_fscrypt

qa: cephfs add fscrypt test suite support for kclient

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>

doc/glossary: add matter to "RBD"

Clarify that "RBD" and "Ceph Block Device" and "RADOS Block Device" all
refer to the same thing.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #48223 from myoungwon/wip-fix-tier-evict-range

osd: mark modified region as dirty when tier-evict is called

Merge pull request #48467 from baergj/fix-read-error-code

blk/kernel: Fix error code mapping in KernelDevice::read.

Reviewed-by: Robin H. Johnson <robbat2@orbis-terrarum.net>
Reviewed-by: Igor Fedotov <igor.fedotov@croit.io>

.github: add core label to files under src/test/librados

In response to https://tracker.ceph.com/issues/58173, it would have helped to have the PR label librados test files with core, so the PR would have been tagged for rados qa.

Signed-off-by: Laura Flores <lflores@redhat.com>

Merge pull request #48817 from adk3798/device-refresh-message

mgr/cephadm: fix check for if devices have changed

Reviewed-by: Redouane Kachach <rkachach@redhat.com>

Merge pull request #48874 from senax/ingress_backend_ssl

mgr/cephadm: add ingress support for ssl rgw service

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>

Merge pull request #48899 from ivancich/wip-fix-old-shard

rgw: address bug where object puts could write to decommissioned shard

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #48585 from cbodley/wip-test-librados-asio-spawn

test/librados: use spawn submodule instead of boost::asio::spawn

Reviewed-by: Adam Emerson <aemerson@redhat.com>

Merge pull request #48708 from sseshasa/wip-fix-osd-capacity-display

osd: Reset mClock's OSD capacity config option for inactive device type

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>

Merge pull request #48623 from batrick/i57923

log: use non-blocking atomic writes to stderr fifos

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #48513 from ideepika/wip-crush-debug

src/crush: extra logging to debug CPU burn in test_with_fork()

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #49253 from kvanals/update-board-softiron

doc: Update Foundation member for SoftIron

Merge pull request #48618 from idryomov/rbd-clone-encryption-part2

 librbd: add encryption format support for clones (part 2/2)

Reviewed-by: Mykola Golub <mgolub@suse.com>
Acked-by: Or Ozeri <oro@il.ibm.com>

Merge pull request #49252 from zdover23/wip-doc-2022-12-05-glossary-das

doc/glossary: add DAS

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/glossary: add DAS

Add a definition for "DAS" (directly attached storage).

Signed-off-by: Zac Dover <zac.dover@gmail.com>

doc: Update Foundation member for SoftIron

Signed-off-by: kvanals <Kenny.VanAlstyne@softiron.com>

Merge pull request #49235 from idryomov/wip-rbd-groups-bash

qa: rbd_groups.sh: change interpreter to bash

Reviewed-by: Ramana Raja <rraja@redhat.com>

Merge pull request #49204 from Tooa/adapt_keepalived_reference

containers: use quay.io/ceph/keepalived in docs

Merge pull request #49249 from krambrod/main

doc/cephadm: fix initial-ceph.conf example

Merge pull request #49076 from Matan-B/wip-matanb-crimson-suite-adjust

crimson: Suite testing minor adjustment

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

doc/cephadm: fix initial-ceph.conf example

Signed-off-by: krambrod <114069812+krambrod@users.noreply.github.com>

Merge pull request #49241 from zdover23/wip-doc-2022-12-05-rados-ops-monitoring-prompts

doc/rados: add prompts to monitoring.rst

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

Merge pull request #49243 from zdover23/wip-doc-2022-12-05-rados-pg-repair-prompts

doc/rados: add prompts to pg-repair.rst

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

doc/rados: add prompts to pg-repair.rst

Add unselectable prompts to doc/rados/operations/pg-repair.rst.

https://tracker.ceph.com/issues/57108

Signed-off-by: Zac Dover <zac.dover@gmail.com>

doc/rados: add prompts to monitoring.rst

Add unselectable prompts to doc/rados/operations/monitoring.rst.

https://tracker.ceph.com/issues/57108

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #49238 from zdover23/wip-doc-2022-12-05-rados-ops-monitoring-osd-pg-prompts

doc/rados: add prompts to monitoring-osd-pg.rst

Reviewed-by: Cole Mtichell <cole.mitchell@gmail.com>

doc/rados: add prompts to monitoring-osd-pg.rst

Add unselectable prompts to doc/rados/operations/monitoring-osd-pg.rst.

https://tracker.ceph.com/issues/57108

Signed-off-by: Zac Dover <zac.dover@gmail.com>

qa/workunits/rbd: add encryption-aware resize test

Note that we are hitting https://tracker.ceph.com/issues/58160 here
because by the time we get to "rbd resize" RAW_DEV mapping owns the
lock (due to a write to /dev/mapper/cryptsetupdev being last).

While at it, resurrect the ability to easily run this script on
vstart clusters -- see commit f737c2855a19 ("qa/workunits/rbd: make
luks-encryption test work on vstart cluster").

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

doc/rbd: add clone encryption details and examples

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

rbd, rbd-nbd: make --encryption-format optional

If no --encryption-format specified at all, default to "luks" for each
specified --encryption-passphrase-file.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

rbd, rbd-nbd: accept "luks", "luks1" and "luks2" formats

Since RBD_ENCRYPTION_FORMAT_LUKS1, RBD_ENCRYPTION_FORMAT_LUKS2
and RBD_ENCRYPTION_FORMAT_LUKS aren't treated the same when loading
encryption anymore, "luks1" and "luks2" formats need to be accepted
in addition to "luks" format.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

librbd: don't decay LUKS{1,2}EncryptionFormat into LUKSEncryptionFormat

Commit 9892ead7fcd9 ("librbd/crypto: allow loading luks format
without specifying version") introduced RBD_ENCRYPTION_FORMAT_LUKS
format identifier, matching cryptsetup's CRYPT_LUKS ("load any LUKS
version happens to be there").  However, in an effort to enable an
obscure "layered encryption with the same passphrase + old QEMU" use
case, it also introduced decaying of RBD_ENCRYPTION_FORMAT_LUKS1 and
RBD_ENCRYPTION_FORMAT_LUKS2 format identifiers, making it impossible
to assert on the format that is being loaded.  This new behavior was
then extended to standalone images.

Treating RBD_ENCRYPTION_FORMAT_LUKS1, RBD_ENCRYPTION_FORMAT_LUKS2
and RBD_ENCRYPTION_FORMAT_LUKS the same when loading encryption can
be construed as an opening for a format downgrade attack.  Let's
resurrect the previous standalone images behavior and extend it to
layered encryption instead.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

rbd: fix passphrase zeroing in "rbd encryption format" handler

"rbd encryption format" handler sets up a scope guard to zero out
the passphrase string on return but also makes a copy of same which
isn't zeroed out.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

rbd, rbd-nbd: don't strip trailing newline in passphrase files

One of the stated goals is compatibility with standard LUKS tools,
in particular being able to load encryption on images formatted with
cryptsetup.  cryptsetup doesn't do this and this really interferes
with randomly generated (binary) passphrases.

While at it, open passphrase files as binary -- it communicates the
intent if nothing else on POSIX.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

librbd: constify specs array in rbd_encryption_load2()

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

librbd: remove unused trim_image() method

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

librbd: non-pruning parent overlap handling fixes

Apply similar "reduce overlap and respect area" logic to places
that don't use prune_parent_extents().  Changes to FlattenRequest
and TrimRequest here should complete the long tail of encrypted
I/O path and flatten fixes.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

librbd: reduce overlap and respect area when pruning parent extents

DATA area in the parent may be smaller than the part of DATA area in
the clone that is still within the overlap.  This would occur e.g. in
LUKS2-formatted parent + LUKS1-formatted clone case, due to LUKS2
header usually being bigger than LUKS1 header:

parent: raw size = 64M
        LUKS2 header area = 16M
        data area = 48M

clone:  raw size = 64M (raw overlap 64M)
        LUKS1 header area = 4M
        data area = 60M

Currently, because parent extents are pruned only according to raw
overlap (64M), the clone ends up attempting to reach the parent for all
of its data area (60M < 64M) even though the parent only has 48M worth
of data.  All kinds of bugs ensue for 48M..60M offsets and this range
basically becomes inaccessible to the user.

A related issue is that prune_parent_extents() ignores area.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

librbd: clip extents to their area instead of DATA area

This fixes cases where CRYPTO HEADER area is larger than DATA area.
In particular, it was effectively impossible to flatten unformatted
clones of such images.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>