]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Dan Mick [Tue, 15 Mar 2016 19:58:18 +0000 (12:58 -0700)]
Merge pull request #836 from ceph/wip-fix_cdtest
fix ceph-deploy test
Reviewed-by: Dan Mick <dmick@redhat.com>
Gregory Farnum [Tue, 15 Mar 2016 19:41:07 +0000 (12:41 -0700)]
Merge pull request #861 from ceph/wip-vstart-fixes
tasks/cephfs: vstart & fuse improvements
Loic Dachary [Tue, 15 Mar 2016 15:57:29 +0000 (16:57 +0100)]
Merge pull request #877 from dachary/wip-workunit
workunit: git-reset --hard does not accept a branch
Reviewed by: Nathan Cutler <ncutler@suse.com>
Loic Dachary [Tue, 15 Mar 2016 15:31:31 +0000 (16:31 +0100)]
workunit: git-reset --hard does not accept a branch
Uses git clone --branch refspec because it agrees to use either a tag or
a branch.
Signed-off-by: Loic Dachary <loic@dachary.org>
Josh Durgin [Mon, 14 Mar 2016 07:06:40 +0000 (00:06 -0700)]
Merge pull request #871 from ceph/wip-rbd-client-upgrade
upgrade/client-upgrade: only use supported features for RBD tests
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Jason Dillaman [Sun, 13 Mar 2016 20:15:43 +0000 (16:15 -0400)]
upgrade/client-upgrade: only use supported features for RBD tests
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Jason Dillaman [Sat, 12 Mar 2016 12:53:32 +0000 (07:53 -0500)]
Merge pull request #870 from ceph/wip-rbd-mirror
rbd: add some missing workunits
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Vasu Kulkarni [Sat, 12 Mar 2016 07:15:39 +0000 (02:15 -0500)]
Fix review comments
Signed-off-by: Vasu Kulkarni <vasu@redhat.com>
Jason Dillaman [Fri, 11 Mar 2016 23:36:57 +0000 (18:36 -0500)]
Merge pull request #868 from ceph/wip-fio-ver
Update fio version to 2.7
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Josh Durgin [Fri, 11 Mar 2016 22:51:16 +0000 (14:51 -0800)]
rbd: add some missing workunits
Signed-off-by: Josh Durgin <jdurgin@redhat.com>
Sage Weil [Fri, 11 Mar 2016 17:39:09 +0000 (12:39 -0500)]
Merge pull request #863 from ceph/wip-15049
rados/singleton-nomsgr/all/11429: no mds
Gregory Farnum [Fri, 11 Mar 2016 17:36:39 +0000 (09:36 -0800)]
Merge pull request #824 from ceph/wip-multi-filesystems
Test updates for multi-filesystem support
Vasu Kulkarni [Fri, 11 Mar 2016 02:08:26 +0000 (21:08 -0500)]
Update fio version to 2.7
Signed-off-by: Vasu Kulkarni <vasu@redhat.com>
John Spray [Thu, 18 Feb 2016 14:10:30 +0000 (14:10 +0000)]
tasks/cephfs: enable multi fs flag
Cluster won't let you create more than without
setting this flag explicitly.
Signed-off-by: John Spray <john.spray@redhat.com>
John Spray [Wed, 13 Jan 2016 10:16:40 +0000 (10:16 +0000)]
tasks/cephfs: debug in wait_for_daemons
Signed-off-by: John Spray <john.spray@redhat.com>
John Spray [Wed, 13 Jan 2016 10:16:18 +0000 (10:16 +0000)]
tasks/cephfs: switch off extra daemons in TestStrays
Signed-off-by: John Spray <john.spray@redhat.com>
John Spray [Mon, 11 Jan 2016 19:43:40 +0000 (19:43 +0000)]
tasks/cephfs: further thrasher fixes
Move the thrasher-specific methods out of CephManager
into MDSThrasher and plumb them into MDSCluster.
Signed-off-by: John Spray <john.spray@redhat.com
John Spray [Mon, 11 Jan 2016 13:23:11 +0000 (13:23 +0000)]
tasks/cephfs: simplify recreate()
Signed-off-by: John Spray <john.spray@redhat.com>
John Spray [Mon, 11 Jan 2016 12:59:44 +0000 (12:59 +0000)]
tasks/cephfs: update test_journal_repair for multi fs
Signed-off-by: John Spray <john.spray@redhat.com>
John Spray [Mon, 11 Jan 2016 12:19:03 +0000 (12:19 +0000)]
tasks/cephfs: add TestStandbyReplay
In addition to the multi-fs tests, more localised
standby-replay cases.
Signed-off-by: John Spray <john.spray@redhat.com>
John Spray [Mon, 11 Jan 2016 12:18:20 +0000 (12:18 +0000)]
suites: add fs/multifs
Separate because it wants a larger MDS count. Points
to the new tests in test_failover.py.
Signed-off-by: John Spray <john.spray@redhat.com>
John Spray [Sun, 10 Jan 2016 15:51:48 +0000 (15:51 +0000)]
tasks/cephfs: fix datascan for multiple filesystems
Signed-off-by: John Spray <john.spray@redhat.com>
John Spray [Fri, 8 Jan 2016 18:20:29 +0000 (18:20 +0000)]
tasks/cephfs: move the journaltool smoke test into python land
This is one of those things that had a convoluted .yaml file
because it predated the ability to write explicit procedural
python tests.
Signed-off-by: John Spray <john.spray@redhat.com>
John Spray [Fri, 8 Jan 2016 17:59:35 +0000 (17:59 +0000)]
tasks/cephfs: rename Filesystem.reset to recreate
Name was ambiguous wrt "fs reset"
Signed-off-by: John Spray <john.spray@redhat.com>
John Spray [Fri, 8 Jan 2016 10:23:20 +0000 (10:23 +0000)]
tasks: fix mds_thrash for multi filesystems
Signed-off-by: John Spray <john.spray@redhat.com>
John Spray [Fri, 8 Jan 2016 09:49:36 +0000 (09:49 +0000)]
tasks/cephfs: update test_runner for mds_cluster
Signed-off-by: John Spray <john.spray@redhat.com>
John Spray [Sun, 3 Jan 2016 18:35:17 +0000 (18:35 +0000)]
tasks: generalise cephfs classes for multi-fs
Signed-off-by: John Spray <john.spray@redhat.com>
John Spray [Sun, 3 Jan 2016 18:34:54 +0000 (18:34 +0000)]
tasks: add cephfs TestMultiFilesystems
Signed-off-by: John Spray <john.spray@redhat.com>
vasukulkarni [Fri, 11 Mar 2016 02:59:04 +0000 (18:59 -0800)]
Merge pull request #865 from ceph/wip-dbg-packages-1
packages: update for all the new debug packages we have in jewel
Greg Farnum [Thu, 10 Mar 2016 23:13:19 +0000 (15:13 -0800)]
packages: update for all the new debug packages we have in jewel
Signed-off-by: Greg Farnum <gfarnum@redhat.com>
Gregory Farnum [Thu, 10 Mar 2016 22:04:22 +0000 (14:04 -0800)]
Merge pull request #859 from ceph/wip-15014
Add packages.yaml
Yuri Weinstein [Thu, 10 Mar 2016 21:11:16 +0000 (13:11 -0800)]
Removed branch: firefly from 4-after.yaml
Fixes #15012
Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
(cherry picked from commit
872aed9e72d0bac1fc21152544eef3c42abbd0bb )
Sage Weil [Thu, 10 Mar 2016 17:06:21 +0000 (12:06 -0500)]
rados/singleton-nomsgr/all/11429: no mds
The newer cephfs logic wants to use the 'status' command on the
daemon, but that doesn't exist on firefly. Luckly we don't need
it for this test.
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Thu, 10 Mar 2016 16:23:52 +0000 (11:23 -0500)]
Merge pull request #862 from ceph/wip-odsync
rados: Enable odsync write for pggrow thrasher
Samuel Just [Wed, 2 Mar 2016 07:01:06 +0000 (23:01 -0800)]
rados: Enable odsync write for pggrow thrasher
Signed-off-by: Samuel Just <sjust@redhat.com>
John Spray [Thu, 10 Mar 2016 12:27:44 +0000 (12:27 +0000)]
tasks/cephfs: vstart & fuse improvements
A couple of corner cases that would get tripped up sometimes
in a vstart_runner.py environment.
Signed-off-by: John Spray <john.spray@redhat.com>
Greg Farnum [Thu, 10 Mar 2016 06:29:34 +0000 (22:29 -0800)]
Merge remote-tracking branch 'origin/greg-fs-testing-3-7-damage'
Gregory Farnum [Thu, 10 Mar 2016 06:31:21 +0000 (22:31 -0800)]
Merge pull request #731 from ceph/wip-scrub-repair
Wip scrub repair
Josh Durgin [Thu, 10 Mar 2016 00:37:16 +0000 (16:37 -0800)]
Merge pull request #860 from ceph/wip-krbd-fio
Fixes for krbd test cases
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Zack Cerza [Wed, 9 Mar 2016 21:21:55 +0000 (14:21 -0700)]
Reflect that ceph-dbg is dropped
Signed-off-by: Zack Cerza <zack@redhat.com>
Zack Cerza [Wed, 9 Mar 2016 21:18:40 +0000 (14:18 -0700)]
Add packages.yaml
Signed-off-by: Zack Cerza <zack@redhat.com>
Vasu Kulkarni [Sat, 27 Feb 2016 04:16:10 +0000 (20:16 -0800)]
Fix recent failures due to HEALTH_WARN check issues
There were recent failures due to HEALTH_WARN check unrelated
to script, this fix basically bypasses this issue by using
osd pool default size: 1 in ceph.conf and now
checks for HEALTH_OK instead of HEALTH_WARN
It also adds the meta information to tasks which describes test
Signed-off-by: Vasu Kulkarni <vasu@redhat.com>
Sage Weil [Tue, 8 Mar 2016 16:14:55 +0000 (11:14 -0500)]
rados/thrash/workloads/radosbench: shorten 300s->200s
Signed-off-by: Sage Weil <sage@redhat.com>
Greg Farnum [Tue, 8 Mar 2016 00:31:35 +0000 (16:31 -0800)]
Merge remote-tracking branch 'origin/wip-damage-table' into greg-fs-testing
https://github.com/ceph/ceph-qa-suite/pull/782
Conflicts:
tasks/cephfs/test_scrub_checks.py
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Greg Farnum [Tue, 8 Mar 2016 00:20:37 +0000 (16:20 -0800)]
Merge remote-tracking branch 'origin/wip-scrub-repair' into greg-fs-testing
https://github.com/ceph/ceph-qa-suite/pull/731
Jason Dillaman [Mon, 7 Mar 2016 18:59:13 +0000 (13:59 -0500)]
krbd: do not test unsupported striping feature
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Jason Dillaman [Mon, 7 Mar 2016 18:57:32 +0000 (13:57 -0500)]
tasks/rbd_fio: create sane image name based on feature set
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Zack Cerza [Mon, 7 Mar 2016 18:18:55 +0000 (11:18 -0700)]
Merge pull request #858 from ceph/wip-pg-dump
tasks/ceph_manager: dump pgs if other peering timeouts expire
Sage Weil [Mon, 7 Mar 2016 17:21:10 +0000 (12:21 -0500)]
tasks/ceph_manager: dump pgs if other peering timeouts expire
We were doing this for one of the recovery timeouts but not all of them.
Signed-off-by: Sage Weil <sage@redhat.com>
Yuri Weinstein [Sun, 6 Mar 2016 19:51:39 +0000 (11:51 -0800)]
Merge pull request #857 from smithfarm/wip-move-plus-to-clusters
suites/smoke/1node: move + to clusters/ subdirectory
Nathan Cutler [Sun, 6 Mar 2016 18:31:08 +0000 (19:31 +0100)]
suites/smoke/1node: move + to clusters/ subdirectory
Signed-off-by: Nathan Cutler <ncutler@suse.com>
Loic Dachary [Fri, 4 Mar 2016 02:22:53 +0000 (09:22 +0700)]
Merge pull request #854 from SUSE/wip-opensuse-distros
distros: add yaml fragments for openSUSE 13.2 and 42.1
Reviewed-by: Loic Dachary <ldachary@redhat.com>
John Spray [Tue, 23 Feb 2016 17:32:30 +0000 (17:32 +0000)]
tasks: add TestDamage.test_damaged_dentry
A more detailed test for the case of damaged dentries,
because the handling involves the system passing through
a state where the containing dir has invalid stats,
and has the complete flag set even though the
dentry in question is missing.
Signed-off-by: John Spray <john.spray@redhat.com>
John Spray [Thu, 7 Jan 2016 16:51:27 +0000 (16:51 +0000)]
suites: update log whitelist for TestDamage
For branch wip-damage-table.
Signed-off-by: John Spray <john.spray@redhat.com>
John Spray [Tue, 8 Dec 2015 16:29:11 +0000 (16:29 +0000)]
tasks/cephfs: update TestDamage
...to account for the behavioural changes with
the addition of DamageTable.
Signed-off-by: John Spray <john.spray@redhat.com>
John Spray [Tue, 15 Dec 2015 11:40:31 +0000 (11:40 +0000)]
tasks: move wait_for_health up into CephFSTestCase
...so that TestDamage can use it too.
Signed-off-by: John Spray <john.spray@redhat.com>
John Spray [Mon, 14 Dec 2015 22:13:13 +0000 (22:13 +0000)]
tasks/cephfs: optionally stat() in background
Signed-off-by: John Spray <john.spray@redhat.com>
John Spray [Tue, 28 Jul 2015 10:28:18 +0000 (11:28 +0100)]
tasks/cephfs: avoid sleep in test_client_cache_size
Instead of waiting 30s and then checking, use
wait_until_true to complete as soon as the
condition is met. Test runs faster this way.
Signed-off-by: John Spray <john.spray@redhat.com>
John Spray [Tue, 28 Jul 2015 10:22:46 +0000 (11:22 +0100)]
tasks/cephfs: remove extraneous ;s in test_client_limits
These are harmless but they stand out in some editors.
Signed-off-by: John Spray <john.spray@redhat.com>
Yan, Zheng [Wed, 25 Nov 2015 12:45:16 +0000 (20:45 +0800)]
tasks/cephfs: add test case for scrub repair
Signed-off-by: Yan, Zheng <zyan@redhat.com>
Nathan Cutler [Thu, 3 Mar 2016 21:44:36 +0000 (22:44 +0100)]
distros: add yaml fragments for openSUSE 13.2 and 42.1
Signed-off-by: Nathan Cutler <ncutler@suse.com>
Sage Weil [Thu, 3 Mar 2016 13:23:55 +0000 (08:23 -0500)]
Merge remote-tracking branch 'gh/wip-file-layout'
Sage Weil [Thu, 3 Mar 2016 13:23:49 +0000 (08:23 -0500)]
Merge remote-tracking branch 'gh/jewel'
Yuri Weinstein [Thu, 3 Mar 2016 01:06:52 +0000 (17:06 -0800)]
Merge pull request #852 from ceph/wip-ceph-ansible
ceph-ansible: Add openstack hints for volumes
Zack Cerza [Wed, 2 Mar 2016 23:34:24 +0000 (16:34 -0700)]
ceph-ansible: Add openstack hints for volumes
3x20GB per instance
Signed-off-by: Zack Cerza <zack@redhat.com>
Yuri Weinstein [Wed, 2 Mar 2016 16:16:57 +0000 (08:16 -0800)]
Merge pull request #851 from ceph/wip-ceph-ansible
ceph-ansible: Install ceph-test
Yuri Weinstein [Tue, 1 Mar 2016 21:58:44 +0000 (13:58 -0800)]
Merge pull request #848 from ceph/wip-ceph-ansible
ceph-ansible suite improvements
Zack Cerza [Tue, 1 Mar 2016 21:58:34 +0000 (14:58 -0700)]
Install ceph-test
Signed-off-by: Zack Cerza <zack@redhat.com>
Zack Cerza [Tue, 1 Mar 2016 19:49:34 +0000 (12:49 -0700)]
Disable rbd_cli_tests for now
They don't seem to ever fail.
Signed-off-by: Zack Cerza <zack@redhat.com>
Zack Cerza [Tue, 1 Mar 2016 19:47:53 +0000 (12:47 -0700)]
Add ceph-deploy_hello_world.sh
Signed-off-by: Zack Cerza <zack@redhat.com>
Samuel Just [Tue, 1 Mar 2016 16:47:22 +0000 (08:47 -0800)]
Merge pull request #843 from ceph/wip-list-inconsistent-obj
tasks/scrub_test: match the NOSNAP with "head"
Reviewed-by: Samuel Just <sjust@redhat.com>
Sage Weil [Sat, 30 Jan 2016 18:51:00 +0000 (13:51 -0500)]
suites/fs/verify: debug mon too
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Sat, 30 Jan 2016 18:46:21 +0000 (13:46 -0500)]
tasks/cephfs/filesystem: ceph_file_layout -> file_layout_t
Signed-off-by: Sage Weil <sage@redhat.com>
Jason Dillaman [Tue, 1 Mar 2016 13:09:01 +0000 (08:09 -0500)]
Merge pull request #844 from ceph/wip-rbd-cli-features
rbd/cli: add older default features
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Loic Dachary [Tue, 1 Mar 2016 07:50:41 +0000 (14:50 +0700)]
Merge pull request #846 from dachary/wip-14931-cram
cram: pin to version 0.6 because 0.7 handles \r differently
Reviewed-by: Xiaoxi Chen <xiaoxchen@ebay.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Loic Dachary [Tue, 1 Mar 2016 06:54:07 +0000 (13:54 +0700)]
cram: pin to version 0.6 because 0.7 handles \r differently
http://tracker.ceph.com/issues/14931 Fixes: #14931
Signed-off-by: Loic Dachary <loic@dachary.org>
Kefu Chai [Tue, 1 Mar 2016 01:13:52 +0000 (09:13 +0800)]
tasks/scrub_test: match the NOSNAP with "head"
* rados cli prints "head" at seeing CEPH_NOSNAP, so update the test
accordingly
* print inconsistent objs before testing them
Fixes: #14924
Signed-off-by: Kefu Chai <kchai@redhat.com>
Josh Durgin [Tue, 1 Mar 2016 05:55:39 +0000 (21:55 -0800)]
rbd/cli: add older default features
Explicitly set features and default format so they don't become out of
date. Remove none.yaml, since default.yaml is an explicit version of
it now.
Signed-off-by: Josh Durgin <jdurgin@redhat.com>
Josh Durgin [Tue, 1 Mar 2016 02:26:14 +0000 (18:26 -0800)]
Merge pull request #842 from ceph/wip-rbd-features
rbd: updated tests to use new rbd default feature set
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Josh Durgin [Tue, 1 Mar 2016 02:20:30 +0000 (18:20 -0800)]
Merge pull request #841 from ceph/wip-krbd-default-features
krbd: override rbd defaults features to 1
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Josh Durgin [Tue, 1 Mar 2016 02:18:22 +0000 (18:18 -0800)]
Merge pull request #821 from ceph/wip-fsx-journal
rbd: add fsx journal replay test case
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Zack Cerza [Tue, 1 Mar 2016 00:19:51 +0000 (17:19 -0700)]
Make the keyring world-readable
Signed-off-by: Zack Cerza <zack@redhat.com>
Zack Cerza [Mon, 29 Feb 2016 23:44:25 +0000 (16:44 -0700)]
Rename mon.0 to mon.a
Signed-off-by: Zack Cerza <zack@redhat.com>
Zack Cerza [Mon, 29 Feb 2016 21:37:10 +0000 (14:37 -0700)]
Run 'ceph health' after deployment
Signed-off-by: Zack Cerza <zack@redhat.com>
Samuel Just [Mon, 29 Feb 2016 23:53:12 +0000 (15:53 -0800)]
Merge pull request #832 from athanatos/wip-lost
Wip lost
Reviewed-by: Sage Weil <sage@redhat.com>
Yuri Weinstein [Mon, 29 Feb 2016 21:17:12 +0000 (13:17 -0800)]
Merge pull request #839 from ceph/wip-ceph-ansible
Add ceph-ansible suite
Jason Dillaman [Mon, 29 Feb 2016 14:16:27 +0000 (09:16 -0500)]
rbd: updated tests to use new rbd default feature set
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Jason Dillaman [Mon, 29 Feb 2016 13:42:22 +0000 (08:42 -0500)]
krbd: override rbd defaults features to 1
Jewel will update the default feature set to features
unsupported by krbd.
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Vasu Kulkarni [Sat, 27 Feb 2016 04:10:52 +0000 (20:10 -0800)]
Fix old and new pep8 issues
Signed-off-by: Vasu Kulkarni <vasu@redhat.com>
Zack Cerza [Fri, 19 Feb 2016 16:19:35 +0000 (09:19 -0700)]
Add ceph-ansible suite
Signed-off-by: Zack Cerza <zack@redhat.com>
Zack Cerza [Fri, 26 Feb 2016 15:38:49 +0000 (08:38 -0700)]
Merge pull request #837 from ceph/wip-valgrind
suites: debuginfo: true for valgrind
Sage Weil [Fri, 26 Feb 2016 15:01:53 +0000 (10:01 -0500)]
Merge pull request #833 from ceph/wip-async
Revert "basic/msgr: remove async and random for now"
Sage Weil [Fri, 26 Feb 2016 14:46:27 +0000 (09:46 -0500)]
suites: debuginfo: true for valgrind
This lets us get line numbers in the valgrind xml output.
Signed-off-by: Sage Weil <sage@redhat.com>
Kefu Chai [Thu, 25 Feb 2016 04:51:17 +0000 (12:51 +0800)]
Merge pull request #795 from ceph/wip-list-inconsistent-obj
task/scrub_test: tests for list inconsistent obj APIs
Reviewed-by: Samuel Just <sjust@redhat.com>
Yuri Weinstein [Wed, 24 Feb 2016 21:28:51 +0000 (13:28 -0800)]
Reduced runtime for radosbench to 600
Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
(cherry picked from commit
a72bba29103cd287131eb7b56953c417649fed5d )
Yuri Weinstein [Wed, 24 Feb 2016 21:31:20 +0000 (13:31 -0800)]
Merge pull request #835 from ceph/wip-14810-master-2
Reduced runtime for radosbench to 600
Yuri Weinstein [Wed, 24 Feb 2016 21:28:51 +0000 (13:28 -0800)]
Reduced runtime for radosbench to 600
Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
Yan, Zheng [Wed, 25 Nov 2015 12:45:16 +0000 (20:45 +0800)]
tasks/cephfs: add test case for scrub repair
Signed-off-by: Yan, Zheng <zyan@redhat.com>
Kefu Chai [Tue, 16 Feb 2016 10:40:27 +0000 (18:40 +0800)]
tasks/scrub_test: add test for get-inconsistent-* commands
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 22 Feb 2016 07:04:49 +0000 (15:04 +0800)]
tasks/scrub_test: restore the changes to omap after the test
because the repair for digest mismatch will rewrite the omap digest
in the corresponding OI attribute with the one calculated from the
omap read from disk. this is fine. but the succeeding test can not
use the same way used before to mess up the victim object in hope
to get an inconsistent object, as we have accepted it as an authroized
copy and populate the change to its replicas. to address this
problem, the crime scene of the `test_repair_bad_omap()` is cleaned
up before calling `repair()`. it helps with isolating the different
tests, so new tests should not worry about what the current omap
should look like.
Signed-off-by: Kefu Chai <kchai@redhat.com>