]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
5 months agoMerge pull request #61133 from cbodley/wip-69298-reef
Yuri Weinstein [Mon, 27 Jan 2025 18:35:57 +0000 (10:35 -0800)]
Merge pull request #61133 from cbodley/wip-69298-reef

reef: rgw/abortmp: Race condition on AbortMultipartUpload

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
5 months agoMerge pull request #61105 from cbodley/wip-69259-reef
Yuri Weinstein [Mon, 27 Jan 2025 18:35:17 +0000 (10:35 -0800)]
Merge pull request #61105 from cbodley/wip-69259-reef

reef: <common> fix formatter buffer out-of-bounds

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
5 months agoMerge pull request #61022 from cbodley/wip-69180-reef
Yuri Weinstein [Mon, 27 Jan 2025 18:32:03 +0000 (10:32 -0800)]
Merge pull request #61022 from cbodley/wip-69180-reef

reef: qa/rgw: bump keystone/barbican from 2023.1 to 2024.1

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
5 months agoMerge pull request #60977 from cbodley/wip-69147-reef
Yuri Weinstein [Mon, 27 Jan 2025 18:30:35 +0000 (10:30 -0800)]
Merge pull request #60977 from cbodley/wip-69147-reef

reef: test/rgw/multisite: add meta checkpoint after bucket creation

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
5 months agoMerge pull request #61458 from aaSharma14/wip-69597-reef
afreen23 [Mon, 27 Jan 2025 06:40:34 +0000 (12:10 +0530)]
Merge pull request #61458 from aaSharma14/wip-69597-reef

reef: mgr/dashboard: fix total objects/Avg object size in RGW Overview Page

Reviewed-by: Afreen Misbah <afreen@ibm.com>
5 months agoMerge pull request #61038 from rhcs-dashboard/wip-69194-reef
Nizamudeen A [Mon, 27 Jan 2025 06:19:52 +0000 (11:49 +0530)]
Merge pull request #61038 from rhcs-dashboard/wip-69194-reef

reef: mgr/dashboard: add a custom warning message when enabling feature

Reviewed-by: Afreen Misbah <afreen@ibm.com>
5 months agoMerge pull request #61236 from aaSharma14/wip-69222-reef
afreen23 [Mon, 27 Jan 2025 05:29:52 +0000 (10:59 +0530)]
Merge pull request #61236 from aaSharma14/wip-69222-reef

reef: mgr/dashboard: Update and correct zonegroup delete notification

Reviewed-by: Afreen Misbah <afreen@ibm.com>
5 months agoMerge pull request #61529 from zdover23/wip-doc-2025-01-27-backport-61525-to-reef
Anthony D'Atri [Sun, 26 Jan 2025 18:02:21 +0000 (13:02 -0500)]
Merge pull request #61529 from zdover23/wip-doc-2025-01-27-backport-61525-to-reef

reef: doc/cephadm: correct note

5 months agodoc/cephadm: correct note 61529/head
Zac Dover [Sun, 26 Jan 2025 05:11:16 +0000 (15:11 +1000)]
doc/cephadm: correct note

Correct the English in a note in doc/cephadm/host-management.rst.

This commit was made in response to
https://github.com/ceph/ceph/pull/50340, which corrected some of this
note in Quincy.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit d15f1f6869465a8cc3191169f038217baecf2c4f)

5 months agoMerge pull request #61522 from zdover23/wip-doc-2025-01-26-backport-61503-to-reef
Zac Dover [Sun, 26 Jan 2025 02:19:44 +0000 (12:19 +1000)]
Merge pull request #61522 from zdover23/wip-doc-2025-01-26-backport-61503-to-reef

reef: doc/cephfs: edit disaster-recovery-experts (6 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
5 months agoMerge pull request #61524 from zdover23/wip-doc-2025-01-26-backport-61520-to-reef
Ilya Dryomov [Sat, 25 Jan 2025 20:43:43 +0000 (21:43 +0100)]
Merge pull request #61524 from zdover23/wip-doc-2025-01-26-backport-61520-to-reef

reef: doc/rados: pool and namespace are independent osdcap restrictions

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
5 months agodoc/rados: pool and namespace are independent osdcap restrictions 61524/head
Ilya Dryomov [Sat, 25 Jan 2025 10:11:14 +0000 (11:11 +0100)]
doc/rados: pool and namespace are independent osdcap restrictions

For the "profile {name}" syntax, pool and namespace restrictions are
independent of each other (i.e. specifying namespace doesn't also
require specifying pool like is currently suggested).  A cap can look
like "profile rbd namespace=myns", signifying that the RBD profile is
to be allowed in myns namespace of any pool.

For the "allow {access-spec}" syntax, pool restriction is optional.
A cap can look like "allow r namespace=myns", "allow w object_prefix
myprefix" or "allow rw namespace=myns object_prefix myprefix", for
example.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 67f5769ce6e110b89362763cfb41a0e00e595cdf)

5 months agodoc/cephfs: edit disaster-recovery-experts (6 of x) 61522/head
Zac Dover [Fri, 24 Jan 2025 13:46:19 +0000 (23:46 +1000)]
doc/cephfs: edit disaster-recovery-experts (6 of x)

In doc/cephfs/disaster-recovery-experts.rst, incorporate Anthony's
suggestions in

https://github.com/ceph/ceph/pull/61462#discussion_r1923917812
and
https://github.com/ceph/ceph/pull/61462#discussion_r1923920724

and reword the sentences in the section "Using an alternate metadata
pool for recovery" to be in the imperative mood, which better suits the
ordered list format that was introduced in
https://github.com/ceph/ceph/pull/61493.

Follows https://github.com/ceph/ceph/pull/61493.

https://tracker.ceph.com/issues/69557

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 5670054bd0533c8f2507d0596797214da8ba489a)

5 months agoMerge pull request #61102 from ivancich/wip-69255-reef
J. Eric Ivancich [Fri, 24 Jan 2025 16:13:23 +0000 (11:13 -0500)]
Merge pull request #61102 from ivancich/wip-69255-reef

reef: qa/rgw: pull Apache artifacts from mirror instead of archive.apache.org

Reviewed-by: Casey Bodley <cbodley@redhat.com>
5 months agoMerge pull request #61054 from smanjara/wip-69211-reef
J. Eric Ivancich [Fri, 24 Jan 2025 16:11:11 +0000 (11:11 -0500)]
Merge pull request #61054 from smanjara/wip-69211-reef

reef: qa/rgw: fix s3 java tests by forcing gradle to run on Java 8

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
5 months agoMerge pull request #61121 from ivancich/wip-69270-reef
J. Eric Ivancich [Fri, 24 Jan 2025 16:10:43 +0000 (11:10 -0500)]
Merge pull request #61121 from ivancich/wip-69270-reef

reef: qa/rgw: force Hadoop to run under Java 1.8

Reviewed-by: Casey Bodley <cbodley@redhat.com>
5 months agoMerge pull request #61500 from zdover23/wip-doc-2025-01-24-backport-61493-to-reef
Anthony D'Atri [Fri, 24 Jan 2025 14:05:06 +0000 (09:05 -0500)]
Merge pull request #61500 from zdover23/wip-doc-2025-01-24-backport-61493-to-reef

reef: doc/cephfs: edit disaster-recovery-experts (5 of x)

5 months agodoc/cephfs: edit disaster-recovery-experts (5 of x) 61500/head
Zac Dover [Thu, 23 Jan 2025 09:49:26 +0000 (19:49 +1000)]
doc/cephfs: edit disaster-recovery-experts (5 of x)

Put the procedure in the section called "Using an alternate metadata
pool for recovery" into an ordered list, so that it is in a proper
procedure format.

This commit is meant only to break the procedure into steps. The English
language in each of these steps could be improved, but that improvement
will be done after this formatting has been merged and backported.

Follows https://github.com/ceph/ceph/pull/61462.

https://tracker.ceph.com/issues/69557

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 9af7d9786a11e2b07a095c95ae911dfb13e4a61b)

5 months agoMerge pull request #60237 from aclamk/wip-aclamk-bluefs-truncate-allocations-reef
Adam Kupczyk [Thu, 23 Jan 2025 08:41:06 +0000 (09:41 +0100)]
Merge pull request #60237 from aclamk/wip-aclamk-bluefs-truncate-allocations-reef

reef: os/bluestore: Make truncate() drop unused allocations

5 months agoMerge pull request #61485 from ivancich/wip-69564-reef
J. Eric Ivancich [Wed, 22 Jan 2025 18:51:36 +0000 (13:51 -0500)]
Merge pull request #61485 from ivancich/wip-69564-reef

reef: rgw/lc: make lc worker thread name shorter

Reviewed-by: Casey Bodley <cbodley@redhat.com>
5 months agoMerge pull request #61318 from aclamk/wip-aclamk-ifed-allocation-info-reef
Yuri Weinstein [Wed, 22 Jan 2025 18:42:06 +0000 (10:42 -0800)]
Merge pull request #61318 from aclamk/wip-aclamk-ifed-allocation-info-reef

[reef] os/bluestore: introduce allocator state histogram

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
5 months agorgw/lc: make lc worker thread name shorter 61485/head
lightmelodies [Thu, 9 Jan 2025 10:15:50 +0000 (10:15 +0000)]
rgw/lc: make lc worker thread name shorter

Fixes: https://tracker.ceph.com/issues/69459
Signed-off-by: lightmelodies <lightmelodies@outlook.com>
(cherry picked from commit 05e241245744d105e285373bb9aa7861c62dcc18)

5 months agoMerge pull request #61480 from zdover23/wip-doc-2025-01-22-backport-61462-to-reef
Anthony D'Atri [Wed, 22 Jan 2025 15:12:38 +0000 (10:12 -0500)]
Merge pull request #61480 from zdover23/wip-doc-2025-01-22-backport-61462-to-reef

reef: doc/cephfs: edit disaster-recovery-experts (4 of x)

5 months agoMerge pull request #61360 from zdover23/wip-doc-2025-01-14-backport-61352-to-reef
Zac Dover [Wed, 22 Jan 2025 12:02:02 +0000 (22:02 +1000)]
Merge pull request #61360 from zdover23/wip-doc-2025-01-14-backport-61352-to-reef

reef: doc/releases: add actual_eol for quincy

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
5 months agoMerge pull request #61059 from zdover23/wip-doc-2024-12-12-backport-61049-to-reef
Zac Dover [Wed, 22 Jan 2025 12:01:34 +0000 (22:01 +1000)]
Merge pull request #61059 from zdover23/wip-doc-2024-12-12-backport-61049-to-reef

reef: doc/cephfs: edit 2nd 3rd of mount-using-kernel-driver

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
5 months agodoc/cephfs: edit disaster-recovery-experts (4 of x) 61480/head
Zac Dover [Tue, 21 Jan 2025 05:53:19 +0000 (15:53 +1000)]
doc/cephfs: edit disaster-recovery-experts (4 of x)

Edit the seventh and final section of
doc/cephfs/disaster-recovery-experts.rst in preparation for adding
deeper explanations of the contexts in which one should use the various
commands listed on that page.

The section edited in this commit is

 * Using an alternate metadata pool for recovery

A future commit might beneficially put this section into the format of
an ordered list. If so, such a commit should only reformat the
content and should not make any changes to the English. It's enough to
verify content or format. Let's not overload our editorial faculties by
forcing ourselves to walk and chew gum at the same time.

Follows https://github.com/ceph/ceph/pull/61442

https://tracker.ceph.com/issues/69557

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit f2529d11745d99e5b5c404193d3dd5e47e48afda)

6 months agoMerge pull request #61460 from zdover23/wip-doc-2025-01-21-backport-61249-to-reef
Anthony D'Atri [Tue, 21 Jan 2025 15:22:17 +0000 (10:22 -0500)]
Merge pull request #61460 from zdover23/wip-doc-2025-01-21-backport-61249-to-reef

reef: doc/cephfs: edit grammar in snapshots.rst

6 months agoMerge pull request #59786 from zdover23/wip-doc-2024-09-14-backport-59732-to-reef
Zac Dover [Tue, 21 Jan 2025 09:44:27 +0000 (19:44 +1000)]
Merge pull request #59786 from zdover23/wip-doc-2024-09-14-backport-59732-to-reef

reef: doc/README.md: improve formatting

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
6 months agodoc/cephfs: edit grammar in snapshots.rst 61460/head
Zac Dover [Tue, 7 Jan 2025 06:42:52 +0000 (16:42 +1000)]
doc/cephfs: edit grammar in snapshots.rst

This commit improves the grammar in doc/cephfs/snapshots.rst. The PR
associated with this commit follows from
https://github.com/ceph/ceph/pull/61240, the PR raised by Neeraj Pratap
Singh to introduce information about snapshots into the CephFS
documentation.

See also https://tracker.ceph.com/issues/68974.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 9a34ae55ede6dea5bb784a3e6cd45b9e60d4475d)

6 months agoMerge pull request #61247 from zdover23/wip-doc-2025-01-07-backport-61240-to-reef
Zac Dover [Tue, 21 Jan 2025 05:32:47 +0000 (15:32 +1000)]
Merge pull request #61247 from zdover23/wip-doc-2025-01-07-backport-61240-to-reef

reef: doc: add snapshots in docs under Cephfs concepts

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
6 months agoMerge pull request #61309 from zdover23/wip-doc-2025-01-10-backport-61243-to-reef
Zac Dover [Tue, 21 Jan 2025 05:23:11 +0000 (15:23 +1000)]
Merge pull request #61309 from zdover23/wip-doc-2025-01-10-backport-61243-to-reef

reef: doc/radosgw/s3: correct eTag op match tables

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
6 months agomgr/dashboard: fix total objects/Avg object size in RGW Overview Page 61458/head
Aashish Sharma [Mon, 28 Oct 2024 10:09:52 +0000 (15:39 +0530)]
mgr/dashboard: fix total objects/Avg object size in RGW Overview Page

Till now we are calculating the total number of objects and the average
object size in the RGW Overview Page using `ceph df` command's output.
As per the discussion with RGW team, this data is not correct as S3
objects in rgw can occupy more than one rados object. This PR tends to
make the overview page's info in sync with the RGW bucket page's info.

Fixes: https://tracker.ceph.com/issues/68733
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit 74b0749b7e63f2690a70d0226a1d730b23ddaea1)

Conflicts:
src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-overview-dashboard/rgw-overview-dashboard.component.spec.ts
src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-overview-dashboard/rgw-overview-dashboard.component.ts

6 months agoMerge pull request #61332 from zdover23/wip-doc-2025-01-11-backport-60081-to-reef
Anthony D'Atri [Mon, 20 Jan 2025 18:01:09 +0000 (13:01 -0500)]
Merge pull request #61332 from zdover23/wip-doc-2025-01-11-backport-60081-to-reef

reef: src/exporter: improve usage message

6 months agoMerge pull request #61454 from zdover23/wip-doc-2025-01-20-backport-61442-to-reef
Anthony D'Atri [Mon, 20 Jan 2025 16:09:41 +0000 (11:09 -0500)]
Merge pull request #61454 from zdover23/wip-doc-2025-01-20-backport-61442-to-reef

reef: doc/cephfs: edit disaster-recovery-experts (3 of x)

6 months agodoc/cephfs: edit disaster-recovery-experts (3 of x) 61454/head
Zac Dover [Sat, 18 Jan 2025 04:04:14 +0000 (14:04 +1000)]
doc/cephfs: edit disaster-recovery-experts (3 of x)

Edit the fifth and sixth sections of
doc/cephfs/disaster-recovery-experts.rst in preparation for adding
deeper explanations of the contexts in which one should use the various
commands listed on that page.

The sections edited in this commit are

 - MDS Map Reset
 - Recovery From Mission Metadata Objects

Follows https://github.com/ceph/ceph/pull/61427

https://tracker.ceph.com/issues/69557

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit a69c4142b7f99146af690933b3cfe897a64c7c59)

6 months agoMerge pull request #61097 from afreen23/wip-69200-reef
afreen23 [Mon, 20 Jan 2025 09:36:20 +0000 (15:06 +0530)]
Merge pull request #61097 from afreen23/wip-69200-reef

reef: mgr/dashboard: handle infinite values for pools

Reviewed-by: Afreen Misbah <afreen@ibm.com>
6 months agosrc/exporter: improve usage message 61332/head
Anthony D'Atri [Tue, 1 Oct 2024 16:21:56 +0000 (12:21 -0400)]
src/exporter: improve usage message

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit 725b4e184798dc38ec60ab81766577b39fd6e488)

6 months agoMerge pull request #61447 from zdover23/wip-doc-2025-01-20-backport-61445-to-reef
Anthony D'Atri [Mon, 20 Jan 2025 02:57:45 +0000 (21:57 -0500)]
Merge pull request #61447 from zdover23/wip-doc-2025-01-20-backport-61445-to-reef

doc/cephfs: disaster-recovery-experts cleanup

6 months agodoc/cephfs: disaster-recovery-experts cleanup 61447/head
Zac Dover [Sun, 19 Jan 2025 12:49:52 +0000 (22:49 +1000)]
doc/cephfs: disaster-recovery-experts cleanup

Properly wrap a poorly-formatted paragraph that looks just awful in an
80-column viewport and change MDS to "MDS daemons" where the latter
makes the sentence a lot clearer.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit dceaab9a1a479ea3a10b6eff5bb4ae23d2ad6aa0)

6 months agoMerge pull request #61444 from zdover23/wip-doc-2025-01-19-backport-61427-to-reef
Anthony D'Atri [Sun, 19 Jan 2025 16:02:45 +0000 (11:02 -0500)]
Merge pull request #61444 from zdover23/wip-doc-2025-01-19-backport-61427-to-reef

reef: doc/cephfs: edit disaster-recovery-experts (2 of x)

6 months agodoc/cephfs: edit disaster-recovery-experts (2 of x) 61444/head
Zac Dover [Fri, 17 Jan 2025 12:33:49 +0000 (22:33 +1000)]
doc/cephfs: edit disaster-recovery-experts (2 of x)

Edit the third and fourth sections of
doc/cephfs/disaster-recovery-experts.rst in preparation for adding
deeper explanations of the contexts in which one should use the various
commands listed on that page.

Follows https://github.com/ceph/ceph/pull/61426

https://tracker.ceph.com/issues/69557

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 4f3a69eb919fc0d99cdf943f095ca3a951c82897)

6 months agoMerge pull request #61438 from zdover23/wip-doc-2025-01-18-backport-61272-to-reef
Zac Dover [Sat, 18 Jan 2025 03:44:23 +0000 (13:44 +1000)]
Merge pull request #61438 from zdover23/wip-doc-2025-01-18-backport-61272-to-reef

reef: doc/radosgw/config-ref: fix lc worker thread tuning

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
6 months agoMerge pull request #61424 from zdover23/wip-doc-2025-01-17-backport-61411-to-reef
Zac Dover [Sat, 18 Jan 2025 03:42:57 +0000 (13:42 +1000)]
Merge pull request #61424 from zdover23/wip-doc-2025-01-17-backport-61411-to-reef

reef: doc/cephfs: edit disaster-recovery-experts

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
6 months agoMerge pull request #61402 from zdover23/wip-doc-2025-01-16-backport-61373-to-reef
Zac Dover [Sat, 18 Jan 2025 03:42:28 +0000 (13:42 +1000)]
Merge pull request #61402 from zdover23/wip-doc-2025-01-16-backport-61373-to-reef

reef: AsyncMessenger.cc : improve error messages

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
6 months agodoc/radosgw/config-ref: fix lc worker thread tuning 61438/head
Laimis Juzeliūnas [Wed, 8 Jan 2025 22:05:34 +0000 (00:05 +0200)]
doc/radosgw/config-ref: fix lc worker thread tuning

This commit updates RGW Config Reference - Lifecycle Settings section. In particular it addresses an incorrect suggestion to decrease parallel threads in the workers pool for a more aggressive/accelerated per-bucket lifecycle processing. A more aggressive lifecycle processing for a bucket containing higher number of objects is achieved by increasing, not decreasing parallel threads.
Current suggestion is miss-leading.

Fixes: https://tracker.ceph.com/issues/63659
Signed-off-by: Laimis Juzeliunas <laimis.juzeliunas@oxylabs.io>
(cherry picked from commit b7ae18a292c7d1d5139dfb74c575f1af0de29a3e)

6 months agoMerge pull request #58920 from mohit84/wip-67235-reef
Yuri Weinstein [Fri, 17 Jan 2025 16:05:35 +0000 (08:05 -0800)]
Merge pull request #58920 from mohit84/wip-67235-reef

reef: test: Create ParallelPGMapper object before start threadpool

Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>
6 months agodoc/cephfs: edit disaster-recovery-experts 61424/head
Zac Dover [Thu, 16 Jan 2025 11:51:46 +0000 (21:51 +1000)]
doc/cephfs: edit disaster-recovery-experts

Edit the first two sections of doc/cephfs/disaster-recovery-experts.rst
in preparation for adding deeper explanations of the contexts in which
one should use the various commands listed on that page.

https://tracker.ceph.com/issues/69557

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit cc8cfeddbd290ef9b5e4e0c68ae94cefb34e1be9)

6 months agoMerge pull request #59285 from k0ste/wip-64168-reef
SrinivasaBharathKanta [Fri, 17 Jan 2025 10:17:13 +0000 (15:47 +0530)]
Merge pull request #59285 from k0ste/wip-64168-reef

reef: osd: Add memstore to unsupported objstores for QoS

6 months agoMerge pull request #61259 from idryomov/wip-fsx-try-netlink-reef
Sunil Angadi [Fri, 17 Jan 2025 09:45:53 +0000 (15:15 +0530)]
Merge pull request #61259 from idryomov/wip-fsx-try-netlink-reef

reef: test/librbd/fsx: switch to netlink interface for rbd-nbd

6 months agoMerge pull request #61171 from idryomov/wip-69324-reef
Sunil Angadi [Fri, 17 Jan 2025 09:45:37 +0000 (15:15 +0530)]
Merge pull request #61171 from idryomov/wip-69324-reef

reef: rbd: handle --{group,image}-namespace in "rbd group image {add,rm}"

6 months agoMerge pull request #61167 from idryomov/wip-68998-reef
Sunil Angadi [Fri, 17 Jan 2025 09:45:17 +0000 (15:15 +0530)]
Merge pull request #61167 from idryomov/wip-68998-reef

reef: librbd: avoid data corruption on flatten when object map is inconsistent

6 months agoMerge pull request #61094 from idryomov/wip-69178-reef
Sunil Angadi [Fri, 17 Jan 2025 09:44:51 +0000 (15:14 +0530)]
Merge pull request #61094 from idryomov/wip-69178-reef

reef: librbd/migration/HttpClient: avoid reusing ssl_stream after shut down

6 months agoMerge pull request #61182 from rhcs-dashboard/reef-configuration-not-updatable
afreen23 [Fri, 17 Jan 2025 09:29:50 +0000 (14:59 +0530)]
Merge pull request #61182 from rhcs-dashboard/reef-configuration-not-updatable

reef: mgr/dashboard: Administration > Configuration > Some of the config options are not updatable at runtime

Reviewed-by: Afreen Misbah <afreen@ibm.com>
6 months agoos/bluestore: Fix BlueFS::truncate() 60237/head
Adam Kupczyk [Fri, 10 Jan 2025 08:26:54 +0000 (08:26 +0000)]
os/bluestore: Fix BlueFS::truncate()

In `struct bluefs_fnode_t` there is a vector `extents` and
the vector `extents_index` that is a log2 seek cache.

Until modifications to truncate() we never removed extents from files.
Modified truncate() did not update extents_index.

For example 10 extents long files when truncated to 0 will have:
0 extents, 10 extents_index.
After writing some data to file:
1 extents, 11 extents_index.

Now, `bluefs_fnode_t::seek` will binary search extents_index,
lets say it located seek at item #3.
It will then jump up from #0 extent (that exists) to #3 extent which
does not exist at.
The worst part is that code is now broken, as #3 != extent.end().

There are 3 parts of the fix:
1) assert in `bluefs_fnode_t::seek` to protect against
   jumping outside extents
2) code in BlueFS::truncate to sync up `extents_index` with `extents`
3) dampening down assert in _replay to give a way out of cases
   where incorrect "offset 12345" (12345 is file size) instead of
   "offset 20000" (allocations occupied) was written to log.

Fixes: https://tracker.ceph.com/issues/69481
Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
(cherry picked from commit 7f3601089d41bfc23f530c7bf3fb7efad2d055ec)

6 months agoos/bluestore: bluefs unittest for truncate bug
Adam Kupczyk [Fri, 10 Jan 2025 10:07:18 +0000 (10:07 +0000)]
os/bluestore: bluefs unittest for truncate bug

Unittest showing 2 different flavours of problems:
1) bluefs log corruption
2) bluefs sigsegv

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
(cherry picked from commit f2b5e2fa0a9274c1667fccafa597fff9be7a74b1)
+ fixes for add_block_device
+ fix for bad usage of std::string's fill constructor

6 months agoos/bluestore: Add unittest for BlueFS::truncate()
Adam Kupczyk [Wed, 23 Oct 2024 11:57:01 +0000 (11:57 +0000)]
os/bluestore: Add unittest for BlueFS::truncate()

Add unittest for some truncate scenarios.

Fixes: https://tracker.ceph.com/issues/68385 (addendum)
Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
(cherry picked from commit 612f24b41fb44e478d6c1cc867dfa0720197793f)

6 months agoos/bluestore: Make truncate() drop unused allocations
Adam Kupczyk [Tue, 22 Oct 2024 18:53:22 +0000 (18:53 +0000)]
os/bluestore: Make truncate() drop unused allocations

Review fixes. Removed overcatious assert.
Improved if .. else style.
Skipped processing extent truncation when seek() goes to end.

Fixes: https://tracker.ceph.com/issues/68385 (addendum)
Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
(cherry picked from commit 85fac18a1cb0491e270261c71a506c4c1ba5e0bf)

6 months agotest/store_test: get rid off explicit offset specifications in shared
Igor Fedotov [Wed, 10 Jan 2024 16:28:13 +0000 (19:28 +0300)]
test/store_test: get rid off explicit offset specifications in shared
blob repair test case.

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit 482e5b85f08a07200c1f18db509b6b0f2ebcf3e6)

6 months agoos/bluestore: Make truncate() drop unused allocations
Adam Kupczyk [Mon, 7 Oct 2024 11:45:41 +0000 (11:45 +0000)]
os/bluestore: Make truncate() drop unused allocations

Now when truncate() drops unused allocations.
Modified Close() in BlueRocksEnv to unconditionally call truncate.

Fixes: https://tracker.ceph.com/issues/68488
Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
(cherry picked from commit 9fc65f160cd3764a68fb3697d067c358761fc837)

Conflicts:
src/os/bluestore/BlueFS.cc, trivial

6 months agoMerge pull request #59266 from k0ste/wip-65924-reef
Kamoltat (Junior) Sirivadhna [Fri, 17 Jan 2025 08:33:42 +0000 (15:33 +0700)]
Merge pull request #59266 from k0ste/wip-65924-reef

reef: CephContext: acquire _fork_watchers_lock in notify_post_fork()
Reviewed-by: Kamoltat Sirivadhna <ksirivad@redhat.com>
6 months agoMerge pull request #60981 from sseshasa/wip-69150-reef
SrinivasaBharathKanta [Fri, 17 Jan 2025 05:09:45 +0000 (10:39 +0530)]
Merge pull request #60981 from sseshasa/wip-69150-reef

reef: osd: adding 'reef' to pending_require_osd_release

6 months agoMerge pull request #60780 from shraddhaag/wip-68948-reef
Shraddha Agrawal [Thu, 16 Jan 2025 08:13:15 +0000 (13:43 +0530)]
Merge pull request #60780 from shraddhaag/wip-68948-reef

reef: qa/standalone/mon/mon_cluster_log.sh: retry check for log line

6 months agoqa/standalone/mon/mon_cluster_log.sh: retry check for log line 60780/head
Shraddha Agrawal [Mon, 30 Sep 2024 15:37:35 +0000 (21:07 +0530)]
qa/standalone/mon/mon_cluster_log.sh: retry check for log line

Issue: The test was failing as we were checking for the osd boot
log before it was actually emitted in the log file.

Solution: We retry checking for the desired string in the log file
for a duration of 60s after OSD has come up successfully.

Fixes: https://tracker.ceph.com/issues/67282
Signed-off-by: Shraddha Agrawal <shraddha.agrawal000@gmail.com>
Signed-off-by: Naveen Naidu <naveennaidu479@gmail.com>
(cherry picked from commit 67928a27357e2d600114db1891db5e7b30c8d1a9)

6 months agoAsyncMessenger.cc : improve error messages 61402/head
Anthony D'Atri [Wed, 15 Jan 2025 00:17:14 +0000 (19:17 -0500)]
AsyncMessenger.cc : improve error messages

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit 3d36a3b9bbeb8b21b99046aab0d0bdf8f1c30aa2)

6 months agodoc/releases: add actual_eol for quincy 61360/head
Zac Dover [Mon, 13 Jan 2025 19:00:00 +0000 (05:00 +1000)]
doc/releases: add actual_eol for quincy

Add the actual EOL date for the Quincy release (it's 2025-01-13).

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 2c4ab9c571218bc09d14de0b101166fbab965f85)

6 months agoMerge pull request #61292 from phlogistonjohn/jjm-fix-reef-mypy-69471
Adam King [Mon, 13 Jan 2025 15:37:47 +0000 (10:37 -0500)]
Merge pull request #61292 from phlogistonjohn/jjm-fix-reef-mypy-69471

reef: mgr/diskprediction_local: avoid mypy error

Reviewed-by: Adam King <adking@redhat.com>
6 months agoMerge pull request #61343 from zdover23/wip-doc-2025-01-13-backport-61313-to-reef
Anthony D'Atri [Mon, 13 Jan 2025 15:09:01 +0000 (10:09 -0500)]
Merge pull request #61343 from zdover23/wip-doc-2025-01-13-backport-61313-to-reef

reef: doc: improve tests-integration-testing-teuthology-workflow.rst

6 months agoMerge pull request #60445 from mohit84/wip-68663-reef
Yuri Weinstein [Mon, 13 Jan 2025 14:04:09 +0000 (06:04 -0800)]
Merge pull request #60445 from mohit84/wip-68663-reef

reef: AsyncMessenger: Don't decrease l_msgr_active_connections if it is negative

Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>
6 months agodoc: improve tests-integration-testing-teuthology-workflow.rst 61343/head
Vallari Agrawal [Thu, 9 Jan 2025 12:27:42 +0000 (17:57 +0530)]
doc: improve tests-integration-testing-teuthology-workflow.rst

This commit adds:
1. workflow summary in the first section along with an image.
2. sub-section "Pushing to ceph-ci repository" to second section.
3. file doc/dev/developer_guide/testing_integration_tests/workflow.png

Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>
(cherry picked from commit dc539b3ea8031d2b02da9d5a5b1f856d96d70362)

6 months agoCephContext: acquire _fork_watchers_lock in notify_post_fork() 59266/head
Venky Shankar [Thu, 9 Nov 2023 10:31:26 +0000 (05:31 -0500)]
CephContext: acquire _fork_watchers_lock in notify_post_fork()

The ceph::spin_unlock() seems incorrect here.

Fixes: http://tracker.ceph.com/issues/63494
Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit faef266331ae0e372a345ef1926c239aa6c3bf45)

6 months agoosd: Remove usage of unsupported objstores for QoS 59285/head
Aishwarya Mathuria [Thu, 13 Jul 2023 18:05:42 +0000 (23:35 +0530)]
osd: Remove usage of unsupported objstores for QoS

mClock is supported on Bluestore and a check is currently done to eliminate other unsupported object stores.
With Filestore no longer in the code base, this check can be removed.
In addition, make sure that osd bench will no longer run on setups with memstore.

Fixes: https://tracker.ceph.com/issues/59531
Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
(cherry picked from commit 18043c5e88d241f43b8fd23a8cbc1b15a3854de9)

Conflicts:
  - file: src/osd/OSD.cc
    comment: `OSD::maybe_override_cost_for_qos()` was removed as part of the backport
      that included mClock changes for PG delete operation

6 months agoMerge pull request #60612 from cbodley/wip-68824-reef
Yuri Weinstein [Fri, 10 Jan 2025 16:19:42 +0000 (08:19 -0800)]
Merge pull request #60612 from cbodley/wip-68824-reef

reef: os: remove unused btrfs_ioctl.h and tests

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
6 months agoMerge pull request #59280 from k0ste/wip-67458-reef
Yuri Weinstein [Fri, 10 Jan 2025 16:17:35 +0000 (08:17 -0800)]
Merge pull request #59280 from k0ste/wip-67458-reef

reef: common/TrackedOp: rename and raise prio of slow op perfcounter

Reviewed-by: YiteGu <yitegu0@gmail.com>
6 months agoMerge pull request #57067 from batrick/wip-65377-reef
Yuri Weinstein [Fri, 10 Jan 2025 16:13:09 +0000 (08:13 -0800)]
Merge pull request #57067 from batrick/wip-65377-reef

reef: osd/OSDMonitor: check svc is writeable before changing pending

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
6 months agoMerge pull request #59444 from kamoltat/wip-67721-reef
Yuri Weinstein [Fri, 10 Jan 2025 16:07:00 +0000 (08:07 -0800)]
Merge pull request #59444 from kamoltat/wip-67721-reef

reef: src/pybind/mgr/pg_autoscaler/module.py: fix 'pg_autoscale_mode' output

Reviewed-by: Samuel Just <sjust@redhat.com>
6 months agoMerge pull request #59404 from Matan-B/wip-67666-reef
Yuri Weinstein [Fri, 10 Jan 2025 16:06:07 +0000 (08:06 -0800)]
Merge pull request #59404 from Matan-B/wip-67666-reef

reef: mon/OSDMonitor: Add force-remove-snap mon command

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
6 months agoMerge pull request #59371 from NitzanMordhai/wip-67644-reef
Yuri Weinstein [Fri, 10 Jan 2025 16:05:16 +0000 (08:05 -0800)]
Merge pull request #59371 from NitzanMordhai/wip-67644-reef

reef: mgr/rest: Trim  requests array and limit size

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
6 months agoos/bluestore: do not include single AU allocations to allocation 61318/head
Igor Fedotov [Mon, 29 May 2023 14:11:37 +0000 (17:11 +0300)]
os/bluestore: do not include single AU allocations to allocation
fragmentation stats.

The rationale is that such allocations always get single framgent.

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit 5cdd29f78bdd19185d3d93479a57be25fa98d7f1)

6 months agotest/allocator_replay: introduce allocator fragmentation histogram.
Igor Fedotov [Thu, 22 Jun 2023 13:18:03 +0000 (16:18 +0300)]
test/allocator_replay: introduce allocator fragmentation histogram.

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit 600fc5b0f18aca5f129cb18ce4b0ea16dbc3b9f0)

6 months agoos/bluestore: implement allocator fragmentation histogram
Igor Fedotov [Thu, 22 Jun 2023 13:16:32 +0000 (16:16 +0300)]
os/bluestore: implement allocator fragmentation histogram

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit 625e3461fbed904e85dfeea7ab3e8f7b74c4f384)

6 months agodoc/radosgw/s3: correct eTag op match tables 61309/head
Anthony D'Atri [Mon, 6 Jan 2025 17:48:04 +0000 (12:48 -0500)]
doc/radosgw/s3: correct eTag op match tables

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit f108a3739700c49a46472fb7b936acb9c53f0c0d)

6 months agoreef: mgr/diskprediction_local: avoid mypy error 61292/head
John Mulligan [Thu, 9 Jan 2025 18:35:28 +0000 (13:35 -0500)]
reef: mgr/diskprediction_local: avoid mypy error

Patch is for reef ONLY, not a traditional backport.
Disable mypy check for the given line. This check is triggerin all
reef CI jobs to fail.

Fixes: https://tracker.ceph.com/issues/69471
Signed-off-by: John Mulligan <jmulligan@redhat.com>
6 months agoMerge pull request #56139 from ifed01/wip-ifed-fix-global-repair-stats-reef
Igor Fedotov [Thu, 9 Jan 2025 10:20:31 +0000 (13:20 +0300)]
Merge pull request #56139 from ifed01/wip-ifed-fix-global-repair-stats-reef

reef: os/store_test: Retune tests to current code

Revewed-by: Md Mahamudur Rahaman Sajib mahamudur.sajib@croit.io
6 months agoMerge pull request #59499 from pponnuvel/wip-67607-reef
Igor Fedotov [Thu, 9 Jan 2025 10:16:38 +0000 (13:16 +0300)]
Merge pull request #59499 from pponnuvel/wip-67607-reef

reef: os/bluestore: allow use BtreeAllocator

Reviewed-by: Igor Fedotov <igor.fedotov@croit.io>
6 months agoMerge pull request #59270 from k0ste/wip-67246-reef
SrinivasaBharathKanta [Wed, 8 Jan 2025 15:22:32 +0000 (20:52 +0530)]
Merge pull request #59270 from k0ste/wip-67246-reef

reef: mon: Remove any pg_upmap_primary mapping during remove a pool

6 months agotest/librbd/fsx: switch to netlink interface for rbd-nbd 61259/head
Ilya Dryomov [Tue, 7 Jan 2025 16:29:03 +0000 (17:29 +0100)]
test/librbd/fsx: switch to netlink interface for rbd-nbd

The default was flipped in commit fcbf7367d285 ("rbd-nbd: map using
netlink interface by default") in squid.  This is a reef-only fixup for
fsx to counter failures like "Size error: expected 0xa5cac00 stat 0x0"
which seem to be quite persistent on CentOS Stream 9.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
6 months agodoc: add snapshots in docs under Cephfs concepts 61247/head
neeraj pratap singh [Mon, 6 Jan 2025 11:00:32 +0000 (16:30 +0530)]
doc: add snapshots in docs under Cephfs concepts

Fixes: https://tracker.ceph.com/issues/68974
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
(cherry picked from commit 885b1bf88ee28b05cc9ed91e8ea5146511b6cf34)

6 months agomgr/dashboard: Update and correct zonegroup delete notification 61236/head
Aashish Sharma [Thu, 5 Dec 2024 05:37:13 +0000 (11:07 +0530)]
mgr/dashboard: Update and correct zonegroup delete notification

while deleting zone group from dashboard, notification message says "zone <zg_name> deleted successfully" instead of "zone group <zg_name> deleted successfully"

Fixes: https://tracker.ceph.com/issues/69121
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit 48dd55a0ad469f14d7a530d8c6aaf6f3aab2be43)

6 months agoMerge pull request #60741 from mkogan1/wip-62255-reef
Shilpa Jagannath [Fri, 3 Jan 2025 21:52:42 +0000 (13:52 -0800)]
Merge pull request #60741 from mkogan1/wip-62255-reef

reef: rgw: fix the Content-Length in response header of static website

6 months agoMerge pull request #60701 from cbodley/wip-68898-reef
Shilpa Jagannath [Fri, 3 Jan 2025 21:30:36 +0000 (13:30 -0800)]
Merge pull request #60701 from cbodley/wip-68898-reef

reef: qa/rgw/crypt: disable failing kmip testing

6 months agomgr/dashboard: adding & exposing Param Class to support EndpointDoc creation 61182/head
Naman Munet [Thu, 26 Dec 2024 08:48:00 +0000 (14:18 +0530)]
mgr/dashboard: adding & exposing Param Class to support EndpointDoc creation

Fixes: https://tracker.ceph.com/issues/69272
Signed-off-by: Naman Munet <naman.munet@ibm.com>
6 months agoMerge pull request #60849 from smanjara/wip-reef-60801
Shilpa Jagannath [Thu, 2 Jan 2025 23:00:12 +0000 (15:00 -0800)]
Merge pull request #60849 from smanjara/wip-reef-60801

[reef] qa/rgw: the rgw/verify suite runs java tests last

6 months agoMerge pull request #60165 from cbodley/wip-68426-reef
Shilpa Jagannath [Thu, 2 Jan 2025 22:54:10 +0000 (14:54 -0800)]
Merge pull request #60165 from cbodley/wip-68426-reef

reef: cls/user: reset stats only returns marker when truncated

6 months agoMerge pull request #60455 from cbodley/wip-64398-reef
Shilpa Jagannath [Thu, 2 Jan 2025 22:49:32 +0000 (14:49 -0800)]
Merge pull request #60455 from cbodley/wip-64398-reef

reef: rgw/auth: ignoring signatures for HTTP OPTIONS calls

6 months agoMerge pull request #61194 from zdover23/wip-doc-2024-12-30-backport-60794-to-reef
Anthony D'Atri [Mon, 30 Dec 2024 15:12:06 +0000 (10:12 -0500)]
Merge pull request #61194 from zdover23/wip-doc-2024-12-30-backport-60794-to-reef

reef: doc/cephfs: document purge queue and its perf counters

6 months agodoc/README.md: improve formatting 59786/head
Zac Dover [Wed, 11 Sep 2024 12:50:35 +0000 (22:50 +1000)]
doc/README.md: improve formatting

Improve the formatting in the section "Building Ceph" in the file
README.md.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit b9ca3957303989bbba9301cbbd18ba8faa0b8168)

6 months agodoc/cephfs: document purge queue and its perf counters 61194/head
Dhairya Parmar [Thu, 21 Nov 2024 22:10:33 +0000 (03:40 +0530)]
doc/cephfs: document purge queue and its perf counters

Fixes: https://tracker.ceph.com/issues/68571
Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
(cherry picked from commit ae9277398840bf8576ea5a8c4a2ba4e23f8b9613)

6 months agomgr/dashboard: Administration > Configuration > Some of the config options are not...
Naman Munet [Fri, 22 Nov 2024 09:57:44 +0000 (15:27 +0530)]
mgr/dashboard: Administration > Configuration > Some of the config options are not updatable at runtime

Fixes: https://tracker.ceph.com/issues/68976
Fixes Includes:
1) by-passing 'can_update_at_runtime' flag for 'rgw' related configurations as the same can be updated at runtime via CLI.
Also implemented a warning popup for user to make force edit to rgw related configurations.

Signed-off-by: Naman Munet <naman.munet@ibm.com>
(cherry picked from commit 3181acc223dafd04e3fc56d418389ad50c5868e4)

6 months agoMerge pull request #61179 from zdover23/wip-doc-2024-12-26-backport-61177-to-reef
Anthony D'Atri [Thu, 26 Dec 2024 00:27:50 +0000 (19:27 -0500)]
Merge pull request #61179 from zdover23/wip-doc-2024-12-26-backport-61177-to-reef

reef: doc: Fixes a typo in controllers section of hardware recommendations

6 months agodoc: Fixes a typo in controllers section of hardware recommendations 61179/head
Skalador [Wed, 25 Dec 2024 22:57:00 +0000 (23:57 +0100)]
doc: Fixes a typo in controllers section of hardware recommendations

Signed-off-by: Kevin Niederwanger <k.niederwanger@gmail.com>
(cherry picked from commit 089636224910e1cd6231cadd2c422a78c3d08fea)