]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
12 months agoqa: use supported releases for featureful_client
Venky Shankar [Fri, 7 Jun 2024 05:13:27 +0000 (05:13 +0000)]
qa: use supported releases for featureful_client

... and switch for centos9.

For squid branch, start upgrade from quincy/reef.

Fixes: https://tracker.ceph.com/issues/65580
Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 3715ce671de97530dda30d59fe643cebc3ebc508)
(cherry picked from commit ab7d6bfee1b39072f49de7aa7913df5c90b3ed3f)

12 months agoqa/suites: add "mon down" log variations to ignorelist
Laura Flores [Mon, 1 Apr 2024 17:27:54 +0000 (12:27 -0500)]
qa/suites: add "mon down" log variations to ignorelist

Fixes: https://tracker.ceph.com/issues/64864
Signed-off-by: Laura Flores <lflores@ibm.com>
(cherry picked from commit d475ac3e6ab86a4913e1d318989c617031978bc2)

Conflicts:
qa/suites/orch/cephadm/smoke/start.yaml
qa/suites/orch/cephadm/workunits/task/test_host_drain.yaml
qa/suites/orch/cephadm/workunits/task/test_monitoring_stack_basic.yaml
qa/suites/orch/cephadm/workunits/task/test_rgw_multisite.yaml
qa/suites/orch/cephadm/workunits/task/test_set_mon_crush_locations.yaml

The log-only-match entry was backported to squid before the ignorelist changes,
        but in main it was introduced after the ignorelist changes.
        See https://github.com/ceph/ceph/commit/b4522dd332d40a54b9e0be58bd96aeaa345f8977.

(cherry picked from commit f963cd8b2889752c4afe399c4da0df53e8295cf7)

12 months agoqa/suites/rados/thrash-old-clients: update supported releases and distro
Laura Flores [Wed, 12 Jun 2024 20:21:09 +0000 (15:21 -0500)]
qa/suites/rados/thrash-old-clients: update supported releases and distro

thrash-old-clients tests should only support N-3 releases. To fix this for
main, I have removed all releases < quincy and have added squid.

Also, we are fully switching to centos.9_stream packages/containers after
the centos.8_stream end of life, so I changed the distro from centos.8_stream
to centos.9_stream.

*** Note: If this commit is backported, it should be done in such a way that
only releases >= quincy reference centos.9_stream. For instance, if backporting to squid,
a reef/squid thrash test is okay to make references to centos.9_stream since both reef and
squid support this, but a pacific/squid test will have to take a different approach
since pacific does not support centos.9_stream.

Fixes: https://tracker.ceph.com/issues/66398
Signed-off-by: Laura Flores <lflores@ibm.com>
(cherry picked from commit 820e4004f3fd17a5daee955f7a1443b1501caaad)

Modifications:
- For this squid backport, I kept pacific since that fits into N-3 where
  N is squid.
- Pacific does not build c9 packages, so I picked an alternative distro
  that is shared among all represented releases: ubuntu 20.04.

(cherry picked from commit 9081c674ab056aef02ec773714b111b5b4ff80ce)

12 months agoqa/rados: don't pass --max_attr_len to ceph_test_rados unconditionally
Radosław Zarzyński [Mon, 3 Jun 2024 22:00:38 +0000 (00:00 +0200)]
qa/rados: don't pass --max_attr_len to ceph_test_rados unconditionally

Fixes: https://tracker.ceph.com/issues/66321
Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
(cherry picked from commit 8a6d56e62fc03062e60828a3bc9f37ed7232b3e7)
(cherry picked from commit 5b900b4405984abf7b7a123df331b67077bbd679)

12 months agoqa/tasks/qemu: Fix OS version comparison
Zack Cerza [Fri, 14 Jun 2024 19:37:16 +0000 (13:37 -0600)]
qa/tasks/qemu: Fix OS version comparison

See: https://sentry.ceph.com/share/issue/21ed88d705854238bdafbf6711e795ee/
They're strings, not floats.
This surfaced as a result of https://github.com/ceph/teuthology/pull/1953

Signed-off-by: Zack Cerza <zack@redhat.com>
(cherry picked from commit 260a45a03148ba4d2bbfcac9485bcf9a8743cade)
(cherry picked from commit c67550651bc7dbc4680ddb2a56bd90b5ee6032fc)

14 months agodoc/dev/release-checklists.rst: squid milestone added
Neha Ojha [Mon, 20 May 2024 16:53:01 +0000 (16:53 +0000)]
doc/dev/release-checklists.rst: squid milestone added

Signed-off-by: Neha Ojha <nojha@redhat.com>
(cherry picked from commit 873bfd7e69ba507b264bca577ce5f6526feb52f9)

14 months ago.github/milestone.yml: add squid
Neha Ojha [Fri, 10 May 2024 20:59:25 +0000 (20:59 +0000)]
.github/milestone.yml: add squid

Signed-off-by: Neha Ojha <nojha@redhat.com>
(cherry picked from commit bca45c7df2c26b105401b299161f553ffe4e32c1)
(cherry picked from commit dd7e9fcbd2acdc59a05131780f4ef747b12757c5)

14 months agodoc/dev/release-checklists.rst: squid is in rc phase
Neha Ojha [Fri, 10 May 2024 20:51:04 +0000 (20:51 +0000)]
doc/dev/release-checklists.rst: squid is in rc phase

Signed-off-by: Neha Ojha <nojha@redhat.com>
(cherry picked from commit 1261a79628bf7d677cdb52ca2670930fc3fc3541)

14 months agodoc/dev/release-checklists.rst: add release to redmine check
Neha Ojha [Fri, 10 May 2024 20:48:00 +0000 (20:48 +0000)]
doc/dev/release-checklists.rst: add release to redmine check

Signed-off-by: Neha Ojha <nojha@redhat.com>
(cherry picked from commit 51094ea986811f23386f80e37ef8066cec751030)

14 months agosrc/ceph_release: dev -> rc
Neha Ojha [Fri, 10 May 2024 20:41:49 +0000 (20:41 +0000)]
src/ceph_release: dev -> rc

squid is now in rc phase

Signed-off-by: Neha Ojha <nojha@redhat.com>
(cherry picked from commit b6180044afcca552ee0df037e93c50df5cdb5636)

14 months agomgr/k8sevents: update V1Events to CoreV1Events
Nizamudeen A [Fri, 3 May 2024 08:56:19 +0000 (14:26 +0530)]
mgr/k8sevents: update V1Events to CoreV1Events

centos9 only provides kubernetes 26.1.0 as base dep and hence the
k8sevents code needs to be updated accordingly. the api changes happened
in kuberenetes while 19.0.0 was released

Fixes: https://tracker.ceph.com/issues/65627
Fixes: https://tracker.ceph.com/issues/64981
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 6af964719217d720e6c2fd1ba2a607f6255d2604)
(cherry picked from commit 78969708bc560d42ddcf8ceb8d4c34c46e70fccd)

14 months agoMerge pull request #57303 from ronen-fr/wip-rf-reinstate-q-squid
Laura Flores [Mon, 13 May 2024 18:44:14 +0000 (13:44 -0500)]
Merge pull request #57303 from ronen-fr/wip-rf-reinstate-q-squid

squid:osd/scrub: reinstate scrub reservation queuing

14 months agoMerge pull request #57092 from idryomov/wip-65573-squid
Ilya Dryomov [Wed, 8 May 2024 21:28:50 +0000 (23:28 +0200)]
Merge pull request #57092 from idryomov/wip-65573-squid

squid: librbd: make group and group snapshot IDs more random

Reviewed-by: Mykola Golub <mgolub@suse.com>
14 months agoMerge pull request #57242 from cbodley/wip-65767-squid
Casey Bodley [Wed, 8 May 2024 20:23:20 +0000 (21:23 +0100)]
Merge pull request #57242 from cbodley/wip-65767-squid

squid: rgw/multisite-notification: retry storing bucket notification attrs for ECANCELED(ConcurrentModification) errors.

Reviewed-by: Krunal Chheda <kchheda3@bloomberg.net>
14 months agoMerge pull request #57006 from rzarzynski/wip-65185-squid
Laura Flores [Wed, 8 May 2024 17:52:34 +0000 (12:52 -0500)]
Merge pull request #57006 from rzarzynski/wip-65185-squid

squid: osd/PGBackend::be_scan_list: only call stat, getattrs once per object

14 months agoMerge pull request #57300 from cbodley/wip-65821-squid
Casey Bodley [Wed, 8 May 2024 16:47:08 +0000 (17:47 +0100)]
Merge pull request #57300 from cbodley/wip-65821-squid

squid: rgw: fix CompleteMultipart error handling regression

Reviewed-by: Ali Masarwa <amasarwa@redhat.com>
14 months agoMerge pull request #57104 from soumyakoduri/wip-skoduri-squid
Casey Bodley [Wed, 8 May 2024 15:13:35 +0000 (16:13 +0100)]
Merge pull request #57104 from soumyakoduri/wip-skoduri-squid

[squid] rgw/lc: advance head if the current entry doesn't exist

Reviewed-by: Casey Bodley <cbodley@redhat.com>
14 months agoMerge pull request #57231 from galsalomon66/wip-65244-squid
Casey Bodley [Wed, 8 May 2024 15:13:23 +0000 (16:13 +0100)]
Merge pull request #57231 from galsalomon66/wip-65244-squid

squid: rgw/s3select: s3select response handler refactor

Reviewed-by: Casey Bodley <cbodley@redhat.com>
14 months agoMerge pull request #57254 from aaSharma14/wip-65790-squid
Aashish Sharma [Wed, 8 May 2024 09:24:47 +0000 (14:54 +0530)]
Merge pull request #57254 from aaSharma14/wip-65790-squid

squid: mgr/dashboard: add prometheus federation config for multi-cluster monitoring

Reviewed-by: Nizamudeen A <nia@redhat.com>
14 months agoMerge pull request #57285 from Matan-B/wip-55699-squid
Rongqi Sun [Tue, 7 May 2024 01:01:53 +0000 (18:01 -0700)]
Merge pull request #57285 from Matan-B/wip-55699-squid

squid: doc/crimson: cleanup duplicate seastore description

14 months agosquid:osd/scrub: reinstate scrub reservation queuing 57303/head
Ronen Friedman [Mon, 6 May 2024 19:43:41 +0000 (22:43 +0300)]
squid:osd/scrub: reinstate scrub reservation queuing

Re-enabling the Reserver-based scrub queuing (undoing
https://github.com/ceph/ceph/pull/56750), as all known issues
related to the reservation queuing have been fixed and back-ported.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
14 months agorgw: move publish_complete() back to RGWCompleteMultipart::execute() 57300/head
Casey Bodley [Fri, 3 May 2024 19:43:39 +0000 (15:43 -0400)]
rgw: move publish_complete() back to RGWCompleteMultipart::execute()

move publish_complete() and meta_obj->delete_object() back to execute()
so they only run on success. this allows several member variables to
move back to execute()'s stack as well

Fixes: https://tracker.ceph.com/issues/65746
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit ebb37c7bb3aee4663220054c6516164bf046fa8c)

14 months agorgw: CompleteMultipart uses s->object for Notification
Casey Bodley [Fri, 3 May 2024 19:29:00 +0000 (15:29 -0400)]
rgw: CompleteMultipart uses s->object for Notification

get_notification() should be associated with the target object
s->object. the meta_obj has the wrong object name, so required passing
s->object->get_name() as an extra argument

importantly, Notification no longer depends on the lifetime of meta_obj
to avoid a dangling pointer, while the lifetime of s->object is guaranteed

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 91dc7f3be945dccd8f59e070e9bc43a2a5df12db)

14 months agorgw: CompleteMultipart uses s->object instead of target_obj
Casey Bodley [Fri, 3 May 2024 19:17:48 +0000 (15:17 -0400)]
rgw: CompleteMultipart uses s->object instead of target_obj

most requests operate directly on s->object. there's no reason to
allocate a separate target_obj for the same purpose

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit d09b8ab2e077ceb6a0c6dfb99ce1b45d63a28be4)

14 months agoMerge pull request #56947 from adk3798/wip-65539-squid
Aashish Sharma [Mon, 6 May 2024 13:45:50 +0000 (19:15 +0530)]
Merge pull request #56947 from adk3798/wip-65539-squid

squid: ceph-mixin: Update mixin to include alerts for the nvmeof gateway(s)

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
14 months agodoc/crimson: cleanup duplicate seastore description 57285/head
Rongqi Sun [Thu, 22 Feb 2024 02:41:43 +0000 (10:41 +0800)]
doc/crimson: cleanup duplicate seastore description

Signed-off-by: Rongqi Sun <sunrongqi@huawei.com>
(cherry picked from commit 8d766c57173cf6bdea0d8fcfa8fa3c1b61fd10ef)

14 months agoMerge pull request #57220 from rhcs-dashboard/wip-65758-squid
Pedro Gonzalez Gomez [Mon, 6 May 2024 09:24:58 +0000 (11:24 +0200)]
Merge pull request #57220 from rhcs-dashboard/wip-65758-squid

squid: mgr/dashboard: exclude cloned-deleted RBD snaps

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
14 months agoMerge pull request #57268 from zdover23/wip-doc-2024-05-05-backport-55380-to-squid-2
Anthony D'Atri [Sun, 5 May 2024 11:55:21 +0000 (07:55 -0400)]
Merge pull request #57268 from zdover23/wip-doc-2024-05-05-backport-55380-to-squid-2

doc/foundation: Updating members for Jan 2024

14 months agodoc/foundation: Updating members for Jan 2024 57268/head
Mike Perez [Tue, 30 Jan 2024 20:10:22 +0000 (12:10 -0800)]
doc/foundation: Updating members for Jan 2024

Signed-off-by: Mike Perez <thingee@gmail.com>
(cherry picked from commit f979ead661d716a4a1b7bd04a30e8af3691542a0)

14 months agoMerge pull request #57264 from zdover23/wip-doc-2024-05-04-backport-57252-to-squid
Zac Dover [Sat, 4 May 2024 13:02:58 +0000 (23:02 +1000)]
Merge pull request #57264 from zdover23/wip-doc-2024-05-04-backport-57252-to-squid

squid: doc/rados: PR#57022 unfinished business

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
14 months agodoc/rados: PR#57022 unfinished business 57264/head
Zac Dover [Fri, 3 May 2024 05:32:28 +0000 (15:32 +1000)]
doc/rados: PR#57022 unfinished business

Make the changes suggested by Anthony D'Atri in
https://github.com/ceph/ceph/pull/57022.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 93898d80836ac41041f75b5bf5398f9388abb52f)

14 months agoMerge pull request #57225 from zdover23/wip-doc-2024-05-02-cephadm-services-monitorin...
Zac Dover [Sat, 4 May 2024 12:37:04 +0000 (22:37 +1000)]
Merge pull request #57225 from zdover23/wip-doc-2024-05-02-cephadm-services-monitoring-squid

squid: doc/cephadm: Squid default images procedure

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Adam King <adking@redhat.com>
14 months agomgr/dashboard: add prometheus federation config for mulkti-cluster 57254/head
Aashish Sharma [Tue, 12 Dec 2023 08:38:26 +0000 (14:08 +0530)]
mgr/dashboard: add prometheus federation config for mulkti-cluster
monitoring

Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit 82b50b4eac819a71542d766b573f65819046f403)

14 months agoMerge pull request #56964 from adk3798/squid-dashboard-anon-grafana
Nizamudeen A [Fri, 3 May 2024 05:30:10 +0000 (11:00 +0530)]
Merge pull request #56964 from adk3798/squid-dashboard-anon-grafana

squid: mgr/dashboard: fix dashboard not visible on disabled anonymous access

Reviewed-by: Nizamudeen A <nia@redhat.com>
14 months agoMerge pull request #57055 from cbodley/wip-65636-squid
Casey Bodley [Thu, 2 May 2024 20:18:35 +0000 (21:18 +0100)]
Merge pull request #57055 from cbodley/wip-65636-squid

squid: doc/rgw: add release note for changes to rgw_realm init

Reviewed-by: Zac Dover <zac.dover@proton.me>
14 months agoos/: modify getattrs to clear attrs out param before populating 57006/head
Samuel Just [Thu, 18 Apr 2024 22:19:31 +0000 (15:19 -0700)]
os/: modify getattrs to clear attrs out param before populating

Passing in a non-empty map would otherwise exhibit quite unexpected
behavior.  For the bufferptr overload, any preexisting entries would
not be overwritten due to how std::map::emplace behaves.  For the
bufferlist overload, it would result in appending to any pre-existing
entries.

The prior commit cleans up one such inadvertent caller which resulted
in the below bug.

Fixes: https://tracker.ceph.com/issues/65185
Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit 915f92ba9dc8e192bdcebcb92e7d06a93a401f5d)

14 months agoMerge pull request #57246 from zdover23/wip-doc-2024-05-03-backport-57207-to-squid
Anthony D'Atri [Thu, 2 May 2024 18:30:34 +0000 (14:30 -0400)]
Merge pull request #57246 from zdover23/wip-doc-2024-05-03-backport-57207-to-squid

squid: doc/rados: s/cepgsqlite/cephsqlite/

14 months agodoc/rados: s/cepgsqlite/cephsqlite/ 57246/head
Zac Dover [Wed, 1 May 2024 16:42:46 +0000 (02:42 +1000)]
doc/rados: s/cepgsqlite/cephsqlite/

As stated in the commit-message line, this corrects the typo "cepg" to
the correct string "ceph".

This typo was discovered by https://github.com/test-erik and this was
brought to our attention way back in
https://github.com/ceph/ceph/pull/50420.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit ddef880947ac6b8b3b08092865f8a9a6fe03839c)

14 months agoMerge pull request #57095 from cbodley/wip-rgw-cache-size-squid
Casey Bodley [Thu, 2 May 2024 17:26:52 +0000 (18:26 +0100)]
Merge pull request #57095 from cbodley/wip-rgw-cache-size-squid

squid: rgw: increase default metadata cache size for accounts

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
14 months agoMerge pull request #57058 from cbodley/wip-65640-squid
Casey Bodley [Thu, 2 May 2024 17:26:36 +0000 (18:26 +0100)]
Merge pull request #57058 from cbodley/wip-65640-squid

squid: rgw/account: add bucket_quota to RGWAccountInfo

Reviewed-by: Oguzhan Ozmen <oozmen@bloomberg.net>
14 months agorgw/multisite-notification: retry storing bucket notification attrs for ECANCELED... 57242/head
kchheda3 [Fri, 19 Apr 2024 14:59:13 +0000 (10:59 -0400)]
rgw/multisite-notification: retry storing bucket notification attrs for ECANCELED(ConcurrentModification) errors.

An ECANCELED error coming from our write of the bucket instance metadat is a common error for metadata writes on secondary zones, because secondary write races with metadata sync from the write that is forwarded to the master zone

Signed-off-by: kchheda3 <kchheda3@bloomberg.net>
(cherry picked from commit 9ca76770434e4dd796afe2c88446f94279919026)

14 months agodoc/cephadm: Squid default images procedure 57225/head
Zac Dover [Thu, 2 May 2024 08:36:34 +0000 (18:36 +1000)]
doc/cephadm: Squid default images procedure

Address Adam King's request for version-specific
cephadm-container-image-retrieval procedures, which he requested here: https://github.com/ceph/ceph/pull/57208#discussion_r1586614140

Co-authored-by: Adam King <adking@redhat.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
14 months agorefactor of s3select response handler, adding continuation-response to parquet flow... 57231/head
Gal Salomon [Tue, 19 Mar 2024 11:45:58 +0000 (13:45 +0200)]
refactor of s3select response handler, adding continuation-response to parquet flow, refacor of error response

bug fix (init_success_response).
s3select submodule

fix for json-error-flow

Signed-off-by: Gal Salomon <gal.salomon@gmail.com>
(cherry picked from commit 06eadd66db4eb0a8688ee39ae13093a68f0868b5)

14 months agoMerge pull request #57208 from zdover23/wip-doc-2024-05-02-backport-57148-to-squid
Zac Dover [Thu, 2 May 2024 07:21:47 +0000 (17:21 +1000)]
Merge pull request #57208 from zdover23/wip-doc-2024-05-02-backport-57148-to-squid

squid: doc/cephadm: add default monitor images

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
14 months agomgr/dashboard: exclude cloned-deleted RBD snaps 57220/head
Ernesto Puerta [Tue, 30 Apr 2024 08:51:23 +0000 (10:51 +0200)]
mgr/dashboard: exclude cloned-deleted RBD snaps

Fixes: https://tracker.ceph.com/issues/65698
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
(cherry picked from commit 8b1ef2ee411b7c6fb52825bf577860f3727738c2)

14 months agoMerge pull request #56946 from aaSharma14/wip-64791-squid
Nizamudeen A [Thu, 2 May 2024 05:52:03 +0000 (11:22 +0530)]
Merge pull request #56946 from aaSharma14/wip-64791-squid

squid: mgr/dashboard: Allow the user to add the access/secret key on zone edit and not on zone creation

Reviewed-by: afreen23 <NOT@FOUND>
14 months agodoc/cephadm: add default monitor images 57208/head
Zac Dover [Tue, 30 Apr 2024 07:09:05 +0000 (17:09 +1000)]
doc/cephadm: add default monitor images

Add a list of default monitor images to the documentation. This commit
is made in response to a request from Eugen Block, and is made using the
information developed by Mr Block here:
https://lists.ceph.io/hyperkitty/list/ceph-users@ceph.io/thread/QGC66QIFBKRTPZAQMQEYFXOGZJ7RLWBN/.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit d6311d24c277f35fcae5097ed8a19843e62e6149)

14 months agoMerge pull request #56790 from ronen-fr/wip-rf-56389-to-squid
Ronen Friedman [Wed, 1 May 2024 11:26:24 +0000 (14:26 +0300)]
Merge pull request #56790 from ronen-fr/wip-rf-56389-to-squid

squid: osd/scrub: remove detection & handling of reservation timeouts from the code

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
14 months agoMerge pull request #56777 from ronen-fr/wip-rf-56459-squid
Ronen Friedman [Wed, 1 May 2024 10:16:40 +0000 (13:16 +0300)]
Merge pull request #56777 from ronen-fr/wip-rf-56459-squid

squid: osd/scrub:  implement reservation state as a ReplicaActive flag
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
14 months agoMerge pull request #56903 from adk3798/wip-65417-squid
Adam King [Tue, 30 Apr 2024 19:47:19 +0000 (15:47 -0400)]
Merge pull request #56903 from adk3798/wip-65417-squid

squid: cephadm: fix host-maintenance command always exiting with a failure

Reviewed-by: John Mulligan <jmulligan@redhat.com>
14 months agoMerge pull request #56900 from adk3798/wip-65381-squid
Adam King [Tue, 30 Apr 2024 19:44:39 +0000 (15:44 -0400)]
Merge pull request #56900 from adk3798/wip-65381-squid

squid: mgr/cephadm: pass daemon's current image when reconfiguring

Reviewed-by: John Mulligan <jmulligan@redhat.com>
14 months agoMerge pull request #57156 from zdover23/wip-doc-2024-04-30-backport-57154-to-squid
Anthony D'Atri [Tue, 30 Apr 2024 14:05:32 +0000 (10:05 -0400)]
Merge pull request #57156 from zdover23/wip-doc-2024-04-30-backport-57154-to-squid

squid: doc/rados/operations: rephrase OSDs peering

14 months agoMerge pull request #57159 from zdover23/wip-doc-2024-04-30-backport-57153-to-squid
Anthony D'Atri [Tue, 30 Apr 2024 14:04:32 +0000 (10:04 -0400)]
Merge pull request #57159 from zdover23/wip-doc-2024-04-30-backport-57153-to-squid

squid: doc/man/8/radosgw-admin: add get lifecycle command

14 months agodoc/man/8/radosgw-admin: add get lifecycle command 57159/head
rkhudov [Tue, 30 Apr 2024 10:00:36 +0000 (11:00 +0100)]
doc/man/8/radosgw-admin: add get lifecycle command

Signed-off-by: rkhudov <rhudov@gmail.com>
(cherry picked from commit 04393ec3c1a12d6a9405272ab2cffe9dfa67aa92)

14 months agodoc/rados/operations: rephrase OSDs peering 57156/head
Piotr Parczewski [Tue, 30 Apr 2024 10:56:44 +0000 (12:56 +0200)]
doc/rados/operations: rephrase OSDs peering

Signed-off-by: Piotr Parczewski <piotr@stackhpc.com>
(cherry picked from commit 048f6e539b3035175479a88a4cf6f774cca68ddb)

14 months agoMerge pull request #56412 from zdover23/wip-doc-2024-03-23-backport-56379-to-squid
Zac Dover [Tue, 30 Apr 2024 06:50:53 +0000 (16:50 +1000)]
Merge pull request #56412 from zdover23/wip-doc-2024-03-23-backport-56379-to-squid

squid: doc/install: fix typos in openEuler-installation doc

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
14 months agoMerge pull request #57140 from zdover23/wip-doc-2024-04-30-backport-57136-to-squid
Anthony D'Atri [Mon, 29 Apr 2024 16:42:46 +0000 (12:42 -0400)]
Merge pull request #57140 from zdover23/wip-doc-2024-04-30-backport-57136-to-squid

squid: doc/radosgw: disambiguate version-added remarks

14 months agodoc/radosgw: disambiguate version-added remarks 57140/head
Zac Dover [Mon, 29 Apr 2024 10:23:13 +0000 (20:23 +1000)]
doc/radosgw: disambiguate version-added remarks

Rewrite two sentences so that they explain precisely what was added to
Ceph and when it was added to Ceph.

This commit is made in response to a request made by Dr Per Mildner on
https://pad.ceph.com/p/Report_Documentation_Bugs.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 586e8e6577c6b62062d6ed60c439088705fbd2c1)

14 months agoMerge pull request #56497 from adk3798/wip-65124-squid
Adam King [Mon, 29 Apr 2024 15:18:43 +0000 (11:18 -0400)]
Merge pull request #56497 from adk3798/wip-65124-squid

squid: mgr/cephadm: add some NVMEof gateway fields to be configurable by cephadm

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
14 months agoMerge pull request #57121 from zdover23/wip-doc-2024-04-29-backport-57119-to-squid
Anthony D'Atri [Mon, 29 Apr 2024 12:36:07 +0000 (08:36 -0400)]
Merge pull request #57121 from zdover23/wip-doc-2024-04-29-backport-57119-to-squid

squid: doc/cephfs: edit front matter in client-auth.rst

14 months agodoc/cephfs: edit front matter in client-auth.rst 57121/head
Zac Dover [Sun, 28 Apr 2024 13:18:50 +0000 (23:18 +1000)]
doc/cephfs: edit front matter in client-auth.rst

Clarify the front matter in doc/cephfs/client-auth.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 713c7304d15279cbc2031efc05cc9e49911974fe)

14 months agoMerge pull request #57108 from zdover23/wip-doc-2024-04-27-backport-57105-to-squid
Zac Dover [Fri, 26 Apr 2024 23:48:52 +0000 (09:48 +1000)]
Merge pull request #57108 from zdover23/wip-doc-2024-04-27-backport-57105-to-squid

squid: doc/mgr: explain error message - dashboard.rst

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
14 months agodoc/mgr: explain error message - dashboard.rst 57108/head
Zac Dover [Fri, 26 Apr 2024 11:59:09 +0000 (21:59 +1000)]
doc/mgr: explain error message - dashboard.rst

Explain that an error message received in response to
"redirect_resolve_ip_addr True" might be caused by having an
insufficiently recent release of Ceph running in your cluster.

Fixes: https://tracker.ceph.com/issues/61312
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 78545030761330c44168dbb3f8d1e4c3c9a9a3bd)

14 months agorgw/lc: cleanup duplicate code 57104/head
Soumya Koduri [Wed, 10 Apr 2024 19:34:17 +0000 (01:04 +0530)]
rgw/lc: cleanup duplicate code

Cleaning up duplicate code around updating head

Signed-off-by: Soumya Koduri <skoduri@redhat.com>
(cherry picked from commit e2b3a3002f404c8e61fd792e773abde1ec60016e)

14 months agorgw/lc: advance head if the current entry doesn't exist
Soumya Koduri [Mon, 25 Mar 2024 18:08:57 +0000 (23:38 +0530)]
rgw/lc: advance head if the current entry doesn't exist

This is extension to https://github.com/ceph/ceph/pull/47595.

When skipping the non-exist LC entry, instead of get_next_entry(),
use advance_head() to fetch the next entry. In case the cycle
is finished for that shard, head should be reset to avoid lc process
being stuck in indefinite loop.

Fixes: https://tracker.ceph.com/issues/65160
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
(cherry picked from commit 86a8709dc8884c5f065946926648a75485002efb)

14 months agorgw: increase default metadata cache size for accounts 57095/head
Casey Bodley [Fri, 22 Mar 2024 14:23:31 +0000 (10:23 -0400)]
rgw: increase default metadata cache size for accounts

account users will put some extra pressure on the metadata cache,
because each request has to load metadata for the account and zero
or more groups, in addition to the user's access key and user metadata

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 451e03782e95dfd5b26aacb0d131126260b83d37)

14 months agolibrbd: make group and group snapshot IDs more random 57092/head
Ilya Dryomov [Wed, 17 Apr 2024 18:31:02 +0000 (20:31 +0200)]
librbd: make group and group snapshot IDs more random

Image IDs suffered from the same issue -- it was addressed in commit
be8373688c1b ("librbd: block_name_prefix is not created randomly").
The code for generating group IDs is duplicated in api/Group.cc and
got missed.

Instead of cut-and-pasting the fix, just call generate_image_id()
directly and rename variables for more explicitness.

Before:

  $ rados -p rbd ls | grep rbd_group_header
  rbd_group_header.10256b8b4567
  rbd_group_header.10216b8b4567
  rbd_group_header.10236b8b4567
  rbd_group_header.101f6b8b4567

After:

  $ rados -p rbd ls | grep rbd_group_header
  rbd_group_header.10255f555a5
  rbd_group_header.1023f347eafb
  rbd_group_header.101f24c75111
  rbd_group_header.1021dda4e122

Fixes: https://tracker.ceph.com/issues/65573
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 76ed07d2d8085b733f51540154cfaf917db05e86)

14 months agoMerge pull request #57078 from adk3798/squid-cephadm-no-downgrade
Zac Dover [Thu, 25 Apr 2024 05:46:15 +0000 (15:46 +1000)]
Merge pull request #57078 from adk3798/squid-cephadm-no-downgrade

squid: doc/cephadm: remove downgrade reference from upgrade docs

Reviewed-by: Zac Dover <zac.dover@proton.me>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
14 months agodoc/cephadm: remove downgrade reference from upgrade docs 57078/head
Adam King [Tue, 23 Apr 2024 16:04:39 +0000 (12:04 -0400)]
doc/cephadm: remove downgrade reference from upgrade docs

This has been in here for years, but cephadm will block
attempted upgrades to lower versions and we generally
don't want people to think this is supported or safe.

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 787130175d3d40d3671be88a81c4b8843655b01e)

14 months agoMerge pull request #56528 from adk3798/squid-mypy-bump
Adam King [Wed, 24 Apr 2024 15:37:42 +0000 (11:37 -0400)]
Merge pull request #56528 from adk3798/squid-mypy-bump

squid: python: mypy version bump

Reviewed-by: John Mulligan <jmulligan@redhat.com>
14 months agoMerge pull request #56899 from adk3798/wip-65378-squid
Adam King [Wed, 24 Apr 2024 15:34:27 +0000 (11:34 -0400)]
Merge pull request #56899 from adk3798/wip-65378-squid

squid: mgr/cephadm: make client-keyring deploying ceph.conf optional

Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
14 months agoMerge pull request #56715 from adk3798/squid-test-cephadm-correct-bootstrap-image
Adam King [Wed, 24 Apr 2024 15:32:24 +0000 (11:32 -0400)]
Merge pull request #56715 from adk3798/squid-test-cephadm-correct-bootstrap-image

squid: qa/cephadm: use squid image as default for test_cephadm workunit

Reviewed-by: John Mulligan <jmulligan@redhat.com>
14 months agoMerge pull request #56527 from adk3798/squid-tox-default-envs
Adam King [Wed, 24 Apr 2024 15:28:52 +0000 (11:28 -0400)]
Merge pull request #56527 from adk3798/squid-tox-default-envs

squid: python: allow unit tests to use tox default envs

Reviewed-by: John Mulligan <jmulligan@redhat.com>
14 months agomgr/cephadm: some changes to nvmeof conf file defaults 56497/head
Gil Bregman [Mon, 22 Apr 2024 09:32:15 +0000 (12:32 +0300)]
mgr/cephadm: some changes to nvmeof conf file defaults
Fixes https://tracker.ceph.com/issues/65566

Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
(cherry picked from commit da2d088c1319e980b5202fb65326e78daa014063)

14 months agopython-common/ceph/deployment: some changes to nvmeof conf file defaults
Gil Bregman [Mon, 22 Apr 2024 09:31:16 +0000 (12:31 +0300)]
python-common/ceph/deployment: some changes to nvmeof conf file defaults
Fixes https://tracker.ceph.com/issues/65566

Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
(cherry picked from commit c2aa1fcaf2d43a55953c77b991f688f4b060cd5e)

14 months agomgr/cephadm: make enable_monitor_client configurable for nvmeof
Adam King [Tue, 9 Apr 2024 16:19:06 +0000 (12:19 -0400)]
mgr/cephadm: make enable_monitor_client configurable for nvmeof

Currently, the mon client work is not merged on main, but our
default nvmeof container will attempt to make use of it by default,
causing it to crash. This makes it configurable and defaults the
behavior to false. That can be changed once the work is actually
present in main.

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 3276471ff765b0118105a7820a13d9e5efa9934b)

14 months agopython-common/ceph/deployment: add nvmeof configuration fields
Gil Bregman [Tue, 2 Apr 2024 10:23:43 +0000 (13:23 +0300)]
python-common/ceph/deployment: add nvmeof configuration fields
Fixes https://tracker.ceph.com/issues/65259

Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
(cherry picked from commit 187baffd56fde2499109e779b3dacd9fa4d52ecf)

14 months agomgr/cephadm: add some NVMEof gateway fields to be configurable by cephadm
Gil Bregman [Tue, 2 Apr 2024 10:22:56 +0000 (13:22 +0300)]
mgr/cephadm: add some NVMEof gateway fields to be configurable by cephadm
Fixes https://tracker.ceph.com/issues/65259

Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
(cherry picked from commit aa4adf97f6daec0a85b042a1591a6cc7ac137d14)

14 months agomgr/cephadm: add nvmeof configuration fields
Gil Bregman [Thu, 21 Mar 2024 09:06:52 +0000 (11:06 +0200)]
mgr/cephadm: add nvmeof configuration fields

Fixes: https://tracker.ceph.com/issues/64821
Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
(cherry picked from commit a16ac81c43be884f2dd7fc8b0566be5aa35b7ace)

Conflicts:
src/pybind/mgr/cephadm/templates/services/nvmeof/ceph-nvmeof.conf.j2
src/pybind/mgr/cephadm/tests/test_services.py

14 months agopython-common/ceph/deployment: add nvmeof configuration fields
Gil Bregman [Thu, 21 Mar 2024 09:07:54 +0000 (11:07 +0200)]
python-common/ceph/deployment: add nvmeof configuration fields

Fixes: https://tracker.ceph.com/issues/64821
Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
(cherry picked from commit 86a592730b09ab2cfaf4100907366050c932f30a)

14 months agoMerge pull request #57072 from zdover23/wip-doc-2024-04-24-backport-57051-to-squid
Anthony D'Atri [Wed, 24 Apr 2024 13:19:24 +0000 (09:19 -0400)]
Merge pull request #57072 from zdover23/wip-doc-2024-04-24-backport-57051-to-squid

squid: doc/rados: remove dual-stack docs

14 months agodoc/rados: remove dual-stack docs 57072/head
Zac Dover [Tue, 23 Apr 2024 06:37:27 +0000 (16:37 +1000)]
doc/rados: remove dual-stack docs

Remove references to dual-stack mode in
doc/rados/configuration/network-config-ref.rst and
doc/rados/configuration/msgr2.rst. This feature seems to have been
planned but never to have been completely implemented.

See the tracker issue listed below for an email exchange detailing the
confusion caused by the presence in the documentation of this
now-removed information.

Fixes: https://tracker.ceph.com/issues/65631
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit c65d2056c27d75f91af44e004d8defe7ffbf5fc8)

14 months agoosd/scrub: remove scrbcnt_resrv_timed_out perf counter 56790/head
Ronen Friedman [Fri, 22 Mar 2024 13:07:07 +0000 (08:07 -0500)]
osd/scrub: remove scrbcnt_resrv_timed_out perf counter

as the code that updates it, following a reservation timeout,
was removed.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
(cherry picked from commit 7eb287280e64b48447fe95875debc69e907fb7b7)

14 months agoosd/scrub: remove osd_scrub_reservation_timeout config option
Ronen Friedman [Fri, 22 Mar 2024 13:06:09 +0000 (08:06 -0500)]
osd/scrub: remove osd_scrub_reservation_timeout config option

following the removal of the reservation timeout handling code.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
(cherry picked from commit 2836805cfe9572b2e4c934716dc0967d9cdbfdc9)

14 months agoosd/scrub: remove detection & handling of reservation timeouts
Ronen Friedman [Fri, 22 Mar 2024 13:05:34 +0000 (08:05 -0500)]
osd/scrub: remove detection & handling of reservation timeouts

as no timeout can be set for reserver-based (queued)
reservation requests.

Fixes: https://tracker.ceph.com/issues/65044
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
(cherry picked from commit e8db183ce4f1c6db34129cc1c8c57912643d1ace)
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
14 months agoMerge pull request #57054 from rhcs-dashboard/wip-65255-squid
Nizamudeen A [Wed, 24 Apr 2024 06:54:26 +0000 (12:24 +0530)]
Merge pull request #57054 from rhcs-dashboard/wip-65255-squid

squid: mgr/dashboard: start using alertmanager v2

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
14 months agorgw: apply default quota config on account creation 57058/head
Casey Bodley [Mon, 22 Apr 2024 14:50:01 +0000 (10:50 -0400)]
rgw: apply default quota config on account creation

add new default quota config options for accounts analogous to
rgw_user_default_quota_max_objects/size. apply the default bucket quota
config options as-is

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 9ed8263edff7e87907bf24b054e5c7144c194dbe)

14 months agorgw/account: add bucket_quota to RGWAccountInfo
Casey Bodley [Thu, 18 Apr 2024 16:14:14 +0000 (12:14 -0400)]
rgw/account: add bucket_quota to RGWAccountInfo

support bucket quotas per account the same way as for user

Fixes: https://tracker.ceph.com/issues/65551
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit b9677714b2a57e4f97ff87c9d654f4dddae3c2b2)

14 months agomonitoring/ceph-mixin: set NVMeoFMaxGatewaysPerGroup to 4 56947/head
Adam King [Mon, 22 Apr 2024 12:48:15 +0000 (08:48 -0400)]
monitoring/ceph-mixin: set NVMeoFMaxGatewaysPerGroup to 4

Recommendation from the nvmeof team

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit c6871bbaf5eef1d855ec4ca269ab24adb4c00d73)

14 months agoceph-mixins: Update MIB to include nvmeof notification
Paul Cuzner [Thu, 15 Feb 2024 22:56:03 +0000 (11:56 +1300)]
ceph-mixins: Update MIB to include nvmeof notification

Signed-off-by: Paul Cuzner <pcuzner@ibm.com>
(cherry picked from commit 19ce7abd11d0fc6cc6a30115d31242f45f15ed05)

14 months agoceph-mixins: Add test cases for nvmeof alerts
Paul Cuzner [Tue, 13 Feb 2024 00:55:24 +0000 (13:55 +1300)]
ceph-mixins: Add test cases for nvmeof alerts

Signed-off-by: Paul Cuzner <pcuzner@ibm.com>
(cherry picked from commit c2534a6dbacf0f2ff5c649f7a0e04b5a94dbfdc0)

14 months agoceph-mixins: nvmeof alerts added
Paul Cuzner [Tue, 13 Feb 2024 00:54:48 +0000 (13:54 +1300)]
ceph-mixins: nvmeof alerts added

Signed-off-by: Paul Cuzner <pcuzner@ibm.com>
(cherry picked from commit e7d25482d1b418bf6b1c75dac60c64fd24ab6f01)

14 months agoceph-mixins: Add nvmeof alerts
Paul Cuzner [Fri, 9 Feb 2024 04:00:28 +0000 (17:00 +1300)]
ceph-mixins: Add nvmeof alerts

Signed-off-by: Paul Cuzner <pcuzner@ibm.com>
(cherry picked from commit f1573b76f3485aed148a8aeb69a40ef69df58912)

14 months agoceph-mixins: Add vars to support nvmeof alerts
Paul Cuzner [Fri, 9 Feb 2024 03:56:58 +0000 (16:56 +1300)]
ceph-mixins: Add vars to support nvmeof alerts

Signed-off-by: Paul Cuzner <pcuzner@ibm.com>
(cherry picked from commit feb1e69034026583a6770512a90b0172b6b5c76a)

14 months agoMerge pull request #57047 from zdover23/wip-doc-2024-04-23-backport-57032-to-squid
Anthony D'Atri [Tue, 23 Apr 2024 14:02:49 +0000 (10:02 -0400)]
Merge pull request #57047 from zdover23/wip-doc-2024-04-23-backport-57032-to-squid

squid: doc/rados: fix outdated value for ms_bind_port_max

14 months agodoc/rgw: add release note for changes to rgw_realm init 57055/head
Casey Bodley [Thu, 18 Apr 2024 21:57:46 +0000 (17:57 -0400)]
doc/rgw: add release note for changes to rgw_realm init

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 09f44129f95e5b6675e2b7a45012c67007e1e173)

14 months agomgr/dashboard: start using alertmanager v2 57054/head
Nizamudeen A [Tue, 26 Sep 2023 16:08:51 +0000 (21:38 +0530)]
mgr/dashboard: start using alertmanager v2

I was looking into sorting the alerts and saw there is an api v2 for
alertmanager which also has an endpoint like `alerts/groups` which might
be something that is useful for us.

Refer: https://github.com/prometheus/alertmanager/blob/main/api/v2/openapi.yaml

Fixes: https://tracker.ceph.com/issues/65070
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 6f2d0b14e52885d97fdb48c2e5d7d71201494a8f)

 Conflicts:
src/pybind/mgr/dashboard/controllers/prometheus.py
  - don't add the endpoint apart from the get_alertgroup one

15 months agodoc/rados: fix outdated value for ms_bind_port_max 57047/head
Pierre Riteau [Mon, 22 Apr 2024 09:28:53 +0000 (11:28 +0200)]
doc/rados: fix outdated value for ms_bind_port_max

The highest port number used by OSD or MDS daemons was increased from
7300 to 7568 in [1] but the documentation still refers to 7300 in
multiple locations.

[1] https://github.com/ceph/ceph/pull/42210

Fixes: https://tracker.ceph.com/issues/65609
Signed-off-by: Pierre Riteau <pierre@stackhpc.com>
(cherry picked from commit 23d2740241af2118652fef6e7d6a286f338a18f2)

15 months agoMerge pull request #57039 from zdover23/wip-doc-2024-04-23-backport-57022-to-squid
Anthony D'Atri [Mon, 22 Apr 2024 20:38:57 +0000 (16:38 -0400)]
Merge pull request #57039 from zdover23/wip-doc-2024-04-23-backport-57022-to-squid

squid: doc/rados: remove redundant pg repair commands

15 months agoMerge pull request #56958 from cbodley/wip-64552-squid
Casey Bodley [Mon, 22 Apr 2024 17:31:37 +0000 (18:31 +0100)]
Merge pull request #56958 from cbodley/wip-64552-squid

squid: rgw/http/client-side: disable curl path normalization

Reviewed-by: Oguzhan Ozmen <oozmen@bloomberg.net>
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>