]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Aashish Sharma [Tue, 20 Dec 2022 10:44:09 +0000 (16:14 +0530)]
Merge pull request #49501 from aaSharma14/wip-58309-quincy
quincy: mgr/dashboard: Add metric relative to osd blocklist
Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Aashish Sharma [Tue, 20 Dec 2022 08:10:02 +0000 (13:40 +0530)]
Merge pull request #49499 from aaSharma14/wip-58307-quincy
quincy:mgr/dashboard: rbd-mirror improvements
Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
colemitchell [Mon, 19 Dec 2022 17:57:46 +0000 (12:57 -0500)]
Merge pull request #49511 from zdover23/wip-doc-2022-12-20-backport-49510-to-quincy
quincy: doc/rados: add prompts to msgr2.rst
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Zac Dover [Mon, 19 Dec 2022 17:41:22 +0000 (03:41 +1000)]
doc/rados: add prompts to msgr2.rst
Add unselectable prompts to doc/rados/configuration/msgr2.rst.
https://tracker.ceph.com/issues/57108
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit
239e7c0e6891c774d93dc9cc65f33a2750b0f8d0 )
Aashish Sharma [Fri, 25 Nov 2022 06:07:54 +0000 (11:37 +0530)]
mgr/dashboard: Add metric relative to osd blocklist
It would be good to have a metric with number of clients "blocklisted" of command: "ceph osd blocklist ls". The reason to have this is metric is have an alert when this number raise up.
Fixes: https://tracker.ceph.com/issues/58083
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit
7c910eb0411bd1681ad76ca728390f8e2b168032 )
Aashish Sharma [Wed, 7 Dec 2022 05:25:24 +0000 (10:55 +0530)]
mgr/dashboard: Rbd Mirroring improvements
1.RBD images in dashboard shows default mirroring as journal
2.snapshot based mirroring schedule Interval got disabled to edit
3.unable to create snapshot of an image using dashboard
4.provide snapshot schedule info in a new column
5.dashboard doesn't allow importing peer bootstrap key to be imported for subsequent pools
Fixes: https://tracker.ceph.com/issues/58297
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit
1a37c5e001e0bbc2720e6dfabf6ba04442acabb7 )
(cherry picked from commit
a85ed9412faa3b3389cf2bdca7d11142bd571ddf )
Conflicts:
src/pybind/mgr/dashboard/services/rbd.py
Pere Diaz Bou [Mon, 19 Dec 2022 14:14:19 +0000 (15:14 +0100)]
Merge pull request #49505 from rhcs-dashboard/fix-tox-flake8-check
pybind/mgr: fix tox autopep8 args flake8
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Aashish Sharma [Mon, 19 Dec 2022 12:21:33 +0000 (17:51 +0530)]
pybind/mgr: fix tox autopep8 args flake8
Similar to mypy, we now need a backslash to signal
a newline doesn't mean to start a new command
Follow up of: https://github.com/ceph/ceph/pull/49361
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
Aashish Sharma [Mon, 19 Dec 2022 08:18:04 +0000 (13:48 +0530)]
Merge pull request #49475 from aaSharma14/wip-58298-quincy
quincy: mgr/dashboard: Fix CephPoolGrowthWarning alert
Nizamudeen A [Mon, 19 Dec 2022 07:40:41 +0000 (13:10 +0530)]
Merge pull request #49150 from rhcs-dashboard/wip-58122-quincy
quincy: mgr/dashboard: allow cross origin when the url is set
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Aashish Sharma [Mon, 19 Dec 2022 06:24:59 +0000 (11:54 +0530)]
Merge pull request #49476 from aaSharma14/wip-58300-quincy
quincy: mgr/dashboard: fix CephPGImbalance alert
Aashish Sharma [Mon, 19 Dec 2022 05:37:20 +0000 (11:07 +0530)]
Merge pull request #49481 from aaSharma14/wip-58302-quincy
quincy: mgr/dashboard: fix server side encryption config error
colemitchell [Sun, 18 Dec 2022 18:31:04 +0000 (13:31 -0500)]
Merge pull request #49492 from zdover23/wip-doc-2022-12-19-backport-49491-to-quincy
quincy: doc/rados: add prompts to ceph-conf.rst
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Zac Dover [Sun, 18 Dec 2022 15:29:33 +0000 (01:29 +1000)]
doc/rados: add prompts to ceph-conf.rst
Add unselectable prompts to doc/rados/ceph-conf.rst.
https://tracker.ceph.com/issues/57108
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit
874152535c5f8ca4a447b68040d62d1c34c3c24e )
zdover23 [Fri, 16 Dec 2022 16:24:06 +0000 (02:24 +1000)]
Merge pull request #49484 from zdover23/wip-doc-2022-12-17-backport-49394-to-quincy
quincy: doc/rbd: refine rbd-snapshot.rst
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Zac Dover [Fri, 9 Dec 2022 17:42:14 +0000 (03:42 +1000)]
doc/rbd: refine rbd-snapshot.rst
Refine the text in rbd-snapshot.rst
https://tracker.ceph.com/issues/57001
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit
292c826acd2d617fa93f4a4a0398110be1620d1c )
Aashish Sharma [Thu, 1 Dec 2022 10:32:14 +0000 (16:02 +0530)]
mgr/dashboard: fix server side encryption config error
Fixes: https://tracker.ceph.com/issues/58296
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit
7d2b83c57f6a73247ee1c3a33b3f6a491736afd3 )
Aashish Sharma [Thu, 15 Sep 2022 12:32:29 +0000 (18:02 +0530)]
mgr/dashboard: fix CephPGImbalance alert
Donot show the CephPgImbalance alert if the balancer shows no optimization required
Fixes: https://tracker.ceph.com/issues/55568
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit
a75792d5c3c78feffc0cc564deb9bcac19584503 )
Aashish Sharma [Tue, 18 Oct 2022 11:12:32 +0000 (16:42 +0530)]
mgr/dashboard: Fix CephPoolGrowthWarning alert
Prometheus reports an error - many-to-many matching not allowed: matching labels must be unique on one side for CephPoolGrowthWarning if we have same pool ids on two different instances.
Fixes: https://tracker.ceph.com/issues/58017
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit
97189b66afd4623ae09bc4ba12e1af6f69821793 )
colemitchell [Fri, 16 Dec 2022 01:45:11 +0000 (20:45 -0500)]
Merge pull request #49468 from zdover23/wip-doc-2022-12-16-backport-49467-to-quincy
quincy: doc/rados: clarify default EC pool from simplest
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Zac Dover [Fri, 16 Dec 2022 01:07:51 +0000 (11:07 +1000)]
doc/rados: clarify default EC pool from simplest
Distinguish between the default erasure-coded pool (k=2 m=2) and the
simplest erasure-coded pool (k=2 m=1).
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit
63c27ab8e746127b89120d4c47b427d13433758c )
Sridhar Seshasayee [Thu, 15 Dec 2022 05:48:48 +0000 (11:18 +0530)]
Merge pull request #49437 from sseshasa/wip-58273-quincy
quincy: osd: Reduce backfill/recovery default limits for mClock and other optimizations
Reviewed-by: Neha Ojha <nojha@redhat.com>
colemitchell [Thu, 15 Dec 2022 05:02:03 +0000 (00:02 -0500)]
Merge pull request #49450 from zdover23/wip-doc-2022-12-15-backport-49445-to-quincy
quincy: doc/cephfs: fix "e.g." in posix.rst
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Zac Dover [Thu, 15 Dec 2022 04:08:20 +0000 (14:08 +1000)]
doc/cephfs: fix "e.g." in posix.rst
Remove "e.g." and replace it with "for example".
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit
ac20eb83fe0decb2ffa349622d92331dcf225932 )
colemitchell [Thu, 15 Dec 2022 04:52:17 +0000 (23:52 -0500)]
Merge pull request #49448 from zdover23/wip-doc-2022-12-15-backport-49441-to-quincy
quincy: doc/cephfs - s/yet to here/yet to hear/ posix.rst
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
colemitchell [Thu, 15 Dec 2022 04:50:14 +0000 (23:50 -0500)]
Merge pull request #49446 from zdover23/wip-doc-2022-12-15-backport-49442-to-quincy
quincy: doc/cephfs: s/all of there are/all of these are/
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Wed, 14 Dec 2022 20:51:29 +0000 (06:51 +1000)]
doc/cephfs - s/yet to here/yet to hear/ posix.rst
Correct "yet to here" to "yet to hear" in posix.rst.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit
03bfcb134b36ed1af484108f167f35271e09204c )
Zac Dover [Wed, 14 Dec 2022 21:07:44 +0000 (07:07 +1000)]
doc/cephfs: s/all of there are/all of these are/
s/all of there are/all of these are/ in posix.rst.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit
e1c5bcd73ba666f618947473a0e4da35e52dbaaa )
Sridhar Seshasayee [Mon, 12 Dec 2022 07:09:33 +0000 (12:39 +0530)]
qa: Allow tests to override recovery configs with mClock scheduler enabled
Set osd_mclock_override_recovery_settings option to true for tests that
modify recovery/backfill configuration options. This prevents logging of
the cluster warning when modifying recovery/backfill limits.
Fixes: https://tracker.ceph.com/issues/57529
Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
(cherry picked from commit
5b2fee21e85ff46441701f2e3cdf43f13181db54 )
Sridhar Seshasayee [Fri, 7 Oct 2022 11:44:47 +0000 (17:14 +0530)]
qa/standalone: Add/Modify tests to verify mclock recovery/backfill limits
- Consolidate all mclock standalone tests under
qa/standalone/misc/mclock-config.sh.
- Revert existing tests in ceph-helpers.sh that verified the earlier hard
override of recovery/backfill limits.
- Add new tests to verify the procedure to change the recovery/backfill
limits with mclock scheduler.
Fixes: https://tracker.ceph.com/issues/57529
Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
(cherry picked from commit
9c72116b1cdeaa5593932135c05e00cc5d701534 )
Sridhar Seshasayee [Mon, 10 Oct 2022 13:18:13 +0000 (18:48 +0530)]
doc: Update mClock config reference doc to reflect new max recovery limits
Document the following:
- New max backfill/recovery defaults for mClock.
- Steps to modify the backfill/recovery defaults.
- Modify defaults using new osd_mclock_override_recovery_settings option
- Steps to mitigate unrealistic OSD bench results to set OSD capacity.
- New capacity threshold options for ssd/hdd
Fixes: https://tracker.ceph.com/issues/57529
Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
(cherry picked from commit
a4c2e28877daee0b5ad88c2ea9d359d567d473be )
Sridhar Seshasayee [Mon, 10 Oct 2022 05:47:54 +0000 (11:17 +0530)]
common: Optimize the HDD mClock cost parameters.
With the earlier cost per io and cost per byte parameters, the
client ops performance was good but the recovery ops were taking
much longer to complete. The new cost parameters optimizes this
further so that the recovery ops progress faster while
maintaining similar client throughput.
This optimization is tested on both a small cluster and a larger
cluster in a scaled environment.
Fixes: https://tracker.ceph.com/issues/57529
Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
(cherry picked from commit
38655922870dd9dc36a23df6e01492da6ad44e1b )
Sridhar Seshasayee [Fri, 23 Sep 2022 11:36:38 +0000 (17:06 +0530)]
osd: Ignore osd bench results for mclock if it exceeds the set threshold
The osd bench may in some cases show unrealistic results. The IOPS capacity
reported is used for QoS specific calculations in the mClock scheduler. If
the IOPS capacity is unrealistic, it could result is a performance impact
to the ops handled by mClock scheduler.
To avoid this, do not consider the results of the osd bench if it breaches
a threshold set for hdd and ssd media. The existing default setting will
be enforced as a safety measure. A cluster log warning is raised for the
osd.
Fixes: https://tracker.ceph.com/issues/57529
Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
(cherry picked from commit
737a7f1cf6194d3b286657587a2123ee5b688a3e )
Sridhar Seshasayee [Mon, 19 Sep 2022 08:48:33 +0000 (14:18 +0530)]
osd: Reduce default max backfill/recoveries for mclock to realistic limits
The earlier max number of backfill and recovery limits were overly
optimistic and caused recovery ops to overwhelm client ops regardless of
the mclock profile type.
Set the max backfill limit to 10. Set the max recovery limit to 10 for
osds having HDD backing device. For osds having SSD backing device, set
the recovery limit to 20.
Introduce and new config option, 'osd_mclock_override_recovery_settings',
that when set (false by default) allows the modification of the max
backfill and recovery options with mclock scheduler enabled.
It is important to note that with 'osd_mclock_override_recovery_settings'
disabled, the config subsystem will still allow the changes made to the
recovery and backfill settings when using the cli commands as the level at
which the change is made is always greater than CONF_DEFAULT. To counter this,
the osd will forcibly revert the recovery and backfill limits to the mClock
defaults by removing the existing setting from the config store and raises a
cluster log warning indicating the revert. This should force the user to set
the 'osd_mclock_override_recovery_settings' option first and then make changes
to the recovery and backfill limits.
Fixes: https://tracker.ceph.com/issues/57529
Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
(cherry picked from commit
89e48395f8b1329066a1d7e05a4e9e083c88c1a6 )
Laura Flores [Wed, 14 Dec 2022 17:44:28 +0000 (11:44 -0600)]
Merge pull request #49333 from aclamk/wip-58103-quincy
quincy: [bluestore] Improve deferred write decision
Avan Thakkar [Thu, 8 Dec 2022 11:16:21 +0000 (16:46 +0530)]
mgr/dashboard: allow Origin for CORS if present in config `cross_origin_url`
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
(cherry picked from commit
04cfd23122248a7262a29003b9e5b4c18edbfb5b )
Nizamudeen A [Fri, 25 Nov 2022 14:53:31 +0000 (20:23 +0530)]
mgr/dashboard: allow cross origin when the url is set
Allow CORS when the cross_origin_url is set in the config opt.
you have to update the cross_origin_url setting with the url of the
requesting entity.
The request needs to have the header `Access-Control-Allow-Origin`
with the origin URL
The url can be set using this command
`ceph config set mgr mgr/dashboard/cross_origin_url
http://localhost:4200`
multiple urls can be set as
`ceph config set mgr mgr/dashboard/cross_origin_url
http://localhost:4200,http://localhost:4201`
If multiple url is provided in the configuration option, then whatever
url is there in the Access-Control-Allow-Origin request header will be
allowed for CORS
Once the URL is set you have to restart the dashboard module to restart
the cherrypy server with the new CORS policies
Fixes: https://tracker.ceph.com/issues/58086
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit
1cf017bde492d3058d05b4375c1168cec9002afd )
Adam King [Wed, 14 Dec 2022 12:58:30 +0000 (07:58 -0500)]
Merge pull request #49361 from adk3798/tox-upgrade-fixes
quincy: pybind/mgr: fixup after upgrading tox versions
Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
colemitchell [Wed, 14 Dec 2022 07:07:59 +0000 (02:07 -0500)]
Merge pull request #49424 from zdover23/wip-doc-2022-12-14-backport-49421-to-quincy
quincy: doc/glossary: add "FQDN" entry
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Zac Dover [Wed, 14 Dec 2022 05:59:51 +0000 (15:59 +1000)]
doc/glossary: add "FQDN" entry
Add "FQDN" definition to doc/glossary.rst.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit
e919941036c6576d7085ea7fa611011cccd17fa9 )
colemitchell [Tue, 13 Dec 2022 04:56:32 +0000 (23:56 -0500)]
Merge pull request #49397 from zdover23/wip-doc-2022-12-13-backport-49396-to-quincy
quincy: doc/glossary - add "secrets"
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Zac Dover [Tue, 13 Dec 2022 04:39:35 +0000 (14:39 +1000)]
doc/glossary - add "secrets"
Add "secrets" to doc/glossary.rst.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit
a36409d3de77b37788a07ebf1380514c8bffd6ad )
Kefu Chai [Thu, 8 Dec 2022 16:32:26 +0000 (00:32 +0800)]
cmake: temporarily disable py3 test
py3 tries to import all python modules to ensure that they are
python3 compatible. but the installation fails on jenkins test node:
Resolved https://github.com/ceph/teuthology.git to commit
4da97cf64e542f347ec47b7bdbe5eca99759f9b7
Installing build dependencies: started
error: subprocess-exited-with-error
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit
da40d8464013812e7d9e4e653eb5179ef3841394 )
Kefu Chai [Thu, 8 Dec 2022 16:49:37 +0000 (00:49 +0800)]
pybind/mgr: do not test with py37
as we always test with ubuntu jammy, which does not provide python3.7:
py37: skipped because could not find python interpreter with spec(s): py37
so there is no point testing with python3.7.
also, in tox v4, it is not able to handle "key = value" anymore, where
value has newlines in it. so we need to find a better way passing
command line options to the test command.
this change partially reverts
2dd86c9e3eca6e14a04a821edf3a654f31da7a21
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit
c67106b120c0289f0c26d2f89892e8954b3b57bd )
Conflicts:
src/pybind/mgr/tox.ini
Adam King [Fri, 9 Dec 2022 16:10:36 +0000 (11:10 -0500)]
mgr/pybind: fix mypy arg parsing
On the new tox version it is treating each line as a new command
so it will do something like "mypy --config-file=../../mypy.ini"
as one command and then "-m balancer" as a totally separate command.
The first one immediately fails as it doesn't include any modules
to test. Adding backslashes to the ends of the lines gets it to
handle the lines as one long command
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit
8e5840ff2c5815897e3eaeb136927971ad6f5384 )
Adam King [Fri, 9 Dec 2022 16:25:01 +0000 (11:25 -0500)]
pybind/mgr: fix tox autopep8 args
Similar to mypy, we now need a backslash to signal
a newline doesn't mean to start a new command
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit
2ecd74cdac098b3b4cdd209c10ce00f050aa8a8a )
Avan [Mon, 12 Dec 2022 10:10:48 +0000 (15:40 +0530)]
Merge pull request #48788 from rhcs-dashboard/wip-57995-quincy
quincy: mgr/dashboard: paginate services
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: melissa-kun-li <NOT@FOUND>
colemitchell [Mon, 12 Dec 2022 04:37:24 +0000 (23:37 -0500)]
Merge pull request #49384 from zdover23/wip-doc-2022-12-12-backport-49383-to-quincy
quincy: doc/rados: add prompts to user-management.rst
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Zac Dover [Mon, 12 Dec 2022 04:22:40 +0000 (14:22 +1000)]
doc/rados: add prompts to user-management.rst
Add unselectable prompts to doc/rados/operations/user-management.rst.
https://tracker.ceph.com/issues/57108
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit
46f9506e4ce5fbf0db7ca06f638df7678a382760 )
colemitchell [Sat, 10 Dec 2022 21:36:19 +0000 (16:36 -0500)]
Merge pull request #49377 from zdover23/wip-doc-2022-12-11-backport-49376-to-quincy
quincy: doc/install: update clone-source.rst
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Zac Dover [Sat, 10 Dec 2022 20:25:13 +0000 (06:25 +1000)]
doc/install: update clone-source.rst
Beef up clone-source.rst. Repair semantics. Add internal references. Fix
a broken "git submodule foreach git clean -fdx" command.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit
344ef1553e4d0ec86153252891a194097548c602 )
colemitchell [Sat, 10 Dec 2022 04:56:19 +0000 (23:56 -0500)]
Merge pull request #49371 from zdover23/wip-doc-2022-12-10-backport-49368-to-quincy
quincy: doc/rados: add prompts to upmap.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
colemitchell [Sat, 10 Dec 2022 04:54:04 +0000 (23:54 -0500)]
Merge pull request #49369 from zdover23/wip-doc-2022-12-10-backport-49367-to-quincy
quincy: doc/rados: add prompts to stretch-mode.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Sat, 10 Dec 2022 04:34:46 +0000 (14:34 +1000)]
doc/rados: add prompts to upmap.rst
Add unselectable prompts to doc/rados/operations/upmap.rst.
https://tracker.ceph.com/issues/57108
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit
06d8ac91b2e3f235088940565e9d7e003edc964a )
Zac Dover [Sat, 10 Dec 2022 04:15:45 +0000 (14:15 +1000)]
doc/rados: add prompts to stretch-mode.rst
Add unselectable prompts to doc/rados/operations/stretch-mode.rst.
https://tracker.ceph.com/issues/57108
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit
bafe76c20488006ced7d9a2f6b82a54540dd7a89 )
colemitchell [Sat, 10 Dec 2022 03:57:25 +0000 (22:57 -0500)]
Merge pull request #49365 from zdover23/wip-doc-2022-12-10-backport-49364-to-quincy
quincy: doc/rbd: remove typo and ill-formed command
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Zac Dover [Sat, 10 Dec 2022 03:20:17 +0000 (13:20 +1000)]
doc/rbd: remove typo and ill-formed command
Ingest Ilya Dryomov's comments here https://github.com/ceph/ceph/pull/49340/files#r1044365857
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit
8df894b753ce15852cd72d5be22e2286a053b6e8 )
Kefu Chai [Thu, 8 Dec 2022 14:34:38 +0000 (22:34 +0800)]
qa: add pytest to deps of py3 env
otherwise it is mising when running test, and we'd have following
failure:
py3: exit 2 (0.00 seconds) /home/jenkins-build/build/workspace/ceph-pull-requests/qa> pytest --assert=plain test_import.py
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit
127dd54db84afb90ae20fdc7c4ecdcbf789aec25 )
Kefu Chai [Thu, 8 Dec 2022 06:42:42 +0000 (14:42 +0800)]
qa: set locale to C.UTF-8 in tox.ini
as ansible is using UTF-8 encoded characters in the file names, so,
to avoid failures like:
File "/home/jenkins-build/build/workspace/ceph-pull-requests/qa/.tox/py3/lib/python3.10/site-packages/pip/_internal/utils/unpacking.py", line 217, in untar_file
with open(path, "wb") as destfp:
UnicodeEncodeError: 'latin-1' codec can't encode characters in position 137-140: ordinal not in range(256)
we have to set a locale which is able to handle UTF-8.
see also https://github.com/ceph/teuthology/pull/1671
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit
bc2b551e9fc94697aee42de34de03d0a2a819850 )
Kefu Chai [Thu, 8 Dec 2022 10:25:20 +0000 (18:25 +0800)]
pybind/mgr: drop cython from requires
cython is not required for running tox commands.
this should address the test failure like:
ROOT: will run in automatically provisioned tox, host /home/jenkins-build/build/workspace/ceph-pull-requests/build/mgr-virtualenv/bin/python3.10 is missing [requires (has)]: cython
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit
c9cc795d02682f550098e517a01cf2adc7502906 )
Kefu Chai [Thu, 8 Dec 2022 10:23:32 +0000 (18:23 +0800)]
cephadm: drop cython from requires
cython is not required for launching the tox environment.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit
8b20bb8ca2b8f110a030a2f3fffd849faa125948 )
Kefu Chai [Thu, 8 Dec 2022 06:53:33 +0000 (14:53 +0800)]
*: s/whitelist_externals/allowlist_externals/
as allowlist_externals was introduced in
tox v4.0. see
https://github.com/tox-dev/tox/commit/
5e33fda1a40ffb4973de3d607a572891eb3cb2d2 , but
this option was backported to 3.18 as an alias of whitelist_externals, so we don't need
to specify the minversion to 4.0 in this change.
as we started using tox 4.0 and up (v4.0.2 in specific). tox complains
and fails like:
alerts-lint: failed with promtool is not allowed, use allowlist_externals to allow it
alerts-lint: FAIL code 1 (9.25 seconds)
see https://tox.wiki/en/latest/faq.html#tox-4-removed-tox-ini-keys
and https://tox.wiki/en/latest/config.html#allowlist_externals
it'd be nice to use a more inclusive language also. so, in this change,
s/whitelist_externals/allowlist_externals/ in all tox.ini in this
project.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit
34e2e33870b1ce381f9cd3eead882daa7b640b81 )
Yuri Weinstein [Fri, 9 Dec 2022 17:12:46 +0000 (09:12 -0800)]
Merge pull request #48314 from andriytk/fix-rpmbuild-quincy
quincy: compressor: fix rpmbuild on RHEL-8
Reviewed-by: Casey Bodley <cbodley@redhat.com>
colemitchell [Fri, 9 Dec 2022 07:10:54 +0000 (02:10 -0500)]
Merge pull request #49356 from zdover23/wip-doc-2022-12-09-backport-49342-to-quincy
quincy: doc/rbd: refine "Removing a Block Device Image"
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Zac Dover [Fri, 9 Dec 2022 01:16:27 +0000 (11:16 +1000)]
doc/rbd: refine "Removing a Block Device Image"
Refine and add unselectable prompts to "Removing a Block Device Image"
in doc/rbd/rados-rbd-cmds.
https://tracker.ceph.com/issues/57001
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit
3a6284a49bf41030bb20a5714b0dfce92928438b )
colemitchell [Fri, 9 Dec 2022 07:04:15 +0000 (02:04 -0500)]
Merge pull request #49354 from zdover23/wip-doc-2022-12-09-backport-49343-to-quincy
quincy: doc/rbd: refine "Restoring a Block Device Image"
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
colemitchell [Fri, 9 Dec 2022 07:01:49 +0000 (02:01 -0500)]
Merge pull request #49352 from zdover23/wip-doc-2022-12-09-backport-49341-to-quincy
quincy: doc/rbd: refine "Resizing a Block Device Image"
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
colemitchell [Fri, 9 Dec 2022 06:58:42 +0000 (01:58 -0500)]
Merge pull request #49350 from zdover23/wip-doc-2022-12-09-backport-49340-to-quincy
quincy: doc/rbd: refine "Retrieving Image Information"
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Zac Dover [Fri, 9 Dec 2022 01:31:07 +0000 (11:31 +1000)]
doc/rbd: refine "Restoring a Block Device Image"
Refine and add unselectable prompts to "Restoring a Block Device Image"
in doc/rbd/rados-rbd-cmds.rst.
https://tracker.ceph.com/issues/57001
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit
8fb4edb92d82019065a884d63a71ca68e8c8de6a )
colemitchell [Fri, 9 Dec 2022 06:56:03 +0000 (01:56 -0500)]
Merge pull request #49348 from zdover23/wip-doc-2022-12-09-backport-49339-to-quincy
quincy: doc/rbd: refine "Listing Block Device Images"
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Zac Dover [Fri, 9 Dec 2022 01:02:31 +0000 (11:02 +1000)]
doc/rbd: refine "Resizing a Block Device Image"
Refine and add unselectable prompts to "Resizing a Block Device Image"
in doc/rbd/rados/rbd-cmds.rst.
https://tracker.ceph.com/issues/57001
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit
078bec94d08529c87766c12055c365fc53d356a2 )
Zac Dover [Fri, 9 Dec 2022 00:25:55 +0000 (10:25 +1000)]
doc/rbd: refine "Retrieving Image Information"
Refine the text and prompts in "Retrieving Image Information" in
doc/rbd/rados-rbd-cmds.rst.
https://tracker.ceph.com/issues/57001
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit
d418037b3817b62cee4cb151ab84bb24c676b117 )
colemitchell [Fri, 9 Dec 2022 06:50:58 +0000 (01:50 -0500)]
Merge pull request #49346 from zdover23/wip-doc-2022-12-09-backport-49338-to-quincy
quincy: doc/rbd: refine "Creating a Block Device Image"
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Zac Dover [Fri, 9 Dec 2022 00:21:47 +0000 (10:21 +1000)]
doc/rbd: refine "Listing Block Device Images"
Refine the text and prompts in "Listing Block Device Images" in
doc/rbd/rados-rbd-cmds.rst.
https://tracker.ceph.com/issues/57001
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit
ad3c93535fbb614d593f74806fdfccdd60a1696f )
Zac Dover [Thu, 8 Dec 2022 23:53:14 +0000 (09:53 +1000)]
doc/rbd: refine "Creating a Block Device Image"
Refine the English and prompts in "Creating a Block Device Image" in
doc/rbd/rados-rbd-cmds.rst.
https://tracker.ceph.com/issues/57001
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit
20b14437d6847fefdd3435bc9ec7a8b5580968f8 )
Adam Kupczyk [Thu, 13 Oct 2022 17:55:13 +0000 (17:55 +0000)]
test/store_test: add tests for deferred writes
Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
(cherry picked from commit
6eb5ea7ea8652eafd84e56a773bd53363b7f205f )
Adam Kupczyk [Thu, 13 Oct 2022 15:01:21 +0000 (15:01 +0000)]
test/store_test: extend test that reproduces bug #56488
Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
(cherry picked from commit
3e8e4fff587375bc7863769ce6d7fb0757bafb4c )
Adam Kupczyk [Thu, 13 Oct 2022 14:25:42 +0000 (14:25 +0000)]
os/bluestore: fix no deferred writing
Fixes: https://tracker.ceph.com/issues/56488
Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
(cherry picked from commit
9a57b631730674c2c4d94383002813ad2b7e868d )
Igor Fedotov [Mon, 18 Jul 2022 16:00:40 +0000 (19:00 +0300)]
test/store_test: introduce a case to reproduce bug #56488
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit
1000f8d8c85e486fd958abed4a03de05c054c484 )
zdover23 [Thu, 8 Dec 2022 11:38:36 +0000 (21:38 +1000)]
Merge pull request #49318 from zdover23/wip-doc-2022-12-08-backport-49306-to-quincy
quincy: doc/rbd: refine "Create a Block Device User"
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Wed, 7 Dec 2022 14:43:31 +0000 (00:43 +1000)]
doc/rbd: refine "Create a Block Device User"
Refine "Create a Block Device User", after suggestions made by Ilya
Dryomov in https://github.com/ceph/ceph/pull/49301#pullrequestreview-
1208285685
https://tracker.ceph.com/issues/57001
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit
b6cc04e0bc1a30df7434b1fc857846750e714b31 )
zdover23 [Thu, 8 Dec 2022 05:22:43 +0000 (15:22 +1000)]
Merge pull request #49307 from zdover23/wip-doc-2022-12-08-backport-49282-to-quincy
quincy: doc/rbd: refine "Create a Block Device Pool"
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Laura Flores [Wed, 7 Dec 2022 22:34:05 +0000 (16:34 -0600)]
Merge pull request #46896 from ceph/wip-yuriw-quincy-p2p-quincy
quincy: qa/tests: initial draft for quincy p2p tests
Zac Dover [Tue, 6 Dec 2022 13:14:49 +0000 (23:14 +1000)]
doc/rbd: refine "Create a Block Device Pool"
Refine the "Create a Block Device Pool" section of
doc/rbd/rados-rbd-cmds.rst.
https://tracker.ceph.com/issues/57001
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit
987d3163a1d15b0f5e2870cf4d1d63e38bec9a34 )
Adam King [Wed, 7 Dec 2022 16:13:15 +0000 (11:13 -0500)]
Merge pull request #49059 from idryomov/wip-cephadm-flake8-quincy
quincy: cephadm: pin flake8 to 5.0.4
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
zdover23 [Wed, 7 Dec 2022 14:33:31 +0000 (00:33 +1000)]
Merge pull request #49300 from zdover23/wip-doc-2022-12-07-backport-49283-to-quincy
quincy: doc/rbd: refine "Create a Block Device User"
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Zac Dover [Tue, 6 Dec 2022 14:20:24 +0000 (00:20 +1000)]
doc/rbd: refine "Create a Block Device User"
Refine "Create a Block Device User" in doc/rbd/rados-rbd-cmds.rst.
https://tracker.ceph.com/issues/57001
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit
51bc43845f03956b26c2a65fbd89a5654b860093 )
zdover23 [Tue, 6 Dec 2022 13:36:04 +0000 (23:36 +1000)]
Merge pull request #49275 from zdover23/wip-doc-2022-12-06-backport-49270-to-quincy
quincy: doc/rados: add prompts to placement-groups.rst (3)
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
zdover23 [Tue, 6 Dec 2022 13:35:04 +0000 (23:35 +1000)]
Merge pull request #49273 from zdover23/wip-doc-2022-12-06-backport-49269-to-quincy
quincy: doc/rados: add prompts to placement-groups.rst
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Zac Dover [Tue, 6 Dec 2022 07:13:44 +0000 (17:13 +1000)]
doc/rados: add prompts to placement-groups.rst (3)
Add unselectable prompts to doc/rados/operations/placement-groups.rst (3
of 3).
https://tracker.ceph.com/issues/57108
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit
eb24e24e99e76adae954fc56f509b8adc7217a16 )
colemitchell [Tue, 6 Dec 2022 07:31:12 +0000 (02:31 -0500)]
Merge pull request #49271 from zdover23/wip-doc-2022-12-06-backport-49268-to-quincy
quincy: doc/rados: add prompts to placement-groups.rst
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Zac Dover [Tue, 6 Dec 2022 07:07:18 +0000 (17:07 +1000)]
doc/rados: add prompts to placement-groups.rst
Add unselectable prompts to doc/rados/operations/placement-groups.rst.
(2 of 3)
https://tracker.ceph.com/issues/57108
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit
8574cfb847bb555bc724a6bd44a815f83e3dd364 )
Zac Dover [Tue, 6 Dec 2022 06:56:02 +0000 (16:56 +1000)]
doc/rados: add prompts to placement-groups.rst
Add unselectable prompts to doc/rados/operations/placement-groups.rst.
https://tracker.ceph.com/issues/57108
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit
ec38804d5a9007bbccb3d841f4e882d7c7a5951b )
colemitchell [Tue, 6 Dec 2022 06:17:14 +0000 (01:17 -0500)]
Merge pull request #49265 from zdover23/wip-doc-2022-12-06-backport-49264-to-quincy
quincy: doc/glossary: add matter to "RBD"
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Zac Dover [Tue, 6 Dec 2022 04:15:43 +0000 (14:15 +1000)]
doc/glossary: add matter to "RBD"
Clarify that "RBD" and "Ceph Block Device" and "RADOS Block Device" all
refer to the same thing.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit
acdb2a6ee357f3b662580d6d7bc815af08af730e )
Yuri Weinstein [Mon, 5 Dec 2022 17:34:37 +0000 (09:34 -0800)]
Merge pull request #48543 from ronen-fr/wip-rf-acting-quincy
Quincy: osd/scrub: use the actual active set when requesting replicas…
Reviewed-by: Samuel Just <sjust@redhat.com>
Yuri Weinstein [Mon, 5 Dec 2022 17:33:55 +0000 (09:33 -0800)]
Merge pull request #47925 from rzarzynski/wip-56648-quincy
quincy: pybind/mgr/autoscaler: Donot show NEW PG_NUM value if autoscaler is not on
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Prashant D <pdhange@redhat.com>
colemitchell [Mon, 5 Dec 2022 16:50:48 +0000 (11:50 -0500)]
Merge pull request #49254 from zdover23/wip-doc-2022-12-06-backport-49252-to-quincy
quincy: doc/glossary: add DAS
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Zac Dover [Mon, 5 Dec 2022 13:43:29 +0000 (23:43 +1000)]
doc/glossary: add DAS
Add a definition for "DAS" (directly attached storage).
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit
a1f53a0fc0314c5c8a5cb0cb6d47acf20a4e52d0 )
colemitchell [Mon, 5 Dec 2022 03:23:44 +0000 (22:23 -0500)]
Merge pull request #49244 from zdover23/wip-doc-2022-12-05-backport-49241-to-quincy
quincy: doc/rados: add prompts to monitoring.rst
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>