script/redmine-upkeep: bullet issue list

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

script/redmine-upkeep: add stronger note on upkeep-failed tag in failure message

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

script/redmine-upkeep: do not raise commennt if upkeep-failed already present

If the script is run manually on an issue, don't leave a new comment if we
already have the issue tagged with upkeep-failed.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

script/redmine-upkeep: correct filter out of upkeep-failed

"!~" is the proper filter for "does not contain".

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

.github/workflows: allow redmine-upkeep to write comments

Fixes errors like:

    Posting a comment to GitHub PR #62992.
    GitHub API error posting comment to PR #62992: 401 Client Error: Unauthorized for url: https://api.github.com/repos/ceph/ceph/issues/62992/comments - Response: {"message":"Requires authentication","documentation_url":"https://docs.github.com/rest/issues/comments#create-an-issue-comment","status":"401"}

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

Merge pull request #64501 from aainscow/ec_fixpack2_pr

Optimized Erasure Coding - Fixpack 2

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #64926 from chanyoung/faster-seastore-eph-dev

crimson/.../ephemeral: faster seastore eph dev

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #64861 from ronen-fr/wip-rf-pgdict

test/standalone/scrub: improve build_pg_dicts() performance

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #64253 from arm7star/rgw-openssl

rgw, common: OpenSSL provider support

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #64675 from chanyoung/fix-omap-balance

crimson/.../omap_btree_node_impl: pass pivot_idx for balancing

Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>

Merge pull request #64575 from chanyoung/add-test-omap-update

test/crimson/seastore/test_omap_manager: add heavy update UT

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #64812 from Matan-B/wip-matanb-crimson-seastore-trans-intr

crimson/os/seastore: introduce with_repeat_trans_intr

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>

Merge pull request #64911 from rhcs-dashboard/dashboard-loading-state

mgr/dashboard: loading state for inventory card

Reviewed-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #64890 from cloudbehl/add-osd-ratio

prometheus: Add OSD full and nearfull ratio to prometheus

Reviewed-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #64753 from Hezko/nvmeof-cli-mtls-fix2

mgr/dashboard: fix nvmeof mtls

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #64767 from bluikko/doc-notifications-fixes-cephadm

doc/radosgw: Small fixes and improvements in notifications.rst, part 1

Reviewed-by: Yuval Lifshitz <ylifshit@ibm.com>
Reviewed-by: Zac Dover <zac.dover@proton.me>

Merge PR #64716 into main

* refs/pull/64716/head:

Reviewed-by: Anoop C S <anoopcs@cryptolab.net>
Reviewed-by: Sachin Prabhu <sp@spui.uk>

Merge pull request #64952 from Matan-B/wip-matanb-rgw-fifo-ftbfs

neorados/cls/fifo/detail/fifo: include strtol.h

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>

neorados/cls/fifo/detail/fifo: include strtol.h

https://github.com/ceph/ceph/commit/a2d26647c011274b61805f8ac17c3422e9b9b63c

ftbfs:
```
/home/jenkins-build/build/workspace/ceph-pull-requests/src/neorados/cls/fifo/detail/fifo.h:630:14: error: no member named 'parse' in namespace 'ceph'; did you mean 'pause'?
  630 |     auto n = ceph::parse<decltype(m.num)>(num);
      |              ^~~~~~~~~~~
```

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #64773 from afreen23/freq-api-calls

mgr/dashboard: Stop rules api being polled on every page

Reviewed-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #64905 from rhcs-dashboard/mem-leak

mgr/dashboard: fix memory leak in prometheus service

Reviewed-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #62915 from MaxKellermann/common_includes

common: include cleanup

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge PR #61116 into main

* refs/pull/61116/head:

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>

Merge PR #64822 into main

* refs/pull/64822/head:

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>

mgr/dashboard: fix memory leak in prometheus service

Prometheus API calls in the Cluster Utilization call is subscribed in
the for loop multiple times but this is not properly unsubscribed. As we
stay in the dashboard page for longer time, it produces a significant
memory leak which eventually lags the UI. Attempting to fix it by
properly handling the subscription

Fixes: https://tracker.ceph.com/issues/72511
Signed-off-by: Nizamudeen A <nia@redhat.com>

mgr/dashboard: loading state for inventory card

show loading state when inventory details are being loaded. also don't
block the UI when inventories are not loaded.

Fixes: https://tracker.ceph.com/issues/72494
Signed-off-by: Nizamudeen A <nia@redhat.com>

Merge pull request #62488 from dparmar18/i70553

client: fix unmount hang after lookups

Reviewed-by: Venky Shankar <vshankar@redhat.com>

crimson/os/seastore: mkfs_managers() into coroutines

* txn is now created only once and not in each repeated
  iteration as before, with_repeat_trans_intr will reset the txn
  if needed.

* in order for us to return a seastar::future, we would have to handle
  each and every errorator. Instead, change the return value to
  errorator and let the caller handle the error.

* The lambda which is passed to with_trans_intr returns mkfs_iertr
  since this is an extended version of base_iertr.
  Introduce a mkfs_ertr for the reason above. Future commits would
  unify the new mkfs_ertr with seastore_mkfs_ertr.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

crimson/os/seastore: cleanup final base_ertr users

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

crimson/os/seastore: introduce with_repeat_trans_intr

Most of with_trans_intr use repeat_eagain so it makes sense to introduce
this wrapper and audit exisitng users (future PR).

Note: each repeated iteration should use a fresh txn if we failed
in-flight.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

crimson/os/seastore/transaction: Cleanup journal_seq_t users

Seems like to logic is moved here:
```
  last_commit = start_seq;

  apply_backref_byseq(t.move_backref_entries(), start_seq);
  commit_backref_entries(std::move(backref_entries), start_seq);
```

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

crimson/os/seastore/transaction_interruptor: include transaction.h

With the new design, only transaction_interruptor would include
transaction in order to use its methods (is_conflicted and future
commits)

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

crimson/os/seastore/transaction: fix circular dependency

transaction_interruptor includes transaction and vice verca.
With the previous commits in this PR, we can not drop transaction
from including transaction_interruptor.

* move interrupt_cond_t to transaction_interruptor.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

crimson/os/seastore/btree/fixed_kv_btree: use common base_ertr

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

crimson/os/seastore/backref/btree_backref_manager: use common base_ertr

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

crimson/os/seastore/object_data_handler: use base_iertr

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

test/crimson/seastore/test_omap_manager: add heavy update UT

Signed-off-by: Chanyoung Park <chaney.p@kakaoenterprise.com>

crimson/seastore/async: Use common base_ertr and base_iertr

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

crimson/os/seastore/onode_manager: use common base_iertr

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

crimson/os/seastore/cache: remove Cache::base_ertr and iertr

Use the common declarations instead

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

crimson/os/seastore/seastore_types: introduce base_ertr

Instead of decalring base_ertr and base_iertr in every file or
class that use them -
* Move base_ertr decleration to the common seastore_types header.
  Note: the price for that is including errorator in seastore_types
        though this seems reasonable considering the benefits.
* Move base_iertr to transaction_interruptor where trans_iertr
  is defined.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

crimson/os/seastore/cached_extent: remove transaction_interruptor

da5e195cb4d8c2e2299ab86da156e98cda16496b added transaction_interruptor
but its no longer needed. Revert the relevant changes.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

test/crimson/seastore/test_omap_manager: add a UT to reproduce issue 72270

Signed-off-by: Chanyoung Park <chaney.p@kakaoenterprise.com>

crimson/.../omap_btree_node_impl: pass pivot_idx for balancing

Fixes: https://tracker.ceph.com/issues/72270
Signed-off-by: Chanyoung Park <chaney.p@kakaoenterprise.com>

Merge pull request #64714 from chanyoung/fix-rebalancing-assertion

crimson/.../linked_tree_node: fix pivot_idx assertion in balancing

Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>

Merge pull request #64810 from chanyoung/faster-seastore-ut

test/crimson/seastore/CMakeLists: tune ASan's UAR fake stack size

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #62513 from xxhdx1985126/wip-seastore-transaction-manager-iterator

crimson/os/seastore: LBACursor based LBAManager/TM interfaces and the related ObjectDataHandler refactor

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #64522 from chanyoung/cleanup-test-variable-sizes

test/crimson/seastore/test_omap_manager: redesign test variable sizes

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #64779 from baum/create_dev_dsa

nvmeof: create /dev/dsa if DSA acceleration is enabled and the device is missing

crimson/.../ephemeral: replace sleep(1ms) with seastar::yield()

Replaced fixed 1ms sleep calls with seastar::yield() to eliminate
unnecessary wall-clock delays while still yielding execution to
the scheduler

Signed-off-by: Chanyoung Park <chaney.p@kakaoenterprise.com>

crimson/.../ephemeral: remove unnecessary zero fill in anonymous mmap

Anonymous mmap is zero-filled on first access by the kernel, so an
explicit memset(0) is redundant and has been removed.

Signed-off-by: Chanyoung Park <chaney.p@kakaoenterprise.com>

nvmeof: create /dev/dsa if DSA acceleration is enabled and the device doesn't exist

Signed-off-by: Alexander Indenbaum <aindenba@redhat.com>

Merge pull request #64713 from baum/nvmeof_mon_client_connect_panic

src/nvmeof/NVMeofGwMonitorClient: connect panic

Merge pull request #64614 from shreya-subramanian/benchmarking_clean_pg_rgw

crimson-store-bench: add utility for measuring IO patterns against crimson FuturizedStore

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #64710 from rhcs-dashboard/table-re-render-fix

mgr/dashboard: fix table dom re-rendering

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Naman Munet <nmunet@redhat.com>

mgr/dashboard: Stop rules api being polled on every page

- /rules ar epolled every 5 seconds on every page
- it is only required for alerts page where full rules list is shown in `Alerts` tab
- also added observable for getting rules instead of plain array

Signed-off-by: Afreen Misbah <afreen@ibm.com>

prometheus: Add OSD full and nearfull ratio to prometheus

Fixes: https://tracker.ceph.com/issues/72495
Signed-off-by: Ankush Behl <cloudbehl@gmail.com>

Merge pull request #64586 from afreen23/eol

mgr/dashboard; setup husky

Reviewed-by: Naman Munet <nmunet@redhat.com>

mgr/dashboard: fix table dom re-rendering

each table refresh creates a new data or update the existing data. this
causes the existing data to be completely replaced with a newer one and
thereby loosing the trackBy functionality. So I am modifying the data
in-place so that the memory reference doesn't get changed

Fixes: https://tracker.ceph.com/issues/72491
Signed-off-by: Nizamudeen A <nia@redhat.com>

Merge pull request #64634 from rhcs-dashboard/fix-skeleton-loader-table

mgr/dashboard: fix table loading while fetching data

Merge pull request #64876 from zdover23/wip-doc-2025-08-07-cephfs-troubleshooting-2

doc/cephfs: edit troubleshooting.rst

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #64881 from zdover23/wip-doc-2025-08-07-cephfs-troubleshooting-3

doc/cephfs: edit troubleshooting.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/cephfs: edit troubleshooting.rst

Edit the section "Slow/Stuck Operations" in
doc/cephfs/troubleshooting.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>

test/crimson/seastore/test_omap_manager: redesign test variable sizes

Signed-off-by: Chanyoung Park <chaney.p@kakaoenterprise.com>

Merge pull request #64625 from chanyoung/fix-end-offset

crimson/.../linked_tree_node: fix incorrect end offset calculation

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>

Merge pull request #64703 from myoungwon/wip-fix-print-rbm-space

crimson/os/seastore: fix incorrect total space reporting when using multiple shards in RBM

Reviewed-by: Samuel Just <sjust@redhat.com>

debian/ceph-osd.install: add packaging for crimson-store-bench

Signed-off-by: Samuel Just <sjust@redhat.com>

ceph.spec.in: add packaging for crimson-store-bench

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/tools: Added PG log and rgw_index workload

This commit includes 2 workloads to crimson-store-bench
(a)PG_log workload with sequential omap write and delete
(b)RGW_index workload with randomised omap write and delete

Output is the number of operations, the total latency in seconds and the
duration of the workload in seconds per reactor.

Signed-off-by: Shreya Subramanian <Shreya.Subramanian@ibm.com>

crimson/tools: add store-bench

Adds stub for a new store-bench tool.

Signed-off-by: Samuel Just <sjust@redhat.com>

Merge pull request #64699 from stzuraski898/szmappadd

mailmap, githubmap, organisationmap: Add Steven Zuraski

Reviewed-by: Laura Flores <lflores@ibm.com>
Reviewed-by: Yaarit Hatuka <yhatuka@ibm.com>

Merge pull request #62770 from adamemerson/wip-70882

rgw/admin: Fix assert on datalog list of invalid shard

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #64566 from chanyoung/cleanup-test-basic

test/crimson/seastore/test_omap_manager: redesign test basic

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #64528 from chanyoung/cleanup-test-clear

test/crimson/seastore/test_omap_manager: add unit test for clear

Reviewed-by: Samuel Just <sjust@redhat.com

doc/radosgw: Small fixes and improvements in notifications.rst, part 1

Fix ordering of list items so that the sub-list is after the parent list
item referring to it.
Also fix multiple formatting errors in the same unordered list.

Fix unordered list rendered as a single sentence due to missing empty
line.

Break many long lines around standard line length.

Don't use hyphen for "regular expressions".

Use double backticks for data like configuration parameters.

Fix double space in an example CLI command.

Don't list same parameter "user/password" in multiple list items,
instead just list all concerns under the same list item.

Start sentences with capital case and end in full stop consistently.

Trim section title formatting syntax to text length.

Capitalize "URI" and "Kafka" consistently.

Use quotation marks in one occurrence of the value "true" instead of
single backticks for consistency.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>

Merge pull request #64763 from adk3798/cephadm-limit-list-servers-calls

mgr/cephadm: limit calls to list_servers

Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #64136 from JonBailey1993/ceph_test_rados_io_sequence_10_bug_fix

test/osd: Fix pack for minor issues in ceph_test_rados_io_sequence

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>

test/crimson/seastore/CMakeLists: re-enable seastore unittests

Fixes: https://tracker.ceph.com/issues/70254
Signed-off-by: Chanyoung Park <chaney.p@kakaoenterprise.com>

test/crimson/seastore/CMakeLists: tune ASan's UAR fake stack size

Avoids severe slowdowns with detect_stack_use_after_return=1.
The root cause is unclear, but ASan's fake stack GC behavior is
suspected. Tuning the UAR (Use-After-Return) fake stack size
(reduced from 64KB–1MB to 64KB) helped delay the onset of the
performance degradation.

Fixes: https://tracker.ceph.com/issues/71704
Signed-off-by: Chanyoung Park <chaney.p@kakaoenterprise.com>

Merge pull request #64869 from zdover23/wip-doc-2025-08-07-cephfs-troubleshooting

doc/cephfs: edit troubleshooting.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/cephfs: edit troubleshooting.rst

Edit "Avoiding Recovery Roadblocks" in the "Stuck During Recovery"
section of doc/cephfs/troubleshooting.rst.

This commit follows https://github.com/ceph/ceph/pull/64854.

Signed-off-by: Zac Dover <zac.dover@proton.me>

doc/cephfs: edit troubleshooting.rst

Follow up on comments made by Anthony D'Atri in
https://github.com/ceph/ceph/pull/64832 and make other small changes to
increase the ease of reading this text.

Signed-off-by: Zac Dover <zac.dover@proton.me>

Merge pull request #64854 from zdover23/wip-doc-2025-08-06-cephfs-troubleshooting-stuck-during-recovery

doc/cephfs: edit troubleshooting.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #64848 from bluikko/doc-conf-file-linkify-install

doc/install: Linkify mention of ceph.conf and use ref for links

Merge pull request #64856 from zdover23/wip-doc-2025-08-06-rados-operations-erasure-code-profile-tr72436

doc/rados: Fix broken links

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #64719 from cloudbehl/smb-overview-per-share

monitoring: Add per share metrics to SMB dashboard

Reviewed-by: Pedro Gonzalez <pegonzal@redhat.com>

rgw/datalog: Stick noexcept on wrappers returning int

Easier to debug.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

rgw: Use `run_coro` to call coroutines at use

This avoids having two entry points with different error checking
preparation, etc. to get out of sync or have a fix get forgotten.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

rgw: Add run_coro utility

A convenience function for turning coroutines that return values and
use exceptions, `error_code`, or similar into `int`-returning
functions that take references to out parameters.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

common/async: Update `use_blocked` for newer asio

Reimplement with `initiate` rather than the old style. This
necessitates getting rid of the old `async::Completion` in anything
that was calling it, and other changes.

Also, use disposition for error handling.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

Merge pull request #64712 from idryomov/wip-krbd-unmap-fixed-1

qa/suites/krbd: use a standard fixed-1 cluster in unmap subsuite

Reviewed-by: Ramana Raja <rraja@redhat.com>

common/async: Add concepts.h

Asio does not have nearly as many actual explicit concepts one can use
as one might like.

And there's no reason we might not want our own asynchrony-related concepts.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

common/async/co_waiter: Add missing header

Didn't include `associated_cancellation_slot.hpp`.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

rgw/multi: Fix error handling in public Datalog APIs

I had been thinking of list and trim as purely internal interfaces,
but they are called through HTTP and thus need to be prepared for bad
input.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

rgw/admin: Fix assert on datalog list of invalid shard

Fixes: https://tracker.ceph.com/issues/70882
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

Merge pull request #63698 from adamemerson/wip-71066

rgw/multisite: Fix lifetime issues

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #64849 from ronen-fr/wip-rf-72420repair

osd/scrub: do not limit operator-initiated repairs

Reviewed-by: Alex Ainscow <aainscow@uk.ibm.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #63047 from awojno-bloomberg/sts-fix

rgw: check all JWKS for STS

Reviewed-by: Pritha Srivastava <prsrivas@redhat.com>

Merge pull request #64825 from rhcs-dashboard/72409-parsing-error-in-grafana

mgr/dashboard: 72409 : Fixed parsing error in grafana for host overall performance iframe

Merge pull request #64689 from rhcs-dashboard/72288-mirrored-images-have-incorrect-info-in-gui

mgr/dashboard: Fixed incorrect snapshot scheduled date for rbd block in GUI