]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Ronen Friedman [Tue, 28 Nov 2023 15:46:01 +0000 (09:46 -0600)]
osd/scrub: unhandled scrub backend errors should cause an abort
... as we do not have any mechanism to handle them.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Ronen Friedman [Wed, 20 Dec 2023 19:57:37 +0000 (21:57 +0200)]
Merge pull request #54936 from ronen-fr/wip-rf-pcnt3
osd/scrub: initial set of performance counters
Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>
Ronen Friedman [Sun, 17 Dec 2023 18:14:53 +0000 (12:14 -0600)]
osd/scrub: collect replica reservations performance counters
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Ronen Friedman [Sat, 16 Dec 2023 10:10:22 +0000 (04:10 -0600)]
test/osd: log scrub performance counters in osd-scrub-test.sh
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Ronen Friedman [Sat, 16 Dec 2023 10:02:54 +0000 (04:02 -0600)]
osd/scrub: provide selected counters set to Scrubber & FSM
also - move most time keeping from the Scrubber to the FSM.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Ronen Friedman [Thu, 14 Dec 2023 14:27:13 +0000 (08:27 -0600)]
osd/scrub: add a basic set of performance counters
Add a labeled set of performance counters, with the labels selecting
one of four copies of the counters - one per each scrub level and
pool type combination.
Inside the Scrubber, the relevant set of counters is selected
when the scrub is initialized.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Ronen Friedman [Wed, 20 Dec 2023 16:53:27 +0000 (18:53 +0200)]
Merge pull request #54828 from ronen-fr/wip-rf-dec-fixes-1
osd/scrub: don't block high-priority scrubs on local resources
Reviewed-by: Samuel Just <sjust@redhat.com>-
Yuri Weinstein [Wed, 20 Dec 2023 15:24:11 +0000 (07:24 -0800)]
Merge pull request #54023 from Matan-B/wip-matanb-objectstore-tool-superblock
tools/ceph_objectstore_tool: Support get/set/superblock
Reviewed-by: Samuel Just <sjust@redhat.com>
Igor Fedotov [Wed, 20 Dec 2023 12:18:41 +0000 (15:18 +0300)]
Merge pull request #54195 from ifed01/wip-ifed-silent-warns
core: silent a couple of compiler warnings on uninitialized vars.
Reviewed-by: Adam Kupczyk <akupczyk@ibm.com>
NitzanMordhai [Wed, 20 Dec 2023 07:43:03 +0000 (09:43 +0200)]
Merge pull request #52871 from NitzanMordhai/wip-nitzan-ceph-dencoder-extend-osd-type-available
ceph-dencoder: OSD - Add missing types
NitzanMordhai [Wed, 28 Jun 2023 09:57:11 +0000 (09:57 +0000)]
ceph-dencoder: osd - Add missing types
Currently, ceph-dencoder lacks certain osd types, preventing us from accurately checking the ceph corpus for encode-decode mismatches.
This pull request aims to address this issue by adding the missing types to ceph-dencoder.
To successfully incorporate these types into ceph-dencoder, we need to introduce the necessary `dump` and `generate_test_instances`
functions that was missing in some types. These functions are essential for proper encode and decode of the added types.
This PR will enhance the functionality of ceph-dencoder by including the missing types, enabling a comprehensive analysis of encode-decode consistency.
With the addition of these types, we can ensure the robustness and correctness of the ceph corpus.
This update will significantly contribute to improving the overall reliability and accuracy of ceph-dencoder.
It allows for a more comprehensive assessment of the encode-decode behavior, leading to enhanced data integrity and stability within the ceph ecosystem.
Fixes: https://tracker.ceph.com/issues/61788
Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
Kefu Chai [Wed, 20 Dec 2023 02:14:38 +0000 (10:14 +0800)]
Merge pull request #54916 from tchaikov/cmake-boost-workaround
cmake: only apply workaround for boost < 1.84
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Kefu Chai [Wed, 20 Dec 2023 02:14:17 +0000 (10:14 +0800)]
Merge pull request #54919 from tchaikov/cmake-boost-1.84
cmake: add 1.82 and 1.83 to known versions
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Yuri Weinstein [Tue, 19 Dec 2023 23:00:22 +0000 (15:00 -0800)]
Merge pull request #53591 from EdwardVitor/fix-makecheck-warning
kv: resolve three compilation warnings
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Yuri Weinstein [Tue, 19 Dec 2023 22:59:25 +0000 (14:59 -0800)]
Merge pull request #53524 from sseshasa/wip-fix-osd-op-queue-rndmize-62171
osd: Apply randomly selected scheduler type across all OSD shards
Reviewed-by: Samuel Just <sjust@redhat.com>
Yuri Weinstein [Tue, 19 Dec 2023 22:57:48 +0000 (14:57 -0800)]
Merge pull request #53228 from rzarzynski/wip-bug-62645
common/weighted_shuffle: don't feed std::discrete_distribution with all-zero weights
Reviewed-by: Neha Ojha <nojha@redhat.com>
Ilya Dryomov [Tue, 19 Dec 2023 21:12:15 +0000 (22:12 +0100)]
Merge pull request #54953 from ljflores/wip-fix-18.2.1-doc
doc/releases: specify dashboard improvements
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Laura Flores [Mon, 18 Dec 2023 21:09:43 +0000 (15:09 -0600)]
doc/releases: specify dashboard improvements
...and address other nits
Signed-off-by: Laura Flores <lflores@ibm.com>
Yuval Lifshitz [Tue, 19 Dec 2023 17:57:47 +0000 (19:57 +0200)]
Merge pull request #54935 from yuvalif/wip-yuval-return-lua-devel
build/rgw/lua: return lua-devel runtime dependency
reviewed-by: cbodley
Nizamudeen A [Tue, 19 Dec 2023 13:48:20 +0000 (19:18 +0530)]
Merge pull request #54710 from kalaspuffar/replace_jwt_with_pure_python
mgr/dashboard: Simplify authentication protocol
Reviewed-by: Fabian-Gruenbichler <NOT@FOUND>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Adam Kupczyk [Tue, 19 Dec 2023 13:40:18 +0000 (14:40 +0100)]
Merge pull request #54897 from aclamk/wip-aclamk-bs-fix-esb-multichunk-alloc
os/bluestore: Fix assert() caused by ESB
Matan Breizman [Tue, 19 Dec 2023 10:12:53 +0000 (12:12 +0200)]
Merge pull request #54609 from xxhdx1985126/wip-crimson-rollback-fixes
crimson/osd/pg_backend: fix rollback on whiteouts
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
zdover23 [Tue, 19 Dec 2023 09:53:04 +0000 (19:53 +1000)]
Merge pull request #54960 from zdover23/wip-doc-2023-12-19-install-clone-source-submodule-update
doc/install: update "update submodules"
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Zac Dover [Tue, 19 Dec 2023 09:15:57 +0000 (19:15 +1000)]
doc/install: update "update submodules"
Remove misleading material that would give readers the wrong idea about
when stale submodules are present. This commit is made in response to
information given to me by Ilya Dryomov here: https://github.com/ceph/ceph/pull/54929#issuecomment-
1859237986 .
Signed-off-by: Zac Dover <zac.dover@proton.me>
Xuehan Xu [Wed, 22 Nov 2023 05:16:36 +0000 (13:16 +0800)]
crimson/osd/pg_backend: whiteout objects if they will have clones when
rolling back
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Kefu Chai [Tue, 19 Dec 2023 04:57:41 +0000 (12:57 +0800)]
Merge pull request #54917 from tchaikov/cmake-cephfs-sans-libcephfs
cmake: differentiate WITH_CEPHFS from WITH_LIBCEPHFS
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Samuel Just [Tue, 19 Dec 2023 01:37:26 +0000 (17:37 -0800)]
Merge pull request #54931 from athanatos/sjust/wip-crimson-2023-12-13-fixes
crimson: misc fixes
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Laura Flores [Mon, 18 Dec 2023 20:57:53 +0000 (14:57 -0600)]
Merge pull request #54506 from ceph/wip-yuriw-release-18.2.1-main
doc: Add Reef 18.2.1 release notes
Casey Bodley [Mon, 18 Dec 2023 18:28:45 +0000 (18:28 +0000)]
Merge pull request #52495 from adamemerson/wip-neorados-learning-from-experience
neorados: Learning from experience
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Matan Breizman [Mon, 18 Dec 2023 14:36:49 +0000 (16:36 +0200)]
Merge pull request #53227 from Matan-B/wip-matanb-cleanup-stale-osdmap
osd/OSD: introduce trim_stale_maps
Reviewed-by: Samuel Just <sjust@redhat.com>
Matan Breizman [Thu, 26 Oct 2023 10:18:59 +0000 (10:18 +0000)]
qa/tasks/ceph_manager: thrash - add trim stale osdmaps
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Wed, 30 Aug 2023 08:57:18 +0000 (08:57 +0000)]
osd/OSD: introduce trim_stale_maps
```
/**
* trim_stale_maps
*
* trim_maps had a possible (rare) leak which resulted in stale osdmaps.
* This method will cleanup any existing osdmaps from the store
* with an epoch earlier than the superblock's oldest_map epoch.
* See: https://tracker.ceph.com/issues/61962
*/
```
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Kefu Chai [Fri, 15 Dec 2023 10:18:01 +0000 (18:18 +0800)]
cmake: differentiate WITH_CEPHFS from WITH_LIBCEPHFS
WITH_CEPHFS is used for enabling the server side of cephfs, i.e., mds,
while WITH_LIBCEPHFS is for the client side of it, namely libcephfs
and its python bindings. since we have these two different options,
in theory, user is allowed to build with WITH_CEPHFS=ON and
WITH_LIBCEPHFS=OFF, and in that case, `vstart` should not depend on
the non-existent target of cephfs and cython_cephfs. the same applies to
the build of cython_cephfs. this is an unusual combination, but
it is a valid one.
in this change, we
* build the python binding only if WITH_LIBCEPHFS is ON
* add cephfs and cython_cephfs as dependencies of vstart only if
WITH_LIBCEPHFS is ON
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Mon, 18 Dec 2023 07:16:38 +0000 (15:16 +0800)]
cmake: add deps to vstart and vstart-base with loop
so we don't have to repeat the settings enabling a given target
when adding the deps to vstart and vstart-base
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
zdover23 [Mon, 18 Dec 2023 04:19:58 +0000 (14:19 +1000)]
Merge pull request #54929 from dann1/main
doc: Improve documentation regarding OpenNebula integration with ceph
Reviewed-by: Zac Dover <zac.dover@proton.me>
Kefu Chai [Mon, 18 Dec 2023 02:25:54 +0000 (10:25 +0800)]
Merge pull request #54937 from gruenich/feature/cmake-drop-redundant-policies
cmake: Do not set CMake policy to new that are set anyway
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Daniel Clavijo Coca [Fri, 15 Dec 2023 15:54:02 +0000 (09:54 -0600)]
docs: Add information about OpenNebula integration
- Exclude doc build output from git
- Fix missing doc build dependency
- Also includes some involuntary automatically persistent linting by vscode
Co-authored-by: Ilya Dryomov <idryomov@redhat.com>
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Co-authored-by: Zac Dover <zac.dover@proton.me>
Signed-off-by: Daniel Clavijo <dclavijo@opennebula.io>
Christoph Grüninger [Sun, 17 Dec 2023 21:18:43 +0000 (22:18 +0100)]
cmake: Do not set CMake policy to new that are set anyway
CMP0097 and below are all implicitly set to new because
the minimum required CMake version is 3.16 and these
policies are older.
Signed-off-by: Christoph Grüninger <foss@grueninger.de>
Yuval Lifshitz [Sun, 17 Dec 2023 16:29:41 +0000 (18:29 +0200)]
Merge pull request #52474 from vedanshbhartia/coverity_1515850
rgw: Fix potential null dereference in rgw/driver/dbstore/sqlite/statement.cc
reviewed-by: thotz, yuvalif
Yuval Lifshitz [Sun, 17 Dec 2023 16:29:01 +0000 (18:29 +0200)]
Merge pull request #52276 from vedanshbhartia/coverity_1523402
rgw: Add a wrapper for librados::AioCompletion to prevent memory leaks
reviewed-by: cbodley, yuvalif
Yuval Lifshitz [Sun, 17 Dec 2023 16:27:27 +0000 (18:27 +0200)]
Merge pull request #53902 from vedanshbhartia/coverity_except_main
rgw: Add coverity annotations for uncaught exceptions in standalone binaries
reviewed-by: yuvalif
Yuval Lifshitz [Tue, 12 Dec 2023 08:11:57 +0000 (08:11 +0000)]
build/rgw/lua: return lua-devel runtime dependency
reverting:
b0a77a53ab86b9b24a2cfb46049957d40a8c80aa
after sepia lab issue is resolved
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
Ilya Dryomov [Sun, 17 Dec 2023 10:27:11 +0000 (11:27 +0100)]
Merge pull request #54547 from idryomov/wip-53897
librbd: don't report HOLE_UPDATED when diffing against a hole
Reviewed-by: Mykola Golub <mgolub@suse.com>
Yuval Lifshitz [Sun, 17 Dec 2023 10:12:48 +0000 (12:12 +0200)]
Merge pull request #54569 from AliMasarweh/wip-alimasa-multi-pubsub-etag
RGW: pubsub publish commit with etag populated
revieweed-by: cbodley, yuvalif
Anthony D'Atri [Sat, 16 Dec 2023 19:11:54 +0000 (14:11 -0500)]
Merge pull request #52354 from bluikko/patch-13
doc/radosgw/admin.rst: use underscores in config var names
Casey Bodley [Sat, 16 Dec 2023 16:25:14 +0000 (16:25 +0000)]
Merge pull request #54888 from cbodley/wip-rgw-multisite-forward-empty-buffer
rgw/multisite: forwarded requests always pass a bufferlist
Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
Casey Bodley [Sat, 16 Dec 2023 16:24:57 +0000 (16:24 +0000)]
Merge pull request #54739 from cbodley/wip-qa-rgw-upgrade-distros
qa/rgw/upgrade: stop testing upgrade from pacific
Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
Samuel Just [Sat, 16 Dec 2023 00:26:30 +0000 (00:26 +0000)]
crimson/.../client_request_common: skip non-existent oids in recover_missings
See comment.
Introduced:
38cc750f
Fixes: https://tracker.ceph.com/issues/63821
Signed-off-by: Samuel Just <sjust@redhat.com>
Samuel Just [Thu, 14 Dec 2023 06:41:00 +0000 (22:41 -0800)]
crimson/.../client_request_common: simplify recover_missings
- Modify ClientRequest::snaps_need_to_recover() to return all
relevant snaps including the operation target.
- Update ClientRequest::snaps_need_to_recover() and
CommonClientRequest::recover_missings to use set::set
for snaps.
- Remove special handling for soid from
CommonClientRequest::recover_missings
- Simplify CommonClientRequest::recover_missings.
Signed-off-by: Samuel Just <sjust@redhat.com>
Yuri Weinstein [Tue, 14 Nov 2023 21:14:46 +0000 (13:14 -0800)]
doc: Add Reef 18.2.1 release notes
Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
Signed-off-by: Laura Flores <lflores@ibm.com>
Casey Bodley [Fri, 15 Dec 2023 18:34:25 +0000 (18:34 +0000)]
Merge pull request #54841 from cbodley/wip-rgw-multisite-rados-crash
rgw/multisite: error repo coroutines store raw_obj by value
Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
Casey Bodley [Fri, 15 Dec 2023 16:40:07 +0000 (16:40 +0000)]
Merge pull request #54920 from tchaikov/cls-2pc-reserv-dencode
cls/queue: always set member variables in ctor
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Kefu Chai [Fri, 15 Dec 2023 12:20:46 +0000 (20:20 +0800)]
cls/queue: always set member variables in ctor
this should address the test failures like
```
/tmp/typ-WWFeFl6yK /tmp/typ-sMfwoaGMU differ: byte 24, line 1
**** cls_2pc_reservation test 2 binary reencode check failed ****
ceph-dencoder type cls_2pc_reservation select_test 2 encode export /tmp/typ-WWFeFl6yK
ceph-dencoder type cls_2pc_reservation select_test 2 encode decode encode export /tmp/typ-sMfwoaGMU
2c2
<
00000010 00 00 00 00 00 00 c0 c6 92 10 |..........|
---
>
00000010 00 00 00 00 00 00 c0 e6 cd 53 |.........S|
```
where we
1. encode the 2nd sample created by `generate_test_instances()`,
2. encode, decode, and encode again, the same sample
and compare the encoded blobs.
but if we fail to set any of the fields in `cls_2pc_reservation`,
we are at the mercy of the random bits on stack/heap.
in this change, all bits are initialized.
the flaky test was introduced by
1d7cabf3
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Patrick Donnelly [Fri, 15 Dec 2023 13:18:28 +0000 (08:18 -0500)]
Merge PR #52196 into main
* refs/pull/52196/head:
qa: configure balancer for multi-mds workloads
qa: create qa subvolumes in named subvolumegroup
qa: do not rely on default max_mds value
qa: add automate_balance to dashboard qa schema
doc/cephfs: add docs for balance_automate
doc/cephfs: use bash prompt for shell code
mds: add balance_automate fs setting
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Kefu Chai [Fri, 15 Dec 2023 09:28:37 +0000 (17:28 +0800)]
cmake: add 1.82 and 1.83 to known versions
this change should silence the warning when building Ceph with Boost 1.82:
```
CMake Warning at cmake/modules/FindBoost.cmake:1384 (message):
New Boost version may have incorrect or missing dependencies and imported
targets
Call Stack (most recent call first):
cmake/modules/FindBoost.cmake:1507 (_Boost_COMPONENT_DEPENDENCIES)
cmake/modules/FindBoost.cmake:2125 (_Boost_MISSING_DEPENDENCIES)
CMakeLists.txt:687 (find_package)
```
despite that
244c5ebb added boost to `_Boost_KNOWN_VERSIONS`, it was
not enough. would be better to sync up the CMake upstream for an updated
version of this file like we did before.
in this change
* syncs this file with
https://github.com/Kitware/CMake/blob/
897a149067b84375d094700632255c0b54f5e44c /Modules/FindBoost.cmak
* re-apply the change of
06824bc1ecbe68b6809c1f47f0f5d636842746b5
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
cmake: adapt FindBoost.cmake to our needs
the vanilla FindBoost.cmake pulled from cmake has couple assumptions
which do not hold in our environment. so address them case by case.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Ilya Dryomov [Sun, 10 Dec 2023 16:01:24 +0000 (17:01 +0100)]
test/pybind/rbd: don't ignore from_snapshot in check_diff()
Despite the test in test_diff_iterate() being correct, it started
failing:
> check_diff(self.image, 0, IMG_SIZE, 'snap1', [(0, 512, False)])
...
a = [], b = [(0, 512, False)]
...
> assert a == b
E AssertionError
This is because check_diff() drops 'snap1' argument on the floor and
passes None to image.diff_iterate() instead. This goes back to 2013,
see commit
e88fe3cbbc8f ("rbd.py: add some missing functions").
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Sun, 3 Dec 2023 15:39:39 +0000 (16:39 +0100)]
test/librbd: redo TestMockObjectMapDiffRequest.*Delta tests
Existing *Delta tests cover:
- beginning of time -> HEAD, through intermediate snap
- snap -> snap, directly
- snap -> HEAD, directly
But coverage is too weak: none of the weird OBJECT_PENDING cases and
only a single diff-iterate vs deep-copy case is tested, for example.
Coverage is missing completely for:
- beginning of time -> HEAD, directly
- beginning of time -> snap, directly
- beginning of time -> snap, through intermediate snap
- snap -> snap, through intermediate snap
- snap -> HEAD, through intermediate snap
This adds the following tests:
- FromBeginningToHead
- FromBeginningToHeadIntermediateSnap (expands FullDelta)
- FromBeginningToSnap
- FromBeginningToSnapIntermediateSnap
- FromSnapToSnap (expands IntermediateDelta)
- FromSnapToSnapIntermediateSnap
- FromSnapToHead (expands EndDelta)
- FromSnapToHeadIntermediateSnap
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Kefu Chai [Fri, 15 Dec 2023 10:04:53 +0000 (18:04 +0800)]
cmake: only apply workaround for boost < 1.84
https://github.com/boostorg/phoenix/issues/111 was fixed in master.
see the fix which addresses the issue:
https://github.com/boostorg/phoenix/commit/
8913607a3788cb82d48ed461ea59c919b7bad3df
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Casey Bodley [Fri, 15 Dec 2023 04:10:29 +0000 (04:10 +0000)]
Merge pull request #54878 from yuvalif/wip-yuval-split-rgw-tools
rgw: split RGWDataAccess from rgw_tools.cc
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Casey Bodley [Fri, 15 Dec 2023 04:10:13 +0000 (04:10 +0000)]
Merge pull request #54840 from cbodley/wip-qa-rgw-crypt-disable-kmip
qa/rgw/crypt: disable failing kmip testing
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Kefu Chai [Fri, 15 Dec 2023 01:13:08 +0000 (09:13 +0800)]
Merge pull request #51732 from andreas-schwab/main
ceph.spec.in: enable build on riscv64 for openSUSE Factory
Reviewed-by: Tim Serong <tserong@suse.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
zdover23 [Thu, 14 Dec 2023 21:45:22 +0000 (07:45 +1000)]
Merge pull request #54893 from zdover23/wip-doc-2023-12-14-radosgw-role-formatting
doc/radosgw: format commands in role.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Thu, 14 Dec 2023 06:14:29 +0000 (16:14 +1000)]
doc/radosgw: format commands in role.rst
Format approximately one-hundred lines of doc/radosgw/role.rst to
include proper command prompts. I also made one small English usage
improvement.
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
Adam King [Thu, 14 Dec 2023 18:39:54 +0000 (13:39 -0500)]
Merge pull request #54723 from phlogistonjohn/jjm-bib
script/build-integration-branch: minor improvements around github api access & tokens
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Laura Flores <lflores@ibm.com>
Casey Bodley [Thu, 30 Nov 2023 22:39:34 +0000 (17:39 -0500)]
qa/rgw/upgrade: stop testing upgrade from pacific
squid won't support upgrades from pacific. stop all testing against
centos8 and ubuntu20
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Ali Masarwa [Sun, 19 Nov 2023 13:29:28 +0000 (15:29 +0200)]
RGW:pubsub publish commit with etag populated
Signed-off-by: Ali Masarwa <ali.saed.masarwa@gmail.com>
Adam Kupczyk [Thu, 14 Dec 2023 09:38:08 +0000 (09:38 +0000)]
os/bluestore: Fix Blob::copy_extents function
The function had an error, that it assumed its smallest operational block is allocation unit.
In reality, the smallest block is min_release_size, that is a max(allocation size, checksum size).
In some wierd cases single min_release_size block could be composed of *disjointed*
allocation on the disk. This is something that bitmap allocator does often.
Blob::copy_extents could not handle it properly, but luckily, it asserted when faced with that data.
New fixed and improved version is able to handle this case too.
Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Venky Shankar [Thu, 14 Dec 2023 05:55:01 +0000 (11:25 +0530)]
Merge PR #54733 into main
* refs/pull/54733/head:
client/fuse: handle case of renameat2 with non-zero flags
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Yingxin [Thu, 14 Dec 2023 02:21:43 +0000 (10:21 +0800)]
Merge pull request #53393 from rzarzynski/wip-ceph-run-op
ceph-run: fix string comparison around --no-restart
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Samuel Just [Wed, 13 Dec 2023 20:43:35 +0000 (12:43 -0800)]
crimson/osd/pg: rollback obc unconditionally before error log
If we're recording an error to the log, the write definitionally did not
happen. Rollback the obc regardless of the specific error code.
Introduced:
1d98e8da
Fixes: https://tracker.ceph.com/issues/63820
Signed-off-by: Samuel Just <sjust@redhat.com>
Samuel Just [Tue, 17 Oct 2023 04:33:08 +0000 (21:33 -0700)]
os/bluestore/BlueStore: fix crimson-only omap_get_values start handling
seek_to_first() if start is nullopt, upper_bound() otherwise.
Introduced:
9cf183ed46ad
Fixes: https://tracker.ceph.com/issues/63819
Signed-off-by: Samuel Just <sjust@redhat.com>
Casey Bodley [Wed, 13 Dec 2023 20:32:37 +0000 (15:32 -0500)]
rgw/multisite: error repo coroutines initialize rados pointer
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Fri, 8 Dec 2023 20:26:21 +0000 (15:26 -0500)]
rgw/multisite: error repo coroutines store raw_obj by value
RGWErrorRepoWriteCR/RGWErrorRepoRemoveCR need to copy their rgw_raw_obj
arguments to extend the lifetimes until send_request() is called
potential regression from https://github.com/ceph/ceph/pull/50359
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Ilya Dryomov [Wed, 13 Dec 2023 20:17:16 +0000 (21:17 +0100)]
Merge pull request #54657 from
a180285 /patch-2
rbd: update import-diff command help message
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Adam King [Wed, 13 Dec 2023 19:14:26 +0000 (14:14 -0500)]
Merge pull request #54832 from hex2dec/fix-cephadm-shell-help
cephadm: Fix `cephadm shell` command help message
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
Adam King [Wed, 13 Dec 2023 19:10:55 +0000 (14:10 -0500)]
Merge pull request #54814 from rhcs-dashboard/update-grafana-version-cephadm
mgr/cephadm: bump grafana to 9.4.12
Reviewed-by: Adam King <adking@redhat.com>
Adam King [Wed, 13 Dec 2023 17:15:53 +0000 (12:15 -0500)]
Merge pull request #54786 from guits/fix_63729
python-common: fix osdspec_affinity check
Reviewed-by: Adam King <adking@redhat.com>
Adam King [Wed, 13 Dec 2023 17:15:05 +0000 (12:15 -0500)]
Merge pull request #54681 from adk3798/device-limit-testing
python-common/drive_selection: fix limit with existing devices
Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Guillaume Abrioux <gabrioux@ibm.com>
Adam King [Wed, 13 Dec 2023 16:57:59 +0000 (11:57 -0500)]
Merge pull request #54536 from phlogistonjohn/jjm-cephadm-units-n-scripts
cephadm: add modules to abstract systemd units and run scripts
Reviewed-by: Adam King <adking@redhat.com>
HuangWei [Sat, 25 Nov 2023 08:52:21 +0000 (16:52 +0800)]
Update rbd import-diff command help message
Signed-off-by: HuangWei <huangwei.a180285@gmail.com>
Yuri Weinstein [Wed, 13 Dec 2023 15:43:52 +0000 (07:43 -0800)]
Merge pull request #54319 from ajarr/wip-63410
mgr/Mgr: remove shutdown() and handle_signal()
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Yuri Weinstein [Wed, 13 Dec 2023 15:43:12 +0000 (07:43 -0800)]
Merge pull request #54102 from ifed01/wip-ifed-better-vselector-calls
os/bluestore: rework vselector calls.
Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
Yuri Weinstein [Wed, 13 Dec 2023 15:40:08 +0000 (07:40 -0800)]
Merge pull request #52210 from ceph/wip-nitzan-ceph-dencoder-extend-common-types-available
ceph-dencoder: COMMON - Add missing types
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Venky Shankar [Wed, 13 Dec 2023 15:23:13 +0000 (20:53 +0530)]
Merge PR #48895 into main
* refs/pull/48895/head:
qa: test cases for checking the health status after scrub repair
mds: scrub repair does not clear earlier damage health status
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Venky Shankar [Wed, 13 Dec 2023 15:19:52 +0000 (20:49 +0530)]
Merge PR #54628 into main
* refs/pull/54628/head:
qa/fscrypt: enable debug log for bluestore
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Venky Shankar [Wed, 13 Dec 2023 15:18:27 +0000 (20:48 +0530)]
Merge PR #54669 into main
* refs/pull/54669/head:
mds: set the loner to true for LOCK_EXCL_XSYN
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Venky Shankar [Wed, 13 Dec 2023 15:08:51 +0000 (20:38 +0530)]
Merge PR #54704 into main
* refs/pull/54704/head:
qa: don't fail on gather_mount_info() failure
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
Venky Shankar [Wed, 13 Dec 2023 15:06:06 +0000 (20:36 +0530)]
Merge PR #54745 into main
* refs/pull/54745/head:
mds: encode `bal_rank_mask` using a higher (next) version
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Casey Bodley [Wed, 13 Dec 2023 14:30:35 +0000 (09:30 -0500)]
rgw/multisite: forwarded requests always pass a bufferlist
d2dbe7550296da6db885b5344c71f77f9acbfd8f added a rgw_forward_request_to_master()
that took the input bufferlist by pointer instead of reference so it
could be optional; however, RGWRESTSimpleRequest::forward_request()
omits the Content-Length header when the data is nullptr. this was an
unintended change and broke the forwarding of some requests
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Wed, 13 Dec 2023 12:54:34 +0000 (12:54 +0000)]
Merge pull request #54864 from cbodley/wip-mgr-rgw-realm-name
mgr/rgwam: period doesn't have a realm_name anymore
Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
Ronen Friedman [Wed, 13 Dec 2023 10:07:38 +0000 (12:07 +0200)]
Merge pull request #54615 from ronen-fr/wip-rf-schedRepair
osd/scrub: allow auto-repair on operator-initiated scrubs
Reviewed-by: Samuel Just <sjust@redhat.com>-
Daniel Persson [Sun, 3 Dec 2023 09:46:56 +0000 (09:46 +0000)]
mgr/dashboard: Updated test dependencies
Seemed that the test dependencies was separated in two different requirements files
one for the testing and one for linting. Added the JWT dependency in the linting file
as well.
Signed-off-by: Daniel Persson <mailto.woden@gmail.com>
Daniel Persson [Sun, 3 Dec 2023 08:03:47 +0000 (08:03 +0000)]
mgr/dashboard: Changes suggested after review by @epuertat.
Move the JWT requirement to the test requirements file. Also remove JWT from ceph specification and debian build.
Signed-off-by: Daniel Persson <mailto.woden@gmail.com>
Casey Bodley [Tue, 12 Dec 2023 22:36:31 +0000 (22:36 +0000)]
Merge pull request #54748 from cbodley/wip-63717
rgw/sysobj: pool_list_objects_init() initializes marker
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Patrick Donnelly [Wed, 12 Jul 2023 16:46:35 +0000 (12:46 -0400)]
qa: configure balancer for multi-mds workloads
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Mon, 17 Jul 2023 15:07:14 +0000 (11:07 -0400)]
qa: create qa subvolumes in named subvolumegroup
So we can twiddle the subvolumegroup settings (like pins).
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Wed, 12 Jul 2023 16:44:49 +0000 (12:44 -0400)]
qa: do not rely on default max_mds value
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Tue, 18 Jul 2023 18:08:22 +0000 (14:08 -0400)]
qa: add automate_balance to dashboard qa schema
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Tue, 12 Dec 2023 16:45:05 +0000 (11:45 -0500)]
doc/cephfs: add docs for balance_automate
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Tue, 12 Dec 2023 16:44:43 +0000 (11:44 -0500)]
doc/cephfs: use bash prompt for shell code
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>