]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
17 months agomgr/dashboard: snap schedule module detect/eneable
Ivo Almeida [Sun, 10 Dec 2023 17:44:33 +0000 (17:44 +0000)]
mgr/dashboard: snap schedule module detect/eneable

Fixes: https://tracker.ceph.com/issues/63768
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
17 months agomgr/dashboard: added snap-schedule api and ui list
Ivo Almeida [Sat, 25 Nov 2023 19:10:35 +0000 (19:10 +0000)]
mgr/dashboard: added snap-schedule api and ui list

Fixes: https://tracker.ceph.com/issues/63767
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
(cherry picked from commit acaad3555414aa1f1b4fa732af70612d50c5e883)

17 months agoMerge pull request #55571 from aaSharma14/wip-64048-reef
Nizamudeen A [Wed, 14 Feb 2024 09:47:04 +0000 (15:17 +0530)]
Merge pull request #55571 from aaSharma14/wip-64048-reef

reef: mgr/dashboard: increase the number of plottable graphs in charts

Reviewed-by: afreen23 <NOT@FOUND>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
17 months agomgr/dashboard: Fix issue with Object's Overview page 55571/head
Afreen [Wed, 24 Jan 2024 15:09:54 +0000 (20:39 +0530)]
mgr/dashboard: Fix issue with Object's Overview page

Fixes https://tracker.ceph.com/issues/64150

Issue: Due to absence of null checks, the overview page was failing to
load.

Fix: Added, null check at relevant places to ensure data availability
before accessing the data.

Signed-off-by: Afreen <afreen23.git@gmail.com>
17 months agomgr/dashboard: increase the number of plottable graphs in charts
Aashish Sharma [Tue, 5 Dec 2023 05:58:25 +0000 (11:28 +0530)]
mgr/dashboard: increase the number of plottable graphs in charts

Fixes: https://tracker.ceph.com/issues/64024
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
17 months agoMerge pull request #55544 from rhcs-dashboard/wip-61657-reef
Nizamudeen A [Tue, 13 Feb 2024 16:55:36 +0000 (22:25 +0530)]
Merge pull request #55544 from rhcs-dashboard/wip-61657-reef

reef: mgr/dashboard: change deprecated grafana URL in daemon logs

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: ivoalmeida <NOT@FOUND>
17 months agoMerge pull request #55515 from afreen23/wip-64367-reef
Nizamudeen A [Tue, 13 Feb 2024 11:05:10 +0000 (16:35 +0530)]
Merge pull request #55515 from afreen23/wip-64367-reef

reef: mgr/dashboard: fix error while accessing roles tab when policy attached

Reviewed-by: Nizamudeen A <nia@redhat.com>
17 months agoMerge pull request #55542 from rhcs-dashboard/wip-61714-reef
Nizamudeen A [Tue, 13 Feb 2024 05:24:21 +0000 (10:54 +0530)]
Merge pull request #55542 from rhcs-dashboard/wip-61714-reef

reef: mgr/dashboard: fix the jsonschema issue in install-deps

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: ivoalmeida <NOT@FOUND>
17 months agoMerge pull request #55497 from guits/wip-64357-reef
Guillaume Abrioux [Mon, 12 Feb 2024 15:15:42 +0000 (16:15 +0100)]
Merge pull request #55497 from guits/wip-64357-reef

reef: ceph-volume: Fix migration from WAL to data with no DB

17 months agomgr/dashboard: change deprecated grafana URL in daemon logs 55544/head
Nizamudeen A [Thu, 8 Jun 2023 06:43:54 +0000 (12:13 +0530)]
mgr/dashboard: change deprecated grafana URL in daemon logs

See https://github.com/grafana/grafana/issues/51276

I am also increasting the height of the panel

Fixes: https://tracker.ceph.com/issues/61618
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit f428b1468844345915b4cf607a104732b1b967f3)

17 months agomgr/dashboard: fix the jsonschema issue in install-deps 55542/head
Nizamudeen A [Fri, 16 Jun 2023 09:08:52 +0000 (14:38 +0530)]
mgr/dashboard: fix the jsonschema issue in install-deps

Fixes: https://tracker.ceph.com/issues/61690
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit a6a123d3b498c6fa8a09339ed5e7d5b95581419b)

 Conflicts:
src/pybind/mgr/dashboard/requirements-test.txt
  - accept the incoming changes

17 months agoMerge pull request #55517 from rhcs-dashboard/wip-64370-reef
Pedro Gonzalez Gomez [Mon, 12 Feb 2024 12:36:18 +0000 (13:36 +0100)]
Merge pull request #55517 from rhcs-dashboard/wip-64370-reef

reef: mgr/dashboard: dashboard area chart unit test

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
17 months agoMerge pull request #55511 from zdover23/wip-doc-2024-02-09-backport-55465-to-reef
zdover23 [Fri, 9 Feb 2024 15:39:25 +0000 (01:39 +1000)]
Merge pull request #55511 from zdover23/wip-doc-2024-02-09-backport-55465-to-reef

reef: doc: add description of metric fields for cephfs-top

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
17 months agoMerge pull request #55505 from zdover23/wip-doc-2024-02-09-backport-55490-to-reef
zdover23 [Fri, 9 Feb 2024 15:38:34 +0000 (01:38 +1000)]
Merge pull request #55505 from zdover23/wip-doc-2024-02-09-backport-55490-to-reef

reef: doc:start.rst fix typo in hw-recs

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
17 months agomgr/dashboard: dashboard area chart unit test 55517/head
Pedro Gonzalez Gomez [Thu, 19 Oct 2023 09:29:36 +0000 (11:29 +0200)]
mgr/dashboard: dashboard area chart unit test

Fixes: https://tracker.ceph.com/issues/63243
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
(cherry picked from commit 445724fa61a27071bce02afa084bfc1437acd271)

17 months agomgr/dashboard: fix error while accessing roles tab when policy attached 55515/head
Afreen [Tue, 6 Feb 2024 09:43:58 +0000 (15:13 +0530)]
mgr/dashboard: fix error while accessing roles tab when policy attached

Fixes https://tracker.ceph.com/issues/64270

Issue:
======
Accessing Object->Users-Roles tab causing 500 internal servor error.
This is due to the "PermissionPolicies" which are attached to role and
backend was not handling this field for rgw roles.

Fix:
====
Added "PermissionPolicies" as the valid field in backend and updated
frontend to render the attached policy in formatted JSON

Signed-off-by: Afreen <afreen23.git@gmail.com>
(cherry picked from commit 5247d7d19455a5ab7d1bb56b9586c6b08843b15d)

 Conflicts:
src/pybind/mgr/dashboard/frontend/src/app/shared/models/crud-table-metadata.ts

17 months agoMerge pull request #55224 from rhcs-dashboard/wip-64077-reef
Pedro Gonzalez Gomez [Fri, 9 Feb 2024 12:36:07 +0000 (13:36 +0100)]
Merge pull request #55224 from rhcs-dashboard/wip-64077-reef

reef: mgr/dashboard: chartjs and ng2-charts version upgrade

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
17 months agoMerge pull request #55477 from guits/wip-64337-reef
Guillaume Abrioux [Fri, 9 Feb 2024 08:03:54 +0000 (09:03 +0100)]
Merge pull request #55477 from guits/wip-64337-reef

reef: ceph-volume: fix zap_partitions() in devices.lvm.zap

17 months agoMerge pull request #55489 from rhcs-dashboard/wip-64245-reef
Nizamudeen A [Fri, 9 Feb 2024 07:06:24 +0000 (12:36 +0530)]
Merge pull request #55489 from rhcs-dashboard/wip-64245-reef

reef: mgr/dashboard: create cephfs snapshot clone

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
17 months agodoc: add description of metric fields for cephfs-top 55511/head
neeraj pratap singh [Tue, 6 Feb 2024 12:12:50 +0000 (17:42 +0530)]
doc: add description of metric fields for cephfs-top

Fixes: https://tracker.ceph.com/issues/63991
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
(cherry picked from commit 956f644f86c0790c17976b98df112747d66837df)

17 months agodoc:start.rst fix typo in hw-recs 55505/head
Eduardo Roldan [Thu, 8 Feb 2024 06:40:21 +0000 (03:40 -0300)]
doc:start.rst fix typo in hw-recs

s/power less/power loss/

Signed-off-by: Eduardo Roldan <trazor@gmail.com>
(cherry picked from commit b80c12d080275e3c221a1e305c345fbc1caa3c8e)

17 months agoMerge pull request #55369 from afreen23/wip-64239-reef
Nizamudeen A [Thu, 8 Feb 2024 15:02:05 +0000 (20:32 +0530)]
Merge pull request #55369 from afreen23/wip-64239-reef

reef: mgr/dashboard: Create subvol of same name in different group

Reviewed-by: Nizamudeen A <nia@redhat.com>
17 months agoceph-volume: Fix migration from WAL to data with no DB 55497/head
Igor Fedotov [Wed, 31 Jan 2024 12:45:26 +0000 (15:45 +0300)]
ceph-volume: Fix migration from WAL to data with no DB

Fixes: https://tracker.ceph.com/issues/64260
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit 88466b3e7daad51a93ef1ccdbced1f33337c4eec)

17 months agoMerge pull request #55491 from rkachach/fix_issue_64339
Redouane Kachach [Thu, 8 Feb 2024 12:56:22 +0000 (13:56 +0100)]
Merge pull request #55491 from rkachach/fix_issue_64339

backport mgr/prometheus: fix orch check to prevent Prometheus crash

17 months agobackport mgr/prometheus: fix orch check to prevent Prometheus crash 55491/head
Redouane Kachach [Thu, 8 Feb 2024 07:25:37 +0000 (08:25 +0100)]
backport mgr/prometheus: fix orch check to prevent Prometheus crash
https://tracker.ceph.com/issues/64339

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
17 months agomgr/dashboard: create cephfs snapshot clone 55489/head
Nizamudeen A [Tue, 23 Jan 2024 16:47:46 +0000 (22:17 +0530)]
mgr/dashboard: create cephfs snapshot clone

Fixes: https://tracker.ceph.com/issues/64175
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 129f1db734777f3df551965c35f40ee0ab7d467a)

 Conflicts:
src/pybind/mgr/dashboard/controllers/cephfs.py
  - Left the snapshot scheduler controller out

17 months agoMerge pull request #55484 from zdover23/wip-doc-2024-02-08-backport-55475-to-reef
Anthony D'Atri [Wed, 7 Feb 2024 20:15:51 +0000 (15:15 -0500)]
Merge pull request #55484 from zdover23/wip-doc-2024-02-08-backport-55475-to-reef

reef: doc/radosgw: add confval directives

17 months agodoc/radosgw: add confval directives 55484/head
Zac Dover [Wed, 7 Feb 2024 13:18:35 +0000 (23:18 +1000)]
doc/radosgw: add confval directives

Add confval directives to the documentation of "quota cache" options.
This addresses a request made by Antony D'Atri in https://github.com/ceph/ceph/pull/55075/files#r1444006246.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 6504732e1b5b34756a119bc1547d22c07bd6458a)

17 months agoMerge pull request #55482 from zdover23/wip-doc-2024-02-08-backport-55476-to-reef
Anthony D'Atri [Wed, 7 Feb 2024 19:02:35 +0000 (14:02 -0500)]
Merge pull request #55482 from zdover23/wip-doc-2024-02-08-backport-55476-to-reef

reef: doc/cephadm - edit t11ing.

17 months agoMerge pull request #55454 from guits/node-proxy-subthread-bkp-reef
Adam King [Wed, 7 Feb 2024 15:29:32 +0000 (10:29 -0500)]
Merge pull request #55454 from guits/node-proxy-subthread-bkp-reef

reef: node-proxy: refactor entrypoint (backport)

Reviewed-by: Adam King <adking@redhat.com>
17 months agoMerge pull request #55460 from zdover23/wip-doc-2024-02-06-backport-55447-to-reef
zdover23 [Wed, 7 Feb 2024 15:17:02 +0000 (01:17 +1000)]
Merge pull request #55460 from zdover23/wip-doc-2024-02-06-backport-55447-to-reef

reef: doc/rados: update PG guidance

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
17 months agodoc/cephadm - edit t11ing. 55482/head
Zac Dover [Wed, 7 Feb 2024 13:32:53 +0000 (23:32 +1000)]
doc/cephadm - edit t11ing.

Edit "Running Repeated Debugging Sessions" in
doc/cephadm/troubleshooting.rst. Improve grammar. Fix a misspelling.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit f5b8afe981650f5072294303b0e488b91fc65fe8)

17 months agoceph-volume: fix zap_partitions() in devices.lvm.zap 55477/head
Guillaume Abrioux [Tue, 30 Jan 2024 14:17:35 +0000 (14:17 +0000)]
ceph-volume: fix zap_partitions() in devices.lvm.zap

The current logic is unable to find the holders for the
partition being zapped.

This commit fixes this issue.

Fixes: https://tracker.ceph.com/issues/64248
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 36c83bf5424308214228b1c86d8e1d215b8519c5)

17 months agoMerge pull request #55290 from ceph/revert-54865-wip-63782-reef
Venky Shankar [Tue, 6 Feb 2024 13:25:09 +0000 (18:55 +0530)]
Merge pull request #55290 from ceph/revert-54865-wip-63782-reef

Revert "reef: qa: add support/qa for cephfs-shell on CentOS 9 / RHEL9"

Reviewed-by: Milind Changire <mchangir@redhat.com>
17 months agodoc/rados: update PG guidance 55460/head
Zac Dover [Sun, 4 Feb 2024 15:36:10 +0000 (01:36 +1000)]
doc/rados: update PG guidance

Update the "Creating a Pool" section of doc/rados/operations/pools.rst
so that the documentation no longer insists that the user change the
values of "osd_pool_default_pg_num" and "osd_pool_default_pgp_num".

See also: https://github.com/ceph/ceph/pull/55419

Tracker: https://tracker.ceph.com/issues/64259

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 5ad241442d2c141ba508faba61f39d70f3f09679)

17 months agoRevert "reef: qa: add support/qa for cephfs-shell on CentOS 9 / RHEL9" 55290/head
Venky Shankar [Wed, 24 Jan 2024 06:19:27 +0000 (11:49 +0530)]
Revert "reef: qa: add support/qa for cephfs-shell on CentOS 9 / RHEL9"

Signed-off-by: Venky Shankar <vshankar@redhat.com>
17 months agoMerge pull request #55237 from joscollin/wip-64073-reef
Yuri Weinstein [Mon, 5 Feb 2024 15:25:26 +0000 (07:25 -0800)]
Merge pull request #55237 from joscollin/wip-64073-reef

reef: pybind/mgr/mirroring: drop mon_host from peer_list

Reviewed-by: Venky Shankar <vshankar@redhat.com>
17 months agoMerge pull request #55208 from mchangir/wip-62842-reef
Yuri Weinstein [Mon, 5 Feb 2024 15:24:47 +0000 (07:24 -0800)]
Merge pull request #55208 from mchangir/wip-62842-reef

reef: mgr/snap_schedule: add support for monthly snapshots

Reviewed-by: Venky Shankar <vshankar@redhat.com>
17 months agoMerge pull request #55057 from vshankar/wip-63922-reef
Yuri Weinstein [Mon, 5 Feb 2024 15:24:08 +0000 (07:24 -0800)]
Merge pull request #55057 from vshankar/wip-63922-reef

reef: mds: change priority of mds rss perf counter to useful

Reviewed-by: Milind Changire <mchangir@redhat.com>
17 months agoMerge pull request #55002 from leonid-s-usov/bp/renameat2/reef
Yuri Weinstein [Mon, 5 Feb 2024 15:23:28 +0000 (07:23 -0800)]
Merge pull request #55002 from leonid-s-usov/bp/renameat2/reef

reef: client/fuse: handle case of renameat2 with non-zero flags

Reviewed-by: Milind Changire <mchangir@redhat.com>
17 months agoMerge pull request #54911 from lxbsz/wip-63809
Yuri Weinstein [Mon, 5 Feb 2024 15:22:45 +0000 (07:22 -0800)]
Merge pull request #54911 from lxbsz/wip-63809

reef: mds: set the loner to true for LOCK_EXCL_XSYN

Reviewed-by: Milind Changire <mchangir@redhat.com>
17 months agoMerge pull request #54899 from neesingh-rh/wip-63810-reef
Yuri Weinstein [Mon, 5 Feb 2024 15:22:06 +0000 (07:22 -0800)]
Merge pull request #54899 from neesingh-rh/wip-63810-reef

reef: mds: scrub repair does not clear earlier damage health status

Reviewed-by: Milind Changire <mchangir@redhat.com>
17 months agoMerge pull request #54895 from mchangir/wip-63416-reef
Yuri Weinstein [Mon, 5 Feb 2024 15:21:01 +0000 (07:21 -0800)]
Merge pull request #54895 from mchangir/wip-63416-reef

reef: mds: do not simplify fragset

Reviewed-by: Venky Shankar <vshankar@redhat.com>
17 months agoMerge pull request #54766 from vshankar/wip-53418-reef
Yuri Weinstein [Mon, 5 Feb 2024 15:19:42 +0000 (07:19 -0800)]
Merge pull request #54766 from vshankar/wip-53418-reef

reef: qa: use exisitng ignorelist override list for fs:mirror[-ha]

Reviewed by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
17 months agoMerge pull request #54716 from batrick/wip-63676-reef
Yuri Weinstein [Mon, 5 Feb 2024 15:17:55 +0000 (07:17 -0800)]
Merge pull request #54716 from batrick/wip-63676-reef

reef: mds: revert standby-replay trimming changes

Reviewed-by: Milind Changire <mchangir@redhat.com>
17 months agoMerge pull request #54714 from mchangir/wip-63575-reef
Yuri Weinstein [Mon, 5 Feb 2024 15:17:15 +0000 (07:17 -0800)]
Merge pull request #54714 from mchangir/wip-63575-reef

reef: qa: use correct imports to resolve fuse_mount and kernel_mount

Reviewed-by: Venky Shankar <vshankar@redhat.com>
17 months agoMerge pull request #54493 from leonid-s-usov/bp/balance-after-stop/reef
Yuri Weinstein [Mon, 5 Feb 2024 15:16:21 +0000 (07:16 -0800)]
Merge pull request #54493 from leonid-s-usov/bp/balance-after-stop/reef

reef: mds/MDBalancer: ignore queued callbacks if MDS is not active

Reviewed-by: Milind Changire <mchangir@redhat.com>
17 months agoMerge pull request #54466 from lxbsz/wip-63273
Yuri Weinstein [Mon, 5 Feb 2024 15:15:31 +0000 (07:15 -0800)]
Merge pull request #54466 from lxbsz/wip-63273

reef: client: queue a delay cap flushing if there are ditry caps/snapcaps

Reviewed-by: Milind Changire <mchangir@redhat.com>
17 months agonode-proxy: refactor entrypoint 55454/head
Guillaume Abrioux [Sun, 4 Feb 2024 19:11:41 +0000 (19:11 +0000)]
node-proxy: refactor entrypoint

This commit introduces a major refactor of the main
entrypoint.

- subclass threading.Thread:
  - Introduce a new class `BaseThread()` that is a
    `threading.Thread()` abstraction class in order
    to monitor the different threads.
  - `BaseSystem()` inherits from `BaseThread()`.
  - Handle `SIGTERM` signal in order to gracefully shutdown
    node-proxy (make threads exit gracefully, log out from RedFish API, etc.)

Additionally, this:
  - drops the class `Logger()` from util.py which
was not adding value. It is now replaced with a simple `get_logger()`
function.
  - changes the node-proxy API port from 8080 to 9456
    (8080 being widely used for frontend apps...)
  - changes the container entrypoint in order to use the
    `ceph-node-proxy` binary from the packaging

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit ebf05d5d6cf0532d321a668a4444d2069f995d4a)

17 months agoMerge pull request #54404 from joscollin/wip-63474-reef
Yuri Weinstein [Mon, 5 Feb 2024 10:47:45 +0000 (02:47 -0800)]
Merge pull request #54404 from joscollin/wip-63474-reef

reef: client: call _getattr() for -ENODATA returned _getvxattr() calls

Reviewed-by: Milind Changire <mchangir@redhat.com>
17 months agoMerge pull request #53359 from k0ste/wip-62004-reef
Yuri Weinstein [Mon, 5 Feb 2024 10:45:41 +0000 (02:45 -0800)]
Merge pull request #53359 from k0ste/wip-62004-reef

reef: client: readdir_r_cb: get rstat for dir only if using rbytes for size

Reviewed-by: Milind Changire <mchangir@redhat.com>
17 months agoMerge pull request #55445 from zdover23/wip-doc-2024-02-05-backport-55434-to-reef
Anthony D'Atri [Sun, 4 Feb 2024 19:52:20 +0000 (14:52 -0500)]
Merge pull request #55445 from zdover23/wip-doc-2024-02-05-backport-55434-to-reef

reef: src/common/options: Correct typo in rgw.yaml.in

17 months agosrc/common/options: Correct typo in rgw.yaml.in 55445/head
Anthony D'Atri [Sat, 3 Feb 2024 07:18:25 +0000 (02:18 -0500)]
src/common/options: Correct typo in rgw.yaml.in

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit 1796022aa4778226c2d7e04c1cb989ab9d025272)

17 months agoMerge pull request #55438 from zdover23/wip-doc-2024-02-04-backport-55419-to-reef
Anthony D'Atri [Sun, 4 Feb 2024 00:09:04 +0000 (19:09 -0500)]
Merge pull request #55438 from zdover23/wip-doc-2024-02-04-backport-55419-to-reef

reef: doc/rados: update config for autoscaler

17 months agodoc/rados: update config for autoscaler 55438/head
Zac Dover [Fri, 2 Feb 2024 01:53:45 +0000 (11:53 +1000)]
doc/rados: update config for autoscaler

Update doc/rados/configuration/pool-pg-config-ref.rst to account for the
behavior of autoscaler.

Previously, this file was last meaningfully altered in 2013, prior to
the invention of autoscaler. A recent confusion was brought to my
attention on the Ceph Slack whereby a user attempted to alter the
default values of a Quincy cluster, as suggested in this documentation.
That alteration caused Ceph to throw the error "Error ERANGE: 'pgp_num'
must be greater than 0 and lower or equal than 'pg_num', which in this
case is one" and a related "rgw_init_ioctx ERROR" reading in part
"Numerical result out of range". The user removed the
"osd_pool_default_pgp_num" configuration line from ceph.conf and the
cluster worked as expected. I presume that this is because the removal
of this configuration line allowed autoscaler to work as intended.

Fixes: https://tracker.ceph.com/issues/64259
Co-authored-by: David Orman <ormandj@corenode.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 4dc12092be584da44baca14e31ca33231164235f)

17 months agoMerge pull request #55432 from zdover23/wip-doc-2024-02-03-backport-55403-to-reef
Anthony D'Atri [Sat, 3 Feb 2024 02:51:30 +0000 (21:51 -0500)]
Merge pull request #55432 from zdover23/wip-doc-2024-02-03-backport-55403-to-reef

reef: doc/rgw: fix Attributes index in CreateTopic example

17 months agodoc/rgw: fix Attributes index in CreateTopic example 55432/head
Casey Bodley [Wed, 31 Jan 2024 17:31:02 +0000 (12:31 -0500)]
doc/rgw: fix Attributes index in CreateTopic example

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit ecbd8376675c39893c55ceb7fa8653458d3fc6ed)

17 months agoMerge pull request #55405 from guits/node-proxy-reef
Adam King [Fri, 2 Feb 2024 14:15:31 +0000 (09:15 -0500)]
Merge pull request #55405 from guits/node-proxy-reef

reef: orch: implement hardware monitoring

Reviewed-by: Adam King <adking@redhat.com>
17 months agoMerge pull request #55375 from rkachach/fix_issue_64176
Redouane Kachach [Fri, 2 Feb 2024 10:20:31 +0000 (11:20 +0100)]
Merge pull request #55375 from rkachach/fix_issue_64176

reef backport: rook e2e testing related PRs

17 months agomgr/rook: adding deployment to ceph image built for rook e2e testing 55375/head
Redouane Kachach [Thu, 1 Feb 2024 11:38:46 +0000 (12:38 +0100)]
mgr/rook: adding deployment to ceph image built for rook e2e testing
Fixes: https://tracker.ceph.com/issues/64286
using reef image as base

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
17 months agoMerge pull request #55361 from rhcs-dashboard/wip-63426-reef
Nizamudeen A [Fri, 2 Feb 2024 05:43:18 +0000 (11:13 +0530)]
Merge pull request #55361 from rhcs-dashboard/wip-63426-reef

reef: mgr/dashboard: get object bucket policies for a bucket

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
17 months agoMerge pull request #54951 from idryomov/wip-53897-reef
Yuri Weinstein [Thu, 1 Feb 2024 21:57:26 +0000 (13:57 -0800)]
Merge pull request #54951 from idryomov/wip-53897-reef

reef: librbd: don't report HOLE_UPDATED when diffing against a hole

Reviewed-by: Mykola Golub <mgolub@suse.com>
17 months agobackport mgr/rook: adding metrics monitoring e2e testing
Redouane Kachach [Thu, 1 Feb 2024 09:43:17 +0000 (10:43 +0100)]
backport mgr/rook: adding metrics monitoring e2e testing
Fixes: https://tracker.ceph.com/issues/64247
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
17 months agobackport mgr/rook: adding some basic rook e2e testing
Redouane Kachach [Thu, 1 Feb 2024 09:41:17 +0000 (10:41 +0100)]
backport mgr/rook: adding some basic rook e2e testing
Fixes: https://tracker.ceph.com/issues/64176
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
17 months agobacport mgr/rook: always recreate kvm default network + fix groups refresh
Redouane Kachach [Thu, 1 Feb 2024 09:39:36 +0000 (10:39 +0100)]
bacport mgr/rook: always recreate kvm default network + fix groups refresh
Fixes: https://tracker.ceph.com/issues/64079
This change also includes:
- adding ~/.local/bin to path so behave binary can be found
- adding requirements.txt file for testing dependencies
- increasing timeout used to wait for tools deployment to 90s
- increasing timeout used to wait for kvm network to 20s

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
17 months agoMerge pull request #55316 from ajarr/wip-64181-reef
Yuri Weinstein [Thu, 1 Feb 2024 00:59:32 +0000 (16:59 -0800)]
Merge pull request #55316 from ajarr/wip-64181-reef

reef: rbd-nbd: fix resize of images mapped using netlink

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
17 months agoMerge pull request #55173 from ronen-fr/wip-64019-reef
Yuri Weinstein [Thu, 1 Feb 2024 00:58:18 +0000 (16:58 -0800)]
Merge pull request #55173 from ronen-fr/wip-64019-reef

reef: osd/scrub: increasing max_osd_scrubs to 3

Reviewed-by: Sridhar Seshasayee <sseshasa@redhat.com>
17 months agoMerge pull request #55399 from zdover23/wip-doc-2024-01-31-backport-55396-to-reef
Anthony D'Atri [Wed, 31 Jan 2024 14:53:49 +0000 (09:53 -0500)]
Merge pull request #55399 from zdover23/wip-doc-2024-01-31-backport-55396-to-reef

reef: doc/architecture: improve some paragraphs

17 months agodoc: add node-proxy documentation 55405/head
Guillaume Abrioux [Wed, 31 Jan 2024 14:23:44 +0000 (15:23 +0100)]
doc: add node-proxy documentation

This commit adds some documentation about the
'hardware inventory / monitoring' feature (node-proxy agent).

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit b7c0a6a5b0e7d6ba063e1dd1715f938ecf7ec55d)

17 months agodoc/architecture: improve some paragraphs 55399/head
Zac Dover [Tue, 30 Jan 2024 09:51:53 +0000 (19:51 +1000)]
doc/architecture: improve some paragraphs

Improve paragraphs under the heading "The Ceph Storage Cluster". Remove
a sentence that was pleonastic in its context in the paragraph.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 2f0542d66901295cf875893de0ac15304578d917)

17 months agoMerge pull request #55384 from zdover23/wip-doc-2024-01-31-backport-55372-to-reef
zdover23 [Wed, 31 Jan 2024 01:19:11 +0000 (11:19 +1000)]
Merge pull request #55384 from zdover23/wip-doc-2024-01-31-backport-55372-to-reef

reef: doc/architecture.rst - fix typo

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
17 months agodoc/architecture.rst - fix typo 55384/head
Zac Dover [Tue, 30 Jan 2024 12:24:11 +0000 (22:24 +1000)]
doc/architecture.rst - fix typo

s/requies/requires

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 6c0417fbcbe6b9760b3836e5166d6bd929578096)

17 months agoMerge pull request #55335 from guits/wip-64197-reef
Guillaume Abrioux [Tue, 30 Jan 2024 22:27:10 +0000 (23:27 +0100)]
Merge pull request #55335 from guits/wip-64197-reef

reef: ceph-volume: use 'no workqueue' options with dmcrypt

17 months agoagent/node-proxy: fix wrong host name used in data endpoint
Guillaume Abrioux [Tue, 30 Jan 2024 16:38:31 +0000 (16:38 +0000)]
agent/node-proxy: fix wrong host name used in data endpoint

data['cephx']['name'] will return something like:

node-proxy.hostname123

the prefix "node-proxy." has the be removed otherwise there will be
a mismatch between what is actually expected.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 224dd36df9c57e2162407ea0b98598f401884060)

17 months agocephadm: rewrite NodeProxy class for reef
Adam King [Fri, 26 Jan 2024 16:09:10 +0000 (11:09 -0500)]
cephadm: rewrite NodeProxy class for reef

Since we don't have some refactoring work in reef
that we have in main that allowed writing these daemon
classes in a more standard way

Signed-off-by: Adam King <adking@redhat.com>
17 months agomgr/cephadm: update node-proxy unit tests
Guillaume Abrioux [Thu, 25 Jan 2024 14:34:26 +0000 (14:34 +0000)]
mgr/cephadm: update node-proxy unit tests

The recent migration to a separate daemon implied
some changes which have broken these tests.
This commit fixes them.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 40fe3147a84452d1409f7b792736e090b01c7674)

17 months agomgr/cephadm: add a new config option 'oob_default_addr'
Guillaume Abrioux [Wed, 24 Jan 2024 15:08:14 +0000 (15:08 +0000)]
mgr/cephadm: add a new config option 'oob_default_addr'

So there's a default value (169.254.1.1) which is the default
address for the 'OS to iDrac pass-through' interface.
Given that node-proxy will reach the RedFish API through this interface,
we can make users avoid to pass that addr when providing the host spec
at bootstrap time.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit b09fd672c9838a091d6779047f3292acbb62070d)

17 months agoMerge pull request #55040 from sseshasa/wip-63910-reef
Yuri Weinstein [Tue, 30 Jan 2024 16:12:40 +0000 (08:12 -0800)]
Merge pull request #55040 from sseshasa/wip-63910-reef

reef: osd: Tune snap trim item cost to reflect a PGs' average object size for mClock scheduler

Reviewed-by: Laura Flores <lflores@redhat.com>
17 months agoMerge pull request #55311 from afreen23/wip-64178-reef
Nizamudeen A [Tue, 30 Jan 2024 11:35:28 +0000 (17:05 +0530)]
Merge pull request #55311 from afreen23/wip-64178-reef

reef: mgr/dashboard: Fix inconsistency in capitalisation of "Multi-site"

Reviewed-by: Nizamudeen A <nia@redhat.com>
17 months agomgr/dashboard: Create subvol of same name in different group 55369/head
Afreen [Mon, 29 Jan 2024 10:12:10 +0000 (15:42 +0530)]
mgr/dashboard: Create subvol of same name in different group

Fixes https://tracker.ceph.com/issues/64112

Issue:
Currently, we are unable to create subvolume of same name in different
subvolume group

Fix:
We are validating only the filesystem name of subvolume
which is stopping the creation a subvolume of same name.
Added more granularity , by adding the subvolumegroup name.

Signed-off-by: Afreen <afreen23.git@gmail.com>
(cherry picked from commit fb79df410d39ad01c9192433e03d8a0a33c81568)

17 months agoMerge pull request #55362 from ljflores/wip-64234-reef
Nizamudeen A [Tue, 30 Jan 2024 04:08:15 +0000 (09:38 +0530)]
Merge pull request #55362 from ljflores/wip-64234-reef

reef: mgr: pin pytest to version 7.4.4

Reviewed-by: Nizamudeen A <nia@redhat.com>
17 months agomgr: pin pytest to version 7.4.4 55362/head
Laura Flores [Mon, 29 Jan 2024 00:58:25 +0000 (00:58 +0000)]
mgr: pin pytest to version 7.4.4

On 2024-01-27, pytest updated to 8.0.0,
which broke run-tox-mgr.

https://docs.pytest.org/en/stable/changelog.html

==================================== ERRORS ====================================
_____________________ ERROR collecting alerts/__init__.py ______________________
alerts/__init__.py:2: in <module>
    from .module import Alerts
alerts/module.py:6: in <module>
    from mgr_module import CLIReadCommand, HandleCommandResult, MgrModule, Option
mgr_module.py:1: in <module>
    import ceph_module  # noqa
E   ModuleNotFoundError: No module named 'ceph_module'
______________________ ERROR collecting alerts/module.py _______________________
alerts/module.py:6: in <module>
    from mgr_module import CLIReadCommand, HandleCommandResult, MgrModule, Option
mgr_module.py:1: in <module>
    import ceph_module  # noqa
E   ModuleNotFoundError: No module named 'ceph_module'
____________________ ERROR collecting balancer/__init__.py _____________________
balancer/__init__.py:2: in <module>
    from .module import Module
balancer/module.py:12: in <module>
    from mgr_module import CLIReadCommand, CLICommand, CommandResult, MgrModule, Option, OSDMap, CephReleases
mgr_module.py:1: in <module>
    import ceph_module  # noqa
E   ModuleNotFoundError: No module named 'ceph_module'
_____________________ ERROR collecting balancer/module.py ______________________
balancer/module.py:12: in <module>
    from mgr_module import CLIReadCommand, CLICommand, CommandResult, MgrModule, Option, OSDMap, CephReleases
mgr_module.py:1: in <module>
    import ceph_module  # noqa
E   ModuleNotFoundError: No module named 'ceph_module'

Fixes: https://tracker.ceph.com/issues/64200
Signed-off-by: Laura Flores <lflores@ibm.com>
(cherry picked from commit 5554e565ca7ca9c9d6bc70e245be63d947722eda)

17 months agoMerge pull request #55167 from kamoltat/wip-ksirivad-backport-reef-52380
Yuri Weinstein [Mon, 29 Jan 2024 19:29:53 +0000 (11:29 -0800)]
Merge pull request #55167 from kamoltat/wip-ksirivad-backport-reef-52380

reef: mon/ConnectionTracker.cc: disregard connection scores from mon_rank = -1

Reviewed-by: Laura Flores <lflores@redhat.com>
17 months agomgr/dashboard: get object bucket policies for a bucket 55361/head
Nizamudeen A [Tue, 17 Oct 2023 04:34:33 +0000 (10:04 +0530)]
mgr/dashboard: get object bucket policies for a bucket

Getting the bucket details will also fetch the bucket policy if its set.

Fixes: https://tracker.ceph.com/issues/63221
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 40f053aee0d3504d34545101a546b3eaf64f50d1)

17 months agoMerge pull request #53972 from Matan-B/wip-63180-reef
Yuri Weinstein [Mon, 29 Jan 2024 15:37:11 +0000 (07:37 -0800)]
Merge pull request #53972 from Matan-B/wip-63180-reef

reef: osd/OSD: introduce reset_purged_snaps_last

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
17 months agoMerge pull request #55343 from zdover23/wip-doc-2024-01-29-backport-55341-to-reef
Anthony D'Atri [Mon, 29 Jan 2024 03:56:11 +0000 (22:56 -0500)]
Merge pull request #55343 from zdover23/wip-doc-2024-01-29-backport-55341-to-reef

reef: doc/architecture.rst: improve rados definition

17 months agodoc/architecture.rst: improve rados definition 55343/head
Zac Dover [Sun, 28 Jan 2024 19:33:58 +0000 (05:33 +1000)]
doc/architecture.rst: improve rados definition

Improve the definition of RADOS, and link to information about RADOS.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 763f6b7a22e846962f388d58fd7e699cbf16ffe7)

17 months agoMerge pull request #55338 from zdover23/wip-doc-2024-01-28-backport-55333-to-reef
Anthony D'Atri [Sun, 28 Jan 2024 16:04:17 +0000 (11:04 -0500)]
Merge pull request #55338 from zdover23/wip-doc-2024-01-28-backport-55333-to-reef

reef: doc/radosgw: fix verb disagreement - index.html

17 months agodoc/radosgw: fix verb disagreement - index.html 55338/head
Zac Dover [Sat, 27 Jan 2024 08:40:20 +0000 (18:40 +1000)]
doc/radosgw: fix verb disagreement - index.html

Fix a tricky verb disagreement and rewrite a few sentences for what I
hope is greater clarity.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 9f271093f4331381dc024cb4309f9f486d366818)

17 months agoceph-volume: fix partitions support in disk.get_devices() 55335/head
Guillaume Abrioux [Fri, 26 Jan 2024 20:35:18 +0000 (21:35 +0100)]
ceph-volume: fix partitions support in disk.get_devices()

The following:
```
is_part = get_file_contents(os.path.join(_sys_dev_block_path, item, 'partition')) == "1"
```
assumes any `/sys/dev/block/x:y/partition` contains '1' which is wrong.
This file actually contains the corresponding partition number.

Fixes: https://tracker.ceph.com/issues/64195
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit f72100bbd17539d9774ae72215afefee16f20775)

17 months agoceph-volume: use 'no workqueue' options with dmcrypt
Guillaume Abrioux [Wed, 8 Nov 2023 16:43:46 +0000 (16:43 +0000)]
ceph-volume: use 'no workqueue' options with dmcrypt

CloudFlare engineers made some testing and realized that using
workqueues with encryption on flash devices has a bad effect.

See [1] for details.

With this patch it will make ceph-volume call crypsetup with
`--perf-no_read_workqueue` and `--perf-no_write_workqueue` options
when the device is not a rotational.

[1] https://blog.cloudflare.com/speeding-up-linux-disk-encryption/

Fixes: https://tracker.ceph.com/issues/64195
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
Co-Authored-by: Stefan Kooman <stefan@kooman.org>
(cherry picked from commit 0985e201342fa53c014a811156aed661b4b8f994)

17 months agoceph-volume: fix util.get_partitions
Guillaume Abrioux [Tue, 3 Oct 2023 23:11:32 +0000 (01:11 +0200)]
ceph-volume: fix util.get_partitions

The current logic makes it report only the first
partitions of devices.

Fixes: https://tracker.ceph.com/issues/63086
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit b14ff07e6344d9f097259265d468f6300818b053)

17 months agoMerge pull request #55321 from zdover23/wip-doc-2024-01-26-backport-55307-to-reef
Anthony D'Atri [Fri, 26 Jan 2024 03:43:47 +0000 (22:43 -0500)]
Merge pull request #55321 from zdover23/wip-doc-2024-01-26-backport-55307-to-reef

reef: doc/radosgw: edit "Usage" admin.rst

17 months agodoc/radosgw: edit "Usage" admin.rst 55321/head
Zac Dover [Wed, 24 Jan 2024 19:13:00 +0000 (05:13 +1000)]
doc/radosgw: edit "Usage" admin.rst

Edit "Usage" in doc/radosgw/admin.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit d8df6f61e817a34c2c3282224cff117ae43e3f98)

17 months agonode-proxy: collect `LocationIndicatorActive` property (storage)
Guillaume Abrioux [Tue, 23 Jan 2024 09:41:39 +0000 (09:41 +0000)]
node-proxy: collect `LocationIndicatorActive` property (storage)

This makes node-proxy collect the `LocationIndicatorActive`
property for storage component.
This can be needed for the Blinkenlight feature.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit d4cfc5a96c9e6d04dedb21e7788325d7b00c533a)

17 months agonode-proxy: add new attribute to BaseRedfishSystem()
Guillaume Abrioux [Tue, 23 Jan 2024 09:36:00 +0000 (09:36 +0000)]
node-proxy: add new attribute to BaseRedfishSystem()

This adds `self.component_list()` in order to parametrize
which categories the agent will collect.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit b49216bf8bb01fc8f11f4575cca644bd3ead5f5a)

17 months agonode-proxy: add packaging related changes
Guillaume Abrioux [Mon, 15 Jan 2024 14:09:23 +0000 (14:09 +0000)]
node-proxy: add packaging related changes

This adds the required changes to build an RPM of node-proxy.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 940ce782b5843ef1c0a80a74c5ad2af3f635a8b9)

17 months agonode-proxy: reduce log level in reporter agent
Guillaume Abrioux [Fri, 12 Jan 2024 09:15:02 +0000 (09:15 +0000)]
node-proxy: reduce log level in reporter agent

the following messages get logged quite a lot while
this is not a very useful information in a normal situation:

```
2024-01-12 09:09:40,604 - reporter - INFO - data ready to be sent to the mgr.
2024-01-12 09:09:40,604 - reporter - INFO - no diff, not sending data to the mgr.
2024-01-12 09:10:15,022 - reporter - INFO - data ready to be sent to the mgr.
2024-01-12 09:10:15,022 - reporter - INFO - no diff, not sending data to the mgr.
...
```

This commit changes the log level to DEBUG.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit b4091600f696fa8c3577876e071af3d53024f56f)

17 months agonode-proxy: fix a thread/locking issue
Guillaume Abrioux [Fri, 12 Jan 2024 09:11:21 +0000 (09:11 +0000)]
node-proxy: fix a thread/locking issue

This `sleep(5)` should be initiated *after* the lock is released.
Otherwise, it can cause troubles with the reporter loop which can
never acquire the lock.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 06a4a637b5988a1b6d7bae5d74ae140ff9ba83b6)

17 months agonode-proxy: address a typo
Guillaume Abrioux [Fri, 12 Jan 2024 09:09:15 +0000 (09:09 +0000)]
node-proxy: address a typo

while checking logs, I noticed the following message:

```
2024-01-12 09:08:03,751 - reporter - INFO - Reporter url set to https:10.10.10.11:7150/node-proxy/data
```

Although this is only a cosmetic issue as this variable
is only used for logging messages, let's fix it.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 1c4a212eb8d9608630c518cbbf46ab97051b1bc0)