cephfs-journal-tool:: Don't reset the journal trim position

If the fs had to go through journal recovery and reset,
the cephfs-journal-tool resets the journal trim position
because of which the old unused journal objects just stay
forever in the metadata pool. The patch fixes the issue.
Now, the old stale journal objects are trimmed during the
regular trimming cycle helping to recover space in the
metadata pool.

Fixes: https://tracker.ceph.com/issues/69708
Signed-off-by: Kotresh HR <khiremat@redhat.com>

qa: Validate cephfs-journal-tool reset trim

Validates that the cephfs-journal-tool reset
doesn't reset the trim position so that the
journal trim takes care of trimming the older
unused journal objects helping to recover the
space in metadata pool.

Fixes: https://tracker.ceph.com/issues/69708
Signed-off-by: Kotresh HR <khiremat@redhat.com>

Merge pull request #65061 from zhscn/wip-replay-backref-retire

crimson/os/seastore: add retire alloc remarks for backref extents to skip replay invalid deltas

Reviewed-by: Myoungwon Oh <ohmyoungwon@gmail.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>

Merge pull request #64553 from jamiepryde/teuthology-ec-op-on-off

qa: Add a config setting to the teuthology erasure code tests so that we can test with EC optimizations on and/or off

Merge pull request #64458 from linuxkidd/add-bluestore-frag-warning-desc

mon/PGmap: Add warn description for bluestore fragmentation

Merge pull request #64995 from ifed01/wip-ifed-fix-snapdiff-fragment

mds: fix snapdiff result fragmentation

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #65316 from dmick/uadk-ftbfs

Fix uadk build (arm64 only) on debian (conflict with DESTDIR)

Merge PR #65331 into main

* refs/pull/65331/head:
script/redmine-upkeep: fix formatting of comment

Reviewed-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #65101 from spuiuk/smb_lazy_init

mgr/smb: use lazy_init to create the rados store

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>

Merge pull request #64603 from Naveenaidu/wip-naveen-fix-70972

qa/suites/rados/thrash-old-clients: Add OSD warnings to ignore list

Merge pull request #63687 from samarahu/wip-samarahu-standalone-user

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>

Merge pull request #64717 from abitdrag/tracker_72265

auth: msgr2 can return incorrect allowed_modes through AuthBadMethodFrame

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

script/redmine-upkeep: fix formatting of comment

The update log link would appear as preformatted text.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

Merge pull request #64550 from kotreshhr/multifs-authcaps

Fix multifs auth caps check

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #64273 from tchaikov/wip-ceph-mutex-atomic

common/mutex_debug: fix arm64 SIGBUS/segfault due to data race

Merge pull request #64696 from rzarzynski/wip-bug-71966

tools: make rados ls aware about the locator concept

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge PR #64663 into main

* refs/pull/64663/head:

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>

Merge pull request #65079 from rhcs-dashboard/img-summary-mirroring

mgr/dashboard: expose image summary API

Merge pull request #65240 from knrt10/test-crimson-librbd-reenable

qa/suites/crimson-rados: run full librbd test suite

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #64554 from jamiepryde/teuthology-ec-more-configs

qa: Add cauchy and 16K chunk size profiles to rados erasure code teuthology suites

Merge pull request #64577 from rzarzynski/wip-ec-shuffling-for-crimson

osd: shuffle FastEC code needed by crimson from ECBackend to ECCommon

Merge pull request #65192 from tchaikov/wip-cmake-silence-lsan

cmake: disable LeakSanitizer suppression output to fix CLI tests

Reviewed-by: Casey Bodley <cbodley@redhat.com>

cmake/modules/Builduadk.cmake: fix build

DESTDIR should not be set when building.

Fixes: https://tracker.ceph.com/issues/72722
Signed-off-by: Dan Mick <dan.mick@redhat.com>

cmake/modules/Builduadk.cmake: fix tabs/spaces

Signed-off-by: Dan Mick <dan.mick@redhat.com>

Merge PR #65276 into main

* refs/pull/65276/head:
.github/workflows: run redmine-upkeep for release branches

Reviewed-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #65285 from rhcs-dashboard/table-actions

mgr/dashboard: add customizations to table-actions

Reviewed-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #65246 from afreen23/remove-old-dash

Drop support for older version of dashboard

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #63641 from anushruti10116/add-bucket-notification-dashboard

mgr/dashboard: Adding RGW Bucket Notification Dashboard for Grafana

Merge pull request #65284 from pritha-srivastava/wip-rgw-d4n-centos9-build-failure

rgw/d4n: removing fmt related code as it is

Reviewed-by: Casey Bodley <cbodley@redhat.com>

mgr/dashboard: Update release notes and doc

-  for removal of old dashoard support

Signed-off-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #65176 from phlogistonjohn/jjm-cephadm-build-el10rpm

cephadm: fix building rpm-sourced cephadm zippapp on el10

Reviewed-by: Adam King <adking@redhat.com>

rgw/d4n: removing fmt related code as it is
causing centos 9 build failure and is debug
only code.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>

mgr/dashboard: add customizations to table-actions

https://tracker.ceph.com/issues/72764

Signed-off-by: Naman Munet <naman.munet@ibm.com>

Merge pull request #65029 from guits/drop-udevadm-subprocess-calls

ceph-volume: drop udevadm subprocess calls

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #64955 from rhcs-dashboard/bug-2314829-about-panel

mgr/dashboard: About panel showing other icons in background while open

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Dnyaneshwari Talwekar <dtalwekar@redhat.com>

Merge pull request #65146 from rhcs-dashboard/fix-72656-main

mgr/dashboard: Fix duplicate selection on multi-select in table component

Reviewed-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #65247 from afreen23/optimize-css

mgr/dashboard: Optimize css styles.css bundle

Reviewed-by: Nizamudeen A <nia@redhat.com>com>
Reviewed-by: Abhishek Desai <abhishek.desai1@ibm.com>

fixing review comment

Signed-off-by: Anushruti Sharma <anushruti10116@gmail.com>

.github/workflows: run redmine-upkeep for release branches

This `if` was filtering out merges for release branches like squid.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

Merge pull request #65050 from zmc/osd-method-passing

cephadm: Use specified method for osd.default

Merge PR #65266 into main

* refs/pull/65266/head:
script/redmine-upkeep: filter by one status_id at a time
script/redmine-upkeep: add more statuses and organize
script/redmine-upkeep: break out of filters on limit threshold
.github/workflows/redmine-upkeep: bump limit

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

script/redmine-upkeep: filter by one status_id at a time

The API, unlike the www browser, does not actually allow filtering multiple
status IDs. We have to filter for each status we want to look at.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

script/redmine-upkeep: add more statuses and organize

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

script/redmine-upkeep: break out of filters on limit threshold

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

.github/workflows/redmine-upkeep: bump limit

Now that this no longer hits the github API in general, it's safer to process
many more issues. This is generally good as it's not possible to construct a
specific search that will process issues that have had their corresponding PR
merged. (We do have merge triggers however.)  Additionally, process more issues
but only every 12 hours.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

Merge pull request #64973 from edwinzrodriguez/ceph-wip-72482

test/osd: Suppress subobject-linkage warning in SelectMappingAndLayers

Merge pull request #64742 from cbodley/wip-72315

rgw/s3: support paginated ListBuckets

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>

mgr/dashboard: Optimize css styles.css bundle

-  compresses the css bundle before sending to browser
-  this improves LCP value value as well

Fixes https://tracker.ceph.com/issues/72742

Signed-off-by: Afreen Misbah <afreen@ibm.com>

mgr/dashboard: use border:0 for clipboard css

- Sets border-width: 0
- Completely removes the border
- More memory efficient than `border: none` which occupies some browser memory
- Higher priority in border conflicts

Signed-off-by: Afreen Misbah <afreen@ibm.com>

mgr/dashboard: Drop support for older version of dashboard

Fixes https://tracker.ceph.com/issues/72739

- remove the code for previous version of dashboard
- popover css was globally added in infocard component which needs to be removed now. So include css in respective components- dashboard and upgrade.

Signed-off-by: Afreen Misbah <afreen@ibm.com>

cephadm: Use specified method for osd.default

When creating the first OSD in a cluster, the method requested was being
ignored - meaning an LVM OSD would be created in all cases. If a given cluster
couldn't support LVM, it could not be deployed. If we relay the method value
requested by the cephadm invocation, we can create OSDs as expected.

Fixes: https://tracker.ceph.com/issues/72381
Signed-off-by: Zack Cerza <zack@cerza.org>

test/osd: Suppress subobject-linkage warning in SelectMappingAndLayers class

Change SelectMapping and SelectLayers definitions to use non-static arrays of strings.

SelectMappingAndLayers::sma and SelectMappingAndLayers::sly have internal storage
duration, because it is a non-template, non-inline, non-extern const-qualified variable.

As a consequence, in each translation unit sma and sly is a different object.
And because ProgramOptionSelector takes a reference as template argument, then
ProgramOptionSelector<...> are different specializations of ProgramOptionSelector
in different translation units, because the template parameter references different objects in each.

Then, if you include the header in two different translation units, the program will
have undefined behavior, because the definitions of SelectMapping violates the one-definition
rule as they are, roughly said, not semantically identical. The compiler has no way to
decide whether SelectMapping is supposed to have ProgramOptionSelector<value1> or
ProgramOptionSelector<value2> as base class (where value1 and value2 are invented names
for the two instances of io_sequence::tester::lrc::mapping_layer_array_sizes in the
different translation units).

Fixes: https://tracker.ceph.com/issues/72482
Signed-off-by: Edwin Rodriguez <edwin.rodriguez1@ibm.com>

Merge pull request #65222 from dmick/make-debs-remove-git-clean

Remove git clean -fdx

mgr/dashboard: minor fixes

- purge css got added by mistake while testing in pr https://github.com/ceph/ceph/pull/65019/
- updated helath snaphost schema to include num_hosts

Signed-off-by: Afreen Misbah <afreen@ibm.com>

mgr/dashboard: Add localization for nx based production builds

Signed-off-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #63921 from pritha-srivastava/wip-rgw-d4n-iterate-connpool-pipeline

rgw/d4n: Integration of optimization in iterate, connection pool and pipelining

mgr/dashboard: expose image summary API

Introduce a new API for getting per image summary
```
╰─$ curl -kX GET "https://localhost:4200/api/block/mirroring/rbd/test/summary" \
-H "Accept: application/vnd.ceph.api.v1.0+json" \
-H "Authorization: Bearer $TOKEN" -H "Content-Type: application/json" | jq .
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   637  100   637    0     0  14597      0 --:--:-- --:--:-- --:--:-- 14813
{
  "name": "test2",
  "id": "10d618ea1a58",
  "info": {
    "global_id": "f25678be-64a2-481f-b96c-9bcc566dcbfe",
    "state": 1,
    "primary": true
  },
  "remote_statuses": [
    {
      "state": "Replaying",
      "description": {
        "bytes_per_second": 0.0,
        "bytes_per_snapshot": 0.0,
        "last_snapshot_bytes": 0,
        "last_snapshot_sync_seconds": 0,
        "local_snapshot_timestamp": 1755579780,
        "remote_snapshot_timestamp": 1755579780,
        "replay_state": "idle"
      },
      "last_update": "2025-08-19T05:03:17Z",
      "up": true,
      "mirror_uuid": "4d734616-5a38-4399-b743-86bcd8c1ab8f"
    }
  ],
  "state": 6,
  "description": "local image is primary",
  "last_update": "2025-08-19T05:03:10Z",
  "up": true
}
```
Also update the existing API to add the image syncing status. The
/summary API's `image_ready` will also have the `remote_status` which is
a list of dict to show the status of all the remote clusters (one image
can be mirrored to more than one cluster)

```
"image_ready": [
            {
                "pool_name": "rbd",
                "name": "test2",
                "state_color": "info",
                "state": "Stopped",
                "mirror_mode": "snapshot",
                "description": "local image is primary",
                "remote_status": [
                    {
                        "state": "Replaying",
                        "description": {
                            "bytes_per_second": 0.0,
                            "bytes_per_snapshot": 0.0,
                            "last_snapshot_bytes": 0,
                            "last_snapshot_sync_seconds": 0,
                            "local_snapshot_timestamp": 1755579780,
                            "remote_snapshot_timestamp": 1755579780,
                            "replay_state": "idle"
                        },
                        "last_update": "2025-08-19T05:03:47Z",
                        "up": true,
                        "mirror_uuid": "4d734616-5a38-4399-b743-86bcd8c1ab8f"
                    }
                ]
            }
        ]
```

Fixes: https://tracker.ceph.com/issues/72520
Signed-off-by: Nizamudeen A <nia@redhat.com>

Merge pull request #65130 from cbodley/wip-72643

rpm: default to gcc-toolset-13, not just for crimson

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #65169 from afreen23/nfs-fix

mgr/dashboard: Dashboard nfs export editor rejects ipv6 addresses

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #65230 from anthonyeleven/bs-slow-op-alert

doc/rados/operations: Improve health-checks.rst

Reviewed-by: Zac Dover <zac.dover@proton.me>

doc/rados/operations: Improve health-checks.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>

test/librbd: Add SKIP_IF_CRIMSON for failing tests

Since now crimson has all tests enabled some still fails. This skips
them and adds a dedicated tracker for the same.

Co-authored-by: Matan Breizman <mbreizma@redhat.com>
Signed-off-by: Kautilya Tripathi <kautilya.tripathi@ibm.com>

fixing review comment

Signed-off-by: Anushruti Sharma <anushruti10116@gmail.com>

fixing review comment

Signed-off-by: Anushruti Sharma <anushruti10116@gmail.com>

Merge pull request #65019 from afreen23/ceph-status-api

Add /health/snapshot api

Reviewed-by: Nizamudeen A <nia@redhat.com>

mgr/dashboard: Fix duplicate selection on multi-select in table component

Fixes: https://tracker.ceph.com/issues/72656
Signed-off-by: Aashish Sharma <Aashish.Sharma1@ibm.com>

Merge pull request #65208 from rhcs-dashboard/72717-test-host-tc-failing

mgr/dashboard: Fix test_host.py test case

Reviewed-by: Aashish Sharma <aasharma@redhat.com>

rgw/d4n: comment to suppress false positive
flagged by coverity

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>

rgw/d4n: fix for rgw user create hanging when vstart
cluster starts when there is data in cache.

the cleaning thread sleeps when the entry for cleaning
has not expired, therefore radosgw-admin user create hangs
when vstart cluster comes up.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>

rgw/d4n: changes to integrate pipelining with connection pool.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>

rgw/d4n: add pipelining to PUT in write-cache
and read cache for data blocks directory entries

introduced a pipelined version of set command.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>

rgw/d4n: use boost::generic::response for bucket list operation.

1. test case to explore pipelining using boost::redis::generic_response

2. introduced a get method based on redis::generic_response
and used the same for Bucket::list.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>

the current connection setup is single and shared connection, the strand on that single connection may cause a serialization.
it should be noted that per s3-request there are several redis-operation that may run on co-routine.
the redis-connection pool implement the guarded acquire/release APIs.

adding configuration : rgw_redis_connection_pool_size.
re-factor of redis-exec* function.

shared pointer for Redis connection pool

adding branch predication optimization for redis-pool/single-shared-connection condition

adding a warning-report-method for the case there is a blocking state upon empty connection pool.

Signed-off-by: galsalomon66 <gal.salomon@gmail.com>

Remove git clean -fdx

either
1) a source tarball is supplied, in which case the local dir is
   irrelevant, or
2) make-debs calls make-dist, which doesn't care about a dirty cwd

so it just punishes the unaware by removing things that they may
have wanted to keep.

Signed-off-by: Dan Mick <dan.mick@redhat.com>

Merge pull request #64681 from athanatos/sjust/wip-rocky-10

rocky 10 build error fixes

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Merge PR #65217 into main

* refs/pull/65217/head:
.github: pass GITHUB_TOKEN to redmine-upkeep
.github/workflows: remove unnecessary permissions for leaving PR comments
script/redmine-upkeep: pass token to auth
script/redmine-upkeep: cleanup formatting for github comment

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

fixing review comment

Signed-off-by: Anushruti Sharma <anushruti10116@gmail.com>

.github: pass GITHUB_TOKEN to redmine-upkeep

This was the actual problem preventing the script from leaving comments.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

.github/workflows: remove unnecessary permissions for leaving PR comments

https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#permissions

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

script/redmine-upkeep: pass token to auth

I believe I structured it this way originally because I had copied from
ptl-tool.py which used a personal github token.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

script/redmine-upkeep: cleanup formatting for github comment

Manually breaking the lines screws up the formatting of the comment in github.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

Merge pull request #65190 from dmick/make-debs-no-tar-chown

make-debs.sh: invoke tar with --no-same-owner

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: David Galloway <david.galloway@ibm.com>

Merge pull request #65180 from qiuxinyidian/doc

doc/dev:update blkin.rst doc for lttng trace

mgr/dashboard: Fix test_host.py test case
fixes: https://tracker.ceph.com/issues/72717

Signed-off-by: Abhishek Desai <abhishek.desai1@ibm.com>

Merge pull request #64659 from anthonyeleven/fix-mds-units

Update CephFS option descriptions

Merge pull request #64074 from nh2/docs-config-more-commands

doc/rados/configuration: Mention show-with-defaults and ceph-conf

Reviewed-by: Zac Dover <zac.dover@proton.me>

Merge pull request #64969 from edwinzrodriguez/ceph-wip-72478

common/async:: Update delete operator in CompletionImpl

Merge pull request #64827 from rhcs-dashboard/72408-rgw-crypt-kmip-addr-format-change

mgr/dashboard: rgw_crypt_kmip_addr in SSE-KMS kmip address input field validation updated

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>

Merge pull request #64440 from cbodley/wip-21128

rgw/s3: remove 'aws-chunked' from Content-Encoding response

Reviewed-by: Seena Fallah <seenafallah@gmail.com>

Merge pull request #64993 from xxhdx1985126/wip-72539

crimson/os/seastore/object_data_handler: remove redundant indirect mappings at the end of ObjectDataHandler::clone()

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #64951 from rhcs-dashboard/72522-remove-service-instances

mgr/dashboard : 72522 - Remove service instances column to imporve API perf

Reviewed-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #65102 from rhcs-dashboard/72608-optimize-host-api

mgr/dashboard : Optimized /host API to minimum resp

Reviewed-by: Nizamudeen A <nia@redhat.com>

mgr/dashboard: Add /health/snapshot api

Fixes https://tracker.ceph.com/issues/72609

- The current minimal API relies on fetching data from osdmap and pgmap.
- These commands produce large, detailed payloads that become a performance bottleneck and impact scalability, especially in large clusters.
- To address this, we propose switching to the ceph snapshot API using ceph status command, which retrieves essential information directly from the cluster map.
- ceph status is significantly more lightweight compared to osdmap/pgmap, reducing payload sizes and processing overhead.
- This change ensures faster response times, improves system efficiency in large deployments, and minimizes unnecessary data transfer.
- update tests

Signed-off-by: Afreen Misbah <afreen@ibm.com>

mgr/dashboard: Dashboard nfs export editor rejects ipv6 addresses

Fixes https://tracker.ceph.com/issues/72660

Signed-off-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #65165 from amathuria/wip-amat-splitting-fixes

crimson/osd: pg splitting fixes

Merge pull request #65185 from zdover23/wip-doc-2025-08-22-cephfs-troubleshooting

doc/cephfs: edit troubleshooting.rst (Slow MDS)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #65154 from chanyoung/fix-cbjournal-boundary-check

crimson/.../circular_journal_space: fix boundary check

Reviewed-by: Myoungwon Oh <ohmyoungwon@gmail.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #65027 from Hezko/nvmeof-cli-71983-fix

mgr/dashboard: fix missing gw group error

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #65108 from zhscn/fix-assert

crimson/os/seastore/CBJournal: correct needs_roll condition

Reviewed-by: Myoungwon Oh <ohmyoungwon@gmail.com>

Merge pull request #65070 from chanyoung/remove-redundant-memset

crimson/.../rbm_device: remove unnecessary zero fill in anonymous mmap

Reviewed-by: Myoungwon Oh <ohmyoungwon@gmail.com>