]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
2 years agoosd: change 2 ObjectContext flags from bitfields to full variables 48597/head
Ronen Friedman [Sun, 23 Oct 2022 14:34:33 +0000 (17:34 +0300)]
osd: change 2 ObjectContext flags from bitfields to full variables

The change does not increase the size of the structure. It does
simplify fmt-formatting of the boolean flags, and has better
performance.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2 years agoMerge pull request #48593 from zdover23/wip-doc-2022-10-23-cephadm-front-matter
zdover23 [Sun, 23 Oct 2022 02:18:00 +0000 (12:18 +1000)]
Merge pull request #48593 from zdover23/wip-doc-2022-10-23-cephadm-front-matter

doc/cephadm: update install.rst

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agodoc/cephadm: update install.rst 48593/head
Zac Dover [Sun, 23 Oct 2022 01:09:18 +0000 (11:09 +1000)]
doc/cephadm: update install.rst

This commit addresses https://github.com/ceph/ceph/pull/43250,
which has remained unmerged for thirteen months. The issues
raised in that PR are addressed here.

This commit contributes to the simplification of the procedure
that explains how to install cephadm. More remains to be done
on this page, but the old PR had to be dealt with first.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #48584 from tchaikov/crimson-net-formatter
Kefu Chai [Sat, 22 Oct 2022 00:27:00 +0000 (08:27 +0800)]
Merge pull request #48584 from tchaikov/crimson-net-formatter

crimson/net: define fmt::formatter for write_state_t

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
2 years agoMerge pull request #48587 from zdover23/wip-doc-2022-10-22-cephadm-host-management...
zdover23 [Fri, 21 Oct 2022 18:04:56 +0000 (04:04 +1000)]
Merge pull request #48587 from zdover23/wip-doc-2022-10-22-cephadm-host-management-prompts

doc/cephadm: add prompts to host-management.rst

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agoMerge pull request #48555 from phlogistonjohn/jjm-unify-test-alertmanager-config
Adam King [Fri, 21 Oct 2022 16:55:27 +0000 (12:55 -0400)]
Merge pull request #48555 from phlogistonjohn/jjm-unify-test-alertmanager-config

mgr/cephadm: consolidate test_alertmanager_config_* tests into one

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2 years agodoc/cephadm: add prompts to host-management.rst 48587/head
Zac Dover [Fri, 21 Oct 2022 16:42:33 +0000 (02:42 +1000)]
doc/cephadm: add prompts to host-management.rst

This PR adds unselectable prompts to host-management.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agocrimson/net: define fmt::formatter for write_state_t 48584/head
Kefu Chai [Fri, 21 Oct 2022 16:12:19 +0000 (00:12 +0800)]
crimson/net: define fmt::formatter for write_state_t

for better readability

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agoMerge pull request #48478 from myoungwon/wip-rbm-move-mkfs-cleanup
Yingxin [Fri, 21 Oct 2022 10:01:15 +0000 (18:01 +0800)]
Merge pull request #48478 from myoungwon/wip-rbm-move-mkfs-cleanup

crimson/os/seastore/rbm: move mkfs to RBMDevice and use device_config_t

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agoMerge pull request #48445 from rzarzynski/wip-crimson-fix-obcload-errs
Radoslaw Zarzynski [Fri, 21 Oct 2022 07:35:56 +0000 (09:35 +0200)]
Merge pull request #48445 from rzarzynski/wip-crimson-fix-obcload-errs

crimson/osd: send proper reply on obc load failure

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #48577 from zdover23/wip-doc-2022-10-21-radosgw-notifications...
zdover23 [Fri, 21 Oct 2022 03:47:56 +0000 (13:47 +1000)]
Merge pull request #48577 from zdover23/wip-doc-2022-10-21-radosgw-notifications-and-event

doc/radosgw: refine "notifications" and "events"

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agodoc/radosgw: refine "notifications" and "events" 48577/head
Zac Dover [Fri, 21 Oct 2022 03:07:16 +0000 (13:07 +1000)]
doc/radosgw: refine "notifications" and "events"

This commit refines the English in the "Notifications"
and "Events" sections of the notifications.rst page
(the "Bucket Notifications" page).

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agocrimson/os/seastore/cbj: handle remaing space (from written_to to the end of the... 48478/head
myoungwon oh [Fri, 21 Oct 2022 01:56:58 +0000 (10:56 +0900)]
crimson/os/seastore/cbj: handle remaing space (from written_to to the end of the journal) is less than the requested size

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2 years agocrimson/os/seastore/rbm: move test interfaces to the end of the class
myoungwon oh [Thu, 20 Oct 2022 05:21:49 +0000 (14:21 +0900)]
crimson/os/seastore/rbm: move test interfaces to the end of the class

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2 years agocrimson/os/seastore/cbj: rename size-related interfaces with grouping
myoungwon oh [Thu, 20 Oct 2022 05:16:51 +0000 (14:16 +0900)]
crimson/os/seastore/cbj: rename size-related interfaces with grouping

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2 years agoMerge pull request #48477 from rzarzynski/wip-crimson-rollback-delete-head
Samuel Just [Fri, 21 Oct 2022 01:27:55 +0000 (18:27 -0700)]
Merge pull request #48477 from rzarzynski/wip-crimson-rollback-delete-head

crimson/osd: add the delete-head special case of CEPH_OSD_OP_ROLLBACK

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #48572 from zdover23/wip-doc-2022-10-21-cephadm-host-management...
zdover23 [Thu, 20 Oct 2022 19:22:53 +0000 (05:22 +1000)]
Merge pull request #48572 from zdover23/wip-doc-2022-10-21-cephadm-host-management-os-tuning-grammar

doc/cephadm: refine "os tuning" in h. management

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/cephadm: refine "os tuning" in h. management 48572/head
Zac Dover [Thu, 20 Oct 2022 18:43:24 +0000 (04:43 +1000)]
doc/cephadm: refine "os tuning" in h. management

This commit refines the English in the "OS Tuning Profiles" section of
the "Host Management" page of the cephadm documentation. This commit is
made separately from but in anticipation of a forthcoming commit that
corrects technical (non-grammatical) errors.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #46089 from myoungwon/wip-dedup-doc
zdover23 [Thu, 20 Oct 2022 15:54:56 +0000 (01:54 +1000)]
Merge pull request #46089 from myoungwon/wip-dedup-doc

doc/dev: add explanation of how to use deduplication

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agocrimson/osd: add the delete-head special case of CEPH_OSD_OP_ROLLBACK 48477/head
Radoslaw Zarzynski [Thu, 13 Oct 2022 11:54:35 +0000 (11:54 +0000)]
crimson/osd: add the delete-head special case of CEPH_OSD_OP_ROLLBACK

This allows to pass `TestLibRBD.TestIOToSnapshot`:

```
[rzarzynski@o06 build]$ CRIMSON_COMPAT=true RBD_FEATURES=1 bin/ceph_test_librbd --gtest_filter=TestLibRBD.TestIOToSnapshot
seed 3954016
Note: Google Test filter = TestLibRBD.TestIOToSnapshot
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from TestLibRBD
[ RUN      ] TestLibRBD.TestIOToSnapshot
using new format!
...
opening testimg@orig
read: 80
write to snapshot returned -30
Read-only file system
num snaps is: 2
expected: 2
snap: orig
snap: written
found orig with size 2097152
found written with size 2097152
num snaps is: 1
expected: 1
snap: orig
found orig with size 2097152
num snaps is: 0
expected: 0
[       OK ] TestLibRBD.TestIOToSnapshot (7510 ms)
[----------] 1 test from TestLibRBD (7510 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (8504 ms total)
[  PASSED  ] 1 test.
```

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2 years agoMerge pull request #48246 from liangmingyuanneo/fix-throttle-test
Casey Bodley [Thu, 20 Oct 2022 13:42:35 +0000 (09:42 -0400)]
Merge pull request #48246 from liangmingyuanneo/fix-throttle-test

test/rgw: improve integrity of rgw throttle test

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agocrimson/osd: ClientRequest sends error to client when loading obc fails 48445/head
Radoslaw Zarzynski [Tue, 11 Oct 2022 13:38:30 +0000 (13:38 +0000)]
crimson/osd: ClientRequest sends error to client when loading obc fails

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2 years agoMerge pull request #48456 from rhcs-dashboard/cypress-video-enable
Nizamudeen A [Thu, 20 Oct 2022 06:07:52 +0000 (11:37 +0530)]
Merge pull request #48456 from rhcs-dashboard/cypress-video-enable

mgr/dashboard: enable cypress video on test fails

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
2 years agoMerge pull request #48546 from rhcs-dashboard/update-node
Nizamudeen A [Thu, 20 Oct 2022 06:07:07 +0000 (11:37 +0530)]
Merge pull request #48546 from rhcs-dashboard/update-node

cmake: bump node version to 14

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2 years agoMerge pull request #48505 from zhscn/fix-uaf
Kefu Chai [Thu, 20 Oct 2022 03:20:51 +0000 (11:20 +0800)]
Merge pull request #48505 from zhscn/fix-uaf

crimson/osd: fix use after free error in FuturizedStoreLogReader::read

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2 years agoMerge pull request #48556 from zdover23/wip-doc-2022-10-20-radosgw-notifications...
zdover23 [Wed, 19 Oct 2022 21:51:36 +0000 (07:51 +1000)]
Merge pull request #48556 from zdover23/wip-doc-2022-10-20-radosgw-notifications-bucket-notifications-rest-api

doc/radosgw: refine "bucket notifications"

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agodoc/radosgw: refine "bucket notifications" 48556/head
Zac Dover [Wed, 19 Oct 2022 18:35:14 +0000 (04:35 +1000)]
doc/radosgw: refine "bucket notifications"

This commit refines the English in the "Bucket Notifications REST API"
section of the notifications.rst page (the "Bucket Notifications" page).

Co-author: Cole Mitchell <cole.mitchell@gmail.com>

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #47848 from galsalomon66/s3select_next_version
Casey Bodley [Wed, 19 Oct 2022 19:44:27 +0000 (15:44 -0400)]
Merge pull request #47848 from galsalomon66/s3select_next_version

moving to next version of s3select.

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agomgr/cephadm: consolidate test_alertmanager_config_* tests into one 48555/head
John Mulligan [Wed, 19 Oct 2022 17:25:51 +0000 (13:25 -0400)]
mgr/cephadm: consolidate test_alertmanager_config_* tests into one

Consolidate all the test_alertmanager_config_* tests into one pytest
parameterized test function. While doing this make all test instances
use a mock socket.getfqdn so that all hostname resolution is controlled
by the test and shouldn't fail on systems set up differently from the
test runners.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2 years agoMerge pull request #48532 from ceph/wip-yuriw-release-17.2.5-main
Laura Flores [Wed, 19 Oct 2022 18:06:50 +0000 (13:06 -0500)]
Merge pull request #48532 from ceph/wip-yuriw-release-17.2.5-main

doc: 17.2.5 Release Notes

2 years agodoc: 17.2.5 Release Notes 48532/head
Yuri Weinstein [Tue, 18 Oct 2022 16:38:49 +0000 (09:38 -0700)]
doc: 17.2.5 Release Notes

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
Signed-off-by: Laura Flores <lflores@redhat.com>
2 years agocrimson/os/seastore/rbm: rename TestMemory to EphemeralRBMDevice and adjust default...
myoungwon oh [Wed, 19 Oct 2022 07:27:37 +0000 (16:27 +0900)]
crimson/os/seastore/rbm: rename TestMemory to EphemeralRBMDevice and adjust default paramter location

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2 years agocrimson/os/seastore/cbj: add get_journal_start() and adjust it to default block size
myoungwon oh [Tue, 18 Oct 2022 01:48:05 +0000 (10:48 +0900)]
crimson/os/seastore/cbj: add get_journal_start() and adjust it to default block size

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2 years agocrimson/os/seastore/cbj: merge mkfs() in cbj into open_for_mkfs()
myoungwon oh [Wed, 19 Oct 2022 08:13:59 +0000 (17:13 +0900)]
crimson/os/seastore/cbj: merge mkfs() in cbj into open_for_mkfs()

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2 years agocmake: bump node version to 14 48546/head
Nizamudeen A [Wed, 19 Oct 2022 08:04:58 +0000 (13:34 +0530)]
cmake: bump node version to 14

to update the angular to 13, we need a node version of either 12.20.x or
14.15.x or 16.10.x. But inorder to not break the angular 12 run for now
   we  need to choose the node which works for both 12 and 13. which is
14.15.x. So I went with that node version here.

Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #48347 from ronen-fr/wip-rf-acting
Ronen Friedman [Wed, 19 Oct 2022 05:13:25 +0000 (08:13 +0300)]
Merge pull request #48347 from ronen-fr/wip-rf-acting

osd/scrub: use the actual active set when requesting replicas to scrub

Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #48510 from ceph/update-mailmap
Nizamudeen A [Wed, 19 Oct 2022 05:06:14 +0000 (10:36 +0530)]
Merge pull request #48510 from ceph/update-mailmap

mailmap: add Pedro Gonzalez Gomez

Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #48528 from ceph/fix-gh_pr_triage_node_version-main
Nizamudeen A [Wed, 19 Oct 2022 05:03:52 +0000 (10:33 +0530)]
Merge pull request #48528 from ceph/fix-gh_pr_triage_node_version-main

.github/pr-triage: update node.js to v16

Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #48515 from athanatos/sjust/wip-crimson-suites
Samuel Just [Tue, 18 Oct 2022 22:45:28 +0000 (15:45 -0700)]
Merge pull request #48515 from athanatos/sjust/wip-crimson-suites

qa/suites/crimson-rados: move seastore to crimson-rados-experimental, remove cache/dedup workloads

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
2 years agomoving to next version of s3select 47848/head
galsalomon66 [Mon, 29 Aug 2022 09:05:35 +0000 (12:05 +0300)]
moving to next version of s3select
s3select submodule

Signed-off-by: galsalomon66 <gal.salomon@gmail.com>
2 years agoMerge pull request #48533 from zdover23/wip-doc-2022-10-19-radosgw-notification-topic...
zdover23 [Tue, 18 Oct 2022 17:14:46 +0000 (03:14 +1000)]
Merge pull request #48533 from zdover23/wip-doc-2022-10-19-radosgw-notification-topic-management-and-notification-performance

doc/radosgw: refine top. man. and not. perf. stats

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/radosgw: refine top. man. and not. perf. stats 48533/head
Zac Dover [Tue, 18 Oct 2022 16:55:23 +0000 (02:55 +1000)]
doc/radosgw: refine top. man. and not. perf. stats

This commit refines the English in the "Topic Management via CLI" and
"Notification Performance Statistics" sections of the notifications.rst
file.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #48444 from yuvalif/wip-yuval-fix-57850
Yuval Lifshitz [Tue, 18 Oct 2022 16:07:42 +0000 (19:07 +0300)]
Merge pull request #48444 from yuvalif/wip-yuval-fix-57850

rgw/amqp: store CA location string in connection object

2 years agoqa/suites/crimson-rados: remove cache and dedup related tests 48515/head
Samuel Just [Mon, 10 Oct 2022 23:33:38 +0000 (16:33 -0700)]
qa/suites/crimson-rados: remove cache and dedup related tests

It's an accident that some of these pass -- the tests provide some
coverage for inconsistencies that can arise, but don't really validate
that the objects actually get moved between tiers.

It's going to be some time before we implement cache or dedup in
crimson, and we'll probably want to disable the related commands for
pools that can map to crimson osds to prevent accidents.

Signed-off-by: Samuel Just <sjust@redhat.com>
2 years agoqa/suites: move seastore to crimson-rados-experimental suite
Samuel Just [Mon, 10 Oct 2022 23:30:06 +0000 (16:30 -0700)]
qa/suites: move seastore to crimson-rados-experimental suite

Let's use crimson-rados-experimental for tests that don't yet
pass reliably.  We can move these to crimson-rados as they
become reliable.

Signed-off-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #48511 from zdover23/wip-doc-2022-10-18-radosgw-notification-relia...
zdover23 [Tue, 18 Oct 2022 14:56:50 +0000 (00:56 +1000)]
Merge pull request #48511 from zdover23/wip-doc-2022-10-18-radosgw-notification-reliability

doc/radosgw: refine "notification reliability"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/radosgw: refine "notification reliability" 48511/head
Zac Dover [Mon, 17 Oct 2022 14:09:34 +0000 (00:09 +1000)]
doc/radosgw: refine "notification reliability"

This commit refines the English in the "Notification Reliability"
section of the notifications.rst page (the "Bucket Notifications"
page). I have also added signposting structure.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Co-authored-by: Yuval Lifshitz <ylifshit@redhat.com>
Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years ago.github/pr-triage: update node.js to v16 48528/head
Ernesto Puerta [Tue, 18 Oct 2022 12:50:39 +0000 (14:50 +0200)]
.github/pr-triage: update node.js to v16

[Warning](https://github.com/ceph/ceph/actions/runs/3273201887):
```
Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
Please update the following actions to use Node.js 16: actions/labeler, iyu/actions-milestone
```

Signed-off-by: Ernesto Puerta <37327689+epuertat@users.noreply.github.com>
2 years agoMerge pull request #48484 from cyx1231st/wip-crimson-msgr-cleanup
Kefu Chai [Tue, 18 Oct 2022 12:36:20 +0000 (20:36 +0800)]
Merge pull request #48484 from cyx1231st/wip-crimson-msgr-cleanup

crimson/net: simplify msgr interfaces with AuthClient/Server

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2 years agoMerge pull request #48514 from ceph/wip-dashboard_gh_project-main
Ernesto Puerta [Tue, 18 Oct 2022 12:13:10 +0000 (14:13 +0200)]
Merge pull request #48514 from ceph/wip-dashboard_gh_project-main

Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #48485 from vshankar/wip-upgrade-x-o-q
Venky Shankar [Tue, 18 Oct 2022 09:05:59 +0000 (14:35 +0530)]
Merge pull request #48485 from vshankar/wip-upgrade-x-o-q

qa: fs:upgrade featureful_client test upgrades to quincy

Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
2 years agoMerge pull request #48398 from rhcs-dashboard/fix-get-rbd-stats
Avan [Tue, 18 Oct 2022 09:00:15 +0000 (14:30 +0530)]
Merge pull request #48398 from rhcs-dashboard/fix-get-rbd-stats

mgr/prometheus: avoid duplicates and deleted entries for rbd_stats_pools

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2 years agoMerge pull request #48471 from SUSE/wip-fix-57860
Ilya Dryomov [Tue, 18 Oct 2022 08:41:01 +0000 (10:41 +0200)]
Merge pull request #48471 from SUSE/wip-fix-57860

ceph.spec.in: disable system_pmdk on s390x for SUSE distros

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agodoc/dev: add explanation of how to use deduplication 46089/head
myoungwon oh [Fri, 29 Apr 2022 06:32:08 +0000 (15:32 +0900)]
doc/dev: add explanation of how to use deduplication

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2 years agocrimson/os/seastore/cbj: remove duplicate configs in cbj_header_t
myoungwon oh [Mon, 17 Oct 2022 09:52:29 +0000 (18:52 +0900)]
crimson/os/seastore/cbj: remove duplicate configs in cbj_header_t

Also, this commits remove cbj::mkfs_config_t and use device's
information.

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2 years agocrimson/os/seastore/rbm: add stat to get device info. at mkfs time
myoungwon oh [Sat, 15 Oct 2022 06:57:53 +0000 (15:57 +0900)]
crimson/os/seastore/rbm: add stat to get device info. at mkfs time

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2 years agocrimson/os/seastore/rbm: remove start and start_data_area
myoungwon oh [Fri, 14 Oct 2022 08:45:50 +0000 (17:45 +0900)]
crimson/os/seastore/rbm: remove start and start_data_area

remove start and start_data_area in rbm header and
use RBM_START_ADDRESS and journal_size instead.

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2 years agocrimson/os/seastore/rbm: remove block_size and size in RBMDevice
myoungwon oh [Fri, 14 Oct 2022 07:27:50 +0000 (16:27 +0900)]
crimson/os/seastore/rbm: remove block_size and size in RBMDevice

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2 years agocrimson/os/seastore/rbm: use device_config_t in rbm_metadata_header_t
myoungwon oh [Thu, 13 Oct 2022 12:38:15 +0000 (21:38 +0900)]
crimson/os/seastore/rbm: use device_config_t in rbm_metadata_header_t

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2 years agocrimson/os/seastore/rbm: move mkfs to RBMDevice
myoungwon oh [Wed, 12 Oct 2022 03:25:37 +0000 (12:25 +0900)]
crimson/os/seastore/rbm: move mkfs to RBMDevice

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2 years ago.github/pr-triage: switch from old to new project 48514/head
Ernesto Puerta [Mon, 17 Oct 2022 15:50:41 +0000 (17:50 +0200)]
.github/pr-triage: switch from old to new project

The old (classic) Dashboard project (https://github.com/ceph/ceph/projects/6) has been migrated to a new-style one (https://github.com/orgs/ceph/projects/2/views/1).

This also requires updating the GH Action that automatically assigned `dashboard`-labeled PRs to the Dashboard project.

Signed-off-by: Ernesto Puerta <37327689+epuertat@users.noreply.github.com>
2 years agoMerge pull request #48512 from zdover23/wip-doc-2022-10-18-radosgw-notifications...
zdover23 [Mon, 17 Oct 2022 15:49:32 +0000 (01:49 +1000)]
Merge pull request #48512 from zdover23/wip-doc-2022-10-18-radosgw-notifications-prompts

doc/radowsgw: add prompts to notifications.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agomailmap: add Pedro Gonzalez Gomez 48510/head
Pedro Gonzalez Gomez [Mon, 17 Oct 2022 13:59:36 +0000 (15:59 +0200)]
mailmap: add Pedro Gonzalez Gomez

Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
2 years agodoc/radowsgw: add prompts to notifications.rst 48512/head
Zac Dover [Mon, 17 Oct 2022 13:46:39 +0000 (23:46 +1000)]
doc/radowsgw: add prompts to notifications.rst

This PR adds unselectable prompts to doc/radosgw/notifications.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #48241 from ajarr/fix-57210
Venky Shankar [Mon, 17 Oct 2022 11:56:46 +0000 (17:26 +0530)]
Merge pull request #48241 from ajarr/fix-57210

 src/mds: increment directory inode's change attr by one

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
2 years agocrimson/osd: fix use after free error in FuturizedStoreLogReader::read 48505/head
Zhang Song [Mon, 17 Oct 2022 06:40:41 +0000 (14:40 +0800)]
crimson/osd: fix use after free error in FuturizedStoreLogReader::read

Signed-off-by: Zhang Song <zhangsong325@gmail.com>
2 years agoMerge pull request #48425 from phlogistonjohn/jjm-shell-fixups
Kefu Chai [Mon, 17 Oct 2022 03:44:14 +0000 (11:44 +0800)]
Merge pull request #48425 from phlogistonjohn/jjm-shell-fixups

build: minor build script cleanups

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2 years agoMerge pull request #48501 from zdover23/wip-doc-2022-10-17-radosgw-notifications
zdover23 [Sun, 16 Oct 2022 18:14:38 +0000 (04:14 +1000)]
Merge pull request #48501 from zdover23/wip-doc-2022-10-17-radosgw-notifications

doc/radosgw: refine notifications.rst - top part

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agodoc/radosgw: refine notifications.rst - top part 48501/head
Zac Dover [Sun, 16 Oct 2022 17:54:25 +0000 (03:54 +1000)]
doc/radosgw: refine notifications.rst - top part

This commit refines the English in the first part of the
notifications.rst page (the "Bucket Notifications" page).

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoinstall-deps: switch to C.UTF-8 locale 48425/head
John Mulligan [Mon, 10 Oct 2022 14:21:02 +0000 (10:21 -0400)]
install-deps: switch to C.UTF-8 locale

The en_US.UTF-8 locale is not always going to present on all systems.
Specifically, setting en_US.UTF-8 causes numerous warnings when running
this script on a CentOS Stream 8 container. Rather than install
additional packages to suppress the warning, use the C.UTF-8 locale.

Additionally, try to update the comment explaining the line to something
based on the commit history rather than the confusing term "vulnerable".

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2 years agoscript/run-make: convert a tab to spaces
John Mulligan [Mon, 10 Oct 2022 14:18:00 +0000 (10:18 -0400)]
script/run-make: convert a tab to spaces

There was a single line using a hard tab to indent, convert the tab
and reformat the spacing of the line near it.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2 years agoinstall-deps: for consistency, reformat tabs to spaces
John Mulligan [Mon, 10 Oct 2022 14:16:44 +0000 (10:16 -0400)]
install-deps: for consistency, reformat tabs to spaces

The majority of the install-deps.sh file was already using spaces to
indent, convert the remaining hard tabs to 8 spaces.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2 years agoinstall-deps: remove emacs modeline from script
John Mulligan [Mon, 10 Oct 2022 14:01:21 +0000 (10:01 -0400)]
install-deps: remove emacs modeline from script

The majority of the lines in this shell script uses spaces to indent,
but I *think* this modeline tells emacs to indent with tabs. In a very
near future change I'm going to make all indents use spaces. So we first
remove the emacs modeline that tells it to use the opposite.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2 years agoMerge pull request #48086 from vshankar/wip-57084
Venky Shankar [Sun, 16 Oct 2022 14:46:17 +0000 (20:16 +0530)]
Merge pull request #48086 from vshankar/wip-57084

client: use parent directory POSIX ACLs for snapshot dir

Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
2 years agoMerge pull request #48497 from liu-chunmei/fix-variable-usage-after-move
Liu-Chunmei [Sun, 16 Oct 2022 06:19:08 +0000 (23:19 -0700)]
Merge pull request #48497 from liu-chunmei/fix-variable-usage-after-move

crimson/osd: not use a moved variable

Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #48498 from zdover23/wip-doc-2022-10-16-radosgw-notifications...
zdover23 [Sun, 16 Oct 2022 03:41:41 +0000 (13:41 +1000)]
Merge pull request #48498 from zdover23/wip-doc-2022-10-16-radosgw-notifications-wording

doc/radosgw: update notifications.rst - grammar

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agodoc/radosgw: update notifications.rst - grammar 48498/head
Zac Dover [Sun, 16 Oct 2022 03:09:35 +0000 (13:09 +1000)]
doc/radosgw: update notifications.rst - grammar

This commit rewrites a sentence, as requested by
C. Mitchell here:
https://github.com/ceph/ceph/pull/48493/files#r996003812

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agocrimson/osd: not use a moved variable 48497/head
chunmei-liu [Sun, 16 Oct 2022 00:52:36 +0000 (17:52 -0700)]
crimson/osd: not use a moved variable

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
2 years agocephfs: add additional logging to track change_attr of inodes 48241/head
Ramana Raja [Wed, 21 Sep 2022 20:31:05 +0000 (16:31 -0400)]
cephfs: add additional logging to track change_attr of inodes

Signed-off-by: Ramana Raja <rraja@redhat.com>
2 years agosrc/mds: increment directory inode's change attr by one
Ramana Raja [Thu, 22 Sep 2022 15:41:50 +0000 (11:41 -0400)]
src/mds: increment directory inode's change attr by one

... whenever the mtime or ctime of the directory inode is modified.

In CephFS subvolume clones exported using NFS-Ganesha, newly created
files using `touch` were not being listed. It was identified that the
create request sent to the Ceph MDS via NFS-Ganesha's libcephfs client
modified the mtime and ctime of the parent directory, but did not modify
the change_attr of the parent directory. Since the NFS client
didn't see a modification of the change attribute in the reply, it
didn't invalidate its readdir cache. The subsequent directory `ls` was
satisfied from the NFS client's stale readdir cache.

Whenever parent directory inode's  mtime was modified in
MDCache::predirty_journal_parents(), the parent inode's change_attr
was set to its dirstat->change_attr. The parent inode's
dirstat->change_attr doesn't track changes to parent's *ctime only*
changes such as setattr, setvxattr, etc. on the parent
directory. See commit 0d441dcd6af553d11d6be6df56d577c5659904a0 for more
details. This caused the directory inode's change_attr to not be updated
when an operation to change only its ctime was followed by an operation
to change its mtime and ctime.

Fix this by making changes to MDCache::predirty_journal_parents() and
CInode::finish_scatter_gather_update() to increment the directory
inode's change_attr by one instead of setting it to its
dirstat->change_attr.

Fixes: https://tracker.ceph.com/issues/57210
Signed-off-by: Ramana Raja <rraja@redhat.com>
2 years agotest/libcephfs: enhance directory's change_attr testing
Ramana Raja [Thu, 22 Sep 2022 19:55:52 +0000 (15:55 -0400)]
test/libcephfs: enhance directory's change_attr testing

Alternate operations that only change directory's ctime
(setattr/setxattr/removexattr on directory) with those that change
directory's mtime and ctime (create/rename/remove a file within
directory). Check that directory's change_attr is updated everytime
ctime changes.

Signed-off-by: Ramana Raja <rraja@redhat.com>
2 years agoMerge pull request #48227 from phlogistonjohn/jjm-cephadm-test-nfsg
Adam King [Fri, 14 Oct 2022 20:10:57 +0000 (16:10 -0400)]
Merge pull request #48227 from phlogistonjohn/jjm-cephadm-test-nfsg

cephadm: add test coverage for NFSGanesha, HAproxy, & Keepalived classes

Reviewed-by: Adam King <adking@redhat.com>
2 years agoMerge pull request #48493 from zdover23/wip-doc-2022-10-15-radosgw-notifications...
zdover23 [Fri, 14 Oct 2022 18:02:21 +0000 (04:02 +1000)]
Merge pull request #48493 from zdover23/wip-doc-2022-10-15-radosgw-notifications-cleanup

doc/radosgw: improve grammar - notifications.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/radosgw: improve grammar - notifications.rst 48493/head
Zac Dover [Fri, 14 Oct 2022 17:48:44 +0000 (03:48 +1000)]
doc/radosgw: improve grammar - notifications.rst

This commit makes the changes suggested by C. Mitchell in
https://github.com/ceph/ceph/pull/48486.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #48422 from aravind-wdc/refactor
Kefu Chai [Fri, 14 Oct 2022 12:06:52 +0000 (20:06 +0800)]
Merge pull request #48422 from aravind-wdc/refactor

crimson/zns: refactor zone operations

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2 years agoMerge pull request #48486 from zdover23/wip-doc-2022-10-14-radosgw-push_endpoint
zdover23 [Fri, 14 Oct 2022 06:49:49 +0000 (16:49 +1000)]
Merge pull request #48486 from zdover23/wip-doc-2022-10-14-radosgw-push_endpoint

doc/radosgw: add push_endpoint for rabbitmq

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agocrimson/zns: refactor zone operation 48422/head
Aravind Ramesh [Mon, 10 Oct 2022 07:22:59 +0000 (07:22 +0000)]
crimson/zns: refactor zone operation

Moved all zone operations into one routine.

Signed-off-by: Aravind Ramesh <Aravind.Ramesh@wdc.com>
2 years agodoc/radosgw: add push_endpoint for rabbitmq 48486/head
Zac Dover [Fri, 14 Oct 2022 06:17:12 +0000 (16:17 +1000)]
doc/radosgw: add push_endpoint for rabbitmq

This commit directs users of rabbitmq to use "push_endpoint"
(with an underscore) instead of "push-endpoint" (with a hy-
phen). This commit adds a note that contains such a direct-
ive. It does not alter the examples already present in the
text.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoqa: fs:upgrade featureful_client test upgrades to quincy 48485/head
Venky Shankar [Thu, 13 Oct 2022 05:22:22 +0000 (01:22 -0400)]
qa: fs:upgrade featureful_client test upgrades to quincy

Reef cycle will not allow upgrades from octopus. However, the featureful
client tests still needs to be testes, therefore, upgrade to quincy (from
octopus) rather to the current cycle (reef).

Signed-off-by: Venky Shankar <vshankar@redhat.com>
2 years agoMerge pull request #48475 from rzarzynski/wip-crimson-resolve_oid-clone_snaps-fix...
Samuel Just [Thu, 13 Oct 2022 20:56:07 +0000 (13:56 -0700)]
Merge pull request #48475 from rzarzynski/wip-crimson-resolve_oid-clone_snaps-fix-search

crimson/osd: resolve_oid() looks in clone_snaps by requested snap ID

Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #48405 from athanatos/sjust/wip-57759
Samuel Just [Thu, 13 Oct 2022 20:01:25 +0000 (13:01 -0700)]
Merge pull request #48405 from athanatos/sjust/wip-57759

crimson: tmap support, list_snaps support, fixes for zero and cmpext

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
2 years agomgr/prometheus: avoid duplicates and deleted entries for rbd_stats_pool 48398/head
Avan Thakkar [Fri, 7 Oct 2022 20:10:57 +0000 (01:40 +0530)]
mgr/prometheus: avoid duplicates and deleted entries for rbd_stats_pool

Fixes: https://tracker.ceph.com/issues/57797
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
Avoid duplicate entries (pool[/namespace]) for rbd_stats_pools config and also avoid deleted pools.

2 years agocrimson/osd: resolve_oid() looks in clone_snaps by requested snap ID 48475/head
Radoslaw Zarzynski [Thu, 13 Oct 2022 11:22:32 +0000 (11:22 +0000)]
crimson/osd: resolve_oid() looks in clone_snaps by requested snap ID

Before the patch the method was looking for `lower_bound(oid.snap)`
from `SnapSet::clones` which leads to reading from head instead of
returning the `ENOENT` expected in `TestLibRBD.TestIOToSnapshot`.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2 years agocrimson/net: hide peer_global_id from Connection class 48484/head
Yingxin Cheng [Thu, 13 Oct 2022 09:51:52 +0000 (17:51 +0800)]
crimson/net: hide peer_global_id from Connection class

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/net: replace unnecessary ConnectionRef/AuthConnectionMetaRef
Yingxin Cheng [Thu, 13 Oct 2022 09:38:09 +0000 (17:38 +0800)]
crimson/net: replace unnecessary ConnectionRef/AuthConnectionMetaRef

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/net: drop Connection::get_messenger()
Yingxin Cheng [Thu, 13 Oct 2022 08:17:00 +0000 (16:17 +0800)]
crimson/net: drop Connection::get_messenger()

Simplify Connection interface for multi-core support.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/net: drop require_authorizer feature
Yingxin Cheng [Thu, 13 Oct 2022 08:11:54 +0000 (16:11 +0800)]
crimson/net: drop require_authorizer feature

There is no need to consider the pre-nautilus scenario.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/net: drop the unused ProtocolV1
Yingxin Cheng [Thu, 13 Oct 2022 08:03:29 +0000 (16:03 +0800)]
crimson/net: drop the unused ProtocolV1

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/os/seastore/rbm: remove bitmap related layout
myoungwon oh [Thu, 29 Sep 2022 13:15:58 +0000 (22:15 +0900)]
crimson/os/seastore/rbm: remove bitmap related layout

Before introduceing new layout for metadatas to store existing btrees
(e.g., backrefs), this commit cleans bitmap related layout up.

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2 years agoceph.spec.in: disable system_pmdk on s390x for SUSE distros 48471/head
Tim Serong [Thu, 13 Oct 2022 04:30:16 +0000 (15:30 +1100)]
ceph.spec.in: disable system_pmdk on s390x for SUSE distros

Fixes: https://tracker.ceph.com/issues/57860
Signed-off-by: Tim Serong <tserong@suse.com>