crimson/common: throw if fails to change config

simpler this way, and this allows us to have more detailed error message
so we can present it to end-user. skipping the updating step if no
changes is made is nice to have, but changing settings is not in the
critical path. so let's keep it simple.

Signed-off-by: Kefu Chai <kchai@redhat.com>

common/config: do not use magic number in set_mon_vals()

before this change, we compare the retcode of _set_val() with 1, and 0,
which are pratically magic numbers. after this change, we use
ConfigValues::set_value_result_t for non-error retcode.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #23043 from tchaikov/wip-python-cephfs-dependencies

deb,rpm: fix python-cephfs dependencies

Reviewed-by: Nathan Cutler <ncutler@suse.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #23288 from theanalyst/doc/releases/13.2.1

doc: releases: mimic 13.2.1 release notes

Reviewed-By: Sage Weil <sweil@redhat.com>

Merge pull request #23278 from b-ranto/wip-volume-selinux

ceph-volume: Restore SELinux context

Reviewed-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #23106 from noahdesu/always-on-mgr-modules2

mgr: create always on class of modules

Merge pull request #23143 from joke-lee/qa-admin-api-user-info-through-access-key

qa: add test for https://github.com/ceph/ceph/pull/22790

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #23289 from alfredodeza/wip-rm24993-2

ceph-volume ensure encoded bytes are always used

Reviewed-by: Andrew Schoen <aschoen@redhat.com>

ceph-volume: Restore SELinux context

We need to reset the root context of the file system after mounting it.
Otherwise, the SELinux policy rules will not be preserved.

Fixes: https://tracker.ceph.com/issues/24785
Signed-off-by: Boris Ranto <branto@redhat.com>

Merge pull request #23277 from zy751713126/fix_note

cls/rbd: fix method comment

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #23279 from tchaikov/wip-cmake-cleanup

cmake: cleanups

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #23283 from tchaikov/wip-cmake-fmt

cmake: bump up the required fmt version

Reviewed-by: Casey Bodley <cbodley@redhat.com>

doc: releases: mimic 13.2.1 release notes

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

ceph-volume tests.util verify as_bytes behavior

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume tests catch utf-8 encoded stdin errors

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume process use the as_bytes util for stdin

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume util create a helper for converting to bytes

Signed-off-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #22994 from tspmelo/wip-prettier-lint

mgr/dashboard: Improve prettier scripts and documentation

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #23281 from tspmelo/wip-opaque

mgr/dashboard: Fix localStorage problem in Jest

Reviewed-by: Kefu Chai <kchai@redhat.com>

cmake: bump up the required fmt version

seastar actually requires fmt 4.0.0 and up, as 3.0.2 does not offer
fmt/printf.h. see
https://github.com/fmtlib/fmt/blob/master/ChangeLog.rst#400---2017-06-27
.

Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr/dashboard: Fix localStorage problem in Jest

Latest version of Jest was showing the following error:
"SecurityError: localStorage is not available for opaque origins"

Signed-off-by: Tiago Melo <tmelo@suse.com>

cmake: extract mgr into its own CMakeLists.txt

Signed-off-by: Kefu Chai <kchai@redhat.com>

cmake: extract common,msg out of src/CMakeLists.txt

* add arch as a static library.
* add crc32 as a static library. its only dependency is libarch.

Signed-off-by: Kefu Chai <kchai@redhat.com>

cls/rbd: fix note

Signed-off-by: Zheng Yin <zhengyin@cmss.chinamobile.com>

Merge pull request #23254 from tchaikov/wip-cmake-cleanup

cmake: modularize src/perfglue

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #23255 from tchaikov/wip-seastar-yaml-cpp

seastar: lower the required yaml-cpp version to 0.5.1

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #23253 from smithfarm/wip-doc-dev-toc

doc: make it easier to reach the old dev doc TOC

Reviewed-by: Dan Mick <dan.mick@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

doc/dev/internals: drop :orphan: directive

Signed-off-by: Nathan Cutler <ncutler@suse.com>

Merge pull request #23165 from smithfarm/wip-doc-snaptrim-nit

doc/rados/operations/pg-states: fix PG state names, part 2

Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge pull request #23072 from fullerdj/wip-djf-24687

mon/OSDMonitor: Warnings for expected_num_objects

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #23268 from ceph/simple-testinfra-version

ceph-volume: do not pin the testinfra version for the simple tests

Reviewed-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: do not pin the testinfra version for the simple tests

For testinfra to work with a 2.6.x version of ansible it must use the
latest version.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

mon/OSDMonitor: Warn if missing expected_num_objects

When creating a pool on filestore, warn if the user appears to be
creating a pool to store a large number of objects but omitted the
expected_num_objects parameter. Create the pool anyway.

Fixes: http://tracker.ceph.com/issues/24687
Signed-off-by: Douglas Fuller <dfuller@redhat.com>

Merge pull request #23263 from ceph/simple-ansible-version

ceph-volume: update version of ansible to 2.6.x for simple tests

Reviewed-by: Andrew Schoen <aschoen@redhat.com>

ceph-volume: update version of ansible to 2.6.x for simple tests

ceph-ansible now requires a 2.5.x or 2.6.x version of ansible if you're
using the master branch. This updates our functional tests for the
simple subcommand to use a 2.6.x version of ansible.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

Merge pull request #23256 from trociny/wip-25114

test/pybind: fix test_rbd.TestClone.test_trash_snapshot

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

mgr/dashboard: Improve prettier scripts and documentation

Added prettier validation to the run-frontend-unittests script. This will make
sure we are always running prettier in our commits.

Added 2 new npm scripts:
- 'prettier', will run prettier formatter on all frontend files
- 'prettier:lint', will check all frontend files against prettier linter

Removed 'pretty-quick' and related scripts. Since we now have all files
prettified we can simply run prettier on them.

Remove 'tslint-eslint-rules' package and all related rules. Prettier can check
all the removed rules.

Updated HACKING.rst with some information about prettier.

Signed-off-by: Tiago Melo <tmelo@suse.com>

mgr/dashboard: Prettify all remaining files

Signed-off-by: Tiago Melo <tmelo@suse.com>

mgr/dashboard: Add reference to prettier in CodingStyle

Signed-off-by: Tiago Melo <tmelo@suse.com>

Merge pull request #23168 from tchaikov/wip-dpdk-fixes

msg/async: fix FTBFS of dpdk

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #23200 from votdev/bug_25068

mgr/dashboard: RGW is not working if an URL prefix is defined

Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>

Merge pull request #22906 from tspmelo/wip-improve-summary

mgr/dashboard: Improve SummaryService and TaskWrapperService

Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>

do_cmake: fail if cmake fails

Signed-off-by: Kefu Chai <kchai@redhat.com>

cmake: add Findfmt.cmake

the cmake config provided by fmt-devel-3.0.2 does not offer fmt::fmt target,
so we need to offer a Findfmt.cmake to do this.

Signed-off-by: Kefu Chai <kchai@redhat.com>

doc: make it easier to reach the old dev doc TOC

Signed-off-by: Nathan Cutler <ncutler@suse.com>

test/pybind: fix test_rbd.TestClone.test_trash_snapshot

Fixes: http://tracker.ceph.com/issues/25114
Signed-off-by: Mykola Golub <mgolub@suse.com>

cmake: make cpu_profiler a library target

Signed-off-by: Kefu Chai <kchai@redhat.com>

cmake: make heap_profiler a library target

Signed-off-by: Kefu Chai <kchai@redhat.com>

cmake: import allocator libraries in a better way

* instead expose the paths, it'd better to expose a library target.
* remove HAVE_LIBJEMALLOC, as it not used anywhere.

Signed-off-by: Kefu Chai <kchai@redhat.com>

seastar: lower the required yaml-cpp version to 0.5.1

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #23191 from dillaman/wip-23398

rbd: improved trash snapshot namespace handling

Reviewed-by: songweibin <song.weibin@zte.com.cn>
Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge pull request #23228 from tchaikov/wip-ceph-dencoder

test: move ceph-dencoder to src/tools

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Nathan Cutler <ncutler@suse.com>

Merge pull request #20366 from Synesis-LLC/master

doc: print pg peering in SVG instead of PNG

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #23248 from linuxbox2/rgw-fix-relaxed

rgw: fix build

Merge pull request #22758 from ricardoasmarques/wip-user-management

mgr/dashboard: Ceph dashboard user management from the UI

Reviewed-by: Ricardo Dias <rdias@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>

rgw: fix build

merge crossed with #23074

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>

Merge PR #23247 into master

* refs/pull/23247/head:
Revert "rpm,deb: chown bluestore block* links to ceph.ceph on install/upgrade"
Revert "rpm,deb: fix chown to use -h"
rpm,deb: fix chown to use -h
rpm,deb: chown bluestore block* links to ceph.ceph on install/upgrade

Reviewed-by: Nathan Cutler <ncutler@suse.com>

Revert "rpm,deb: chown bluestore block* links to ceph.ceph on install/upgrade"

This reverts commit 58cde3fd793c037beca6645cc30b2ae1c30e2af1.

This was only needed for luminous and mimic.  We are keeping these commits in master (and reverting them) only so that the cherry-pick -x references work.

Signed-off-by: Sage Weil <sage@redhat.com>

Revert "rpm,deb: fix chown to use -h"

This reverts commit 92207c76b91c26c0558688a358ade7c0d94d1b59.

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #23234 from ceph/wip-rm24784

ceph-volume: PVolumes.get() should return one PV when using name or uuid

Reviewed-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #23237 from neha-ojha/wip-whitelist-slow-requests

qa/tasks/thrashosds-health.yaml: whitelist slow requests

Merge pull request #23141 from alfredodeza/wip-rm24993

ceph-volume process.call with stdin in Python 3 fix

Reviewed-by: Andrew Schoen <aschoen@redhat.com>

Merge pull request #22533 from linuxbox2/wip-rgw-24507

rgw: add option for relaxed region enforcement

qa/tasks/thrashosds-health.yaml: whitelist slow requests

Signed-off-by: Neha Ojha <nojha@redhat.com>

Merge pull request #23074 from tchaikov/wip-seastar-config

common/config: add ConfigProxy for crimson

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

mgr/dashboard: Ceph dashboard user management

Fixes: https://tracker.ceph.com/issues/24446
Signed-off-by: Ricardo Marques <rimarques@suse.com>

mgr/dashboard: Skip tab focus on "show/hide password" button

Signed-off-by: Ricardo Marques <rimarques@suse.com>

mgr/dashboard: Add 'onCancel' output for 'ConfirmationModal'

Signed-off-by: Ricardo Marques <rimarques@suse.com>

mgr/dashboard: Add cd-select-badges component

Signed-off-by: Ricardo Marques <rimarques@suse.com>

ceph-volume: PVolumes.get() should return one PV when using name or uuid

It is possible to get duplicated pv entires from the 'pvs' lvm command.
If we're using PVolumes.get() with either pv_name or pv_uuid we can
safely return a single PVolume object. However, if we use pv_tags with
PVolumes.get() we must still raise a MultiplePVsError if many pvs
are found that have the tags, because they are not guaranteed to be the
same pv, as would be the case with pv_name or pv_uuid.

Fixes: http://tracker.ceph.com/issues/24784
Signed-off-by: Andrew Schoen <aschoen@redhat.com>

Merge PR #23232 into master

* refs/pull/23232/head:
mon: don't require CEPHX_V2 from mons until nautilus

ceph-volume tests run to log_descriptors, verifying utf-8

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume process decode to utf-8 when logging descriptors

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume tests.process ensure that stdin works on py3 and py2.7

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume process encode stdin with utf-8 to prevent bytes TypeError

Signed-off-by: Alfredo Deza <adeza@redhat.com>

mon: don't require CEPHX_V2 from mons until nautilus

The mimic 13.2.0 didn't have it.

Fixes: 3dc80e5f9b6ebf1bc1cecbd95b288005216bdbec
Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #23231 from tchaikov/wip-fio

tests/fio: fix build failures and ensure this is covered by run-make-check.sh

Reviewed-by: Igor Fedotov <ifedotov@suse.com>

tools/ceph_dencoder: use full path for including headers

Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr/dashboard: Add match validator

Signed-off-by: Ricardo Marques <rimarques@suse.com>

mgr/dashboard: Add user management API

Fixes: https://tracker.ceph.com/issues/24446
Signed-off-by: Ricardo Marques <rimarques@suse.com>

mgr/dashboard: Add asserError helper method

Signed-off-by: Ricardo Marques <rimarques@suse.com>

cmake: sync up with upstream FIO

to pick up the change to FTBFS with C++ engine.

Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr/dashboard: Improve SummaryService and TaskWrapperService

When you create a new task, and it stays running, it will be added automatically
to the summary data.

This will allows for us to deal with it more quickly, by subscribing
to the summaryService, and removes the need to pass a runningTasks array
between services.

Added 3 new methods to SummaryService.

Signed-off-by: Tiago Melo <tmelo@suse.com>

Merge pull request #22695 from a2batic/scss

mgr/dashboard: Color variables for color codes

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #23100 from adamemerson/wip-robustly-notify

rgw: Robustly notify

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>

Merge pull request #23183 from ricardoasmarques/wip-fix-url-prefix

mgr/dashboard: Fix cherrypy static content URL prefix config

Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Ricardo Dias <rdias@suse.com>

mgr/dashboard: Color variables for color codes
Assign variables to colors present in css files
Changed navigation icons padding because the notification dropdown was going out of window.
Fixes: http://tracker.ceph.com/issues/24575
Signed-off-by: Kanika Murarka <kmurarka@redhat.com>

Merge pull request #22857 from tspmelo/wip-move-test-file

mgr/dashboard: Move unit-test-helper into the new testing folder

Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>

Merge pull request #22624 from ashutosh-narkar/opa-ceph

rgw: Initial work for OPA-Ceph integration

test: move ceph-dencoder to src/tools

as it belongs to ceph-common, not ceph-test.

Signed-off-by: Kefu Chai <kchai@redhat.com>

deb,rpm: python-cephfs should depend on python-ceph-argparse

python-ceph-argparse is required by ceph_volume_client.py. hence we do
need list it as a dependency of python-cephfs.

Fixes: http://tracker.ceph.com/issues/24919
Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge PR #23220 into master

* refs/pull/23220/head:
osd/OSDMap: CRUSH_TUNABLES5 added in jewel, not kraken

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

mgr/dashboard: RGW is not working if an URL prefix is defined

Fixes https://tracker.ceph.com/issues/25068

Signed-off-by: Volker Theile <vtheile@suse.com>

Initial work for OPA-Ceph integration

Signed-off-by: Ashutosh Narkar <anarkar4387@gmail.com>

rpm: Revert "build/ops: rpm: python3-ceph-argparse only if Python 2 available"

This reverts commit c0b7aab381c7232eb81eb023c7fe5242ef6517a1.

python3-ceph-argparse is required by ceph_volume_client.py. hence we do
need it as a dependency of python3-cephfs.

Signed-off-by: Kefu Chai <kchai@redhat.com>

deb,rpm: python-cephfs should depend on python-rados

in `cephfs.pyx` we `cimport rados`, and in
LibCephFs.create_with_rados(), Rados.cluster is accesssed without GIL,
so we need to import the rados module for cephfs to ensure that it's
safe to access this attribute without GIL.

dh_python2 and dh_python3 cannot fill ${python:Depends} and
${python3:Depends} with this dependency, so we need to set it
explicitly.

Fixes: http://tracker.ceph.com/issues/24918
Signed-off-by: Kefu Chai <kchai@redhat.com>

common/config_proxy: document Config{Values,Proxy}

Signed-off-by: Kefu Chai <kchai@redhat.com>

test/crimson: update test_alien_echo.cc with f80b848d

Signed-off-by: Kefu Chai <kchai@redhat.com>

cmake: build c-ares if it's not found or not new enough

Signed-off-by: Kefu Chai <kchai@redhat.com>

c-ares: add c-ares submodule

c-ares is a C library for asynchronous DNS requests, seastar requires
c-ares 1.13.0 or up. but xenial and EPEL offer 1.10.0, so we need to
build and ship it as part of Ceph.

Signed-off-by: Kefu Chai <kchai@redhat.com>