Merge pull request #55655 from cbodley/wip-64500-reef

reef: rgw/datalog: RGWDataChangesLog::add_entry() uses null_yield

Reviewed-by: Adam Emerson <aemerson@redhat.com>

Merge pull request #55621 from cbodley/wip-64426-reef

reef: rgw/putobj: RadosWriter uses part head object for multipart parts

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #55606 from jzhu116-bloomberg/wip-64448-reef

reef: rgw: do not copy olh attributes in versioning suspended bucket

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #55289 from jzhu116-bloomberg/wip-64088-reef

reef: rgw/lc: do not add datalog/bilog for some lc actions

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #55094 from cbodley/wip-63960-reef

reef: rgw: add headers to guide cache update in 304 response

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #55061 from cbodley/wip-63940-reef

reef: radosgw-admin: 'zone set' won't overwrite existing default-placement

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #54866 from trociny/wip-63777-reef

reef: [rgw][lc][rgw_lifecycle_work_time] adjust timing if the configured end time is less than the start time

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #55931 from ceph/reef-release

v18.2.2

Reviewed-by: Laura Flores <lflores@redhat.com>

Merge pull request #56059 from rhcs-dashboard/wip-64807-reef

reef: mgr/dashboard: add snap schedule M, Y frequencies

Reviewed-by: afreen23 <NOT@FOUND>

Merge pull request #56111 from zdover23/wip-doc-2024-03-11-backport-56091-to-reef

reef: doc/cephadm: improve host-management.rst

doc/cephadm: improve host-management.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit 9fb51bb537e8bd9ea60633091acfc48a58262c3b)

Merge pull request #56073 from zdover23/wip-doc-2024-03-09-backport-56068-to-reef

reef: doc/glossary: add "Crimson" entry

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>

doc/glossary: add "Crimson" entry

Add a "Crimson" entry to the glossary.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit b31e061cc087b31a7e9e841dd21e7403a2197378)

Merge pull request #56041 from zdover23/wip-doc-2024-03-08-backport-56010-to-reef

reef: doc/start: add Slack invite link

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/start: add Slack invite link

Add a link to the ceph-storage Slack invitation page. Previously the
link went to a plain old "this is the ceph-storage Slack" page that did
not direct the reader to sign up.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit dee319e61204b2ee9ac13562c2c7075ef0f2ea4b)

Merge pull request #55999 from guits/wip-64750-reef

reef: mgr/node-proxy: handle 'None' statuses returned by RedFish

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #56057 from zdover23/wip-doc-2024-03-08-backport-56045-to-reef

reef: doc/rados: restore PGcalc tool

mgr/dashboard: add snap schedule M, Y frequencies

Added M and Y (month and year) repeat frequencies to snap schedule
create form.

Fixes: https://tracker.ceph.com/issues/64614
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
(cherry picked from commit be3bb09cca7ff8d10a36a59702bb16fd10aba84e)

doc/rados: restore PGcalc tool

Restore the PGcalc tool to the documentation suite.

Co-authored-by: Josh Durgin <jdurgin@redhat.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit eaaf72253123de1a66f163f651046817faa97a1a)

Merge pull request #56012 from zdover23/wip-doc-2024-03-07-backport-55995-to-reef

reef: doc/architecture: correct typo

Merge pull request #55640 from vshankar/wip-64485-reef

reef: mds,cephfs_mirror: add labelled per-client and replication metrics

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #55395 from dparmar18/wip-63691-reef

reef: mgr/(object_format && nfs/export): enhance nfs export update failure response

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #55302 from neesingh-rh/wip-64144-reef

reef: qa: fix rank_asok() to handle errors from asok commands

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #54538 from aaSharma14/wip-63571-reef

reef: mgr/dashboard: Show the OSDs Out and Down panels as red whenever an OSD is in Out or Down state in Ceph Cluster grafana dashboard

Reviewed-by: Ejdesgaard <NOT@FOUND>
Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>

Merge pull request #55993 from rhcs-dashboard/wip-64732-reef

reef: mgr/dashboard: fixed cephfs mount command

Reviewed-by: Nizamudeen A <nia@redhat.com>

doc/architecture: correct typo

s/client/clients/ where necessary, and add a link to the glossary.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit ae08855cf870173dce2a47a28f3bbb22e7ae0ca2)

Merge pull request #56002 from zdover23/wip-doc-2024-03-07-backport-55982-to-reef

reef: doc/dev: edit teuthology workflow

Merge pull request #55836 from vshankar/wip-reef-raw-cluster-cmd

reef: use raw_cluster_cmd instead of run_ceph_cmd

Reviewed-by: Rishabh Dave <ridave@redhat.com>

Merge pull request #55943 from vshankar/wip-64705-reef

reef: qa: remove error string checks and check w/ return value

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #55300 from neesingh-rh/wip-64098-reef

reef: src/mount: kernel mount command returning misleading error message

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #54467 from lxbsz/wip-63262

reef: mds: fix issuing redundant reintegrate/migrate_stray requests

Reviewed-by: Venky Shankar <vshankar@redhat.com>

doc/dev: edit teuthology workflow

Improve a couple of sentences in
doc/dev/developer_guide_testing_integration_tests/tests-integration-testing-teutology-workflow.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 51796e80f35da8ca13b72f31eeafefd4c1e40773)

mgr/node-proxy: handle 'None' statuses returned by RedFish

Looks like RedFish might return 'None' values for some attributes.

for instance:

```
[root@ceph-node-01 ~]# curl -s -k -X GET https://169.254.1.1/redfish/v1/Systems/System.Embedded.1/Storage/AHCI.SL.6-1/Drives/Disk.Direct.0-0:AHCI.SL.6-1 -H "X-Auth-Token: 3264251c28191fa5e7c9ebec49ef90fc"  | jq .Status
{
  "Health": "OK",
  "HealthRollup": "OK",
  "State": "Enabled"
}
[root@ceph-node-01 ~]# curl -s -k -X GET https://169.254.1.1/redfish/v1/Systems/System.Embedded.1/Storage/NonRAID.Slot.2-1/Drives/Disk.Bay.0:Enclosure.Internal.0-1:NonRAID.Slot.2-1 -H "X-Auth-Token: 3264251c28191fa5e7c9ebec49ef90fc" | jq .Status
{
  "Health": null,
  "HealthRollup": null,
  "State": "Enabled"
}
[root@ceph-node-01 ~]#
```

Although this seems to be a bug from RedFish, we need to handle
the case when it happens otherwise it makes the mgr orchestrator module
throw an error.

The idea here is to create a new status "unknown" when we can't fetch the
real status of a component.

Fixes: https://tracker.ceph.com/issues/64712
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit cc279a3dd23d9219e508b80512f363a4ae577392)

mgr/dashboard: fixed cephfs mount command

Fixes: https://tracker.ceph.com/issues/64716
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
(cherry picked from commit eeb09b19581d353fb68f86bb4c2871f026a35c29)

qa: remove error string checks and check w/ return value

I ran into this failure once #54972 was merged. The test is validating
the error string returned due to the failed mount. There aren't any
return value checks - which is a _more_ important check. Generic error
string checks will fail once a (error) string is changed (typo, etc..).

Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 7cd17931b1690029d182954b0382acc45b9ccb2b)

Merge pull request #55936 from zdover23/wip-doc-2024-03-05-backport-55918-to-reef

reef: doc/rados: link to pg setting commands

Merge pull request #55933 from zdover23/wip-doc-2024-03-05-backport-55924-to-reef

reef: doc/architecture: remove pleonasm

doc/rados: link to pg setting commands

Link to the instructions for manually setting the number of PGs per
pool, from the mention of placement groups. These instructions are
included here in response to a request from Ronen Friedman on the
occasion of the removal of links to the PGcalc (see
https://github.com/ceph/ceph/pull/55899#pullrequestreview-1912940118).

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 9da81b87ca161370c869b49f5d4e6b50edd54a0e)

doc/architecture: remove pleonasm

Remove the word "detailed" in a sentence immediately following a
sentence containing the word "detail".

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 7791509741d8c21e273a46374a087dcca53a2816)

18.2.2

Signed-off-by: Ceph Release Team <ceph-maintainers@ceph.io>

Merge pull request #55709 from mcv21/wip-64509-reef

reef: debian/*.postinst: add adduser as a dependency and specify --home when adduser

Reviewed-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #55901 from zdover23/wip-doc-2024-03-03-backport-55899-to-reef

reef: doc/rados: remove PGcalc from docs

doc/rados: remove PGcalc from docs

Remove mention of the "PG calc" tool from the documentation. I have
removed all mention of this in one fell swoop to help posterity restore
mention of this tool if we decide we need to do so.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit ccb851d2a431647124754e1252df66ed11d0e900)

Merge pull request #54879 from batrick/wip-63796-reef

reef: pybind/mgr/devicehealth: replace SMART data if exists for same DATETIME

Reviewed-by: Laura Flores <lflores@redhat.com>

Merge pull request #55880 from zdover23/wip-doc-2024-03-02-backport-55869-to-reef

reef: doc/install: add manual RADOSGW install procedure

Merge pull request #54122 from batrick/wip-63277-reef

reef: cmake: use or turn off liburing for rocksdb

Reviewed-by: Laura Flores <lflores@redhat.com>

doc/install: add manual RADOSGW install procedure

Add a manual RADOSGW installation procedure to
doc/install/manual-deployment.rst. This procedure was developed by Janne
Johansson and reported to the ceph-users mailing list on 29 Jan 2024
here: https://lists.ceph.io/hyperkitty/list/ceph-users@ceph.io/message/LB3YRIKAPOHXYCW7MKLVUJPYWYRQVARU/

Co-authored-by: Janne Johansson <icepic.dz@gmail.com>
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 565bc9503838906995fa48f59debcd2843775b18)

Merge pull request #55827 from afreen23/wip-64640-reef

reef: mgr/dashboard: fix roles page for roles without policies

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #55852 from zdover23/wip-doc-2024-03-01-backport-55834-to-reef

reef: doc/dev: edit internals.rst

doc/dev: edit internals.rst

Edit doc/dev/internals.rst. Make a few sentences pithier.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit e16ab1df72c3640db907e377da7ca97ce3eaa26e)

Merge pull request #55849 from zdover23/wip-doc-2024-03-01-backport-55835-to-reef

reef: doc/glossary: improve "MDS" entry

doc/glossary: improve "MDS" entry

Improve the entry for "MDS" in doc/glossary.rst by linking to the
"ceph-mds" man page and mentioning the relationship between clients and
MDS (or MDSes).

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 2c6983d8b4e841f2bfbc4e4f82bb0e41e10aec7e)

Merge pull request #55712 from rzarzynski/wip-64406-reef

reef: src/osd/OSDMap.cc: Fix encoder to produce same bytestream

Reviewed-by: Kamoltat (Junior) Sirivadhna <ksirivad@redhat.com>

Merge PR #55669 into reef

* refs/pull/55669/head:
qa: test fuse/kclient for mds upgrade seq
qa: ignore OSD_DOWN during cephadm upgrades
qa: ignore warning "Replacing daemon"
qa: ignore MDS_INSUFFICIENT_STANDBY
qa: remove ignorelist error parenthesis
mds: update comment on kclient decoding of MDSMap
qa: do upgrades from quincy and older reef minor releases
mds: reverse MDSMap encoding of max_xattr_size/bal_rank_mask

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #55811 from rhcs-dashboard/wip-64610-reef

reef: mgr/dashboard: fix subvolume group edit

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>

reef: use raw_cluster_cmd instead of run_ceph_cmd

Due to https://github.com/ceph/ceph/pull/50569 not being backported

Signed-off-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #55786 from rhcs-dashboard/wip-64595-reef

reef: mgr/dashboard: fix volume creation with multiple hosts

Reviewed-by: Nizamudeen A <nia@redhat.com>

mgr/dashboard: fix roles page for roles without policies

If there is no permission policies attached to a role, it fails the
UI with an exception.

Fixes: https://tracker.ceph.com/issues/64588
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 5f3f31921c9f3ed909a94f287bfd4cc3f0987649)

Merge pull request #55665 from idryomov/wip-64423-reef

reef: librbd: fix split() for SparseExtent and SparseBufferlistExtent

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>

Merge pull request #55617 from trociny/wip-64464-reef

reef: tools/rbd: make 'children' command support --image-id

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>

debian/cephadm.postinst: stop using adduser --gecos

--gecos option of adduser is deprecated in debian/bookworm, and
will be removed in debian/trixie,
see https://manpages.debian.org/bookworm/adduser/adduser.8.en.html.
so to be future-proof, let's switch to `usermod --comment`. please
note, since we still need to support ubuntu/jammy which is used in
our CI, and `adduser` shipped by ubuntu/jammy does not support
`--comment` yet, so we cannot use this option.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit e74ec0b27dfb480a2951f85bf00072e95d944772)
(cherry picked from commit 5a236031951a2a6f8b358a25b9238dd1e8281f10)

debian/cephadm.postinst: replace tab with spaces

for better readability, and to be more consistent with the rest
of this file, and other .postinst scripts of this project.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit 013eebf5357666cf2509a37eecf69ef4ac349321)
(cherry picked from commit 7cff98556ecc407da17d62ca26b6989d1a2837d2)

debian/cephadm.postinst: specify --home when adduser

quote from adduser/NEWS.Debian.gz:

>  System user home defaults to /nonexistent if --home is not specified.
>  Packages that call adduser to create system accounts should explicitly
>  specify a location for /home (see Lintian check
>  maintainer-script-lacks-home-in-adduser).

so let's follow this change in adduser. otherwise "cephadm"
would have a $HOME at `/nonexistent`.

Fixes: https://tracker.ceph.com/issues/64069
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit 90bc0369243077c2aaf67f0de2bab5810b217f4e)
(cherry picked from commit 81c71165defaeedaf127263b7e615938df493b8e)

debian/cephadm.postinst: wrap command line lines which is too long

for better readability.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit c517d0b0e95b20cd9bd979405d0248b9419e5c85)
(cherry picked from commit 044bb8a92514c66c24393e184db3b70298c62cb3)

debian/ceph-common.postinst: set user directory using adduser

now that adduser allows us to set its home directory, we can do
this using adduser instead of using usermod. this change also
silences the warning from lintian
"maintainer-script-lacks-home-in-adduser". lintian complains if
`adduser --system` is called without passing `--home` option.

also, take this opportunity to s/-c/--comment/ in the command line
of `usermod`, for better readability.

Fixes: https://tracker.ceph.com/issues/64069
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit a1a857698cad4f2feeea0b56fd781350e44078b7)
(cherry picked from commit 776a089b09c70ee45f2c84eec05279d6826abf15)

debian/control: add adduser to Depends of cephadm and ceph-common

in `debian/ceph-common.postinst` and `debian/cephadm.postinst`, we
use `adduser --system` to create the system user when configuring
the corresponding package.

before this change, the dependency is not listed in the runtime
`Depends` section of ceph-common and cephadm.

in this change, the dependency is added. this is also suggested
by Securing Debian Manual, see
https://www.debian.org/doc/manuals/securing-debian-manual/bpp-lower-privs.en.html

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit 2a30ddccd04b204821f0496856847e8ffc07835d)
(cherry picked from commit eeaaeeadcdff5fff0732d6f4e89b9d6f7b626c2f)

backport mgr/prometheus: fix orch check to prevent Prometheus crash
https://tracker.ceph.com/issues/64339

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit de7da4a77ddbd33bbe050c52c4c5bbbb6ab1919f)

src/osd/OSDMap.cc: Fix encoder to produce same bytestream

Fixes: https://tracker.ceph.com/issues/63389
Signed-off-by: Kamoltat <ksirivad@redhat.com>
(cherry picked from commit a3bdffb4e0366af8288258539f17bafeae17e3c4)
(cherry picked from commit e9880fefda543d9d785dba89fe90c5e5074bb62a)

Merge pull request #55714 from ceph/wip-yuriw-p2p-reef

qa/tests: added the initial reef-p2p suite

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>

mgr/dashboard: fix subvolume group edit

Fixes: https://tracker.ceph.com/issues/64487
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
(cherry picked from commit 8aaa0bca47fa49073e797ee427bcec282ef1adbe)

Merge pull request #55799 from zdover23/wip-doc-2024-02-28-backport-55782-to-reef

reef: doc/rados: add "change public network" procedure

doc/rados: add "change public network" procedure

Add a procedure to /doc/rados/operations/add-or-rm-mons.rst that
explains how to change the public_network in a Ceph cluster deployed
with cephadm. This procedure was developed by Eugen Block, and can be
seen in its original form here:
https://heiterbiswolkig.blogs.nde.ag/2024/02/22/cephadm-change-public-network/

Co-authored-by: Eugen Block <eblock@nde.ag>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 0b6739a4aa2dd931d97b8af9b3a352969f8767c2)

qa/tests: added the initial reef-p2p suite

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>

mgr/dashboard: fix volume creation with multiple hosts

Fixes: https://tracker.ceph.com/issues/64559
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
(cherry picked from commit 4313f9a59c676067ca23242808c8e87068d0d953)

Merge pull request #55358 from ljflores/wip-revert-pr-55263

reef: Revert "doc/rados/operations: document `ceph balancer status detail`"

Merge pull request #55754 from zdover23/wip-doc-2024-02-26-backport-55683-to-reef

reef: doc/man/8/mount.ceph.rst: add more mount options

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>

Merge pull request #55704 from afreen23/wip-64528-reef

reef: mgr/dashboard: Handle errors for /api/osd/settings

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

doc/man/8/mount.ceph.rst: add more mount options

Fixes: https://tracker.ceph.com/issues/62837
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit d5639cc670d248da7c84e6f2eaf73ce40bd93db4)

Merge pull request #55749 from zdover23/wip-doc-2024-02-26-backport-55739-to-reef

reef: doc/glossary: Add "OMAP" to glossary

doc/glossary: Add "OMAP" to glossary

Add an entry for "OMAP" to the glossary. This commit represents only the
first improvement to the documentation of OMAP in the Ceph docs suite.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 1d8baa1d4c3583f4a8dc0f46d81f198a3d027e4d)

Merge pull request #55737 from zdover23/wip-doc-2024-02-25-backport-55731-to-reef

reef: doc/dev: fix spelling in crimson.rst

doc/dev: fix spelling in crimson.rst

Repair a confusing sentence in doc/dev/crimson.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit dfdb5e124a19e0c5ce1e7ba47e574e0504e7091f)

doc: Revert "doc/rados/operations: document `ceph balancer status detail`"

This reverts commit fdf274e25ab100bec038011b794dfd0bfd4f8667.

Signed-off-by: Laura Flores <lflores@ibm.com>

Merge pull request #55732 from zdover23/wip-doc-2024-02-24-backport-55729-to-reef

reef: doc/rbd: repair ordered list

doc/rbd: repair ordered list

Fix the numbering in an ordered list. The numbering was thrown off
because a ".. prompt" directive was improperly indented (it wasn't
indented at all).

See https://github.com/ceph/ceph/pull/55540#discussion_r1500051264

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 6df12da2cd0946092fa49f8dbb7661e4487c3c22)

Merge pull request #55730 from zdover23/wip-doc-2024-02-24-backport-55699-to-reef

reef: doc/crimson: cleanup duplicate seastore description

doc/crimson: cleanup duplicate seastore description

Signed-off-by: Rongqi Sun <sunrongqi@huawei.com>
(cherry picked from commit 8d766c57173cf6bdea0d8fcfa8fa3c1b61fd10ef)

Merge pull request #55724 from zdover23/wip-doc-2024-02-23-backport-55540-to-reef

reef: doc: Add NVMe-oF gateway documentation

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #55689 from mcv21/wip-63529-reef

Reef: mgr/dashboard: Simplify authentication protocol

Reviewed-by: Daniel Persson <mailto.woden@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

doc: Add NVMe-oF gateway documentation

- Add nvmeof-initiator-esx.rst
- Add nvmeof-initiator-linux.rst
- Add nvmeof-initiators.rst
- Add nvmeof-overview.rst
- Add nvmeof-requirements.rst
- Add nvmeof-target-configure.rst
- Add links to rbd-integrations.rst

Co-authored-by: Ilya Dryomov <idryomov@redhat.com>
Co-authored-by: Zac Dover <zac.dover@proton.me>
Signed-off-by: Orit Wasserman <owasserm@ibm.com>
(cherry picked from commit 9f86c35a0d308c6ff24d3a033f5314ec86bf896b)

Merge pull request #55706 from rkachach/fix_issue_64520

reef: backport rook/mgr recent changes

src/osd/OSDMap.cc: Fix encoder to produce same bytestream

Fixes: https://tracker.ceph.com/issues/63389
Signed-off-by: Kamoltat <ksirivad@redhat.com>
(cherry picked from commit a3bdffb4e0366af8288258539f17bafeae17e3c4)

debian/cephadm.postinst: stop using adduser --gecos

--gecos option of adduser is deprecated in debian/bookworm, and
will be removed in debian/trixie,
see https://manpages.debian.org/bookworm/adduser/adduser.8.en.html.
so to be future-proof, let's switch to `usermod --comment`. please
note, since we still need to support ubuntu/jammy which is used in
our CI, and `adduser` shipped by ubuntu/jammy does not support
`--comment` yet, so we cannot use this option.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit e74ec0b27dfb480a2951f85bf00072e95d944772)

debian/cephadm.postinst: replace tab with spaces

for better readability, and to be more consistent with the rest
of this file, and other .postinst scripts of this project.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit 013eebf5357666cf2509a37eecf69ef4ac349321)

debian/cephadm.postinst: specify --home when adduser

quote from adduser/NEWS.Debian.gz:

>  System user home defaults to /nonexistent if --home is not specified.
>  Packages that call adduser to create system accounts should explicitly
>  specify a location for /home (see Lintian check
>  maintainer-script-lacks-home-in-adduser).

so let's follow this change in adduser. otherwise "cephadm"
would have a $HOME at `/nonexistent`.

Fixes: https://tracker.ceph.com/issues/64069
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit 90bc0369243077c2aaf67f0de2bab5810b217f4e)

debian/cephadm.postinst: wrap command line lines which is too long

for better readability.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit c517d0b0e95b20cd9bd979405d0248b9419e5c85)

debian/ceph-common.postinst: set user directory using adduser

now that adduser allows us to set its home directory, we can do
this using adduser instead of using usermod. this change also
silences the warning from lintian
"maintainer-script-lacks-home-in-adduser". lintian complains if
`adduser --system` is called without passing `--home` option.

also, take this opportunity to s/-c/--comment/ in the command line
of `usermod`, for better readability.

Fixes: https://tracker.ceph.com/issues/64069
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit a1a857698cad4f2feeea0b56fd781350e44078b7)

debian/control: add adduser to Depends of cephadm and ceph-common

in `debian/ceph-common.postinst` and `debian/cephadm.postinst`, we
use `adduser --system` to create the system user when configuring
the corresponding package.

before this change, the dependency is not listed in the runtime
`Depends` section of ceph-common and cephadm.

in this change, the dependency is added. this is also suggested
by Securing Debian Manual, see
https://www.debian.org/doc/manuals/securing-debian-manual/bpp-lower-privs.en.html

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit 2a30ddccd04b204821f0496856847e8ffc07835d)

mgr/rook: removing HostPattern references

Signed-off-by: Redouane Kachach <rkachach@redhat.com>

mgr/dashboard: Updated test dependencies

Seemed that the test dependencies was separated in two different requirements files
one for the testing and one for linting. Added the JWT dependency in the linting file
as well.

Signed-off-by: Daniel Persson <mailto.woden@gmail.com>
(cherry picked from commit 06765e648acb1676d5d563c631b8d8fc08b5323c)