]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Zac Dover [Wed, 25 Jun 2025 08:40:11 +0000 (18:40 +1000)]
Merge pull request #64163 from tchaikov/wip-doc-inline-literal
doc: Fix unterminated inline literal in ceph-conf.rst
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Zac Dover <zac.dover@proton.me>
Matan Breizman [Wed, 25 Jun 2025 07:36:59 +0000 (10:36 +0300)]
Merge pull request #63673 from Matan-B/wip-matanb-crimson-signals-aborts
crimson/common/fatal_signal: Rework signals
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Wed, 25 Jun 2025 07:07:10 +0000 (15:07 +0800)]
Merge pull request #63972 from cyx1231st/wip-seastore-refine-extent-states-p2
crimson/os/seastore: update extent states from pending to stable upon prepare_record()
Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>
Venky Shankar [Wed, 25 Jun 2025 06:39:39 +0000 (12:09 +0530)]
Merge PR #59435 into main
* refs/pull/59435/head:
mgr/volumes: Fix json.loads for test on mon caps
mgr/volumes: Add test for mon caps if auth key has remaining mds/osd caps
mgr/volumes: Keep mon caps if auth key has remaining mds/osd caps
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Zac Dover [Wed, 25 Jun 2025 05:11:42 +0000 (15:11 +1000)]
Merge pull request #64160 from tchaikov/wip-doc-dev-config
doc/dev/config: Document how to use :confval: directive for config options
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Zac Dover <zac.dover@proton.me>
Kefu Chai [Wed, 25 Jun 2025 03:34:50 +0000 (11:34 +0800)]
doc: Fix unterminated inline literal in ceph-conf.rst
Add missing space after closing backticks to properly terminate inline literal.
Sphinx was generating a warning due to an unterminated inline literal
string:
```
/home/kefu/dev/ceph/doc/rados/configuration/ceph-conf.rst:320: WARNING: Inline literal start-string without end-string.
```
This fix ensures the inline literal is properly closed and eliminates the
build warning.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Wed, 25 Jun 2025 03:50:24 +0000 (11:50 +0800)]
doc/dev/config: Document how to use :confval: directive for config options
Add comprehensive guide for documenting configuration options using the
:confval: directive, including naming conventions and cross-referencing.
Previously, the documentation lacked guidance on using the :confval:
directive and the important distinction between regular config options
and mgr module options (which require the mgr/<module>/ namespace
prefix). This change provides detailed examples and best practices for
properly documenting and referencing both types of configuration options.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Patrick Donnelly [Wed, 25 Jun 2025 01:06:14 +0000 (21:06 -0400)]
Merge PR #64153 into main
* refs/pull/64153/head:
Revert "Merge pull request #64111 from zdover23/wip-doc-2025-06-23-tr71796-rados-ops-balancer"
Reviewed-by: Zac Dover <zac.dover@gmail.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Patrick Donnelly [Tue, 24 Jun 2025 18:52:09 +0000 (14:52 -0400)]
Revert "Merge pull request #64111 from zdover23/wip-doc-2025-06-23-tr71796-rados-ops-balancer"
This reverts commit
f2b7c0465ea2727537ea58b44b2f17c6dda7d556 , reversing
changes made to
e5868d88dd3ada55a7cacd7a5faec5aa9bc96aff .
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
Zac Dover [Tue, 24 Jun 2025 18:51:11 +0000 (04:51 +1000)]
Merge pull request #64107 from zdover23/wip-doc-2025-06-23-tr71789-radosgw-notifications
doc/radosgw: remove "pubsub_event_triggered"
Reviewed-by: Yuval Lifshitz <ylifshit@ibm.com>
Ilya Dryomov [Tue, 24 Jun 2025 18:37:34 +0000 (20:37 +0200)]
Merge pull request #64137 from tchaikov/wip-rbd-with-krbd
rbd: fix unused function warning when WITH_KRBD is disabled
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Zac Dover [Mon, 23 Jun 2025 08:07:40 +0000 (18:07 +1000)]
doc/radosgw: remove "pubsub_event_triggered"
Remove "pubsub_event_triggered" from the list of "Notification
Performance Statistics". It is obsolete.
Fixes: https://tracker.ceph.com/issues/71789
Signed-off-by: Zac Dover <zac.dover@proton.me>
Zac Dover [Tue, 24 Jun 2025 18:09:16 +0000 (04:09 +1000)]
Merge pull request #64111 from zdover23/wip-doc-2025-06-23-tr71796-rados-ops-balancer
doc/rados: clarify "upmap_max_deviation"
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Tue, 24 Jun 2025 17:56:49 +0000 (03:56 +1000)]
Merge pull request #64105 from zdover23/wip-doc-2025-06-23-tr71791-radosgw-notifications
doc/radosgw: add "persistent_topic_len"
Reviewed-by: Yuval Lifshitz <ylifshit@ibm.com>
Zac Dover [Mon, 23 Jun 2025 08:26:09 +0000 (18:26 +1000)]
doc/radosgw: add "persistent_topic_len"
Add the labeled counter "persistent_topic_len" to the list of
"Notification Performance Statistics" in doc/radosgw/notifications.rst.
Fixes: https://tracker.ceph.com/issues/71791
Signed-off-by: Zac Dover <zac.dover@proton.me>
Zac Dover [Tue, 24 Jun 2025 15:42:10 +0000 (01:42 +1000)]
Merge pull request #64106 from zdover23/wip-doc-2025-06-23-tr71792-radosgw-notifications
doc/radosgw: add "persistent_topic_size"
Reviewed-by: Yuval Lifshitz <ylifshit@ibm.com>
Kefu Chai [Tue, 24 Jun 2025 14:38:13 +0000 (22:38 +0800)]
rbd: fix unused function warning when WITH_KRBD is disabled
Guard print_error_description() and get_unsupported_features() with
`#ifdef WITH_KRBD` to prevent compiler warnings when KRBD support is
not enabled.
These functions are only called by do_kernel_map(), which is itself
conditionally compiled. When WITH_KRBD is not defined, the compiler
generates unused function warnings for these helper functions.
Fixes warning:
```
/home/kefu/dev/ceph/src/tools/rbd/action/Kernel.cc:305:13: warning: ‘void rbd::action::kernel::print_error_description(const char*, const char*, const char*, const char*, int)’ defined but not used [-Wunused-function]
305 | static void print_error_description(const char *poolname,
| ^~~~~~~~~~~~~~~~~~~~~~~
```
this silences the warning.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Venky Shankar [Tue, 24 Jun 2025 11:08:48 +0000 (16:38 +0530)]
Merge PR #62675 into main
* refs/pull/62675/head:
test/mds: Fix catch by value
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
Alex Ainscow [Tue, 24 Jun 2025 10:04:15 +0000 (11:04 +0100)]
Merge pull request #64063 from tchaikov/wip-ec-cache-refactor
osd/ECExtentCache: cleanup and optimization
Pedro Gonzalez Gomez [Tue, 24 Jun 2025 09:55:28 +0000 (11:55 +0200)]
Merge pull request #60797 from rhcs-dashboard/carbon-icons-subtask
mgr/dashboard: Carbonize Icons for Modules (Block, Object, File, Observability, Administration)
Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Pedro Gonzalez <pegonzal@ibm.com>
afreen23 [Tue, 24 Jun 2025 08:30:43 +0000 (14:00 +0530)]
Merge pull request #63963 from afreen23/wip-label-hosts
mgr/dashboard: Allow host with labels in listener form
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
afreen23 [Tue, 24 Jun 2025 08:30:12 +0000 (14:00 +0530)]
Merge pull request #63961 from afreen23/wip-force-listener
mgr/dashboard: Add --force flag for listeners
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Zac Dover [Tue, 24 Jun 2025 07:07:12 +0000 (17:07 +1000)]
Merge pull request #64088 from InstelligenceIO/patch-2
[Docs]: Corrected spelling mistake
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Mon, 23 Jun 2025 12:50:03 +0000 (22:50 +1000)]
doc/rados: clarify "upmap_max_deviation"
Clarify the threshold set by "upmap_max_deviation" and add the
information about this configurable that is currently in
src/pybind/mgr/balancer/module.py to src/common/options/global.yaml.in,
so that it will be accessible by means of ".. confval::" declarations.
Fixes: https://tracker.ceph.com/issues/71796
Signed-off-by: Zac Dover <zac.dover@proton.me>
Zac Dover [Tue, 24 Jun 2025 04:46:11 +0000 (14:46 +1000)]
Merge pull request #64104 from zdover23/wip-doc-2025-06-23-tr71790-radosgw-notifications
doc/radosgw: remove "pubsub_event_lost"
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Dan Mick [Mon, 23 Jun 2025 16:42:44 +0000 (09:42 -0700)]
Merge pull request #64072 from phlogistonjohn/jjm-wip-el10
script/build-with-container.: fixes and improvments towards el10
SrinivasaBharathKanta [Mon, 23 Jun 2025 16:12:40 +0000 (21:42 +0530)]
Merge pull request #63883 from leonidc/fix_upgrade_gw_lost
nvmeofgw: fix sending acks during upgrade
Kefu Chai [Mon, 23 Jun 2025 14:07:25 +0000 (22:07 +0800)]
Merge pull request #63796 from tchaikov/wip-memstore-silence-warning
cmake: suppress -Wmaybe-uninitialized warning in memstore PageSet
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Zac Dover [Mon, 23 Jun 2025 14:02:25 +0000 (00:02 +1000)]
Merge pull request #64075 from nh2/docs-balancer-variable-name
doc/rados/operations: Actually mention `upmap_max_deviation` setting name
Reviewed-by: Zac Dover <zac.dover@proton.me>
Zac Dover [Mon, 23 Jun 2025 08:35:05 +0000 (18:35 +1000)]
doc/radosgw: add "persistent_topic_size"
Add "persistent_topic_size" to the list of "Notification Performance
Statistics" in doc/radosgw/notifications.rst.
Fixes: https://tracker.ceph.com/issues/71792
Signed-off-by: Zac Dover <zac.dover@proton.me>
Casey Bodley [Mon, 23 Jun 2025 13:12:33 +0000 (09:12 -0400)]
Merge pull request #64071 from tchaikov/wip-static_ptr-alignas
common/static_ptr: pass an integer to alignas to fix GCC-11 build fai…
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Zac Dover [Mon, 23 Jun 2025 13:02:42 +0000 (23:02 +1000)]
Merge pull request #64103 from zdover23/wip-doc-2025-06-23-tr71793-radosgw-notifications
doc/radosgw: improve "pubsub_push_pending" info
Reviewed-by: Yuval Lifshitz <ylifshit@ibm.com>
NitzanMordhai [Mon, 23 Jun 2025 12:20:14 +0000 (15:20 +0300)]
Merge pull request #63398 from NitzanMordhai/wip-nitzan-calc-pool-availability-valgrind-invalid-read
src/mon/MgrStatMonitor: fix invalid iterator increment in calc_pool_availability()
Niklas Hambüchen [Sat, 21 Jun 2025 17:53:34 +0000 (19:53 +0200)]
doc/rados/operations: Actually mention `upmap_max_deviation` setting name
Signed-off-by: Niklas Hambüchen <mail@nh2.me>
Stellios Williams [Mon, 23 Jun 2025 10:54:31 +0000 (20:54 +1000)]
doc: Fixed a spelling error.
Corrected communicte to communicate
Signed-off-by: Instelligence.io <github@instelligence.io>
NitzanMordhai [Mon, 23 Jun 2025 09:31:02 +0000 (12:31 +0300)]
Merge pull request #63425 from NitzanMordhai/wip-nitzan-osdmap-incremental-process-idle
objecter: request OSDMap after idle ticks
NitzanMordhai [Mon, 23 Jun 2025 09:30:34 +0000 (12:30 +0300)]
Merge pull request #62916 from mohit84/tick_without_osd_crash
osd: Access/Modify epoch maps under mutex in OSDSuperblock class
Zac Dover [Mon, 23 Jun 2025 08:47:05 +0000 (18:47 +1000)]
doc/radosgw: improve "pubsub_push_pending" info
Explain in greater detail what the counter "pubsub_push_pending" counts.
Fixes: https://tracker.ceph.com/issues/71793
Signed-off-by: Zac Dover <zac.dover@proton.me>
Zac Dover [Mon, 23 Jun 2025 08:18:07 +0000 (18:18 +1000)]
doc/radosgw: remove "pubsub_event_lost"
Remove "pubsub_event_lost" from the list of "Notification Performance
Statistics" in doc/radosgw/notifications.rst. "pubsub_event_lost" is now
obsolete.
Fixes: https://tracker.ceph.com/issues/71790
Signed-off-by: Zac Dover <zac.dover@proton.me>
Jon Bailey [Mon, 23 Jun 2025 08:17:41 +0000 (09:17 +0100)]
Merge pull request #64046 from JonBailey1993/ceph_test_rados_io_sequence_error_readability
test/osd: Improve readability of errors in ceph_test_rados_io_sequence
Reviewed-by: Bill Scales <bill_scales@uk.ibm.com>
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Enrico Bocchi [Tue, 5 Nov 2024 08:26:04 +0000 (09:26 +0100)]
mgr/volumes: Fix json.loads for test on mon caps
Signed-off-by: Enrico Bocchi <enrico.bocchi@cern.ch>
Enrico Bocchi [Wed, 16 Oct 2024 09:40:26 +0000 (11:40 +0200)]
mgr/volumes: Add test for mon caps if auth key has remaining mds/osd caps
Signed-off-by: Enrico Bocchi <enrico.bocchi@cern.ch>
Enrico Bocchi [Mon, 26 Aug 2024 11:30:02 +0000 (13:30 +0200)]
mgr/volumes: Keep mon caps if auth key has remaining mds/osd caps
Signed-off-by: Enrico Bocchi <enrico.bocchi@cern.ch>
Zac Dover [Mon, 23 Jun 2025 07:01:50 +0000 (17:01 +1000)]
Merge pull request #64026 from zdover23/wip-doc-2025-06-19-tr-68619-radosgw-s3select
doc/radosgw: update aws specification link
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Prachi Goel [Fri, 22 Nov 2024 07:15:44 +0000 (12:45 +0530)]
mgr/dashboard: Carbonize Icons for Modules (Block, Object, File, Observability, Administration)
Fixes: https://tracker.ceph.com/issues/69017
Signed-off-by: Prachi <prgoel@redhat.com>
Modules Changed for this:
1. Block( mirroring, NVMe, ICSI, Images)
2. Object RGW (Overview, Bucket, Users, Multi-site, Gateways, NFS, Config)
3. Logs
4. Alerts
5. Services
6. Cluster
Nitzan Mordechai [Wed, 21 May 2025 11:41:01 +0000 (11:41 +0000)]
src/mon/MgrStatMonitor: fix invalid iterator increment in calc_pool_availability()
Erasing entries from `pool_availability` inside a range-for
loop invalidated the hidden iterator, triggering an
“Invalid read” under Valgrind.
- Use `std::erase_if(pool_availability, predicate)` for
atomic removal.
- Refactor the stats-update loop to use structured bindings
and a clear `++it` for readability.
Fixes: https://tracker.ceph.com/issues/71271
Signed-off-by: Nitzan Mordechai <nmordec@redhat.com>
Yingxin Cheng [Mon, 23 Jun 2025 02:00:27 +0000 (10:00 +0800)]
Merge pull request #64019 from cyx1231st/wip-seastore-improve-ut
test/crimson/seastore/test_transaction_manager: improve check_available()
Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>
Afreen Misbah [Mon, 16 Jun 2025 17:09:46 +0000 (22:39 +0530)]
mgr/dashboard: Allow host with labels in listener form
- Currently, listeners cannot be added with the Ceph Dashboard if the gateway nodes are selected by label instead of hosts.
- Refactored the code to incorporate nodes with labels
- Also added missing typings and removed 'any'
Fixes https://tracker.ceph.com/issues/71686
Signed-off-by: Afreen Misbah <afreen@ibm.com>
Matan Breizman [Thu, 12 Jun 2025 12:32:38 +0000 (12:32 +0000)]
crimson/common/fatal_signal: Log error before collecting backtrace
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Wed, 4 Jun 2025 10:58:29 +0000 (10:58 +0000)]
crimson/common/fatal_signal: skip print_segv_info and proc_maps
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Wed, 4 Jun 2025 10:56:37 +0000 (10:56 +0000)]
crimson/common/fatal_signal: rework print_backtrace
* Move to GENERIC_LOG
* Print backtrace in log and in std out
* Switch to fmt::format
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Gil Bregman [Sat, 21 Jun 2025 19:39:40 +0000 (22:39 +0300)]
Merge pull request #64006 from gbregman/main
mgr/cephadm/nvmeof: Allow setting NVMEoF gateway notifications interval in the spec file
Adam King [Sat, 21 Jun 2025 18:07:16 +0000 (14:07 -0400)]
Merge pull request #63247 from phlogistonjohn/jjm-cephadm-guess-name
cephadm: minor ergonomic improvements for hackers
Reviewed-by: Adam King <adking@redhat.com>
SrinivasaBharathKanta [Sat, 21 Jun 2025 05:05:31 +0000 (10:35 +0530)]
Merge pull request #62445 from mchangir/mgr-bump-up-ref-count-for-MgrOpRequest
mgr: avoid explicit dropping of ref
John Mulligan [Fri, 20 Jun 2025 23:03:22 +0000 (19:03 -0400)]
script/build-with-container: add rocky10 to built-in distros
Add "rocky10" (also aliased to "rockylinux10") to the known distro bases
so that the team can begin to experiment with the Rocky Linux 10 distro
for containerized builds.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
John Mulligan [Fri, 20 Jun 2025 23:46:16 +0000 (19:46 -0400)]
script/build-with-container: support --build-arg arguments
Allow passing --build-arg arguments to build-with-container.py
which are passed directly to the container build command.
This allows a developer to toggle certain features of the build
container, however this should not be used in CI.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
John Mulligan [Fri, 20 Jun 2025 23:34:45 +0000 (19:34 -0400)]
Dockerfile.build: make WITH_CRIMSON a build arg
We've chosen to enable crimson by default to match the CI, but that
is not always something a developer may want, so make WITH_CRIMSON
a build argument that can be toggled off if necessary.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
John Mulligan [Fri, 20 Jun 2025 23:25:53 +0000 (19:25 -0400)]
install-deps.sh: enable crb for rocky 10
Rocky Linux 10 has a CRB repo that must be enabled for a number of
Ceph's dependencies to be installed via dnf.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
John Mulligan [Mon, 16 Jun 2025 18:38:00 +0000 (14:38 -0400)]
buildcontainer-setup.sh: allow testing with various ELish bases
Allow testing with more RPM-based/EL style distros.
Simplify the centos selection as centos8 ought to always
be matched by the earlier block.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
Kefu Chai [Fri, 20 Jun 2025 23:00:01 +0000 (07:00 +0800)]
common/static_ptr: pass an integer to alignas to fix GCC-11 build failure
GCC-11 fails to compile `alignas(std::bit_ceil(Size))` despite std::bit_ceil()
being marked constexpr in libstdc++11. The compiler doesn't recognize it as a
constant expression, while GCC-12+ and Clang-14+ handle it correctly.
Define the alignment value as a separate constexpr variable before passing it
to alignas() to ensure compatibility with GCC-11.
Fixes compilation issue introduced in commit
73399b05 when std::aligned_storage_t
was replaced with alignas.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
J. Eric Ivancich [Fri, 20 Jun 2025 20:02:10 +0000 (14:02 -0600)]
Merge pull request #63561 from cbodley/wip-71479
rgw: RGWPostBucketLoggingOp uses yield context
Reviewed-by: Yuval Lifshitz <ylifshit@ibm.com>
J. Eric Ivancich [Fri, 20 Jun 2025 20:01:32 +0000 (14:01 -0600)]
Merge pull request #63443 from ivancich/wip-dbr-versioned
rgw: make sure max_objs_per_shard is appropriate in debugging scenarios
Reviewed-by: Casey Bodley <cbodley@redhat.com>
J. Eric Ivancich [Fri, 20 Jun 2025 20:00:54 +0000 (14:00 -0600)]
Merge pull request #63271 from rafaelweingartner/parameter_to_externalize_secret_key_ttl-upstream-2
rgw: Externalize Keystone secret key cache TTL
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Reviewed-by: Tobias Urdin <tobias.urdin@binero.com>
J. Eric Ivancich [Fri, 20 Jun 2025 19:59:27 +0000 (13:59 -0600)]
Merge pull request #63212 from pritha-srivastava/wip-rgw-sts-key-default-val
rgw/sts: removing default value of rgw sts key and adding checks to return error when it is not set in config options
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
SrinivasaBharathKanta [Fri, 20 Jun 2025 15:42:39 +0000 (21:12 +0530)]
Merge pull request #63364 from batrick/mon-redundant
mon/MonMap: remove redundant method
Ilya Dryomov [Fri, 20 Jun 2025 15:09:10 +0000 (17:09 +0200)]
Merge pull request #63302 from VinayBhaskar-V/wip-sort-snaps-changes
librbd: retry list_snap_orders() once instead of failing sort_snaps()
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Ronen Friedman [Fri, 20 Jun 2025 12:53:32 +0000 (15:53 +0300)]
Merge pull request #64048 from ronen-fr/wip-rf-numerrors-doc
osd/scrub: clarify that osd_scrub_auto_repair_num_errors counts objects
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Alex Ainscow [Fri, 20 Jun 2025 11:41:45 +0000 (12:41 +0100)]
Merge pull request #63522 from connorfawcett/ec-tool-encode-fix
tools/ceph-erasure-code-tool: Fix issue stopping parity shards being generated when running encode.
Kefu Chai [Fri, 20 Jun 2025 10:27:53 +0000 (18:27 +0800)]
Merge pull request #63761 from aclamk/aclamk-bs-bluefs-various-fixes
os/bluestore: Set of various fixes to bluefs
Reviewed-by: Igor Fedotov <igor.fedotov@croit.io>
Kefu Chai [Fri, 20 Jun 2025 09:00:59 +0000 (17:00 +0800)]
osd/ECExtentCache: eliminate redundant map lookups
Replace contains() + at() pattern with single find() call to avoid
double lookup overhead. Previously checked map.contains(key) then
used map.at(key), which performs two hash table lookups for the
same operation.
Now uses map.find() and checks the returned iterator against end(),
accessing the value directly from the iterator when found.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Fri, 20 Jun 2025 07:56:26 +0000 (15:56 +0800)]
osd/ECExtentCache: convert LRU::Key from class to struct
Change Key from a class with public members and constructor to a
plain struct. Since Key only holds data with no special initialization
logic, a struct with aggregate initialization is more appropriate
and simpler.
This removes the user-declared constructor and relies on the compiler's
default aggregate initialization from initializer lists.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Fri, 20 Jun 2025 07:31:56 +0000 (15:31 +0800)]
osd/ECExtentCache: use default-generated comparison operators
Replace manually implemented operator== and operator!= for Key with
compiler-generated defaults. In C++20, comparison operators can be
explicitly defaulted, and the generated behavior is identical to our
hand-crafted implementation.
This simplifies the code by letting the compiler handle operator
generation automatically.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Fri, 20 Jun 2025 07:23:00 +0000 (15:23 +0800)]
osd/ECExtentCache: Replace manual mutex operations with std::lock_guard
Replace manual mutex.lock() and mutex.unlock() calls with std::lock_guard
for LRU cache access serialization. This improves code safety by ensuring
automatic unlock on scope exit and reduces maintenance burden compared to
manual mutex management.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
SrinivasaBharathKanta [Fri, 20 Jun 2025 08:24:54 +0000 (13:54 +0530)]
Merge pull request #63516 from mohit84/refactor_mclock
mclock : Refactor the mClock scheduler source code
SrinivasaBharathKanta [Fri, 20 Jun 2025 08:24:08 +0000 (13:54 +0530)]
Merge pull request #62844 from MaxKellermann/auth_includes
auth: add missing includes
Venky Shankar [Fri, 20 Jun 2025 07:38:04 +0000 (13:08 +0530)]
Merge PR #63517 into main
* refs/pull/63517/head:
qa/cephfs: ignore `OSD_DOWN/osds down` warning
Reviewed-by: Jos Collin <jcollin@redhat.com>
Venky Shankar [Fri, 20 Jun 2025 07:04:07 +0000 (12:34 +0530)]
Merge PR #63383 into main
* refs/pull/63383/head:
test: multi client file read/write test for extending writes
client: do not check file size when inode does not have Fc caps
Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
Reviewed-by: Anoop C S <anoopcs@cryptolab.net>
Venky Shankar [Fri, 20 Jun 2025 06:54:44 +0000 (12:24 +0530)]
Merge PR #63323 into main
* refs/pull/63323/head:
Merge branch 'main' into main
qa/cephfs: replace deprecated assertEquals with assertEqual
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
Jos Collin [Fri, 20 Jun 2025 06:09:25 +0000 (11:39 +0530)]
Merge pull request #64035 from joscollin/wip-mirroring-doc-fix
doc/qa: drop mentioning 'manual' in remote snapshotting
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Yingxin Cheng [Fri, 20 Jun 2025 01:33:22 +0000 (09:33 +0800)]
Merge pull request #64002 from xxhdx1985126/wip-seastore-cache-capture
crimson/os/seastore/cache: fix inappropriate lambda by-reference captures in get_extent_viewable_by_trans()
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Kefu Chai [Fri, 20 Jun 2025 01:15:19 +0000 (09:15 +0800)]
Merge pull request #64040 from tchaikov/wip-static_ptr-no-aligned_storage
common/static_ptr: avoid using std::aligned_storage_t
Reviewed-by: Adam Emerson <aemerson@redhat.com>
Hezko [Fri, 20 Jun 2025 00:51:17 +0000 (03:51 +0300)]
Merge pull request #63988 from Hezko/nvmeof-cli-ns-cmnds
mgr/dashboard: add missing namespace CLI commands
SrinivasaBharathKanta [Thu, 19 Jun 2025 23:33:46 +0000 (05:03 +0530)]
Merge pull request #63486 from Matan-B/wip-matanb-ndebug-typo
src: fix NDEBUG typo
SrinivasaBharathKanta [Thu, 19 Jun 2025 23:31:32 +0000 (05:01 +0530)]
Merge pull request #58881 from cbodley/wip-gcc-13-lto
rpm: reenable lto for gcc-toolset-13 by requiring 13.3
Kefu Chai [Thu, 19 Jun 2025 23:20:45 +0000 (07:20 +0800)]
Merge pull request #64037 from tchaikov/wip-neorados-alignedas
neorados: avoid using std::aligned_storage_t
Reviewed-by: Adam Emerson <aemerson@redhat.com>
Kefu Chai [Thu, 19 Jun 2025 23:20:11 +0000 (07:20 +0800)]
Merge pull request #64042 from tchaikov/wip-rgw-no-aligned_storage
rgw: avoid using std::aligned_storage_t
Reviewed-by: Adam Emerson <aemerson@redhat.com>
Samuel Just [Thu, 19 Jun 2025 23:17:44 +0000 (16:17 -0700)]
Merge pull request #63925 from athanatos/sjust/wip-71658
test/fs/CMakeLists.txt: add ceph-common to ceph_test_trim_caps and ceph_test_ino_release_cb
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
Kefu Chai [Thu, 19 Jun 2025 23:10:39 +0000 (07:10 +0800)]
Merge pull request #62568 from Matan-B/wip-matanb-fmt-11.1.4
fmt: bump up version to 11.1.4
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Thu, 19 Jun 2025 22:57:52 +0000 (06:57 +0800)]
Merge pull request #64036 from tchaikov/wip-common-io-exerciser-fix-buffer-overread
common/io_exerciser: fix buffer overread in DataGenerator
Reviewed-by: Jon Bailey <jonathan.bailey1@ibm.com>
Kefu Chai [Thu, 19 Jun 2025 22:52:17 +0000 (06:52 +0800)]
Merge pull request #63800 from tchaikov/wip-fmt-utime
include/utime_fmt.h: replace deprecated fmt::localtime() with localti…
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
afreen23 [Thu, 19 Jun 2025 22:37:19 +0000 (04:07 +0530)]
Merge pull request #63891 from ceph/dependabot-npm_and_yarn-src-pybind-mgr-dashboard-frontend-multi-
f14091dc8f
mgr/dashboard: bump vite and @angular-devkit/build-angular in /src/pybind/mgr/dashboard/frontend
Reviewed-by: Afreen Misbah <afreen@ibm.com>
Tomer Haskalovitch [Thu, 22 May 2025 10:35:26 +0000 (13:35 +0300)]
mgr/dashboard: add missing ns commands
Signed-off-by: Tomer Haskalovitch <il033030@Tomers-MBP.lan>
Kamoltat (Junior) Sirivadhna [Thu, 19 Jun 2025 18:34:35 +0000 (14:34 -0400)]
Merge pull request #64047 from kamoltat/wip-ksirivad-revert-pr-63413
ProtocolV2: Revert "make handle_existing_connection check for cookie mismatch first"
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Ilya Dryomov [Thu, 19 Jun 2025 18:10:11 +0000 (20:10 +0200)]
Merge pull request #63149 from ajarr/wip-ajarr-fix-mirror-image-get-mode
librbd/api/Mirror: return EINVAL from image_get_mode() when the image is disabled for mirroring
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Afreen Misbah <afreen@ibm.com>
Ilya Dryomov [Thu, 19 Jun 2025 18:08:17 +0000 (20:08 +0200)]
Merge pull request #63295 from tchaikov/rbd-cache-pwl-fix-leaks
librbd/cache/pwl: fix memory leak in SyncPoint persist context cleanup
Reviewed-by: Yin Congmin <congmin.yin@intel.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Ronen Friedman [Thu, 19 Jun 2025 15:27:38 +0000 (10:27 -0500)]
osd/scrub: clarify that osd_scrub_auto_repair_num_errors counts objects
'osd_scrub_auto_repair_num_errors' limits the number of damaged objects
that we will try to auto-repair during a scrub. Its documentation
referred to "number of errors", which did not fit the implementation.
Fixes: https://tracker.ceph.com/issues/71754
Fixes: Red Hat BZ2316244
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Casey Bodley [Thu, 19 Jun 2025 16:17:32 +0000 (12:17 -0400)]
Merge pull request #63521 from mertsunacoglu/wip-url-decode-check
fix: the RGW crash caused by special characters
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Ronen Friedman [Thu, 19 Jun 2025 16:05:12 +0000 (19:05 +0300)]
Merge pull request #64000 from ronen-fr/wip-rf-testd4n
test/rgw/test_d4n_filter: remove unused captures
Reviewed-by: Pritha Srivastava <prsrivas@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Samarah <samarah.uriarte@ibm.com>
Afreen Misbah [Mon, 16 Jun 2025 15:16:39 +0000 (20:46 +0530)]
mgr/dashboard: Add --force flag for listeners
Fixes https://tracker.ceph.com/issues/71685
Signed-off-by: Afreen Misbah <afreen@ibm.com>
Yuval Lifshitz [Thu, 19 Jun 2025 15:47:31 +0000 (18:47 +0300)]
Merge pull request #63959 from yuvalif/wip-yuval-71608
rgw/logging: make unique part of log file both random and incremental