rgw: Fix segfault due to concurrent socket use at timeout

This commit fixes a potential segfault risk when
rgw timeout handler works on the socket in one
thread while it is concurrently used by another.
The details of the fix are:

1. Instead of calling socket close(), which resets
descriptor_data in boost::asio socket and risks
segfault due to concurrent use of the socket,
the timeout handler now calls cancel() to abort
all pending ops followed by shutdown() to disable
the underlying transport. The eventual closure of
the socket will be done in the socket destructor.

2. Expose the actual boost::asio socket via get_socket()
from Connection so that the timeout handler can call
cancel() and shutdown() on it, although the socket data
member is already accessible. It allows future expansion
that wants to hide the socket even though it renders the
existing close() less useful.

Fixes: https://tracker.ceph.com/issues/58670
Signed-off-by: Yixin Jin <yjin77@yahoo.ca>
(cherry picked from commit 6d5988cbdab48705414e311217c61d3c798085d8)

Merge pull request #50184 from cbodley/wip-58118

quincy: rgw: default-initialize delete_multi_obj_op_meta

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #49902 from ifed01/wip-ifed-fix-cls-queue-list-qui

quincy: cls/queue: use larger read chunks in queue_list_entries

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #49840 from k0ste/wip-58554-quincy

quincy: rgw/beast: fix interaction between keepalive and 100-continue

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #49794 from dang/wip-58509-quincy

quincy: Fix chown to unlink

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #49775 from liangmingyuanneo/wip-rgw-backport-49636-to-quincy

quincy: rgw: remove guard_reshard in bucket_index_read_olh_log

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #49404 from lxbsz/wip-58251

quincy: mount: fix mount failure with old kernels

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #49092 from cfsnyder/wip-54496-quincy

quincy: rgw: prevent spurious/lost notifications in the index completion thread

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #49090 from cfsnyder/wip-54157-quincy

quincy: rgw: "reshard cancel" errors with "invalid argument"

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #48845 from nkshirsagar/wip-58006-quincy

quincy: mon: bail from handle_command() if _generate_command_map() fails

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>

Merge pull request #49967 from vshankar/tr-57729

quincy: pybind/mgr: check for empty metadata mgr_module:get_metadata()

Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge pull request #49831 from tserong/wip-58534-quincy

quincy: ceph.spec.in: Replace %usrmerged macro with regular version check

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>

Merge pull request #48719 from idryomov/gcc-13-quincy

quincy: common: fix build with GCC 13 (missing <cstdint> include)

Reviewed-by: Ramana Raja <rraja@redhat.com>

Merge pull request #48222 from mchangir/wip-55749-quincy

quincy: mgr/snap_schedule: remove subvol interface

Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge pull request #48028 from tserong/wip-57391-quincy

quincy: ceph-dencoder: Add erasure_code to denc-mod-osd's target_link_libraries

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #48466 from neesingh-rh/wip-57849-quincy

quincy: mgr/volumes: Add human-readable flag to volume info command

Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #48252 from dparmar18/wip-57666-quincy

quincy: mds/Server: Do not abort MDS on unknown messages

Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge pull request #50224 from zdover23/wip-doc-2023-02-23-backport-50221-to-quincy

quincy: doc/glossary: add "Bucket"

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

Merge pull request #50228 from zdover23/wip-doc-2023-02-23-backport-50226-to-quincy

quincy: doc: preen cephadm/troubleshooting.rst and radosgw/placement.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc: preen cephadm/troubleshooting.rst and radosgw/placement.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit d5bf55bcd6fcec43d2b728a2b8cd2f35b42e3b7e)

Merge pull request #50222 from zdover23/wip-doc-2023-02-23-backport-50220-to-quincy

quincy: doc/cephadm/troubleshooting: remove word repeat

doc/glossary: add "Bucket"

Add "Bucket" to the glossary. The definition added here is just a first
attempt, but a man's reach must exceed his grasp, or what's a heaven
for?

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit ffbc5ea2b9347e2600df6aea9cdf895529fbf857)

doc/cephadm/troubleshooting: remove word repeat

The original text was "In case the cluster the last MGR of a cluster"

Signed-off-by: thomas <me@thomasanderson.cloud>
(cherry picked from commit 4e9eaf8b5d81b58ad49ed6ecbce38db98b985fc1)

Merge pull request #50218 from zdover23/wip-doc-2023-02-23-backport-50213-to-quincy

quincy: doc/rados: update OSD_BACKFILLFULL description

doc/rados: update OSD_BACKFILLFULL description

Document that this warning can happen even when the OSDs' limits
haven't hit the backfill_full_ratio.

Signed-off-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com>
(cherry picked from commit 198a9e02cb934802fcb5d5d06b05e3662a4b5cab)

Merge pull request #50097 from sseshasa/wip-58708-quincy

quincy: osd: Restore defaults of mClock built-in profiles upon modification

Reviewed-by: Laura Flores <lflores@redhat.com>

Merge pull request #50091 from petrutlucian94/wip-58702-quincy

quincy: os/memstore: Fix memory leak

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>

rgw: initialize RGWIndexCompletionManager thread after related members

resolves valgrind issues about RGWIndexCompletionManager::process()
using uninitialized memory

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 112c2608750cf8db2c52c8e89f5897080501f6bd)

rgw: prevent spurious/lost notifications in the index completion thread

this was happening when asyn completions happened during reshard.
more information about testing:
https://gist.github.com/yuvalif/d526c0a3a4c5b245b9e951a6c5a10517

we also add more logs to the completion manager.
should allow finding unhandled completions due to reshards.

Fixes: https://tracker.ceph.com/issues/54435
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
(cherry picked from commit e72b6510a402cbafa6c99475626f15d97fd00f86)

Conflicts:
- src/rgw/rgw_rados.cc

Cherry-pick notes:
- Conflicts within RGWIndexCompletionThread methods, which were removed by this commit

Merge pull request #48312 from k0ste/wip-57196-quincy

quincy: rgw: x-amz-date change breaks certain cases of aws sig v4.

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #49096 from cfsnyder/wip-57237-quincy

quincy: rgw/coroutine: check for null stack on wakeup

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #49094 from cfsnyder/wip-55227-quincy

quincy: rgw: adding BUCKET_REWRITE and OBJECT_REWRITE OPS to

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #49088 from cfsnyder/wip-55506-quincy

quincy: rgw: RGWPutLC does not require Content-MD5

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #50204 from zdover23/wip-doc-2023-02-22-backport-50203-to-quincy

quincy: doc/rgw: clarify multisite.rst top matter

doc/rgw: clarify multisite.rst top matter

Improve the pragmatics of the top matter of multisite.rst. Organize the
text into sections, where doing so makes the nature of multi-site
configurations clearer.

Co-authored-by: Cole Mitchell <cole.mitchell@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit bbc229340f77ba8ec7fa967a59664caf3c07d030)

Merge pull request #49085 from cfsnyder/wip-57410-quincy

quincy: rgw: bucket list operation slow down in special scenario

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #48914 from yuvalif/wip-57561-quincy

quincy: tests: remove pubsub tests from multisite

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #48239 from trociny/wip-56406-quincy

quincy: rgw: splitting gc chains into smaller parts to prevent

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #50002 from smanjara/wip-57702-quincy

quincy: qa/suites/rgw: fix and update tempest and barbican tests

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #49828 from ivancich/wip-58543-quincy

quincy: rgw: fix the problem of duplicate idx when bi list

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #49641 from dang/wip-58388-quincy

quincy: RGW - Make sure PostObj set bucket on s->object

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #49679 from adamemerson/wip-58402-quincy

rgw: Backport of issue 57562 to Quincy

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #49525 from dang/wip-58233-quincy

quincy: rgw: Fix truncated ListBuckets response.

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #48273 from satoru-takeuchi/wip-57559-quincy

quincy: rgw: fix data corruption due to network jitter

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #48030 from pritha-srivastava/wip-57364-quincy

quincy: rgw multisite: replicate metadata for iam roles

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>

Merge pull request #50189 from zdover23/wip-doc-2023-02-21-backport-50165-to-quincy

quincy: doc/rgw: multisite ref. top matter cleanup

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

Merge pull request #48325 from kotreshhr/wip-57722-quincy

quincy: qa: Fix test_subvolume_snapshot_info_if_orphan_clone

Reviewed-by: Jos Collin <jcollin@redhat.com>

doc/rgw: multisite ref. top matter cleanup

Edit the top matter in "Multi-site Configuration Reference" so that it
is semantically more natural.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit db2a5624852224263ba3bd8baaa9b4addf80cb97)

Merge pull request #50187 from zdover23/wip-doc-2023-02-21-backport-50186-to-quincy

quincy: doc/rgw: session-tags.rst - fix link to keycloak

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

doc/rgw: session-tags.rst - fix link to keycloak

Fix a link in the doc/radosgw/session-tags.rst file that was intended to
link to the doc/radosgw/keycloak.rst file.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 76eae93ab8dcd91873f49350d452da8b4838fbb0)

doc/cephfs: remove subvol support from snap-schedule

Signed-off-by: Milind Changire <mchangir@redhat.com>
(cherry picked from commit c15b854c0c9656edd5d4fd240c7d90736eca2957)

qa: remove spurious argument to snap-schedule status command

Removing the subvol support exposed a spurious argument to the status
command which was assgned to the 'subvol' parameter but was unused in
this command implementation.

The spurious argument is now removed.

Signed-off-by: Milind Changire <mchangir@redhat.com>
(cherry picked from commit b814630794abccb31f05e1efcd3b9f3e35cd3bec)

mgr/snap_schedule: remove subvol interface

Remove snap-schedule support for subvolumes.

Fixes: https://tracker.ceph.com/issues/55148
Signed-off-by: Milind Changire <mchangir@redhat.com>
(cherry picked from commit 919c156884587fc87b418c776046c8b6a7efe4ff)

mgr/snap_schedule: validate fs name argument

Validate fs name argument for all commands.

Fixes: https://tracker.ceph.com/issues/54560
Signed-off-by: Milind Changire <mchangir@redhat.com>
(cherry picked from commit 483a97830bd918a2be83021edeedf9f8a2fc54f8)

rgw: initialize rgw_log_entry::identity_type

uninitialized identity_type field was causing unit test failures from
check-generated.sh:

**** rgw_log_entry test 2 dump_json check failed ****
   ceph-dencoder type rgw_log_entry select_test 2 dump_json > /tmp/typ-AW7AEODB3
   ceph-dencoder type rgw_log_entry select_test 2 encode decode dump_json > /tmp/typ-0NX4cmLHR
21c21
<     "identity_type": 3599295712
---
>     "identity_type": 2072560864

Fixes: https://tracker.ceph.com/issues/58115
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit cd99af0760bf973d44bacb55767f26ec7a975912)

rgw: default-initialize delete_multi_obj_op_meta

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit d7cfbdac1a07feb2dfd108add4a4cdc161a5ddac)

Merge pull request #49795 from ivancich/wip-58171-quincy

quincy: rgw: address bug where object puts could write to decommissioned shard

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #50173 from zdover23/wip-doc-2023-02-20-backport-50164-to-quincy

quincy: doc/radosgw: s/execute/run/ in multisite.rst

doc/radosgw: s/execute/run/ in multisite.rst

Replace "execute" with "run" in fourteen out of fifteen instances in
multisite.rst. "Execute" is plain old too grand in most of these
instances.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit b54b1b6bf5c9f7fee9387464b553035a88f6729e)

Merge pull request #49788 from guits/wip-58396-quincy

quincy: ceph-volume/tests: add allowlist_externals to tox.ini

Merge pull request #50155 from zdover23/wip-doc-2023-02-18-backport-50154-to-quincy

quincy: doc/glossary: add "Period" to glossary

doc/glossary: add "Period" to glossary

Add definition for "period" to glossary.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit bd9bc3adb3960385615fe79ea83809396a19dae0)

Merge pull request #49414 from ljflores/wip-quincy-backport-pr-48214

quincy: mgr/telemetry: add `basic_pool_options_bluestore` collection

Merge pull request #48613 from tserong/wip-57916-quincy

quincy: make-dist: don't set Release tag in ceph.spec for SUSE distros

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

Merge pull request #48522 from tserong/wip-57885-quincy

quincy: ceph.spec.in: disable system_pmdk on s390x for SUSE distros

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>

Merge pull request #47233 from cfsnyder/wip-55829-quincy

quincy: common: notify all when max backlog reached in OutputDataSocket

Reviewed-by: Laura Flores <lflores@redhat.com>

Merge pull request #48805 from tserong/wip-57997-quincy

quincy: ceph-crash: drop privleges to run as "ceph" user, rather than root (CVE-2022-3650)

Merge pull request #50130 from idryomov/wip-58060-quincy

quincy: librbd: avoid EUCLEAN error after "rbd rm" is interrupted

Reviewed-by: Ramana Raja <rraja@redhat.com>

Merge pull request #50113 from idryomov/wip-58688-quincy

quincy: qa/suites/rbd: fix sporadic "rx-only direction" test failures

Reviewed-by: Ramana Raja <rraja@redhat.com>

Merge pull request #48211 from mgfritch/wip-57645-quincy

quincy: cephadm: add `ip_nonlocal_bind` to haproxy deployment

Reviewed-by: Redouane Kachach <rkachach@redhat.com>

Merge pull request #49309 from adk3798/wip-58204-quincy

quincy: mgr/cephadm: iscsi username and password defaults to admin

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #49849 from adk3798/wip-58558-quincy

quincy: cephadm: don't overwrite cluster logrotate file

Reviewed-by: Teoman ONAY <tonay@ibm.com>

Merge pull request #49854 from adk3798/wip-58454-quincy

quincy: cephadm: only pull host info from applied spec, don't try to parse yaml

Reviewed-by: Redouane Kachach <rkachach@redhat.com>

Merge pull request #49855 from adk3798/wip-58451-quincy

quincy: mgr/orchestrator: fix upgrade status help message

Reviewed-by: Redouane Kachach <rkachach@redhat.com>

Merge pull request #49860 from adk3798/wip-58207-quincy

quincy: mgr/cephadm: write client files after applying services

Reviewed-by: Teoman ONAY <tonay@ibm.com>

Merge pull request #49861 from adk3798/wip-58205-quincy

quincy: mgr/cephadm: don't say migration in progress if migration current > migration last

Reviewed-by: Teoman ONAY <tonay@ibm.com>

Merge pull request #48677 from joscollin/wip-57946-quincy

quincy: cephfs-top: make cephfs-top display scrollable

Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge pull request #48563 from vshankar/tr-57874

quincy: client: use parent directory POSIX ACLs for snapshot dir

Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge pull request #48520 from ajarr/wip-57879-quincy

quincy:  src/mds: increment directory inode's change attr by one

Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge pull request #48442 from trociny/wip-57820-quincy

quincy: cephfs-data-scan: make scan_links more verbose

Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>

Merge pull request #48261 from batrick/i57670

quincy: mds: damage table only stores one dentry per dirfrag

Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge pull request #48132 from lxbsz/wip-57572

quincy: client: do not uninline data for read

Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge pull request #48110 from lxbsz/wip-57392

quincy: client: abort the client if we couldn't invalidate dentry caches

Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge pull request #48107 from lxbsz/wip-57394

quincy: client: stop the remount_finisher thread in the Client::unmount()

Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge pull request #48208 from s0nea/wip-57640-quincy

quincy: cephadm: consider stdout to get container version

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #48242 from tserong/wip-57637-quincy

quincy: python-common: Add 'KB' to supported suffixes in SizeMatcher

Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>

Merge pull request #48531 from adk3798/wip-57787-quincy

quincy: mgr/nfs: add sectype option

Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #49771 from adk3798/quincy-cephadm-exporter

quincy: ceph-exporter: cephadm changes

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>

Merge pull request #49847 from adk3798/wip-58568-quincy

quincy: mgr/cephadm: call iscsi post_remove from serve loop

Reviewed-by: Redouane Kachach <rkachach@redhat.com>

Merge pull request #49850 from adk3798/wip-58557-quincy

quincy: mgr/cephadm: fix removing offline hosts with ingress daemons

Reviewed-by: Redouane Kachach <rkachach@redhat.com>

Merge pull request #49859 from adk3798/wip-58248-quincy

quincy: mgr/cephadm: fix handling of mgr upgrades with 3 or more mgrs

Reviewed-by: Redouane Kachach <rkachach@redhat.com>

Merge pull request #49864 from adk3798/wip-58174-quincy

quincy: mgr/cephadm: fix check for if devices have changed

Reviewed-by: Redouane Kachach <rkachach@redhat.com>

Merge pull request #50134 from zdover23/wip-doc-2023-02-16-backport-50120-to-quincy

quincy: doc/glossary: add "realm" to glossary

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

mount: fix mount failure with old kernels

If the 'cmi->cmi_opts' has only one option and there is no any
comma in it, when removing the 'mon_addr' it will fail. And will
pass the 'mon_addr' option to the old kernels.

Fixes: https://tracker.ceph.com/issues/58018
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 3180332ec48596794e2ff4fff305119c4ec2caf7)

Merge pull request #49858 from adk3798/wip-58445-quincy

quincy: qa/tasks/cephadm.py: fix pulling cephadm from git.ceph.com

Reviewed-by: Redouane Kachach <rkachach@redhat.com>

Merge pull request #49868 from guits/wip-58574-quincy

quincy: ceph-volume: fix a bug in lsblk_all()

Merge pull request #49323 from sseshasa/wip-58214-quincy

quincy: osd: Randomize osd bench buffer data before submitting to objectstore

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #49670 from vshankar/wip-58350

quincy: mds: fix scan_stray_dir not reset next.frag on each run of stray inode

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #49504 from rhcs-dashboard/wip-58271-quincy

quincy: mgr/dashboard: add tooltip mirroring pools table

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #50139 from zdover23/wip-doc-2023-02-16-backport-50138-to-quincy

quincy: doc/rgw: refine "Realms" section