]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
11 years agomessages,osd: add EC messages and associated types
Samuel Just [Fri, 20 Dec 2013 00:15:03 +0000 (16:15 -0800)]
messages,osd: add EC messages and associated types

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agosrc/osd/: add ECBackend stubs
Samuel Just [Thu, 12 Dec 2013 19:17:04 +0000 (11:17 -0800)]
src/osd/: add ECBackend stubs

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoPGBackend: make getattrs virtual
Samuel Just [Sun, 16 Feb 2014 03:08:42 +0000 (19:08 -0800)]
PGBackend: make getattrs virtual

This way, the backend can choose to filter private attrs.

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoReplicatedPG: fix size checking for ECBackend pools
Samuel Just [Sun, 16 Feb 2014 03:08:13 +0000 (19:08 -0800)]
ReplicatedPG: fix size checking for ECBackend pools

Allow the backend to adjust the logical object size before
checking against the ondisk size.

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoPGBackend/ReplicatedBackend: factor out logical to ondisk size mapping
Samuel Just [Sat, 8 Feb 2014 22:04:14 +0000 (14:04 -0800)]
PGBackend/ReplicatedBackend: factor out logical to ondisk size mapping

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoPGBackend/ReplicatedBackend: move the backend agnostic code into PGBackend for scrub
Samuel Just [Sat, 8 Feb 2014 21:52:28 +0000 (13:52 -0800)]
PGBackend/ReplicatedBackend: move the backend agnostic code into PGBackend for scrub

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoReplicatedBackend: factor out be_deep-scrub
Samuel Just [Sat, 8 Feb 2014 21:40:50 +0000 (13:40 -0800)]
ReplicatedBackend: factor out be_deep-scrub

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoosd/: replace bufferptr with bufferlist for attrs in recovery
Samuel Just [Thu, 30 Jan 2014 21:06:50 +0000 (13:06 -0800)]
osd/: replace bufferptr with bufferlist for attrs in recovery

Now we won't have to keep converting back and forth!

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoPG::discover_all_missing: request a FULLLOG
Samuel Just [Mon, 10 Feb 2014 22:05:09 +0000 (14:05 -0800)]
PG::discover_all_missing: request a FULLLOG

Otherwise, we cannot correct for divergent objects in the missing
set.

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoPG,ReplicatedPG: Generalize missing_loc for ECBackend
Samuel Just [Wed, 29 Jan 2014 21:38:04 +0000 (13:38 -0800)]
PG,ReplicatedPG: Generalize missing_loc for ECBackend

Prior to EC pools, unfound => missing.  Now, unfound (unreadable,
really) is dependent on the PGBackend requirements for reconstituting
an object.  This also means recovering an object missing on a replica
but not the primary requires tracking the missing_loc set.

Thus, rather than maintaining missing_loc only for objects missing
on the primary, the MissingLoc structure will track all missing
objects actingbackfill-wide until each object is recovered.

For simplicity, since we don't really know what objects need recovery
until activation (and since we can't do anything with that information
prior to activation anyway), we defer populating the missing_loc
information until activation.

We need peers to rollback divergent log entries before we attempt to
read the relevant objects.  The simplest way to accomplish this seems to
be the simply choose to always activate peers if search_for_missing
turns up missing objects.

Due to EC pools, missing is necessary, but not sufficient for readability.
Thus, we instead check is_unreadable for cases where we need to read the object
and reserve is_missing for cases where we need the object context.

wait_for_missing_object becomes waiting_for_unreadable_object in order to avoid
having another layer of waiting_for_* maps.  These ops may be requeued
either when the primary is recovered or when the object is no longer degraded,
depending on when the object becomes readable.

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoPG: allow PGBackend to set criteria for PG up-ness
Samuel Just [Wed, 12 Feb 2014 18:53:13 +0000 (10:53 -0800)]
PG: allow PGBackend to set criteria for PG up-ness

ECBackend needs to be able to require that a readable
set of the most recent interval to write be available
in order to ensure that it rolls back the log far
enough.

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoPGBackend: add some additional helpers.
Samuel Just [Tue, 28 Jan 2014 00:52:05 +0000 (16:52 -0800)]
PGBackend: add some additional helpers.

ECBackend's primary specific logic mostly won't treat the
primary shard specially, so it'll be handy to have primary
agnostic helpers for get_shard_info and get_shard_missing.

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoPG,PGBackend: expose acting and backfill_targets
Samuel Just [Tue, 28 Jan 2014 00:52:20 +0000 (16:52 -0800)]
PG,PGBackend: expose acting and backfill_targets

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoos/: allow objects with NO_GEN but non-NO_SHARD shard
Samuel Just [Sat, 1 Feb 2014 05:42:45 +0000 (21:42 -0800)]
os/: allow objects with NO_GEN but non-NO_SHARD shard

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoPG: skip CRUSH_ITEM_NONE in acting set in various places
Samuel Just [Wed, 12 Feb 2014 18:46:09 +0000 (10:46 -0800)]
PG: skip CRUSH_ITEM_NONE in acting set in various places

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoosd/: extend pg_interval_t to include primary
Samuel Just [Wed, 12 Feb 2014 18:44:45 +0000 (10:44 -0800)]
osd/: extend pg_interval_t to include primary

Otherwise, we cannot correctly determine up_from/up_thru for
old intervals.  Also, we need this information to determine
when a new interval starts due to a new primary without a
change in the acting set.

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoObjecter: handle primary other than acting[0]
Samuel Just [Wed, 12 Feb 2014 18:48:56 +0000 (10:48 -0800)]
Objecter: handle primary other than acting[0]

EC pool particularly might have CRUSH_ITEM_NONE as acting[0] which
is not a valid osd.

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoOSDMap: handle CRUSH_ITEM_NONE in acting sets
Samuel Just [Wed, 12 Feb 2014 18:45:07 +0000 (10:45 -0800)]
OSDMap: handle CRUSH_ITEM_NONE in acting sets

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoOSDMap: fill in get_primary_shard
Samuel Just [Thu, 23 Jan 2014 22:52:01 +0000 (14:52 -0800)]
OSDMap: fill in get_primary_shard

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoPG: introduce calc_ec_acting
Samuel Just [Thu, 23 Jan 2014 21:09:54 +0000 (13:09 -0800)]
PG: introduce calc_ec_acting

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoPG: refactor calc_acting to handle pg_shard_t changes
Samuel Just [Thu, 23 Jan 2014 18:12:45 +0000 (10:12 -0800)]
PG: refactor calc_acting to handle pg_shard_t changes

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoosd/: refer to pg by spg_t and replica by pg_shard_t
Samuel Just [Tue, 28 Jan 2014 20:50:05 +0000 (12:50 -0800)]
osd/: refer to pg by spg_t and replica by pg_shard_t

We may have multiple pg shards on the same osd for an
ec pool.  Thus, replicas must be referred to by <osd, shard>
and pgs by <pgid, shard>.

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agomessages/: include shard information in various pg messages
Samuel Just [Thu, 16 Jan 2014 23:27:36 +0000 (15:27 -0800)]
messages/: include shard information in various pg messages

We can no longer use the messenger source information to determine
the origin of the message since an osd might have more than one
shard of a particular pg.  Thus, we need to include a pg_shard_t
from field to indicate origin.  Similarly, pg_t is no longer
sufficient to specify the destination pg, we instead use spg_t.
In the event that we get a message from an old peer, we default
from to pg_shard_t(get_source().num(), ghobject_t::no_shard())
and spg_t to spg_t(pgid, ghobject_t::no_shard()).  This suffices
because non-NO_SHARD shards can only appear once ec pools have
been enabled -- and doing that bans unenlightened osds.

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoReplicatedBackend: excise OSDService*
Samuel Just [Sun, 16 Feb 2014 01:43:19 +0000 (17:43 -0800)]
ReplicatedBackend: excise OSDService*

This should eventually make it easier to mock out a PGBackend::Listener.

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoPGBackend/ReplicatedBackend: move temp handling into PGBackend
Samuel Just [Thu, 23 Jan 2014 01:56:30 +0000 (17:56 -0800)]
PGBackend/ReplicatedBackend: move temp handling into PGBackend

Temp handling is also the same in ReplicatedBackend as in ECBackend.

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoPGBackend: use whoami_shard().shard in rollback*, objects*
Samuel Just [Sat, 1 Feb 2014 06:52:37 +0000 (22:52 -0800)]
PGBackend: use whoami_shard().shard in rollback*, objects*

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoReplicatedBackend/PGBackend: move objects_* methods into PGBackend
Samuel Just [Thu, 23 Jan 2014 01:50:04 +0000 (17:50 -0800)]
ReplicatedBackend/PGBackend: move objects_* methods into PGBackend

These also are unchanged in ECBackend.

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoPGBackend/ReplicatedBackend: move rollback methods into PGBackend
Samuel Just [Thu, 23 Jan 2014 01:46:22 +0000 (17:46 -0800)]
PGBackend/ReplicatedBackend: move rollback methods into PGBackend

These will end up essentially unchanged in ECBackend as it turns out.

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoosd_types: introduce spg_t, pg_shard_t
Samuel Just [Wed, 11 Dec 2013 23:03:44 +0000 (15:03 -0800)]
osd_types: introduce spg_t, pg_shard_t

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoObjectStore: use ghobject_t for setattrs
Samuel Just [Mon, 16 Dec 2013 23:40:04 +0000 (15:40 -0800)]
ObjectStore: use ghobject_t for setattrs

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agosrc/osd: pass in version to recover to recover_object
Samuel Just [Fri, 27 Dec 2013 19:26:11 +0000 (11:26 -0800)]
src/osd: pass in version to recover to recover_object

Otherwise we need to do some annoying contortions to
get it out of the missing sets.

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoosd/: Add a shard parameter to SnapMapper to handle multiple pg shards
Samuel Just [Thu, 6 Feb 2014 02:42:34 +0000 (18:42 -0800)]
osd/: Add a shard parameter to SnapMapper to handle multiple pg shards

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoTestPGLog: remove test with DELETE op with prior_version = eversion_t()
Samuel Just [Mon, 17 Feb 2014 22:20:44 +0000 (14:20 -0800)]
TestPGLog: remove test with DELETE op with prior_version = eversion_t()

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoPGLog::merge_old_entry: simplify the oe.version > ne.version case
Samuel Just [Mon, 10 Feb 2014 22:07:07 +0000 (14:07 -0800)]
PGLog::merge_old_entry: simplify the oe.version > ne.version case

If ne.version < oe.version, the correct answer is to rollback oe.version
if possible regardless of what the entries are.

Also, rearrange to deal with the fact that we cannot roll back a missing
object.

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoPG: just ignore rollbacks on objects we have already failed to rollback
Samuel Just [Fri, 7 Feb 2014 01:26:24 +0000 (17:26 -0800)]
PG: just ignore rollbacks on objects we have already failed to rollback

The relevant changes to missing and/or the filestore will have
already been made.

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoPG::remove_snap_mapped_object: use pg_whoami.shard
Samuel Just [Mon, 10 Feb 2014 22:04:30 +0000 (14:04 -0800)]
PG::remove_snap_mapped_object: use pg_whoami.shard

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoReplicatedPG: take snapset_obc write lock where appropriate
Samuel Just [Sun, 16 Feb 2014 01:44:57 +0000 (17:44 -0800)]
ReplicatedPG: take snapset_obc write lock where appropriate

Otherwise, we might read it for backfill before it's fully created
on a peer.

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoReplicatedPG: release backfill state on_global_recover not peer recover
Samuel Just [Tue, 11 Feb 2014 02:35:47 +0000 (18:35 -0800)]
ReplicatedPG: release backfill state on_global_recover not peer recover

There may now be multiple backfill peers.

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoReplicatedPG: take clone write lock as well in make_writeable
Samuel Just [Tue, 11 Feb 2014 02:34:52 +0000 (18:34 -0800)]
ReplicatedPG: take clone write lock as well in make_writeable

Otherwise, we might start backfilling the clone before the op is
complete.

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoReplicatedPG,osd_types: seperate require_rollback from ec_pool
Samuel Just [Thu, 23 Jan 2014 21:32:21 +0000 (13:32 -0800)]
ReplicatedPG,osd_types: seperate require_rollback from ec_pool

It's handy to allow a pool to answer false to ec_pool() and
true to require_rollback() in order to allow a replicated
pool to test the rollback mechanisms without allowing
non-NO_SHARD shards.

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoReplicatedPG:: remove_snap_mapped_object already removes the object
Samuel Just [Mon, 10 Feb 2014 22:07:46 +0000 (14:07 -0800)]
ReplicatedPG:: remove_snap_mapped_object already removes the object

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoReplicatedPG: find_object_context debugging: output oi
Samuel Just [Tue, 4 Feb 2014 01:10:56 +0000 (17:10 -0800)]
ReplicatedPG: find_object_context debugging: output oi

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoReplicatedPG: handle xattr cache on rollback and delete_head
Samuel Just [Sat, 8 Feb 2014 19:24:37 +0000 (11:24 -0800)]
ReplicatedPG: handle xattr cache on rollback and delete_head

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoReplicatedPG: release_op_ctx_locks in all-applied, not all-committed
Samuel Just [Tue, 4 Feb 2014 01:10:45 +0000 (17:10 -0800)]
ReplicatedPG: release_op_ctx_locks in all-applied, not all-committed

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoFileStore: permit NULL onreadable callback
Samuel Just [Mon, 3 Feb 2014 04:05:20 +0000 (20:05 -0800)]
FileStore: permit NULL onreadable callback

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoErasureCodeJerasure: fill in decoded if all shards are included
Samuel Just [Tue, 4 Feb 2014 01:09:28 +0000 (17:09 -0800)]
ErasureCodeJerasure: fill in decoded if all shards are included

This causes it to match minimum_to_decode.

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoErasureCodeJerasure: fix alignement issues in encode/decode
Samuel Just [Sat, 1 Feb 2014 04:07:26 +0000 (20:07 -0800)]
ErasureCodeJerasure: fix alignement issues in encode/decode

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoObjectStore: fix OP_COLL_ADD dump output
Samuel Just [Sun, 9 Feb 2014 01:37:15 +0000 (17:37 -0800)]
ObjectStore: fix OP_COLL_ADD dump output

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoTestRados: send aligned appends on erasure pools
Samuel Just [Sat, 1 Feb 2014 19:31:25 +0000 (11:31 -0800)]
TestRados: send aligned appends on erasure pools

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoReplicatedPG: reject unaligned writes on ec pools
Samuel Just [Thu, 6 Feb 2014 04:05:04 +0000 (20:05 -0800)]
ReplicatedPG: reject unaligned writes on ec pools

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agolibrados: add calls to expose required write alignment
Samuel Just [Thu, 6 Feb 2014 04:04:41 +0000 (20:04 -0800)]
librados: add calls to expose required write alignment

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoSimpleMessenger: init_local_connection whenever my_inst changes
Samuel Just [Sat, 1 Feb 2014 04:07:54 +0000 (20:07 -0800)]
SimpleMessenger: init_local_connection whenever my_inst changes

This is necessary to correctly handle messages to self.

Signed-off-by: Samuel Just <sam.just@inktank.com>
11 years agoMerge pull request #1139 from ceph/wip-agent
Sage Weil [Mon, 17 Feb 2014 22:14:21 +0000 (14:14 -0800)]
Merge pull request #1139 from ceph/wip-agent

osd: basic cache tier agent

Reviewed-by: Samuel Just <sam.just@inktank.com>
11 years agoosd: improve whiteout debug prints 1139/head
Sage Weil [Mon, 17 Feb 2014 21:07:47 +0000 (13:07 -0800)]
osd: improve whiteout debug prints

Signed-off-by: Sage Weil <sage@inktank.com>
11 years agoosd/ReplicatedPG: make agent skip blocked obcs
Sage Weil [Mon, 17 Feb 2014 21:05:58 +0000 (13:05 -0800)]
osd/ReplicatedPG: make agent skip blocked obcs

Among other things, this can interfere with an in-flight copy-from and
corrupt the pg stats.

Signed-off-by: Sage Weil <sage@inktank.com>
11 years agoReplicatedBackend: print char ack_type as int
Sage Weil [Mon, 17 Feb 2014 16:45:46 +0000 (08:45 -0800)]
ReplicatedBackend: print char ack_type as int

Signed-off-by: Sage Weil <sage@inktank.com>
11 years agoMerge pull request #1254 from ceph/wip-barrier
Sage Weil [Mon, 17 Feb 2014 19:09:09 +0000 (11:09 -0800)]
Merge pull request #1254 from ceph/wip-barrier

libcephfs: disable barriers for now

11 years agoMerge remote-tracking branch 'gh/wip-7212-sage-b'
Sage Weil [Mon, 17 Feb 2014 19:07:55 +0000 (11:07 -0800)]
Merge remote-tracking branch 'gh/wip-7212-sage-b'

We should carefully backport some or all of this.

Backport: emperor, dumpling
Reviewed-by: Joao Eduardo Luis <joao.luis@inktank.com>
11 years agoclient: disable barrier support 1254/head
Sage Weil [Mon, 17 Feb 2014 18:27:23 +0000 (10:27 -0800)]
client: disable barrier support

The boost interval_set class is not available on centos6/rhel6.  Until that
dependency is sorted out, fix the build.

Signed-off-by: Sage Weil <sage@inktank.com>
11 years agoclient: fix barrier interval
Sage Weil [Mon, 17 Feb 2014 18:23:37 +0000 (10:23 -0800)]
client: fix barrier interval

(start, end) not (start, length)

Signed-off-by: Sage Weil <sage@inktank.com>
11 years agoclient/barrier: drop unused active_commit_interval
Sage Weil [Mon, 17 Feb 2014 17:19:17 +0000 (09:19 -0800)]
client/barrier: drop unused active_commit_interval

Signed-off-by: Sage Weil <sage@inktank.com>
11 years agoclient: don't populate Client::barriers from read accesses
Sage Weil [Mon, 17 Feb 2014 17:58:56 +0000 (09:58 -0800)]
client: don't populate Client::barriers from read accesses

If the entry doesn't exist, no need to create it.

Signed-off-by: Sage Weil <sage@inktank.com>
11 years agoqa/workunits/suites/pjd: use test suite with acl tweak
Sage Weil [Mon, 17 Feb 2014 06:25:49 +0000 (22:25 -0800)]
qa/workunits/suites/pjd: use test suite with acl tweak

Test 45 in xacl/00.t fails on ext4 and cephfs.  Just disable it.
Everything else passes.

Signed-off-by: Sage Weil <sage@inktank.com>
11 years agoosd/ReplicatedPG: allow is_degraded_object() to be called outside of backfil
Sage Weil [Mon, 17 Feb 2014 04:53:13 +0000 (20:53 -0800)]
osd/ReplicatedPG: allow is_degraded_object() to be called outside of backfil

The agent does this.

Signed-off-by: Sage Weil <sage@inktank.com>
11 years agoMerge pull request #1251 from ceph/wip-7371
Sage Weil [Sun, 16 Feb 2014 16:26:33 +0000 (08:26 -0800)]
Merge pull request #1251 from ceph/wip-7371

ReplicatedPG: return no data if read size is trimmed to zero

Backport: emperor, dumpling
Reviewed-by: Sage Weil <sage@inktank.com>
11 years agoReplicatedPG: return no data if read size is trimmed to zero 1251/head
Yan, Zheng [Sun, 16 Feb 2014 14:14:50 +0000 (22:14 +0800)]
ReplicatedPG: return no data if read size is trimmed to zero

OSD should return no data if the read size is trimmed to zero by the
truncate_seq/truncate_size check. We can't rely on ObjectStore::read()
to do that because it reads the entire object when the 'len' parameter
is zero.

Fixes: #7371
Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>
11 years agoMerge pull request #1223 from ceph/wip-7395
Sage Weil [Sun, 16 Feb 2014 06:36:23 +0000 (22:36 -0800)]
Merge pull request #1223 from ceph/wip-7395

Improve OSD subscription handling

Reviewed-by: Sage Weil <sage@inktank.com>
11 years agoMerge pull request #1234 from dachary/wip-format
Sage Weil [Sun, 16 Feb 2014 06:21:57 +0000 (22:21 -0800)]
Merge pull request #1234 from dachary/wip-format

mon: remove format argument from osd crush dump

Reviewed-by: Sage Weil <sage@inktank.com>
11 years agoosd: set client incarnation for Objecter instance
Sage Weil [Sun, 16 Feb 2014 01:22:30 +0000 (17:22 -0800)]
osd: set client incarnation for Objecter instance

Each ceph-osd process's Objecter instance has a sequence
of tid's that start at 1.  To ensure these are unique
across all time, set the client incarnation to the
OSDMap epoch in which we booted.

Note that the MDS does something similar (except the
incarnation is actually the restart count for the MDS
rank, since the MDSMap tracks that explicitly).

Backport: emperor
Signed-off-by: Sage Weil <sage@inktank.com>
11 years agoosd: schedule agent from a priority queue
Sage Weil [Wed, 12 Feb 2014 20:39:25 +0000 (12:39 -0800)]
osd: schedule agent from a priority queue

We need to focus agent attention on those PGs that most need it.  For
starters, full PGs need immediate attention so that we can unblock IO.
More generally, fuller ones will give us the best payoff in terms of
evicted data vs effort expended finding candidate objects.

Restructure the agent queue with priorities.  Quantize evict_effort so that
PGs do not jump between priorities too frequently.

Signed-off-by: Sage Weil <sage@inktank.com>
11 years agoosd/ReplicatedPG: simplify agent_choose_mode
Sage Weil [Wed, 12 Feb 2014 00:26:18 +0000 (16:26 -0800)]
osd/ReplicatedPG: simplify agent_choose_mode

Use a temp variable.

Signed-off-by: Sage Weil <sage@inktank.com>
11 years agoosd/ReplicatedPG: block requests to cache PGs when they are full
Sage Weil [Wed, 12 Feb 2014 00:25:51 +0000 (16:25 -0800)]
osd/ReplicatedPG: block requests to cache PGs when they are full

If we are full and get a write request to a new object, put the op on a
wait list.  Wake up when the agent frees up some space.

Note that we do not block writes to existing objects.  That would be a
more aggressive strategy, but it is difficult to know up front whether we
will increase the size of the object or not, so we just leave it be.  I
suspect this strategy is "good enough".

Also note that we do not yet prioritize agent attention to PGs that most
need eviction (e.g., those that are full).

Signed-off-by: Sage Weil <sage@inktank.com>
11 years agoosd/ReplicatedPG: redirect reads instead of promoting when full
Sage Weil [Tue, 11 Feb 2014 22:01:10 +0000 (14:01 -0800)]
osd/ReplicatedPG: redirect reads instead of promoting when full

If the cache pool is full, we are processing a read op, and we would
otherwise promote, redirect instead.  This lets us continue to process the
op without blocking or making the cache pool any more full than it is.

Signed-off-by: Sage Weil <sage@inktank.com>
11 years agoosd/ReplicatedPG: use reply_ctx in a few cases
Sage Weil [Tue, 11 Feb 2014 21:43:11 +0000 (13:43 -0800)]
osd/ReplicatedPG: use reply_ctx in a few cases

Signed-off-by: Sage Weil <sage@inktank.com>
11 years agoosd/ReplicatedPG: do not flush omap objects to an EC base pool
Sage Weil [Sat, 8 Feb 2014 02:05:04 +0000 (18:05 -0800)]
osd/ReplicatedPG: do not flush omap objects to an EC base pool

The EC pool does not support omap content.  If the caching/tiering agent
encounters such an object, just skip it.  Use the OMAP object_info_t flag
for this.

Although legacy pools will have objects with omap that do not have this
flag set, no *cache* pools yet exist, so we do not need to worry about the
agent running across legacy content.

Signed-off-by: Sage Weil <sage@inktank.com>
11 years agoosd/ReplicatedPG: do not activate agent unless base pool exists
Sage Weil [Sat, 8 Feb 2014 02:03:41 +0000 (18:03 -0800)]
osd/ReplicatedPG: do not activate agent unless base pool exists

Paranoia.

Signed-off-by: Sage Weil <sage@inktank.com>
11 years agoosd: add OMAP flag to object_info_t
Sage Weil [Sat, 8 Feb 2014 02:03:19 +0000 (18:03 -0800)]
osd: add OMAP flag to object_info_t

Set a flag if we ever set or update OMAP content on an object.  This gives
us an easy indicator for the cache agent (without actually querying the
ObjectStore) so that we can avoid trying to flush omap to EC pools.

Signed-off-by: Sage Weil <sage@inktank.com>
11 years agoosd/ReplicatedPG: ignore starvation potential when taking write lock during promote
Sage Weil [Mon, 3 Feb 2014 19:44:18 +0000 (11:44 -0800)]
osd/ReplicatedPG: ignore starvation potential when taking write lock during promote

Signed-off-by: Sage Weil <sage@inktank.com>
11 years agoosd/ReplicatedPG: do not choke on op-less flush OpContexts (from flush)
Sage Weil [Mon, 3 Feb 2014 01:11:23 +0000 (17:11 -0800)]
osd/ReplicatedPG: do not choke on op-less flush OpContexts (from flush)

The agent initiates flush ops that don't have an OpRequest associated
with them.  Make reply_ctx skip the actual reply message instead of
crashing if the flush request gets canceled (e.g., due to a race with
a write).

Signed-off-by: Sage Weil <sage@inktank.com>
11 years agoosd/ReplicatedPG: do not flush|evict degraded objects
Sage Weil [Sun, 2 Feb 2014 05:48:07 +0000 (21:48 -0800)]
osd/ReplicatedPG: do not flush|evict degraded objects

The repop won't work right; we still repair the object before making
any update.

Signed-off-by: Sage Weil <sage@inktank.com>
11 years agoceph_test_rados_api_tier: fix osd pool set json syntax
Sage Weil [Sun, 2 Feb 2014 05:26:00 +0000 (21:26 -0800)]
ceph_test_rados_api_tier: fix osd pool set json syntax

String, not int.

Signed-off-by: Sage Weil <sage@inktank.com>
11 years agoosd: clear agent state when PG becomes a replica
Sage Weil [Sat, 1 Feb 2014 05:16:54 +0000 (21:16 -0800)]
osd: clear agent state when PG becomes a replica

Signed-off-by: Sage Weil <sage@inktank.com>
11 years agoosd/ReplicatedPG: do not flush or evict hitsets
Sage Weil [Thu, 30 Jan 2014 18:40:22 +0000 (10:40 -0800)]
osd/ReplicatedPG: do not flush or evict hitsets

Signed-off-by: Sage Weil <sage@inktank.com>
11 years agoosd/ReplicatedPG: fix evict mode selection for large target
Sage Weil [Tue, 28 Jan 2014 02:14:09 +0000 (18:14 -0800)]
osd/ReplicatedPG: fix evict mode selection for large target

If the target is > 1.0 for some reason (bad configuration, or high slop
value), and we are not yet full, we should be in IDLE mode--not SOME.

Signed-off-by: Sage Weil <sage@inktank.com>
11 years agoosd/ReplicatedPG: add slop to agent mode selection
Sage Weil [Tue, 28 Jan 2014 01:57:53 +0000 (17:57 -0800)]
osd/ReplicatedPG: add slop to agent mode selection

We want to avoid a situation where the agent clicks on and off when the
system hovers around a utilization threshold.  Particularly for trim,
the system can expend a lot of energy doing a minimal amount of work when
the effort level is low.  To avoid this, enable when we are some amount
above the threshold, and do not turn off until we are the same amount below
the target.

Signed-off-by: Sage Weil <sage@inktank.com>
11 years agoosd/ReplicatedPG: initial agent to random hash position inside pg
Sage Weil [Tue, 28 Jan 2014 00:26:19 +0000 (16:26 -0800)]
osd/ReplicatedPG: initial agent to random hash position inside pg

When the agent starts, start at a random offset to ensure we get a more
uniform distribution of attention to all objects in the PG.  Otherwise, we
will disproportionately examine objects at the "beginning" of the PG if we
are interrupted by peering or restarts or some other activity.

Note that if the agent_state is preserved, we do not forget our position,
which is also nice.

We *could* persist this position in the pg_info_t somewhere, but I am not
sure it is worth the effort.

Signed-off-by: Sage Weil <sage@inktank.com>
11 years agoosd: add pg_pool_t::get_random_pg_position()
Sage Weil [Tue, 28 Jan 2014 00:20:04 +0000 (16:20 -0800)]
osd: add pg_pool_t::get_random_pg_position()

Return a hash position somewhere inside a given pg.

Signed-off-by: Sage Weil <sage@inktank.com>
11 years agoosd: only enable tier agent when osd is in active state
Sage Weil [Mon, 27 Jan 2014 23:34:50 +0000 (15:34 -0800)]
osd: only enable tier agent when osd is in active state

Signed-off-by: Sage Weil <sage@inktank.com>
11 years agoosd: observe 'notieragent' osdmap flag
Sage Weil [Mon, 27 Jan 2014 23:30:28 +0000 (15:30 -0800)]
osd: observe 'notieragent' osdmap flag

Pause/unpause the agent thread accordingly.

Signed-off-by: Sage Weil <sage@inktank.com>
11 years agoosd: add 'notieragent' flag to OSDMap
Sage Weil [Mon, 27 Jan 2014 23:30:09 +0000 (15:30 -0800)]
osd: add 'notieragent' flag to OSDMap

This will pause tiering agent work.

Signed-off-by: Sage Weil <sage@inktank.com>
11 years agohistogram: fix histogram::get_position_micro overflow
Loic Dachary [Mon, 27 Jan 2014 13:20:25 +0000 (14:20 +0100)]
histogram: fix histogram::get_position_micro overflow

Convert the return values to uint64_t

Signed-off-by: Loic Dachary <loic@dachary.org>
11 years agomon: test dirty stats in ceph df detail
Loic Dachary [Mon, 27 Jan 2014 15:47:33 +0000 (16:47 +0100)]
mon: test dirty stats in ceph df detail

Signed-off-by: Loic Dachary <loic@dachary.org>
11 years agoosd/ReplicatedPG: decay tier agent histograms over time
Sage Weil [Fri, 24 Jan 2014 22:57:02 +0000 (14:57 -0800)]
osd/ReplicatedPG: decay tier agent histograms over time

Make decisions based on recent observations of object age distributions,
not all time history.

Signed-off-by: Sage Weil <sage@inktank.com>
11 years agoosd/ReplicatedPG: basic flush and evict agent functionality
Sage Weil [Fri, 24 Jan 2014 22:35:41 +0000 (14:35 -0800)]
osd/ReplicatedPG: basic flush and evict agent functionality

This is very basic flush and evict functionality for the tiering agent.

The flush policy is very simple: if we are above the threshold and the
object is dirty, and not super young, flush it.  This is not too braindead
of a policy (although we could clearly do something smarter).

The evict policy is pretty simple: evict the object if it is clean and
we are over our full threshold.  If we are in the middle mode, try to
estimate how cold the object is based on an accumulated histogram of
objects we have examined so far, and decide to evict based on our
position in that histogram relative to our "effort" level.

Caveats:
 * the histograms are not refreshed
 * we aren't taking temperature into consideration yet, although some of
   the infrastructure is there.

Signed-off-by: Sage Weil <sage@inktank.com>
11 years agoosd: agent worker thread
Sage Weil [Mon, 20 Jan 2014 21:51:45 +0000 (13:51 -0800)]
osd: agent worker thread

Signed-off-by: Sage Weil <sage@inktank.com>
11 years agoosd/ReplicatedPG: fix finish_flush
Sage Weil [Sat, 8 Feb 2014 02:10:00 +0000 (18:10 -0800)]
osd/ReplicatedPG: fix finish_flush

Make sure we reallocate a pgbackend transaction at the time when we are
initiating new work.

Signed-off-by: Sage Weil <sage@inktank.com>
11 years agoosd/HitSet: add HitSetRef
Sage Weil [Fri, 24 Jan 2014 22:18:49 +0000 (14:18 -0800)]
osd/HitSet: add HitSetRef

Signed-off-by: Sage Weil <sage@inktank.com>
11 years agoosd/ReplicatedPG: factor clone check out of evict op code
Sage Weil [Mon, 20 Jan 2014 22:30:48 +0000 (14:30 -0800)]
osd/ReplicatedPG: factor clone check out of evict op code

Move the check for clones into a helper so that we will be able to use in
other places where we need to evict.

Signed-off-by: Sage Weil <sage@inktank.com>
11 years agoosd/ReplicatedPG: add on_finish to OpContext
Sage Weil [Tue, 4 Feb 2014 06:10:07 +0000 (22:10 -0800)]
osd/ReplicatedPG: add on_finish to OpContext

Add a callback hook for whenever an OpContext completes or cancels.  We
are pretty sloppy here about the return values because our initial user
will not care, and it is unclear if future users will.

Signed-off-by: Sage Weil <sage@inktank.com>
11 years agomon: include dirty stats in 'ceph df detail'
Sage Weil [Mon, 20 Jan 2014 21:47:08 +0000 (13:47 -0800)]
mon: include dirty stats in 'ceph df detail'

Signed-off-by: Sage Weil <sage@inktank.com>