]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
4 years agoMerge pull request #37594 from trociny/wip-rbd-quiesce-cancel
Jason Dillaman [Wed, 14 Oct 2020 13:59:58 +0000 (09:59 -0400)]
Merge pull request #37594 from trociny/wip-rbd-quiesce-cancel

librbd: fix race on watcher unregister

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #37650 from jschmid1/gs
Joshua Schmid [Wed, 14 Oct 2020 12:45:27 +0000 (14:45 +0200)]
Merge pull request #37650 from jschmid1/gs

mgr/cephadm: adapt <placement> usage string

4 years agoMerge pull request #37394 from rosinL/cleanup-queue-option
Kefu Chai [Wed, 14 Oct 2020 08:08:04 +0000 (16:08 +0800)]
Merge pull request #37394 from rosinL/cleanup-queue-option

common/options: remove unavailable values of osd_op_queue

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #37627 from changchengx/msg
Kefu Chai [Wed, 14 Oct 2020 08:05:51 +0000 (16:05 +0800)]
Merge pull request #37627 from changchengx/msg

msg: remove stale comment and unnecessary code

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #37626 from tchaikov/wip-drop-std-iterator
Kefu Chai [Wed, 14 Oct 2020 08:04:14 +0000 (16:04 +0800)]
Merge pull request #37626 from tchaikov/wip-drop-std-iterator

include/interval_set: do not inherit from std::iterator

Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>
4 years agoMerge pull request #37455 from smithfarm/wip-spec-file-cleanup
Kefu Chai [Wed, 14 Oct 2020 07:43:30 +0000 (15:43 +0800)]
Merge pull request #37455 from smithfarm/wip-spec-file-cleanup

rpm: three spec file cleanups

Reviewed-by: Tim Serong <tserong@suse.com>
4 years agoMerge PR #37583 into master
Patrick Donnelly [Tue, 13 Oct 2020 17:27:02 +0000 (10:27 -0700)]
Merge PR #37583 into master

* refs/pull/37583/head:
mgr/volumes/nfs: Fix wrong error message for pseudo path

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #37585 into master
Patrick Donnelly [Tue, 13 Oct 2020 17:26:02 +0000 (10:26 -0700)]
Merge PR #37585 into master

* refs/pull/37585/head:
doc/cephfs/nfs: Remove outdated doc related to rook

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge pull request #37610 from anthonyeleven/doc-rados-troubleshooting
zdover23 [Tue, 13 Oct 2020 16:32:24 +0000 (02:32 +1000)]
Merge pull request #37610 from anthonyeleven/doc-rados-troubleshooting

doc/rados/troubleshooting: clarity and modernization

Reviewed-by: Zac Dover <zac.dover@gmail.com>
4 years agoMerge PR #36537 into master
Patrick Donnelly [Tue, 13 Oct 2020 16:29:04 +0000 (09:29 -0700)]
Merge PR #36537 into master

* refs/pull/36537/head:
qa/cephfs: update ephemeral pin tests
mds: distribute dirfrags for ephemeral distributed directory

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoqa/cephfs: update ephemeral pin tests 36537/head
Yan, Zheng [Wed, 12 Aug 2020 06:49:15 +0000 (14:49 +0800)]
qa/cephfs: update ephemeral pin tests

Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
4 years agomds: distribute dirfrags for ephemeral distributed directory
Yan, Zheng [Fri, 7 Aug 2020 15:58:19 +0000 (23:58 +0800)]
mds: distribute dirfrags for ephemeral distributed directory

Instead of distribute individual dir inodes inside the ephemeral
distributed dir. Distributing dirfrags can limit number of subtrees
created by the ephemeral dist pin.

This patch also unifies codes that handle export pin and ephemeral pin.

Fixes: https://tracker.ceph.com/issues/46696
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
4 years agomgr/cephadm: adapt <placement> usage string 37650/head
Joshua Schmid [Tue, 13 Oct 2020 10:48:32 +0000 (12:48 +0200)]
mgr/cephadm: adapt <placement> usage string

Signed-off-by: Joshua Schmid <jschmid@suse.de>
4 years agoMerge pull request #35477 from yuvalif/add_lua_to_rgw
Yuval Lifshitz [Tue, 13 Oct 2020 09:42:48 +0000 (12:42 +0300)]
Merge pull request #35477 from yuvalif/add_lua_to_rgw

rgw/lua: embedding lua in rgw in s3 request context

4 years agoMerge pull request #37581 from dillaman/wip-librbd-exclusive-lock-shutdown
Mykola Golub [Tue, 13 Oct 2020 07:44:58 +0000 (10:44 +0300)]
Merge pull request #37581 from dillaman/wip-librbd-exclusive-lock-shutdown

librbd: avoid failing IO with -ESHUTDOWN when disabling exclusive-lock

Reviewed-by: Mykola Golub <mgolub@suse.com>
4 years agoMerge pull request #37613 from tchaikov/wip-cls-osd-cleanup
Kefu Chai [Tue, 13 Oct 2020 06:23:29 +0000 (14:23 +0800)]
Merge pull request #37613 from tchaikov/wip-cls-osd-cleanup

cls, osd: cleanups

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
4 years agoMerge pull request #37537 from yuvalif/missing_brackets_in_rgw_file
Yuval Lifshitz [Tue, 13 Oct 2020 05:06:31 +0000 (08:06 +0300)]
Merge pull request #37537 from yuvalif/missing_brackets_in_rgw_file

rgw/file: missing brackets around if statement

4 years agoMerge pull request #37538 from yuvalif/potential_crash_in_kafka
Yuval Lifshitz [Tue, 13 Oct 2020 05:04:18 +0000 (08:04 +0300)]
Merge pull request #37538 from yuvalif/potential_crash_in_kafka

fix potential crash in rgw_kafka

4 years agoMerge pull request #37599 from yuvalif/remove_doxyfile
Yuval Lifshitz [Tue, 13 Oct 2020 05:03:39 +0000 (08:03 +0300)]
Merge pull request #37599 from yuvalif/remove_doxyfile

cmake: remove Doxyfile as doxygen run via make

4 years agoMerge pull request #37534 from yuvalif/fix_ownership_in_role_applier
Yuval Lifshitz [Tue, 13 Oct 2020 05:02:40 +0000 (08:02 +0300)]
Merge pull request #37534 from yuvalif/fix_ownership_in_role_applier

 rgw/auth: fix copy&paste bug in RoleApplier::is_owner_of

4 years agoMerge PR #29951 into master
Patrick Donnelly [Tue, 13 Oct 2020 01:50:33 +0000 (18:50 -0700)]
Merge PR #29951 into master

* refs/pull/29951/head:
test: add tests for validating MDS metrics via `perf stats` module
test: Filesystem class helpers to grow and shrink MDS cluster
mgr/stats: mds performance stats module
mds: support sending empty perf metrics to ceph-manager

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge pull request #37541 from anthonyeleven/osd-internals-tweaks
zdover23 [Mon, 12 Oct 2020 20:01:05 +0000 (06:01 +1000)]
Merge pull request #37541 from anthonyeleven/osd-internals-tweaks

doc/dev: doc/dev/osd_internals capitalization, formatting, clarity

Reviewed-by: Zac Dover <zac.dover@gmail.com>
4 years agorgw/lua: run lua scripts in s3 requests context 35477/head
Yuval Lifshitz [Mon, 8 Jun 2020 12:26:47 +0000 (15:26 +0300)]
rgw/lua: run lua scripts in s3 requests context

for more details on design and
remaining work see:
https://gist.github.com/yuvalif/60d5984c28af89ba17443ce947540c1f

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
4 years agodoc/rados/troubleshooting: clarity and modernization 37610/head
Anthony D'Atri [Fri, 9 Oct 2020 03:54:43 +0000 (20:54 -0700)]
doc/rados/troubleshooting: clarity and modernization

Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>
4 years agoMerge PR #37593 into master
Patrick Donnelly [Mon, 12 Oct 2020 14:42:13 +0000 (07:42 -0700)]
Merge PR #37593 into master

* refs/pull/37593/head:
qa/tasks/cephfs: Refactor test_volumes

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge pull request #37154 from bk201/wip-47397
Tatjana Dehler [Mon, 12 Oct 2020 12:32:39 +0000 (14:32 +0200)]
Merge pull request #37154 from bk201/wip-47397

mgr/dashboard: fix the error when exporting CephFS path "/" in NFS exports

Reviewed-by: Laura Paduano lpaduano@suse.com
Reviewed-by: Stephan Müller smueller@suse.com
Reviewed-by: Varsha Rao varao@redhat.com
4 years agotest: add tests for validating MDS metrics via `perf stats` module 29951/head
Venky Shankar [Tue, 10 Sep 2019 12:57:07 +0000 (08:57 -0400)]
test: add tests for validating MDS metrics via `perf stats` module

Fixes: http://tracker.ceph.com/issues/24285
Signed-off-by: Venky Shankar <vshankar@redhat.com>
4 years agotest: Filesystem class helpers to grow and shrink MDS cluster
Venky Shankar [Thu, 29 Aug 2019 05:24:10 +0000 (01:24 -0400)]
test: Filesystem class helpers to grow and shrink MDS cluster

These routines were test specific. Make them a part of Filesystem
class.

Signed-off-by: Venky Shankar <vshankar@redhat.com>
4 years agomgr/stats: mds performance stats module
Venky Shankar [Mon, 26 Aug 2019 09:32:23 +0000 (05:32 -0400)]
mgr/stats: mds performance stats module

Signed-off-by: Venky Shankar <vshankar@redhat.com>
4 years agomds: support sending empty perf metrics to ceph-manager
Venky Shankar [Fri, 24 Jul 2020 04:45:55 +0000 (00:45 -0400)]
mds: support sending empty perf metrics to ceph-manager

Right now, there are no per-mds metrics that are tracked and
sent by mds. However, such metrics will get added soon. So,
send empty performance metrics to ceph-manager for now.

Signed-off-by: Venky Shankar <vshankar@redhat.com>
4 years agoqa/tasks/cephfs: Refactor test_volumes 37593/head
Ramana Raja [Tue, 8 Sep 2020 18:31:00 +0000 (00:01 +0530)]
qa/tasks/cephfs: Refactor test_volumes

... into smaller test classes. This enables breaking up the volumes yaml
into smaller yaml fragments.

Fixes: https://tracker.ceph.com/issues/47160
Signed-off-by: Ramana Raja <rraja@redhat.com>
4 years agoMerge pull request #37628 from changchengx/mail_update
Kefu Chai [Mon, 12 Oct 2020 07:43:30 +0000 (15:43 +0800)]
Merge pull request #37628 from changchengx/mail_update

mailmap: update Intel employee mail/org

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agomsg: remove unnecessary assignment 37627/head
Changcheng Liu [Mon, 12 Oct 2020 02:58:40 +0000 (10:58 +0800)]
msg: remove unnecessary assignment

memset(&header, 0, sizeof(header)) clear the variable to
be 0.

Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>
4 years agomsg: remove outdated comments
Changcheng Liu [Mon, 12 Oct 2020 01:17:54 +0000 (09:17 +0800)]
msg: remove outdated comments

Parameter "features" has been removed in commit 0dbe8fd3987d.

Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>
4 years agomailmap: update Intel employee mail/org 37628/head
Changcheng Liu [Wed, 23 Sep 2020 07:39:47 +0000 (15:39 +0800)]
mailmap: update Intel employee mail/org

1. "changcheng.liu@aliyun.com" need be classified into intel until now.
   This reverts part of commit: df07e9f3
2. add "Yuan Lu <yuan.y.lu@intel.com>" in mailmap

Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>
4 years agoMerge pull request #36942 from rosinL/wip-fix-librgw
Matt Benjamin [Sun, 11 Oct 2020 15:14:06 +0000 (11:14 -0400)]
Merge pull request #36942 from rosinL/wip-fix-librgw

rgw/rgw_file: Fix the incorrect lru object eviction

4 years agorgw/file: add missing brackets around if statement 37537/head
Yuval Lifshitz [Sun, 4 Oct 2020 13:04:45 +0000 (16:04 +0300)]
rgw/file: add missing brackets around if statement

also some small style issues
issues were detected by pvs-studio static analyzer

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
4 years agoinclude/interval_set: do not inherit from std::iterator 37626/head
Kefu Chai [Sat, 10 Oct 2020 12:56:21 +0000 (20:56 +0800)]
include/interval_set: do not inherit from std::iterator

std::iterator is deprecated in C++17, so drop it.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #37580 from aclamk/wip-bluestore-fix-2q-cache
Kefu Chai [Sat, 10 Oct 2020 11:42:11 +0000 (19:42 +0800)]
Merge pull request #37580 from aclamk/wip-bluestore-fix-2q-cache

os/bluestore: fix memory accounting in TwoQBufferCacheShard

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
4 years agoMerge pull request #37325 from badone/wip-angular-cli-analytics-dont-prompt
Kefu Chai [Sat, 10 Oct 2020 11:41:07 +0000 (19:41 +0800)]
Merge pull request #37325 from badone/wip-angular-cli-analytics-dont-prompt

mgr/dashboard: Don't prompt for analytics during @angular/cli install

Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
4 years agoMerge pull request #37542 from SUSE/wip-fix-47745
Kefu Chai [Sat, 10 Oct 2020 11:38:33 +0000 (19:38 +0800)]
Merge pull request #37542 from SUSE/wip-fix-47745

cephadm: allow uid/gid == 0 in copy_tree, copy_files, move_files

Reviewed-by: Michael Fritch <mfritch@suse.com>
4 years agoMerge pull request #37559 from wjwithagen/wjw-fix-iterator
Kefu Chai [Sat, 10 Oct 2020 11:37:16 +0000 (19:37 +0800)]
Merge pull request #37559 from wjwithagen/wjw-fix-iterator

include: explicitly define all types needed for libc++ iterator

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #37104 from sebastian-philipp/cephadm-serve.py-2
Kefu Chai [Sat, 10 Oct 2020 11:35:48 +0000 (19:35 +0800)]
Merge pull request #37104 from sebastian-philipp/cephadm-serve.py-2

mgr/cephadm: move functions that do remote calls to serve.py

Reviewed-by: Michael Fritch <mfritch@suse.com>
4 years agoMerge PR #37441 into master
Patrick Donnelly [Sat, 10 Oct 2020 01:41:24 +0000 (18:41 -0700)]
Merge PR #37441 into master

* refs/pull/37441/head:
qa: fix proc exit status check

Reviewed-by: Jos Collin <jcollin@redhat.com>
4 years agocommon/options: remove unavailable values of osd_op_queue 37394/head
luo rixin [Thu, 24 Sep 2020 13:17:36 +0000 (21:17 +0800)]
common/options: remove unavailable values of osd_op_queue

Signed-off-by: luo rixin <luorixin@huawei.com>
4 years agoMerge pull request #36979 from tspmelo/wip-npm-update-20-8
Lenz Grimmer [Fri, 9 Oct 2020 13:56:00 +0000 (15:56 +0200)]
Merge pull request #36979 from tspmelo/wip-npm-update-20-8

mgr/dashboard: Update npm packages

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
4 years agorgw/rgw_file: Fix the incorrect lru object eviction 36942/head
luo rixin [Tue, 1 Sep 2020 09:06:40 +0000 (17:06 +0800)]
rgw/rgw_file: Fix the incorrect lru object eviction

In func lookup_fh, when RGWFileHandle not be found in fh_cache, it
need to recycle an object and create an new RGWFileHandle. When there
are multi threads use lookup_fh to find and create RGWFileHandle concurrently,
it must to make sure evict lru object from the partiton of fh_cache which new
RGWFileHandle will be inserted to.

Fixes: https://tracker.ceph.com/issues/47235
Signed-off-by: luo rixin <luorixin@huawei.com>
4 years agoMerge pull request #37449 from ceph/47676-zone-empty-realm-id
Lenz Grimmer [Fri, 9 Oct 2020 12:32:10 +0000 (14:32 +0200)]
Merge pull request #37449 from ceph/47676-zone-empty-realm-id

mgr/dashboard: get rgw daemon zonegroup name from mgr

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
4 years agoMerge pull request #37375 from ceph/47615-fix-endpoint-responses
Lenz Grimmer [Fri, 9 Oct 2020 11:43:52 +0000 (13:43 +0200)]
Merge pull request #37375 from ceph/47615-fix-endpoint-responses

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
4 years agoMerge pull request #37064 from bk201/wip-47372
Lenz Grimmer [Fri, 9 Oct 2020 11:42:30 +0000 (13:42 +0200)]
Merge pull request #37064 from bk201/wip-47372

mgr/dashboard: fix error when typing existing paths in the Ganesha form

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
4 years agoMerge pull request #37596 from rhcs-dashboard/telemetry_link_cleanup
Lenz Grimmer [Fri, 9 Oct 2020 11:40:32 +0000 (13:40 +0200)]
Merge pull request #37596 from rhcs-dashboard/telemetry_link_cleanup

mgr/dashboard: Improve HTML formatting of the telemetry report preview

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
4 years agodoc/cephfs/nfs: Remove outdated doc related to rook 37585/head
Varsha Rao [Wed, 7 Oct 2020 17:17:20 +0000 (22:47 +0530)]
doc/cephfs/nfs: Remove outdated doc related to rook

The doc is outdated because the mentioned orch commands have changed[1] and
using dashboard backend script to create exports is buggy[2].

[1] https://docs.ceph.com/en/latest/mgr/orchestrator/#current-implementation-status
[2] https://github.com/rook/rook/issues/6147

Fixes: https://tracker.ceph.com/issues/47784
Signed-off-by: Varsha Rao <varao@redhat.com>
4 years agomgr/dashboard: Update npm packages 36979/head
Tiago Melo [Mon, 24 Aug 2020 13:47:37 +0000 (13:47 +0000)]
mgr/dashboard: Update npm packages

Angular 10.1 includes extraction of TS translations,
so @locl/cli is no longer needed.

Updating Angular automatically removed the usage of base tsconfig.

Downgraded css-loader to be able to use css modules.

angular-tree-component has been deprecated and
replaced by @circlon/angular-tree-component

Fixes: https://tracker.ceph.com/issues/47289
Signed-off-by: Tiago Melo <tmelo@suse.com>
4 years agoMerge PR #32778 into master
Jan Fajerski [Fri, 9 Oct 2020 09:22:01 +0000 (11:22 +0200)]
Merge PR #32778 into master

* refs/pull/32778/head:
msg: Use sockets instead of pipes for wakeup events on win32
common: Convert remote errors on win32
common,msg: Initialize Windows WSA and TLS
common,os,kv: Define aligned_free
common: avoid CLOCK_*_COARSE warnings on win32
global: Windows support

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agoosd/OSD: remove unused #include 37613/head
Kefu Chai [Fri, 9 Oct 2020 07:58:06 +0000 (15:58 +0800)]
osd/OSD: remove unused #include

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocls/fifo: cast ceph_le64 to uint64_t before printing it
Kefu Chai [Fri, 9 Oct 2020 07:54:35 +0000 (15:54 +0800)]
cls/fifo: cast ceph_le64 to uint64_t before printing it

silences warning like:

../src/cls/fifo/cls_fifo.cc: In member function ‘int rados::cls::fifo::{anonymous}::EntryReader::get_next_entry(ceph::buffer::v15_2_0::list*, uint64_t*, ceph::real_time*)’:
../src/include/rados/objclass.h:33:18: warning: format ‘%llu’ expects argument of type ‘long long unsigned int’, but argument 7 has type ‘ceph_le64’ {aka ‘ceph_le<long long unsigned int>’} [-Wformat=]
   33 |   cls_log(level, "<cls> %s:%d: " fmt, __FILE__, __LINE__, ##__VA_ARGS__)
../src/include/rados/objclass.h:33:18: note: in definition of macro ‘CLS_LOG’
   33 |   cls_log(level, "<cls> %s:%d: " fmt, __FILE__, __LINE__, ##__VA_ARGS__)
      |                  ^~~~~~~~~~~~~~~
../src/cls/fifo/cls_fifo.cc:703:48: note: format string is defined here
  703 |   CLS_LOG(10, "%s():%d: pre_header.pre_size=%llu", __func__, __LINE__,
      |                                             ~~~^
      |                                                |
      |                                                long long unsigned int

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge PR #36554 into master
Patrick Donnelly [Thu, 8 Oct 2020 20:25:15 +0000 (13:25 -0700)]
Merge PR #36554 into master

* refs/pull/36554/head:
mgr/volumes: Make number of cloner threads configurable

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Shyamsundar R <srangana@redhat.com>
4 years agoMerge PR #36457 into master
Patrick Donnelly [Thu, 8 Oct 2020 20:23:34 +0000 (13:23 -0700)]
Merge PR #36457 into master

* refs/pull/36457/head:
qa/tasks/cephfs: fix fs authorize cmd args
mds: add root_squash mode in MDS auth caps
vstart_runner: add write_file and sudo_write_file

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #36556 into master
Patrick Donnelly [Thu, 8 Oct 2020 19:43:39 +0000 (12:43 -0700)]
Merge PR #36556 into master

* refs/pull/36556/head:
doc: cephfs mirroring design document

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge pull request #37483 from dzafman/wip-46405
Neha Ojha [Thu, 8 Oct 2020 18:44:00 +0000 (11:44 -0700)]
Merge pull request #37483 from dzafman/wip-46405

osd/osd-rep-recov-eio.sh: TEST_rados_repair_warning:  return 1

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agoMerge pull request #37500 from ricardoasmarques/fix-bootstrap-container-init
Nathan Cutler [Thu, 8 Oct 2020 18:04:02 +0000 (20:04 +0200)]
Merge pull request #37500 from ricardoasmarques/fix-bootstrap-container-init

cephadm: Fix error setting 'mgr/cephadm/container_init' config

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Joshua Schmid <jschmid@suse.de>
Reviewed-by: Nathan Cutler <ncutler@suse.com>
4 years agolibrbd: fix race on watcher unregister 37594/head
Mykola Golub [Thu, 8 Oct 2020 17:12:11 +0000 (18:12 +0100)]
librbd: fix race on watcher unregister

It was possible that "unregister_watch" would get stuck forever
in "m_async_op_tracker.wait_for_ops", waiting for unqueiesce
notifications to complete, which had been already canceled
when "unregister" called "TaskFinisher::cancel_all".

Signed-off-by: Mykola Golub <mgolub@suse.com>
4 years agoMerge pull request #37582 from ivancich/wip-fix-bucket-list-namespace
J. Eric Ivancich [Thu, 8 Oct 2020 17:01:36 +0000 (13:01 -0400)]
Merge pull request #37582 from ivancich/wip-fix-bucket-list-namespace

rgw: fix setting of namespace in ordered and unordered bucket listing

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
4 years agoMerge pull request #37572 from ivancich/wip-orphan-list-namespace-locator
J. Eric Ivancich [Thu, 8 Oct 2020 17:00:51 +0000 (13:00 -0400)]
Merge pull request #37572 from ivancich/wip-orphan-list-namespace-locator

rgw: allow rgw-orphan-list to note when rados objects are in namespace

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
4 years agoMerge pull request #37511 from ivancich/wip-paginate-rgw-bucket-list
J. Eric Ivancich [Thu, 8 Oct 2020 16:59:55 +0000 (12:59 -0400)]
Merge pull request #37511 from ivancich/wip-paginate-rgw-bucket-list

rgw: radosgw-admin should paginate internally when listing bucket

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Reviewed-By: Abhishek Lekshmanan <abhishek@suse.com>
4 years agobuild/doc: remove Doxyfile as doxygen run via make 37599/head
Yuval Lifshitz [Thu, 8 Oct 2020 13:58:14 +0000 (16:58 +0300)]
build/doc: remove Doxyfile as doxygen run via make

also update document doxygen behavior
this is to complete: https://github.com/ceph/ceph/pull/35027

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
4 years agomgr/dashboard: Improve HTML formatting of the telemetry report preview 37596/head
Nizamudeen A [Thu, 8 Oct 2020 11:50:34 +0000 (17:20 +0530)]
mgr/dashboard: Improve HTML formatting of the telemetry report preview

Convert the string "Community Data License Agreement - Sharing - Version 1.0" to a clickable link

Fixes: https://tracker.ceph.com/issues/47790
Signed-off-by: Nizamudeen A <nia@redhat.com>
4 years agoMerge pull request #37584 from rhcs-dashboard/report-preview-helper
Lenz Grimmer [Thu, 8 Oct 2020 11:15:58 +0000 (13:15 +0200)]
Merge pull request #37584 from rhcs-dashboard/report-preview-helper

mgr/dashboard: Add short descriptions to the telemetry report preview

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
4 years agoMerge PR #37591 into master
Jan Fajerski [Thu, 8 Oct 2020 09:52:56 +0000 (11:52 +0200)]
Merge PR #37591 into master

* refs/pull/37591/head:
ceph-volume: don't exit before empty report can be printed

Reviewed-by: Joshua Schmid <jschmid@suse.de>
4 years agodoc: cephfs mirroring design document 36556/head
Venky Shankar [Mon, 28 Sep 2020 11:41:59 +0000 (17:11 +0530)]
doc: cephfs mirroring design document

Signed-off-by: Venky Shankar <vshankar@redhat.com>
4 years agoceph-volume: don't exit before empty report can be printed 37591/head
Jan Fajerski [Thu, 8 Oct 2020 06:45:26 +0000 (08:45 +0200)]
ceph-volume: don't exit before empty report can be printed

get_plan() called exit in case of an empty plan. This prevented a report
being printed under these circumstances. Avoid exit in this case. Also
adds tests to ensure an empty report is printed.

Fixes: https://tracker.ceph.com/issues/47760
Signed-off-by: Jan Fajerski <jfajerski@suse.com>
4 years agoMerge pull request #37561 from tchaikov/wip-cmake-node-mirror
Kefu Chai [Thu, 8 Oct 2020 06:50:30 +0000 (14:50 +0800)]
Merge pull request #37561 from tchaikov/wip-cmake-node-mirror

cmake: support Node.js and npm registry mirror

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
4 years agoMerge pull request #37570 from ceph/wip-install-ceph-deploy
Josh Durgin [Thu, 8 Oct 2020 00:56:22 +0000 (17:56 -0700)]
Merge pull request #37570 from ceph/wip-install-ceph-deploy

doc: add a link to ceph-deploy document

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Zac Dover <zac.dover@gmail.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agoMerge PR #37446 into master
Patrick Donnelly [Wed, 7 Oct 2020 20:35:18 +0000 (13:35 -0700)]
Merge PR #37446 into master

* refs/pull/37446/head:
mds: remove dead mdsmap broadcast code

Reviewed-by: Jos Collin <jcollin@redhat.com>
4 years agoMerge PR #37497 into master
Patrick Donnelly [Wed, 7 Oct 2020 19:39:04 +0000 (12:39 -0700)]
Merge PR #37497 into master

* refs/pull/37497/head:
client,mds: Drop execute permission bits

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #37571 into master
Patrick Donnelly [Wed, 7 Oct 2020 19:38:04 +0000 (12:38 -0700)]
Merge PR #37571 into master

* refs/pull/37571/head:
qa/tasks/cephfs/nfs: Check ganesha daemon status after restarting mgr

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #37579 into master
Patrick Donnelly [Wed, 7 Oct 2020 19:29:03 +0000 (12:29 -0700)]
Merge PR #37579 into master

* refs/pull/37579/head:
SubmittingPatches: use "doc" prefix in title of doc-only commits

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agomgr/dashboard: Add short descriptions to the telemetry report preview 37584/head
Nizamudeen A [Wed, 7 Oct 2020 17:21:10 +0000 (22:51 +0530)]
mgr/dashboard: Add short descriptions to the telemetry report preview

A small info icon with a popover on the telemetry report preview form step2 for
Report ID and Report Preview.

Report ID: "A randomized UUID to identify a particular cluster over the course of several telemetry reports."
Report preview: "The actual telemetry data that will be submitted."

Fixes: https://tracker.ceph.com/issues/47610
Signed-off-by: Nizamudeen A <nia@redhat.com>
4 years agomgr/volumes/nfs: Fix wrong error message for pseudo path 37583/head
Varsha Rao [Wed, 7 Oct 2020 17:01:01 +0000 (22:31 +0530)]
mgr/volumes/nfs: Fix wrong error message for pseudo path

Fixes: https://tracker.ceph.com/issues/47783
Signed-off-by: Varsha Rao <varao@redhat.com>
4 years agolibrbd: avoid failing IO with -ESHUTDOWN when disabling exclusive-lock 37581/head
Jason Dillaman [Wed, 7 Oct 2020 14:58:57 +0000 (10:58 -0400)]
librbd: avoid failing IO with -ESHUTDOWN when disabling exclusive-lock

When dynamically disabling the exclusive-lock feature with in-flight IO,
it was previously possible for IO to fail with -ESHUTDOWN when it
attempts to acquire the lock due to the PreReleaseRequest setting the
lock required flag. There is also the possibility for a race with the
first IO racing with exclusive-lock shutdown when the lock was not
already acquired.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
4 years agorgw: fix setting of namespace in ordered and unordered bucket listing 37582/head
J. Eric Ivancich [Tue, 6 Oct 2020 16:42:22 +0000 (12:42 -0400)]
rgw: fix setting of namespace in ordered and unordered bucket listing

The namespace is not always set correctly during bucket listing. This
can, for example, cause the listing of incomplete multipart uploads,
which are in the _multipart_ namespace, to not paginate correctly, and
cause entries to be re-listed.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
4 years agoMerge PR #37577 into master
Jan Fajerski [Wed, 7 Oct 2020 13:19:54 +0000 (15:19 +0200)]
Merge PR #37577 into master

* refs/pull/37577/head:
PendingReleaseNotes: add note about batch refactor

Reviewed-by: Nathan Cutler <ncutler@suse.com>
4 years agorgw: allow rgw-orphan-list to note when rados objects are in namespace 37572/head
J. Eric Ivancich [Tue, 6 Oct 2020 19:21:02 +0000 (15:21 -0400)]
rgw: allow rgw-orphan-list to note when rados objects are in namespace

Currently namespaces and locators are ignored when `rados ls` is run
by rgw-orphan-list to record RADOS's known objects.

However there have been cases where RADOS objects have a locator, and
when one is included in the listing, the script does not handle it
correctly. Now when objects have locators, we will prevent their
output from entering the .intermediate file.

Additionally we do not expect RGW data objects to be in RADOS
namespaces, so when a namespaced object is detected, we'll error out
with a message.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
4 years agoinclude: explicitly define all types needed for libc++ iterator 37559/head
Willem Jan Withagen [Tue, 6 Oct 2020 00:00:28 +0000 (02:00 +0200)]
include: explicitly define all types needed for libc++ iterator

There is a serious difference between iterator in
    libstdc++ (gcc) versus libc++ (clang)

This generates a rather big and vague set of warnings and notes.
The crux is the warnings about `requirement '!__is_forward_iterator....`
Extra information can also be found on:
    https://www.fluentcpp.com/2018/05/08/std-iterator-deprecated/

```
/home/jenkins/workspace/ceph-master-compile/src/librbd/deep_copy/ObjectCopyRequest.cc:142:15: error: no matching constructor for initialization of 'io::Extents' (aka 'vector<pair<unsigned long, unsigned long> >')
  io::Extents image_extents{read_op.image_interval.begin(),
              ^            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/jenkins/workspace/ceph-master-compile/src/librbd/deep_copy/ObjectCopyRequest.cc:769:35: note: in instantiation of member function 'librbd::deep_copy::ObjectCopyRequest<librbd::ImageCtx>::send_read' requested here
template class librbd::deep_copy::ObjectCopyRequest<librbd::ImageCtx>;
                                  ^
/usr/include/c++/v1/vector:516:14: note: candidate constructor not viable: no known conversion from 'interval_set<unsigned long, std::map>::iterator' to 'std::__1::vector<std::__1::pair<unsigned long, unsigned long>, std::__1::allocator<std::__1::pair<unsigned long, unsigned long> > >::size_type' (aka 'unsigned long') for 1st argument
    explicit vector(size_type __n, const allocator_type& __a);
             ^
/usr/include/c++/v1/vector:518:5: note: candidate constructor not viable: no known conversion from 'interval_set<unsigned long, std::map>::iterator' to 'std::__1::vector<std::__1::pair<unsigned long, unsigned long>, std::__1::allocator<std::__1::pair<unsigned long, unsigned long> > >::size_type' (aka 'unsigned long') for 1st argument
    vector(size_type __n, const value_type& __x);
    ^
/usr/include/c++/v1/vector:559:5: note: candidate constructor not viable: no known conversion from 'interval_set<unsigned long, std::map>::iterator' to 'const std::__1::vector<std::__1::pair<unsigned long, unsigned long>, std::__1::allocator<std::__1::pair<unsigned long, unsigned long> > >' for 1st argument
    vector(const vector& __x, const allocator_type& __a);
    ^
/usr/include/c++/v1/vector:568:5: note: candidate constructor not viable: no known conversion from 'interval_set<unsigned long, std::map>::iterator' to 'initializer_list<std::__1::vector<std::__1::pair<unsigned long, unsigned long>, std::__1::allocator<std::__1::pair<unsigned long, unsigned long> > >::value_type>' (aka 'initializer_list<std::__1::pair<unsigned long, unsigned long> >') for 1st argument
    vector(initializer_list<value_type> __il, const allocator_type& __a);
    ^
/usr/include/c++/v1/vector:579:5: note: candidate constructor not viable: no known conversion from 'interval_set<unsigned long, std::map>::iterator' to 'std::__1::vector<std::__1::pair<unsigned long, unsigned long>, std::__1::allocator<std::__1::pair<unsigned long, unsigned long> > >' for 1st argument
    vector(vector&& __x, const allocator_type& __a);
    ^
/usr/include/c++/v1/vector:521:9: note: candidate template ignored: requirement '!__is_forward_iterator<interval_set<unsigned long, std::map>::iterator>::value' was not satisfied [with _InputIterator = interval_set<unsigned long, std::map>::iterator]
        vector(_InputIterator __first,
        ^
/usr/include/c++/v1/vector:536:9: note: candidate template ignored: requirement 'is_constructible<std::__1::pair<unsigned long, unsigned long>, unsigned long &>::value' was not satisfied [with _ForwardIterator = interval_set<unsigned long, std::map>::iterator]
        vector(_ForwardIterator __first,
        ^
/usr/include/c++/v1/vector:502:40: note: candidate constructor not viable: requires single argument '__a', but 2 arguments were provided
    _LIBCPP_INLINE_VISIBILITY explicit vector(const allocator_type& __a)
                                       ^
/usr/include/c++/v1/vector:514:14: note: candidate constructor not viable: requires single argument '__n', but 2 arguments were provided
    explicit vector(size_type __n);
             ^
/usr/include/c++/v1/vector:558:5: note: candidate constructor not viable: requires single argument '__x', but 2 arguments were provided
    vector(const vector& __x);
    ^
/usr/include/c++/v1/vector:565:5: note: candidate constructor not viable: requires single argument '__il', but 2 arguments were provided
    vector(initializer_list<value_type> __il);
    ^
/usr/include/c++/v1/vector:571:5: note: candidate constructor not viable: requires single argument '__x', but 2 arguments were provided
    vector(vector&& __x)
    ^
/usr/include/c++/v1/vector:519:5: note: candidate constructor not viable: requires 3 arguments, but 2 were provided
    vector(size_type __n, const value_type& __x, const allocator_type& __a);
    ^
/usr/include/c++/v1/vector:496:5: note: candidate constructor not viable: requires 0 arguments, but 2 were provided
    vector() _NOEXCEPT_(is_nothrow_default_constructible<allocator_type>::value)
    ^
/usr/include/c++/v1/vector:529:9: note: candidate constructor template not viable: requires at least 3 arguments, but 2 were provided
        vector(_InputIterator __first, _InputIterator __last, const allocator_type& __a,
        ^
/usr/include/c++/v1/vector:543:9: note: candidate constructor template not viable: requires at least 3 arguments, but 2 were provided
        vector(_ForwardIterator __first, _ForwardIterator __last, const allocator_type& __a,
        ^
1 error generated.
```

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
4 years agoPendingReleaseNotes: add note about batch refactor 37577/head
Jan Fajerski [Wed, 7 Oct 2020 07:45:42 +0000 (09:45 +0200)]
PendingReleaseNotes: add note about batch refactor

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
4 years agoos/bluestore: fix memory accounting in TwoQBufferCacheShard 37580/head
Adam Kupczyk [Wed, 7 Oct 2020 10:34:04 +0000 (06:34 -0400)]
os/bluestore: fix memory accounting in TwoQBufferCacheShard

Variable buffer_bytes has been redefined in TwoQBufferCacheShard,
causing PriCache to see always 0 usage when 2q cache was selected,
as it looks at it through BufferCacheShard::_get_bytes().

Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
4 years agoSubmittingPatches: use "doc" prefix in title of doc-only commits 37579/head
Kefu Chai [Wed, 7 Oct 2020 09:43:57 +0000 (17:43 +0800)]
SubmittingPatches: use "doc" prefix in title of doc-only commits

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #37498 from jan--f/cadm-new-batch-report
Joshua Schmid [Wed, 7 Oct 2020 07:56:10 +0000 (09:56 +0200)]
Merge pull request #37498 from jan--f/cadm-new-batch-report

pybind/mgr/orchestrator: fix preview for new c-v batch output

4 years agoMerge pull request #37556 from dillaman/wip-rbd-status
Mykola Golub [Wed, 7 Oct 2020 07:42:04 +0000 (10:42 +0300)]
Merge pull request #37556 from dillaman/wip-rbd-status

rbd: cleanup code and output formatting in status action

Reviewed-by: Mykola Golub <mgolub@suse.com>
4 years agoMerge pull request #37521 from jschmid1/remove_orch_osd_spec_mention
Joshua Schmid [Wed, 7 Oct 2020 07:37:42 +0000 (09:37 +0200)]
Merge pull request #37521 from jschmid1/remove_orch_osd_spec_mention

docs: <orch osd spec> is no longer present

4 years agoMerge pull request #37574 from tchaikov/wip-crimson-doc
Kefu Chai [Wed, 7 Oct 2020 05:45:35 +0000 (13:45 +0800)]
Merge pull request #37574 from tchaikov/wip-crimson-doc

doc/crimson: cleanups

Reviewed-by: Myoungwon Oh <myoungwon.oh@samsung.com>
4 years agodoc/crimson/poseidonstore: reformat 37574/head
Kefu Chai [Wed, 7 Oct 2020 03:43:54 +0000 (11:43 +0800)]
doc/crimson/poseidonstore: reformat

to render it as expected

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agodoc: move dev/crimson.rst into dev/crimson/
Kefu Chai [Wed, 7 Oct 2020 03:34:54 +0000 (11:34 +0800)]
doc: move dev/crimson.rst into dev/crimson/

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #36343 from myoungwon/wip-doc-poseidon-store
Samuel Just [Wed, 7 Oct 2020 00:28:43 +0000 (17:28 -0700)]
Merge pull request #36343 from myoungwon/wip-doc-poseidon-store

doc: introduce PoseidonStore

Reviewed-by: Samuel Just <sjust@redhat.com>
4 years agodoc/dev: doc/dev/osd_internals caps, formatting, clarity 37541/head
Anthony D'Atri [Mon, 5 Oct 2020 01:52:00 +0000 (18:52 -0700)]
doc/dev: doc/dev/osd_internals caps, formatting, clarity

Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>
4 years agomgr/dashboard: get rgw daemon zonegroup name from mgr 37449/head
Alfonso Martínez [Tue, 29 Sep 2020 14:37:01 +0000 (16:37 +0200)]
mgr/dashboard: get rgw daemon zonegroup name from mgr

Fixes: https://tracker.ceph.com/issues/47676
Signed-off-by: Alfonso Martinez <almartin@redhat.com>
4 years agoMerge pull request #37567 from liewegas/wip-stable-mod
Josh Durgin [Tue, 6 Oct 2020 18:54:04 +0000 (11:54 -0700)]
Merge pull request #37567 from liewegas/wip-stable-mod

include: ceph_stable_mod in public domain

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
4 years agoqa/tasks/cephfs/nfs: Check ganesha daemon status after restarting mgr 37571/head
Varsha Rao [Tue, 6 Oct 2020 05:59:40 +0000 (11:29 +0530)]
qa/tasks/cephfs/nfs: Check ganesha daemon status after restarting mgr

Fixes: https://tracker.ceph.com/issues/47591
Signed-off-by: Varsha Rao <varao@redhat.com>
4 years agodoc: add a link to ceph-deploy document 37570/head
Kefu Chai [Tue, 6 Oct 2020 16:20:58 +0000 (00:20 +0800)]
doc: add a link to ceph-deploy document

4 years agoMerge pull request #37565 from tchaikov/wip-crimson-cleanup
Kefu Chai [Tue, 6 Oct 2020 15:21:51 +0000 (23:21 +0800)]
Merge pull request #37565 from tchaikov/wip-crimson-cleanup

crimson: do not capture unused variables

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>