Merge pull request #65424 from xxhdx1985126/wip-72902

crimson/os/seastore/transaction_manager: read_pin_by_type read the whole extent if it's not fully loaded

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #64755 from cloudbehl/grafana-rate-irate-fix

ceph-mixin: Update monitoring mixin

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: SuperQ <superq@gmail.com>

Merge pull request #65243 from myoungwon/wip-corouint-state-device

crimson/os/seastore/rbm: switch to coroutine in state_device

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #65503 from Hezko/nvmeof-cli-ns-add-nsid-param

mgr/dashboard: add nsid param to ns add command

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #65504 from Hezko/nvmeof-cli-fix-subsys-group-add

mgr/dashboard: --no-group-append default value to False, aligned with old cli

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #65646 from zmc/pr-checklist

.github/workflows/pr-checklist.yml: Update

Merge pull request #65396 from ceph/wip-uadk-main-fix

uadk: Build with ceph fork (for FORTIFY_SOURCE fix)

.github/workflows/pr-checklist.yml: Update

To pull in these changes:
https://github.com/ceph/ceph-pr-checklist-action/pull/5
https://github.com/ceph/ceph-pr-checklist-action/pull/6

Signed-off-by: Zack Cerza <zack@cerza.org>

Merge pull request #65634 from ljflores/wip-tracker-71182

qa: suppress OpenSSL valgrind leaks

Merge pull request #65268 from rhcs-dashboard/fix-multiple-user-deletion

mgr/dashboard: add multiple ceph users deletion

Reviewed-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #65119 from rhcs-dashboard/72635-skip-secure-monitoring-stack

mgr/dashboard : Skip calls until secure_monitoring_stack is enabled

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@ibm.com>

Merge pull request #65600 from rhcs-dashboard/nfs-command

mgr/dashboard: FS - Attach Command showing undefined for MountData

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>

Merge pull request #65561 from rhcs-dashboard/fix-72810-main

monitoring: fix "In" OSDs in Cluster-Advanced grafana panel. Also change units from decbytes to bytes wherever used in the panel

Merge pull request #65409 from rhcs-dashboard/pool-configuration-new

 mgr/dashboard: Handle pool creation in tiering local storage class creation

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@ibm.com>

Merge pull request #65519 from Hezko/fix-force-param-in-ns-add-host

mgr/dashboard: fix None force param handling in ns add_host so it won't raise exceptions

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #65487 from rhcs-dashboard/72989-notification-form

mgr/dashboard: Form retains old data when switching from edit to create mode

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #65265 from UtkarshBhatthere/fix/cephfsmir/mgrclireq

pybind/mgr/mirroring: modifies the cli command type to read

Reviewed-by: Venky Shankar <vshankar@redhat.com>

qa: suppress OpenSSL valgrind leaks

These leaks started happening when OpenSSL v3.5.0
was released. We determined they are safe to suppress.

Fixes: https://tracker.ceph.com/issues/71182
Signed-off-by: Laura Flores <lflores@ibm.com>

Merge pull request #65576 from rhcs-dashboard/smb-bugfixes

mgr/dashboard: fix smb button and table column

Merge pull request #64933 from soumyakoduri/wip-skoduri-restore-progress

rgw/restore: Persistently store the restore state for cloud-s3 tier

Reviewed-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>

Merge PR #65569 into main

* refs/pull/65569/head:
script/redmine-upkeep: do not try to update status if open subtasks exist

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

Merge PR #65547 into main

* refs/pull/65547/head:
.github/workflows/redmine-upkeep: remove concurrency limit

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

Merge PR #65555 into main

* refs/pull/65555/head:
script/redmine-upkeep: include each issue changed in summary
.github/workflows/redmine-upkeep: use smaller limit for testing push

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

pybind/mgr/mirroring: modifies the cli command type to read

The command fs snapshot mirror ls is used to present state data to
client. This does not require Write semantics.

Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>

Merge pull request #65412 from rhcs-dashboard/fix-72893-main

mgr/progress: expose API from CLI

Merge pull request #65537 from rhcs-dashboard/total-capacity-fix

mgr/dashboard: fix total capacity value in dashboard

Merge pull request #64858 from rhcs-dashboard/edit-nfs-export

mgr/dashboard:[NFS] Missing Subvolume Groups and Subvolumes on Edit NFS Export.

Reviewed-by: Naman Munet <naman.munet@ibm.com>

Merge pull request #64559 from rhcs-dashboard/inline-table-edit

mgr/dashboard: support inline edit for datatable

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Pedro Gonzalez Gomez <pegonzal@ibm.com>

Merge pull request #65441 from linuxbox2/wip-72915

rgw: fix policy enforcement for GetObjectAttributes

mgr/dashboard: Local storage class creation via dashboard doesn't handle creation of pool.

Fixes: https://tracker.ceph.com/issues/72569
Signed-off-by: Dnyaneshwari <dtalweka@redhat.com>
mgr/dashboard: handle creation of new pool

Commit includes:
1) Provide link to create a new pool
2) Refactored validation on ACL mapping, removed required validator as default
3) fixed runtime error on console due to ACL length due to which the details section was not opening
4) Used rxjs operators to make API calls and making form ready once all data is available, fixing the form patch issues
5) Refactored some part of code to improve the performance
6) Added zone and pool information in details section for local storage class

Fixes: https://tracker.ceph.com/issues/72569
Signed-off-by: Naman Munet <naman.munet@ibm.com>

Merge pull request #65633 from adk3798/cephadm-pin-cheroot

pybind/mgr: pin cheroot version in requirements-required.txt

Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #65198 from xxhdx1985126/wip-72701

crimson/os/seastore/cache: clear extents_index when the booting is done

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #65234 from xxhdx1985126/wip-72706

crimson/osd/recovery_backend: interrupt all recovery_waiter unconditionally when cleaning up the recovery backend

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #65283 from xxhdx1985126/wip-72763

crimson/osd/osd_operations/client_request: rely on the checks in PG::do_recover_missing() to determine whether to recover clone objects

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #65317 from xxhdx1985126/wip-72790

crimson/osd/pg_backend: tolerate enoent for both head and clone when doing rollback

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #65353 from xxhdx1985126/wip-72844

crimson/osd/pg: tolerate NULL PG::pglog_based_recovery_op when cancelling pglog based recovery

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #65197 from myoungwon/wip-fix-allocator-alloc-handling

crimson/os/seastore/rbm: handle no-space case properly

Reviewed-by: Samuel Just <sjust@redhat.com>

pybind/mgr: pin cheroot version in requirements-required.txt

With python 3.10 (didn't seem to happen with python 3.12) the
pybind/mgr/cephadm/tests/test_node_proxy.py test times out.
This appears to be related to a new release of the cheroot
package and a github issues describing the same problem
we're seeing has been opened by another user
https://github.com/cherrypy/cheroot/issues/769

It is worth noting that the workaround described in that
issue does also work for us. If you add

```
import cheroot
cheroot.server.HTTPServer._serve_unservicable = lambda: None
```

after the existing imports in test_node_proxy.py the
test hanging issue also disappears. Also worth noting the
particular pin of

cheroot~=10.0

was chosen as it matches the existing pin being used
in pybind/mgr/dashboard/constraints.txt

Signed-off-by: Adam King <adking@redhat.com>

Merge pull request #65204 from ifed01/wip-ifed-fix-ec-contiguous

erasure-code: make bufferlist contiguous in ErasureCode::encode_prepare

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Alex Ainscow <aainscow@uk.ibm.com>

rgw/restore: Fixing teuthology restore tests

This includes
* fixing `rgw_cloudtier.py` qa script
* enabling `debug_rgw_restore` for cloud-transition suite
* adding few debug statements

Signed-off-by: Soumya Koduri <skoduri@redhat.com>

rgw/restore: Mark the restore entry status as `None` first time

While adding the restore entry to the FIFO, mark its status as `None`
so that restore thread knows that the entry is being processed for
the first time. Incase the restore is still in progress and the entry
needs to be re-added to the queue, its status then will be marked
`InProgress`.

Signed-off-by: Soumya Koduri <skoduri@redhat.com>

qa/rgw: Include rgw_restore_processor_period in s3tests

Signed-off-by: Soumya Koduri <skoduri@redhat.com>

rgw/restore: Persistently store the restore state for cloud-s3 tier

In order to resume IN_PROGRESS restore operations post RGW service
restarts, store the entries of the objects being restored from `cloud-s3`
tier persistently. This is already being done for `cloud-s3-glacier`
tier and now the same will be applied to `cloud-s3` tier too.

With this change, when `restore-object` is performed on any object,
it will be marked RESTORE_ALREADY_IN_PROGRESS and added to a restore FIFO queue.
This queue is later processed by Restore worker thread which will try to
fetch the objects from Cloud or Glacier/Tape S3 services. Hence all the
restore operations are now handled asynchronously (for both `cloud-s3`,
`cloud-s3-glacier` tiers).

Signed-off-by: Soumya Koduri <skoduri@redhat.com>

Merge pull request #65566 from rhcs-dashboard/fix-73077-main

mgr/dashboard: Allow FQDN in Connect Cluster form -> Cluster API URL

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #65579 from rhcs-dashboard/fix-73105-main

mgr/dashboard: fix zone update API forcing STANDARD storage class

Reviewed-by: Nizamudeen A <nia@redhat.com>

mgr/dashboard: FS - Attach Command showing undefined for MountData

Fixes: https://tracker.ceph.com/issues/73137
Signed-off-by: Dnyaneshwari Talwekar <dtalwekar@redhat.com>

Merge pull request #65613 from cybozu/doc-fix-osd-min-size

doc: fix osd min size

doc: fix osd min size

Exact 5 GiB block devices are also considered
as an available device.

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>

Merge pull request #65489 from shraddhaag/wip-shraddhaag-availability-format

mon/OSDMonitor.cc: optionally display availability status in json

Reviewed-by: Nitzan Mordhai<nmordech@ibm.com>

Merge pull request #65527 from chanyoung/fix-coll-refs

crimson/.../store-bench: fix coll_refs index error

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #65484 from ronen-fr/wip-rf-oneauth

osd/scrub: modify repair_object() to accept a single auth peer

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #62887 from clwluvw/copy-obj-remote

rgw: report copy obj progress from the frontend CR

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>

Merge pull request #65415 from kchheda3/wip-re-create-bucket

rgw/create-bucket: Do not re-create the bucket instance & bucket index shard object if if bucket already exist..

Merge pull request #64152 from cbodley/wip-63323

rgw: support S3 Object Ownership controls to disable object ACLs

Reviewed-by: Adam Emerson <aemerson@redhat.com>

Merge PR #65392 into main

* refs/pull/65392/head:

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>

mgr/dashboard: support inline edit for datatable

adding a new celltransformation that will transform the cell to a form
control when you click on the edit button which is inside a cell.

Added a new CellTemplate `editing` which if set to a cell, then it'll
add the edit button. You can also add validators to the control by using
the `customTemplateConfig` like
```
customTemplateConfig: {
          validators: [Validators.required]
        }
```

Also using a `EditState` to keep track of the different cells I can edit
simultaneously in a single time.

Fixes: https://tracker.ceph.com/issues/72171
Signed-off-by: Nizamudeen A <nia@redhat.com>

mgr/dashboard: fix zone update API forcing STANDARD storage class

The zone update REST API (`edit_zone`) always attempted to configure a
placement target for the `STANDARD` storage class, even when the request
was intended for a different storage class name.
This caused failures in deployments where `STANDARD` is not defined.

Changes:
Club add placement target and add storage class methods into one single
add_placement_targets_storage_class_zone method which takes the storage
class as a param as well alongside the rest of the placement params.

Fixes: https://tracker.ceph.com/issues/73105
Signed-off-by: Aashish Sharma <aasharma@redhat.com>

Merge PR #65577 into main

* refs/pull/65577/head:

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>

Merge pull request #64893 from zer0def/bug-57939

cephadm: pass wal/db slot count to ceph-volume

Reviewed-by: Guillaume Abrioux <gabrioux@ibm.com>

Merge pull request #63170 from adk3798/cephadm-nvmeof-stray

mgr/cephadm: don't mark nvmeof daemons without pool and group in name as stray

Reviewed-by: Redouane Kachach <rkachach@ibm.com>

Merge pull request #65548 from EncoreTechnologies/cephadmin-vir-ip-networks-interfaces-check

mgr/cephadm: Add check for virtual_interface_networks

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #65373 from phlogistonjohn/jjm-cephadm-build-ensure-byte-comp

cephadm: fail the script if byte-compile step fails

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@ibm.com>

Merge pull request #65155 from phlogistonjohn/jjm-py-common-fmt-black

python-common: enable consistent code formatting with 'black'

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #63962 from adk3798/cephadm-signal-containerized-daemon

cephadm: add command to send signals to daemons

Reviewed-by: John Mulligan <jmulligan@redhat.com>

cephfs-journal-tool:: Don't reset the journal trim position

If the fs had to go through journal recovery and reset,
the cephfs-journal-tool resets the journal trim position
because of which the old unused journal objects just stay
forever in the metadata pool. The patch fixes the issue.
Now, the old stale journal objects are trimmed during the
regular trimming cycle helping to recover space in the
metadata pool.

Fixes: https://tracker.ceph.com/issues/69708
Signed-off-by: Kotresh HR <khiremat@redhat.com>

qa: Validate cephfs-journal-tool reset trim

Validates that the cephfs-journal-tool reset
doesn't reset the trim position so that the
journal trim takes care of trimming the older
unused journal objects helping to recover the
space in metadata pool.

Fixes: https://tracker.ceph.com/issues/69708
Signed-off-by: Kotresh HR <khiremat@redhat.com>

Merge pull request #65510 from anthonyeleven/eugen

src/cephadm/cephadmlib/daemons: Fix typos in ceph.py and elsewhere

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #65322 from ShwetaBhosale1/fix_issue_72345_set_healthwarning_for_ssh_timeout_during_refresh

mgr/cephadm: set health warning for host SSH timeout

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #65291 from ShwetaBhosale1/fix_issue_72774_spec_reapply_causing_osd_to_apply_in_every_serve_loop

mgr/cephadm: After reapplying the osd spec, the OSD services are continuously applied in each serve loop iteration

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #65149 from ShwetaBhosale1/fix_issue_72652_max_num_of_osds_to_upgrade_in_single_iteration

mgr/cephadm: Config parameter to set the max number of OSDs to upgrade in single iteration

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@ibm.com>

Merge pull request #64642 from ShwetaBhosale1/fix_issue_72206_Allow_registry_credentials_to_define_multiple_container_registries

mgr/cephadm: Allow registry credentials to define multiple container registries

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #65398 from smanjara/wip-fix-zg-api-name

rgw/multisite: update api_name during a zonegroup rename

Merge pull request #64018 from 9401adarsh/wip-adashoka-71677

rgw/notifications: add support for sharded persistent bucket notifications

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>

Merge pull request #65366 from cbodley/wip-72847

rgw/admin: allow listing account's root users

Reviewed-by: Adam Emerson <aemerson@redhat.com>

doc: add format option in docs

Fixes: https://tracker.ceph.com/issues/71546
Signed-off-by: Shraddha Agrawal <shraddhaag@ibm.com>

mgr/dashboard: fix SMB custom DNS button and linked_to_cluster col

- The button 'add custom DNS' in smb cluster form should only appear for active directory where is relevant.

- The linked_to_cluster column data is missing from smb standalone

- Some refactoring to remove magic strings and use FormControl for publicAddrs field

Fixes: https://tracker.ceph.com/issues/73096
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@ibm.com>

Merge pull request #65528 from mkogan1/wip-d4n-odsync

rgw/d4n: change cache write ::open() flags

Merge pull request #65166 from myoungwon/wip-fix-rbm-mergeable-block

crimson/os/seastore: correct possible mergeable size for ool extents

Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>

Merge pull request #59608 from VallariAg/wip-nvmeof-teuthology-v7-upgrade

qa/suites/nvmeof: add upgrade sub-suite

Merge pull request #65565 from salieri11/igolikov-bug-73053

mds: remove unused enum values for subvolume metrics

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #65394 from athanatos/sjust/wip-seastore-cleanups-2025-08

seastore: misc cleanups, coroutine conversions

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #65399 from anthonyeleven/improve-global-yml

src/common/options: Improve global.yaml.in

Merge pull request #65372 from adamemerson/wip-70916-bis

test/neorados: Catch timeouts in Watch/Poll test

Merge pull request #65532 from phlogistonjohn/jjm-jenk-hint

github: add a note reminding to use one command per comment

Merge pull request #65553 from ceph/pr-checklist-fix

.github/workflows/pr-checklist.yml: Update

script/redmine-upkeep: do not try to update status if open subtasks exist

To avoid chaos like:

https://tracker.ceph.com/issues/71735

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

test/.../test_cbjournal: destroy CircularBoundedJournal instance prior to reactor shutdown

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/.../circular_bounded_journal: inline do_submit_record into submit_record

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/.../circular_bounded_journal: add journal submission metrics

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/.../circular_bounded_journal: convert do_submit_record to coroutine

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/.../circular_bounded_journal: convert submit_record to coroutine

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/.../transaction_manager: convert do_submit_transaction to coroutine

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/.../extent_placement_manager: convert BackgroundProcess::run() to coroutine

Signed-off-by: Samuel Just <sjust@redhat.com>

Merge pull request #64978 from athanatos/sjust/wip-mclock-cleanup

mclock: avoid using config keys for profiles, remove MonClient from MclockConfig

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Mohit Agrawal <moagrawa@redhat.com>
Reviewed-by: Sridhar Seshasayee <sseshasa@redhat.com>

cephadm: add command to send signals to daemons

This command figures out the container id for the
daemon based on the given name and then uses
a docker/podman to send that signal to the container

Signed-off-by: Adam King <adking@redhat.com>

qa: Add nvmeof:upgrade suite

Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>

mgr/dashboard: Allow FQDN in Connect Cluster form -> Cluster API URL

Allow the user to enter URL with FQDN in the Cluster API URL filed in
the Connect Cluster form inside Multi-cluster tab.

Fixes: https://tracker.ceph.com/issues/73077
Signed-off-by: Aashish Sharma <aasharma@redhat.com>

Merge PR #65516 into main

* refs/pull/65516/head:
common: remove unused attribute

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #65559 from nbalacha/wip-nbalacha-cleanup-1

rgw/bucket-logging: minor code cleanup

monitoring/ceph_mixin: fix Cluster - Advanced OSD grafana panel

1. Fixes the promql expr used to calculate "In" OSDs in
   ceph-cluster-advanced.json.
2. Fixes the color coding for the single state panels used in the OSDs
   grafana panel like "In", "Out" etc

Fixes: https://tracker.ceph.com/issues/72810
Signed-off-by: Aashish Sharma <aasharma@redhat.com>