]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
8 months agomgr/vol: reuse code for spawning threads
Rishabh Dave [Mon, 16 Sep 2024 09:16:45 +0000 (14:46 +0530)]
mgr/vol: reuse code for spawning threads

Signed-off-by: Rishabh Dave <ridave@redhat.com>
8 months agoMerge pull request #60042 from sunilangadi2/migration_with_namespace_test
Ilya Dryomov [Thu, 24 Oct 2024 10:02:09 +0000 (12:02 +0200)]
Merge pull request #60042 from sunilangadi2/migration_with_namespace_test

qa/workunits/rbd: cover native migration between namespaces

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
8 months agoMerge pull request #60420 from nbalacha/wip-nbalacha-namespace-doc
Ilya Dryomov [Thu, 24 Oct 2024 07:12:30 +0000 (09:12 +0200)]
Merge pull request #60420 from nbalacha/wip-nbalacha-namespace-doc

doc/rbd: namespace mirroring updates

Reviewed-by: Sunil Angadi <Sunil.Angadi@ibm.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
8 months agoMerge pull request #60355 from rhcs-dashboard/carbonize-hosts-form
afreen23 [Thu, 24 Oct 2024 06:41:07 +0000 (12:11 +0530)]
Merge pull request #60355 from rhcs-dashboard/carbonize-hosts-form

mgr/dashboard: carbonize Cluster > Hosts form

Reviewed-by: Afreen Misbah <afreen@ibm.com>
8 months agoMerge pull request #60465 from zdover23/wip-doc-2024-10-24-cephfs-troubleshooting
Zac Dover [Thu, 24 Oct 2024 05:27:17 +0000 (15:27 +1000)]
Merge pull request #60465 from zdover23/wip-doc-2024-10-24-cephfs-troubleshooting

doc/cephfs: edit "Disabling Volumes Plugin"

Reviewed-by: Jos Collin <jcollin@redhat.com>
8 months agodoc/cephfs: edit "Disabling Volumes Plugin" 60465/head
Zac Dover [Thu, 24 Oct 2024 04:52:58 +0000 (14:52 +1000)]
doc/cephfs: edit "Disabling Volumes Plugin"

Improve the English language in the section 'Disabling Volumes Plugin"
(which here becomes "Disabling the Volumes Plugin") in the
doc/cephfs/troubleshooting.rst file.

The change here is similar to a change introduced in
https://github.com/ceph/ceph/pull/60448/. That PR seems to be unable to
pass the "make check", and this PR is part of a test to see if breaking
the changes in that PR into several smaller changes results in mergeable
PRs.

Signed-off-by: Zac Dover <zac.dover@proton.me>
8 months agoMerge pull request #59027 from hit1943/65971_fix
Venky Shankar [Thu, 24 Oct 2024 04:24:11 +0000 (09:54 +0530)]
Merge pull request #59027 from hit1943/65971_fix

client: fixed a bug that read operation hung

Reviewed-by: Venky Shankar <vshankar@redhat.com>
8 months agodoc/rbd : add namespace mirroring updates 60420/head
N Balachandran [Tue, 22 Oct 2024 04:47:00 +0000 (10:17 +0530)]
doc/rbd : add namespace mirroring updates

Updates the rbd docs with the new remote-namespace
mirroring configuration option.

Signed-off-by: N Balachandran <nibalach@redhat.com>
8 months agoMerge pull request #60276 from ceph/bypass_sr
Yingxin [Thu, 24 Oct 2024 01:29:11 +0000 (09:29 +0800)]
Merge pull request #60276 from ceph/bypass_sr

test/crimson: disable stall-detector on aarch64 to fix asan failures

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
8 months agoMerge pull request #60460 from zdover23/wip-doc-2024-10-24-start-beginners-guide
Zac Dover [Thu, 24 Oct 2024 00:19:40 +0000 (10:19 +1000)]
Merge pull request #60460 from zdover23/wip-doc-2024-10-24-start-beginners-guide

doc/start: add vstart install guide

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
8 months agodoc/start: add vstart install guide 60460/head
Zac Dover [Wed, 23 Oct 2024 23:04:08 +0000 (09:04 +1000)]
doc/start: add vstart install guide

Add "vstart Cluster Installation and Configuration Procedure" to the
Beginner's Guide.

Signed-off-by: Zac Dover <zac.dover@proton.me>
8 months agoMerge pull request #60413 from gbregman/main
Gil Bregman [Wed, 23 Oct 2024 19:54:01 +0000 (22:54 +0300)]
Merge pull request #60413 from gbregman/main

 Add namespace netmask parameters to nvmeof configuration

8 months agomgr/dashboard: carbonize Cluster > Hosts form 60355/head
Dnyaneshwari [Wed, 16 Oct 2024 11:03:19 +0000 (16:33 +0530)]
mgr/dashboard: carbonize Cluster > Hosts form

Fixes: https://tracker.ceph.com/issues/68264
Signed-off-by: Dnyaneshwari Talwekar <dtalweka@redbat.com>
8 months agoMerge pull request #60399 from rhcs-dashboard/rgw-bucket-get-fix-for-account
afreen23 [Wed, 23 Oct 2024 15:58:03 +0000 (21:28 +0530)]
Merge pull request #60399 from rhcs-dashboard/rgw-bucket-get-fix-for-account

mgr/dashboard: fix bucket get for s3 account owned bucket

Reviewed-by: Afreen Misbah <afreen@ibm.com>
8 months agoMerge pull request #60388 from ceph/fix-check_license_typo-main
Ernesto Puerta [Wed, 23 Oct 2024 15:12:35 +0000 (16:12 +0100)]
Merge pull request #60388 from ceph/fix-check_license_typo-main

ci: fix typo in check-license

8 months agoadded tests migration with namespace 60042/head
Sunil Angadi [Sun, 29 Sep 2024 09:56:12 +0000 (15:26 +0530)]
added tests migration with namespace

Signed-off-by: Sunil Angadi <Sunil.Angadi@ibm.com>
8 months agoMerge pull request #58647 from rishabh-d-dave/mgr-vol-mod-disable
Hemanth [Wed, 23 Oct 2024 12:27:50 +0000 (17:57 +0530)]
Merge pull request #58647 from rishabh-d-dave/mgr-vol-mod-disable

mgr: allow disabling always-on modules

8 months agoMerge pull request #60316 from VallariAg/wip-nvmeof-teuthology-mtls-test
Vallari Agrawal [Wed, 23 Oct 2024 11:58:53 +0000 (17:28 +0530)]
Merge pull request #60316 from VallariAg/wip-nvmeof-teuthology-mtls-test

qa/suites/nvmeof: add mtls test

8 months agoMerge pull request #60157 from soumyakoduri/wip-skoduri-lc-nullinstance
Soumya Koduri [Wed, 23 Oct 2024 11:52:08 +0000 (17:22 +0530)]
Merge pull request #60157 from soumyakoduri/wip-skoduri-lc-nullinstance

rgw/lc: Fix issues with non-current objects with instance empty

Reviewed-by: Casey Bodley <cbodley@redhat.com>
8 months agoMerge pull request #60258 from aclamk/wip-aclamk-cbt-improve-show-label
Adam Kupczyk [Wed, 23 Oct 2024 11:38:15 +0000 (13:38 +0200)]
Merge pull request #60258 from aclamk/wip-aclamk-cbt-improve-show-label

os/bluestore/ceph-bluestore-tool: Modify show-label for many devs

8 months agotest/crimson: disable stall-detector on aarch64 to fix asan failures 60276/head
cailianchun [Fri, 18 Oct 2024 02:39:46 +0000 (02:39 +0000)]
test/crimson: disable stall-detector on aarch64 to fix asan failures

Ceph crimson uses seastar on debug mode which would enable ASAN, while stall-detector uses glibc backtrace function which would cause ASAN failures on aarch64.
Reason see scylladb/scylladb#15090 (comment)

Because arm ci servers in lab are "elderly", causing stall happened often, this PR is to disable stall-detector until seastar upstream migrated to libunwind, see scylladb/seastar#1878
Seastar does not provide a function to disable stall-detector, at present, increase stall-detector time to avoid stall-detector timeout on arm platform.

fixes: https://tracker.ceph.com/issues/65635

Signed-off-by: cailianchun <arm7star@qq.com>
8 months agoMerge pull request #60433 from indirasawant/doc_fix_1
Anthony D'Atri [Tue, 22 Oct 2024 22:48:06 +0000 (18:48 -0400)]
Merge pull request #60433 from indirasawant/doc_fix_1

doc/cephfs: rearrange subvolume group information

8 months agodoc/cephfs: rearrange subvolume group information 60433/head
Indira Sawant [Tue, 22 Oct 2024 21:45:10 +0000 (16:45 -0500)]
doc/cephfs: rearrange subvolume group information

Rearranging the documentation to align it with CephFS encapsulation design.

Signed-off-by: Indira Sawant <indira.sawant@ibm.com>
8 months agoMerge pull request #60423 from zdover23/wip-doc-2024-10-22-cephadm-services-smb
Zac Dover [Tue, 22 Oct 2024 20:17:21 +0000 (06:17 +1000)]
Merge pull request #60423 from zdover23/wip-doc-2024-10-22-cephadm-services-smb

doc/cephadm: correct "ceph orch apply" command

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
8 months agomgr/dashboard: fix bucket get for s3 account owned bucket 60399/head
Nizamudeen A [Fri, 18 Oct 2024 15:20:33 +0000 (20:50 +0530)]
mgr/dashboard: fix bucket get for s3 account owned bucket

**Issue 1:**

When a bucket is created with a user that is owner by the account user,
it fails to fetch the info for the bucket because the owner of that
bucket is considered as owned by the account rather than the user.

dashboard api try to fetch some info for the bucket on the basis of the
bucket owner which in this case fails since its not a real user.

To keep the existing behavior as it is and fix the current issue, I am
doing a check to make sure the user id exists or not. if it doesn't
exist, we goes on to fetch using the dashboard user.

**Issue 2**
Editing the bucket owner by the account is broken. So disabling the
ownership change for the bucket owned by account until we have user
account management for rgw in the dashboard

Fixes: https://tracker.ceph.com/issues/68622
Signed-off-by: Nizamudeen A <nia@redhat.com>
8 months agorgw/lc: Fix issues with non-current objects with instance empty 60157/head
Soumya Koduri [Mon, 7 Oct 2024 11:24:02 +0000 (16:54 +0530)]
rgw/lc: Fix issues with non-current objects with instance empty

When the bucket versioning is enabled, old plain object entry is converted
to versioned by updating its instance as "null" in its raw head/old object.
However its instance remains empty in the bi list entry. Same is the case for
the entries created after versioning is suspended and re-enabled.

So to access such objects which are non-current, we need to set rgw_obj_key.instance as
1) "null" to read the actual raw obj and
2) empty while accessing/updating their bi entry.

Fixes: https://tracker.ceph.com/issues/68402
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
8 months agodoc/cephadm: correct "ceph orch apply" command 60423/head
Zac Dover [Tue, 22 Oct 2024 11:30:02 +0000 (21:30 +1000)]
doc/cephadm: correct "ceph orch apply" command

s/orch apply/ceph orch apply/ in a command where "ceph" was missing.

This was reported by Eugen Block to Zac Dover on 22 Oct 2024 through
Slack.

Co-authored-by: Eugen Block <eblock@nde.ag>
Signed-off-by: Zac Dover <zac.dover@proton.me>
8 months agoMerge PR #60106 into main
Patrick Donnelly [Tue, 22 Oct 2024 01:00:21 +0000 (21:00 -0400)]
Merge PR #60106 into main

* refs/pull/60106/head:
msg/async/ProtocolV2: pass `desc` as `std::string_view` to write()

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
8 months agoMerge PR #60174 into main
Patrick Donnelly [Tue, 22 Oct 2024 00:57:15 +0000 (20:57 -0400)]
Merge PR #60174 into main

* refs/pull/60174/head:
common/Finisher: pass name as std::string_view to ctor
common/Finisher: add method get_thread_name()
mgr/ActivePyModule: build thread name with fmt
mgr/ActivePyModule: return std::string_view instead of std::string copy
common/Finisher: use fmt to build strings
common/Finisher: un-inline ctor and dtor
common/Finisher: add `const` to several fields
common/Finisher: merge duplicate field initializers
common/Finisher: call notify_one() instead of notify_all()
common/Finisher: wake up after pushing to the queue
common/Finisher: do not wake up the thread if already running
common/Finisher: call logger without holding the lock
common/Finisher: use `std::lock_guard` instead of `std::unique_lock`
common/Finisher: merge all queue() container methods into one template

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
8 months agoMerge PR #60214 into main
Patrick Donnelly [Tue, 22 Oct 2024 00:56:01 +0000 (20:56 -0400)]
Merge PR #60214 into main

* refs/pull/60214/head:
mds/MDCache: use `auto`
mds/CDir: use the erase() return value
mds/MDCache: remove unnecessary empty() check
mds/MDCache: use the erase() return value
mds/MDCache: pass iterator by value

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
8 months agoMerge PR #60216 into main
Patrick Donnelly [Tue, 22 Oct 2024 00:54:15 +0000 (20:54 -0400)]
Merge PR #60216 into main

* refs/pull/60216/head:
common/options: pass name as rvalue reference
common/config: use libfmt to build strings
common/config: use emplace_back() instead of push_back()
common/HeartbeatMap: pass name as rvalue reference
common/config_obs_mgr: use the erase() return value
common/SloppyCRCMap: use the erase() return value
common: disable `boost::intrusive::constant_time_size`

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
8 months agoMerge PR #60220 into main
Patrick Donnelly [Tue, 22 Oct 2024 00:53:44 +0000 (20:53 -0400)]
Merge PR #60220 into main

* refs/pull/60220/head:
msg/async/AsyncConnection: move the writeCallback instead of copying it
msg/async/AsyncConnection: do not wrap writeCallback in `std::optional`
msg/async/frames_v2: use zero-initialization instead of memset()
msg/async/Event: use zero-initialization instead of memset()
msg/Message: use zero-initialization instead of memset()
msg/async/ProtocolV2: eliminate redundant std::map lookups
msg/async/ProtocolV[12]: reverse the std::map sort order
msg/async/ProtocolV[12]: use `auto`
msg/async/ProtocolV[12]: use range-based `for`
msg/async/ProtocolV1: use zero-initialization instead of memset()

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
8 months agoMerge PR #60324 into main
Patrick Donnelly [Tue, 22 Oct 2024 00:51:33 +0000 (20:51 -0400)]
Merge PR #60324 into main

* refs/pull/60324/head:
mds/Beacon: set a thread name

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
8 months agomgr/cephadm: Add namespace netmask parameters to nvmeof configuration 60413/head
Gil Bregman [Mon, 21 Oct 2024 14:23:22 +0000 (17:23 +0300)]
mgr/cephadm: Add namespace netmask parameters to nvmeof configuration
Fixes https://tracker.ceph.com/issues/68542

Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
8 months agopython-common/ceph/deployment: Add namespace netmask parameters to nvmeof configuration
Gil Bregman [Mon, 21 Oct 2024 14:22:17 +0000 (17:22 +0300)]
python-common/ceph/deployment: Add namespace netmask parameters to nvmeof configuration
Fixes https://tracker.ceph.com/issues/68542

Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
8 months agoMerge pull request #59470 from adk3798/cephadm-staggered-upgrade-test-wait-check...
Adam King [Mon, 21 Oct 2024 18:54:56 +0000 (14:54 -0400)]
Merge pull request #59470 from adk3798/cephadm-staggered-upgrade-test-wait-check-rgw-versions

qa/cephadm: wait a bit before checking rgw daemons upgraded w/ `ceph versions`

Reviewed-by: Guillaume Abrioux <gabrioux@ibm.com>
8 months agoMerge pull request #60225 from MaxKellermann/ceph_context_atomic
Casey Bodley [Mon, 21 Oct 2024 17:07:20 +0000 (13:07 -0400)]
Merge pull request #60225 from MaxKellermann/ceph_context_atomic

common/ceph_context: use std::atomic<std::shared_ptr<T>>

Reviewed-by: Casey Bodley <cbodley@redhat.com>
8 months agoMerge PR #60341 into main
Patrick Donnelly [Mon, 21 Oct 2024 16:20:21 +0000 (12:20 -0400)]
Merge PR #60341 into main

* refs/pull/60341/head:
doc/dev: add walkthrough for CephFS kernel development

Reviewed-by: Anthony D Atri <anthony.datri@gmail.com>
8 months agoMerge pull request #60045 from AliMasarweh/wip-alimasa-notif-list-bucket
Ali Masarwa [Mon, 21 Oct 2024 13:34:57 +0000 (16:34 +0300)]
Merge pull request #60045 from AliMasarweh/wip-alimasa-notif-list-bucket

RGW|Bucket notification: fix for v2 topics rgw-admin list operation

Reviewed-by: yuvalif<ylifshit@redhat.com>
8 months agoMerge pull request #56849 from frittentheke/issue_64321_alerts
afreen23 [Mon, 21 Oct 2024 12:09:56 +0000 (17:39 +0530)]
Merge pull request #56849 from frittentheke/issue_64321_alerts

Add multi-cluster support (showMultiCluster=True) to alerts

Reviewed-by: Afreen Misbah <afreen@ibm.com>
8 months agoMerge pull request #60401 from rhcs-dashboard/cephfs
afreen23 [Mon, 21 Oct 2024 11:57:58 +0000 (17:27 +0530)]
Merge pull request #60401 from rhcs-dashboard/cephfs

mgr/dashboard: Removing duplicate cephfs constant file & importing correct default_subvolumegroup.

Reviewed-by: Afreen Misbah <afreen@ibm.com>
8 months agoMerge pull request #59926 from JonBailey1993/JonBailey1993/ceph_test_rados_io_sequenc...
Jon Bailey [Mon, 21 Oct 2024 08:50:44 +0000 (09:50 +0100)]
Merge pull request #59926 from JonBailey1993/JonBailey1993/ceph_test_rados_io_sequence_interactive

test/osd: Add interactive mode to ceph_test_rados_io_sequence

Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>
8 months agoRGW|Bucket notification: fix for v2 topics rgw-admin list operation 60045/head
Ali Masarwa [Sun, 29 Sep 2024 12:00:13 +0000 (15:00 +0300)]
RGW|Bucket notification: fix for v2 topics rgw-admin list operation

Signed-off-by: Ali Masarwa <amasarwa@redhat.com>
8 months agoAdd multi-cluster support (showMultiCluster=True) to alerts 56849/head
Christian Rohmann [Fri, 26 Jan 2024 14:05:52 +0000 (15:05 +0100)]
Add multi-cluster support (showMultiCluster=True) to alerts

Following PR https://github.com/ceph/ceph/pull/55495 fixing the
dashboard in regards to multiple clusters storing their metrics
in a single Prometheus instance, this PR addresses the issues
for alerts.

Fixes: https://tracker.ceph.com/issues/64321
Signed-off-by: Christian Rohmann <christian.rohmann@inovex.de>
8 months agoqa/suites/nvmeof: add mtls test 60316/head
Vallari Agrawal [Tue, 15 Oct 2024 10:57:37 +0000 (16:27 +0530)]
qa/suites/nvmeof: add mtls test

Add qa/workunits/nvmeof/mtls_test.sh which enables
mtls config and redeploy, then verify and disables
mtls config.

Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>
9 months agoPendingReleaseNote: add release note that mgr/volumes plugin can be... 58647/head
Rishabh Dave [Sun, 28 Jul 2024 17:36:42 +0000 (23:06 +0530)]
PendingReleaseNote: add release note that mgr/volumes plugin can be...

disabled now.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
9 months agodoc/cephfs: add doc for disabling mgr/volumes plugin
Rishabh Dave [Sun, 28 Jul 2024 17:28:49 +0000 (22:58 +0530)]
doc/cephfs: add doc for disabling mgr/volumes plugin

Signed-off-by: Rishabh Dave <ridave@redhat.com>
9 months agoqa/cephfs: test enable/disable of volumes plugin
Rishabh Dave [Sun, 28 Jul 2024 16:43:07 +0000 (22:13 +0530)]
qa/cephfs: test enable/disable of volumes plugin

Signed-off-by: Rishabh Dave <ridave@redhat.com>
9 months agomon/MgrMonitor: allow disabling always-on MGR modules
Rishabh Dave [Thu, 18 Jul 2024 19:38:07 +0000 (01:08 +0530)]
mon/MgrMonitor: allow disabling always-on MGR modules

Add a new command ("ceph mgr module force disable <module>") that allows
forcibly disabling an always-on module. This command should ideally only
be used to for cluster recovery.

Fixes: https://tracker.ceph.com/issues/66005
Signed-off-by: Rishabh Dave <ridave@redhat.com>
9 months agomon/MgrMontitor: add log entry to support debugging
Rishabh Dave [Thu, 8 Aug 2024 17:18:03 +0000 (22:48 +0530)]
mon/MgrMontitor: add log entry to support debugging

It becomes easier to understand logs when whether command succeeded or
not are also logged.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
9 months agomon/MgrMonitor: improve a log message
Rishabh Dave [Wed, 17 Jul 2024 12:35:33 +0000 (18:05 +0530)]
mon/MgrMonitor: improve a log message

Following log message has 3 distinct information (enabled modules,
modules that are alwats on and total number of commands enabled) printed
on the same line which makes it hard to find one of the information and
also makes it comparatively hard to read -

2024-07-17T17:21:16.609+0530 7f534ae006c0  0 mon.a@0(leader).mgr e0 create_initial initial modules iostat,nfs,volumes, always on modules balancer,crash,devicehealth,orchestrator,pg_autoscaler,progress,status,telemetry, 50 commands

With this commit it would be easier to read and find needed info -

2024-07-17T17:21:16.609+0530 7f534ae006c0  0 mon.a@0(leader).mgr e0 create_initial initial modules: iostat,nfs,volumes
2024-07-17T17:21:16.609+0530 7f534ae006c0  0 mon.a@0(leader).mgr e0 create_initial always on modules: balancer,crash,devicehealth,orchestrator,pg_autoscaler,progress,status,telemetry
2024-07-17T17:21:16.609+0530 7f534ae006c0  0 mon.a@0(leader).mgr e0 create_initial 50 commands

Signed-off-by: Rishabh Dave <ridave@redhat.com>
9 months agodoc/dev: add walkthrough for CephFS kernel development 60341/head
Patrick Donnelly [Tue, 15 Oct 2024 21:12:28 +0000 (17:12 -0400)]
doc/dev: add walkthrough for CephFS kernel development

Specifically, an opinionated walkthrough of how to setup an environment for a
built kernel, networking a VM to sepia, and mounting a remote Ceph cluster.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
9 months agomgr/dashboard: Removing duplicate cephfs constant file & importing correct default_su... 60401/head
Dnyaneshwari [Fri, 18 Oct 2024 15:58:37 +0000 (21:28 +0530)]
mgr/dashboard: Removing duplicate cephfs constant file & importing correct default_subvolumegroup.

Fixes: https://tracker.ceph.com/issues/68623
Signed-off-by: Dnyaneshwari Talwekar <dtalweka@redbat.com>
9 months agoMerge pull request #60323 from aclamk/wip-aclamk-fix-68528
Adam Kupczyk [Fri, 18 Oct 2024 15:56:46 +0000 (17:56 +0200)]
Merge pull request #60323 from aclamk/wip-aclamk-fix-68528

os/bluestore: Fix repair of multilabel when collides with BlueFS

9 months agoMerge pull request #59420 from rishabh-d-dave/max-mds-confirm
Rishabh Dave [Fri, 18 Oct 2024 14:34:18 +0000 (20:04 +0530)]
Merge pull request #59420 from rishabh-d-dave/max-mds-confirm

mon,cephfs: require confirmation when changing max_mds on unhealthy cluster

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
9 months agoMerge pull request #60331 from MaxKellermann/CodingStyle_fwd
Ilya Dryomov [Fri, 18 Oct 2024 14:08:51 +0000 (16:08 +0200)]
Merge pull request #60331 from MaxKellermann/CodingStyle_fwd

CodingStyle: allow C++ forward declarations

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
9 months agoMerge pull request #58084 from asm0deuz/mgmt_gtw_e2e 60380/head
Adam King [Fri, 18 Oct 2024 13:05:43 +0000 (09:05 -0400)]
Merge pull request #58084 from asm0deuz/mgmt_gtw_e2e

mgmt-gateway: add e2e testing

Reviewed-by: Adam King <adking@redhat.com>
9 months agoMerge pull request #60328 from cbodley/wip-mstart-doc
Casey Bodley [Fri, 18 Oct 2024 12:36:29 +0000 (08:36 -0400)]
Merge pull request #60328 from cbodley/wip-mstart-doc

rgw: document and label mstart.sh and related scripts

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
9 months agoMerge pull request #58486 from rishabh-d-dave/ignore-osd-down
Rishabh Dave [Fri, 18 Oct 2024 11:46:23 +0000 (17:16 +0530)]
Merge pull request #58486 from rishabh-d-dave/ignore-osd-down

qa/cephfs: ignore when specific OSD is reported down during upgrade

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
9 months agoMerge pull request #59712 from rishabh-d-dave/mgr-vol-clone-stats-snap
Rishabh Dave [Fri, 18 Oct 2024 11:45:40 +0000 (17:15 +0530)]
Merge pull request #59712 from rishabh-d-dave/mgr-vol-clone-stats-snap

qa/cephfs: test clone progress reporter after subvol is deleted but...

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
9 months agoMerge pull request #59848 from rishabh-d-dave/mgr-vol-wakeup-timeout
Rishabh Dave [Fri, 18 Oct 2024 11:44:42 +0000 (17:14 +0530)]
Merge pull request #59848 from rishabh-d-dave/mgr-vol-wakeup-timeout

mgr/vol: use pre-defined timeout period instead of hardcoded value

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
9 months agoMerge pull request #60008 from rishabh-d-dave/mgr-util-improve
Rishabh Dave [Fri, 18 Oct 2024 11:36:12 +0000 (17:06 +0530)]
Merge pull request #60008 from rishabh-d-dave/mgr-util-improve

mgr/mgr_util: improvements for RTimer

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
9 months agoMerge pull request #60027 from rishabh-d-dave/mgr-vol-progbar-id
Rishabh Dave [Fri, 18 Oct 2024 11:35:39 +0000 (17:05 +0530)]
Merge pull request #60027 from rishabh-d-dave/mgr-vol-progbar-id

mgr/vol: don't define progress bar ID repeatedly

Reviewed-by: Venky Shankar <vshankar@redhat.com>
9 months agoci: fix typo in check-license 60388/head
Ernesto Puerta [Fri, 18 Oct 2024 09:37:10 +0000 (11:37 +0200)]
ci: fix typo in check-license

Signed-off-by: Ernesto Puerta <37327689+epuertat@users.noreply.github.com>
9 months agoMerge pull request #59782 from aclamk/wip-aclamk-fix-67596-allocmap
Adam Kupczyk [Fri, 18 Oct 2024 06:49:16 +0000 (08:49 +0200)]
Merge pull request #59782 from aclamk/wip-aclamk-fix-67596-allocmap

os/bluestore: Fix ceph-bluestore-tool allocmap command

9 months agomgmt-gateway: add e2e testing 58084/head
Teoman ONAY [Mon, 17 Jun 2024 11:16:48 +0000 (13:16 +0200)]
mgmt-gateway: add e2e testing

Add mgmt-gateway teuthology test scenarios

Signed-off-by: Teoman ONAY <tonay@ibm.com>
9 months agoMerge pull request #60202 from athanatos/sjust/wip-crimson-io
Samuel Just [Thu, 17 Oct 2024 18:09:26 +0000 (11:09 -0700)]
Merge pull request #60202 from athanatos/sjust/wip-crimson-io

crimson: replace do_osd_ops* with simpler, more general mechanism

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
9 months agoMerge pull request #60223 from guits/replace-osd-enhancement
Adam King [Thu, 17 Oct 2024 16:12:16 +0000 (12:12 -0400)]
Merge pull request #60223 from guits/replace-osd-enhancement

orch: disk replacement enhancement

Reviewed-by: Adam King <adking@redhat.com>
9 months agoMerge pull request #60347 from avanthakkar/rm-smb-dump-everything
Adam King [Thu, 17 Oct 2024 14:44:32 +0000 (10:44 -0400)]
Merge pull request #60347 from avanthakkar/rm-smb-dump-everything

mgr/smb: rm all `smb dump` commands

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
9 months agoMerge pull request #60167 from jmolmo/add_daemon_health_metric
Juan Miguel Olmo [Thu, 17 Oct 2024 14:39:37 +0000 (16:39 +0200)]
Merge pull request #60167 from jmolmo/add_daemon_health_metric

exporter: New metric for report ceph daemons health

9 months agoMerge pull request #59514 from kevinzs2048/add-uadk-doc
Zac Dover [Thu, 17 Oct 2024 13:25:15 +0000 (23:25 +1000)]
Merge pull request #59514 from kevinzs2048/add-uadk-doc

Compressor: Add UADK document

Reviewed-by: Zac Dover <zac.dover@proton.me>
9 months agoMerge pull request #60173 from rhcs-dashboard/fix-lc
afreen23 [Thu, 17 Oct 2024 11:41:54 +0000 (17:11 +0530)]
Merge pull request #60173 from rhcs-dashboard/fix-lc

mgr/dashboard: fix lifecycle issues

Reviewed-by: Afreen Misbah <afreen@ibm.com>
9 months agoMerge pull request #60260 from ShwetaBhosale1/new_cephadm_command_to_list_default_images
Adam King [Thu, 17 Oct 2024 11:12:01 +0000 (07:12 -0400)]
Merge pull request #60260 from ShwetaBhosale1/new_cephadm_command_to_list_default_images

cephadm: Added cephadm command to list all the default images

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
9 months agoMerge pull request #55808 from neesingh-rh/wip-63700
Venky Shankar [Thu, 17 Oct 2024 06:31:27 +0000 (12:01 +0530)]
Merge pull request #55808 from neesingh-rh/wip-63700

cephfs-shell: fixing cephfs-shell test failures

Reviewed-by: Venky Shankar <vshankar@redhat.com>
9 months agomgr/dashboard: fix lifecycle issues 60173/head
Pedro Gonzalez Gomez [Mon, 7 Oct 2024 19:22:20 +0000 (21:22 +0200)]
mgr/dashboard: fix lifecycle issues

Fixes: https://tracker.ceph.com/issues/68434
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
9 months agoMerge pull request #58292 from neesingh-rh/wip-vol-method-name-change
Venky Shankar [Thu, 17 Oct 2024 05:21:16 +0000 (10:51 +0530)]
Merge pull request #58292 from neesingh-rh/wip-vol-method-name-change

mgr/vol : shortening the name of helper method

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
9 months agocephadm: Added new cephadm command to list all the default images 60260/head
Shweta Bhosale [Wed, 9 Oct 2024 09:23:30 +0000 (14:53 +0530)]
cephadm: Added new cephadm command to list all the default images

Fixes: https://tracker.ceph.com/issues/68438
Signed-off-by: Shweta Bhosale <Shweta.Bhosale1@ibm.com>
9 months agoMerge pull request #60058 from mchangir/log-save-thread-name-in-log-entries
Yuri Weinstein [Wed, 16 Oct 2024 20:42:33 +0000 (13:42 -0700)]
Merge pull request #60058 from mchangir/log-save-thread-name-in-log-entries

log: save/fetch thread name infra

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
9 months agoMerge PR #60317 into main
Patrick Donnelly [Wed, 16 Oct 2024 19:34:40 +0000 (15:34 -0400)]
Merge PR #60317 into main

* refs/pull/60317/head:
.github: detect GPL license in PRs

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
9 months agoMerge PR #59996 into main
Patrick Donnelly [Wed, 16 Oct 2024 19:32:00 +0000 (15:32 -0400)]
Merge PR #59996 into main

* refs/pull/59996/head:
mailmap: Add dashboard new joinees in maps

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
9 months agoMerge pull request #60053 from rkachach/fix_issue_68315
Adam King [Wed, 16 Oct 2024 18:07:30 +0000 (14:07 -0400)]
Merge pull request #60053 from rkachach/fix_issue_68315

mgr/cephadm: move Grafana's subpath handling logic to grafan config

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
9 months agomgr/smb: rm all `smb dump` commands 60347/head
Avan Thakkar [Wed, 16 Oct 2024 07:59:34 +0000 (13:29 +0530)]
mgr/smb: rm all `smb dump` commands

Fixes: https://tracker.ceph.com/issues/68545
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
9 months agoMerge pull request #59680 from adk3798/bootstrap-apply-spec-fail-continue
Adam King [Wed, 16 Oct 2024 15:49:38 +0000 (11:49 -0400)]
Merge pull request #59680 from adk3798/bootstrap-apply-spec-fail-continue

cephadm: add ability to continue on failure when applying multiple specs

Reviewed-by: John Mulligan <jmulligan@redhat.com>
9 months agoMerge pull request #60077 from adk3798/cephadm-ganesha-conf-allow-set-io-flusher...
Adam King [Wed, 16 Oct 2024 15:37:14 +0000 (11:37 -0400)]
Merge pull request #60077 from adk3798/cephadm-ganesha-conf-allow-set-io-flusher-fail

mgr/cephadm: add "allow_set_io_flusher_fail = true;" to ganesha conf

Reviewed-by: Guillaume Abrioux <gabrioux@ibm.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
9 months agoMerge pull request #60300 from avanthakkar/add-smb-ok-to-stop
Adam King [Wed, 16 Oct 2024 15:35:27 +0000 (11:35 -0400)]
Merge pull request #60300 from avanthakkar/add-smb-ok-to-stop

mgr/cephadm: add ok_to_stop func for smb service

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Anoop C S <anoopcs@cryptolab.net>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
9 months agoMerge pull request #60112 from anoopcs9/cephadm-smb-add-ctdb-loglevel
Adam King [Wed, 16 Oct 2024 15:31:54 +0000 (11:31 -0400)]
Merge pull request #60112 from anoopcs9/cephadm-smb-add-ctdb-loglevel

cephadm/smb: Add a provision to specify ctdb log level

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
9 months agoMerge pull request #60263 from afreen23/wip-api-update
afreen23 [Wed, 16 Oct 2024 15:23:05 +0000 (20:53 +0530)]
Merge pull request #60263 from afreen23/wip-api-update

mgr/dashboard: Adapt gateway group changes in nvmeof UI

Reviewed-by: Afreen Misbah <afreen@ibm.com>
9 months agoexporter: New metric for report ceph daemons health 60167/head
Juan Miguel Olmo Martínez [Mon, 7 Oct 2024 14:55:51 +0000 (16:55 +0200)]
exporter: New metric for report ceph daemons health

Ceph exporter provide metrics to report ceph daemons communication health using
 the admin socket

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2146728
       https://tracker.ceph.com/issues/68428

Signed-off-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
9 months agoMerge pull request #60306 from cbodley/wip-osdc-rm-completion
Casey Bodley [Wed, 16 Oct 2024 14:01:07 +0000 (10:01 -0400)]
Merge pull request #60306 from cbodley/wip-osdc-rm-completion

osdc: remove unused overloads for async::Completion

Reviewed-by: Adam Emerson <aemerson@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
9 months agoorch: disk replacement enhancement 60223/head
Guillaume Abrioux [Wed, 31 Jul 2024 14:36:48 +0000 (14:36 +0000)]
orch: disk replacement enhancement

This introduces a new `ceph orch device replace` command in order to
improve the user experience when it comes to replacing the underlying
device of an OSD.

Fixes: https://tracker.ceph.com/issues/68456
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
9 months agoceph-volume: address mypy errors in disk.py
Guillaume Abrioux [Wed, 9 Oct 2024 15:00:53 +0000 (15:00 +0000)]
ceph-volume: address mypy errors in disk.py

typical error:

```
ceph_volume/util/disk.py:1374: error: Incompatible types in assignment (expression has type "Optional[str]", variable has type "str")  [assignment]
```

This commits addresses it.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
9 months agoceph-volume: address test_activate_dmcrypt_tpm
Guillaume Abrioux [Wed, 9 Oct 2024 14:59:38 +0000 (14:59 +0000)]
ceph-volume: address test_activate_dmcrypt_tpm

This mocks the call to `luks_close()`, otherwise this test
fails when run on a system where `cryptsetup` isn't available.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
9 months agoMerge PR #59503 into main
Venky Shankar [Wed, 16 Oct 2024 13:36:32 +0000 (19:06 +0530)]
Merge PR #59503 into main

* refs/pull/59503/head:
client: Resolve symlink from dirfd for empty pathname
client: Fix symlink open with O_PATH and O_NOFOLLOW

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
9 months agoos/bluestore: Fix repair of multilabel when collides with BlueFS 60323/head
Adam Kupczyk [Tue, 15 Oct 2024 12:41:22 +0000 (12:41 +0000)]
os/bluestore: Fix repair of multilabel when collides with BlueFS

The problem was that BDEV_FIRST_LABEL_POSITION was removed from
bdev_label_valid_locations set.
Now, if label at BDEV_FIRST_LABEL_POSITION is valid, it is in the set.

Fixes: https://tracker.ceph.com/issues/68528
Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
9 months agoMerge pull request #60055 from guits/tracker_68312
Guillaume Abrioux [Wed, 16 Oct 2024 07:35:49 +0000 (09:35 +0200)]
Merge pull request #60055 from guits/tracker_68312

ceph-volume: drop unnecessary call to `get_single_lv()`

9 months agoMerge pull request #60291 from rhcs-dashboard/NFS-subvol-list
Nizamudeen A [Wed, 16 Oct 2024 06:40:32 +0000 (12:10 +0530)]
Merge pull request #60291 from rhcs-dashboard/NFS-subvol-list

mgr/dashboard: The subvolumes are missing from the dropdown menu on the "Create NFS export" page

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
9 months agoMerge pull request #60256 from joscollin/wip-doc-update-key-idea
Zac Dover [Wed, 16 Oct 2024 05:14:12 +0000 (15:14 +1000)]
Merge pull request #60256 from joscollin/wip-doc-update-key-idea

doc: update Key Idea in cephfs-mirroring.rst

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Zac Dover <zac.dover@proton.me>
9 months agoMerge pull request #60222 from rhcs-dashboard/group-name-bug
afreen23 [Tue, 15 Oct 2024 18:30:17 +0000 (00:00 +0530)]
Merge pull request #60222 from rhcs-dashboard/group-name-bug

mgr/dashboard: fix group name bugs in the nvmeof API

Reviewed-by: Afreen Misbah <afreen@ibm.com>
9 months agoMerge pull request #60060 from guits/move-to-quay-io
Adam King [Tue, 15 Oct 2024 18:01:37 +0000 (14:01 -0400)]
Merge pull request #60060 from guits/move-to-quay-io

cephadm: pull container images from quay.io

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
9 months agoMerge pull request #60241 from rhcs-dashboard/sync-policy-display-zonegroup
afreen23 [Tue, 15 Oct 2024 17:08:00 +0000 (22:38 +0530)]
Merge pull request #60241 from rhcs-dashboard/sync-policy-display-zonegroup

mgr/dashboard: sync policy's in Object >> Multi-site >> Sync-policy does not show the zonegroup to which policy belongs to

Reviewed-by: Afreen Misbah <afreen@ibm.com>