]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Lenz Grimmer [Mon, 21 Sep 2020 09:48:28 +0000 (11:48 +0200)]
Merge pull request #36900 from wjwithagen/wjw-enhance-mgr_module.py
mgr/dashboard: Report the missing path in error message
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
Lenz Grimmer [Mon, 21 Sep 2020 09:45:19 +0000 (11:45 +0200)]
Merge pull request #37087 from tspmelo/wip-iscsi-logged-in
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
Kefu Chai [Mon, 21 Sep 2020 09:43:17 +0000 (17:43 +0800)]
Merge pull request #37261 from tchaikov/wip-47552
common/BackTrace: do not use len for length of demangled symbol
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Kefu Chai [Mon, 21 Sep 2020 09:38:56 +0000 (17:38 +0800)]
Merge pull request #37185 from david-z/wip-fix-osdmaptool
tools/osdmaptool.cc: fix inaccurate pg map result when simulating osd out
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Kefu Chai [Mon, 21 Sep 2020 09:37:21 +0000 (17:37 +0800)]
Merge pull request #37210 from changchengx/no_tune_message
messenger: remove unused variable
Reviewed-by: Kefu Chai <kchai@redhat.com>
Lenz Grimmer [Mon, 21 Sep 2020 08:42:19 +0000 (10:42 +0200)]
Merge pull request #37183 from rhcs-dashboard/fix-47434-master
mgr/dashboard: table detail rows overflow
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Kefu Chai [Mon, 21 Sep 2020 06:41:35 +0000 (14:41 +0800)]
Merge pull request #37268 from anthonyeleven/anthonyeleven/doc-fixes
doc/man: Add optional reweight-by-utilization args
Reviewed-by: Zac Dover <zac.dover@gmail.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Anthony D'Atri [Mon, 21 Sep 2020 00:37:58 +0000 (17:37 -0700)]
doc/man: Add optional reweight-by-utilization args
doc/mgr: Grammar and wording for Prometheus labels
doc/rados: Spelling and clarity
Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>
Brad Hubbard [Mon, 21 Sep 2020 01:34:58 +0000 (11:34 +1000)]
Merge pull request #37176 from badone/wip-enable-mgr-client-debug
qa: Enable debug_client for mgr tests
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Changcheng Liu [Thu, 17 Sep 2020 05:15:44 +0000 (13:15 +0800)]
messenger: remove unused variable
Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>
Kefu Chai [Sun, 20 Sep 2020 03:30:26 +0000 (11:30 +0800)]
common/BackTrace: do not use len for length of demangled symbol
it turns out `len` is longer than the length of demangled symbol,
let's rely on the `\0` sentry in the returned char* string instead.
in this change, use `status` to tell if the demangle is successful or
not.
Fixes: https://tracker.ceph.com/issues/47552
Signed-off-by: Kefu Chai <kchai@redhat.com>
Ilya Dryomov [Sat, 19 Sep 2020 09:36:43 +0000 (11:36 +0200)]
Merge pull request #37072 from idryomov/wip-kcephfs-blacklisted-string
mds: add " (blacklisted)" to session reject error string
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Kefu Chai [Sat, 19 Sep 2020 04:08:35 +0000 (12:08 +0800)]
Merge pull request #37207 from tchaikov/wip-doc-dev-osx
doc/dev/macos.rst: disable features not supported on osx
Reviewed-by: Kamoltat Sirivadhna <ksirivad@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Kefu Chai [Sat, 19 Sep 2020 03:07:52 +0000 (11:07 +0800)]
Merge pull request #37252 from pponnuvel/spellcheck-docs
doc: Fixed a number of typos in documentation
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Sat, 19 Sep 2020 02:57:58 +0000 (10:57 +0800)]
Merge pull request #37216 from tchaikov/wip-doc-cephadmin-codeblock
doc/cephadm: use appropriate directive for formatting codeblocks
Reviewed-by: Zac Dover <zac.dover@gmail.com>
Patrick Donnelly [Sat, 19 Sep 2020 01:54:57 +0000 (18:54 -0700)]
Merge PR #37202 into master
* refs/pull/37202/head:
mon: allow overriding the initial mon_host
Reviewed-by: Neha Ojha <nojha@redhat.com>
Kefu Chai [Sat, 19 Sep 2020 01:33:31 +0000 (09:33 +0800)]
Merge pull request #37224 from tchaikov/wip-cmake-boost-MPL-list-size
cmake: introduce Boost::MPL interface library for increasing BOOST_MPL_LIMIT_LIST_SIZE
Reviewed-by: David Zafman <dzafman@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Patrick Donnelly [Sat, 19 Sep 2020 00:29:27 +0000 (17:29 -0700)]
Merge PR #37214 into master
* refs/pull/37214/head:
mgr/volumes/nfs: Check if orchestrator spec service_id is valid
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Sat, 19 Sep 2020 00:27:09 +0000 (17:27 -0700)]
Merge PR #37190 into master
* refs/pull/37190/head:
mon/MonCap: check profile_grants too while checking caps
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Sat, 19 Sep 2020 00:24:38 +0000 (17:24 -0700)]
Merge PR #37148 into master
* refs/pull/37148/head:
mds/FSMap: do not set legacy_client_fscid after filtering
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Patrick Donnelly [Sat, 19 Sep 2020 00:23:32 +0000 (17:23 -0700)]
Merge PR #37037 into master
* refs/pull/37037/head:
mds: fix purge_queue's _calculate_ops is inaccurate
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Fri, 18 Sep 2020 23:25:59 +0000 (16:25 -0700)]
Merge PR #37218 into master
* refs/pull/37218/head:
qa: spawn MDS daemons before creating fs
Reviewed-by: Kefu Chai <kchai@redhat.com>
Neha Ojha [Fri, 18 Sep 2020 21:31:45 +0000 (14:31 -0700)]
Merge pull request #35906 from gregsfortytwo/wip-stretch-mode
Add a new stretch mode for 2-site Ceph clusters
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Patrick Donnelly [Fri, 18 Sep 2020 18:04:11 +0000 (11:04 -0700)]
Merge PR #36957 into master
* refs/pull/36957/head:
mds: convert stringstream to CachedStackStringStream
Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
Michael Fritch [Fri, 18 Sep 2020 17:50:35 +0000 (11:50 -0600)]
Merge pull request #37245 from mgfritch/cephadm-extra-ceph-conf-test
mgr/cephadm: fixup expected extra ceph conf test result
Reviewed-by: Adam King <adking@redhat.com>
Ponnuvel Palaniyappan [Fri, 18 Sep 2020 17:12:07 +0000 (18:12 +0100)]
doc: Fixed a number of typos in documentation
Signed-off-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com>
Michael Fritch [Fri, 18 Sep 2020 14:54:00 +0000 (08:54 -0600)]
mgr/cephadm: fixup expected extra ceph conf test result
fix test failure introduced by:
ff7e76348e5457fa6acb23545fcef56d6640c50a
```
E AssertionError: expected call not found.
E Expected: _run_cephadm('test', 'mon.test', 'deploy', ['--name', 'mon.test', '--reconfig', '--config-json', '-'], stdin='{"config": "\\n\\n[mon]\\nk=v\\n", "keyring": ""}')
E Actual: _run_cephadm('test', 'mon.test', 'deploy',
['--name', 'mon.test', '--reconfig', '--config-json', '-'],
stdin='{"config": "\\n\\n[mon]\\nk=v\\n", "keyring": ""}', image='')
```
Signed-off-by: Michael Fritch <mfritch@suse.com>
Lenz Grimmer [Fri, 18 Sep 2020 10:59:30 +0000 (12:59 +0200)]
Merge pull request #34545 from rhcs-dashboard/read_only
mgr/dashboard: Disabling the form inputs for the read_only modals
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Lenz Grimmer [Fri, 18 Sep 2020 09:58:47 +0000 (11:58 +0200)]
Merge pull request #37023 from p-se/grafana-many-to-many
mgr/dashboard: Fix many-to-many issue in host-details Grafana dashboard
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Joshua Schmid [Fri, 18 Sep 2020 08:57:52 +0000 (10:57 +0200)]
Merge pull request #37059 from guits/guits-cephadm-shell-multiple-mounts
cephadm: support multiple mounts when running interactive shell
Joshua Schmid [Fri, 18 Sep 2020 08:56:24 +0000 (10:56 +0200)]
Merge pull request #36890 from sebastian-philipp/cephadm-extend-ceph.conf
mgr/cephadm: Add extra-ceph-conf
Joshua Schmid [Fri, 18 Sep 2020 08:55:17 +0000 (10:55 +0200)]
Merge pull request #37135 from sebastian-philipp/cephadm-race-add-host-vs-apply
mgr/cephadm: Fix race between host_add and _apply_all_specs
Joshua Schmid [Fri, 18 Sep 2020 08:50:30 +0000 (10:50 +0200)]
Merge pull request #36969 from votdev/issue_46666_container_spec
cephadm: Introduce 'container' specification to deploy custom containers
Rishabh Dave [Wed, 16 Sep 2020 10:59:24 +0000 (16:29 +0530)]
mon/MonCap: check profile_grants too while checking caps
When checking if a certain fs subcommand can and should be executed in
FSCommands.cc, check permissions in "profile_grants" too when the caps
for that entity contains a cap profile.
Fixes: https://tracker.ceph.com/issues/47423
Signed-off-by: Rishabh Dave <ridave@redhat.com>
Kefu Chai [Fri, 18 Sep 2020 07:18:31 +0000 (15:18 +0800)]
Merge pull request #37158 from tchaikov/wip-no-more-assertDictContainsSubset
mgr/dashboard: replace assertDictContainsSubset() with assertLessEqual()
Reviewed-by: Volker Theile <vtheile@suse.com>
Kefu Chai [Fri, 18 Sep 2020 05:42:44 +0000 (13:42 +0800)]
Merge pull request #37170 from yaarith/add-smartctl-nvme-dependencies
ceph.spec, debian: add smartmontools, nvme-cli dependencies
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Fri, 18 Sep 2020 04:23:13 +0000 (12:23 +0800)]
cmake: introduce Boost::MPL interface library
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Fri, 18 Sep 2020 03:01:19 +0000 (11:01 +0800)]
src: Revert "Fix to raise BOOST_MPL_LIMIT_LIST_SIZE from 20 to 30"
This reverts commit
3f4e9a4526b8f174888828078e610769b80e48ec .
will fix the FTBFS by introducing a interface library in CMake script
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Fri, 18 Sep 2020 04:17:44 +0000 (12:17 +0800)]
cmake: extract admin/CMakeLists.txt
for better modularity
Signed-off-by: Kefu Chai <kchai@redhat.com>
Yaarit Hatuka [Fri, 18 Sep 2020 03:25:56 +0000 (03:25 +0000)]
ceph.spec.in, debian/control: add smartmontools and nvme-cli dependencies
These packages are needed in order to scrape device health metrics from
devices used by OSD and MON daemons.
smartmontools' smartctl is what we use in order to scrape devices' SMART
attributes and general health metrics.
In addition, we use nvme-cli tool on NVMe devices, which fetches
vendor specific NVMe related health metrics.
Ceph rely on these tools for proper functioning of the underlying layers
of devicehealth mgr module, and other mgr modules which use devicehealth
functionality (such as diskprediction_local, telemetry, dashboard).
Essentially, most of devicehealth commands rely on proper functioning of
smartctl, otherwise they lack the device health metrics.
For example, in case smartctl is missing, the commands:
ceph device scrape-daemon-health-metrics <who>
ceph device scrape-health-metrics [<devid>]
will not be able to scrape health metrics, and the command:
ceph device predict-life-expectancy <devid>
will not provide any meaningful output (since there are no metrics).
In short, when we scrape a device by its daemon (be it an OSD or a MON):
ceph device scrape-daemon-health-metrics <who>
The devicehealth module command eventually invokes a
block_device_get_metrics() call in either osd/OSD.cc or mon/Monitor.cc,
which wraps calls to both
block_device_run_smartctl() (spawns smartctl)
block_device_run_vendor_nvme() (spawns nvme)
in common/blkdev.cc.
Minimum version requirements:
'smartmontools' is the package name, which contains two utility
programs: 'smartd' and 'smartctl'. Ceph uses the latter.
Version 6.7 of smartctl first introduced the --json option (beta), which
allows to output the metrics in a JSON format. Since then a few
adjustments were made and the feature officially launched in smartctl
version 7.0.
Since we rely on the JSON format to process the metrics, we must have
smartmontools' smartctl version >= 7.
That said, we choose not to specify smartmontools version here on
purpose, since there might be a scenario where:
We specified smartmontools version to be >= 7.
smartmontools 7 is not available yet in rhel 8 / centos 8.
A user installs via rpm ceph-osd, for example.
smartmontools will not be installed (since version >= 7 is not available
in this repo yet).
Then the user upgrades to 8.3 (which should have smartmontools >= 7),
but smartmontools will not get upgraded (since it's not installed).
In the scenario where we do not specify a version, smartmontools 6.6
will be installed, but it will be upgraded to >= 7 when a user upgrades
(and if it's a fresh installation - version >= 7 would be installed
anyway).
nvme-cli does not have a minimum version.
We use 'Recommends' for both rpm and deb packages since we do not want
the installation to fail in case of conflicts. 'Recommends' weakens the
dependency to be installed in case possible, but ignores it in cases of
conflicts with other dependencies.
It's worth mentioning that smartmontools and nvme-cli dependencies exist
in ceph-container builds.
We add them here for the cases of bare metal installations.
In the future we will add a separate package (with smartmontools and
nvme-cli dependencies) that can be installed on any node (running
rbd-mirror, rgw, mds, mgr, etc.), in order to be able to collect the
health metrics of its devices and offer their life expectancy
prediction.
Fixes: https://tracker.ceph.com/issues/47479
Signed-off-by: Yaarit Hatuka <yaarit@redhat.com>
Patrick Donnelly [Wed, 2 Sep 2020 23:51:50 +0000 (16:51 -0700)]
mds: convert stringstream to CachedStackStringStream
This is a simple performance refactor.
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Fri, 18 Sep 2020 01:30:11 +0000 (18:30 -0700)]
Merge PR #37163 into master
* refs/pull/37163/head:
mds: silence warning ‘MDSRank::fs_name’ will be initialized after [-Wreorder]
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Fri, 18 Sep 2020 01:28:13 +0000 (18:28 -0700)]
Merge PR #37147 into master
* refs/pull/37147/head:
mds/FSMap: check parse_role return before filtering
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
David Zafman [Fri, 18 Sep 2020 00:45:42 +0000 (17:45 -0700)]
Merge pull request #36989 from AmnonHanuhov/wip-ObjectStore_EIO_Handling
osd: Got rid of global flag eio_errors_to_process
Reviewed-by: David Zafman <dzafman@redhat.com>
David Zafman [Fri, 18 Sep 2020 00:30:43 +0000 (17:30 -0700)]
Merge pull request #36397 from dzafman/wip-39012
distinguish unfound + impossible to find, vs start some down OSDs to get
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Jason Dillaman [Thu, 17 Sep 2020 23:04:29 +0000 (19:04 -0400)]
Merge pull request #37132 from lixiaoy1/dirty_cache_feature
librbd: add DIRTY_CACHE in IMPLICIT_ENABLE
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Jason Dillaman [Thu, 17 Sep 2020 21:52:30 +0000 (17:52 -0400)]
Merge pull request #36586 from MahatiC/wip-ssd-integration
librbd/cache: SSD cache integration framework
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Kefu Chai [Thu, 17 Sep 2020 16:32:22 +0000 (00:32 +0800)]
Merge pull request #37141 from sebastian-philipp/cephadm-fix-rm-util.load_from_store
mgr/cephadm: fix RemoveUtil.load_from_store()
Reviewed-by: Joshua Schmid <jschmid@suse.de>
Patrick Donnelly [Thu, 17 Sep 2020 16:01:33 +0000 (09:01 -0700)]
qa: spawn MDS daemons before creating fs
This avoids unnecessary MDS_ALL_DOWN messages because the MDS daemons
have not yet been spawned.
Fixes: https://tracker.ceph.com/issues/47518
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Kefu Chai [Fri, 11 Sep 2020 23:04:14 +0000 (07:04 +0800)]
doc/cephadm: use appropriate directive for formatting codeblocks
Signed-off-by: Kefu Chai <kchai@redhat.com>
Patrick Donnelly [Thu, 17 Sep 2020 13:42:33 +0000 (06:42 -0700)]
Merge PR #37197 into master
* refs/pull/37197/head:
doc: add "fs authorize" subcommand to ceph man page
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Kefu Chai [Thu, 17 Sep 2020 10:40:06 +0000 (18:40 +0800)]
Merge pull request #37120 from tchaikov/wip-rados-type-hintings
pybind/rados: add more type hintings
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Varsha Rao [Thu, 17 Sep 2020 10:39:52 +0000 (16:09 +0530)]
mgr/volumes/nfs: Check if orchestrator spec service_id is valid
Fixes: https://tracker.ceph.com/issues/47512
Signed-off-by: Varsha Rao <varao@redhat.com>
Kefu Chai [Thu, 17 Sep 2020 10:39:09 +0000 (18:39 +0800)]
Merge pull request #37143 from dvanders/dvanders_flush
ceph.in: ignore failures to flush stdout
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Thu, 17 Sep 2020 10:38:15 +0000 (18:38 +0800)]
Merge pull request #37100 from rhcs-dashboard/fix-47400-master
ceph: ignore BrokenPipeError when printing help
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Thu, 17 Sep 2020 10:16:06 +0000 (18:16 +0800)]
Merge pull request #37045 from tchaikov/wip-crimson-bt
common/BackTrace: extract demangle() out
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Volker Theile [Wed, 16 Sep 2020 10:06:36 +0000 (12:06 +0200)]
cephadm: Introduce 'container' specification to deploy custom containers
Fixes: https://tracker.ceph.com/issues/46666
Signed-off-by: Volker Theile <vtheile@suse.com>
Kefu Chai [Wed, 9 Sep 2020 00:42:24 +0000 (08:42 +0800)]
common/BackTrace: let abi::__cxa_demangle() do the malloc
also use the returned length for constructing the string_view to be
appended.
we could reuse the buffer across multiple demangle() call for saving the
calls to malloc()/free(). but the upside of this change is that it's
simpler.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Tue, 8 Sep 2020 11:52:46 +0000 (19:52 +0800)]
common/BackTrace: extract demangle() out
so it can be reused by crimson
Signed-off-by: Kefu Chai <kchai@redhat.com>
Rishabh Dave [Thu, 20 Aug 2020 13:00:12 +0000 (18:30 +0530)]
doc: add "fs authorize" subcommand to ceph man page
Signed-off-by: Rishabh Dave <ridave@redhat.com>
Kefu Chai [Thu, 17 Sep 2020 04:19:47 +0000 (12:19 +0800)]
doc/dev/macos.rst: disable features not supported on osx
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Thu, 17 Sep 2020 04:04:08 +0000 (12:04 +0800)]
Merge pull request #37187 from kamoltat/patch-1
doc/dev/macos: remove nonexistence flag `--with-toolchain`
Reviewed-by: Kefu Chai <kchai@redhat.com>
Patrick Donnelly [Wed, 16 Sep 2020 19:28:55 +0000 (12:28 -0700)]
mon: allow overriding the initial mon_host
This overrides what the CephContext believes to be the current quorum of
monitors (retrieved from other instances of the MonClient), introduced
by [1]. Tests need to be able to target a specific monitor for
exercising forwarding and other things.
[1]
731e2db9fb4611f767446a3c8e778a097ce70d35
Fixes: https://tracker.ceph.com/issues/47180
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Greg Farnum [Thu, 17 Sep 2020 00:37:23 +0000 (00:37 +0000)]
test: remove a now-erroneous "mon add" CLI test from ceph_test_argparse.py
The "mon add" command now lets you pass in arbitrary numbers of strings,
so that you can include locations, so this test is invalid.
I considered updating it to only allow a single non-spaced string, but
datacenter=site1 rack=abc host=host1
is accepted elsewhere, so let's keep that consistent and just remove
this test instead.
Signed-off-by: Greg Farnum <gfarnum@redhat.com>
Patrick Donnelly [Wed, 16 Sep 2020 23:44:38 +0000 (16:44 -0700)]
Merge PR #37199 into master
* refs/pull/37199/head:
qa/cephfs: add a note to test_nfs.py
Reviewed-by: Varsha Rao <varao@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
David Zafman [Tue, 15 Sep 2020 00:11:07 +0000 (17:11 -0700)]
doc: Add doc and PendingRealeaseNotes
Add help about new list_unfound fields in troubleshooting-pg.rst
Add info in PendingReleaseNotes
Signed-off-by: David Zafman <dzafman@redhat.com>
Patrick Donnelly [Wed, 16 Sep 2020 19:20:13 +0000 (12:20 -0700)]
Merge PR #37159 into master
* refs/pull/37159/head:
mon/MDSMonitor: return zero when mds is absent for "mds fail"
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Tiago Melo [Mon, 7 Sep 2020 09:47:19 +0000 (09:47 +0000)]
mgr/dashboard: Allow editing iSCSI targets with initiators logged-in
Fixes: https://tracker.ceph.com/issues/47393
Signed-off-by: Tiago Melo <tmelo@suse.com>
Rishabh Dave [Wed, 16 Sep 2020 16:39:17 +0000 (22:09 +0530)]
qa/cephfs: add a note to test_nfs.py
A note that tells that test_nfs.py is not yet compatible with
vstart_runner.py.
Signed-off-by: Rishabh Dave <ridave@redhat.com>
Neha Ojha [Wed, 16 Sep 2020 16:30:11 +0000 (09:30 -0700)]
Merge pull request #37167 from neha-ojha/wip-47239
qa/tasks/ceph_manager.py: remove redundant check in raw_cluster_cmd_result
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Jos Collin [Tue, 15 Sep 2020 14:27:22 +0000 (19:57 +0530)]
mds: silence warning ‘MDSRank::fs_name’ will be initialized after [-Wreorder]
Fixes the warning:
ceph/src/mds/MDSRank.h:436:17: warning: ‘MDSRank::fs_name’ will be initialized after [-Wreorder]
Signed-off-by: Jos Collin <jcollin@redhat.com>
Kamoltat Sirivadhna [Wed, 16 Sep 2020 09:17:54 +0000 (16:17 +0700)]
doc/dev/macos: remove nonexistence flag `--with-toolchain`
` --with-toolchain` is an old option from llvm 6
Signed-off-by: Kamoltat Sirivadhna <ksirivad@redhat.com>
Abhishek L [Wed, 16 Sep 2020 14:51:22 +0000 (16:51 +0200)]
Merge pull request #37109 from theanalyst/doc/releases/v15.2.5
doc: releases: notes for v15.2.5 octopus
Reviewed-By: Neha Ojha <nojha@redhat.com>
Reviewed-By: Nathan Cutler <ncutler@suse.com>
Kefu Chai [Wed, 16 Sep 2020 12:59:35 +0000 (20:59 +0800)]
Merge pull request #37166 from adamemerson/wip-undetailed-time
common/ceph_time: Don't define public things in time_detail
Reviewed-by: Kefu Chai <kchai@redhat.com>
Rishabh Dave [Tue, 15 Sep 2020 19:40:31 +0000 (01:10 +0530)]
mon/MDSMonitor: return zero when mds is absent for "mds fail"
... instead of EINVAL.
Signed-off-by: Rishabh Dave <ridave@redhat.com>
Jan Fajerski [Wed, 16 Sep 2020 12:25:24 +0000 (14:25 +0200)]
Merge pull request #37093 from guits/guits-bz1877672
ceph-volume: fix simple activate when legacy osd
Reviewed-by: Jan Fajerski <jfajerski@suse.com>
Lenz Grimmer [Wed, 16 Sep 2020 11:49:54 +0000 (13:49 +0200)]
Merge pull request #35956 from ishanrai05/hover
mgr/dashboard: Display description on mouse hover
Reviewed-by: Tiago Melo <tmelo@suse.com>
Matt Benjamin [Wed, 16 Sep 2020 11:20:51 +0000 (07:20 -0400)]
Merge pull request #35924 from pritha-srivastava/wip-rgw-sts-error-messages
rgw/sts: adding error log messages to STS code.
Matt Benjamin [Wed, 16 Sep 2020 11:09:14 +0000 (07:09 -0400)]
Merge pull request #36255 from pritha-srivastava/wip-rgw-sts-user-as-owner
rgw/sts: adding code for federated user as owner in case of STS.
Guillaume Abrioux [Thu, 10 Sep 2020 23:13:06 +0000 (01:13 +0200)]
ceph-volume: fix simple activate when legacy osd
`ceph-volume simple activate --all` relies on the presence of json files
in `/etc/ceph/osd` that was created with `ceph-volume simple scan`
command.
In a cluster lifecycle, it is very likely an OSD which was deployed with
ceph-disk at some point gets removed or replaced. It means the corresponding
json file in `/etc/ceph/osd` becomes unrelevant. It makes `ceph-volume
simple activate --all` fails because it tries to mount non existing
partitions.
The idea here is to simply warn the user that the osd described in the
json file doesn't exist anymore and exit properly instead of throwing an
error.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1877672
Closes: https://tracker.ceph.com/issues/47493
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
Joshua Schmid [Wed, 16 Sep 2020 08:04:28 +0000 (10:04 +0200)]
Merge pull request #36898 from sebastian-philipp/doc-fix-orch-apply-mgr
doc/mgr: fix outdated `orch apply` docs.
Aashish Sharma [Wed, 16 Sep 2020 06:49:10 +0000 (12:19 +0530)]
mgr/dashboard: table detail rows overflow
Added word-wrap to the rgw-bucket-details table rows to fix overflow of values
Fixes:https://tracker.ceph.com/issues/47434
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
Zhi Zhang [Wed, 16 Sep 2020 06:46:08 +0000 (14:46 +0800)]
tools/osdmaptool.cc: fix inaccurate pg map result when simulating osd out
When simulating osd out, it will always adjust this osd's crush weight
to 1.0. Hence the pg map result is not same as the real cluster or simulated
by crushtool.
Fixes: https://tracker.ceph.com/issues/47492
Signed-off-by: Zhi Zhang <zhangz.david@outlook.com>
Ali Maredia [Wed, 16 Sep 2020 05:38:50 +0000 (01:38 -0400)]
Merge pull request #35986 from TRYTOBE8TME/wip-rgw-sts-new
STS Testing Files
Kefu Chai [Wed, 16 Sep 2020 04:42:39 +0000 (12:42 +0800)]
Merge pull request #37172 from tchaikov/wip-crimson-object-context-lock
crimson/common/tri_mutex: update the class comment
Reviewed-by: Samuel Just <sjust@redhat.com>
Kefu Chai [Wed, 16 Sep 2020 01:12:52 +0000 (09:12 +0800)]
crimson/osd/object_context: s/rwlock/lock/
so it's less confusing.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Brad Hubbard [Wed, 16 Sep 2020 02:16:23 +0000 (12:16 +1000)]
qa: Enable debug_client for mgr tests
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
Kefu Chai [Wed, 16 Sep 2020 01:10:10 +0000 (09:10 +0800)]
crimson/common/tri_mutex: update the class comment
to explain the reason why we have tri_mutex, and how it is related to
pipelined read / write. and the mutual exclusion between read, write
and rmw operations.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Wed, 16 Sep 2020 01:01:32 +0000 (09:01 +0800)]
Merge pull request #37131 from tchaikov/wip-47311
crimson/object_context: make obc interruptible
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Ernesto Puerta [Fri, 11 Sep 2020 10:10:16 +0000 (12:10 +0200)]
ceph: ignore BrokenPipeError when printing help
ignore BrokenPipeError which is thrown when piping the output of ceph
CLI to a tool which might close its stdin before ceph CLI sends the
whole help message.
Follow approach suggested by Kefu: https://github.com/python/cpython/commit/
7b0ed43af55c1e2844aa0ccd5e088b2ddd38dbdb
This doesn't manage the clean-up/exit logic, as that's deferred to the
last part of the __main__ code.
Fixes: https://tracker.ceph.com/issues/47400
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
Adam C. Emerson [Tue, 15 Sep 2020 17:58:30 +0000 (13:58 -0400)]
common/ceph_time: Don't define public things in time_detail
Defining things in a detail section and then using them outside turned
out to not be the best idea.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Neha Ojha [Mon, 14 Sep 2020 21:43:50 +0000 (21:43 +0000)]
qa/tasks/ceph_manager.py: remove redundant check in raw_cluster_cmd_result
Fixes
530982129ec131ef78e2f9989abfaeddb0959c65 . The check for cephadm is no
longer needed since it was moved to run_cluster_cmd.
Fixes: https://tracker.ceph.com/issues/47239
Signed-off-by: Neha Ojha <nojha@redhat.com>
Kefu Chai [Tue, 15 Sep 2020 12:13:57 +0000 (20:13 +0800)]
mgr/dashboard: replace assertDictContainsSubset() with assertLessEqual()
to silence the warnings like
tests/test_access_control.py::AccessControlTest::test_show_all_users
/usr/lib/python3.6/unittest/case.py:1126: DeprecationWarning: assertDictContainsSubset is deprecated
DeprecationWarning)
as assertDictContainsSubset() method was deprecated, see also
https://dev.rbcafe.com/python/python-3.5.1/whatsnew/3.2.html#unittest
Signed-off-by: Volker Theile <vtheile@suse.com>
Pritha Srivastava [Wed, 5 Aug 2020 05:57:59 +0000 (11:27 +0530)]
rgw/sts: adding documentation for a shadow user created for
a user that authenticates with oidc provider.
Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
Pritha Srivastava [Wed, 22 Jul 2020 16:21:25 +0000 (21:51 +0530)]
rgw/sts: adding code for federated user as owner in case of STS.
A new user under the namespace 'oidc' is created for every federated
user in case of AssumeRoleWithWebIdentity.
In case of AssumeRole, the user that needs cross account access becomes
the owner.
In both cases buckets are created in the tenant that the role belongs to.
Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
Pritha Srivastava [Fri, 3 Jul 2020 15:21:03 +0000 (20:51 +0530)]
rgw/sts: adding error log messages to STS code.
Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
Nizamudeen [Tue, 14 Apr 2020 06:53:09 +0000 (12:23 +0530)]
mgr/dashboard: Custom Directive for verifying if user is read_only
This commit introduces two new Custom Directives: `FormInputDisableDirective` and `FormScopeDirective`.
By using the `cdFormScope` attribute of the directive we can customize the behaviour of the modal components.
Signed-off-by: Nizamudeen <nia@redhat.com>
Adam C. Emerson [Tue, 15 Sep 2020 15:16:53 +0000 (11:16 -0400)]
common/ceph_time: Don't indent under namespaces
This is a violation of our guidelines and since I'm making a larger
change anyway.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Guillaume Abrioux [Wed, 9 Sep 2020 08:14:33 +0000 (10:14 +0200)]
cephadm: support multiple mounts when running shell
This commit adds the multiple mounts support when running the
interactive shell.
ie:
```
--mount /foo /bar:/bar:z
```
Keeping default destination `/mnt` when no destination is passed for
backward compatibility. In the above example `/foo` will be mounted in
`/mnt/foo` and `/bar` in `/bar`
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
Mahati Chamarthy [Wed, 2 Sep 2020 09:53:06 +0000 (15:23 +0530)]
librbd/cache: Rename namespaces and move files
Signed-off-by: Lisa Li <xiaoyan.li@intel.com>
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@intel.com>
Signed-off-by: Changcheng Liu <changcheng.liu@intel.com>