]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
5 years agocmake: expose pmem::pmemobj from rbd_internal
Kefu Chai [Thu, 2 Apr 2020 04:19:50 +0000 (12:19 +0800)]
cmake: expose pmem::pmemobj from rbd_internal

because `librbd/cache/rwl/Types.h` includes `libpmemobj.h`, without this
change, `cache/test_mock_ReplicatedWriteLog.cc` will fail to compile as
`libpmemobj.h` might not exist in the default directories compile search
for header files. and hence we could have following failure
```
ceph/src/test/librbd/cache/test_mock_ReplicatedWriteLog.cc:11:
86 /root/luyuan/community/github/ceph/src/librbd/cache/rwl/Types.h:8:10: fatal error: libpmemobj.h: No such file or directory
87 8 | #include <libpmemobj.h>
88 | ^~~~~~~~~~~~~~
89 compilation terminated.
90 src/test/librbd/CMakeFiles/unittest_librbd.dir/build.make:1814: recipe for target 'src/test/librbd/CMakeFiles/unittest_librbd.dir/cache/test_mock_ReplicatedWriteLog.cc.o' failed
91 make[3]: *** [src/test/librbd/CMakeFiles/unittest_librbd.dir/cache/test_mock_ReplicatedWriteLog.cc.o] Error 1
92 make[3]: *** Waiting for unfinished jobs....
93 CMakeFiles/Makefile2:20379: recipe for target 'src/test/librbd/CMakeFiles/unittest_librbd.dir/all' failed
94 make[2]: *** [src/test/librbd/CMakeFiles/unittest_librbd.dir/all] Error 2
95 CMakeFiles/Makefile2:20391: recipe for target 'src/test/librbd/CMakeFiles/unittest_librbd.dir/rule' failed
96 make[1]: *** [src/test/librbd/CMakeFiles/unittest_librbd.dir/rule] Error 2
97 Makefile:5375: recipe for target 'unittest_librbd' failed
```

Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agocmake: do not use $(MAKE) in Buildpmem.cmake
Kefu Chai [Thu, 2 Apr 2020 04:15:21 +0000 (12:15 +0800)]
cmake: do not use $(MAKE) in Buildpmem.cmake

we cannot assume that we are using `make` as the cmake generatator,
for instance, if ninja is used, `$(MAKE)` won't be substituted by ninja.
so we need to check if Make is used as generator, if that's the case, we
can just use `$(MAKE)` so we can benefit from the job control of `make`,
otherwise, `make` is used, because currently, PMDK uses Makefile to
build.

Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agocmake: add find_make() function
Kefu Chai [Fri, 3 Apr 2020 04:39:16 +0000 (12:39 +0800)]
cmake: add find_make() function

it's a shorthand for finding "make" or "gmake" (for FreeBSD), and set
the path to the executable and the command to use in the generated
"Makefile" or whatever build script generated by cmake.

Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge pull request #34330 from mgfritch/cephadm-nfs-extra-args
Sebastian Wagner [Thu, 2 Apr 2020 18:02:46 +0000 (20:02 +0200)]
Merge pull request #34330 from mgfritch/cephadm-nfs-extra-args

cephadm: add `extra_args` to nfs daemon

Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
Reviewed-by: Varsha Rao <varao@redhat.com>
5 years agoMerge pull request #34361 from mgfritch/cephadm-revert-nfs-trivial
Sebastian Wagner [Thu, 2 Apr 2020 16:05:19 +0000 (18:05 +0200)]
Merge pull request #34361 from mgfritch/cephadm-revert-nfs-trivial

mgr/cephadm: revert trivial_completion for nfs_add

Reviewed-by: Matthew Oliver <moliver@suse.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agoMerge pull request #34329 from liewegas/cephadm-bootstrap-typo
Sebastian Wagner [Thu, 2 Apr 2020 16:02:51 +0000 (18:02 +0200)]
Merge pull request #34329 from liewegas/cephadm-bootstrap-typo

cephadm: fix typo

Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agoMerge pull request #34283 from tspmelo/wip-reduce-scss
Laura Paduano [Thu, 2 Apr 2020 14:51:57 +0000 (16:51 +0200)]
Merge pull request #34283 from tspmelo/wip-reduce-scss

mgr/dashboard: Reduce size of component styles

Reviewed-by: Ernesto Puertat <epuertat@redhat.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
5 years agoMerge pull request #33807 from ofriedma/wip-disable-range-prefetch
Casey Bodley [Thu, 2 Apr 2020 14:46:27 +0000 (10:46 -0400)]
Merge pull request #33807 from ofriedma/wip-disable-range-prefetch

rgw: Disable prefetch of entire head object when GET request with ran…

Reviewed-by: Matt Benjamin <mbenjami@redhat.com>
Reviewed-by: Mark Kogan <mkogan@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
5 years agoMerge pull request #34312 from tspmelo/wip-improve-unit-test
Lenz Grimmer [Thu, 2 Apr 2020 13:02:50 +0000 (15:02 +0200)]
Merge pull request #34312 from tspmelo/wip-improve-unit-test

mgr/dashboard: Fix ServiceDetails and PoolDetails unit tests

Reviewed-by: Stephan Müller <smueller@suse.com>
5 years agoMerge pull request #34206 from sebastian-philipp/cephadm-hostname-check-lowercase
Sebastian Wagner [Thu, 2 Apr 2020 12:27:30 +0000 (14:27 +0200)]
Merge pull request #34206 from sebastian-philipp/cephadm-hostname-check-lowercase

cephadm: check hostnames case insensitive

Reviewed-by: Sage Weil <sage@redhat.com>
5 years agoMerge pull request #34250 from Daniel-Pivonka/cephadm_python3
Sebastian Wagner [Thu, 2 Apr 2020 12:26:43 +0000 (14:26 +0200)]
Merge pull request #34250 from Daniel-Pivonka/cephadm_python3

mgr/cephadm: add useful error if python3 is not on remote host

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agoMerge pull request #33954 from jschmid1/parse_hostsspecs
Sebastian Wagner [Thu, 2 Apr 2020 12:25:54 +0000 (14:25 +0200)]
Merge pull request #33954 from jschmid1/parse_hostsspecs

python-common: fix /hosts/ parsing in servicespecs

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agoMerge pull request #34033 from rhcs-dashboard/44666-fix-sso-certificate-file
Lenz Grimmer [Thu, 2 Apr 2020 11:38:21 +0000 (13:38 +0200)]
Merge pull request #34033 from rhcs-dashboard/44666-fix-sso-certificate-file

mgr/dashboard: fix error when enabling SSO with cert. file

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
5 years agomgr/cephadm: revert trivial_completion for nfs_add 34361/head
Michael Fritch [Thu, 2 Apr 2020 03:10:40 +0000 (21:10 -0600)]
mgr/cephadm: revert trivial_completion for nfs_add

revert change that was missed in af8fa11

Signed-off-by: Michael Fritch <mfritch@suse.com>
5 years agoMerge pull request #34324 from rzarzynski/wip-crimson-returnvec
Kefu Chai [Thu, 2 Apr 2020 00:29:35 +0000 (08:29 +0800)]
Merge pull request #34324 from rzarzynski/wip-crimson-returnvec

crimson/osd: OP_CALL does support RETURNVEC now.

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge pull request #34290 from sebastian-philipp/doc-cephadm-service-spec
Sebastian Wagner [Wed, 1 Apr 2020 22:31:14 +0000 (00:31 +0200)]
Merge pull request #34290 from sebastian-philipp/doc-cephadm-service-spec

doc/mgr/orchestrator: Add "Service Specification"

Reviewed-by: Joshua Schmid <jschmid@suse.de>
5 years agoMerge pull request #34322 from cbodley/wip-44857
Casey Bodley [Wed, 1 Apr 2020 18:25:00 +0000 (14:25 -0400)]
Merge pull request #34322 from cbodley/wip-44857

rgw: pubsub sync module ignores ERR_USER_EXIST

Reviewed-by: Yuval Lifshitz <yuvalif@yahoo.com>
5 years agoMerge pull request #34134 from zhangdaolong/fix_incorrect_log_info
Mykola Golub [Wed, 1 Apr 2020 18:01:23 +0000 (21:01 +0300)]
Merge pull request #34134 from zhangdaolong/fix_incorrect_log_info

pybind/rbd: fix no lockers are obtained, ImageNotFound exception will be output

5 years agoMerge PR #34320 into master
Sage Weil [Wed, 1 Apr 2020 15:58:57 +0000 (10:58 -0500)]
Merge PR #34320 into master

* refs/pull/34320/head:
cephadm: ceph-volume: disallow concurrent execution

Reviewed-by: Sebastian Wagner <swagner@suse.com>
5 years agoMerge pull request #34096 from smanjara/wip-dynamic-resharding
Casey Bodley [Wed, 1 Apr 2020 15:55:06 +0000 (11:55 -0400)]
Merge pull request #34096 from smanjara/wip-dynamic-resharding

rgw: groundwork for supporting dynamic resharding in multisite environment

Reviewed-by: Casey Bodley <cbodley@redhat.com>
5 years agocrimson/osd: OP_CALL does support RETURNVEC now. 34324/head
Radoslaw Zarzynski [Tue, 31 Mar 2020 15:45:51 +0000 (17:45 +0200)]
crimson/osd: OP_CALL does support RETURNVEC now.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 years agoMerge pull request #34345 from tchaikov/wip-crimson-less-chatty
Kefu Chai [Wed, 1 Apr 2020 12:31:52 +0000 (20:31 +0800)]
Merge pull request #34345 from tchaikov/wip-crimson-less-chatty

crimson: do not warn() under expected circumstances

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 years agocrimson/osd: do not use "warn()" when handling non-error 34345/head
Kefu Chai [Wed, 1 Apr 2020 11:59:16 +0000 (19:59 +0800)]
crimson/osd: do not use "warn()" when handling non-error

Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agocrimson/mon: do not print error log at seeing unknown connection
Kefu Chai [Tue, 31 Mar 2020 07:32:58 +0000 (15:32 +0800)]
crimson/mon: do not print error log at seeing unknown connection

it happens if a client or an peer osd drops the connection, so it's not
an error and hence we should not print this error message using
"error()".

Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge pull request #34341 from guits/update_cv_deploy
Jan Fajerski [Wed, 1 Apr 2020 11:26:59 +0000 (13:26 +0200)]
Merge pull request #34341 from guits/update_cv_deploy

ceph-volume: update functional testing deploy.yml playbook

5 years agoMerge pull request #34331 from zealoussnow/wip-fix-clone-error
Kefu Chai [Wed, 1 Apr 2020 11:23:54 +0000 (19:23 +0800)]
Merge pull request #34331 from zealoussnow/wip-fix-clone-error

test/common/unittest_blkdev: delete unused test file

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agounittest_blkdev: delete unused test file 34331/head
Leo Zhang [Wed, 1 Apr 2020 02:55:12 +0000 (10:55 +0800)]
unittest_blkdev: delete unused test file

Signed-off-by: Leo Zhang <nguzcf@gmail.com>
5 years agodoc/mgr/orchestrator: Update `Placement by pattern matching` 34290/head
Sebastian Wagner [Wed, 1 Apr 2020 09:33:51 +0000 (11:33 +0200)]
doc/mgr/orchestrator: Update `Placement by pattern matching`

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agodoc/cephadm/drivegroup: Don't introduce DriveGroups
Sebastian Wagner [Mon, 30 Mar 2020 14:48:16 +0000 (16:48 +0200)]
doc/cephadm/drivegroup: Don't introduce DriveGroups

We already have a name for it: a Service Specification of
type `osd`. We don't need to introduce a new name for it.

Well, they are "DriveGroups", but users don't need to know it.

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agodoc/cephadm/drivegroups: Update to new yaml
Sebastian Wagner [Mon, 30 Mar 2020 14:43:44 +0000 (16:43 +0200)]
doc/cephadm/drivegroups: Update to new yaml

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agodoc/mgr/orchestrator: use yaml syntax highlighting
Sebastian Wagner [Tue, 31 Mar 2020 13:21:45 +0000 (15:21 +0200)]
doc/mgr/orchestrator: use yaml syntax highlighting

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agodoc/mgr/orchestrator: Add "Service Specification"
Sebastian Wagner [Mon, 30 Mar 2020 14:36:46 +0000 (16:36 +0200)]
doc/mgr/orchestrator: Add "Service Specification"

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agoceph-volume: update functional testing deploy.yml playbook 34341/head
Guillaume Abrioux [Wed, 1 Apr 2020 09:32:40 +0000 (11:32 +0200)]
ceph-volume: update functional testing deploy.yml playbook

This commit adds a call to `ceph-facts` role in the first play of this
playbook. This is needed so `ceph-validate` won't fail because of
following error:

```
fatal: [osd0]: FAILED! => {}

MSG:

'osd_pool_default_size' is undefined
```

`osd_pool_default_size` is set in ceph-facts.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
5 years agopybind/rbd: fix no lockers are obtained, ImageNotFound exception will be output 34134/head
zhangdaolong [Tue, 24 Mar 2020 00:51:44 +0000 (08:51 +0800)]
pybind/rbd: fix no lockers are obtained, ImageNotFound exception will be output

No lockers are obtained, ImageNotFound exception will be output,
but tht image is always exist.when lockers number is zero,
Should not output any exceptions。

Fixes: https://tracker.ceph.com/issues/44613
Signed-off-by: zhangdaolong <zhangdaolong@fiberhome.com>
5 years agoMerge pull request #34232 from bk201/wip-44743
Laura Paduano [Wed, 1 Apr 2020 08:15:41 +0000 (10:15 +0200)]
Merge pull request #34232 from bk201/wip-44743

qa/tasks/mgr/dashboard/test_rbd: wait longer when purging

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
5 years agomodified get_target_shard_id() to take bucket_index_normal_layout directly 34096/head
Shilpa Jagannath [Tue, 31 Mar 2020 11:20:58 +0000 (16:50 +0530)]
modified get_target_shard_id() to take bucket_index_normal_layout directly

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>
5 years agocephadm: add `extra_args` to nfs daemon 34330/head
Michael Fritch [Tue, 31 Mar 2020 23:39:03 +0000 (17:39 -0600)]
cephadm: add `extra_args` to nfs daemon

Signed-off-by: Michael Fritch <mfritch@suse.com>
5 years agocephadm: fix typo 34329/head
Sage Weil [Tue, 31 Mar 2020 23:06:46 +0000 (18:06 -0500)]
cephadm: fix typo

This has been bugging me

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agorgw: pubsub sync module ignores ERR_USER_EXIST 34322/head
Casey Bodley [Tue, 31 Mar 2020 14:46:33 +0000 (10:46 -0400)]
rgw: pubsub sync module ignores ERR_USER_EXIST

otherwise, this error gets returned by RGWPSDataSyncModule::start_sync()
and data sync fails to start

Fixes: https://tracker.ceph.com/issues/44857
Signed-off-by: Casey Bodley <cbodley@redhat.com>
5 years agoMerge pull request #34291 from dillaman/wip-44814
Yuri Weinstein [Tue, 31 Mar 2020 14:44:31 +0000 (07:44 -0700)]
Merge pull request #34291 from dillaman/wip-44814

librbd: fix client backwards compatibility issues

5 years agopython-common: add pyyaml to requirements file 33954/head
Joshua Schmid [Mon, 30 Mar 2020 15:44:13 +0000 (17:44 +0200)]
python-common: add pyyaml to requirements file

Signed-off-by: Joshua Schmid <jschmid@suse.de>
5 years agopython-common: python-common: fix /hosts/ parsing in servicespecs
Joshua Schmid [Thu, 12 Mar 2020 21:52:14 +0000 (22:52 +0100)]
python-common: python-common: fix /hosts/ parsing in servicespecs

Signed-off-by: Joshua Schmid <jschmid@suse.de>
5 years agoMerge pull request #34295 from sebastian-philipp/raise-for-invalid-dg
Sebastian Wagner [Tue, 31 Mar 2020 13:25:25 +0000 (15:25 +0200)]
Merge pull request #34295 from sebastian-philipp/raise-for-invalid-dg

python-common: raise on empty drive selections

Reviewed-by: Joshua Schmid <jschmid@suse.de>
5 years agocephadm: ceph-volume: disallow concurrent execution 34320/head
Sage Weil [Tue, 31 Mar 2020 13:16:25 +0000 (08:16 -0500)]
cephadm: ceph-volume: disallow concurrent execution

Fixes: https://tracker.ceph.com/issues/44820
Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoMerge pull request #34026 from votdev/issue_44539_shorten_container_id
Lenz Grimmer [Tue, 31 Mar 2020 13:01:37 +0000 (15:01 +0200)]
Merge pull request #34026 from votdev/issue_44539_shorten_container_id

mgr/dashboard: shorten `Container ID` and `Container image ID` in Services page

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
5 years agoqa/tasks/mgr/dashboard/test_rbd: wait longer when purging 34232/head
Kiefer Chang [Fri, 27 Mar 2020 05:14:09 +0000 (13:14 +0800)]
qa/tasks/mgr/dashboard/test_rbd: wait longer when purging

Fixes: https://tracker.ceph.com/issues/44743
Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
Co-authored-by: Kefu Chai <kefu@redhat.com>
Co-authored-by: Volker Theile <vtheile@suse.com>
5 years agoRemoved redundant encoding of layout.* and adjusted the corresponding decoding
Shilpa Jagannath [Tue, 31 Mar 2020 11:18:19 +0000 (16:48 +0530)]
Removed redundant encoding of layout.* and adjusted the corresponding decoding

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>
5 years agoMoved ostream operator overloading to BucketIndexType() to rgw_bucket_layout header...
Shilpa Jagannath [Tue, 31 Mar 2020 11:13:12 +0000 (16:43 +0530)]
Moved ostream operator overloading to BucketIndexType() to rgw_bucket_layout header file

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>
5 years agomgr/dashboard: Fix ServiceDetails and PoolDetails unit tests 34312/head
Tiago Melo [Mon, 30 Mar 2020 14:01:27 +0000 (14:01 +0000)]
mgr/dashboard: Fix ServiceDetails and PoolDetails unit tests

While testing the upgrade to Angular 9,
these 2 unit tests were consistently failling.

Fixes: https://tracker.ceph.com/issues/42929
Signed-off-by: Tiago Melo <tmelo@suse.com>
5 years agomgr/dashboard: shorten `Container ID` and `Container image ID` in Services page 34026/head
Volker Theile [Tue, 31 Mar 2020 09:13:21 +0000 (11:13 +0200)]
mgr/dashboard: shorten `Container ID` and `Container image ID` in Services page

Fixes: https://tracker.ceph.com/issues/44539
Signed-off-by: Volker Theile <vtheile@suse.com>
5 years agoMerge pull request #34259 from rzarzynski/wip-crimson-fix-bad-methods
Kefu Chai [Tue, 31 Mar 2020 09:04:49 +0000 (17:04 +0800)]
Merge pull request #34259 from rzarzynski/wip-crimson-fix-bad-methods

crimson/osd: fix method's flag handling on CEPH_OSD_OP_CALL.

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge pull request #34305 from tchaikov/wip-crimson-stddev
Kefu Chai [Tue, 31 Mar 2020 07:49:57 +0000 (15:49 +0800)]
Merge pull request #34305 from tchaikov/wip-crimson-stddev

test/crimson: increase variance of stdev to 0.20

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 years agoMerge pull request #34167 from javacruft/32bit-fixes-march
Gregory Farnum [Tue, 31 Mar 2020 06:54:30 +0000 (23:54 -0700)]
Merge pull request #34167 from javacruft/32bit-fixes-march

mds: resolve type mismatches on 32 bit archs

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
5 years agotest/crimson: increase variance of stdev to 0.20 34305/head
Kefu Chai [Tue, 31 Mar 2020 03:19:23 +0000 (11:19 +0800)]
test/crimson: increase variance of stdev to 0.20

per Mark Nelson,

> yeah, 5% variation is way too low
> Sometimes we can stay within 5%, but especially if we are pushing the
> system hard we can see closer to 10-20% sometimes.

Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge pull request #34112 from trociny/wip-44610
Jason Dillaman [Tue, 31 Mar 2020 00:50:44 +0000 (20:50 -0400)]
Merge pull request #34112 from trociny/wip-44610

pybind/rbd: ensure image is open before permitting operations

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
5 years agoMerge pull request #34019 from changchengx/blockguard
Jason Dillaman [Tue, 31 Mar 2020 00:49:48 +0000 (20:49 -0400)]
Merge pull request #34019 from changchengx/blockguard

librbd: refine BlockGuard debug output

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
5 years agoMerge PR #34150 into master
Sage Weil [Mon, 30 Mar 2020 20:22:32 +0000 (15:22 -0500)]
Merge PR #34150 into master

* refs/pull/34150/head:
cephadm: rm-cluster clean up /etc/ceph

Reviewed-by: Sage Weil <sage@redhat.com>
5 years agomgr/cephadm: add useful error if python3 is not on remote host 34250/head
Daniel-Pivonka [Fri, 27 Mar 2020 18:38:41 +0000 (14:38 -0400)]
mgr/cephadm: add useful error if python3 is not on remote host

show 'Error ENOENT: New host example (example) failed check: ["Can't communicate with
remote host, possibly because python3 is not installed there"]' instead of traceback
with OSError: cannot send(already closed?) when adding host if python3 is not on host

Signed-off-by: Daniel-Pivonka <dpivonka@redhat.com>
5 years agopython-common: raise on emtpy drive groups 34295/head
Sebastian Wagner [Mon, 30 Mar 2020 17:51:31 +0000 (19:51 +0200)]
python-common: raise on emtpy drive groups

adds a test for https://tracker.ceph.com/issues/44758

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agocephadm: check hostnames case insensitive 34206/head
Sebastian Wagner [Thu, 26 Mar 2020 11:21:31 +0000 (12:21 +0100)]
cephadm: check hostnames case insensitive

Salt converts minion names to lowercase.

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agolibrbd: re-add support for nautilus clients talking to jewel clusters 34291/head
Jason Dillaman [Thu, 2 May 2019 20:55:44 +0000 (16:55 -0400)]
librbd: re-add support for nautilus clients talking to jewel clusters

We want to support N - 3 client backward compatibility (special case
to support Jewel since it was a LTS release). The "get_snapshot_timestamp"
cls method does not exist in Jewel clusters so librbd should fallback
to excluding the op if it fails.

Note that this N - 3 also needs to apply for downstream releases as well,
which implies we still need Jewel for the time being.

Fixes: http://tracker.ceph.com/issues/39450
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit c644121820b83c97e68f9896393a45cd34787672)

Conflicts:
src/test/librbd/image/test_mock_RefreshRequest.cc: tweaked to support pool configs

5 years agolibrbd: ignore -EOPNOTSUPP errors when retrieving image group membership
Jason Dillaman [Wed, 20 Mar 2019 18:40:50 +0000 (14:40 -0400)]
librbd: ignore -EOPNOTSUPP errors when retrieving image group membership

The Luminous release did not support adding images to a group (it only
included the bare-minimum support for creating groups). Commit f76df32666b
incorrectly dropped support for ignoring this possible failure. This
prevents Nautilus-release clients from opening images contained within
a Luminous-release cluster.

Fixes: http://tracker.ceph.com/issues/38834
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 6f29dc69a0db3b6d982c95ab9d3b9b00a7029e37)

5 years agoMerge pull request #34253 from cbodley/wip-qa-rgw-too-many-shards
Casey Bodley [Mon, 30 Mar 2020 14:06:11 +0000 (10:06 -0400)]
Merge pull request #34253 from cbodley/wip-qa-rgw-too-many-shards

qa/rgw: remove 1999-shard tests from rgw/verify

Reviewed-by: Ali Maredia <amaredia@redhat.com>
5 years agoMerge pull request #33557 from yuvalif/add_2pc_cls_queue
Casey Bodley [Mon, 30 Mar 2020 13:49:19 +0000 (09:49 -0400)]
Merge pull request #33557 from yuvalif/add_2pc_cls_queue

cls/queue: add 2-phase-commit queue implementation

Reviewed-by: Casey Bodley <cbodley@redhat.com>
5 years agoMerge pull request #33933 from cbodley/wip-rgw-doc-reshard-v2
Casey Bodley [Mon, 30 Mar 2020 13:38:40 +0000 (09:38 -0400)]
Merge pull request #33933 from cbodley/wip-rgw-doc-reshard-v2

doc/rgw: update multisite reshard design for cross-datalog-shard coordination

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
5 years agoMerge PR #34260 into master
Sage Weil [Mon, 30 Mar 2020 13:36:44 +0000 (08:36 -0500)]
Merge PR #34260 into master

* refs/pull/34260/head:
Revert "Merge PR #34091 into master"

Reviewed-by: Sebastian Wagner <swagner@suse.com>
5 years agoMerge PR #34248 into master
Sage Weil [Mon, 30 Mar 2020 13:24:59 +0000 (08:24 -0500)]
Merge PR #34248 into master

* refs/pull/34248/head:
qa/tasks/cephadm: no need to explicitly reconfig
qa/tasks/cephadm: fetch final ceph.conf
qa/tasks/cephadm: distribute ceph.conf and admin keyring to all nodes

Reviewed-by: Sebastian Wagner <swagner@suse.com>
5 years agoMerge PR #34266 into master
Sage Weil [Mon, 30 Mar 2020 13:24:47 +0000 (08:24 -0500)]
Merge PR #34266 into master

* refs/pull/34266/head:
mgr/DaemonServer: fetch metadata for new daemons (e.g., mons)

Reviewed-by: Neha Ojha <nojha@redhat.com>
5 years agomgr/dashboard: Reduce size of component styles 34283/head
Tiago Melo [Sat, 28 Mar 2020 02:44:18 +0000 (01:44 -0100)]
mgr/dashboard: Reduce size of component styles

Fixes: https://tracker.ceph.com/issues/44811
Signed-off-by: Tiago Melo <tmelo@suse.com>
5 years agorgw: replace RGWBucketInfo's sharding-related fields with BucketLayout
Shilpa Jagannath [Fri, 20 Mar 2020 18:16:24 +0000 (23:46 +0530)]
rgw: replace RGWBucketInfo's sharding-related fields with BucketLayout

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>
5 years agorgw: add BucketLayout to RGWBucketInfo
Casey Bodley [Tue, 3 Mar 2020 20:42:54 +0000 (15:42 -0500)]
rgw: add BucketLayout to RGWBucketInfo

Signed-off-by: Casey Bodley <cbodley@redhat.com>
5 years agorgw: use qualified encode/decode in putobj processor
Casey Bodley [Wed, 11 Mar 2020 14:13:57 +0000 (10:13 -0400)]
rgw: use qualified encode/decode in putobj processor

Signed-off-by: Casey Bodley <cbodley@redhat.com>
5 years agoMerge pull request #34279 from votdev/issue_44805
Laura Paduano [Mon, 30 Mar 2020 09:58:26 +0000 (11:58 +0200)]
Merge pull request #34279 from votdev/issue_44805

mgr/dashboard: 'Prometheus / All Alerts' page shows progress bar

Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Sebastian Krah <skrah@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
5 years agomgr/dashboard: 'Prometheus / All Alerts' page shows progress bar 34279/head
Volker Theile [Mon, 30 Mar 2020 08:17:55 +0000 (10:17 +0200)]
mgr/dashboard: 'Prometheus / All Alerts' page shows progress bar

Fixes: https://tracker.ceph.com/issues/44805
Signed-off-by: Volker Theile <vtheile@suse.com>
5 years agoMerge pull request #34276 from badone/wip-fix-argument-ordering-docker-test
Brad Hubbard [Mon, 30 Mar 2020 03:23:36 +0000 (13:23 +1000)]
Merge pull request #34276 from badone/wip-fix-argument-ordering-docker-test

tests: Reinstate "opts" as final argument

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agotests: Reinstate "opts" as final argument 34276/head
Brad Hubbard [Mon, 30 Mar 2020 02:18:49 +0000 (12:18 +1000)]
tests: Reinstate "opts" as final argument

a1e8f61cb72 broke the "opts" argument.

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
5 years agoMerge pull request #34252 from JackSlateur/doc-os-recommendations2
Kefu Chai [Sun, 29 Mar 2020 16:26:59 +0000 (00:26 +0800)]
Merge pull request #34252 from JackSlateur/doc-os-recommendations2

doc/start/os-recommendations.rst: recommend bluestore

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge pull request #34267 from JackSlateur/doc-man-monmaptool
Kefu Chai [Sun, 29 Mar 2020 16:23:47 +0000 (00:23 +0800)]
Merge pull request #34267 from JackSlateur/doc-man-monmaptool

doc/man/8/monmaptool.rst: update synopsis etc with the latest options

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agodoc/man/8/monmaptool.rst: update the page with the latest options 34267/head
Alexandre Bruyelles [Sat, 28 Mar 2020 23:42:47 +0000 (00:42 +0100)]
doc/man/8/monmaptool.rst: update the page with the latest options

Signed-off-by: Alexandre Bruyelles <jack@jack.fr.eu.org>
5 years agoMerge pull request #34224 from markhpc/wip-bluefs-disable-buffered-io
Kefu Chai [Sun, 29 Mar 2020 14:21:05 +0000 (22:21 +0800)]
Merge pull request #34224 from markhpc/wip-bluefs-disable-buffered-io

common/options: Disable bluefs_buffered_io by default again.

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
5 years agoMerge pull request #33052 from ifed01/wip-ifed-fix-unused2
Kefu Chai [Sun, 29 Mar 2020 14:19:23 +0000 (22:19 +0800)]
Merge pull request #33052 from ifed01/wip-ifed-fix-unused2

os/bluestore: fix 'unused' calculation

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
5 years agoMerge pull request #34203 from majianpeng/bluefs-remove-unused-func
Kefu Chai [Sun, 29 Mar 2020 14:18:02 +0000 (22:18 +0800)]
Merge pull request #34203 from majianpeng/bluefs-remove-unused-func

os/bluestore: remove unused func.

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge PR #34061 into master
Sage Weil [Sun, 29 Mar 2020 12:17:37 +0000 (07:17 -0500)]
Merge PR #34061 into master

* refs/pull/34061/head:
mgr/orch: Add `ceph orch ls --export`
mgr/dashboard: adapt to new `ServiceDescription.to_json()`
python-common: add `service_name` to `ServiceSpec.to_json`
python-common: make ServiceSpec and ServiceDescription compatible
src/ceph.in: add yaml to known formats
mgr/orch: add yaml to `orch ls`
mgr/orch: remove `orch spec dump`
python-common: reorder RGWSpec arguments
python-common: prevent ServiceSpec of wrong type
pybind/mgr: tox.ini: omit cov report
mgr/cephadm: test describe_service
mgr/orch: ServiceDescription: change json representation
mgr/orch: ServiceDescription: Make spec a requirement

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Sage Weil <sage@redhat.com>
5 years agoMerge PR #34215 into master
Sage Weil [Sun, 29 Mar 2020 12:16:59 +0000 (07:16 -0500)]
Merge PR #34215 into master

* refs/pull/34215/head:
cephadm: Fix trucated output of `mgr dump`

Reviewed-by: Sage Weil <sage@redhat.com>
5 years agoMerge pull request #34268 from poyea/docs-options-1
Kefu Chai [Sun, 29 Mar 2020 06:24:09 +0000 (14:24 +0800)]
Merge pull request #34268 from poyea/docs-options-1

doc: Fix inconsistency in logging settings

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agodoc: Fix inconsistency in logging settings 34268/head
John Law [Sun, 29 Mar 2020 01:14:45 +0000 (03:14 +0200)]
doc: Fix inconsistency in logging settings

This patch fixes inconsistency in logging settings with options, namely `log_flush_on_exit` and `log_to_stderr`. This patch also adds `log_to_file` to the section.

Signed-off-by: John Law <johnlaw.po@gmail.com>
5 years agomgr/DaemonServer: fetch metadata for new daemons (e.g., mons) 34266/head
Sage Weil [Sat, 28 Mar 2020 21:22:27 +0000 (16:22 -0500)]
mgr/DaemonServer: fetch metadata for new daemons (e.g., mons)

We fetch metadata for mon/osd/mds daemons on startup.  If a new one comes
along *after* we start up, we need to fetch it on demand.  Otherwise,
notably, we will ignore any new mons added to the cluster:

- mon.a starts
- mgr starts, fetchs a's metadata
- mon.b added
- mon.b tries top open mgr connection, and is rejected each time

This can lead to follow-on badness when the mon tries to proxy mgr
commands or do other things.

Fix by fetching metadata on demand, like we already do in the report
path.

Fixes: https://tracker.ceph.com/issues/44798
Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoMerge PR #34062 into master
Sage Weil [Sat, 28 Mar 2020 14:24:55 +0000 (09:24 -0500)]
Merge PR #34062 into master

* refs/pull/34062/head:
cephadm: update check-host() to return all problems

Reviewed-by: Sebastian Wagner <swagner@suse.com>
5 years agoMerge pull request #33943 from xxhdx1985126/wip-crimson-alienstore-bugs
Kefu Chai [Sat, 28 Mar 2020 01:53:43 +0000 (09:53 +0800)]
Merge pull request #33943 from xxhdx1985126/wip-crimson-alienstore-bugs

crimson: fix bugs that come up when osds go through down/up

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agocrimson/osd: fix method's flag handling on CEPH_OSD_OP_CALL. 34259/head
Radoslaw Zarzynski [Sat, 28 Mar 2020 00:32:32 +0000 (01:32 +0100)]
crimson/osd: fix method's flag handling on CEPH_OSD_OP_CALL.

This patch fixes a regression introduced in d8d0ab1a and
makes `ClsHello.BadMethods` green again.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 years agocephadm: Fix trucated output of `mgr dump` 34215/head
Sebastian Wagner [Fri, 27 Mar 2020 22:24:58 +0000 (23:24 +0100)]
cephadm: Fix trucated output of `mgr dump`

In case the process has terminated, we
have to make sure to read till EOF, otherwise
we might skip some bytes.

Fixes: https://tracker.ceph.com/issues/44642
Co-authored-by: Tim Serong <tserong@suse.com>
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agoqa/rgw: remove 1999-shard tests from rgw/verify 34253/head
Casey Bodley [Fri, 27 Mar 2020 21:43:07 +0000 (17:43 -0400)]
qa/rgw: remove 1999-shard tests from rgw/verify

causing test failures because the host runs out of disk space

Signed-off-by: Casey Bodley <cbodley@redhat.com>
5 years agodoc/start/os-recommendations.rst: recommend bluestore 34252/head
Alexandre Bruyelles [Fri, 27 Mar 2020 21:00:13 +0000 (22:00 +0100)]
doc/start/os-recommendations.rst: recommend bluestore

Signed-off-by: Alexandre Bruyelles <jack@jack.fr.eu.org>
5 years agoMerge PR #34247 into master
Sage Weil [Fri, 27 Mar 2020 20:20:17 +0000 (15:20 -0500)]
Merge PR #34247 into master

* refs/pull/34247/head:
mgr/dashboard: do not fail on user creation

Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Sage Weil <sage@redhat.com>
5 years agoMerge pull request #33279 from rishabh-d-dave/fs-move-run_shell-and-related-methods
Gregory Farnum [Fri, 27 Mar 2020 19:59:43 +0000 (12:59 -0700)]
Merge pull request #33279 from rishabh-d-dave/fs-move-run_shell-and-related-methods

qa/cephfs: move run_shell to mount.py and add methods for negative testing

5 years agoMerge pull request #34021 from lxbsz/deleg_XXX
Gregory Farnum [Fri, 27 Mar 2020 19:57:20 +0000 (12:57 -0700)]
Merge pull request #34021 from lxbsz/deleg_XXX

test/libcephfs: retry and wait for caps when setting the RD deleg

5 years agoMerge pull request #33494 from lxbsz/mount
Gregory Farnum [Fri, 27 Mar 2020 19:56:38 +0000 (12:56 -0700)]
Merge pull request #33494 from lxbsz/mount

mount.ceph: stop printing warning message for unrecognized mount options

Reviewed-by: Jeff Layton <jlayton@redhat.com>
5 years agoMerge pull request #33740 from lxbsz/qa_test_timeout_failed
Gregory Farnum [Fri, 27 Mar 2020 19:55:20 +0000 (12:55 -0700)]
Merge pull request #33740 from lxbsz/qa_test_timeout_failed

qa/test_config_session_timeout: fix options conflicting

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Varsha Rao <varao@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
5 years agoMerge pull request #34024 from vshankar/wip-ignore-mgrmap-when-laggy
Gregory Farnum [Fri, 27 Mar 2020 19:29:43 +0000 (12:29 -0700)]
Merge pull request #34024 from vshankar/wip-ignore-mgrmap-when-laggy

mds: do not defer incoming mgrmap when mds is laggy

Reviewed-by: "Yan, Zheng" <zyan@redhat.com>
5 years agoRevert "Merge PR #34091 into master" 34260/head
Sage Weil [Fri, 27 Mar 2020 14:00:25 +0000 (09:00 -0500)]
Revert "Merge PR #34091 into master"

This reverts commit f865f3e0a0f3a646b093b3571ea76713eca1916c, reversing
changes made to 7ef5458e26ec7c0565509a7882fa31fa064eb49d.

Signed-off-by: Sage Weil <sage@redhat.com>