]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
4 years agoMerge pull request #37893 from tchaikov/wip-wunused-variable
Kefu Chai [Fri, 30 Oct 2020 02:24:11 +0000 (10:24 +0800)]
Merge pull request #37893 from tchaikov/wip-wunused-variable

osd/osd_types: mark unused variable [[maybe_unused]]

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge pull request #37864 from trociny/wip-48020
Jason Dillaman [Fri, 30 Oct 2020 00:58:44 +0000 (20:58 -0400)]
Merge pull request #37864 from trociny/wip-48020

mgr/rbd_support: store global schedule without localized prefix

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #37880 from trociny/wip-rbd-finisher-cancel
Jason Dillaman [Fri, 30 Oct 2020 00:58:13 +0000 (20:58 -0400)]
Merge pull request #37880 from trociny/wip-rbd-finisher-cancel

librbd: relax requirements on finisher canceled callback

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #37886 from tchaikov/wip-osd-scheduler-move
Samuel Just [Thu, 29 Oct 2020 17:56:44 +0000 (10:56 -0700)]
Merge pull request #37886 from tchaikov/wip-osd-scheduler-move

osd/scheduler: rely on copy ellision to move return val

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Sridhar Seshasayee <sseshasa@redhat.com>
4 years agoMerge pull request #34866 from nickjanus/issue-45193
Casey Bodley [Thu, 29 Oct 2020 16:00:52 +0000 (12:00 -0400)]
Merge pull request #34866 from nickjanus/issue-45193

rgw-admin: fixes BucketInfo for missing buckets

Reviewed-by: Casey Bodley <cbodley@redhat.com>
4 years agoMerge pull request #37657 from batrick/rgw-lua-fixes
Yuval Lifshitz [Thu, 29 Oct 2020 15:56:46 +0000 (17:56 +0200)]
Merge pull request #37657 from batrick/rgw-lua-fixes

rgw: lua refactor

4 years agoMerge pull request #37884 from dillaman/wip-48032
Mykola Golub [Thu, 29 Oct 2020 13:48:35 +0000 (15:48 +0200)]
Merge pull request #37884 from dillaman/wip-48032

qa/workunits/rbd: fix permission issue when removing mirror peer

Reviewed-by: Mykola Golub <mgolub@suse.com>
4 years agoMerge pull request #37890 from tchaikov/wip-crimson-os-cleanup
Kefu Chai [Thu, 29 Oct 2020 11:59:08 +0000 (19:59 +0800)]
Merge pull request #37890 from tchaikov/wip-crimson-os-cleanup

crimson/os: fix couple issues reported by clang

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
4 years agoMerge pull request #36739 from pritha-srivastava/wip-rgw-sts-expire-session-token
Matt Benjamin [Thu, 29 Oct 2020 11:58:10 +0000 (07:58 -0400)]
Merge pull request #36739 from pritha-srivastava/wip-rgw-sts-expire-session-token

rgw/sts: adding code for "aws:TokenIssueTime" to be used

4 years agoMerge pull request #35612 from pritha-srivastava/wip-sts-role-min-duration
Matt Benjamin [Thu, 29 Oct 2020 11:57:50 +0000 (07:57 -0400)]
Merge pull request #35612 from pritha-srivastava/wip-sts-role-min-duration

rgw/sts: Adding a configurable rgw_sts_min_session_duration

4 years agoosd/scheduler: rely on copy ellision to move return val 37886/head
Kefu Chai [Mon, 26 Oct 2020 04:49:20 +0000 (12:49 +0800)]
osd/scheduler: rely on copy ellision to move return val

C++14 enforces copy ellision in this case.

also silences warning of

src/osd/scheduler/mClockScheduler.cc:122:21: warning: redundant move in return statement [-Wredundant-move]
  122 |     return std::move(ret);
      |            ~~~~~~~~~^~~~~

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoosd/osd_types: mark unused variable [[maybe_unused]] 37893/head
Kefu Chai [Thu, 29 Oct 2020 10:35:24 +0000 (18:35 +0800)]
osd/osd_types: mark unused variable [[maybe_unused]]

silences warning like:

rc/osd/osd_types.h:5482:18: warning: unused variable '_' [-Wunused-variable]
     auto [iter, _] = ref_delta.try_emplace(hoid, 0);
                  ^

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocrimson/os: capture local bindings using capture variable list 37890/head
Kefu Chai [Thu, 29 Oct 2020 08:24:45 +0000 (16:24 +0800)]
crimson/os: capture local bindings using capture variable list

structured binding does not define variables, and the implicit
capture-by-copy `=` does not help in this case, we have to define a
capture with an initializer to create a *variable* enclosed by
the closure explicitly.

this address the error like:

src/crimson/os/seastore/segment_cleaner.cc:315:5: error: reference to local binding 'addr' declared in enclosing lambda expression
                  addr);
                  ^

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocrimson/os: do not move temporay variable
Kefu Chai [Thu, 29 Oct 2020 08:21:06 +0000 (16:21 +0800)]
crimson/os: do not move temporay variable

copy ellision ensures that copy ctor is not called in this case

silences warning like:

mson/os/seastore/lba_manager/btree/lba_btree_node_impl.cc:262:5: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
    std::move(begin()),
    ^

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocrimson/os: do not capture unused variable
Kefu Chai [Thu, 29 Oct 2020 08:20:12 +0000 (16:20 +0800)]
crimson/os: do not capture unused variable

silences warning like:

btree/extentmap_btree_node.h:100:8: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
      [this, ec, len] (auto &extents) {
       ^

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #37887 from tchaikov/wip-seastar
Kefu Chai [Thu, 29 Oct 2020 07:21:41 +0000 (15:21 +0800)]
Merge pull request #37887 from tchaikov/wip-seastar

seastar: pick up changes to colocate libc allocator and seastar alloc…

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
4 years agoseastar: pick up changes to colocate libc allocator and seastar allocator 37887/head
Kefu Chai [Wed, 28 Oct 2020 09:27:00 +0000 (17:27 +0800)]
seastar: pick up changes to colocate libc allocator and seastar allocator

this allows us to use seastar's builtin allocator along with the libc
allocator used by alien threads.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #37777 from chenerqi/fix-modified-dentries-count
Yan, Zheng [Thu, 29 Oct 2020 03:08:10 +0000 (11:08 +0800)]
Merge pull request #37777 from chenerqi/fix-modified-dentries-count

mds: fix count error of modified dentries

4 years agoMerge pull request #37636 from MahatiC/wip-init-ssd
Jason Dillaman [Wed, 28 Oct 2020 23:03:05 +0000 (19:03 -0400)]
Merge pull request #37636 from MahatiC/wip-init-ssd

librbd/cache: init functionality for SSD Cache

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #37680 from orozery/object-dispatch-aligned-crypto
Jason Dillaman [Wed, 28 Oct 2020 23:02:47 +0000 (19:02 -0400)]
Merge pull request #37680 from orozery/object-dispatch-aligned-crypto

librbd: crypto alignment support

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #37871 from cyx1231st/wip-seastore-misc-fixes
Samuel Just [Wed, 28 Oct 2020 20:16:55 +0000 (13:16 -0700)]
Merge pull request #37871 from cyx1231st/wip-seastore-misc-fixes

crimson/seastore: misc fixes in transaction manager

crimson/seastore: misc fixes in transaction manager

4 years agoMerge pull request #37877 from dang/wip-dang-cond-writeback
Daniel Gryniewicz [Wed, 28 Oct 2020 18:27:06 +0000 (14:27 -0400)]
Merge pull request #37877 from dang/wip-dang-cond-writeback

rgw: Fix broken merge in #37774

4 years agoqa/workunits/rbd: fix permission issue when removing mirror peer 37884/head
Jason Dillaman [Wed, 28 Oct 2020 18:06:57 +0000 (14:06 -0400)]
qa/workunits/rbd: fix permission issue when removing mirror peer

Fixes: https://tracker.ceph.com/issues/48032
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
4 years agoRGW - Fix broken merge in #37774 37877/head
Daniel Gryniewicz [Wed, 28 Oct 2020 13:01:06 +0000 (09:01 -0400)]
RGW - Fix broken merge in #37774

I messed up the merge in #37774 and somehow forgot to push a change.
This resulted it the flag being set on the wrong branch.  This fixes
that.

RHBZ#1845501

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
4 years agoMerge pull request #37865 from neha-ojha/wip-mon-fixes
Kefu Chai [Wed, 28 Oct 2020 15:45:38 +0000 (23:45 +0800)]
Merge pull request #37865 from neha-ojha/wip-mon-fixes

qa: miscellaneous mon test fixes

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #36764 from ishanrai05/guide
Lenz Grimmer [Wed, 28 Oct 2020 14:47:32 +0000 (15:47 +0100)]
Merge pull request #36764 from ishanrai05/guide

mgr/dashboard: Style guide to give a the UI an overall look and feel

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Sebastian Krah <skrah@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
4 years agolibrbd: complete with -ECANCELED queued task requests instead of deleting 37880/head
Mykola Golub [Wed, 28 Oct 2020 13:36:09 +0000 (13:36 +0000)]
librbd: complete with -ECANCELED queued task requests instead of deleting

This is cleanup just to make it consistent with other cases.

Signed-off-by: Mykola Golub <mgolub@suse.com>
4 years agolibrbd: relax requirements on finisher canceled callback
Mykola Golub [Wed, 28 Oct 2020 13:13:02 +0000 (13:13 +0000)]
librbd: relax requirements on finisher canceled callback

The finisher timer is started with safe_callbacks = false, and
cancel_event may fail.

When canceling a task it is safe to just ignore the cancel_event
result and proceed, because the returned false value means the
callback is in TaskFinisher::complete already but before
acquiring the lock, so when it eventually acquires the lock it
will just find out the task is already deleted and return.

Signed-off-by: Mykola Golub <mgolub@suse.com>
4 years agomgr/rbd_support: backward compatibility when loading global schedule 37864/head
Mykola Golub [Wed, 28 Oct 2020 09:20:27 +0000 (09:20 +0000)]
mgr/rbd_support: backward compatibility when loading global schedule

Signed-off-by: Mykola Golub <mgolub@suse.com>
4 years agomgr/rbd_support: store global schedule without localized prefix
Mykola Golub [Tue, 27 Oct 2020 18:00:52 +0000 (18:00 +0000)]
mgr/rbd_support: store global schedule without localized prefix

so it is still used after mgr failover

Fixes: https://tracker.ceph.com/issues/48020
Signed-off-by: Mykola Golub <mgolub@suse.com>
4 years agoMerge PR #37808 into master
Jan Fajerski [Wed, 28 Oct 2020 08:21:06 +0000 (09:21 +0100)]
Merge PR #37808 into master

* refs/pull/37808/head:
ceph-volume: consume mount opt in simple activate

Reviewed-by: Jan Fajerski <jfajerski@suse.com>
Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>
4 years agocrimson/os/seastore/transaction_manager: add missing final keyword 37871/head
Yingxin Cheng [Wed, 28 Oct 2020 07:51:03 +0000 (15:51 +0800)]
crimson/os/seastore/transaction_manager: add missing final keyword

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
4 years agocrimson/os/seastore/transaction_manager: use weak transaction when initialize cached...
Yingxin Cheng [Wed, 28 Oct 2020 07:45:20 +0000 (15:45 +0800)]
crimson/os/seastore/transaction_manager: use weak transaction when initialize cached extents

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
4 years agoMerge pull request #37761 from tchaikov/wip-ceph.spec-with-seastar
Kefu Chai [Wed, 28 Oct 2020 06:43:49 +0000 (14:43 +0800)]
Merge pull request #37761 from tchaikov/wip-ceph.spec-with-seastar

ceph.spec.in: install gcc-toolset on RHEL only

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
4 years agolibrbd/cache: init functionality for SSD Cache 37636/head
Mahati Chamarthy [Thu, 8 Oct 2020 10:55:00 +0000 (16:25 +0530)]
librbd/cache: init functionality for SSD Cache

Adds build option and implements init functionality for SSD cache

Signed-off-by: Lisa Li <xiaoyan.li@intel.com>
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@intel.com>
Signed-off-by: Changcheng Liu <changcheng.liu@intel.com>
4 years agomds: fix count error of modified dentries 37777/head
Erqi Chen [Sat, 24 Oct 2020 06:50:49 +0000 (14:50 +0800)]
mds: fix count error of modified dentries

CDir::_omap_commit counts modified dentries, for fragmenting
new dir modified dentries include head and snap items.

Fixes: https://tracker.ceph.com/issues/47981
Signed-off-by: Erqi Chen <chenerqi@gmail.com>
4 years agoMerge pull request #37826 from badone/wip-make-dist-ng-cli-noprompt
Brad Hubbard [Tue, 27 Oct 2020 21:32:41 +0000 (07:32 +1000)]
Merge pull request #37826 from badone/wip-make-dist-ng-cli-noprompt

make-dist: Don't prompt while running 'npm ci'

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
4 years agoqa/tasks/ceph_manager.py: remove redundant quorum status logging 37865/head
Neha Ojha [Tue, 27 Oct 2020 20:55:28 +0000 (20:55 +0000)]
qa/tasks/ceph_manager.py: remove redundant quorum status logging

2020-10-21T03:42:45.985 INFO:teuthology.orchestra.run.smithi114:> sudo adjust-ulimits ceph-coverage /home/ubuntu/cephtest/archive/coverage timeout 120 ceph --cluster ceph quorum_status
2020-10-21T03:42:58.574 INFO:teuthology.orchestra.run.smithi114.stdout:{"election_epoch":1650,"quorum":[0,2],"quorum_names":["a","c"],"quorum_leader_name":"a","quorum_age":0,"features":{"quorum_con":"4540138297136906239","quorum_mon":["kraken","luminous","mimic","osdmap-prune","nautilus","octopus","pacific","elector-pinging"]},"monmap":{"epoch":1,"fsid":"807c36f1-9e85-4fa3-81fc-95915ab50584","modified":"2020-10-21T00:34:48.421341Z","created":"2020-10-21T00:34:48.421341Z","min_mon_release":16,"min_mon_release_name":"pacific","election_strategy":3,"disallowed_leaders":"","features":{"persistent":["kraken","luminous","mimic","osdmap-prune","nautilus","octopus","pacific","elector-pinging"],"optional":[]},"mons":[{"rank":0,"name":"a","public_addrs":{"addrvec":[{"type":"v1","addr":"172.21.15.114:6789","nonce":0}]},"addr":"172.21.15.114:6789/0","public_addr":"172.21.15.114:6789/0","priority":0,"weight":0},{"rank":1,"name":"b","public_addrs":{"addrvec":[{"type":"v1","addr":"172.21.15.133:6789","nonce":0}]},"addr":"172.21.15.133:6789/0","public_addr":"172.21.15.133:6789/0","priority":0,"weight":0},{"rank":2,"name":"c","public_addrs":{"addrvec":[{"type":"v1","addr":"172.21.15.114:6790","nonce":0}]},"addr":"172.21.15.114:6790/0","public_addr":"172.21.15.114:6790/0","priority":0,"weight":0}]}}
2020-10-21T03:42:58.589 INFO:tasks.mon_thrash.ceph_manager:quorum_status is {"election_epoch":1650,"quorum":[0,2],"quorum_names":["a","c"],"quorum_leader_name":"a","quorum_age":0,"features":{"quorum_con":"4540138297136906239","quorum_mon":["kraken","luminous","mimic","osdmap-prune","nautilus","octopus","pacific","elector-pinging"]},"monmap":{"epoch":1,"fsid":"807c36f1-9e85-4fa3-81fc-95915ab50584","modified":"2020-10-21T00:34:48.421341Z","created":"2020-10-21T00:34:48.421341Z","min_mon_release":16,"min_mon_release_name":"pacific","election_strategy":3,"disallowed_leaders":"","features":{"persistent":["kraken","luminous","mimic","osdmap-prune","nautilus","octopus","pacific","elector-pinging"],"optional":[]},"mons":[{"rank":0,"name":"a","public_addrs":{"addrvec":[{"type":"v1","addr":"172.21.15.114:6789","nonce":0}]},"addr":"172.21.15.114:6789/0","public_addr":"172.21.15.114:6789/0","priority":0,"weight":0},{"rank":1,"name":"b","public_addrs":{"addrvec":[{"type":"v1","addr":"172.21.15.133:6789","nonce":0}]},"addr":"172.21.15.133:6789/0","public_addr":"172.21.15.133:6789/0","priority":0,"weight":0},{"rank":2,"name":"c","public_addrs":{"addrvec":[{"type":"v1","addr":"172.21.15.114:6790","nonce":0}]},"addr":"172.21.15.114:6790/0","public_addr":"172.21.15.114:6790/0","priority":0,"weight":0}]}}

Signed-off-by: Neha Ojha <nojha@redhat.com>
4 years agoqa/suites/rados/dashboard: ignore MON_DOWN
Neha Ojha [Tue, 27 Oct 2020 20:44:15 +0000 (20:44 +0000)]
qa/suites/rados/dashboard: ignore MON_DOWN

This warning is expected during:

2020-10-27T16:29:40.549+0000 7fa1f0927700 10 mon.c@2(peon) e1 handle_auth_request haven't formed initial quorum, EBUSY

and is cleared after:

2020-10-27T16:29:42.597+0000 7fe7b3ada700  7 mon.a@1(peon).log v7 update_from_paxos applying incremental log 7 2020-10-27T16:29:42.319274+0000 mon.b (mon.0) 76 : cluster [INF] mon.b is new leader, mons b,a,c in quorum (ranks 0,1,2)
2020-10-27T16:29:42.597+0000 7fe7b3ada700  7 mon.a@1(peon).log v7 update_from_paxos applying incremental log 7 2020-10-27T16:29:42.326711+0000 mon.b (mon.0) 82 : cluster [INF] Health check cleared: MON_DOWN (was: 1/3 mons down, quorum b,a)

Signed-off-by: Neha Ojha <nojha@redhat.com>
4 years agoceph-volume: consume mount opt in simple activate 37808/head
Dimitri Savineau [Mon, 26 Oct 2020 19:12:59 +0000 (15:12 -0400)]
ceph-volume: consume mount opt in simple activate

When running ceph-volume simple activate command on a Filestore OSD
then the data device is mounted without any specific options so the
one from the ceph configuration file are ignored.
When deploying Filestore with the lvm subcommand then everything is
fine because the filestore_activate method uses mount_osd which relies
on the mount options defined in the ceph configuration file (if any).

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1891557
Fixes: https://tracker.ceph.com/issues/48018
Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
4 years agodoc: style guide to give a the UI an overall look and feel 36764/head
Ishan Rai [Tue, 29 Sep 2020 12:19:52 +0000 (12:19 +0000)]
doc: style guide to give a the UI an overall look and feel

fixes: https://tracker.ceph.com/issues/27218

Signed-off-by: Ishan Rai <ishanrai05@gmail.com>
4 years agoMerge pull request #37774 from dang/wip-dang-cond-writeback
Daniel Gryniewicz [Tue, 27 Oct 2020 11:22:50 +0000 (07:22 -0400)]
Merge pull request #37774 from dang/wip-dang-cond-writeback

Don't writeback when inside a readdir callback

4 years agoMerge pull request #37828 from chenerqi/inode_commit_ops
Yan, Zheng [Tue, 27 Oct 2020 07:34:44 +0000 (15:34 +0800)]
Merge pull request #37828 from chenerqi/inode_commit_ops

mds: optimize batch backtrace store

4 years agomds: optimize batch backtrace store 37828/head
Erqi Chen [Tue, 27 Oct 2020 02:14:35 +0000 (10:14 +0800)]
mds: optimize batch backtrace store

Call backtrace stored callback in batch. This avoids taking mds_lock
for each inode.

Signed-off-by: Erqi Chen <chenerqi@gmail.com>
4 years agomake-dist: Don't prompt while running 'npm ci' 37826/head
Brad Hubbard [Tue, 27 Oct 2020 00:37:15 +0000 (10:37 +1000)]
make-dist: Don't prompt while running 'npm ci'

Prompting for input while in the background results in SIGTTOU being
sent and npm hanging forever.

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
4 years agoMerge pull request #37750 from lixiaoy1/fix_partial_1022
Jason Dillaman [Tue, 27 Oct 2020 00:14:53 +0000 (20:14 -0400)]
Merge pull request #37750 from lixiaoy1/fix_partial_1022

librbd/deep_copy: fix issues in deep_copy

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agolibrbd/deep_copy: skip reading data from image cache 37750/head
lixiaoy1 [Thu, 22 Oct 2020 14:44:43 +0000 (10:44 -0400)]
librbd/deep_copy: skip reading data from image cache

Signed-off-by: Li, Xiaoyan <xiaoyan.li@intel.com>
4 years agoMerge pull request #37714 from dillaman/wip-librbd-migration-1
Mykola Golub [Mon, 26 Oct 2020 19:26:17 +0000 (21:26 +0200)]
Merge pull request #37714 from dillaman/wip-librbd-migration-1

librbd: initial set of changes to migration API for instant-restore

Reviewed-by: Mykola Golub <mgolub@suse.com>
4 years agolibrbd/io: ensure ImageDispatchSpec cannot re-use AioCompletion 37714/head
Jason Dillaman [Mon, 26 Oct 2020 12:27:46 +0000 (08:27 -0400)]
librbd/io: ensure ImageDispatchSpec cannot re-use AioCompletion

Prevent re-using the same AioCompletion between multiple
ImageDispatchSpec objects to prevent the possibility of a memory
leak.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
4 years agolibrbd/migration: native format should not issue a new read request
Jason Dillaman [Mon, 26 Oct 2020 12:11:12 +0000 (08:11 -0400)]
librbd/migration: native format should not issue a new read request

Tweak the format interface's 'read' call to just let the existing
read request continue passed the migration layer if the native
format is in use. Otherwise, the provided AioCompletion would need to
be wrapped with another AioCompletion to prevent the original
image dispatch spec from getting lost.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #37683 from adamemerson/wip-fifo-lessnoisy
Adam C. Emerson [Mon, 26 Oct 2020 15:58:41 +0000 (11:58 -0400)]
Merge pull request #37683 from adamemerson/wip-fifo-lessnoisy

rgw: Be less noisy when probing FIFO existence

Reviewed-By: Casey Bodley cbodley@redhat.com
Reviewed-By: J. Eric Ivancich ivancich@redhat.com
4 years agoMerge pull request #37273 from trociny/wip-rbd-nbd-persist
Jason Dillaman [Mon, 26 Oct 2020 11:57:47 +0000 (07:57 -0400)]
Merge pull request #37273 from trociny/wip-rbd-nbd-persist

rbd-nbd: allow to restart daemon without destroying device

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #37769 from rhcs-dashboard/black-border-text
Lenz Grimmer [Mon, 26 Oct 2020 11:57:32 +0000 (12:57 +0100)]
Merge pull request #37769 from rhcs-dashboard/black-border-text

mgr/dashboard: Removing the black border on the text/input field when its clicked

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
4 years agoMerge pull request #37743 from lixiaoy1/fix_1022
Jason Dillaman [Mon, 26 Oct 2020 11:55:42 +0000 (07:55 -0400)]
Merge pull request #37743 from lixiaoy1/fix_1022

librbd/image: remove implicit features when cloning

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #37753 from bk201/wip-47947
Lenz Grimmer [Mon, 26 Oct 2020 10:33:24 +0000 (11:33 +0100)]
Merge pull request #37753 from bk201/wip-47947

mgr/dashboard: fix disable action for MGR modules

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
4 years agoMerge pull request #37006 from clwluvw/monitoring-osd-latency
Lenz Grimmer [Mon, 26 Oct 2020 10:31:45 +0000 (11:31 +0100)]
Merge pull request #37006 from clwluvw/monitoring-osd-latency

monitoring: Use null yaxes min for OSD read latency

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Patrick Seidensal <pnawracay@suse.com>
4 years agoMerge pull request #37568 from s0nea/wip-dashboard-qa-linting
Lenz Grimmer [Mon, 26 Oct 2020 10:27:23 +0000 (11:27 +0100)]
Merge pull request #37568 from s0nea/wip-dashboard-qa-linting

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
4 years agoMerge pull request #37754 from smithfarm/wip-nautilus-rn-typo
Abhishek L [Mon, 26 Oct 2020 09:36:17 +0000 (10:36 +0100)]
Merge pull request #37754 from smithfarm/wip-nautilus-rn-typo

doc/releases/nautilus: fix typo

Reviewed-By: Neha Ojha <nojha@redhat.com>
Reviewed-By: Kefu Chai <kchai@redhat.com>
Reviewed-By: Abhishek Lekshmanan <abhishek@suse.com>
4 years agoMerge PR #37415 into master
Jan Fajerski [Mon, 26 Oct 2020 08:10:05 +0000 (09:10 +0100)]
Merge PR #37415 into master

* refs/pull/37415/head:
pybind/mgr/snap-schedule: fix deactivate

Reviewed-by: Venky Shankar <vshankar@redhat.com>
4 years agoMerge pull request #37758 from batrick/i47951
Kefu Chai [Mon, 26 Oct 2020 06:59:39 +0000 (14:59 +0800)]
Merge pull request #37758 from batrick/i47951

mon/MonMap: fix unconditional failure for init_with_hosts

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Wido den Hollander <wido@42on.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agoMerge pull request #37759 from adamemerson/wip-context4all
Kefu Chai [Mon, 26 Oct 2020 06:41:55 +0000 (14:41 +0800)]
Merge pull request #37759 from adamemerson/wip-context4all

cmake, rgw: always enable Boost.context

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agolibrbd: migration raw format source
Jason Dillaman [Tue, 20 Oct 2020 00:28:55 +0000 (20:28 -0400)]
librbd: migration raw format source

The raw format maps an abstract, fully allocated, raw block device image
to the migration source IO API.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
4 years agolibrbd: migration file stream source
Jason Dillaman [Mon, 19 Oct 2020 22:28:21 +0000 (18:28 -0400)]
librbd: migration file stream source

The file stream helper will translate byte-extent IO read requests
to ASIO file read requests on the specified backing file. This can be
layered with file format helpers to translate image IO extents down
to the backing file.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
4 years agolibrbd: increase debug logging in ImageCtx
Jason Dillaman [Tue, 20 Oct 2020 06:56:58 +0000 (02:56 -0400)]
librbd: increase debug logging in ImageCtx

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
4 years agolibrbd: migration should attempt to open destination image first
Jason Dillaman [Tue, 20 Oct 2020 06:55:36 +0000 (02:55 -0400)]
librbd: migration should attempt to open destination image first

With the exception of the 'prepare' command, always attempt to open
the destination image first. This will better align with the
ability for read-only, non-native images to be used as a source
image.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge PR #37776 into master
Patrick Donnelly [Sun, 25 Oct 2020 23:29:13 +0000 (16:29 -0700)]
Merge PR #37776 into master

* refs/pull/37776/head:
cephfs: Fix variable declartion in capture list in lambda

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #37735 into master
Patrick Donnelly [Sun, 25 Oct 2020 23:27:48 +0000 (16:27 -0700)]
Merge PR #37735 into master

* refs/pull/37735/head:
client: fix inode ll_ref reference count leak

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #37629 into master
Patrick Donnelly [Sun, 25 Oct 2020 23:26:36 +0000 (16:26 -0700)]
Merge PR #37629 into master

* refs/pull/37629/head:
qa/cephfs: add session_timeout option support
qa/cephfs: move the cephfs's opertions setting to create()
qa/cephfs: add 'cephfs:' section support

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #37652 into master
Patrick Donnelly [Sun, 25 Oct 2020 23:25:24 +0000 (16:25 -0700)]
Merge PR #37652 into master

* refs/pull/37652/head:
qa/tasks: tear down the background process before unmounting
qa/tasks: switch to _kill_background() helper to terminate the daemons

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
4 years agolibrbd: crypto alignment support 37680/head
Or Ozeri [Sun, 18 Oct 2020 16:10:13 +0000 (19:10 +0300)]
librbd: crypto alignment support

This commit extents the recently added CryptoObjectDispatch layer to support block ciphers (as opposed to stream ciphers).
In other words, the crypto layer now handles the necessary data alignments before data is passed on to the crypto engine.

Signed-off-by: Or Ozeri <oro@il.ibm.com>
4 years agoMerge pull request #37718 from smithfarm/wip-rn-nautilus
Nathan Cutler [Sat, 24 Oct 2020 20:27:00 +0000 (22:27 +0200)]
Merge pull request #37718 from smithfarm/wip-rn-nautilus

doc/releases: add Nautilus 14.2.12 release notes

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agolibrbd: pass source ImageCtx to migration API helper methods
Jason Dillaman [Tue, 20 Oct 2020 01:44:55 +0000 (21:44 -0400)]
librbd: pass source ImageCtx to migration API helper methods

This will help ensure that the source ImageCtx can be made optional
when migrating from a read-only, non-native image source.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
4 years agolibrbd: new helper API method to retrieving the migration source spec
Jason Dillaman [Fri, 16 Oct 2020 01:07:07 +0000 (21:07 -0400)]
librbd: new helper API method to retrieving the migration source spec

When using advanced, non-legacy migration sources like a remote Ceph
cluster or a flat file, this API will return the JSON-encoded description
of the migration source.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
4 years agolibrbd: helper method for constructing source-spec for legacy migration
Jason Dillaman [Fri, 16 Oct 2020 00:31:02 +0000 (20:31 -0400)]
librbd: helper method for constructing source-spec for legacy migration

The legacy migration source format has explicit pool, namespace, and image
parameters. This helper method will convert it into the JSON format that
will be used for the new-style migration source-spec.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #37755 from rhcs-dashboard/notification-style
Lenz Grimmer [Sat, 24 Oct 2020 17:02:58 +0000 (19:02 +0200)]
Merge pull request #37755 from rhcs-dashboard/notification-style

mgr/dashboard: Adding more style to the notification sidebar

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
4 years agoMerge pull request #37738 from ifed01/wip-ifed-fix-death-tests
Kefu Chai [Sat, 24 Oct 2020 16:17:33 +0000 (00:17 +0800)]
Merge pull request #37738 from ifed01/wip-ifed-fix-death-tests

test/store_test: use 'threadsafe' style for death tests.

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
4 years agoMerge pull request #37765 from tchaikov/wip-mgr-common-cleanup
Kefu Chai [Sat, 24 Oct 2020 16:15:29 +0000 (00:15 +0800)]
Merge pull request #37765 from tchaikov/wip-mgr-common-cleanup

mgr,common: use make_unique<> and fmt::format()

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge pull request #37431 from sseshasa/wip-handle-future-sched-ops
Sridhar Seshasayee [Sat, 24 Oct 2020 07:52:01 +0000 (13:22 +0530)]
Merge pull request #37431 from sseshasa/wip-handle-future-sched-ops

osd: Handle possible future work items returned from mclock scheduler.

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
4 years agocephfs: Fix variable declartion in capture list in lambda 37776/head
Willem Jan Withagen [Fri, 23 Oct 2020 23:41:17 +0000 (01:41 +0200)]
cephfs: Fix variable declartion in capture list in lambda

/home/jenkins/workspace/ceph-master-compile/src/tools/cephfs_mirror/Mirror.cc:529:33: error: 'mirror_action' in capture list does not name a variable
    m_cond.wait(locker, [this, &mirror_action] {return !mirror_action.action_in_progress;});
                                ^
/home/jenkins/workspace/ceph-master-compile/src/tools/cephfs_mirror/Mirror.cc:529:57: error: reference to local binding 'mirror_action' declared in enclosing function 'cephfs::mirror::Mirror::run'
    m_cond.wait(locker, [this, &mirror_action] {return !mirror_action.action_in_progress;});
                                                        ^
/home/jenkins/workspace/ceph-master-compile/src/tools/cephfs_mirror/Mirror.cc:526:27: note: 'mirror_action' declared here
  for (auto &[filesystem, mirror_action] : m_mirror_actions) {
                          ^
/home/jenkins/workspace/ceph-master-compile/src/tools/cephfs_mirror/Mirror.cc:529:26: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
    m_cond.wait(locker, [this, &mirror_action] {return !mirror_action.action_in_progress;});
                         ^~~~
1 warning and 2 errors generated.

Tracker: https://tracker.ceph.com/issues/47973
Fixes: https://github.com/ceph/ceph/pull/37313
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
4 years agomon/MonMap: fix unconditional failure for init_with_hosts 37758/head
Patrick Donnelly [Thu, 22 Oct 2020 17:08:26 +0000 (10:08 -0700)]
mon/MonMap: fix unconditional failure for init_with_hosts

This bug prevents setting mon_host to a DNS name.

Fixes: https://tracker.ceph.com/issues/47951
Fixes: 7a1f02acfe6b5d8a760efd16bb594a0656b39eac
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agotest/mon: add tests for mon_host build by hostname
Patrick Donnelly [Fri, 23 Oct 2020 23:33:23 +0000 (16:33 -0700)]
test/mon: add tests for mon_host build by hostname

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agotest/mon: fix compiler errors in MonMap unittest
Patrick Donnelly [Fri, 23 Oct 2020 23:28:08 +0000 (16:28 -0700)]
test/mon: fix compiler errors in MonMap unittest

The code atrophied. Clean this up.

The tests are disabled because they SIGSEGV during SetUp.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agotest/mon: build MonMap unittest
Patrick Donnelly [Fri, 23 Oct 2020 23:27:39 +0000 (16:27 -0700)]
test/mon: build MonMap unittest

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoDon't writeback when inside a readdir callback 37774/head
Daniel Gryniewicz [Fri, 23 Oct 2020 16:37:20 +0000 (12:37 -0400)]
Don't writeback when inside a readdir callback

The code updates some attributes that may have changed between versions
when doing a lookup.  However, a lookup can be done from within a
readdir callback, which causes a deadlock during the writeback.  Extend
the flag indicating we're in a callback all the way down, so we can
conditionally avoid the write.

Fixes RHBZ#1845501

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
4 years agoMerge pull request #37678 from ideepika/wip-drop-hammer-from-qa
Neha Ojha [Fri, 23 Oct 2020 15:35:02 +0000 (08:35 -0700)]
Merge pull request #37678 from ideepika/wip-drop-hammer-from-qa

qa: drop hammer branch qa tests

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agodpkg: Remove use of no-longer-existing WITH_BOOST_CONTEXT option 37759/head
Adam C. Emerson [Fri, 23 Oct 2020 01:48:21 +0000 (21:48 -0400)]
dpkg: Remove use of no-longer-existing WITH_BOOST_CONTEXT option

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
4 years agorpm: Remove use of no-longer-existing WITH_BOOST_CONTEXT option
Adam C. Emerson [Fri, 23 Oct 2020 01:46:28 +0000 (21:46 -0400)]
rpm: Remove use of no-longer-existing WITH_BOOST_CONTEXT option

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
4 years ago{rgw, cmake}: Remove WITH_BOOST_CONTEXT
Adam C. Emerson [Thu, 22 Oct 2020 18:55:17 +0000 (14:55 -0400)]
{rgw, cmake}: Remove WITH_BOOST_CONTEXT

As Boost.Context now supports s390, there is no longer any need for
the conditional compilation.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
4 years agoMerge pull request #37193 from rhcs-dashboard/log_download
Lenz Grimmer [Fri, 23 Oct 2020 14:47:20 +0000 (16:47 +0200)]
Merge pull request #37193 from rhcs-dashboard/log_download

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
4 years agoMerge pull request #36449 from s0nea/wip-dashboard-osd-flags-indiv
Lenz Grimmer [Fri, 23 Oct 2020 14:45:28 +0000 (16:45 +0200)]
Merge pull request #36449 from s0nea/wip-dashboard-osd-flags-indiv

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
4 years agoMerge pull request #37440 from Devp00l/wip-44433
Lenz Grimmer [Fri, 23 Oct 2020 11:57:51 +0000 (13:57 +0200)]
Merge pull request #37440 from Devp00l/wip-44433

mgr/dashboard: Add clay plugin support

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
4 years agoMerge pull request #37512 from tspmelo/wip-ng-validation
Lenz Grimmer [Fri, 23 Oct 2020 11:29:32 +0000 (13:29 +0200)]
Merge pull request #37512 from tspmelo/wip-ng-validation

mgr/dashboard: Extract ng-bootstrap-form-validation

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
4 years agoMerge pull request #37748 from Rethan/msg_remove_dispatch_strategy
Kefu Chai [Fri, 23 Oct 2020 10:09:20 +0000 (18:09 +0800)]
Merge pull request #37748 from Rethan/msg_remove_dispatch_strategy

msg: move DispatchStrategy into test/

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agomgr/dashboard: Removing the black border on the text/input field when its clicked 37769/head
Nizamudeen A [Fri, 23 Oct 2020 09:16:24 +0000 (14:46 +0530)]
mgr/dashboard: Removing the black border on the text/input field when its clicked

Resolves: https://tracker.ceph.com/issues/47967
Signed-off-by: Nizamudeen A <nia@redhat.com>
4 years agoMerge pull request #37404 from badone/wip-docker-test-allow-persistent-containers
Kefu Chai [Fri, 23 Oct 2020 08:15:35 +0000 (16:15 +0800)]
Merge pull request #37404 from badone/wip-docker-test-allow-persistent-containers

test/docker-test: Allow persistent containers

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agomgr/DaemonHealthMetricCollector: replace boost::format with fmt::format 37765/head
Kefu Chai [Fri, 23 Oct 2020 08:00:55 +0000 (16:00 +0800)]
mgr/DaemonHealthMetricCollector: replace boost::format with fmt::format

the latter is easier to use, and future proof in the sense that {fmt}
was included as a part of C++20 standard

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocommon/Formatter: replace boost::format with fmt::format
Kefu Chai [Fri, 23 Oct 2020 07:59:37 +0000 (15:59 +0800)]
common/Formatter: replace boost::format with fmt::format

the latter is easier to use, and future proof in the sense that {fmt}
was included as a part of C++20 standard

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agomgr: use make_unique<> when appropriate
Kefu Chai [Fri, 23 Oct 2020 07:40:41 +0000 (15:40 +0800)]
mgr: use make_unique<> when appropriate

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoqa/cephfs: add session_timeout option support 37629/head
Xiubo Li [Tue, 20 Oct 2020 05:26:33 +0000 (01:26 -0400)]
qa/cephfs: add session_timeout option support

When the mds revoking the Fwbl caps, the clients need to flush
the dirty data back to the OSDs, but the flush may make the OSDs
to be overloaded and slow, which may take more than 60 seconds to
finish. Then the MDS daemons will report the WRN messages.

For the teuthology test cases, let's just increase the timeout
value to make it work.

Fixes: https://tracker.ceph.com/issues/47565
Signed-off-by: Xiubo Li <xiubli@redhat.com>
4 years agoqa/cephfs: move the cephfs's opertions setting to create()
Xiubo Li [Mon, 12 Oct 2020 02:13:43 +0000 (10:13 +0800)]
qa/cephfs: move the cephfs's opertions setting to create()

Fixes: https://tracker.ceph.com/issues/47565
Signed-off-by: Xiubo Li <xiubli@redhat.com>