Merge pull request #31840 from rosinL/wip-fix-dpdk

msg/async/dpdk: fix compilation errors when WITH_DPDK=on

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #30631 from xxhdx1985126/wip-bluefs-sync-leak-fix

BlueFS: prevent BlueFS::dirty_files from being leaked when syncing metadata

Reviewed-by: Igor Fedotov <ifedotov@suse.com>

Merge PR #31900 into master

* refs/pull/31900/head:
mgr: fix debug typo

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge PR #31442 into master

* refs/pull/31442/head:
kv/RocksDBStore: Add minimum key limit before invoking DeleteRange.

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>

msg/async/dpdk: Porting seastar's init_port_start to fix to resolve compilation errors

Ceph currently uses dpdk19.05, seastar dpdk_device::init_port_start has
been upgraded to DPDK19.05, so porting changes to fix compiler error.

Signed-off-by: Chunsong Feng <fengchunsong@huawei.com>

Merge pull request #31165 from votdev/improve_py_unittests

mgr/dashboard: Refactor Python unittests and controller

Reviewed-by: Ernesto Puertat <epuertat@redhat.com>
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>

Merge pull request #31856 from rzarzynski/wip-crimson-errorator-handle_error

crimson/common/errorator.h: add handle_error() method.

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #31853 from liewegas/fix-rn-typo

PendingReleaseNotes: fix typo

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #31918 from rzarzynski/wip-crimson-errorator-simplify_safe_then

crimson/common/errorator.h: simplify the compound safe_then() variant.

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge PR #31838 into master

* refs/pull/31838/head:
ceph-daemon: chown uid/gid files during `adopt`
ceph-daemon: use 'iglob' instead of 'glob'
ceph-daemon: Fix handling for symlinks on python2

Reviewed-by: Tim Serong <tserong@suse.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>

crimson/common/errorator.h: simplify the compound safe_then() variant.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/common/errorator.h: add handle_error() method.

In contrast to `safe_then` it deals only with errors
and, on return, leaves the value type `future<ValueT>`
embodies unchanged.
While being basically a specialization of `safe_then`,
it's also a convenience method to squeeze boilerplate.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge PR #31914 into master

* refs/pull/31914/head:
mgr/orchestrator: set node labels to empty list if none specified

Reviewed-by: Joshua Schmid <jschmid@suse.de>
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>

mgr/dashboard: support creating OSDs on spare devices (#30921)

mgr/dashboard: support creating OSDs on spare devices

Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>

Merge pull request #31785 from votdev/cleanup_remove_useless_var

mgr/dashboard: Remove unused variable

Reviewed-by: Kiefer Chang kiefer.chang@suse.com
Reviewed-by: Stephan Müller <smueller@suse.com>

Merge pull request #31720 from rhcs-dashboard/fix-42708-master

mgr/dashboard: remove traceback/version assertions

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #31843 from votdev/rename_list_pipe

mgr/dashboard: Rename pipe list -> join

Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>

mgr/orchestrator: set node labels to empty list if none specified

f06366836ff tries to ' '.join(node.labels), which raises an exception
if labels is None, so we need to default it to an empty list.

Signed-off-by: Tim Serong <tserong@suse.com>

Merge pull request #31588 from usefulalgorithm/patch-1

doc/rados/operations: OSD_OUT_OF_ORDER_FULL fullness order is wrong

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge PR #31870 into master

* refs/pull/31870/head:
ceph-daemon: fix `systemctl is-enabled` bool

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>

Merge PR #31886 into master

* refs/pull/31886/head:
ceph-daemon: error out if not root
ceph-daemon: user-friendly exception/error messages
ceph-daemon: user-friendly exception/error messages

Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #31883 from jan--f/ceph-volume-code-owner

github/codeowners: add ceph-volume

Merge PR #31892 into master

* refs/pull/31892/head:
ceph-daemon: seek relative to the start of file

Reviewed-by: Sebastian Wagner <swagner@suse.com>

Merge PR #31899 into master

* refs/pull/31899/head:
mgr: drop session with Ceph daemon when not ready
mgr: improve debug message information

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

ceph-daemon: error out if not root

Signed-off-by: Sage Weil <sage@redhat.com>

ceph-daemon: user-friendly exception/error messages

- Rename `CDError` to `Error`
- Display traceback on console when `-v` is specified
- Other misc clean-up

Signed-off-by: Michael Fritch <mfritch@suse.com>

Merge pull request #30262 from sebastian-philipp/orchestrator-pomise-future

mgr/orchestrator: Make Completions composable

Reviewed-by: Tim Serong <tserong@suse.com>
Reviewed-by: Joshua Schmid <jschmid@suse.de>

mgr/ssh: Disable host labels.

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #31896 from rsevero/missing_virtualenv

doc: add missing virtualenv for build-doc

Reviewed-by: Kefu Chai <kchai@redhat.com>

mgr/orchestrator: use finalize to set TrivialReadCompletion result

This is needed to correctly set the state of the completion, so that
Completion.has_result returns true.  Without this, _orchestrator_wait()
will spin forever if given a TrivialReadCompletion.

Signed-off-by: Tim Serong <tserong@suse.com>
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/orchestrator: add pretty_print()

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/ssh: Fix Promises

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

import typing optionally

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

Fix testing error

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/deepsea: Fixed DeepSeaReadCompletion arguments

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/orchestrator: fix tests

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

make check fixes

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/orchstrator: Removed all type anotations incompatible to Python 2

* Reduce mypy's type checking capability
* Remove useful code documentation

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

doc/orchestrator: Adapted to new Completions

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/orchestrator: add cancel

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

qa/orchestrator: Adapt teuthology test to new completions

Also: Adapt mgr/test_orchestrator to new completions

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/deepsea: Adapt to new orchestrator completions

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/ansible: Adapt to new orchestrator completions

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/ssh: Adapt ssh orch to new Completions interface

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/rook: Adapt to new completions

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/orchestrator: Introduce composable completions

Also:

* unify Read and Write completions
* Distinguish should_wait and is_finished
* Removed `all_hosts` parameter to `osd_create`

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/orchestrator: rename wait() -> process()

Because wait() should actually not wait!

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #31904 from tchaikov/wip-crimson-stop-msgr-after-stopping-osd

crimson: stop osd before stopping messengers

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

mgr/dashboard: Remove unused variable

Signed-off-by: Volker Theile <vtheile@suse.com>

mgr/dashboard: Rename pipe list -> join

Signed-off-by: Volker Theile <vtheile@suse.com>

crimson: stop osd before stopping messengers

so we can drain all pending tasks referencing messenger before
destroying it, otherwise they will be using a already-stopped
messenger when they are still alive.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge PR #31756 into master

* refs/pull/31756/head:
pybind / cephfs: remove static typing in LibCephFS.chown

Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

mgr: fix debug typo

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #31828 into master

* refs/pull/31828/head:
mgr/orchestrator: include container_image in 'service ls' output
ceph-daemon: include container_image_name and container_image_id in 'ls' output
common/options: default to ceph/ceph:latest-master-devel (for now)

Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>

Merge PR #31854 into master

* refs/pull/31854/head:
mgr/orchestrator_cli: print table for 'host ls'
mgr/ssh: populate labels
mgr/orchestrator: add 'labels' property to InventoryNode
mgr/ssh: add/remove labels
mgr/orchestrator: orchestrator host label {add,rm}
mgr/ssh: add explicit host list

Reviewed-by: Sebastian Wagner <swagner@suse.com>

Merge PR #31864 into master

* refs/pull/31864/head:
osd/PeeringState: clear LAGGY and WAIT states on exiting Started

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>

Merge PR #31865 into master

* refs/pull/31865/head:
cls/rbd: improve efficiency of mirror image status queries

Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge PR #31866 into master

* refs/pull/31866/head:
osd/SnapMirror: no need to record purged_snaps every epoch

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

mgr: drop session with Ceph daemon when not ready

If the mgr is waiting on daemon metadata from the mons, it has no
DaemonState associated with the daemon yet. If we try to process this
MgrOpen, the metadata sent by the daemon (like its config) will not be
recorded.

Fixes: https://tracker.ceph.com/issues/43037
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

mgr: improve debug message information

Connection pointer is not helpful.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

doc: missing virtualenv for build-doc

The install deps command recommended by admin/build-doc doesn't install virtualenv which is required by admin/build-doc.

After manually installing virtualenv, admin/build-doc runned without issues.

Signed-off-by: Rodrigo Severo <rodrigo@fabricadeideias.com>

Merge PR #27467 into master

* refs/pull/27467/head:
cephfs-shell: add snapshot management

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Varsha Rao <varao@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #31871 from smithfarm/wip-43021

doc: mention --namespace option in rados manpage

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: David Zafman <dzafman@redhat.com>

ceph-daemon: seek relative to the start of file

python3 only allows seeks relative to the start of a text file

Signed-off-by: Michael Fritch <mfritch@suse.com>

doc: mention --namespace option in rados manpage

Fixes: https://tracker.ceph.com/issues/43021
Signed-off-by: Nathan Cutler <ncutler@suse.com>

ceph-daemon: user-friendly exception/error messages

We don't want tracebacks for most error conditions in ceph-daemon.

Signed-off-by: Sage Weil <sage@redhat.com>

mgr/orchestrator_cli: print table for 'host ls'

Signed-off-by: Sage Weil <sage@redhat.com>

mgr/ssh: populate labels

Signed-off-by: Sage Weil <sage@redhat.com>

mgr/orchestrator: add 'labels' property to InventoryNode

Signed-off-by: Sage Weil <sage@redhat.com>

mgr/ssh: add/remove labels

Signed-off-by: Sage Weil <sage@redhat.com>

mgr/orchestrator: orchestrator host label {add,rm}

Signed-off-by: Sage Weil <sage@redhat.com>

mgr/ssh: add explicit host list

Keep the host list in an explicit 'inventory' key, and provide a dict for
each host so that we can keep other metadata (like labels).

Signed-off-by: Sage Weil <sage@redhat.com>

Merge PR #31837 into master

* refs/pull/31837/head:
ceph-daemon: add additional debug logging

Reviewed-by: Sage Weil <sage@redhat.com>

github/codeowners: add ceph-volume

Signed-off-by: Jan Fajerski <jfajerski@suse.com>

Merge pull request #31874 from tchaikov/wip-crimson-cyanstore-restructure

crimson: move os/cyan_* down to os/cyanstore/*

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

mgr/dashboard: Refactor Python unittests

* Make use of the KVStoreMockMixin class to get rid off duplicate code.
* Fake the index.html file to be able to run tests/test_home.py locally without building the frontend in production mode.
* Encapsulate helper functions in controllers/home.py, otherwise tests/test_feature_toggles.py need to fake the filesystem because load_controllers() will load the home.py controller and fail due missing files in the filesystem.

Signed-off-by: Volker Theile <vtheile@suse.com>

crimson: move os/cyan_* down to os/cyanstore/*

prepare for bluestore and seastore

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #31859 from rzarzynski/wip-crimson-drop_dup_failed

crimson/osd/osd_operation.h: clean up duplicative check.

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #31252 from wjwithagen/wjw-doc-ceph_volume_zfs_inventory

doc/ceph-volume: initial docs for zfs/inventory and zfs/api

Merge pull request #31821 from mgfritch/c-v-scan-help

ceph-volume: minor clean-up of `simple scan` subcommand help

mgr/dashboard: hide search field when selecting OSD devices

Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>

mgr/dashboard: add condition for search field inside table tool header

Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>

mgr/dashboard: add create osd feature in the backend

Fixes: https://tracker.ceph.com/issues/40335
Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>

mgr/dashboard: support creating OSDs on spare devices

On OSD page, a form is added to allow creating OSDs from non-occupied
devices. User can:
- use filters to select some primary devices for OSD.
- use filters to select WAL/DB devices as shared devices if needed.

Note: This feature requires orchestrator support.

Frontend changes:
- Extract inventory devices component from inventory. We need to reuse
it.
- The inventory devices component supports column filters. The available
options for filters are determined by all possible values in a column.
- Add a button on OSD list page to display OSD creation form.
- Add OSD creation form, it allows selecting primary/WAL/DB devices for
OSDs.
- Add a preview modal to preview OSD creation. Currently, the Drive
Group Specification is displayed. This feature will be completed when we
have library to preview OSD creation.

Fixes: https://tracker.ceph.com/issues/40335
Fixes: https://tracker.ceph.com/issues/42076
Fixes: https://tracker.ceph.com/issues/42882
Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>

ceph-daemon: add additional debug logging

Adds additional detail before invoking subprocess for the
`run`, `shell, `enter`, and `logs` commands

Signed-off-by: Michael Fritch <mfritch@suse.com>

ceph-daemon: chown uid/gid files during `adopt`

shutil does not preserve the file owner/group after copy/move

Signed-off-by: Michael Fritch <mfritch@suse.com>

Merge PR #31567 into master

* refs/pull/31567/head:
common: move gen_rand_alphanumeric() helpers into common
test: add unit tests for gen_rand_alphanumeric helpers

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>

Merge PR #31781 into master

* refs/pull/31781/head:
cmake/modules: look for GNU make first instead of BSD make
cmake: support parallel build for rocksdb

Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge PR #31579 into master

* refs/pull/31579/head:
cmake: add cppcheck and iwyu static analysis targets

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>

ceph-daemon: fix `systemctl is-enabled` bool

systemd run-time units were not correctly detected as `enabled`

Signed-off-by: Michael Fritch <mfritch@suse.com>

Merge PR #31775 into master

* refs/pull/31775/head:
mds: remove the incorrect comments

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>

Merge PR #31762 into master

* refs/pull/31762/head:
mgr/ssh: improve logging for mds removal
mgr/volumes: move up 'confirm' validation

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Tim Serong <tserong@suse.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>

ceph-daemon: use 'iglob' instead of 'glob'

Use a glob iterator for instances where the matched pathnames return a
very long list of files.

Signed-off-by: Michael Fritch <mfritch@suse.com>

ceph-daemon: Fix handling for symlinks on python2

Signed-off-by: Michael Fritch <mfritch@suse.com>

osd/SnapMirror: no need to record purged_snaps every epoch

These keys were a mirror of the mon's purged_epoch keys.  We were writing
them, but never looking at them.  We only need the per-pool keys that
are indexed by snapid for lookups, so we should stop storing the per-epoch
records.

Note that the OSDSuperblock has the purged_snaps_last that serves as our
position/cursor for ingesting the mon keys.

Fixes: https://tracker.ceph.com/issues/42012
Signed-off-by: Sage Weil <sage@redhat.com>

cls/rbd: improve efficiency of mirror image status queries

The removal of remote mirror image status records no longer
(accidentally) searches through nearly the full omap database and
getting the status of a single image no longer involves duplicate
lookups (to pull the fsid keys and then to read the data).

Fixes: https://tracker.ceph.com/issues/42576
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #28625 from zhangsw/rgw-fix-get-object

rgw: ignore If-Unmodified-Since if If-Match exists, and ignore If-Modified-Since if If-None-Match exists.

Reviewed-by: Casey Bodley <cbodley@redhat.com>

osd/PeeringState: clear LAGGY and WAIT states on exiting Started

These flags were not getting cleared except in recheck_readable(), which
meant that a flag from a prior interval could bleed into a new interval.
More dangerously, in a mixed-version cluster, one interval might include
all octopus+ OSDs while the next might include a pre-octopus OSD, bypassing
most of the laggy recheck code.  This could lead to a stalled request
and/or requeue ordering bug when release_object_locks() looked at
is_laggy() and put a lock waiter on the waiting_for_readable list.

Fixes: https://tracker.ceph.com/issues/42978
Signed-off-by: Sage Weil <sage@redhat.com>

ceph-volume: minor clean-up of `simple scan` subcommand help

Fixes: https://tracker.ceph.com/issues/43017
Signed-off-by: Michael Fritch <mfritch@suse.com>

Merge PR #31780 into master

* refs/pull/31780/head:
mgr/volumes: remove unsed variable

Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>