Merge pull request #16173 from smithfarm/wip-20156-kraken

kraken: fix: rgw crashed caused by shard id out of range when listing data log

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #16165 from smithfarm/wip-19839-kraken

kraken: rgw: reduce log level of 'storing entry at' in cls_log

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #16163 from smithfarm/wip-19766-kraken

kraken: rgw: when uploading the objects continuesly in the versioned bucket, some objects will not sync

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #16162 from smithfarm/wip-19725-kraken

kraken: rgw: S3 v4 authentication issue with X-Amz-Expires

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #16161 from smithfarm/wip-19614-kraken

kraken: multisite: rest api fails to decode large period on 'period commit'

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #16139 from smithfarm/wip-20147-kraken

kraken: rgw: 'gc list --include-all' command infinite loop the first 1000 items

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #16096 from smithfarm/wip-19336-kraken

kraken: rbd: refuse to use an ec pool that doesn't support overwrites

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #16097 from smithfarm/wip-19609-kraken

kraken: tests: [librados_test_stub] cls_cxx_map_get_XYZ methods don't return correct value

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #16184 from smithfarm/wip-20154-kraken

kraken: rbd: Potential IO hang if image is flattened while read request is in-flight

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #16187 from smithfarm/wip-20266-kraken

kraken: rbd: [api] is_exclusive_lock_owner shouldn't return -EBUSY

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #16195 from dillaman/wip-20351-kraken

kraken: tests: test/librbd: decouple ceph_test_librbd_api from libceph-common

Reviewed-by: Nathan Cutler <ncutler@suse.com>

Merge pull request #15486 from dillaman/wip-20022-kraken

kraken: rbd-mirror: ensure missing images are re-synced when detected

Reviewed-by: Mykola Golub <mgolub@mirantis.com>

Merge pull request #14540 from smithfarm/wip-18910-kraken

kraken: rbd-nbd: check /sys/block/nbdX/size to ensure kernel mapped correctly

Reviewed-by: Mykola Golub <mgolub@mirantis.com>

Merge pull request #16140 from smithfarm/wip-20271-kraken

kraken: tests: LibRadosMiscConnectFailure.ConnectFailure hang

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #16112 from smithfarm/wip-20499-kraken

kraken: tests: ObjectStore/StoreTest.OnodeSizeTracking/2 fails on bluestore

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #14960 from yehudasa/wip-19704

kraken: civetweb: move to post 1.8 version

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #16143 from smithfarm/wip-20365-kraken

kraken: mon: osd crush set crushmap need sanity check

Reviewed-by: Loic Dachary <ldachary@redhat.com>

Merge pull request #16138 from smithfarm/wip-20034-kraken

kraken: ceph-disk: Racing between partition creation & device node creation

Reviewed-by: Loic Dachary <ldachary@redhat.com>

Merge pull request #16135 from smithfarm/wip-20010-kraken

kraken: ceph-disk: separate ceph-osd --check-needs-* logs

Reviewed-by: Loic Dachary <ldachary@redhat.com>

Merge pull request #16215 from liewegas/wip-17743

kraken: CMakeLists.txt: disable memstore make check test

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

CMakeLists.txt: disable memstore make check test

This fails frequently on kraken, but is probably a wontfix.

See http://tracker.ceph.com/issues/17743

Signed-off-by: Sage Weil <sage@redhat.com>

rbd-mirror: ensure missing images are re-synced when detected

Fixes: http://tracker.ceph.com/issues/19811
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 74bd4f230a0cb7b709f2cb5c6db3dc79f0d8dede)

Conflicts:
src/test/rbd_mirror/image_replayer/test_mock_BootstrapRequest.cc: trivial resolution
src/tools/rbd_mirror/image_replayer/BootstrapRequest.h: trivial resolution

Merge pull request #14067 from asheplyakov/19322-bp-kraken

kraken: rgw: fix break inside of yield in RGWFetchAllMetaCR

Reviewed-by: Orit Wasserman <owasserm@redhat.com>

Merge pull request #14509 from smithfarm/wip-18499-kraken

kraken: rgw: Realm set does not create a new period

Reviewed-by: Orit Wasserman <owasserm@redhat.com>

Merge pull request #14511 from smithfarm/wip-18772-kraken

kraken: rgw: crash when updating period with placement group

Reviewed-by: Orit Wasserman <owasserm@redhat.com>

Merge pull request #14513 from smithfarm/wip-18843-kraken

kraken: rgw: usage stats and quota are not operational for multi-tenant users

Reviewed-by: Orit Wasserman <owasserm@redhat.com>

Merge pull request #14515 from smithfarm/wip-18904-kraken

kraken: rgw: first write also tries to read object

Reviewed-by: Orit Wasserman <owasserm@redhat.com>

Merge pull request #14516 from smithfarm/wip-18909-kraken

kraken: rgw: the swift container acl does not support field .ref

Reviewed-by: Orit Wasserman <owasserm@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>

Merge pull request #14517 from smithfarm/wip-19047-kraken

kraken: rgw: fix use of marker in List::list_objects()

Reviewed-by: Orit Wasserman <owasserm@redhat.com>

Merge pull request #14524 from smithfarm/wip-19477-kraken

kraken: rgw: S3 v4 authentication issue with X-Amz-Expires

Reviewed-by: Orit Wasserman <owasserm@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>

Merge pull request #14525 from smithfarm/wip-19479-kraken

kraken: rgw: zonegroupmap set does not work

Reviewed-by: Orit Wasserman <owasserm@redhat.com>

Merge pull request #14528 from smithfarm/wip-19534-kraken

kraken: rgw: Error parsing xml when get bucket lifecycle

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Orit Wasserman <owasserm@redhat.com>

Merge pull request #14606 from asheplyakov/19608-kraken

kraken: rgw: multisite: fetch_remote_obj() gets wrong version when copying from remote

Reviewed-by: Orit Wasserman <owasserm@redhat.com>

Merge pull request #15384 from asheplyakov/20015-bp-kraken

kraken: cls/rgw: list_plain_entries() stops before bi_log entries

Reviewed-by: Orit Wasserman <owasserm@redhat.com>

Merge pull request #14522 from smithfarm/wip-19472-kraken

kraken: rgw: add the remove-x-delete feature to cancel swift object expiration

Reviewed-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>

Merge pull request #14523 from smithfarm/wip-19475-kraken

kraken: rgw: multisite: EPERM when trying to read SLO objects as system/admin user

Reviewed-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>

Merge pull request #14519 from smithfarm/wip-19175-kraken

kraken: swift API: cannot disable object versioning with empty X-Versions-Location

Reviewed-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>

Merge pull request #14526 from smithfarm/wip-19524-kraken

kraken: rgw: 'radosgw-admin zone create' command with specified zone-id creates a zone with different id

Reviewed-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>

Merge pull request #14529 from smithfarm/wip-19573-kraken

kraken: rgw: Response header of swift API returned by radosgw does not contain x-openstack-request-id. But Swift returns it.

Reviewed-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>

test/librbd: decouple ceph_test_librbd_api from libceph-common

Fixes: http://tracker.ceph.com/issues/20175
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit b7287fdc4d70c5ecedda78ae367b98e5d8f61c5b)

Conflicts:
src/test/librbd/CMakeLists.txt: trivial resolution

test/librbd: replace libcommon classes using standard library

so ceph_test_librbd_api has less dependencies on libcommon

Fixes: http://tracker.ceph.com/issues/20175
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit bc8fa0193c8b2fb4b749ce9976bf6efbea833e96)

Conflicts:
src/test/librbd/test_librbd.cc: trivial resolution

test/librados: extract functions using libcommon in test.cc into test_common.cc

Fixes: http://tracker.ceph.com/issues/20175
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 82a848c2053ea69ebc6d3ec1003e18921e2d08d2)

Conflicts:
src/test/librados/CMakeLists.txt: trivial resolution
src/test/librados/test.cc: trivial resolution

librbd: filter expected error codes from is_exclusive_lock_owner

Fixes: http://tracker.ceph.com/issues/20182
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit d4daaf54e6bc42cd4fb2111ea20b2042941b0c31)

rgw: only log metadata on metadata master zone

Fixes: http://tracker.ceph.com/issues/20244
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit b8272f3607074a2f7cbfd08f7bbc82f22cf120ba)

radosgw-admin: warn that 'realm rename' does not update other clusters

Fixes: http://tracker.ceph.com/issues/19746
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 8a459c768ffecd689a53a79dfe33eb8f1bbc318f)

rgw: fix for zonegroup redirect url

local dest_url variable was shadowing the one in the enclosing scope, so
the changes were not applied and no Location header was written on redirect

Fixes: http://tracker.ceph.com/issues/19488
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 542e188a40f0495720b48308372366951ae41e62)

rgw: use zonegroup's master zone endpoints for bucket redirect

if no zonegroup endpoints are set, fall back to master zone endpoints

Fixes: http://tracker.ceph.com/issues/19488
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 92f63c6392bdc4633a2e57cb3867051bb1a3fd55)

rgw: allow larger payload for period commit

testing with 3 zonegroups and 3 zones each, the period json grew larger
than 4k and caused decode failures on period commit

updated to use the new config variable rgw_max_put_param_size

Fixes: http://tracker.ceph.com/issues/19505
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 7f2871fe59d933b03f37fde40f1781b2320d0d50)

rgw: make a configurable size for requests with xml params

We currently read all user input for a few apis accepting xml, avoid
doing this and error out early, most s3 apis limit to about 1000 xml
entries, make this configurable via a new config param,
`rgw_max_put_param_size` defaulting to 1MB. Also modified
`rgw_rest_read_all_input` with an additional param to not allow for
chunked uploads, though we error out in a better way by responding with
content length required rather than S3's 501 if chunked is set.

This also adds the same behavior in RGWPutCORS reusing
`rgw_rest_read_all_input`, and using a data_deleter to manage the char*

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
rgw: rgw_rest_s3: make PUT CORS accept only a configured max input

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
(cherry picked from commit 35375b75160dc93beeb04c7fe010dc0d21952534)

librbd: potential read IO hang when image is flattened

Fixes: http://tracker.ceph.com/issues/19832
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 10d58618e7c632ef01b9537492239e0a042dc17e)

Merge pull request #16113 from smithfarm/wip-19807-kraken

kraken: tests: remove hard-coded image name from TestLibRBD.Mirror

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Mykola Golub <mgolub@mirantis.com>

rgw: segment fault when shard id out of range

Fixes: http://tracker.ceph.com/issues/19732
Signed-off-by: redickwang <redickwang@tencent.com>
(cherry picked from commit ff4c40fc2e3c092d17a218ae6132de4e6034c8ee)

cls/log/cls_log.cc: reduce logging noise

 - The other reference in the source as already at 20.
      ./src/cls/timeindex/cls_timeindex.cc:85:
CLS_LOG(20, "storing entry at %s", index.c_str());

   And we need not always know where in the log items are stored.
   So it looks like a leftover debug feature.

Fixes: http://tracker.ceph.com/issues/19835
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
(cherry picked from commit d76010900bf9012f2e66335787710531772766b7)

rgw: fix versioned bucket data sync fail when upload is busy

Fixes: http://tracker.ceph.com/issues/18208
Signed-off-by: lvshuhua <lvshuhua@cmss.chinamobile.com>
(cherry picked from commit ce7d00ac1642d84c1d9111156a544c37801c5adf)

rgw: don't return skew time in pre-signed url

Fixes: http://tracker.ceph.com/issues/18828
Signed-off-by: liuchang0812 <liuchang0812@gmail.com>
(cherry picked from commit dd8b348f4aad0124e8a4457117bf3f5f76af7bdb)

Merge pull request #16132 from smithfarm/wip-20522-kraken

kraken: FAILED assert(object_contexts.empty()) (live on master only from Jan-Feb 2017, all other instances are different)

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #15962 from asheplyakov/20443-bp-kraken

kraken: osd: unlock sdata_op_ordering_lock with sdata_lock hold to avoid missing wakeup signal

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #15066 from asheplyakov/19916-bp-kraken

kraken: osd: osd/PrimaryLogPG: do not call on_shutdown() if (pg.deleting)

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #14942 from shinobu-x/wip-18293-kraken

kraken: osd: leaked MOSDMap

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #14736 from smithfarm/wip-19326-kraken

kraken: bluestore bdev: flush no-op optimization is racy

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #14732 from smithfarm/wip-19560-kraken

kraken: objecter: full_try behavior not consistent with osd

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #13542 from shinobu-x/wip-18929-kraken

 kraken: osd: bogus assert when checking acting set on recovery completion in rados/upgrade

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #14939 from rzarzynski/wip-rgw-19754-kraken

kraken: rgw: fix RadosGW hang during multi-chunk upload of AWSv4

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>

Merge pull request #14530 from smithfarm/wip-19574-kraken

kraken: rgw: unsafe access in RGWListBucket_ObjStore_SWIFT::send_response()

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #13868 from smithfarm/wip-19160-kraken

kraken: rgw: multisite: RGWMetaSyncShardControlCR gives up on EIO

Reviewed-by: Orit Wasserman <owasserm@redhat.com>

mon: osd crush set crushmap need sanity check

The sanity check verifying the new crushmap does not remove crush rules
that are in use is not exclusive to ceph setcrushmap.

Fixes: http://tracker.ceph.com/issues/19302
Signed-off-by: Loic Dachary <loic@dachary.org>
(cherry picked from commit ed760457bf154c10adf75c6df046eecab7eb8e4b)

ceph_test_rados_api_misc: fix LibRadosMiscConnectFailure.ConnectFailure retry

Fixes: http://tracker.ceph.com/issues/19901
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 087dff80cac707ee9bcb5bcfc98cb3ec047bd49f)

rgw: fix 'gc list --include-all' command infinite loop the first 1000 items

When the items to gc over 1000, 'gc list --include-all' command will infinite loop the first 1000 items.
Add next_marker to move to the next 1000 items.

Fixes: http://tracker.ceph.com/issues/19978
Signed-off-by: fang yuxiang <fang.yuxiang@eisoo.com>
Signed-off-by: Shasha Lu <lu.shasha@eisoo.com>
(cherry picked from commit fc29f52ebca63104a05515484088ff136dfb0b15)

ceph-disk: Adding retry loop in get_partition_dev()

There is very rare cases where get_partition_dev() is called before the actual partition is available in /sys/block/<device>.

It appear that waiting a very short is usually enough to get the partition beein populated.

Analysis:
update_partition() is supposed to be enough to avoid any racing between events sent by parted/sgdisk/partprobe and
the actual creation on the /sys/block/<device>/* entrypoint.
On our CI that race occurs pretty often but trying to reproduce it locally never been possible.

This patch is almost a workaround rather than a fix to the real problem.
It offer retrying after a very short to be make a chance the device to appear.
This approach have been succesful on the CI.

Note his patch is not changing the timing when the device is perfectly created on time and just differ by a 1/5th up to 2 seconds when the bug occurs.

A typical output from the build running on a CI with that code.
command_check_call: Running command: /usr/bin/udevadm settle --timeout=600
get_dm_uuid: get_dm_uuid /dev/sda uuid path is /sys/dev/block/8:0/dm/uuid
get_partition_dev: Try 1/10 : partition 2 for /dev/sda does not in /sys/block/sda
get_partition_dev: Found partition 2 for /dev/sda after 1 tries
        get_dm_uuid: get_dm_uuid /dev/sda uuid path is /sys/dev/block/8:0/dm/uuid
get_dm_uuid: get_dm_uuid /dev/sda2 uuid path is /sys/dev/block/8:2/dm/uuid

fixes: #19428

Signed-off-by: Erwan Velu <erwan@redhat.com>
(cherry picked from commit 93e7b95ed8b4c78daebf7866bb1f0826d7199075)

ceph-disk: Reporting /sys directory in get_partition_dev()

When get_partition_dev() fails, it reports the following message :
    ceph_disk.main.Error: Error: partition 2 for /dev/sdb does not appear to exist
The code search for a directory inside the /sys/block/get_dev_name(os.path.realpath(dev)).

The issue here is the error message doesn't report that path when failing while it might be involved in.

This patch is about reporting where the code was looking at when trying to estimate if the partition was available.

Signed-off-by: Erwan Velu <erwan@redhat.com>
(cherry picked from commit 413c9fcfbe8e6ab33d73b8428090ccacc33c5d15)

ceph-disk: separate ceph-osd --check-needs-* logs

It is using the OSD id zero but have nothing to do with OSD zero and
this is confusing to the user. The log themselves do not need to be kept
around and are stored in the run directory so that they can be disposed
of after reboot.

Fixes: http://tracker.ceph.com/issues/19888
Signed-off-by: Loic Dachary <loic@dachary.org>
(cherry picked from commit c7b3c46bd63b78475868e405bf20d9c142f0336a)

test: added missing IoCtx copy/assignment methods in librados_test_stub

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit c35d307c62961072b4c00f94e37486e3371c1a21)

ReplicatedBackend: don't queue Context outside of ObjectStore with obc

We only flush the ObjectStore callbacks, not everything else.  Thus,
there isn't a guarrantee that the obc held by pull_complete_info will
be cleaned up before the Flush callback is triggered.  Instead, just
defer clearing the pull state until the callback (it'll be cleaned up
during the interval change) and remove the ObjectContext from
pull_complete_info.

Introduced: 68defc2b0561414711d4dd0a76bc5d0f46f8a3f8
Fixes: http://tracker.ceph.com/issues/18927
Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit 51eee55c475a3d931844831e040ed3d66ee59af4)

osd/: don't leak context for Blessed*Context or RecoveryQueueAsync

This has always been a bug, but until
68defc2b0561414711d4dd0a76bc5d0f46f8a3f8, nothing deleted those contexts
without calling complete().

Fixes: http://tracker.ceph.com/issues/18809
Bug shadowed until: 68defc2b0561414711d4dd0a76bc5d0f46f8a3f8
Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit 91b74235027c8a4872dcab6b37767b12c3267061)

Merge pull request #15792 from liewegas/wip-bluestore-leaks-kraken

kraken: os/bluestore: deep decode onode value

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #15729 from asheplyakov/20315-bp-kraken

kraken: mon: fail to form large quorum; msg/async busy loop

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #15084 from asheplyakov/19928-bp-kraken

kraken: mon crash on shutdown, lease_ack_timeout event

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #14735 from smithfarm/wip-19685-kraken

kraken: osd: Give requested scrubs a higher priority

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #14733 from smithfarm/wip-19561-kraken

kraken: api_misc: [  FAILED  ] LibRadosMiscConnectFailure.ConnectFailure

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #13883 from shinobu-x/wip-19119-kraken

kraken: pre-jewel "osd rm" incrementals are misinterpreted

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #14646 from gregsfortytwo/wip-17916-kraken

kraken: osd: pglog: with config, don't assert in the presence of stale diverg…

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #15237 from asheplyakov/20035-bp-kraken

kraken: mon/PGMap: factor mon_osd_full_ratio into MAX AVAIL calc

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #14331 from shinobu-x/wip-19396-kraken

kraken: Objecter::epoch_barrier isn't respected in _op_submit()

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #16083 from smithfarm/wip-18677-kraken

kraken: osd: metadata reports filestore when using bluestore

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #16098 from smithfarm/wip-19621-kraken

kraken: rbd-nbd: add signal handler

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #15612 from smithfarm/wip-19611-kraken

kraken: rbd: Issues with C API image metadata retrieval functions

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Mykola Golub <mgolub@mirantis.com>

Merge pull request #14833 from smithfarm/wip-19794-kraken

kraken: tests: test_notify.py: assert(not image.is_exclusive_lock_owner()) on line 147

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #14543 from smithfarm/wip-19173-kraken

kraken: rbd: rbd_clone_copy_on_read ineffective with exclusive-lock

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #14974 from dillaman/wip-19872-kraken

kraken: rbd-mirror: failover and failback of unmodified image results in split-brain

Reviewed-by: Mykola Golub <mgolub@mirantis.com>

Merge pull request #14934 from dillaman/wip-19833-kraken

kraken: cls_rbd: default initialize snapshot namespace for legacy clients

Reviewed-by: Mykola Golub <mgolub@mirantis.com>

Merge pull request #14539 from smithfarm/wip-18771-kraken

kraken: rbd: Improve compatibility between librbd + krbd for the data pool

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

test: remove hard-coded image name from RBD metadata test

Fixes: http://tracker.ceph.com/issues/19798
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 8f72e745e157cc12d76ca6babe956c5698ee297f)

librbd: relax "is parent mirrored" check when enabling mirroring for pool

If the parent is in the same pool and has the journaling feature enabled
we can assume the mirroring will eventually be enabled for it.

Fixes: http://tracker.ceph.com/issues/19130
Signed-off-by: Mykola Golub <mgolub@mirantis.com>
(cherry picked from commit fe31bca22f90ce02f461d6421a4f66539db888d3)

rbd-mirror: check image mirroring state when bootstrapping

Fixes: http://tracker.ceph.com/issues/18447
Signed-off-by: Mykola Golub <mgolub@mirantis.com>
(cherry picked from commit 5fc5a8ac895524f05eed6e7db20b0dda3a8cb60f)

rbd-mirror: async request to test if image is primary

Signed-off-by: Mykola Golub <mgolub@mirantis.com>
(cherry picked from commit 0a1cb35caacdf85029f31a0364dc07a5d7462f5f)

rbd-mirror: hold owner lock when testing if lock owner

Signed-off-by: Mykola Golub <mgolub@mirantis.com>
(cherry picked from commit 82aa89668d666f434cd19ff444223017b5512c6a)

os/bluestore: fix OnodeSizeTracking testing

[  FAILED  ] 1 test, listed below:
[  FAILED  ] ObjectStore/StoreTest.OnodeSizeTracking/2, where GetParam() = "bluestore"

 1 FAILED TEST

The above test failure happens as the bluestore mount() process
will try to load all collections and put them into the coll_map,
which will be also tracked as mempool::bluestore_meta_other.
So total_bytes from mempool won't be equal to zero.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
(cherry picked from commit 1d97862f716ce24bfe227b192ecc5e1eb3f76757)

librbd: image create validates that pool supports overwrites

Fixes: http://tracker.ceph.com/issues/19081
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit a16beba7843539bef4e5035148253a7b594a5cfd)

Conflicts:
    src/librbd/image/CreateRequest.cc - kraken uses create_rados_ack_callback;
        in master, this has been renamed ceph_rados_callback

os/bluestore/KernelDevice: fix uninit value

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 42db0c70bc7ef595f0925657c043ce081799b2b9)

Conflicts:
    src/os/bluestore/KernelDevice.h
      - flush_lock mutex is still used in kraken, so keep it

os/bluestore/BlueFS: fix flush_bdev placement

We need to flush any new writes on any fsync().  Notably, this includes
the rocksdb log. However, previously _fsync was only doing a bdev flush if
we also had a dirty bluefs journal and called into _sync_and_flush_journal.
If we didn't, we weren't doing a flush() at all, which could lead to
corrupted data.

Fix this by moving the first flush_bdev *out* of _sync_and_flush_log.  (The
second one is there to flush the bluefs journal; the first one was to
ensure prior writes are stable.)  Instead, flush prior writes in all of the
callers prior to calling _sync_and_flush_log.  This includes _fsync (and
fixes the bug by covering the non-journal-flush path) as well as several
other callers.

Fixes: http://tracker.ceph.com/issues/19250
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 2924a96493d8570317e55854a25fc64911ecf151)